Bug 1305732 - part3 : remove redundent properties setting on non-pseudo background node. r=heycam a=RyanVM
authoralwu <alwu@mozilla.com>
Mon, 08 Jul 2019 04:45:01 +0000
changeset 544485 0e4e5645b8223acdab08e9450291b6d512e55c64
parent 544484 bfa35429419f4f8b28adef941b5e67f78ae3fc98
child 544486 cb42f7e76d0fed643773da7644f7bb476266dc26
push id2131
push userffxbld-merge
push dateMon, 26 Aug 2019 18:30:20 +0000
treeherdermozilla-release@b19ffb3ca153 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersheycam, RyanVM
bugs1305732
milestone69.0
Bug 1305732 - part3 : remove redundent properties setting on non-pseudo background node. r=heycam a=RyanVM If the background node is not a pseudo element, these properties would actually be inherited, so we have no need to set them again. Differential Revision: https://phabricator.services.mozilla.com/D36848
dom/media/webvtt/vtt.jsm
--- a/dom/media/webvtt/vtt.jsm
+++ b/dom/media/webvtt/vtt.jsm
@@ -603,18 +603,16 @@ XPCOMUtils.defineLazyPreferenceGetter(th
 
     _applyNonPseudoCueStyles() {
       // If cue div is not a pseudo element, we should set the default css style
       // for it, the reason we need to set these attributes to cueDiv is because
       // if we set background on the root node directly, if would cause filling
       // too large area for the background color as the size of root node won't
       // be adjusted by cue size.
       this.applyStyles({
-        "white-space": "pre-line",
-        "font": this.fontSize + " sans-serif",
         "background-color": "rgba(0, 0, 0, 0.8)",
         "display": "inline",
       }, this.cueDiv);
     }
 
     // spec https://www.w3.org/TR/webvtt1/#applying-css-properties
     _applyDefaultStylesOnRootNode() {
       // The variables writing-mode, top, left, width, and height are calculated