Bug 1429904 - Remove a comment about std::string. r=njn
authorMarkus Stange <mstange@themasta.com>
Wed, 28 Feb 2018 00:30:55 -0500
changeset 461204 0bf304822495a39b50a173fb1f62cc7602bbcab8
parent 461203 b465484b85ab8a071a51d7d4a7129d0437964ac3
child 461205 c072bfec3cd0e6edc11c7b17ea0a73f45487d4e5
push id1683
push usersfraser@mozilla.com
push dateThu, 26 Apr 2018 16:43:40 +0000
treeherdermozilla-release@5af6cb21869d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnjn
bugs1429904
milestone60.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1429904 - Remove a comment about std::string. r=njn nsCString is the idiomatic string class we want to use anyway. There's no need to think about std::string here. MozReview-Commit-ID: 1rjZAyqp13d
tools/profiler/core/ProfileBufferEntry.h
--- a/tools/profiler/core/ProfileBufferEntry.h
+++ b/tools/profiler/core/ProfileBufferEntry.h
@@ -165,18 +165,16 @@ public:
     bool operator==(const JITAddress& aRhs) const
     {
       return mAddress == aRhs.mAddress && mStreamingGen == aRhs.mStreamingGen;
     }
     bool operator!=(const JITAddress& aRhs) const { return !(*this == aRhs); }
   };
 
   struct FrameKey {
-    // This cannot be a std::string, as it is not memmove compatible, which
-    // is used by nsHashTable
     const nsCString mLocation;
     const mozilla::Maybe<unsigned> mLine;
     const mozilla::Maybe<unsigned> mCategory;
     const mozilla::Maybe<JITAddress> mJITAddress;
     const mozilla::Maybe<uint32_t> mJITDepth;
 
     explicit FrameKey(const char* aLocation)
      : mLocation(aLocation)