Backed out 3 changesets (bug 1496220) for browser_e10s_switchbrowser.js and test_findbar.xul failures CLOSED TREE
authorCiure Andrei <aciure@mozilla.com>
Thu, 11 Oct 2018 01:03:27 +0300
changeset 499073 0bd0dc3c8183e67a37fd08617a5b456049bf444b
parent 499072 9a802bdfec41c901a97985088fdfe2867cd41cb0
child 499074 c1b6778df32c18475f06b4433e5ba13cdbc3ce89
push id1864
push userffxbld-merge
push dateMon, 03 Dec 2018 15:51:40 +0000
treeherdermozilla-release@f040763d99ad [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1496220
milestone64.0a1
backs out70505741627fe29e79facb7fab0e3297320f0421
daf7ced3bbccbbf3a17d2bdc3d65d97def353762
abf2e04e30e4bb0b9cb534926e4df492b9fecf0b
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out 3 changesets (bug 1496220) for browser_e10s_switchbrowser.js and test_findbar.xul failures CLOSED TREE Backed out changeset 70505741627f (bug 1496220) Backed out changeset daf7ced3bbcc (bug 1496220) Backed out changeset abf2e04e30e4 (bug 1496220)
devtools/shared/heapsnapshot/tests/mochitest/test_saveHeapSnapshot_e10s_01.html
mobile/android/geckoview/src/androidTest/assets/www/newSession.html
mobile/android/modules/geckoview/GeckoViewNavigation.jsm
toolkit/components/remotebrowserutils/RemoteWebNavigation.js
--- a/devtools/shared/heapsnapshot/tests/mochitest/test_saveHeapSnapshot_e10s_01.html
+++ b/devtools/shared/heapsnapshot/tests/mochitest/test_saveHeapSnapshot_e10s_01.html
@@ -38,18 +38,17 @@ Bug 1201597 - Sanity test that we can ta
     // Kick everything off on load.
     window.onload = function() {
       info("window.onload fired");
       SpecialPowers.addPermission("browser", true, document);
       SpecialPowers.pushPrefEnv({
          "set": [
              ["dom.ipc.browser_frames.oop_by_default", true],
              ["dom.mozBrowserFramesEnabled", true],
-             ["browser.pagethumbnails.capturing_disabled", true],
-             ["network.disable.ipc.security", true],
+             ["browser.pagethumbnails.capturing_disabled", true]
          ]
       }, function() {
         const iframe = document.createElement("iframe");
         SpecialPowers.wrap(iframe).mozbrowser = true;
         iframe.id = "iframe";
         iframe.src = childFrameURL;
 
         iframe.addEventListener("mozbrowserloadend", function() {
--- a/mobile/android/geckoview/src/androidTest/assets/www/newSession.html
+++ b/mobile/android/geckoview/src/androidTest/assets/www/newSession.html
@@ -1,7 +1,7 @@
 <html>
     <head><title>Hello, world!</title></head>
     <body>
         <a id="targetBlankLink" target="_blank" href="newSession_child.html">target="_blank"</a>
-        <a id="noOpenerLink" target="_blank" rel="noopener" href="http://example.com">rel="noopener"</a>
+        <a id="noOpenerLink" target="_blank" rel="noopener" href="newSession_child.html">rel="noopener"</a>
     </body>
 </html>
--- a/mobile/android/modules/geckoview/GeckoViewNavigation.jsm
+++ b/mobile/android/modules/geckoview/GeckoViewNavigation.jsm
@@ -68,35 +68,19 @@ class GeckoViewNavigation extends GeckoV
         if (flags & (1 << 2)) {
           navFlags |= Ci.nsIWebNavigation.LOAD_FLAGS_EXTERNAL;
         }
 
         if (flags & (1 << 3)) {
           navFlags |= Ci.nsIWebNavigation.LOAD_FLAGS_ALLOW_POPUPS;
         }
 
-        let parsedUri;
-        let triggeringPrincipal;
-        try {
-            parsedUri = Services.io.newURI(uri);
-            if (parsedUri.schemeIs("about") || parsedUri.schemeIs("data") ||
-                parsedUri.schemeIs("file") || parsedUri.schemeIs("resource")) {
-              // Only allow privileged loading for certain URIs.
-              triggeringPrincipal = Services.scriptSecurityManager.getSystemPrincipal();
-            }
-        } catch (ignored) {
-        }
-        if (!triggeringPrincipal) {
-          triggeringPrincipal = Services.scriptSecurityManager.createNullPrincipal({});
-        }
-
-        this.browser.loadURI(parsedUri ? parsedUri.spec : uri, {
+        this.browser.loadURI(uri, {
           flags: navFlags,
           referrerURI: referrer,
-          triggeringPrincipal,
         });
         break;
       case "GeckoView:Reload":
         this.browser.reload();
         break;
       case "GeckoView:Stop":
         this.browser.stop();
         break;
--- a/toolkit/components/remotebrowserutils/RemoteWebNavigation.js
+++ b/toolkit/components/remotebrowserutils/RemoteWebNavigation.js
@@ -100,18 +100,19 @@ RemoteWebNavigation.prototype = {
     this._sendMessage("WebNavigation:LoadURI", {
       uri: aURI,
       flags: aLoadFlags,
       referrer: aReferrer ? aReferrer.spec : null,
       referrerPolicy: aReferrerPolicy,
       postData: aPostData ? Utils.serializeInputStream(aPostData) : null,
       headers: aHeaders ? Utils.serializeInputStream(aHeaders) : null,
       baseURI: aBaseURI ? aBaseURI.spec : null,
-      triggeringPrincipal: Utils.serializePrincipal(
-          aTriggeringPrincipal || Services.scriptSecurityManager.createNullPrincipal({})),
+      triggeringPrincipal: aTriggeringPrincipal
+                           ? Utils.serializePrincipal(aTriggeringPrincipal)
+                           : Services.scriptSecurityManager.createNullPrincipal({}),
       requestTime: Services.telemetry.msSystemNow(),
     });
   },
   setOriginAttributesBeforeLoading(aOriginAttributes) {
     this._sendMessage("WebNavigation:SetOriginAttributes", {
       originAttributes: aOriginAttributes,
     });
   },