Bug 1520782 - Convert server tests using chrome documents to use content one. r=yulia
authorAlexandre Poirot <poirot.alex@gmail.com>
Wed, 23 Jan 2019 08:52:54 +0000
changeset 514957 0b8dbea063541103c759b29e9de24ca9bf0aaa5b
parent 514956 624c6d9e882e6f3e2f0a999b804046961ad95a78
child 514958 552b8ad866be42f5e1ca2376026c6539d2bd28d3
push id1953
push userffxbld-merge
push dateMon, 11 Mar 2019 12:10:20 +0000
treeherdermozilla-release@9c35dcbaa899 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersyulia
bugs1520782
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1520782 - Convert server tests using chrome documents to use content one. r=yulia These tests were using chrome URL for no good reason. With the current bug, the pages running in system principal will be debugged with a special setup. Actors will be run with modules loaded in a distinct loader in order to be executed in a distinct compartment, distinct from the shared system principal compartment. That a prerequisite for the Debugger API. It has to run in a distinct compartment than its debuggee. It makes it harder to reach the actual DebuggerServer being used and register actors. So it is easier to switch to a unprivileged test document loaded in the content process. Differential Revision: https://phabricator.services.mozilla.com/D16824
devtools/client/shared/test/browser_dbg_target-scoped-actor-01.js
devtools/client/shared/test/browser_dbg_target-scoped-actor-02.js
--- a/devtools/client/shared/test/browser_dbg_target-scoped-actor-01.js
+++ b/devtools/client/shared/test/browser_dbg_target-scoped-actor-01.js
@@ -5,17 +5,17 @@
 
 "use strict";
 
 /**
  * Check target-scoped actor lifetimes.
  */
 
 const ACTORS_URL = EXAMPLE_URL + "testactors.js";
-const TAB_URL = EXAMPLE_URL + "doc_empty-tab-01.html";
+const TAB_URL = TEST_URI_ROOT + "doc_empty-tab-01.html";
 
 add_task(async function test() {
   const tab = await addTab(TAB_URL);
 
   await registerActorInContentProcess(ACTORS_URL, {
     prefix: "testOne",
     constructor: "TestActor1",
     type: { target: true },
--- a/devtools/client/shared/test/browser_dbg_target-scoped-actor-02.js
+++ b/devtools/client/shared/test/browser_dbg_target-scoped-actor-02.js
@@ -5,17 +5,17 @@
 
 "use strict";
 
 /**
  * Check target-scoped actor lifetimes.
  */
 
 const ACTORS_URL = EXAMPLE_URL + "testactors.js";
-const TAB_URL = EXAMPLE_URL + "doc_empty-tab-01.html";
+const TAB_URL = TEST_URI_ROOT + "doc_empty-tab-01.html";
 
 add_task(async function() {
   const tab = await addTab(TAB_URL);
 
   await registerActorInContentProcess(ACTORS_URL, {
     prefix: "testOne",
     constructor: "TestActor1",
     type: { target: true },