Bug 1519616 - Clear theme preview for themes that don't have previews r=aswan
authorMark Striemer <mstriemer@mozilla.com>
Tue, 15 Jan 2019 21:39:04 +0000
changeset 513977 0aba112c5ad99d2f3b6045ebc85f5035e5d5be99
parent 513976 959450489bcfc84a4c01cbae0e58b2b0455851e8
child 513978 4ee8f7951ed5cb5fe9b4955dae15e1ca9d6be9c6
push id1953
push userffxbld-merge
push dateMon, 11 Mar 2019 12:10:20 +0000
treeherdermozilla-release@9c35dcbaa899 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersaswan
bugs1519616
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1519616 - Clear theme preview for themes that don't have previews r=aswan Differential Revision: https://phabricator.services.mozilla.com/D16594
toolkit/mozapps/extensions/content/extensions.js
--- a/toolkit/mozapps/extensions/content/extensions.js
+++ b/toolkit/mozapps/extensions/content/extensions.js
@@ -2629,23 +2629,22 @@ var gDetailView = {
   onUpdateModeChanged() {
     this.onPropertyChanged(["applyBackgroundUpdates"]);
   },
 
   _updateView(aAddon, aIsRemote, aScrollToPreferences) {
     setSearchLabel(aAddon.type);
 
     // Set the preview image for themes, if available.
+    this.headingImage.src = "";
     if (aAddon.type == "theme") {
       let previewURL = aAddon.screenshots && aAddon.screenshots[0] && aAddon.screenshots[0].url;
       if (previewURL) {
         this.headingImage.src = previewURL;
       }
-    } else {
-      this.headingImage.src = "";
     }
 
     AddonManager.addManagerListener(this);
     this.clearLoading();
 
     this._addon = aAddon;
     gEventManager.registerAddonListener(this, aAddon.id);
     gEventManager.registerInstallListener(this);