Backed out changeset c8e417bfccfb (bug 1509391) for build bustage. CLOSED TREE
authorDorel Luca <dluca@mozilla.com>
Tue, 27 Nov 2018 00:00:46 +0200
changeset 507353 0a2f54a1a5ca4e1a14ed516fe4b7de2bf8d23a05
parent 507352 8d0de38dc4c80f1382ec80ae8ecb2f0788837be0
child 507354 a6eccac5baa2fce29837003e8de53e9f243a7df0
push id1905
push userffxbld-merge
push dateMon, 21 Jan 2019 12:33:13 +0000
treeherdermozilla-release@c2fca1944d8c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1509391
milestone65.0a1
backs outc8e417bfccfbba8bd7917368778939949d1126bd
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset c8e417bfccfb (bug 1509391) for build bustage. CLOSED TREE
tools/lint/eslint/__init__.py
tools/lint/test/files/eslint/good.js
tools/lint/test/files/eslint/subdir/bad.js
tools/lint/test/python.ini
tools/lint/test/test_eslint.py
--- a/tools/lint/eslint/__init__.py
+++ b/tools/lint/eslint/__init__.py
@@ -55,31 +55,27 @@ def lint(paths, config, binary=None, fix
     if not binary:
         binary, _ = find_node_executable()
 
     if not binary:
         print(ESLINT_NOT_FOUND_MESSAGE)
         return 1
 
     extra_args = lintargs.get('extra_args') or []
-    exclude_args = []
-    for path in config.get('exclude', []):
-        exclude_args.extend(['--ignore-pattern', os.path.relpath(path, lintargs['root'])])
-
     cmd_args = [binary,
                 os.path.join(module_path, "node_modules", "eslint", "bin", "eslint.js"),
                 # Enable the HTML plugin.
                 # We can't currently enable this in the global config file
                 # because it has bad interactions with the SublimeText
                 # ESLint plugin (bug 1229874).
                 '--plugin', 'html',
                 # This keeps ext as a single argument.
                 '--ext', '[{}]'.format(','.join(config['extensions'])),
                 '--format', 'json',
-                ] + extra_args + exclude_args + paths
+                ] + extra_args + paths
 
     # eslint requires that --fix be set before the --ext argument.
     if fix:
         cmd_args.insert(2, '--fix')
 
     shell = False
     if os.environ.get('MSYSTEM') in ('MINGW32', 'MINGW64'):
         # The eslint binary needs to be run from a shell with msys
deleted file mode 100644
deleted file mode 100644
--- a/tools/lint/test/files/eslint/subdir/bad.js
+++ /dev/null
@@ -1,2 +0,0 @@
-// Missing semicolon
-let foo = "bar"
--- a/tools/lint/test/python.ini
+++ b/tools/lint/test/python.ini
@@ -1,6 +1,5 @@
 [DEFAULT]
 subsuite=mozlint, os == "linux"
 skip-if = python == 3
 
-[test_eslint.py]
 [test_flake8.py]
deleted file mode 100644
--- a/tools/lint/test/test_eslint.py
+++ /dev/null
@@ -1,15 +0,0 @@
-import mozunit
-
-from conftest import build
-
-LINTER = 'eslint'
-
-
-def test_lint_with_global_exclude(lint, config, paths):
-    config['exclude'] = ['subdir']
-    results = lint(paths(), config=config, root=build.topsrcdir)
-    assert len(results) == 0
-
-
-if __name__ == '__main__':
-    mozunit.main()