Bug 1142852 P1 Fix NS_NewNonOwningRunnableMethodWithArgs() so that it compiles. r=froydnj
authorBen Kelly <ben@wanderview.com>
Mon, 23 Mar 2015 22:28:09 -0400
changeset 265526 07234a94ed48b08fbcfa4fefe0d2dedb01c27c40
parent 265525 fa8fa3aa9ea63588dfad9dcaf70f0ba0a163758f
child 265527 2e9b6048bd0f5f95389eb2c64e88fda7704721e5
push id830
push userraliiev@mozilla.com
push dateFri, 19 Jun 2015 19:24:37 +0000
treeherdermozilla-release@932614382a68 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj
bugs1142852
milestone39.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1142852 P1 Fix NS_NewNonOwningRunnableMethodWithArgs() so that it compiles. r=froydnj
xpcom/glue/nsThreadUtils.h
--- a/xpcom/glue/nsThreadUtils.h
+++ b/xpcom/glue/nsThreadUtils.h
@@ -716,17 +716,17 @@ NS_NewRunnableMethodWithArgs(PtrType&& a
 {
   static_assert(sizeof...(Storages) == sizeof...(Args),
                 "<Storages...> size should be equal to number of arguments");
   return new nsRunnableMethodImpl<Method, true, Storages...>(
       aPtr, aMethod, mozilla::Forward<Args>(aArgs)...);
 }
 
 template<typename... Storages, typename Method, typename PtrType, typename... Args>
-typename nsRunnableMethodTraits<Method, true>::base_type*
+typename nsRunnableMethodTraits<Method, false>::base_type*
 NS_NewNonOwningRunnableMethodWithArgs(PtrType&& aPtr, Method aMethod,
                                       Args&&... aArgs)
 {
   static_assert(sizeof...(Storages) == sizeof...(Args),
                 "<Storages...> size should be equal to number of arguments");
   return new nsRunnableMethodImpl<Method, false, Storages...>(
       aPtr, aMethod, mozilla::Forward<Args>(aArgs)...);
 }