Bug 1162490 - Only set the transparent accentcolor for Dev Edition theme in Windows;r=Gijs
authorBrian Grinstead <bgrinstead@mozilla.com>
Thu, 07 May 2015 11:08:45 -0700
changeset 274309 067e21985d8dbd9f5bda06898806bae5542d69e0
parent 274308 2bda9fb3b5d66a32ba9ed090caa2113a7d9de48e
child 274310 0e5e9c5ac6f360e9606509d88ed863e1332e6e0c
push id863
push userraliiev@mozilla.com
push dateMon, 03 Aug 2015 13:22:43 +0000
treeherdermozilla-release@f6321b14228d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersGijs
bugs1162490
milestone40.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1162490 - Only set the transparent accentcolor for Dev Edition theme in Windows;r=Gijs It is causing the drop shadow to disappear on osx 10.9. Windows is the only platform that uses a transparent background on the tabs, so it's the only one that neesd the accentcolor
browser/components/nsBrowserGlue.js
--- a/browser/components/nsBrowserGlue.js
+++ b/browser/components/nsBrowserGlue.js
@@ -728,17 +728,19 @@ BrowserGlue.prototype = {
 
 #ifndef RELEASE_BUILD
     let themeName = gBrowserBundle.GetStringFromName("deveditionTheme.name");
     let vendorShortName = gBrandBundle.GetStringFromName("vendorShortName");
 
     LightweightThemeManager.addBuiltInTheme({
       id: "firefox-devedition@mozilla.org",
       name: themeName,
+#ifdef XP_WIN
       accentcolor: "transparent",
+#endif
       headerURL: "resource:///chrome/browser/content/browser/defaultthemes/devedition.header.png",
       iconURL: "resource:///chrome/browser/content/browser/defaultthemes/devedition.icon.png",
       author: vendorShortName,
     });
 #endif
 
 #ifdef MOZ_CRASHREPORTER
     TabCrashReporter.init();