Bug 1512054 part 1: Add some needed "Inlines" includes to .cpp files in layout, to address some -Wundefined-inline build warnings in non-unified builds. r=TYLin
authorDaniel Holbert <dholbert@cs.stanford.edu>
Wed, 05 Dec 2018 02:03:04 +0000
changeset 508661 0648f6fb0eeffe0975343ffbc879a95c284e1b78
parent 508660 ad7fce1f1772f64763f2a6006d7a6d645606addc
child 508662 d186ca68a92d11b4d45397a04300e30226628e75
push id1905
push userffxbld-merge
push dateMon, 21 Jan 2019 12:33:13 +0000
treeherdermozilla-release@c2fca1944d8c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersTYLin
bugs1512054
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1512054 part 1: Add some needed "Inlines" includes to .cpp files in layout, to address some -Wundefined-inline build warnings in non-unified builds. r=TYLin I'm also adding the non-"inlines" version of the added "inlines" includes, too, since it's nice to have them included as a pair. (It's not strictly necessary, since in these cases we were already indirectly including the non-"inlines" header, but it seems like a good practice.) This patch fixes build warnings in non-unified builds for the following calls: - The call to IsColumnSpan() in layout/generic/ColumnSetWrapperFrame.cpp - The call to Type() in layout/style/MappedDeclarations.cpp - The call to IsInAnonymousSubtree() in layout/svg/SVGObserverUtils.cpp Differential Revision: https://phabricator.services.mozilla.com/D13743
layout/generic/ColumnSetWrapperFrame.cpp
layout/style/MappedDeclarations.cpp
layout/svg/SVGObserverUtils.cpp
--- a/layout/generic/ColumnSetWrapperFrame.cpp
+++ b/layout/generic/ColumnSetWrapperFrame.cpp
@@ -2,16 +2,18 @@
 /* vim: set ts=8 sts=2 et sw=2 tw=80: */
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at https://mozilla.org/MPL/2.0/. */
 
 #include "ColumnSetWrapperFrame.h"
 
 #include "nsContentUtils.h"
+#include "nsIFrame.h"
+#include "nsIFrameInlines.h"
 
 using namespace mozilla;
 
 nsBlockFrame* NS_NewColumnSetWrapperFrame(nsIPresShell* aPresShell,
                                           ComputedStyle* aStyle,
                                           nsFrameState aStateFlags) {
   ColumnSetWrapperFrame* frame = new (aPresShell) ColumnSetWrapperFrame(aStyle);
 
--- a/layout/style/MappedDeclarations.cpp
+++ b/layout/style/MappedDeclarations.cpp
@@ -2,16 +2,17 @@
 /* vim: set ts=8 sts=2 et sw=2 tw=80: */
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 #include "MappedDeclarations.h"
 
 #include "nsAttrValue.h"
+#include "nsAttrValueInlines.h"
 #include "nsIDocument.h"
 #include "nsPresContext.h"
 
 namespace mozilla {
 
 void MappedDeclarations::SetIdentAtomValue(nsCSSPropertyID aId,
                                            nsAtom* aValue) {
   Servo_DeclarationBlock_SetIdentStringValue(mDecl, aId, aValue);
--- a/layout/svg/SVGObserverUtils.cpp
+++ b/layout/svg/SVGObserverUtils.cpp
@@ -6,16 +6,18 @@
 
 // Main header first:
 #include "SVGObserverUtils.h"
 
 // Keep others in (case-insensitive) order:
 #include "mozilla/dom/CanvasRenderingContext2D.h"
 #include "mozilla/RestyleManager.h"
 #include "nsCSSFrameConstructor.h"
+#include "nsIContent.h"
+#include "nsIContentInlines.h"
 #include "nsISupportsImpl.h"
 #include "nsSVGClipPathFrame.h"
 #include "nsSVGMarkerFrame.h"
 #include "nsSVGPaintServerFrame.h"
 #include "nsSVGFilterFrame.h"
 #include "nsSVGMaskFrame.h"
 #include "nsIReflowCallback.h"
 #include "nsCycleCollectionParticipant.h"