Bug 1275582 - TSan: data race security/nss/lib/freebl/sha_fast.c:176 SHA1_End. r=dkeeler.
authorJulian Seward <jseward@acm.org>
Mon, 30 May 2016 15:25:52 +0200
changeset 340591 062aa1bd5487d268078b031b75335c106ae40480
parent 340590 999676db297b68200d58c0d086e2a21a0b4856df
child 340592 392b592c2fe40d176119896cf87daa81dd38fc85
push id1183
push userraliiev@mozilla.com
push dateMon, 05 Sep 2016 20:01:49 +0000
treeherdermozilla-release@3148731bed45 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdkeeler
bugs1275582
milestone49.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1275582 - TSan: data race security/nss/lib/freebl/sha_fast.c:176 SHA1_End. r=dkeeler.
security/pkix/lib/pkixocsp.cpp
--- a/security/pkix/lib/pkixocsp.cpp
+++ b/security/pkix/lib/pkixocsp.cpp
@@ -760,17 +760,17 @@ CertID(Reader& input, const Context& con
 //                          -- bits] in the responder's certificate)
 static Result
 MatchKeyHash(TrustDomain& trustDomain, Input keyHash,
              const Input subjectPublicKeyInfo, /*out*/ bool& match)
 {
   if (keyHash.GetLength() != SHA1_DIGEST_LENGTH)  {
     return Result::ERROR_OCSP_MALFORMED_RESPONSE;
   }
-  static uint8_t hashBuf[SHA1_DIGEST_LENGTH];
+  uint8_t hashBuf[SHA1_DIGEST_LENGTH];
   Result rv = KeyHash(trustDomain, subjectPublicKeyInfo, hashBuf,
                       sizeof hashBuf);
   if (rv != Success) {
     return rv;
   }
   Input computed(hashBuf);
   match = InputsAreEqual(computed, keyHash);
   return Success;