Bug 1022612. Part 32: Remove nsDisplayItem::SetVisibleRegionOnLayer. r=mattwoodrow
authorRobert O'Callahan <robert@ocallahan.org>
Mon, 23 Jun 2014 16:24:14 +1200
changeset 217078 05fe1de532bc59da02bbf6568599dae6c0bc5978
parent 217077 bc0968c1d061c3f6288872a0f3c305acb99bc300
child 217079 fa2ce158ea056d119a44e3ecfd603e0e96ea7ed0
push id515
push userraliiev@mozilla.com
push dateMon, 06 Oct 2014 12:51:51 +0000
treeherdermozilla-release@267c7a481bef [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmattwoodrow
bugs1022612
milestone33.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1022612. Part 32: Remove nsDisplayItem::SetVisibleRegionOnLayer. r=mattwoodrow It is no longer called because FrameLayerBuilder always sets the visible regions on layers now.
layout/base/nsDisplayList.h
--- a/layout/base/nsDisplayList.h
+++ b/layout/base/nsDisplayList.h
@@ -1362,21 +1362,16 @@ public:
       DisplayItemClip temp = *mClip;
       temp.IntersectWith(aClip);
       SetClip(aBuilder, temp);
     } else {
       SetClip(aBuilder, aClip);
     }
   }
 
-  // If we return false here it means that if this item creates a layer then
-  // ProcessDisplayItems will not set the visible region on the layer. The item
-  // should set the visible region, usually in BuildContainerLayer.
-  virtual bool SetVisibleRegionOnLayer() { return true; }
-
   bool IsInFixedPos() { return mInFixedPos; }
 
 protected:
   friend class nsDisplayList;
 
   nsDisplayItem() { mAbove = nullptr; }
 
   nsIFrame* mFrame;
@@ -2630,22 +2625,16 @@ public:
   {
     NS_ASSERTION(mList.IsEmpty() || !ReferenceFrame() ||
                  !mList.GetBottom()->ReferenceFrame() ||
                  mList.GetBottom()->ReferenceFrame() == ReferenceFrame(),
                  "Children must have same reference frame");
     return &mList;
   }
   virtual nsDisplayList* GetChildren() MOZ_OVERRIDE { return &mList; }
-  /**
-   * All our subclasses BuildLayers call
-   * FrameLayerBuilder::BuildContainerLayerFor, which
-   * sets the visible region of the layer correctly.
-   */
-  virtual bool SetVisibleRegionOnLayer() { return false; }
 
   virtual int32_t ZIndex() const MOZ_OVERRIDE
   {
     return (mOverrideZIndex > 0) ? mOverrideZIndex : nsDisplayItem::ZIndex();
   }
 
   void SetOverrideZIndex(int32_t aZIndex)
   {