Bug 1373614 - shut down Screenshots WebExtension unconditionally on browser shutdown r=kmag a=jcristau
authorIan Bicking <ianb@colorstudy.com>
Thu, 29 Jun 2017 15:04:59 -0700
changeset 414248 04fc201151527b3084222ac209e554c063de1104
parent 414247 e8e60131e908bb4cf7f919a98646ccb548a6c0b9
child 414249 e8e499165b410f75e867977969e17c70dfae5de1
push id1490
push usermtabara@mozilla.com
push dateMon, 31 Jul 2017 14:08:16 +0000
treeherdermozilla-release@70e32e6bf15e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerskmag, jcristau
bugs1373614
milestone55.0
Bug 1373614 - shut down Screenshots WebExtension unconditionally on browser shutdown r=kmag a=jcristau In some tests the startup does not complete by the time shutdown is called; r?kmag MozReview-Commit-ID: CaeSthDg0g0
browser/extensions/screenshots/bootstrap.js
--- a/browser/extensions/screenshots/bootstrap.js
+++ b/browser/extensions/screenshots/bootstrap.js
@@ -76,19 +76,17 @@ function startup(data, reason) { // esli
 }
 
 function shutdown(data, reason) { // eslint-disable-line no-unused-vars
   prefObserver.unregister();
   const webExtension = LegacyExtensionsUtils.getEmbeddedExtensionFor({
     id: ADDON_ID,
     resourceURI: addonResourceURI
   });
-  if (webExtension.started) {
-    stop(webExtension, reason);
-  }
+  stop(webExtension, reason);
 }
 
 function install(data, reason) {} // eslint-disable-line no-unused-vars
 
 function uninstall(data, reason) {} // eslint-disable-line no-unused-vars
 
 function getBoolPref(pref) {
   return prefs.getPrefType(pref) && prefs.getBoolPref(pref);