Bug 1215079 - Inherit from built-in styles on GB. r=margaret a=ritu
authorMichael Comella <michael.l.comella@gmail.com>
Wed, 11 Nov 2015 14:43:21 -0800
changeset 305729 04c3f8a3a7be936f1ed081fd0d76c6b8203623db
parent 305728 0fec17c6d310132e605e5d0d23258c9d4195d10a
child 305730 7aad7dee85151ba464c2a5d5aa9e522bad9287e3
push id1001
push userraliiev@mozilla.com
push dateMon, 18 Jan 2016 19:06:03 +0000
treeherdermozilla-release@8b89261f3ac4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmargaret, ritu
bugs1215079
milestone44.0a2
Bug 1215079 - Inherit from built-in styles on GB. r=margaret a=ritu This patch undoes the previous work from this bug (and the related work in the original Theme.AppCompat bug). v11+ still uses AppCompat. I tested on my Nexus S and everything seems to be working correctly.
mobile/android/base/resources/values/themes.xml
--- a/mobile/android/base/resources/values/themes.xml
+++ b/mobile/android/base/resources/values/themes.xml
@@ -3,24 +3,26 @@
    - License, v. 2.0. If a copy of the MPL was not distributed with this
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 
 <resources>
 
     <!--
         Base application theme. This could be overridden by GeckoBaseTheme
         in other res/values-XXX/themes.xml.
+
+        Bug 1215079: we inherit from android:* on GB but AppCompat in later versions.
+        Inheriting only from the AppCompat style but not extending AppCompat causes the
+        menu to be transparent and we can't correctly override the color on all devices
+        while also extending AppCompat disables the menu entirely due to a framework bug.
+        We're stuck until we always show the overflow menu (bug 1209967).
     -->
-    <style name="GeckoBase" parent="Theme.AppCompat.Light.DarkActionBar">
+    <style name="GeckoBase" parent="android:Theme.NoTitleBar">
         <item name="windowNoTitle">true</item>
         <item name="android:windowContentOverlay">@null</item>
-
-        <!-- AppCompat sets this to transparent by default:
-             http://stackoverflow.com/a/31777488 -->
-        <item name="android:panelBackground">@color/gingerbread_menu_background_color</item>
     </style>
 
     <style name="GeckoDialogBase" parent="@android:style/Theme.Dialog">
         <item name="android:windowNoTitle">true</item>
         <item name="android:windowContentOverlay">@null</item>
     </style>
 
     <style name="GeckoTitleDialogBase" parent="@android:style/Theme.Dialog" />