searching for reviewer(yulia)
95f4b83aed87e9d8638987cf30b40f5ac6cd1821: bug 1534827: remote: fix constants in transitionToLoadFlag; r=yulia
Andreas Tolfsen <ato@sny.no> - Wed, 13 Mar 2019 14:35:57 +0000 - rev 524707
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
bug 1534827: remote: fix constants in transitionToLoadFlag; r=yulia The transitionType is converted into undefined because there is a typo in the constants. These should be "FLAGS" rather than "FLAG". Thanks-to: Mark Banner <standard8@mozilla.com> Differential Revision: https://phabricator.services.mozilla.com/D23315
a710a25b6c5d3274fb80cf22af7fcc50ce306256: bug 1534829: remote: map source code to bug components; r=yulia
Andreas Tolfsen <ato@sny.no> - Wed, 13 Mar 2019 14:03:16 +0000 - rev 524706
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
bug 1534829: remote: map source code to bug components; r=yulia DevTools :: Remote Agent was removed in favour of a new product, Remote Protocol. This corrects the file metadata mapping for the agent. The patch also adds mapping for new domains. Not all of the components exist yet, but this is tracked separately in https://bugzilla.mozilla.org/show_bug.cgi?id=1534970. Differential Revision: https://phabricator.services.mozilla.com/D23306
ce4157f3f9673dc0b82f38c94b32a8c27adadbe8: Bug 1533938 - Fix regression from refactor of connect.js page. r=yulia
Logan Smyth <loganfsmyth@gmail.com> - Mon, 11 Mar 2019 10:04:22 +0000 - rev 524428
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1533938 - Fix regression from refactor of connect.js page. r=yulia Looks like this regressed in a patch for bug 1520774. Differential Revision: https://phabricator.services.mozilla.com/D22811
fb3cbe9457a98eddda6488517d6a70ce3ab64a16: Bug 1457109 - Open links in the next tab, in background if Ctrl/Cmd is pressed; r=yulia.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Tue, 05 Mar 2019 14:10:19 +0000 - rev 523424
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1457109 - Open links in the next tab, in background if Ctrl/Cmd is pressed; r=yulia. This patch passes the relevant options to the `openDocLink` function, which means now links: - will open right next to the current tab - will open in background if Ctrl/Cmd is pressed. A test case is added to ensures this works as expected. Differential Revision: https://phabricator.services.mozilla.com/D22075
6f356dac426598f80c6ab9d6b4bf983ac8a7f4a1: Bug 1529497 - Remove `promise` and `defer` usage in `devtools/shared/DevToolsUtils.js`; r=yulia.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 27 Feb 2019 13:28:16 +0000 - rev 522317
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529497 - Remove `promise` and `defer` usage in `devtools/shared/DevToolsUtils.js`; r=yulia. The `yieldingEach` is moved into the only file that is using it, in canvas debugger, and is not migrated as the panel will be removed in a few months. Differential Revision: https://phabricator.services.mozilla.com/D20641
c916eda98b1bb33d1f3aa1a7b92d69eb708a884d: Bug 1524628 - Fix a race condition in a devtools style editor test. r=ntim,yulia,miker.
Jason Orendorff <jorendorff@mozilla.com> - Mon, 04 Feb 2019 08:38:04 +0000 - rev 521366
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1524628 - Fix a race condition in a devtools style editor test. r=ntim,yulia,miker. Differential Revision: https://phabricator.services.mozilla.com/D18476
e6a874b75c0bd45b9d782b9edde3bb30c0134d14: Bug 1527830 - Remove unused _filterPrefsPrefix in browser-console.js; r=yulia.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 14 Feb 2019 11:01:36 +0000 - rev 519904
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1527830 - Remove unused _filterPrefsPrefix in browser-console.js; r=yulia. This property isn't used anymore, let's delete it. Differential Revision: https://phabricator.services.mozilla.com/D19749
a42ea7bbd5835457630ea50f4d82779163adfed0: Bug 1520774 - Remove TargetFactory.forWorker. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 06 Feb 2019 12:45:31 +0000 - rev 518507
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1520774 - Remove TargetFactory.forWorker. r=yulia Depends on D18539 Differential Revision: https://phabricator.services.mozilla.com/D18540
023ecfc5cf46837719be435324942c5c1532b7a8: Bug 1520774 - Remove TargetFactory.forRemoteTab. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 06 Feb 2019 16:17:15 +0000 - rev 518506
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1520774 - Remove TargetFactory.forRemoteTab. r=yulia Differential Revision: https://phabricator.services.mozilla.com/D18539
aff30c79fa91fa4b444cc76f1d9e2a4ac487b6af: Bug 1465635 - Remove Target.activeTab property. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Sat, 02 Feb 2019 11:24:24 +0000 - rev 517431
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1465635 - Remove Target.activeTab property. r=yulia Depends on D15831 Differential Revision: https://phabricator.services.mozilla.com/D16874
1dfe4f2eb472d1dd9251297f9476e786c2cd751a: Bug 1465635 - Merge all target fronts with Target class. r=yulia,jdescottes
Alexandre Poirot <poirot.alex@gmail.com> - Sat, 02 Feb 2019 11:24:32 +0000 - rev 517430
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1465635 - Merge all target fronts with Target class. r=yulia,jdescottes This patch makes it so that all target fronts inherits from a Target class mixin. We are using a mixin as fronts should inherit from a custom Front class, which is augmented with its own RDP request and events defined in its spec. (This is done via FrontClassWithSpec(spec)) Depends on D15830 Differential Revision: https://phabricator.services.mozilla.com/D15831
fead89ec2d1bb342ed1feb0616ec241411baed8a: Bug 1465635 - Use Target.title to fetch target's title instead of using its form. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Sat, 02 Feb 2019 11:24:39 +0000 - rev 517429
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1465635 - Use Target.title to fetch target's title instead of using its form. r=yulia Depends on D15828 Differential Revision: https://phabricator.services.mozilla.com/D15830
e6efb1191ec609df0fa28c0594efbafb3e84eb98: Bug 1465635 - Always consider that Target.activeTab is set. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Sat, 02 Feb 2019 11:24:41 +0000 - rev 517428
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1465635 - Always consider that Target.activeTab is set. r=yulia Depends on D15826 Differential Revision: https://phabricator.services.mozilla.com/D15828
9c7fe2ba8434594aa5d49149e74ffba6d21303e2: Bug 1465635 - Convert canvas front instantiation to Target.getFront. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Sat, 02 Feb 2019 11:24:49 +0000 - rev 517427
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1465635 - Convert canvas front instantiation to Target.getFront. r=yulia Depends on D15825 Differential Revision: https://phabricator.services.mozilla.com/D15826
2fe3a0ae216beb2ef4ebbb5e02019d41845c4f4a: Bug 1465635 - Convert browser_two_tabs.js to async. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Sat, 02 Feb 2019 11:24:56 +0000 - rev 517426
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1465635 - Convert browser_two_tabs.js to async. r=yulia Differential Revision: https://phabricator.services.mozilla.com/D15825
11413ebfbcaf5118b933329de3cfb960daaad8ea: Bug 1465635 - Remove Target.activeTab property. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 30 Jan 2019 13:28:25 +0000 - rev 516963
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1465635 - Remove Target.activeTab property. r=yulia Depends on D15831 Differential Revision: https://phabricator.services.mozilla.com/D16874
52728b761d5dd0cc0c73da16b27dd99a7cbb8e22: Bug 1465635 - Merge all target fronts with Target class. r=yulia,jdescottes
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 30 Jan 2019 13:28:23 +0000 - rev 516962
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1465635 - Merge all target fronts with Target class. r=yulia,jdescottes This patch makes it so that all target fronts inherits from a Target class mixin. We are using a mixin as fronts should inherit from a custom Front class, which is augmented with its own RDP request and events defined in its spec. (This is done via FrontClassWithSpec(spec)) Depends on D15830 Differential Revision: https://phabricator.services.mozilla.com/D15831
734646bf982960999cd89f49e84280677f3a0f07: Bug 1465635 - Use Target.title to fetch target's title instead of using its form. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 30 Jan 2019 13:28:15 +0000 - rev 516961
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1465635 - Use Target.title to fetch target's title instead of using its form. r=yulia Depends on D15828 Differential Revision: https://phabricator.services.mozilla.com/D15830
d9ae7cd34c1a66de8a6426e0dc1a3b772d3738f1: Bug 1465635 - Always consider that Target.activeTab is set. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 30 Jan 2019 13:28:13 +0000 - rev 516960
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1465635 - Always consider that Target.activeTab is set. r=yulia Depends on D15826 Differential Revision: https://phabricator.services.mozilla.com/D15828
00d325ab677ae8ac7b7261e5b9600f9bc7f11581: Bug 1465635 - Convert canvas front instantiation to Target.getFront. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 30 Jan 2019 13:28:11 +0000 - rev 516959
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1465635 - Convert canvas front instantiation to Target.getFront. r=yulia Depends on D15825 Differential Revision: https://phabricator.services.mozilla.com/D15826
a9b181f32189d2dadec53a391e0169a6222952fb: Bug 1465635 - Convert browser_two_tabs.js to async. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 30 Jan 2019 13:28:09 +0000 - rev 516958
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1465635 - Convert browser_two_tabs.js to async. r=yulia Differential Revision: https://phabricator.services.mozilla.com/D15825
820e7e98a4f7beee52772f1ef6b3de38b920927b: Bug 1515290 - Instantiate DebuggerServer in dedicated loader when debugging chrome tabs. r=yulia,jdescottes
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 30 Jan 2019 08:04:50 +0000 - rev 516916
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1515290 - Instantiate DebuggerServer in dedicated loader when debugging chrome tabs. r=yulia,jdescottes When debugging contexts running from the system compartment, the debugger has to be loaded in a dedicated Loader, with invisibleToDebugger flag turned on. This ensures that the Debugger API is going to be used from a distinct system compartment. Otherwise it may be used from the same compartment than the page we are debugging. Differential Revision: https://phabricator.services.mozilla.com/D14957
0b8dbea063541103c759b29e9de24ca9bf0aaa5b: Bug 1520782 - Convert server tests using chrome documents to use content one. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 23 Jan 2019 08:52:54 +0000 - rev 514957
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1520782 - Convert server tests using chrome documents to use content one. r=yulia These tests were using chrome URL for no good reason. With the current bug, the pages running in system principal will be debugged with a special setup. Actors will be run with modules loaded in a distinct loader in order to be executed in a distinct compartment, distinct from the shared system principal compartment. That a prerequisite for the Debugger API. It has to run in a distinct compartment than its debuggee. It makes it harder to reach the actual DebuggerServer being used and register actors. So it is easier to switch to a unprivileged test document loaded in the content process. Differential Revision: https://phabricator.services.mozilla.com/D16824
11325875967aeff353c93e6cfc38fc614ce211b1: Bug 1520772 - Construct the WebExtension target front before instantiating the Target object. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 21 Jan 2019 11:04:31 +0000 - rev 514699
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1520772 - Construct the WebExtension target front before instantiating the Target object. r=yulia Differential Revision: https://phabricator.services.mozilla.com/D15829
909b904600e079bc0fe2867956f2d067f1f9ec48: Bug 1520773 - Prevent infinite loops in DebuggerClient.close. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 21 Jan 2019 11:04:08 +0000 - rev 514698
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1520773 - Prevent infinite loops in DebuggerClient.close. r=yulia If any callback fired by DebuggerClient.close ends up calling close again, it will introduce an infinite loop. Depends on D15826 Differential Revision: https://phabricator.services.mozilla.com/D15827
e62e0dfddefe6a582c72c52071742bbc9f3865b0: Bug 1497264 - Split addon/webextension.js into webextension.js and webextension-proxy.js;r=ochameau,yulia
Julian Descottes <jdescottes@mozilla.com> - Tue, 08 Jan 2019 18:18:14 +0000 - rev 512943
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1497264 - Split addon/webextension.js into webextension.js and webextension-proxy.js;r=ochameau,yulia Depends on D15384 Differential Revision: https://phabricator.services.mozilla.com/D15385
033f84c32bce3df3cd0ffd487673463c09bda3cf: Bug 1497264 - Remove references to AddonTargetActor setAddonOptions;r=ochameau,yulia
Julian Descottes <jdescottes@mozilla.com> - Tue, 08 Jan 2019 18:42:44 +0000 - rev 512942
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1497264 - Remove references to AddonTargetActor setAddonOptions;r=ochameau,yulia Depends on D15383 Differential Revision: https://phabricator.services.mozilla.com/D15384
a894d406f4ae900c0dc0f199cfee12082a389def: Bug 1497264 - Remove AddonTargetActor and AddonConsoleActor;r=ochameau,yulia
Julian Descottes <jdescottes@mozilla.com> - Tue, 08 Jan 2019 18:17:17 +0000 - rev 512941
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1497264 - Remove AddonTargetActor and AddonConsoleActor;r=ochameau,yulia This should be rather safe. We can do more refactoring and renaming once LegacyExtension support is fully removed (ie Fx 65 hits release) Differential Revision: https://phabricator.services.mozilla.com/D15383
1399a4ceda2e2f43d1db23aae19d52d8720a4a8d: Bug 1514817 - Convert Target to ES Class. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 07 Jan 2019 11:57:51 +0000 - rev 512684
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1514817 - Convert Target to ES Class. r=yulia Differential Revision: https://phabricator.services.mozilla.com/D14842
f5faf952c6d24e59b821018887e355f9af526bf0: Bug 1512154 - Convert protocol.js to es classes. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 02 Jan 2019 13:38:54 +0000 - rev 512411
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1512154 - Convert protocol.js to es classes. r=yulia Differential Revision: https://phabricator.services.mozilla.com/D14840
3d30fc6ff7c4c6b007b554ef8c185b6a81ef117e: Bug 1513565 - Remove now-unused form argument from Target. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 18 Dec 2018 23:36:06 +0000 - rev 511267
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1513565 - Remove now-unused form argument from Target. r=yulia Depends on D14280 Differential Revision: https://phabricator.services.mozilla.com/D14765
835e98747541301ba1beb317a6ea3fcd7dd0b310: Bug 1513565 - Convert the last manually instantiated fronts to target.getFront. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 18 Dec 2018 23:35:59 +0000 - rev 511266
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1513565 - Convert the last manually instantiated fronts to target.getFront. r=yulia Depends on D14279 Differential Revision: https://phabricator.services.mozilla.com/D14280
69c7978b620c3a89b068bcfef8cd69c5c5ada60d: Bug 1513565 - Get rid of all target.form usages. r=yulia,nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 18 Dec 2018 23:35:57 +0000 - rev 511265
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1513565 - Get rid of all target.form usages. r=yulia,nchevobbe Depends on D14278 Differential Revision: https://phabricator.services.mozilla.com/D14279
af4a0603c641b9235f94af26106557b5538b38a4: Bug 1513565 - Always use Target's WebConsoleClient instead of trying to instantiate it manually. r=yulia,nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 18 Dec 2018 23:35:55 +0000 - rev 511264
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1513565 - Always use Target's WebConsoleClient instead of trying to instantiate it manually. r=yulia,nchevobbe This will help getting rid of another usage of Target.form. And also helps instantiating only one WebConsole client. Once WebConsole becomes a front, we can replace all the target.activeTab to target.getFront("console"). Differential Revision: https://phabricator.services.mozilla.com/D14278
e633fd3fbd905d1cbbcd35ed5b888bcfe4e89e7f: Bug 1514819 - Convert RootFront.getWindow to return a front instead of a form. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 18 Dec 2018 08:54:01 +0000 - rev 511263
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1514819 - Convert RootFront.getWindow to return a front instead of a form. r=yulia This method is only used by target-from-url, it allows to return a target got one precise top level window and instead of the whole main process. It looks like it was the very last non-front/still-form target codepath. Differential Revision: https://phabricator.services.mozilla.com/D14841
651250445f44db2ac52ca8bf65874491298e8144: Bug 1508285 - Refactor RootFront.listTabs to return BrowsingContextTargetFront instead of JSON form. r=yulia,jdescottes
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 17 Dec 2018 11:56:30 +0000 - rev 510897
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1508285 - Refactor RootFront.listTabs to return BrowsingContextTargetFront instead of JSON form. r=yulia,jdescottes MozReview-Commit-ID: 4CMHJ3tV7Rc Depends on D14174 Differential Revision: https://phabricator.services.mozilla.com/D14175
c4b0f1c1f723aea535b0e07feca1cd0810e791f4: Bug 1508285 - Use RootFront.rootForm instead of listTabs to fetch global actors. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 17 Dec 2018 11:56:28 +0000 - rev 510896
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1508285 - Use RootFront.rootForm instead of listTabs to fetch global actors. r=yulia MozReview-Commit-ID: Ed5SyZbB0kq Depends on D14173 Differential Revision: https://phabricator.services.mozilla.com/D14174
433551bcded4cd57938867322fde5488951a7d83: Bug 1508285 - Refactor RootFront.getTab to return BrowsingContextTargetFront instead of JSON form. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 17 Dec 2018 11:56:26 +0000 - rev 510895
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1508285 - Refactor RootFront.getTab to return BrowsingContextTargetFront instead of JSON form. r=yulia MozReview-Commit-ID: 6TOInM5BmYe Differential Revision: https://phabricator.services.mozilla.com/D14173
265e45e19268cc732255cb731e2d44d1fff6aec2: Bug 1513888 - Remove evaluateJSAsync trait; r=yulia.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 13 Dec 2018 15:45:40 +0000 - rev 510395
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1513888 - Remove evaluateJSAsync trait; r=yulia. The trait was added in 37 to handle older server, but given how old it is now, I think it's safe to remove it. Differential Revision: https://phabricator.services.mozilla.com/D14424
943836f5e52865b4c4a39c127cdc274265d0bd72: Bug 1512220 - Convert debugger server test helper to async functions. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 11 Dec 2018 12:14:59 +0000 - rev 510207
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1512220 - Convert debugger server test helper to async functions. r=yulia This cleanup will help next refactorings. Note that attachTestThread and attachTestTabAndResume are still using the callback style as it is still being used by tests that aren't using threadClientTest helper. MozReview-Commit-ID: 6FvoDtzEBmL Depends on D13901 Differential Revision: https://phabricator.services.mozilla.com/D13902
9367d35f4dab2c99cf14cdbfe7f5fd6e07c5e4f8: Bug 1512220 - Refactor debugger test using testGlobal to threadClientTest helper. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 11 Dec 2018 15:19:43 +0000 - rev 510206
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1512220 - Refactor debugger test using testGlobal to threadClientTest helper. r=yulia This isn't removing listTabs calls as these tests were using attachTestTab, but all these tests are using testGlobal helper whereas they don't have to if they were using threadClientTest helper. MozReview-Commit-ID: FPtYlDvYUeD Depends on D13900 Differential Revision: https://phabricator.services.mozilla.com/D13901
67fb7c7594fcf301bbae0a664d7453a436408617: Bug 1512220 - Refactor promises tests to use the same test helper than memory actor's tests. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 11 Dec 2018 15:58:13 +0000 - rev 510205
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1512220 - Refactor promises tests to use the same test helper than memory actor's tests. r=yulia This isn't thread client test, but here we could share some more code with the memory tests and use Target objects to retrieve the fronts. MozReview-Commit-ID: C9S1VjTLrSF Depends on D13899 Differential Revision: https://phabricator.services.mozilla.com/D13900
434525362f73aec285ee22315fe5e6c87e27f04f: Bug 1512220 - Switch devtools/server/tests/unit/test_setBreakpoint* tests to threadClientTest. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 11 Dec 2018 17:46:10 +0000 - rev 510204
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1512220 - Switch devtools/server/tests/unit/test_setBreakpoint* tests to threadClientTest. r=yulia All these tests are clearly copy pasting existing threadClientTest helper. They might run as well against workers but today we don't run them there, so I used the doNotRunWorker flag. MozReview-Commit-ID: 7k1lJ06WeGZ Differential Revision: https://phabricator.services.mozilla.com/D13899
286004dae904045761d7163ac6130ddd3057dc60: Bug 1510949 - Make protocol.js support es6 classes for fronts. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 11 Dec 2018 16:32:41 +0000 - rev 509933
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1510949 - Make protocol.js support es6 classes for fronts. r=yulia MozReview-Commit-ID: JegR2JsyNrI Differential Revision: https://phabricator.services.mozilla.com/D13780
8ff997a8219776be4d5d7a0af8689bd993d6fd99: Bug 1502128 - Migrate promises actor tests to server tests. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 11 Dec 2018 14:15:54 +0000 - rev 509930
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1502128 - Migrate promises actor tests to server tests. r=yulia MozReview-Commit-ID: JobfpedA88C Differential Revision: https://phabricator.services.mozilla.com/D13823
5e887c4ebd791fc491977bdc0ee8fc787f46b33a: Bug 1509315 - Make the console test helper use getTab instead of listTabs. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 27 Nov 2018 21:48:12 +0000 - rev 507609
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1509315 - Make the console test helper use getTab instead of listTabs. r=yulia Ideally, it would use TargetFactory. But as that's mochitest chrome, we don't have natural access to gBrowser/firefox tab. MozReview-Commit-ID: 4nrfFZu6jAU Depends on D12734 Differential Revision: https://phabricator.services.mozilla.com/D12735
30bc5b0c60ebfe0444530fa9af86c5c8d5498ecd: Bug 1509315 - Refactor console attachConsole test helpers to async. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 27 Nov 2018 21:48:05 +0000 - rev 507608
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1509315 - Refactor console attachConsole test helpers to async. r=yulia MozReview-Commit-ID: 2jIm73AiIPN Depends on D12733 Differential Revision: https://phabricator.services.mozilla.com/D12734
3eadd3d0580012f95a9d8e8ac24befb60d93b3fd: Bug 1509315 - Remove unecessary calls to listTabs. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 27 Nov 2018 21:48:03 +0000 - rev 507607
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1509315 - Remove unecessary calls to listTabs. r=yulia These tests are calling listTabs, but that is no longer necessary thanks to rootForm being automatically managed within RootFront. MozReview-Commit-ID: AmC6dTIJjiY Depends on D12732 Differential Revision: https://phabricator.services.mozilla.com/D12733
322f2dd202990fc3bc215a7296423ca683738244: Bug 1509315 - Remove leftover from debugger head.js file. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 27 Nov 2018 21:48:01 +0000 - rev 507606
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1509315 - Remove leftover from debugger head.js file. r=yulia I also removed the get root form leftover. MozReview-Commit-ID: DxPwG9a5YAG Depends on D12731 Differential Revision: https://phabricator.services.mozilla.com/D12732
18f76c41550516fb1cf4bcbe8bfaf82d480322e7: Bug 1509315 - Use TargetFactory.forTab for creating targets in tests. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 27 Nov 2018 21:47:59 +0000 - rev 507605
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1509315 - Use TargetFactory.forTab for creating targets in tests. r=yulia There is 4 patterns here: * Tests using attachThreadActorForUrl like event-listeners ones. I augmented this helper method to call TargetFactory. * Tests using attachTargetActorForUrl like debugger-statement, dbg-navigation and target-scoped-actor. Uses TargetFactory directly. * Tests using connectDebuggerClient like navigateEvents and spaw_actor_in_parent. Uses TargetFactory directly. * All the others, where creating DebuggerClient on their own, and calling listTabs+attachTarget. They now use TargetFactory directly. A note about webconsole-helpers, only consoleClient attribute was used from tests using this helper. Also, in various tests I remove the call to client.destroy, that's because shared-head will close all the tabs/toolboxes and it should lead to target/client destruction. Finally, debugger-statement now request the thread actor via the client instead of manual request, it should help the refactoring to a front! MozReview-Commit-ID: 2ah4UmSjuoi Depends on D12730 Differential Revision: https://phabricator.services.mozilla.com/D12731