searching for reviewer(yulia)
ad7c14c9e73463633f196f156586ee0e703c83c9: Bug 1797166 - Don't assume an exception is always set if module compilation fails r=yulia, a=dmeehan
Jon Coppeard <jcoppeard@mozilla.com> - Mon, 31 Oct 2022 14:26:48 +0000 - rev 714558
Push 2983 by ffxbld-merge at Mon, 07 Nov 2022 15:51:05 +0000
Bug 1797166 - Don't assume an exception is always set if module compilation fails r=yulia, a=dmeehan It would be nice to assume this but CompileFetchedModule can potentially fail for reasons that are not JS-related. Also check for the exception being |undefined| which would cause ModuleScript::HasParseError to return false. Such an exception should never be thrown by parsing but check for it just in case. Add a diagnostic assert to check module script state is as we expect to hopefully catch related problems sooner. Differential Revision: https://phabricator.services.mozilla.com/D160788
d3d8cfbb60df61bcbe40889198a2b847a21fff96: Bug 1712762 - Check if module load requests have already been cancelled in ModuleLoaderBase::CancelDynamicImport r=yulia
Jon Coppeard <jcoppeard@mozilla.com> - Wed, 12 Oct 2022 16:26:20 +0000 - rev 714050
Push 2983 by ffxbld-merge at Mon, 07 Nov 2022 15:51:05 +0000
Bug 1712762 - Check if module load requests have already been cancelled in ModuleLoaderBase::CancelDynamicImport r=yulia I don't know whether this is the problem, but if we try and cancel a request that has already been cancelled it would produce this crash. Differential Revision: https://phabricator.services.mozilla.com/D159167
36d3f80544ecd2e0e0a9765dbe7f512b967674a2: Bug 1778289 - Part 12: Update spec links as the PR is merged. r=jonco,yulia
Yoshi Cheng-Hao Huang <allstars.chh@gmail.com> - Fri, 07 Oct 2022 13:56:27 +0000 - rev 713613
Push 2983 by ffxbld-merge at Mon, 07 Nov 2022 15:51:05 +0000
Bug 1778289 - Part 12: Update spec links as the PR is merged. r=jonco,yulia The PR has been merged. See https://html.spec.whatwg.org/multipage/webappapis.html#import-maps Differential Revision: https://phabricator.services.mozilla.com/D158828
4a1dc47859968786f0edfadd4bed7959074aadc4: Bug 1778289 - Part 11: Update comments for ResolveModuleSpecifier. r=jonco,yulia
Yoshi Cheng-Hao Huang <allstars.chh@gmail.com> - Fri, 07 Oct 2022 13:56:27 +0000 - rev 713612
Push 2983 by ffxbld-merge at Mon, 07 Nov 2022 15:51:05 +0000
Bug 1778289 - Part 11: Update comments for ResolveModuleSpecifier. r=jonco,yulia According to the spec, the method should throw a TypeError if it fails to resolve the specifier. Here we add some comments to explain why we return a result code instead of throwing an error. Differential Revision: https://phabricator.services.mozilla.com/D153331
fcd66d7f491709afe49e890f64e73a42e48a09dc: Bug 1778289 - Part 10: Update comments for 'register an import map'. r=jonco,yulia
Yoshi Cheng-Hao Huang <allstars.chh@gmail.com> - Fri, 07 Oct 2022 13:56:26 +0000 - rev 713611
Push 2983 by ffxbld-merge at Mon, 07 Nov 2022 15:51:05 +0000
Bug 1778289 - Part 10: Update comments for 'register an import map'. r=jonco,yulia Differential Revision: https://phabricator.services.mozilla.com/D152877
b17fa8f361f1fe10e62fd0f261d91711edda5586: Bug 1778289 - Part 9: Bail out early if adding an import map is disallowed. r=jonco,yulia
Yoshi Cheng-Hao Huang <allstars.chh@gmail.com> - Fri, 07 Oct 2022 13:56:26 +0000 - rev 713610
Push 2983 by ffxbld-merge at Mon, 07 Nov 2022 15:51:05 +0000
Bug 1778289 - Part 9: Bail out early if adding an import map is disallowed. r=jonco,yulia If an adding import map is disallowed, we bail out early to prevent creating a ScriptLoadRequest. Differential Revision: https://phabricator.services.mozilla.com/D152876
69c1c66dd5286d063c282a824ca324ab2dc0eaee: Bug 1778289 : Part 8: Update spec for prepare-script when type="importmap". r=jonco,yulia
Yoshi Cheng-Hao Huang <allstars.chh@gmail.com> - Fri, 07 Oct 2022 13:56:25 +0000 - rev 713609
Push 2983 by ffxbld-merge at Mon, 07 Nov 2022 15:51:05 +0000
Bug 1778289 : Part 8: Update spec for prepare-script when type="importmap". r=jonco,yulia Differential Revision: https://phabricator.services.mozilla.com/D152875
03257f7c2f055fe0ee0faffc65b51b9f9d8ada4b: Bug 1778289 - Part 7: Update spec in ImportMaps.cpp/h. r=jonco,yulia
Yoshi Cheng-Hao Huang <allstars.chh@gmail.com> - Fri, 07 Oct 2022 13:56:25 +0000 - rev 713608
Push 2983 by ffxbld-merge at Mon, 07 Nov 2022 15:51:05 +0000
Bug 1778289 - Part 7: Update spec in ImportMaps.cpp/h. r=jonco,yulia Differential Revision: https://phabricator.services.mozilla.com/D152874
3e1a89dcc16c433e089e67cc93605d3cd89a7d34: Bug 1778289 - Part 6: Update comments for external import maps. r=jonco,yulia
Yoshi Cheng-Hao Huang <allstars.chh@gmail.com> - Fri, 07 Oct 2022 13:56:25 +0000 - rev 713607
Push 2983 by ffxbld-merge at Mon, 07 Nov 2022 15:51:05 +0000
Bug 1778289 - Part 6: Update comments for external import maps. r=jonco,yulia Differential Revision: https://phabricator.services.mozilla.com/D152873
6489cf84de36a3a66d04cc12fda494cf11326c6b: Bug 1778289 - Part 5: Update spec in RegisterImportMap. r=jonco,yulia
Yoshi Cheng-Hao Huang <allstars.chh@gmail.com> - Fri, 07 Oct 2022 13:56:24 +0000 - rev 713606
Push 2983 by ffxbld-merge at Mon, 07 Nov 2022 15:51:05 +0000
Bug 1778289 - Part 5: Update spec in RegisterImportMap. r=jonco,yulia Differential Revision: https://phabricator.services.mozilla.com/D152872
829f0f41f7fc460f711d4c5fbbd79afea0e3e750: Bug 1778289 - Part 4: Don't call onerror if parsing import maps fails. r=jonco,yulia
Yoshi Cheng-Hao Huang <allstars.chh@gmail.com> - Fri, 07 Oct 2022 13:56:24 +0000 - rev 713605
Push 2983 by ffxbld-merge at Mon, 07 Nov 2022 15:51:05 +0000
Bug 1778289 - Part 4: Don't call onerror if parsing import maps fails. r=jonco,yulia script's result will be an import map parse result, which will never be null. See explanation from https://github.com/WICG/import-maps/issues/279 Differential Revision: https://phabricator.services.mozilla.com/D152871
3e2e1fbc651a8d0d1f7fbaa3e87d8fa7d14301b2: Bug 1778289 - Part 3: Update spec links in ModuleLoaderBase::ParseImportMap. r=jonco,yulia
Yoshi Cheng-Hao Huang <allstars.chh@gmail.com> - Fri, 07 Oct 2022 13:56:23 +0000 - rev 713604
Push 2983 by ffxbld-merge at Mon, 07 Nov 2022 15:51:05 +0000
Bug 1778289 - Part 3: Update spec links in ModuleLoaderBase::ParseImportMap. r=jonco,yulia Differential Revision: https://phabricator.services.mozilla.com/D152870
b68b8f0d608ce95848145726feee0e19722a3f3e: Bug 1778289 - Part 2: Rename to 'import maps allowed' and add 'disallow import maps'. r=jonco,yulia
Yoshi Cheng-Hao Huang <allstars.chh@gmail.com> - Fri, 07 Oct 2022 13:56:23 +0000 - rev 713603
Push 2983 by ffxbld-merge at Mon, 07 Nov 2022 15:51:05 +0000
Bug 1778289 - Part 2: Rename to 'import maps allowed' and add 'disallow import maps'. r=jonco,yulia Rename 'acquiring import maps' to 'import maps allowed'. Old: https://wicg.github.io/import-maps/#document-acquiring-import-maps New: https://whatpr.org/html/8075/webappapis.html#import-maps-allowed And add 'disallow further import maps': https://whatpr.org/html/8075/webappapis.html#disallow-further-import-maps Differential Revision: https://phabricator.services.mozilla.com/D152869
88647780854af2cc477fd68bd04e8c6986e401a7: Bug 1778289 - Part 1: Rename 'parse a URL-Like import specifier' to 'resolve a URL-Like module specifier'. r=jonco,yulia
Yoshi Cheng-Hao Huang <allstars.chh@gmail.com> - Fri, 07 Oct 2022 13:56:23 +0000 - rev 713602
Push 2983 by ffxbld-merge at Mon, 07 Nov 2022 15:51:05 +0000
Bug 1778289 - Part 1: Rename 'parse a URL-Like import specifier' to 'resolve a URL-Like module specifier'. r=jonco,yulia The old function name is "parse a URL-like import specifier". https://wicg.github.io/import-maps/#parse-a-url-like-import-specifier It has been rename to "resolve a URL-like module specifier". https://whatpr.org/html/8075/webappapis.html#resolving-a-url-like-module-specifier Differential Revision: https://phabricator.services.mozilla.com/D152868
bd23f15494ad540af0bd591b8e4c6d66023f0faf: Bug 1792976 - Update path in .eslintignore in mach esmify command. r=yulia
Tooru Fujisawa <arai_a@mac.com> - Wed, 05 Oct 2022 09:14:26 +0000 - rev 713316
Push 2983 by ffxbld-merge at Mon, 07 Nov 2022 15:51:05 +0000
Bug 1792976 - Update path in .eslintignore in mach esmify command. r=yulia Differential Revision: https://phabricator.services.mozilla.com/D158642
afff9a173a449d966d293b411bf26532a657df13: Bug 1792751 - Quote the mercurial glob pattern in mach esmify command. r=yulia
Tooru Fujisawa <arai_a@mac.com> - Wed, 05 Oct 2022 09:14:25 +0000 - rev 713315
Push 2983 by ffxbld-merge at Mon, 07 Nov 2022 15:51:05 +0000
Bug 1792751 - Quote the mercurial glob pattern in mach esmify command. r=yulia Differential Revision: https://phabricator.services.mozilla.com/D158641
04dc31eaa8eda840e6ecc09046fc65ad4eb2ab34: Bug 1789543 - Part 3: Trigger missing chrome/resource URL error handling with original JSM URL when fallback to ESMified URL also fails. r=yulia
Tooru Fujisawa <arai_a@mac.com> - Mon, 12 Sep 2022 01:04:37 +0000 - rev 711376
Push 2963 by ffxbld-merge at Mon, 10 Oct 2022 11:03:15 +0000
Bug 1789543 - Part 3: Trigger missing chrome/resource URL error handling with original JSM URL when fallback to ESMified URL also fails. r=yulia Depends on D156763 Differential Revision: https://phabricator.services.mozilla.com/D156764
364b5631681ac7528e12b8679b6fd2ce03068e73: Bug 1789543 - Part 2: Pass ModuleLoadRequest to ModuleLoaderInfo constructor. r=yulia
Tooru Fujisawa <arai_a@mac.com> - Mon, 12 Sep 2022 01:04:37 +0000 - rev 711375
Push 2963 by ffxbld-merge at Mon, 10 Oct 2022 11:03:15 +0000
Bug 1789543 - Part 2: Pass ModuleLoadRequest to ModuleLoaderInfo constructor. r=yulia Depends on D156762 Differential Revision: https://phabricator.services.mozilla.com/D156763
4444217fdc0c35492d7828cdcaf34cef45319ff8: Bug 1789543 - Part 1: Pass ModuleLoadRequest to mozJSModuleLoader::LoadSingleModuleScript. r=yulia
Tooru Fujisawa <arai_a@mac.com> - Mon, 12 Sep 2022 01:04:36 +0000 - rev 711374
Push 2963 by ffxbld-merge at Mon, 10 Oct 2022 11:03:15 +0000
Bug 1789543 - Part 1: Pass ModuleLoadRequest to mozJSModuleLoader::LoadSingleModuleScript. r=yulia Differential Revision: https://phabricator.services.mozilla.com/D156762
7756e3ed482fed160d338c36efb4ddfb08619be8: Bug 1789412 - Resolve top-level capability of all Evaluated modules in ModuleEvaluate r=yulia
Jon Coppeard <jcoppeard@mozilla.com> - Fri, 09 Sep 2022 13:13:27 +0000 - rev 711210
Push 2963 by ffxbld-merge at Mon, 10 Oct 2022 11:03:15 +0000
Bug 1789412 - Resolve top-level capability of all Evaluated modules in ModuleEvaluate r=yulia This is indeed very similar to bug 1787926. As per the current spec we don't resolve the top level capability of async modules in ModuleEvaluate, even if evaluation has finished successfully. This is due to the following spec change: https://github.com/tc39/proposal-top-level-await/commit/c2375dbd6ecb0d5e9a415f6a812fc0974a2935b7#diff-181371b08d71216599b0acccbaabd03c306da6de142ea6275c2135810999805aL546-R547 I think this should revert to the original behaviour which resolves the capability when the module has finished evaluating, even for async modules. Differential Revision: https://phabricator.services.mozilla.com/D156704
c2ef22f8486501b334e9589b08ff35e4e4764d03: Bug 1789018 - Remove unused code from browser_promise_userInteractionHandling.html. r=yulia
Tooru Fujisawa <arai_a@mac.com> - Thu, 08 Sep 2022 01:52:40 +0000 - rev 711060
Push 2963 by ffxbld-merge at Mon, 10 Oct 2022 11:03:15 +0000
Bug 1789018 - Remove unused code from browser_promise_userInteractionHandling.html. r=yulia The test is performed inside browser_promise_userInteractionHandling.js Differential Revision: https://phabricator.services.mozilla.com/D156639
f7567091b43ba717392db9e5f780145d9b34ec45: Bug 1788882 - Check module status on entry to JS::ModuleLink API r=yulia
Jon Coppeard <jcoppeard@mozilla.com> - Mon, 05 Sep 2022 09:43:09 +0000 - rev 710744
Push 2963 by ffxbld-merge at Mon, 10 Oct 2022 11:03:15 +0000
Bug 1788882 - Check module status on entry to JS::ModuleLink API r=yulia Checks the module status unconditionally and throws an error if it is not as expected. This now includes the unexpected status in the error to help debugging and bug reported. Differential Revision: https://phabricator.services.mozilla.com/D156293
40afb18a8db39c1aed47dc09d2012ec79b33f27e: Bug 1787926 - Don't add async dependency on modules that have finished evaluating r=yulia
Jon Coppeard <jcoppeard@mozilla.com> - Wed, 31 Aug 2022 14:18:26 +0000 - rev 709981
Push 2963 by ffxbld-merge at Mon, 10 Oct 2022 11:03:15 +0000
Bug 1787926 - Don't add async dependency on modules that have finished evaluating r=yulia The problem is that we're waiting for an import to finish evaluation after it already has. I think this a problem with the spec, related to the change from AsyncEvaluating to AsyncEvaluation here: https://github.com/tc39/proposal-top-level-await/commit/c2375dbd6ecb0d5e9a415f6a812fc0974a2935b7#diff-181371b08d71216599b0acccbaabd03c306da6de142ea6275c2135810999805aL588-R589 Previously we wouldn't add an async dependency when the required module's AsyncEvaluating field was false, which was the case after evaluation had finished. Now this is never set to false so we always add the dependency here and there's nothing to trigger evaluation of the importing module. Differential Revision: https://phabricator.services.mozilla.com/D155968
b3289a628ab09c8cc1c6114861ed2260c8f1d86f: Bug 1775424 - Part 1: Impl import.meta.resolve() on browser. r=jonco,yulia
Yoshi Cheng-Hao Huang <allstars.chh@gmail.com> - Tue, 30 Aug 2022 18:42:53 +0000 - rev 704770
Push 2963 by ffxbld-merge at Mon, 10 Oct 2022 11:03:15 +0000
Bug 1775424 - Part 1: Impl import.meta.resolve() on browser. r=jonco,yulia Define 'resolve()' function on import.meta object on browser. Add mochitests for import.meta.resolve, as some of the wpt tests for import.meta.resolve cannot be run due to some bugs in wpt testing framework. See https://bugzilla.mozilla.org/show_bug.cgi?id=1785806 Differential Revision: https://phabricator.services.mozilla.com/D154105
19bc4fafd300c14da9cc98f78486363e557ce864: Bug 1775424 - Part 1: Impl import.meta.resolve() on browser. r=jonco,yulia
Yoshi Cheng-Hao Huang <allstars.chh@gmail.com> - Mon, 29 Aug 2022 18:12:09 +0000 - rev 704656
Push 2963 by ffxbld-merge at Mon, 10 Oct 2022 11:03:15 +0000
Bug 1775424 - Part 1: Impl import.meta.resolve() on browser. r=jonco,yulia Define 'resolve()' function on import.meta object on browser. Add mochitests for import.meta.resolve, as some of the wpt tests for import.meta.resolve cannot be run due to some bugs in wpt testing framework. See https://bugzilla.mozilla.org/show_bug.cgi?id=1785806 Differential Revision: https://phabricator.services.mozilla.com/D154105
999ccf7813ae49dcf013c57c86370e5ef0361969: Bug 1789412 - Resolve top-level capability of all Evaluated modules in ModuleEvaluate. r=yulia, a=RyanVM
Jon Coppeard <jcoppeard@mozilla.com> - Fri, 09 Sep 2022 13:13:27 +0000 - rev 703936
Push 2938 by ffxbld-merge at Mon, 12 Sep 2022 14:47:05 +0000
Bug 1789412 - Resolve top-level capability of all Evaluated modules in ModuleEvaluate. r=yulia, a=RyanVM This is indeed very similar to bug 1787926. As per the current spec we don't resolve the top level capability of async modules in ModuleEvaluate, even if evaluation has finished successfully. This is due to the following spec change: https://github.com/tc39/proposal-top-level-await/commit/c2375dbd6ecb0d5e9a415f6a812fc0974a2935b7#diff-181371b08d71216599b0acccbaabd03c306da6de142ea6275c2135810999805aL546-R547 I think this should revert to the original behaviour which resolves the capability when the module has finished evaluating, even for async modules. Differential Revision: https://phabricator.services.mozilla.com/D156704
53bd7ef331dbc81b54b4ae05648370eff11d88e4: Bug 1787926 - Don't add async dependency on modules that have finished evaluating. r=yulia, a=RyanVM
Jon Coppeard <jcoppeard@mozilla.com> - Wed, 31 Aug 2022 14:18:26 +0000 - rev 703883
Push 2938 by ffxbld-merge at Mon, 12 Sep 2022 14:47:05 +0000
Bug 1787926 - Don't add async dependency on modules that have finished evaluating. r=yulia, a=RyanVM The problem is that we're waiting for an import to finish evaluation after it already has. I think this a problem with the spec, related to the change from AsyncEvaluating to AsyncEvaluation here: https://github.com/tc39/proposal-top-level-await/commit/c2375dbd6ecb0d5e9a415f6a812fc0974a2935b7#diff-181371b08d71216599b0acccbaabd03c306da6de142ea6275c2135810999805aL588-R589 Previously we wouldn't add an async dependency when the required module's AsyncEvaluating field was false, which was the case after evaluation had finished. Now this is never set to false so we always add the dependency here and there's nothing to trigger evaluation of the importing module. Differential Revision: https://phabricator.services.mozilla.com/D155968
7abab3bd2a576fce23d742e0d004f046f930916d: Bug 1781256 - Append importMapString directly in testInIframe* from test-helper.js. r=yulia
Yoshi Cheng-Hao Huang <allstars.chh@gmail.com> - Mon, 15 Aug 2022 07:21:10 +0000 - rev 703106
Push 2938 by ffxbld-merge at Mon, 12 Sep 2022 14:47:05 +0000
Bug 1781256 - Append importMapString directly in testInIframe* from test-helper.js. r=yulia The check for importMapString is for legacy code from V8. [1] But we no longer have that, so we could just append the importMapString directly. [1]: https://source.chromium.org/chromium/chromium/src/+/154b398975650214a599b3aae5e8679cd18fd13c:third_party/blink/web_tests/external/wpt/import-maps/builtin-import-scheme.tentative.html;dlc=e5916b3c37418878e6e4e1e89783f18d45ec250f Differential Revision: https://phabricator.services.mozilla.com/D153071
5771675980ea9f1e63bcbf905d251f735a7f7bb5: Bug 1782713 - Remove FinishDynamicModuleImport_NoTLA and related defintions r=yulia
Jon Coppeard <jcoppeard@mozilla.com> - Tue, 02 Aug 2022 14:08:46 +0000 - rev 701714
Push 2938 by ffxbld-merge at Mon, 12 Sep 2022 14:47:05 +0000
Bug 1782713 - Remove FinishDynamicModuleImport_NoTLA and related defintions r=yulia Depends on D153464 Differential Revision: https://phabricator.services.mozilla.com/D153465
9226460a36d80abbdaac1d486921345de3f05e29: Bug 1782496 - Handle uncatchable exceptions during module evaluation r=yulia
Jon Coppeard <jcoppeard@mozilla.com> - Tue, 02 Aug 2022 08:36:19 +0000 - rev 701671
Push 2938 by ffxbld-merge at Mon, 12 Sep 2022 14:47:05 +0000
Bug 1782496 - Handle uncatchable exceptions during module evaluation r=yulia This makes sure we still set the module state to evaluated when there's an uncatchable exception. The module's error will be set to undefined, which is not great but it will probably never be used in this case. Differential Revision: https://phabricator.services.mozilla.com/D153372
c02f1a1d3cf6fa8bffb9aaa594320969f0fdbb8c: Bug 1779421 - Part 3: Add tests for expected module status and async evaluating state r=yulia
Jon Coppeard <jcoppeard@mozilla.com> - Thu, 28 Jul 2022 09:08:28 +0000 - rev 701331
Push 2938 by ffxbld-merge at Mon, 12 Sep 2022 14:47:05 +0000
Bug 1779421 - Part 3: Add tests for expected module status and async evaluating state r=yulia This adds a shell function 'clearModules' to clear all loaded modules, so that tests can be insulated from one another. Depends on D151834 Differential Revision: https://phabricator.services.mozilla.com/D151835
d44ac2d93a1c603c30bc98864e5eb37b79ffa02b: Bug 1779421 - Part 2: Fix reset of post order counter r=yulia
Jon Coppeard <jcoppeard@mozilla.com> - Thu, 28 Jul 2022 09:08:27 +0000 - rev 701330
Push 2938 by ffxbld-merge at Mon, 12 Sep 2022 14:47:05 +0000
Bug 1779421 - Part 2: Fix reset of post order counter r=yulia Adding tests (see next patch) revealed an off-by-one bug resetting the async evaluation post order counter. Differential Revision: https://phabricator.services.mozilla.com/D151834
7fa1eac15d439b69f0ac1320adb2ecba61d3c92a: Bug 1779421 - Part 1: Rework module AsyncEvaluation field to match the spec r=yulia
Jon Coppeard <jcoppeard@mozilla.com> - Thu, 28 Jul 2022 09:08:27 +0000 - rev 701329
Push 2938 by ffxbld-merge at Mon, 12 Sep 2022 14:47:05 +0000
Bug 1779421 - Part 1: Rework module AsyncEvaluation field to match the spec r=yulia As per the lastest spec this now stays true after evaluation. This patch keeps a very similar implemenatation and resets the field after evaluation, except that we now report this special value as true rather than false. We assert if we try and use get the sort order after this has happened. We also reset the runtime counter in the same way as before. Differential Revision: https://phabricator.services.mozilla.com/D151833
12620b755d6b0af8909f0249e37af4c5c1893b83: Bug 1773997 - Part 4: wpt for injecting a <base> element for import-maps. r=jonco,yulia
Yoshi Cheng-Hao Huang <allstars.chh@gmail.com> - Tue, 26 Jul 2022 15:16:12 +0000 - rev 701166
Push 2938 by ffxbld-merge at Mon, 12 Sep 2022 14:47:05 +0000
Bug 1773997 - Part 4: wpt for injecting a <base> element for import-maps. r=jonco,yulia This test introduces two new functions to test the base url functionality. In addition, we have a new helper function: testInIframeInjectBase, which injects a base url before the content with the import map is parsed. The two tests test the following: 1. Static import coming after the import map and injected base element 2. Dynamic import coming after the import map and injected base element Differential Revision: https://phabricator.services.mozilla.com/D150719
968815f882d2e5d5775b74f035fc20a0b1931ffe: Bug 1773997 - Part 3: wpt with <base> for import-maps. r=jonco,yulia
Yoshi Cheng-Hao Huang <allstars.chh@gmail.com> - Tue, 26 Jul 2022 15:16:11 +0000 - rev 701165
Push 2938 by ffxbld-merge at Mon, 12 Sep 2022 14:47:05 +0000
Bug 1773997 - Part 3: wpt with <base> for import-maps. r=jonco,yulia With <base> element changes the base URL to "./resources/", the baseURL of the import map should be updated as well. The url "log.js" in the import map will be resolved to "./resources/log.js". Differential Revision: https://phabricator.services.mozilla.com/D150718
7754a95427ef53c3a87aa157d8807ab3e5e50ecc: Bug 1773997 - Part 2: Use absolute path when calling static_import.py r=jonco,yulia
Yoshi Cheng-Hao Huang <allstars.chh@gmail.com> - Tue, 26 Jul 2022 15:16:11 +0000 - rev 701164
Push 2938 by ffxbld-merge at Mon, 12 Sep 2022 14:47:05 +0000
Bug 1773997 - Part 2: Use absolute path when calling static_import.py r=jonco,yulia When using with <base> element, relative paths will also be changed. So updating the path when calling static_import.py. Differential Revision: https://phabricator.services.mozilla.com/D150717
1732aa187a6f4daed995602591122d61af56a9e5: Bug 1782496 - Handle uncatchable exceptions during module evaluation r=yulia, a=dsmith
Jon Coppeard <jcoppeard@mozilla.com> - Tue, 02 Aug 2022 08:36:19 +0000 - rev 700874
Push 2914 by ffxbld-merge at Mon, 15 Aug 2022 14:50:57 +0000
Bug 1782496 - Handle uncatchable exceptions during module evaluation r=yulia, a=dsmith This makes sure we still set the module state to evaluated when there's an uncatchable exception. The module's error will be set to undefined, which is not great but it will probably never be used in this case. Differential Revision: https://phabricator.services.mozilla.com/D153372
a49298bd06fda2fdc8ebb47e63121ec0d7594909: Bug 1764239 - Check for errors before accessing a module's CycleRoot field r=yulia
Jon Coppeard <jcoppeard@mozilla.com> - Thu, 14 Jul 2022 11:29:47 +0000 - rev 699699
Push 2914 by ffxbld-merge at Mon, 15 Aug 2022 14:50:57 +0000
Bug 1764239 - Check for errors before accessing a module's CycleRoot field r=yulia Like the changes in bug 1777972 concerning CycleRoot, this is not in the spec but seems necessary due to the fact that this field isn't set when synchronous module execution fails. Differential Revision: https://phabricator.services.mozilla.com/D151734
aa33ade6d8e508501a4a3ea464421dcbb7615158: Bug 1779538 - Rewrite ChromeUtils.importESModule with static import in sys.mjs. r=yulia
Tooru Fujisawa <arai_a@mac.com> - Thu, 14 Jul 2022 08:54:01 +0000 - rev 699691
Push 2914 by ffxbld-merge at Mon, 15 Aug 2022 14:50:57 +0000
Bug 1779538 - Rewrite ChromeUtils.importESModule with static import in sys.mjs. r=yulia Differential Revision: https://phabricator.services.mozilla.com/D151801
1dbc4ab3ec68640552554f14618f595f115582d8: Bug 1775026 - Update tests; r=yulia
Dan Minor <dminor@mozilla.com> - Wed, 13 Jul 2022 16:39:31 +0000 - rev 699600
Push 2914 by ffxbld-merge at Mon, 15 Aug 2022 14:50:57 +0000
Bug 1775026 - Update tests; r=yulia Differential Revision: https://phabricator.services.mozilla.com/D150634
74443d400c2208559a35ba7fe134cc70c637ff83: Bug 1775026 - Ship Array.{findLast,findLastIndex}; r=yulia
Dan Minor <dminor@mozilla.com> - Wed, 13 Jul 2022 16:39:30 +0000 - rev 699599
Push 2914 by ffxbld-merge at Mon, 15 Aug 2022 14:50:57 +0000
Bug 1775026 - Ship Array.{findLast,findLastIndex}; r=yulia This removes the pref and options for findLast and findLastIndex so that they are shipped by default. Differential Revision: https://phabricator.services.mozilla.com/D150633
8f537ef57b2e025c220c8778f4b2932d469de545: Bug 1779247 - Part 3: Update AsyncModuleExecutionRejected to the latest spec and add steps r=yulia
Jon Coppeard <jcoppeard@mozilla.com> - Wed, 13 Jul 2022 16:06:39 +0000 - rev 699593
Push 2914 by ffxbld-merge at Mon, 15 Aug 2022 14:50:57 +0000
Bug 1779247 - Part 3: Update AsyncModuleExecutionRejected to the latest spec and add steps r=yulia As for the previous patch, we still set async evaluating to false after execution. Differential Revision: https://phabricator.services.mozilla.com/D151719
685b4d3a78111c41bb86493e7bf8e377eb259b9f: Bug 1779247 - Part 2: Update AsyncModuleExecutionFulfilled to the latest spec and add steps r=yulia
Jon Coppeard <jcoppeard@mozilla.com> - Wed, 13 Jul 2022 16:06:39 +0000 - rev 699592
Push 2914 by ffxbld-merge at Mon, 15 Aug 2022 14:50:57 +0000
Bug 1779247 - Part 2: Update AsyncModuleExecutionFulfilled to the latest spec and add steps r=yulia Currently our implementation sets the async evaluating flag to false at the end of execution. This patch does not change this yet as it's a convenient point to reset the moduleAsyncEvaluatingPostOrder counter, so this diverges from the spec. I'll file a followup bug to address this. Depends on D151716 Differential Revision: https://phabricator.services.mozilla.com/D151717
3e7850e36813ed6ef97f250bb741e3420b085bbf: Bug 1779247 - Part 1: Move the sort operation from GatherAvailableModuleAncestors into AsyncModuleExecutionFulfilled as per the spec r=yulia
Jon Coppeard <jcoppeard@mozilla.com> - Wed, 13 Jul 2022 16:06:38 +0000 - rev 699591
Push 2914 by ffxbld-merge at Mon, 15 Aug 2022 14:50:57 +0000
Bug 1779247 - Part 1: Move the sort operation from GatherAvailableModuleAncestors into AsyncModuleExecutionFulfilled as per the spec r=yulia GatherAvailableModuleAncestors is also now local to Modules.cpp. Differential Revision: https://phabricator.services.mozilla.com/D151716
17cdb35dc89335bf96e9fdca170d51d070fa3a10: Bug 1777972 - Part 3: Refactor extra error check at the start of ModuleEvaluate r=yulia
Jon Coppeard <jcoppeard@mozilla.com> - Tue, 12 Jul 2022 12:27:28 +0000 - rev 699418
Push 2914 by ffxbld-merge at Mon, 15 Aug 2022 14:50:57 +0000
Bug 1777972 - Part 3: Refactor extra error check at the start of ModuleEvaluate r=yulia This refactors the extra check to make it clearer what's going on and adds a simple test case for the issue. Differential Revision: https://phabricator.services.mozilla.com/D151508
2e18ce531c64de2b6ed97173bdb75bb473dbf1d4: Bug 1777972 - Part 2: Add evaluating-async module status r=yulia
Jon Coppeard <jcoppeard@mozilla.com> - Tue, 12 Jul 2022 12:27:28 +0000 - rev 699417
Push 2914 by ffxbld-merge at Mon, 15 Aug 2022 14:50:57 +0000
Bug 1777972 - Part 2: Add evaluating-async module status r=yulia This adds ModuleStatus::EvaluatingAsync, splitting it off from ModuleStatus::Evaluated. This allows us to rewrite parts of the code to be closer to the spec. Depends on D151506 Differential Revision: https://phabricator.services.mozilla.com/D151507
23e793db636da5db8828136f8c6868f4023d5a38: Bug 1777972 - Part 1: Hide Evaluated_Error module state r=yulia
Jon Coppeard <jcoppeard@mozilla.com> - Tue, 12 Jul 2022 12:27:27 +0000 - rev 699416
Push 2914 by ffxbld-merge at Mon, 15 Aug 2022 14:50:57 +0000
Bug 1777972 - Part 1: Hide Evaluated_Error module state r=yulia I originally thought adding an extra status would allow for stronger assertions but now I think it has made state checks more verbose and harder to compare with the spec. This patch makes ModuleObject::status return ModuleStatus::Evaluated when the status is Evaluated_Error so that this method matches the spec's concept of the value of the ModuleStatus field. This turned up one place where we diverge from the spec. In ModuleEvaluate step 3 we don't get the cycle root if we are in the error state. This is currently required otherwise some tests fail. This patch preserves the current behvaiour, which is now explicit. Differential Revision: https://phabricator.services.mozilla.com/D151506
9247e947c41c153a3a0d3180ba99e03e328c4f0e: Bug 1773471: renamed test file r=yulia
Hemanth HM <hemanth.hm@gmail.com> - Tue, 12 Jul 2022 11:36:47 +0000 - rev 699405
Push 2914 by ffxbld-merge at Mon, 15 Aug 2022 14:50:57 +0000
Bug 1773471: renamed test file r=yulia Depends on D150471 Differential Revision: https://phabricator.services.mozilla.com/D150486
02293391dc47e0487bf2e441f6eb68984f55e080: Bug 1773471: fixed test r=yulia
Hemanth HM <hemanth.hm@gmail.com> - Tue, 12 Jul 2022 11:36:47 +0000 - rev 699404
Push 2914 by ffxbld-merge at Mon, 15 Aug 2022 14:50:57 +0000
Bug 1773471: fixed test r=yulia Depends on D148672 Differential Revision: https://phabricator.services.mozilla.com/D150471
8a9b5179c88c4b52c27c28e564a1eb7ef6cfff57: Bug 1739648: Renaming to group and groupToMap r=yulia
Hemanth HM <hemanth.hm@gmail.com> - Tue, 12 Jul 2022 11:36:46 +0000 - rev 699403
Push 2914 by ffxbld-merge at Mon, 15 Aug 2022 14:50:57 +0000
Bug 1739648: Renaming to group and groupToMap r=yulia Differential Revision: https://phabricator.services.mozilla.com/D148672