searching for reviewer(whimboo)
086a215d4caadb457a629887524907149cde1c4d: Bug 1533221 - In Mn test_capabilities.py, compare only the basename of profile paths; r=whimboo, a=test-only
Geoff Brown <gbrown@mozilla.com> - Thu, 21 Mar 2019 21:08:55 +0000 - rev 525768
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1533221 - In Mn test_capabilities.py, compare only the basename of profile paths; r=whimboo, a=test-only Differential Revision: https://phabricator.services.mozilla.com/D24377
d266414d9c66f4c3aa758b0879d1603e74282554: Bug 1519055 - Set window handle for 'switch_to_window' also as 'handle'. r=whimboo
Kriti Singh <kritisingh1.ks@gmail.com> - Thu, 14 Mar 2019 20:13:12 +0000 - rev 524945
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1519055 - Set window handle for 'switch_to_window' also as 'handle'. r=whimboo Differential Revision: https://phabricator.services.mozilla.com/D23526
b4a06ea3abad4bcd041492481150150fddcd1309: Bug 1529643 - Don't do MitM priming in tests. r=whimboo,gbrown
Johann Hofmann <jhofmann@mozilla.com> - Wed, 13 Mar 2019 23:37:01 +0000 - rev 524802
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529643 - Don't do MitM priming in tests. r=whimboo,gbrown Differential Revision: https://phabricator.services.mozilla.com/D22407
000dfd4caca0183893f821c4856d2a97c043bf5c: Bug 1529643 - Don't do MitM priming in tests. r=whimboo,gbrown
Johann Hofmann <jhofmann@mozilla.com> - Wed, 13 Mar 2019 21:04:04 +0000 - rev 524781
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529643 - Don't do MitM priming in tests. r=whimboo,gbrown Differential Revision: https://phabricator.services.mozilla.com/D22407
44fee8919949e9b0411ff723443a7b3ff6ae8b86: Bug 1519053 - Set window handle for 'Switch To Window' also as 'handle'. r=whimboo
Kriti Singh <kritisingh1.ks@gmail.com> - Tue, 12 Mar 2019 21:42:31 +0000 - rev 524605
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1519053 - Set window handle for 'Switch To Window' also as 'handle'. r=whimboo Differential Revision: https://phabricator.services.mozilla.com/D23169
ec939d4f81dcf0058ab4b9549083c7f4a9698fe8: Bug 1530980 - Stop listening for mail-startup-done to start Marionette in Thunderbird; r=whimboo
Geoff Lankow <geoff@darktrojan.net> - Sat, 09 Mar 2019 15:44:14 +1300 - rev 524238
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1530980 - Stop listening for mail-startup-done to start Marionette in Thunderbird; r=whimboo
e2bfdeaf11bddaa79f28ad81921d13c7aac9914e: Bug 1533056 - Move test_startup_caches out of marionette unit tests r=whimboo
Doug Thayer <dothayer@mozilla.com> - Thu, 07 Mar 2019 06:30:38 +0000 - rev 523846
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1533056 - Move test_startup_caches out of marionette unit tests r=whimboo Renamed the test to reflect that it is really just a test of the script preloader as well. I just moved it to get it close to the ScriptPreloader and near existing tests. Differential Revision: https://phabricator.services.mozilla.com/D22330
7b44e98a5576d5805fb642c47efa2ba28a999347: Bug 1529863 - Remove remnants of unused browser.firstrun and browser.snippets prefs. r=geckoview-reviewers,whimboo,esawin
Jan Henning <jh+bugzilla@buttercookie.de> - Wed, 06 Mar 2019 14:59:46 +0000 - rev 523544
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529863 - Remove remnants of unused browser.firstrun and browser.snippets prefs. r=geckoview-reviewers,whimboo,esawin "browser.firstrun.*" seems to have been unused since the end of XUL-based Fennec, whereas the code referencing the "browser.snippets.*" prefs was removed in bug 1482836. Differential Revision: https://phabricator.services.mozilla.com/D20862
4348e60c81ed02630b24c9dfa4b49cf5d0a2b696: Bug 1500509 - Move Android marionette tests to 7.0 x86_64; r=whimboo
Geoff Brown <gbrown@mozilla.com> - Wed, 06 Mar 2019 09:09:10 +0000 - rev 523442
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1500509 - Move Android marionette tests to 7.0 x86_64; r=whimboo Differential Revision: https://phabricator.services.mozilla.com/D22183
ab359d0369df423c0699fab9ff7beee7058d6f34: Bug 1418778 - disable tests on windows 10 for intermittent failures in webdriver new_session tests. r=whimboo
Joel Maher <jmaher@mozilla.com> - Wed, 20 Feb 2019 14:13:07 +0000 - rev 520954
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1418778 - disable tests on windows 10 for intermittent failures in webdriver new_session tests. r=whimboo disable tests on windows 10 for intermittent failures in webdriver new_session tests. Differential Revision: https://phabricator.services.mozilla.com/D20480
59fad017d3c5bd70958da132f8f0b319c9899b6b: Bug 1522536 - Remove redundant address bar UI tests. r=whimboo
Dão Gottwald <dao@mozilla.com> - Tue, 19 Feb 2019 07:45:46 +0000 - rev 520722
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1522536 - Remove redundant address bar UI tests. r=whimboo Differential Revision: https://phabricator.services.mozilla.com/D20269
9469362459f91fece70a390dc221129486e82143: bug 1526938: geckodriver: lint main.rs; r=whimboo
Andreas Tolfsen <ato@sny.no> - Mon, 18 Feb 2019 12:48:57 +0000 - rev 520658
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
bug 1526938: geckodriver: lint main.rs; r=whimboo Minor post-patch linting to silence some clippy warnings. Depends on D19434 Differential Revision: https://phabricator.services.mozilla.com/D19435
a02142b7aefff4ff6a57c7f11618d98369b5f8eb: bug 1526938: geckodriver: provide better error messages for flags; r=whimboo
Andreas Tolfsen <ato@sny.no> - Mon, 18 Feb 2019 12:48:55 +0000 - rev 520657
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
bug 1526938: geckodriver: provide better error messages for flags; r=whimboo This will print something along the line of: geckodriver: error: invalid --port: invalid digit found in string: asd Or: geckodriver: error: invalid --port: number too large to fit in target type: 123123123123 We also Include the error message from IpAddr::from_str() to the user. This will make the error seen by the user look something like this: geckodriver: error: invalid IP address syntax: 123123:4444 Depends on D19433 Differential Revision: https://phabricator.services.mozilla.com/D19434
561a8cb2db9b422f4af806b1bb0c7c8448b4d298: bug 1526938: geckodriver: ensure --help is listed in help message; r=whimboo
Andreas Tolfsen <ato@sny.no> - Mon, 18 Feb 2019 12:48:53 +0000 - rev 520656
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
bug 1526938: geckodriver: ensure --help is listed in help message; r=whimboo For completeness, this makes sure the --help flag is included in its own help message. Depends on D19432 Differential Revision: https://phabricator.services.mozilla.com/D19433
b2768473a2805ecf5b58aa0c341d1085d65bad96: bug 1526938: geckodriver: separate flag parsing and application logic; r=whimboo
Andreas Tolfsen <ato@sny.no> - Mon, 18 Feb 2019 12:48:51 +0000 - rev 520655
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
bug 1526938: geckodriver: separate flag parsing and application logic; r=whimboo Flag parsing and application logic belong to one, very long, spaghetti-like function. This patch introduces a distinction between checking the sanity of the CLI input and what action to take depending on that input. Depends on D19431 Differential Revision: https://phabricator.services.mozilla.com/D19432
16aac9625fdee7452d9cfdcf06115512db3d9410: bug 1526938: geckodriver: display help message on non-clap errors; r=whimboo
Andreas Tolfsen <ato@sny.no> - Mon, 18 Feb 2019 12:48:49 +0000 - rev 520654
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
bug 1526938: geckodriver: display help message on non-clap errors; r=whimboo The help message is implicitly included in clap error descriptions, but they are not for errors originating from this file. By introducing a FatalError::help_included() function we make sure we print the help message in all cases. An alternative implementation, which perhaps would be more idiomatic, would be to prepare the help message within the fmt::Display trait implementation for FatalError, but I could find no way of passing in a reference to clap::App without storing it in an atomic global const. Depends on D19430 Differential Revision: https://phabricator.services.mozilla.com/D19431
e37346a0237371a6d707c27d0c7c3e4bf3dbdff1: bug 1526938: geckodriver: fix missing flag parsing errors; r=whimboo
Andreas Tolfsen <ato@sny.no> - Mon, 18 Feb 2019 12:48:47 +0000 - rev 520653
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
bug 1526938: geckodriver: fix missing flag parsing errors; r=whimboo Because we emit the flag parsing errors to the log, through error!(), they are subject to whether the logging subsystem is enabled. Because logging is disabled by default, no error information is currently displayed to the user. Since we cannot initialise logging implicitly due to the risk of emitting log messages the user did not request, this patch changes geckodriver to print the flag parsing errors to stderr Depends on D19429 Differential Revision: https://phabricator.services.mozilla.com/D19430
6ad3a665abdfbaf3ebc96213b4bd4febfa4b062f: bug 1526938: geckodriver: organise args a bit more consistently; r=whimboo
Andreas Tolfsen <ato@sny.no> - Mon, 18 Feb 2019 12:48:45 +0000 - rev 520652
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
bug 1526938: geckodriver: organise args a bit more consistently; r=whimboo Depends on D19428 Differential Revision: https://phabricator.services.mozilla.com/D19429
dfb9154473caf58fb372afa0b923cca32677ec03: bug 1526938: geckodriver: remove --webdriver-port alias; r=whimboo
Andreas Tolfsen <ato@sny.no> - Mon, 18 Feb 2019 12:48:43 +0000 - rev 520651
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
bug 1526938: geckodriver: remove --webdriver-port alias; r=whimboo We replaced --webdriver-port with --port to better match EdgeDriver and chromedriver, but it was discovered in https://github.com/mozilla/geckodriver/issues/154 that this broke Selenium clients. We decided on a two-spearhead approach by reintroducing --webdriver-port as a temporary alias, whilst submitting fixes for the Selenium clients. The fixes to Selenium landed over three years ago. This patch removes the --webdriver-port alias from geckodriver. Depends on D19427 Differential Revision: https://phabricator.services.mozilla.com/D19428
0fdfd128248cfe04218dcc42fe64fced502e8bc1: bug 1526938: geckodriver: generalise cli errors; r=whimboo
Andreas Tolfsen <ato@sny.no> - Mon, 18 Feb 2019 12:48:36 +0000 - rev 520650
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
bug 1526938: geckodriver: generalise cli errors; r=whimboo Instead of returning a tuple of (i32, String), causing us to lose details and the cause of an error, this patch formalises the error scenarios that may occur during command-line parsing and startup of the WebDriver server. Exit codes are encoded with each variant of FatalError, instead of being specified in each case. Type conversions are implemented for clap::Error (flag parsing) and io::Error (webdriver::server). Depends on D19426 Differential Revision: https://phabricator.services.mozilla.com/D19427
342fcc83b61361b143724490c49bda27bc4a4f0d: bug 1526938: geckodriver: import logging::Level into the global scope; r=whimboo
Andreas Tolfsen <ato@sny.no> - Mon, 18 Feb 2019 12:48:34 +0000 - rev 520649
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
bug 1526938: geckodriver: import logging::Level into the global scope; r=whimboo Depends on D19425 Differential Revision: https://phabricator.services.mozilla.com/D19426
f11ef576312915f2eefdaaf1cfaceb29ff27e9f8: bug 1526938: geckodriver: convert ExitCode to consts; r=whimboo
Andreas Tolfsen <ato@sny.no> - Mon, 18 Feb 2019 12:48:32 +0000 - rev 520648
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
bug 1526938: geckodriver: convert ExitCode to consts; r=whimboo We don't need an enum for exit codes as we never have to match on them. Converting them to consts also has the benefit that we will not have to coerce them to i32. i32 is the correct type to use here, since it is what std::process::exit() takes and what the libc crate uses. Depends on D19424 Differential Revision: https://phabricator.services.mozilla.com/D19425
e2a10e5049be9a0b63cc6b6bec92ae9b6d517edc: bug 1526938: geckodriver: make use of clap default values; r=whimboo
Andreas Tolfsen <ato@sny.no> - Mon, 18 Feb 2019 12:48:30 +0000 - rev 520647
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
bug 1526938: geckodriver: make use of clap default values; r=whimboo Making use of clap::Arg::default_value() removes duplicated magic strings, by not having to use .unwrap_or("default value"). Depends on D19423 Differential Revision: https://phabricator.services.mozilla.com/D19424
a9357f295d5fdc0883ce6605fdc1b2612e673ede: bug 1526938: geckodriver: display same version on --help as on --version; r=whimboo
Andreas Tolfsen <ato@sny.no> - Mon, 18 Feb 2019 12:48:28 +0000 - rev 520646
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
bug 1526938: geckodriver: display same version on --help as on --version; r=whimboo Differential Revision: https://phabricator.services.mozilla.com/D19423
4cf8e31cb26140e621218bf5f6c43afad73a4c3d: Bug 1511764 - Bail out of startup if we are unable to connect to wpt, r=whimboo
James Graham <james@hoppipolla.co.uk> - Tue, 12 Feb 2019 14:47:07 +0000 - rev 519625
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1511764 - Bail out of startup if we are unable to connect to wpt, r=whimboo The previous setup was broken because subclasses could run code after the cinnection failed assuming that the connection had succeeded. Unwinding the stack and sending the failure messages at the top level avoid this pitfall. Depends on D19487 Differential Revision: https://phabricator.services.mozilla.com/D19488
f754cb84d09288c4adb6002a5b16d829e04098b3: Bug 1511764 - Ensure that marionette has a session when we try to use it during teardown, r=whimboo
James Graham <james@hoppipolla.co.uk> - Tue, 12 Feb 2019 14:32:16 +0000 - rev 519624
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1511764 - Ensure that marionette has a session when we try to use it during teardown, r=whimboo In the case that startup failed we may not have a marionette session during teardown Depends on D19486 Differential Revision: https://phabricator.services.mozilla.com/D19487
0bdbfacae180f0a3d5f236179f4ad097150efef1: Bug 1511764 - Fixup launching Chrome from ./mach wpt, r=whimboo
James Graham <james@hoppipolla.co.uk> - Tue, 12 Feb 2019 14:32:09 +0000 - rev 519623
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1511764 - Fixup launching Chrome from ./mach wpt, r=whimboo Differential Revision: https://phabricator.services.mozilla.com/D19486
78b4a9446213b4581f2465b801a5aa153b07bfb3: Bug 1526913 - In Mn test_cookies.py allow for some clock difference between host and device; r=whimboo
Geoff Brown <gbrown@mozilla.com> - Tue, 12 Feb 2019 09:24:16 -0700 - rev 519593
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1526913 - In Mn test_cookies.py allow for some clock difference between host and device; r=whimboo
cb96244f54b125436abc17244d7c14d99fc675e1: Bug 1526084 - In Mn test_capabilities.py, allow for multiple links to sdcard; r=whimboo
Geoff Brown <gbrown@mozilla.com> - Tue, 12 Feb 2019 09:24:16 -0700 - rev 519592
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1526084 - In Mn test_capabilities.py, allow for multiple links to sdcard; r=whimboo
a971c53ea2c08f806d5ea1bca5a3c48d68151749: Bug 1524673 - Make Marionette part of remote debugging within GeckoView. r=whimboo,snorp
Nick Alexander <nalexander@mozilla.com> - Mon, 11 Feb 2019 19:35:30 +0000 - rev 519473
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1524673 - Make Marionette part of remote debugging within GeckoView. r=whimboo,snorp Functionally, we want Marionette to be enabled whenever remote debugging enabled and disabled whenever remote debugging is enabled. That's not particularly well supported by Gecko prefs, so we don't try to handle all situations. We force the Marionette pref whenever the remote debugging pref changes; if consumers get themselves into a bad state by fiddling the Marionette pref independently, that's fine: GeckoView will take back control eventually. There are a couple of wrinkles here. The first is that GeckoView and Marionette race to set themselves up in "profile-after-change". We ensure that both are configured before GeckoView notifies "marionette-startup-requested". The second is that the initial value of the Marionette pref is taken from the environment variable MOZ_MARIONETTE; therefore, we set that variable when starting the Gecko thread. Differential Revision: https://phabricator.services.mozilla.com/D17580
590f9a6f20a5bd330ce795eacc9e2e4f853b3387: Bug 1521444 - Add webdriver unit tests for indefinite script timeout. r=whimboo
reimu <r2hkri@gmail.com> - Mon, 28 Jan 2019 10:14:52 +0000 - rev 516475
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1521444 - Add webdriver unit tests for indefinite script timeout. r=whimboo Add tests that check serialization and deserialization for indefinite script timeout Differential Revision: https://phabricator.services.mozilla.com/D17148
d0e6b3cbbd16bce6ab704eb708464ab238d8ded3: Bug 1517442 - [marionette] Use current instead of default startup time in raise_for_port r=whimboo
Agboola Mukhtar <agboolaolamide9@gmail.com> - Wed, 16 Jan 2019 19:54:53 +0000 - rev 514129
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1517442 - [marionette] Use current instead of default startup time in raise_for_port r=whimboo Differential Revision: https://phabricator.services.mozilla.com/D16609
39346b9630dec5b3b076a7c8a5b8dc0e88eb5dea: Bug 1495002 - disable timeouts.py on win ccov for frequent failures. r=whimboo
Cristina Coroiu <ccoroiu> - Thu, 10 Jan 2019 14:19:00 +0200 - rev 514015
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1495002 - disable timeouts.py on win ccov for frequent failures. r=whimboo
060ca330d2aa6eaef17750f20068f96d0bf75d7c: Bug 1520137: Update documentation pointing to #interop instead of #ateam r=whimboo
David Burns <dburns@mozilla.com> - Tue, 15 Jan 2019 14:14:10 +0000 - rev 513917
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1520137: Update documentation pointing to #interop instead of #ateam r=whimboo As we move away from #ateam we need to make sure we that we point people to the correct IRC Channel Differential Revision: https://phabricator.services.mozilla.com/D16547
701665c38279f670742aebe1aee58291484ce129: Bug 1519552 - Disable test_reftest.py on Android r=jgraham,whimboo
Geoffrey Sneddon <me@gsnedders.com> - Mon, 14 Jan 2019 14:50:15 +0000 - rev 513722
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1519552 - Disable test_reftest.py on Android r=jgraham,whimboo Differential Revision: https://phabricator.services.mozilla.com/D16456
d3d18e1a63e346bc4e8cb6aba3a59bf9a28181ee: Bug 1507121 - disable create_firstMatch.py on win ccov for frequently failing. r=whimboo
Cristina Coroiu <ccoroiu> - Mon, 07 Jan 2019 23:21:00 +0200 - rev 512884
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1507121 - disable create_firstMatch.py on win ccov for frequently failing. r=whimboo
a10beb909d931f09e94ee79b990010427aee225a: bug 1496489: webdriver: re-enable test_maximize_when_resized_to_max_size; r=whimboo
Andreas Tolfsen <ato@sny.no> - Thu, 03 Jan 2019 14:10:48 +0000 - rev 512402
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
bug 1496489: webdriver: re-enable test_maximize_when_resized_to_max_size; r=whimboo Marionette recently had changes made to its window maximisation algorithm that lets us re-enable this test. It tests that session.window.maximize() does not hang when the window is already maximised. Differential Revision: https://phabricator.services.mozilla.com/D15582
f3c28d11924b1e36dd09969d65adcacfc76bc877: bug 1510929: marionette: remove scriptTimeout parameter; r=whimboo
Andreas Tolfsen <ato@sny.no> - Thu, 03 Jan 2019 11:20:16 +0000 - rev 512401
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
bug 1510929: marionette: remove scriptTimeout parameter; r=whimboo Depends on D15583 Differential Revision: https://phabricator.services.mozilla.com/D15584
afe5d9b5a7f4f065d04d3bd2dff6962ae8d1b593: bug 1510929: marionette: stop using scriptTimeout parameter; r=whimboo
Andreas Tolfsen <ato@sny.no> - Thu, 03 Jan 2019 14:08:13 +0000 - rev 512400
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
bug 1510929: marionette: stop using scriptTimeout parameter; r=whimboo By stopping to use the scriptTimeout parameter with the WebDriver:ExecuteScript and WebDriver:ExecuteAsyncScript commands in the Marionette Python client, we can remove it from the server. Differential Revision: https://phabricator.services.mozilla.com/D15583
75b067260e3883506fbd19347028f65c6553576e: Bug 1504201 - [marionette] Temporarily skip TestScreenCaptureChrome.test_formats on Linux. r=whimboo
Henrik Skupin <mail@hskupin.info> - Wed, 02 Jan 2019 11:26:06 +0100 - rev 512273
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1504201 - [marionette] Temporarily skip TestScreenCaptureChrome.test_formats on Linux. r=whimboo
87416015abce1d9108dca33f84b1a4a98f3d9422: bug 1510929: marionette: remove script_timeout kwarg from client; r=whimboo
Andreas Tolfsen <ato@sny.no> - Thu, 20 Dec 2018 21:24:05 +0000 - rev 511572
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
bug 1510929: marionette: remove script_timeout kwarg from client; r=whimboo This removes the script_timeouts keyword argument from Marionette#execute_script and #execute_async_script as it is not compatible with the semantic meaning associated with null in WebDriver. The script timeout duration for the session can instead be set using Marionette#timeouts#script. Depends on D13993 Differential Revision: https://phabricator.services.mozilla.com/D13994
919fea1e53373e26dbb38e3d1bde923dac84db21: bug 1510929: puppeteer: remove use of script_timeout; r=whimboo
Andreas Tolfsen <ato@sny.no> - Thu, 20 Dec 2018 21:23:18 +0000 - rev 511571
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
bug 1510929: puppeteer: remove use of script_timeout; r=whimboo Differential Revision: https://phabricator.services.mozilla.com/D13993
0864e90347bf14b1ec57009f094b2435ae97a110: Bug 1504201 - [marionette] Temporarily skip TestScreenCaptureChrome.test_formats on Linux. r=whimboo a=testonly
Henrik Skupin <mail@hskupin.info> - Wed, 02 Jan 2019 11:26:06 +0100 - rev 509286
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1504201 - [marionette] Temporarily skip TestScreenCaptureChrome.test_formats on Linux. r=whimboo a=testonly
f9d8c60591142bd751ff149f34b287d456df606c: Bug 1506523 - Adapt Marionette so it can run on Thunderbird; r=whimboo
Geoff Lankow <geoff@darktrojan.net> - Fri, 23 Nov 2018 10:38:19 +1300 - rev 507005
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1506523 - Adapt Marionette so it can run on Thunderbird; r=whimboo
eed5fefba0897a4dfd2ad9ae9408a02fcc024976: Bug 1480142 - Pass test paths relative to the Marionette test install dir to the Marionette test runner. r=whimboo
Marco Castelluccio <mcastelluccio@mozilla.com> - Tue, 20 Nov 2018 17:25:34 +0100 - rev 506488
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1480142 - Pass test paths relative to the Marionette test install dir to the Marionette test runner. r=whimboo
b6010c470851c2a92036ae40c76665048575a20c: bug 1507428: webdriver: fix incorrect Content-Type header; r=whimboo
Andreas Tolfsen <ato@sny.no> - Fri, 16 Nov 2018 19:17:37 +0000 - rev 506042
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
bug 1507428: webdriver: fix incorrect Content-Type header; r=whimboo The Content-Type header contains the correct MIME type, but the charset option is "utf8" and invalid: it should be "utf-8". Differential Revision: https://phabricator.services.mozilla.com/D12116
6293789f6e9c50b0b24b310c81d4b2b3defc3a1e: Bug 1506796 - use OpenBrowserWindow instead of window.open() to create a browser window, r=whimboo
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 14 Nov 2018 14:27:58 +0000 - rev 505413
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1506796 - use OpenBrowserWindow instead of window.open() to create a browser window, r=whimboo Differential Revision: https://phabricator.services.mozilla.com/D11745
0320a28c61636bb240602ac28caf077480ba5b68: bug 1505806: webdriver: throttle window rect calls; r=whimboo
Andreas Tolfsen <ato@sny.no> - Fri, 09 Nov 2018 10:54:16 +0000 - rev 504610
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
bug 1505806: webdriver: throttle window rect calls; r=whimboo By throttling the Get Window Rect calls we avoid the buffer filling up on Windows, and avoid errors such as: [Errno 10055] An operation on a socket could not be performed because the system lacked sufficient buffer space or because a queue was full Differential Revision: https://phabricator.services.mozilla.com/D11410
2c1b00a6a97f90dea740c046759698bed3a4c6fe: bug 1492499: marionette: increase TimedPromise timeout on debug; r=whimboo
Andreas Tolfsen <ato@sny.no> - Thu, 08 Nov 2018 13:11:40 +0000 - rev 504352
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
bug 1492499: marionette: increase TimedPromise timeout on debug; r=whimboo The things that rely on TimedPromise, such as awaiting a sizemodechange event on exiting fullscreen, takes a lot longer to perform in Asan and debug builds than in optimised builds. This patch increases the TimedPromise timeout duration by three times in debug builds, which is the same amount WPT uses. Depends on D10569 Differential Revision: https://phabricator.services.mozilla.com/D11189
81ac8f7d11b1d003d1a64ad94bfef4cb49553f91: bug 1492499: marionette: restore from maximized before setting rect; r=whimboo
Andreas Tolfsen <ato@sny.no> - Thu, 08 Nov 2018 13:11:31 +0000 - rev 504350
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
bug 1492499: marionette: restore from maximized before setting rect; r=whimboo On certain window manager configurations a window may be resized to fit the full available dimensions of the screen without going into the maximised state. Similarily, a maximised window may be the exact dimensions of the screen. If the window outerWidth/outerHeight is 800x600 and in maximised state, resizing it to 800x600 through WebDriver:SetWindowRect will not work because the window has already reached its requested dimensions. This patch ensures to wait for the resizeEnd event when the window state is not normal. Depends on D8419 Differential Revision: https://phabricator.services.mozilla.com/D10568