searching for reviewer(tnikkel)
560d33742a4e4033becf03f3c4e4c0173488da6e: Bug 1565512 - Ensure the RCD-RSF callback transform is applied for events targeting fixed content too. r=tnikkel, a=RyanVM
Botond Ballo <botond@mozilla.com> - Sat, 03 Aug 2019 16:16:56 +0000 - rev 545092
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1565512 - Ensure the RCD-RSF callback transform is applied for events targeting fixed content too. r=tnikkel, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D40535
8787ce24bafe9bf68892910dd842dc79b1323ef6: Bug 1568826 - Restrict the fix for bug 1549625 to cases where we have a zoomable viewport. r=tnikkel a=pascalc
Botond Ballo <botond@mozilla.com> - Fri, 02 Aug 2019 20:31:57 +0000 - rev 544981
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1568826 - Restrict the fix for bug 1549625 to cases where we have a zoomable viewport. r=tnikkel a=pascalc The fix for bug 1549625 is only necessary in cases where the layout and visual viewports can diverge (currently mobile, and later desktop zooming), but it has caused regressions in desktop scenarios that don't involve zooming. While we can get a proper fix in place (tracked in bug 1543485), restricting the existing fix to zoomable configurations mitigates the regressions. Differential Revision: https://phabricator.services.mozilla.com/D40473
3da66b493241eeb120d698a419f587963b0d802b: Bug 1569772 - Release load group on main thread in win/nsIconChannel r=tnikkel a=RyanVM
Junior Hsu <juhsu@mozilla.com> - Mon, 29 Jul 2019 22:42:39 +0000 - rev 544873
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1569772 - Release load group on main thread in win/nsIconChannel r=tnikkel a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D39795
a60290b9de2c0d51d4622e55c9b33319ee5fdd8e: Bug 1528180 - Don't align scroll offsets to layer pixels when using WebRender. r=tnikkel a=RyanVM
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 12 Jul 2019 20:04:16 +0000 - rev 544574
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1528180 - Don't align scroll offsets to layer pixels when using WebRender. r=tnikkel a=RyanVM This position is only invalidated from FrameLayerBuilder, that's not a very good signal. This would get out of sync when using WebRender, and APZ messages will send sub-pixel scroll positions that will get wrongly adjusted, causing small scroll offsets which scroll anchoring would incorrectly try to correct, which is the ultimate cause of the jittering. Differential Revision: https://phabricator.services.mozilla.com/D37875
13557cb78993a31ebdb850e0076efc3a4a3dfdcb: Bug 1561726 - Add an nsIDOMWindowUtils API for querying the size of layout scrollbars. r=tnikkel
Botond Ballo <botond@mozilla.com> - Fri, 28 Jun 2019 20:22:49 +0000 - rev 543436
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1561726 - Add an nsIDOMWindowUtils API for querying the size of layout scrollbars. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D34257
6d20bab59174d90c2f8b209500648ea73e0f06f1: Bug 1561726 - Add an nsIContent overload of nsLayoutUtils::FindScrollableFrameFor. r=tnikkel
Botond Ballo <botond@mozilla.com> - Fri, 28 Jun 2019 20:22:37 +0000 - rev 543435
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1561726 - Add an nsIContent overload of nsLayoutUtils::FindScrollableFrameFor. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D34256
98a36d0a7ec8807fe9f0023572a07827240663bf: Bug 1557218 - Get the bitmap data for system icons by drawing them to a CGBitmapContext with a format of our choosing. r=tnikkel
Markus Stange <mstange@themasta.com> - Thu, 27 Jun 2019 15:34:20 +0000 - rev 543202
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1557218 - Get the bitmap data for system icons by drawing them to a CGBitmapContext with a format of our choosing. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D36121
3e22c91c3b04f6f4d6e0d172c890b02ee59f2eac: Bug 1561756 - Convert the NSImage into an NSBitmapImageRep without using lockFocus. r=tnikkel
Markus Stange <mstange@themasta.com> - Wed, 26 Jun 2019 22:42:39 +0000 - rev 543094
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1561756 - Convert the NSImage into an NSBitmapImageRep without using lockFocus. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D36124
55d83c717bc8a5e0fff1e117ebd412d2ab8f2020: Bug 1557218 - Get the bitmap data for system icons by drawing them to a CGBitmapContext with a format of our choosing. r=tnikkel
Markus Stange <mstange@themasta.com> - Wed, 26 Jun 2019 22:28:49 +0000 - rev 543089
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1557218 - Get the bitmap data for system icons by drawing them to a CGBitmapContext with a format of our choosing. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D36121
92a3a2e17fdb8b252e73d989cbb2dde0590e8813: Bug 1560587 - Remove incorrect event redirection. r=tnikkel
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 24 Jun 2019 20:10:40 +0000 - rev 542809
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1560587 - Remove incorrect event redirection. r=tnikkel In this codepath, the parent process may be sending an event to a particular content process. The last-saved mouse target might be stale, and using that to redirect the event can result in the event getting sent to the wront content process. Deleting this erroneous change restores correct behaviour. Differential Revision: https://phabricator.services.mozilla.com/D35697
0ee72a7f207835e0d6a4f01e58208f086359263b: Bug 1560441 - Don't create QCMS profiles/transforms during PNG metadata decoding. r=tnikkel
Andrew Osmond <aosmond@mozilla.com> - Thu, 20 Jun 2019 16:50:20 -0700 - rev 542690
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1560441 - Don't create QCMS profiles/transforms during PNG metadata decoding. r=tnikkel Creating QCMS profiles and transforms are fairly expensive operations and not necessary for metadata decoding. We can reduce the time required for PNG metadata decoding by skipping this. The JPEG and WebP decoders already do this. Differential Revision: https://phabricator.services.mozilla.com/D35500
6f11e76d382220103cb9b65b06964429aeeb9010: Bug 1348503 - Retrieve the FrameLayerBuilder pointer from the LayerManager when we need it. r=tnikkel
Matt Woodrow <mwoodrow@mozilla.com> - Thu, 13 Jun 2019 17:02:54 +0000 - rev 541814
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1348503 - Retrieve the FrameLayerBuilder pointer from the LayerManager when we need it. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D34772
83ea8b67c8ff428d920fe6d3f2deac412ffddc08: Bug 1558451 - Add gtest microbenchmarks for image decoders. r=tnikkel
Andrew Osmond <aosmond@mozilla.com> - Tue, 11 Jun 2019 17:46:13 -0400 - rev 541234
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1558451 - Add gtest microbenchmarks for image decoders. r=tnikkel This adds variants of 1000x1000 green pixels encoded for each image format. This includes different pixel representations (e.g. CMYK, YCbCr, grayscale, lossy, lossless) as well as opaque and partially transparent. JPG, PNG and WebP include either an RGB or gray ICC profile to test color management integration as well. Differential Revision: https://phabricator.services.mozilla.com/D34502
7d7a497d0d97b0cade710a11eb6b9161c3e89bfc: Bug 1554813 - Size the scroll parts clip to the scroll frame's true outer size. r=tnikkel
Botond Ballo <botond@mozilla.com> - Mon, 10 Jun 2019 16:30:42 +0000 - rev 541090
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1554813 - Size the scroll parts clip to the scroll frame's true outer size. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D33377
3562bfab16fc325070284259a88a5addd69900c1: Bug 1554832 - Check only for in process content documents in AssumeAllFramesVisible. r=tnikkel
Matt Woodrow <mwoodrow@mozilla.com> - Fri, 07 Jun 2019 06:59:02 +0000 - rev 540837
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1554832 - Check only for in process content documents in AssumeAllFramesVisible. r=tnikkel Depends on D34098 Differential Revision: https://phabricator.services.mozilla.com/D34099
44fa715640dd2a4d06014e6d5fdda63c52707188: Bug 1255108 - Make JPEG decoder use SurfacePipe. r=tnikkel
Andrew Osmond <aosmond@mozilla.com> - Thu, 04 Apr 2019 15:38:52 -0400 - rev 538757
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1255108 - Make JPEG decoder use SurfacePipe. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D26373
aed0c5da0ce04de0940830b096f14bf4f5dd6a3b: Bug 1255106 - Part 4. Ensure we don't apply CMS transforms in cases we missed. r=tnikkel
Andrew Osmond <aosmond@mozilla.com> - Thu, 04 Apr 2019 16:30:10 -0400 - rev 538756
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1255106 - Part 4. Ensure we don't apply CMS transforms in cases we missed. r=tnikkel GIF images should not apply CMS transforms if disabled by caller via SurfaceFlags::NO_COLORSPACE_CONVERSION. WebP images should reject any non-RGB ICC profiles, not just grayscale profiles. Differential Revision: https://phabricator.services.mozilla.com/D26372
85eb83a6f3134ce852117c727da0499f540d0abd: Bug 1255106 - Part 3. Use color management filter with decoders using SurfacePipe. r=tnikkel
Andrew Osmond <aosmond@mozilla.com> - Thu, 04 Apr 2019 13:22:59 -0400 - rev 538755
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1255106 - Part 3. Use color management filter with decoders using SurfacePipe. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D26371
3a7b422645b73ed45c6ace609cf424c06c2040c4: Bug 1255106 - Part 2. Implement color management filter for SurfacePipe. r=tnikkel
Andrew Osmond <aosmond@mozilla.com> - Thu, 04 Apr 2019 11:44:35 -0400 - rev 538754
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1255106 - Part 2. Implement color management filter for SurfacePipe. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D26370
524f61bca4383cae06562409c789cb26d5865c06: Bug 1255106 - Part 1. Move color transform state to image decoder base class. r=tnikkel
Andrew Osmond <aosmond@mozilla.com> - Thu, 04 Apr 2019 11:44:12 -0400 - rev 538753
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1255106 - Part 1. Move color transform state to image decoder base class. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D26369
a479292cb15ca5db48aa280cf3bec0e585ad8ed4: Bug 1550523 - Ensure that decoding methods for frozen images request the correct frame. r=tnikkel
Andrew Osmond <aosmond@mozilla.com> - Tue, 21 May 2019 13:34:14 -0400 - rev 537780
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1550523 - Ensure that decoding methods for frozen images request the correct frame. r=tnikkel With WebRender, we had observed that the print preview for animated images was not displaying correctly. It should display the first frame but it was showing nothing the first time the preview was opened. Once the decoded image was available in the cache, it would display correctly if the preview was reloaded. The StartDecoding and RequestDecode variants always requested FRAME_CURRENT for animated images. They should use FRAME_FIRST for static requests / FrozenImage. Correcting this fixes the print preview. Differential Revision: https://phabricator.services.mozilla.com/D32033
71bf2b9ca6ea2cbd97f4a07242e2ad7f20a1a2e5: Bug 1530190. Call SHGetFileInfo off the main thread in nsIconChannel on Windows. r=tnikkel
Andrew Osmond <aosmond@mozilla.com> - Mon, 22 Apr 2019 17:30:40 -0500 - rev 537744
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1530190. Call SHGetFileInfo off the main thread in nsIconChannel on Windows. r=tnikkel There are two reasons for this. One is performance, it can be slow. The second is that is can spin the event loop which can re-enter into things like layout. This patch uses the image decoder thread pool for that. But this is unsuitable (reason in next patch), the next patch changes it to use the img io thread used for network to pass data to imglib off main thread. Differential Revision: https://phabricator.services.mozilla.com/D28419
9278288dfa948feb1bb91f7d1c625e53a784d514: Bug 1557218 - Get the bitmap data for system icons by drawing them to a CGBitmapContext with a format of our choosing. r=tnikkel a=jcristau
Markus Stange <mstange@themasta.com> - Thu, 27 Jun 2019 15:34:20 +0000 - rev 537186
Push 2083 by archaeopteryx@coole-files.de at Mon, 01 Jul 2019 12:16:33 +0000
Bug 1557218 - Get the bitmap data for system icons by drawing them to a CGBitmapContext with a format of our choosing. r=tnikkel a=jcristau Differential Revision: https://phabricator.services.mozilla.com/D36121
4ae8f7ba99880f6693f5281c76dbb8e41bab11ff: Bug 1348503 - Retrieve the FrameLayerBuilder pointer from the LayerManager when we need it. r=tnikkel, a=jcristau
Matt Woodrow <mwoodrow@mozilla.com> - Thu, 13 Jun 2019 17:02:54 +0000 - rev 537093
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1348503 - Retrieve the FrameLayerBuilder pointer from the LayerManager when we need it. r=tnikkel, a=jcristau Differential Revision: https://phabricator.services.mozilla.com/D34772
a9beb454bd6cfd5bb1045d5d255e07bc54acd5d2: Bug 1560587 - Remove incorrect event redirection. r=tnikkel, a=jcristau
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 24 Jun 2019 20:10:40 +0000 - rev 537090
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1560587 - Remove incorrect event redirection. r=tnikkel, a=jcristau In this codepath, the parent process may be sending an event to a particular content process. The last-saved mouse target might be stale, and using that to redirect the event can result in the event getting sent to the wront content process. Deleting this erroneous change restores correct behaviour. Differential Revision: https://phabricator.services.mozilla.com/D35697
5d6b91a3b5365903cd7d2c48bf32f62e50bff46a: Bug 1545842 - Downgrade RestyleManager assertions to DIAGNOSTIC_ASSERT in beta. r=tnikkel a=jcristau
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 19 Apr 2019 23:32:36 +0300 - rev 536432
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1545842 - Downgrade RestyleManager assertions to DIAGNOSTIC_ASSERT in beta. r=tnikkel a=jcristau The only case where we know that this assert breaks right now is in nsIconChannel. nsIconChannel is used for moz-icon://, which is not exposed to content. So it doesn't seem to be easy to potentially get into a broken state that content could exploit, and thus crashes in release may be a bit excessive. Downgrade the assertion for now. Differential Revision: https://phabricator.services.mozilla.com//D28248
3e3ebfd849558d6011dec7b53ea5942ba1da8867: Bug 1550523 - Ensure that decoding methods for frozen images request the correct frame. r=tnikkel a=jcristau
Andrew Osmond <aosmond@mozilla.com> - Tue, 21 May 2019 13:34:14 -0400 - rev 536431
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1550523 - Ensure that decoding methods for frozen images request the correct frame. r=tnikkel a=jcristau With WebRender, we had observed that the print preview for animated images was not displaying correctly. It should display the first frame but it was showing nothing the first time the preview was opened. Once the decoded image was available in the cache, it would display correctly if the preview was reloaded. The StartDecoding and RequestDecode variants always requested FRAME_CURRENT for animated images. They should use FRAME_FIRST for static requests / FrozenImage. Correcting this fixes the print preview. Differential Revision: https://phabricator.services.mozilla.com/D32033
885f2b742a0252362ff92730c7602802863d9757: Bug 1548835 - Load moz-extension:// URIs from the cache over reloading. r=tnikkel
Andrew Osmond <aosmond@mozilla.com> - Thu, 16 May 2019 14:55:19 -0400 - rev 536246
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1548835 - Load moz-extension:// URIs from the cache over reloading. r=tnikkel Similar to bug 1373258 and moz-page-thumb:// URIs, we are getting bitten by the lack of caching support for non-HTTP channels. This may be removed once bug 1406134 is implemented. Differential Revision: https://phabricator.services.mozilla.com/D31515
c052518818dff9b913814d785606a0d11ec65e4e: Bug 1541253 - Test cases for CSS visibility propagation. r=tnikkel
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Fri, 10 May 2019 10:35:45 +0000 - rev 535268
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1541253 - Test cases for CSS visibility propagation. r=tnikkel There are three test cases; 1) Two iframes are swapped 2) Changing the visibility of the parent document doesn't clobber a child document's visibility in the case where the child document has been hidden by another element in the parent document 3) an iframe is initially inside a visibility:hidden element in the parent document Depends on D26253 Differential Revision: https://phabricator.services.mozilla.com/D27842
57c522abe28f6d78f646d90c720022057205666c: Bug 1541253 - Check PresShell::IsUnderHiddenEmbedderElement where we need to check CSS visibility state across the document boundary. r=tnikkel
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Fri, 10 May 2019 11:22:28 +0000 - rev 535267
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1541253 - Check PresShell::IsUnderHiddenEmbedderElement where we need to check CSS visibility state across the document boundary. r=tnikkel Depends on D26252 Differential Revision: https://phabricator.services.mozilla.com/D26253
335b9a8f496819c5777c0f67eff5f88bf983288b: Bug 1541253 - Propagate CSS visivibility information to descendant documents. r=tnikkel
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Fri, 10 May 2019 11:15:43 +0000 - rev 535266
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1541253 - Propagate CSS visivibility information to descendant documents. r=tnikkel Depends on D26251 Differential Revision: https://phabricator.services.mozilla.com/D26252
d3340f866c7df1f283153c1dec37d5b83933bf7f: Bug 1541253 - Make PresShell::IsVisible const. r=tnikkel
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Fri, 10 May 2019 11:15:30 +0000 - rev 535265
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1541253 - Make PresShell::IsVisible const. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D26251
ea3a73c7788e2b9752d7f00976c8119183e3da18: Bug 1548483 - Don't assert that we have an invalidated frame when we encouter a new displayport, since it can have changed on an earlier paint if we didn't have display items. r=tnikkel
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 06 May 2019 09:13:00 +0000 - rev 534661
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1548483 - Don't assert that we have an invalidated frame when we encouter a new displayport, since it can have changed on an earlier paint if we didn't have display items. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D29975
b3417a0b019fa428a2edbf79683ed5b2260c14cd: Bug 1524232 - Dispatch synthesized mousemoves to OOP iframes if that's where they land. r=tnikkel
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 02 May 2019 19:57:16 +0000 - rev 534561
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1524232 - Dispatch synthesized mousemoves to OOP iframes if that's where they land. r=tnikkel Depends on D29731 Differential Revision: https://phabricator.services.mozilla.com/D29732
0e259884f052230b24601efc3cde3a5ef5d4e6ad: Bug 1535945 - Don't skip invalidating frames when creating displayports for async scrollable ancestors. r=tnikkel
Matt Woodrow <mwoodrow@mozilla.com> - Wed, 01 May 2019 04:23:07 +0000 - rev 533938
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1535945 - Don't skip invalidating frames when creating displayports for async scrollable ancestors. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D23816
c992709a5b8079d6cd6ec133e84fbcbdad3ef7ee: Bug 1543944 - Don't mark nsDisplayVideo as opaque for now because we were using a rectangle that's too big. r=tnikkel
Markus Stange <mstange@themasta.com> - Thu, 18 Apr 2019 17:22:29 +0000 - rev 532009
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1543944 - Don't mark nsDisplayVideo as opaque for now because we were using a rectangle that's too big. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D27979
3502a44129b0a87c0a57c5c02643210d3410d8c6: Bug 1543584 - Always rasterize SVGs but clamp the maximum size. r=tnikkel
Andrew Osmond <aosmond@mozilla.com> - Thu, 11 Apr 2019 15:30:48 -0400 - rev 531936
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1543584 - Always rasterize SVGs but clamp the maximum size. r=tnikkel SVG performance with the fallback path with WebRender is very bad. This patch avoids fallback by always producing a rasterized surface we store in SurfaceCache, but also clamping the size consistently to a configured maximum. This will cause us to upscale rasterized SVGs which is undesirable visually but is a lower risk change that we can uplift to beta than fixing the underlying performance issue. Differential Revision: https://phabricator.services.mozilla.com/D27159
7b63cad25d9b4081eedc4a4d65004c60ac0c9277: Bug 1542663 - Make nsViewManager and nsView (nsIWidgetListener) use mozilla::PresShell directly rather than via nsIPresShell r=tnikkel
Masayuki Nakano <masayuki@d-toybox.com> - Sat, 13 Apr 2019 01:05:21 +0000 - rev 531268
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1542663 - Make nsViewManager and nsView (nsIWidgetListener) use mozilla::PresShell directly rather than via nsIPresShell r=tnikkel This patch makes `nsViewManager::GetPresShell()` and `nsIWidgetListener::GetPresShell()` (overridden by `nsView` and `nsWebShellWindow::WidgetListenerDelegate`) return `mozilla::PresShell*`. Additionally, makes `nsWebShellWindow::GetPresShell()` also return `mozilla::PresShell()`. Differential Revision: https://phabricator.services.mozilla.com/D26454
946181497fb19b1293935525643dfc10a840967c: Bug 1516056 - Adjust ScrollToRestorePosition() to reflect that the layout scroll offset is clamped to the layout viewport. r=tnikkel
Botond Ballo <botond@mozilla.com> - Mon, 08 Apr 2019 23:35:25 +0000 - rev 530332
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1516056 - Adjust ScrollToRestorePosition() to reflect that the layout scroll offset is clamped to the layout viewport. r=tnikkel Depends on D20282 Differential Revision: https://phabricator.services.mozilla.com/D20283
5a7f8303d682cc3ce7880c42dd0c74d75c0b5cd3: Bug 1501794 - Implement img decode API. r=bzbarsky,tnikkel
Andrew Osmond <aosmond@mozilla.com> - Thu, 08 Nov 2018 12:45:50 -0500 - rev 529544
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1501794 - Implement img decode API. r=bzbarsky,tnikkel The img decode API allows a web author to request that an image be decoded at its intrinsic size and be notified when it has been completed. This is useful to ensure an image is ready to display before adding it to the DOM tree -- this will help reduce flickering. Differential Revision: https://phabricator.services.mozilla.com/D11362
7f0d03ec917cfc831b7c4104729801fa33b1d167: Bug 1534240 - Boost loading priority of CSS images similarly to how we do for HTML images. r=tnikkel
Cameron McCormack <cam@mcc.id.au> - Thu, 28 Mar 2019 02:54:16 +0000 - rev 528393
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1534240 - Boost loading priority of CSS images similarly to how we do for HTML images. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D24814
fdc7b66d76a4ded62d0292bef4de0ffb090d9587: Bug 1395964 - Don't clear the previously painted image on intrinsic size changes. r=tnikkel
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 18 Mar 2019 16:19:56 +0100 - rev 526706
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1395964 - Don't clear the previously painted image on intrinsic size changes. r=tnikkel This is needed if we want to handle cases like the reporter's example or Google Images. Rendering the old image upscaled is much better than not rendering anything while it's loading. I added a test for the reframing bit, but I don't know how to add a test for the second bit. Differential Revision: https://phabricator.services.mozilla.com/D23127
3f1e9dae2467e54c783215189e6cb9617cee7dcd: Bug 1395964 - Make image loading changes not reframe. r=tnikkel
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 18 Mar 2019 16:18:52 +0100 - rev 526705
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1395964 - Make image loading changes not reframe. r=tnikkel Bug 1472637 makes the decision of whether to construct an image frame not depend on this, so this is sound. We need to avoid reframing to fix this bug because otherwise we lose track of the previously painted image. Differential Revision: https://phabricator.services.mozilla.com/D23127
94682e23ba118dcfab3843a3280618b2e1686ecb: Bug 1472637 - Don't display alt text while loading, to match other UAs. r=tnikkel
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 18 Mar 2019 15:15:13 +0000 - rev 526704
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1472637 - Don't display alt text while loading, to match other UAs. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D18518
52390d9090fbd8d46b00ea29034e7039511ff8a4: Bug 1530774 - Part 3. Remove decoder support for producing paletted frames. r=tnikkel
Andrew Osmond <aosmond@mozilla.com> - Fri, 15 Mar 2019 13:29:02 -0400 - rev 526657
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1530774 - Part 3. Remove decoder support for producing paletted frames. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D23716
6dd55ee8961128d0c9e314d60e7509604e7548b2: Bug 1530774 - Part 2. Remove support for paletted surface pipes. r=tnikkel
Andrew Osmond <aosmond@mozilla.com> - Mon, 11 Mar 2019 14:05:59 -0400 - rev 526656
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1530774 - Part 2. Remove support for paletted surface pipes. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D23715
e3315d7842089083b389fc666b51c693c05924fc: Bug 1530774 - Part 1. Remove support in FrameAnimator for blending partial/paletted frames. r=tnikkel
Andrew Osmond <aosmond@mozilla.com> - Mon, 11 Mar 2019 13:20:49 -0400 - rev 526655
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1530774 - Part 1. Remove support in FrameAnimator for blending partial/paletted frames. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D23714
b73974383bce7dd7bddb7f59a371ff766a1f4369: Bug 1543584 - Always rasterize SVGs but clamp the maximum size. r=tnikkel a=pascalc
Andrew Osmond <aosmond@mozilla.com> - Thu, 11 Apr 2019 15:30:48 -0400 - rev 526298
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1543584 - Always rasterize SVGs but clamp the maximum size. r=tnikkel a=pascalc SVG performance with the fallback path with WebRender is very bad. This patch avoids fallback by always producing a rasterized surface we store in SurfaceCache, but also clamping the size consistently to a configured maximum. This will cause us to upscale rasterized SVGs which is undesirable visually but is a lower risk change that we can uplift to beta than fixing the underlying performance issue. Differential Revision: https://phabricator.services.mozilla.com/D27159
bdd03a2c4e54d9bd9f6822ab5bef134d11d67f90: Bug 1545842 - Downgrade RestyleManager assertions to DIAGNOSTIC_ASSERT in beta. r=tnikkel a=pascalc
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 21 Apr 2019 02:54:50 +0300 - rev 526260
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1545842 - Downgrade RestyleManager assertions to DIAGNOSTIC_ASSERT in beta. r=tnikkel a=pascalc Summary: The only case where we know that this assert breaks right now is in nsIconChannel. nsIconChannel is used for moz-icon://, which is not exposed to content. So it doesn't seem to be easy to potentially get into a broken state that content could exploit, and thus crashes in release may be a bit excessive. Downgrade the assertion for now. Reviewers: tnikkel Reviewed By: tnikkel Bug #: 1545842 Differential Revision: https://phabricator.services.mozilla.com/D28248
8647c1f78210adcb01511ea27eecfb53bc5c1a5d: Bug 1534188 - Use high quality downscaling for raster images embedded in SVGs. r=tnikkel
Andrew Osmond <aosmond@mozilla.com> - Wed, 13 Mar 2019 12:43:52 -0400 - rev 524900
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1534188 - Use high quality downscaling for raster images embedded in SVGs. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D23374