searching for reviewer(tcampbell)
99a829d2a2a7859b10508b6f05e99780c5e2dc68: Bug 1544386 part 1 - Call ElementAccessHasExtraIndexedProperty instead of ArrayPrototypeHasIndexedProperty when inlining array natives. r=tcampbell, a=jcristau FENNEC_67_0_3_BUILD1 FENNEC_67_0_3_RELEASE FIREFOX_67_0_3_BUILD1 FIREFOX_67_0_3_RELEASE
Jan de Mooij <jdemooij@mozilla.com> - Wed, 08 May 2019 17:48:26 +0000 - rev 526599
Push 2072 by rmaries@mozilla.com at Tue, 18 Jun 2019 02:53:34 +0000
Bug 1544386 part 1 - Call ElementAccessHasExtraIndexedProperty instead of ArrayPrototypeHasIndexedProperty when inlining array natives. r=tcampbell, a=jcristau This simplifies the code a bit because ElementAccessHasExtraIndexedProperty checks for length-overflow and sparse-indexes so the callers don't have to do that anymore. Differential Revision: https://phabricator.services.mozilla.com/D29486
be119fec61f8d4c6692e30dbc5a633749557eb16: Bug 1543166 - Add missing null check in IonBuilder::computeHeapType. r=tcampbell a=pascalc
Jan de Mooij <jdemooij@mozilla.com> - Wed, 10 Apr 2019 12:47:55 +0000 - rev 526119
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1543166 - Add missing null check in IonBuilder::computeHeapType. r=tcampbell a=pascalc getObject can return nullptr when the TypeSet uses a TypeHashSet for the objects. Differential Revision: https://phabricator.services.mozilla.com/D26874
11ddfc9bd642f08e487fb76d23b7626f0b179e58: Bug 1543166 - Add missing null check in IonBuilder::computeHeapType. r=tcampbell a=pascalc
Jan de Mooij <jdemooij@mozilla.com> - Thu, 11 Apr 2019 05:30:10 +0300 - rev 526115
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1543166 - Add missing null check in IonBuilder::computeHeapType. r=tcampbell a=pascalc Summary: getObject can return nullptr when the TypeSet uses a TypeHashSet for the objects. Reviewers: tcampbell Reviewed By: tcampbell Bug #: 1543166 Differential Revision: https://phabricator.services.mozilla.com/D26874
77536919b1210dcee2e3d72416108210bd9a10c8: Bug 1538006 - Don't emit unbarriered writes to an object if its group might change. r=tcampbell, a=dveditz DEVEDITION_67_0b4_BUILD2 DEVEDITION_67_0b4_RELEASE FENNEC_67_0b4_BUILD1 FENNEC_67_0b4_RELEASE FIREFOX_67_0b4_BUILD2 FIREFOX_67_0b4_RELEASE
Jan de Mooij <jdemooij@mozilla.com> - Thu, 21 Mar 2019 22:47:55 +0000 - rev 525667
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1538006 - Don't emit unbarriered writes to an object if its group might change. r=tcampbell, a=dveditz Differential Revision: https://phabricator.services.mozilla.com/D24448
28911550fa180deca742bc66c9b2b1f2b47b636a: Bug 1537924 - Simplify some alias sets in Ion. r=tcampbell, a=dveditz
Jan de Mooij <jdemooij@mozilla.com> - Thu, 21 Mar 2019 17:52:21 +0000 - rev 525665
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1537924 - Simplify some alias sets in Ion. r=tcampbell, a=dveditz Differential Revision: https://phabricator.services.mozilla.com/D24400
3a1ed20749c52c026c16d1a374a53cf7b92799b2: Bug 1528792 - Remove redundant code checking for Symbol values in js::ToNumberSlow. r=tcampbell
Jason Orendorff <jorendorff@mozilla.com> - Tue, 12 Mar 2019 15:17:09 +0000 - rev 524595
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1528792 - Remove redundant code checking for Symbol values in js::ToNumberSlow. r=tcampbell Differential Revision: https://phabricator.services.mozilla.com/D23152
7a1ad6647c22bd34a6c70e67dc26e5b83f71cea4: Bug 1529758 - Add a pref for fields. r=tcampbell
Jason Orendorff <jorendorff@mozilla.com> - Tue, 12 Mar 2019 19:14:57 +0000 - rev 524594
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529758 - Add a pref for fields. r=tcampbell This creates a shell command-line option, `--enable-experimental-fields`, and a Gecko pref, `javascript.options.experimental.fields`. Both are off by default everywhere, for now. Differential Revision: https://phabricator.services.mozilla.com/D22045
aa1745f5137ca071c565bc56425c8fbe4a0f5fcb: Bug 1530937 part 18 - Rename DoNew{Array,Object} to DoNew{Array,Object}Fallback and remove unused NewObject_WithTemplate IC kind. r=tcampbell
Jan de Mooij <jdemooij@mozilla.com> - Tue, 12 Mar 2019 14:19:30 +0000 - rev 524566
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1530937 part 18 - Rename DoNew{Array,Object} to DoNew{Array,Object}Fallback and remove unused NewObject_WithTemplate IC kind. r=tcampbell Depends on D23137 Differential Revision: https://phabricator.services.mozilla.com/D23142
2b5f40fc403b63dab1d17de84126d809cd333c37: Bug 1529758 - Add a pref for fields. r=tcampbell
Jason Orendorff <jorendorff@mozilla.com> - Tue, 12 Mar 2019 16:42:41 +0000 - rev 524562
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529758 - Add a pref for fields. r=tcampbell This creates a shell command-line option, `--enable-experimental-fields`, and a Gecko pref, `javascript.options.experimental.fields`. Both are off by default everywhere, for now. Differential Revision: https://phabricator.services.mozilla.com/D22045
6382f22140dd664135ef6a9142ec98fadb33c183: Bug 1530937 part 16 - Convert tailCallVMs. r=tcampbell
Jan de Mooij <jdemooij@mozilla.com> - Tue, 12 Mar 2019 14:06:22 +0000 - rev 524529
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1530937 part 16 - Convert tailCallVMs. r=tcampbell Tail calls have their own list/array/enum to improve type safety. Differential Revision: https://phabricator.services.mozilla.com/D23112
5aee215799365ba80bbede0bf44edf24c9ff365a: Bug 1530937 part 15 - Convert callVMs in BaselineIC code. r=tcampbell
Jan de Mooij <jdemooij@mozilla.com> - Tue, 12 Mar 2019 14:04:57 +0000 - rev 524528
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1530937 part 15 - Convert callVMs in BaselineIC code. r=tcampbell Differential Revision: https://phabricator.services.mozilla.com/D23108
1e2091a92a1db1d5f602cb3a469571fd517c5ed6: Bug 1530937 part 14 - Convert callVMs in CacheIR IC code. r=tcampbell
Jan de Mooij <jdemooij@mozilla.com> - Tue, 12 Mar 2019 14:04:39 +0000 - rev 524527
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1530937 part 14 - Convert callVMs in CacheIR IC code. r=tcampbell Differential Revision: https://phabricator.services.mozilla.com/D23107
b9d87882a36584e2f17331b652cbc8681aee17ce: Bug 1534437 - Make JSFlatString::new_ always take ownership of the |chars| passed to it, and add the same sensible ownership handling to a bunch of callers. r=tcampbell
Jeff Walden <jwalden@mit.edu> - Fri, 08 Mar 2019 22:28:08 -0800 - rev 524368
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1534437 - Make JSFlatString::new_ always take ownership of the |chars| passed to it, and add the same sensible ownership handling to a bunch of callers. r=tcampbell Differential Revision: https://phabricator.services.mozilla.com/D23043
abcc9ef3e73da68b0fdbe9674364df36b3c25fd4: Bug 1533636 - Remove all remaining calls to XDRState::codeAlign as no longer necessary now that codeChars and XDRAtom don't require buffer alignment. r=tcampbell
Jeff Walden <jwalden@mit.edu> - Tue, 05 Mar 2019 17:37:20 -0800 - rev 524367
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1533636 - Remove all remaining calls to XDRState::codeAlign as no longer necessary now that codeChars and XDRAtom don't require buffer alignment. r=tcampbell Differential Revision: https://phabricator.services.mozilla.com/D22655
b7c332bee855b657db8f0bcbba9dc98465891a1d: Bug 1533636 - Don't bother explicitly aligning when XDRing char16_t data: the operations we use to perform the little/native-endian conversion will correctly translate into, or translate out of, unaligned memory. r=tcampbell
Jeff Walden <jwalden@mit.edu> - Wed, 06 Mar 2019 13:36:47 -0800 - rev 524366
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1533636 - Don't bother explicitly aligning when XDRing char16_t data: the operations we use to perform the little/native-endian conversion will correctly translate into, or translate out of, unaligned memory. r=tcampbell Differential Revision: https://phabricator.services.mozilla.com/D22654
8ffeb0cdf0e58989498414a1f9b7c22495f7f998: Bug 1533636 - Introduce fill-and-terminate functions for filling dest chars from source chars and null-terminating, when the filling will not lose information. r=tcampbell
Jeff Walden <jwalden@mit.edu> - Wed, 06 Mar 2019 03:24:12 -0800 - rev 524365
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1533636 - Introduce fill-and-terminate functions for filling dest chars from source chars and null-terminating, when the filling will not lose information. r=tcampbell Differential Revision: https://phabricator.services.mozilla.com/D22653
0e054a2c650a484e6a547d5fa4a6cde490445b53: Bug 1533636 - Remove an unused PodOperations.h #include from XDR code. r=tcampbell
Jeff Walden <jwalden@mit.edu> - Mon, 04 Mar 2019 18:21:06 -0800 - rev 524363
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1533636 - Remove an unused PodOperations.h #include from XDR code. r=tcampbell Differential Revision: https://phabricator.services.mozilla.com/D22651
a4438c2ef6a3301d41ea17f6f4b5ab5f7f906263: Bug 1533636 - Define XDRBufferBase::{is,set}Aligned only once, and move #ifdef DEBUG into function definitions. r=tcampbell
Jeff Walden <jwalden@mit.edu> - Mon, 04 Mar 2019 18:01:08 -0800 - rev 524362
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1533636 - Define XDRBufferBase::{is,set}Aligned only once, and move #ifdef DEBUG into function definitions. r=tcampbell Differential Revision: https://phabricator.services.mozilla.com/D22650
14778fd00dc5fd23d368e910a7f0d5428cdff623: Bug 1530937 part 12 - Convert remaining inline callVMs in CodeGenerator.cpp. r=tcampbell
Jan de Mooij <jdemooij@mozilla.com> - Fri, 08 Mar 2019 14:56:38 +0000 - rev 524055
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1530937 part 12 - Convert remaining inline callVMs in CodeGenerator.cpp. r=tcampbell * Moves NewArrayWithGroup from CodeGenerator.cpp to builtin/Array.cpp * GetProperty has various overloads so I added GetValueProperty. I considered *renaming* that GetProperty overload to GetValueProperty but there are quite a lot of callers in VM code where GetProperty is probably closer to the spec language. * Ion called js::GetElement and js::CallElement which forwarded to GetElementOperation. This was changed to call GetElementOperation directly (eliminates a VM wrapper). Depends on D22677 Differential Revision: https://phabricator.services.mozilla.com/D22678
b49300f6cc1fc2411be9031f765f240099ec715f: Bug 1530937 part 11 - Convert even more callVMs in CodeGenerator.cpp. r=tcampbell
Jan de Mooij <jdemooij@mozilla.com> - Fri, 08 Mar 2019 14:52:16 +0000 - rev 524054
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1530937 part 11 - Convert even more callVMs in CodeGenerator.cpp. r=tcampbell Differential Revision: https://phabricator.services.mozilla.com/D22677
2a58c63890ccdbbeb846c45dea03cf35b566ebdc: Bug 1523642: Improve Ion-generated code for Array.prototype.reduce[Right]. r=tcampbell
André Bargull <andre.bargull@gmail.com> - Tue, 29 Jan 2019 07:38:06 -0800 - rev 523631
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1523642: Improve Ion-generated code for Array.prototype.reduce[Right]. r=tcampbell
e50966a892bdf92398567c99d4ad945b9df8e9f3: Bug 1530937 part 9 - Convert callVMs for Ion IC fallback functions. r=tcampbell
Jan de Mooij <jdemooij@mozilla.com> - Wed, 06 Mar 2019 17:03:15 +0000 - rev 523515
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1530937 part 9 - Convert callVMs for Ion IC fallback functions. r=tcampbell Differential Revision: https://phabricator.services.mozilla.com/D22284
7dc59aadcb9d3e6b9698f0a6e1b0813f2502baa9: Bug 1530937 part 3 - Convert more callVMs in BaselineCompiler. r=tcampbell
Jan de Mooij <jdemooij@mozilla.com> - Fri, 01 Mar 2019 20:49:29 +0000 - rev 523020
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1530937 part 3 - Convert more callVMs in BaselineCompiler. r=tcampbell InitGetterSetterOperation had multiple overloads, I renamed them to InitPropGetterSetterOperation and InitElemGetterSetterOperation. Differential Revision: https://phabricator.services.mozilla.com/D21686
756272e36e32264332e6b95aa804b69581295c7e: Bug 1530937 part 2 - Add new VMFunction mechanism and use it for some Baseline callVMs. r=nbp,tcampbell
Jan de Mooij <jdemooij@mozilla.com> - Thu, 28 Feb 2019 12:31:01 +0000 - rev 522597
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1530937 part 2 - Add new VMFunction mechanism and use it for some Baseline callVMs. r=nbp,tcampbell We are doing this to: 1) Eliminate (hundreds of) static constructors. These account for a significant fraction of all remaining static constructors in Gecko. 2) Use constexpr for VMFunction data. This was not possible with the linked list but the new design stores all data in a constexpr array. This will save a few KB per process. 3) Make it easier to define a new VMFunction. 4) Coalesce duplicate VMFunction copies in Baseline/Ion/ICs. 5) Get rid of the (read-only) HashMap for the VMFunction => code lookup. We can use a Vector instead. 6) Make it easier in the future to generate the wrappers at compile time. This patch will let us incrementally convert the remaining VM functions. The only thing not handled by this patch is support for the TailCall and extraValuesToPop fields. We can do this when we convert the Baseline IC code that uses these fields. Once all VM functions have been converted we can remove and simplify more code. Differential Revision: https://phabricator.services.mozilla.com/D21332
b8712597ac579317f0ac45072cf007e654655be5: Bug 1526024 - Handle rcx as a destination register r=tcampbell
Matthew Gaudet <mgaudet@mozilla.com> - Wed, 27 Feb 2019 14:31:36 +0000 - rev 522323
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1526024 - Handle rcx as a destination register r=tcampbell Also add unit tests Differential Revision: https://phabricator.services.mozilla.com/D19077
87514c3aaa3a9bd26879cc7fdf5e3c96de948854: Bug 1526024 - Handle rcx as a destination register r=tcampbell
Matthew Gaudet <mgaudet@mozilla.com> - Tue, 26 Feb 2019 19:49:17 +0000 - rev 522126
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1526024 - Handle rcx as a destination register r=tcampbell Also add unit tests Differential Revision: https://phabricator.services.mozilla.com/D19077
7f6e5294fb0fc1314d2f56de6c6423937cfd0a93: Bug 1454862 - Enable compaction for BigInt values r=tcampbell,jonco
Andy Wingo <wingo@igalia.com> - Mon, 25 Feb 2019 15:28:42 +0000 - rev 521781
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1454862 - Enable compaction for BigInt values r=tcampbell,jonco Differential Revision: https://phabricator.services.mozilla.com/D20986
29f06630e00e44ef1723813a38833dce52aea239: Bug 1524419: Incrementally touch stack on arm64 r=tcampbell
Matthew Gaudet <mgaudet@mozilla.com> - Mon, 25 Feb 2019 13:58:15 +0000 - rev 521773
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1524419: Incrementally touch stack on arm64 r=tcampbell Differential Revision: https://phabricator.services.mozilla.com/D19992
241d2964ae968a01928f5e8e4d734781fad1a546: Bug 1528320 - Ensure correct record/replay progress flag after XDR-decoding a script, r=tcampbell.
Brian Hackett <bhackett1024@gmail.com> - Thu, 21 Feb 2019 17:32:59 -1000 - rev 521583
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1528320 - Ensure correct record/replay progress flag after XDR-decoding a script, r=tcampbell.
836b8cf19a9806c374b5712f6061006e72dba245: Bug 1529701 - Fix wrong bug number in a comment in a test configuration file. r=tcampbell
Jason Orendorff <jorendorff@mozilla.com> - Fri, 22 Feb 2019 00:00:57 +0000 - rev 521362
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529701 - Fix wrong bug number in a comment in a test configuration file. r=tcampbell Differential Revision: https://phabricator.services.mozilla.com/D20722
c23dbcea5508a173b9d7d5cf265110763fc15943: Bug 1528980 - [tryselect] Print host:port before running the trychooser flask app, r=tcampbell
Andrew Halberstadt <ahalberstadt@mozilla.com> - Thu, 21 Feb 2019 19:45:57 +0000 - rev 521195
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1528980 - [tryselect] Print host:port before running the trychooser flask app, r=tcampbell I'm not really sure why Flask isn't printing this for us, but it's not worth investigating when the alternative is so easy. Differential Revision: https://phabricator.services.mozilla.com/D20712
133c2fc80e9cbd47a8c03b6054e0458a0d67d211: Bug 1528320 - Ensure correct record/replay progress flag after XDR-decoding a script, r=tcampbell.
Brian Hackett <bhackett1024@gmail.com> - Wed, 20 Feb 2019 12:06:25 -1000 - rev 521063
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1528320 - Ensure correct record/replay progress flag after XDR-decoding a script, r=tcampbell.
ef3a903f83998034acb43924a423bf4d370ac382: Bug 1528028 - Remove obsolete Shark profiling support r=tcampbell
Matthew Gaudet <mgaudet@mozilla.com> - Tue, 19 Feb 2019 19:56:48 +0000 - rev 520822
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1528028 - Remove obsolete Shark profiling support r=tcampbell Differential Revision: https://phabricator.services.mozilla.com/D20323
2d4f87a0212e0a57e8ed39ebe9516a18b4e4ef3e: Bug 1527861: Allow disabling BinAST compilation; r=tcampbell
Benjamin Bouvier <benj@benj.me> - Thu, 14 Feb 2019 11:52:57 +0100 - rev 520415
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1527861: Allow disabling BinAST compilation; r=tcampbell Differential Revision: https://phabricator.services.mozilla.com/D19765
9b436568b978ab2f8f641bdb348ab3d9945e9fe8: Bug 1526947 - Simplify aliased var code in the JITs. r=tcampbell
Jan de Mooij <jdemooij@mozilla.com> - Thu, 14 Feb 2019 12:00:30 +0000 - rev 519907
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1526947 - Simplify aliased var code in the JITs. r=tcampbell Environment shapes always use the max number of fixed slots before using dynamic slots (see EmptyEnvironmentShape). We can take advantage of this in the JITs and eliminate the calls to EnvironmentCoordinateToEnvironmentShape. Differential Revision: https://phabricator.services.mozilla.com/D19361
9b872b266b2ed7aabac64d2f6ccc394277dbaaf3: Bug 1525876: Move ENABLE_WASM_CRANELIFT build test in the wasm mozbuild; r=tcampbell
Benjamin Bouvier <benj@benj.me> - Wed, 13 Feb 2019 13:52:07 +0000 - rev 519783
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1525876: Move ENABLE_WASM_CRANELIFT build test in the wasm mozbuild; r=tcampbell Differential Revision: https://phabricator.services.mozilla.com/D19648
4c4f5992c89e31b32a14df8663d9ff1a71f326a0: Bug 1526451 - Disable unboxed objects by default r=jandem,tcampbell
Matthew Gaudet <mgaudet@mozilla.com> - Mon, 11 Feb 2019 11:55:20 +0000 - rev 519359
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1526451 - Disable unboxed objects by default r=jandem,tcampbell Differential Revision: https://phabricator.services.mozilla.com/D19197
39e1b87c1decf4a69c51f3faef0fbe3bee17742f: Bug 1524752 - Assert cx and function are same-compartment in JSFunction::createScriptForLazilyInterpretedFunction. r=tcampbell
Jan de Mooij <jdemooij@mozilla.com> - Fri, 08 Feb 2019 15:28:02 +0000 - rev 519329
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1524752 - Assert cx and function are same-compartment in JSFunction::createScriptForLazilyInterpretedFunction. r=tcampbell It seems a bit nicer/safer to require the caller to enter the correct realm/compartment in the cross-compartment case. Differential Revision: https://phabricator.services.mozilla.com/D18968
3c6fcec3f2b21a25ca79f6532e7a1ce7afb1cf96: Bug 1522837 part 9 - Update framePushed after Baseline VM call. r=tcampbell
Jan de Mooij <jdemooij@mozilla.com> - Fri, 08 Feb 2019 09:55:32 +0000 - rev 519110
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1522837 part 9 - Update framePushed after Baseline VM call. r=tcampbell The Baseline compiler apparently doesn't depend on this but the interpreter needs framePushed to be correct. Differential Revision: https://phabricator.services.mozilla.com/D18251
cd460d5c95f9f34d175f0342b56042f7382dcea1: Bug 1524499 part 4 - Some minor changes to address review feedback. r=tcampbell
Jan de Mooij <jdemooij@mozilla.com> - Wed, 06 Feb 2019 07:57:34 +0000 - rev 518274
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1524499 part 4 - Some minor changes to address review feedback. r=tcampbell Differential Revision: https://phabricator.services.mozilla.com/D18569
71b541173043dfb9ab7f58b8438374d3c7466cb1: Bug 1524499 part 3 - Move HasFreezeConstraints and TypesGeneration flags from JSScript to TypeScript. r=tcampbell
Jan de Mooij <jdemooij@mozilla.com> - Wed, 06 Feb 2019 07:57:09 +0000 - rev 518273
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1524499 part 3 - Move HasFreezeConstraints and TypesGeneration flags from JSScript to TypeScript. r=tcampbell This is pretty straight-forward now and it's much nicer to encapsulate this in TypeScript instead of having these types-related flags in JSScript. Differential Revision: https://phabricator.services.mozilla.com/D18550
936d2328fb864d10c086729bc3105d115430009b: Bug 1524499 part 2 - Move the AutoSweepTypeScript& from JSScript::types() to TypeScript methods that depend on swept data. r=tcampbell
Jan de Mooij <jdemooij@mozilla.com> - Wed, 06 Feb 2019 07:56:49 +0000 - rev 518272
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1524499 part 2 - Move the AutoSweepTypeScript& from JSScript::types() to TypeScript methods that depend on swept data. r=tcampbell As we add more fields to TypeScript (= JitScript in the future), the AutoSweepTypeScript argument to JSScript::types() is becoming annoying. This patch moves the argument to TypeScript::typeArray() and TypeScript::inlinedCompilations() because that's the data affected by type sweeping. Differential Revision: https://phabricator.services.mozilla.com/D18549
fdc01631d226da0960703451ed2045853658304c: Bug 1524499 part 1 - Move active flag from BaselineScript to TypeScript. r=tcampbell
Jan de Mooij <jdemooij@mozilla.com> - Wed, 06 Feb 2019 07:56:17 +0000 - rev 518271
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1524499 part 1 - Move active flag from BaselineScript to TypeScript. r=tcampbell Baseline interpreter frames will have a TypeScript/ICScript we want to keep around on GC. The JSScript::typesDontCheckGeneration method will be removed in the next patch. Differential Revision: https://phabricator.services.mozilla.com/D18548
9efa9bce49d30ac11cfca09aacc53afd6bb5eefa: Bug 1522837 part 8 - Implement JSOP_GETIMPORT in BaselineInterpreterCodeGen. r=tcampbell
Jan de Mooij <jdemooij@mozilla.com> - Wed, 06 Feb 2019 07:55:25 +0000 - rev 518265
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1522837 part 8 - Implement JSOP_GETIMPORT in BaselineInterpreterCodeGen. r=tcampbell Eventually this op could use an IC or some frontend/bytecode refactoring to make it faster in the interpreter. For now following the C++ interpreter is the simplest solution though. Differential Revision: https://phabricator.services.mozilla.com/D17939
1ef95148918d62198d4acb69c342d60fe0eae802: Bug 1522837 part 7 - Implement JSOP_NEWARRAY_COPYONWRITE in BaselineInterpreterCodeGen. r=tcampbell
Jan de Mooij <jdemooij@mozilla.com> - Wed, 06 Feb 2019 07:54:47 +0000 - rev 518264
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1522837 part 7 - Implement JSOP_NEWARRAY_COPYONWRITE in BaselineInterpreterCodeGen. r=tcampbell Differential Revision: https://phabricator.services.mozilla.com/D17938
62202236497ff7aff78efb9f275e13db96668c4f: Bug 1522837 part 6 - Implement JSOP_BUILTINPROTO in BaselineInterpreterCodeGen. r=tcampbell
Jan de Mooij <jdemooij@mozilla.com> - Wed, 06 Feb 2019 07:53:44 +0000 - rev 518263
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1522837 part 6 - Implement JSOP_BUILTINPROTO in BaselineInterpreterCodeGen. r=tcampbell Differential Revision: https://phabricator.services.mozilla.com/D17937
bf42d78396ab04b36145a9332c19feb2cd54d57d: Bug 1522837 part 5 - Implement JSOP_IMPORTMETA in BaselineInterpreterCodeGen. r=tcampbell
Jan de Mooij <jdemooij@mozilla.com> - Wed, 06 Feb 2019 07:52:43 +0000 - rev 518262
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1522837 part 5 - Implement JSOP_IMPORTMETA in BaselineInterpreterCodeGen. r=tcampbell Differential Revision: https://phabricator.services.mozilla.com/D17936
8d112cd492e7443a9a3225425c798f8093c75c98: Bug 1522837 part 4 - Implement JSOP_CALLSITEOBJ in BaselineInterpreterCodeGen. r=tcampbell
Jan de Mooij <jdemooij@mozilla.com> - Sun, 03 Feb 2019 10:08:41 +0000 - rev 517466
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1522837 part 4 - Implement JSOP_CALLSITEOBJ in BaselineInterpreterCodeGen. r=tcampbell This is just a VM call in the interpreter. We could optimize this with an IC or inline path if it ever becomes a problem. Differential Revision: https://phabricator.services.mozilla.com/D17935
56d070f54c699b2ecc88500921c15459f161dcce: Bug 1522837 part 3 - Refactor JSOP_OBJECT in BaselineCodeGen. r=tcampbell
Jan de Mooij <jdemooij@mozilla.com> - Sun, 03 Feb 2019 10:07:31 +0000 - rev 517465
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1522837 part 3 - Refactor JSOP_OBJECT in BaselineCodeGen. r=tcampbell This adds js::SingletonObjectLiteralOperation and calls it from both the interpreter and Baseline. The Baseline compiler still has a fast path for the cloning-not-necessary case. Differential Revision: https://phabricator.services.mozilla.com/D17934
aea9bf1be0da2f1f1746b5d5f398c9cd50cb853c: Bug 1522837 part 2 - Implement subtractScriptSlotsSize, loadGlobalLexicalEnvironment, loadGlobalThisValue, pushScriptArg. r=tcampbell
Jan de Mooij <jdemooij@mozilla.com> - Sun, 03 Feb 2019 10:07:01 +0000 - rev 517464
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1522837 part 2 - Implement subtractScriptSlotsSize, loadGlobalLexicalEnvironment, loadGlobalThisValue, pushScriptArg. r=tcampbell Differential Revision: https://phabricator.services.mozilla.com/D17645