searching for reviewer(sylvestre)
ebb01d9ac1c94b9ea2a0eee174a2f80d267035c1: Backed out changeset d716b75b8ac3 (bug 1549010). a=sylvestre CLOSED TREE
Tom Prince <mozilla@hocat.ca> - Sat, 04 May 2019 04:31:07 -0600 - rev 526489
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Backed out changeset d716b75b8ac3 (bug 1549010). a=sylvestre CLOSED TREE
2a96d8f9339f49e84789bbe3899699c5d7185406: Bug 1529504 - Fix two flake8 warnings in static analysis (mach_commands.py) r=sylvestre
Alvaro Serero <alvaroserero@gmail.com> - Sat, 16 Mar 2019 11:53:50 +0100 - rev 525384
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529504 - Fix two flake8 warnings in static analysis (mach_commands.py) r=sylvestre
a6cadf50156abc924d17e7e4bdc554d50915c5f4: Bug 1528643 - Fix mach clang-format -c in mercurial. r=sylvestre
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 18 Feb 2019 08:13:45 +0000 - rev 520615
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1528643 - Fix mach clang-format -c in mercurial. r=sylvestre Turns out hg diff works differently, and when Miko tried to use this option last week he realized it didn't work quite as expected. Differential Revision: https://phabricator.services.mozilla.com/D20102
b59977d42a4ddedaee1f431b2c1725c2d64ca723: Bug 1521772: Run clang-format in parallel; r=sylvestre
Benjamin Bouvier <benj@benj.me> - Fri, 15 Feb 2019 16:32:48 +0000 - rev 520444
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1521772: Run clang-format in parallel; r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D19943
a273edea702d8bdfc7a5152160fac49a17902671: Bug 1527286 - For 'mach clang-format' don't pass files that we don't exist on the disk. r=sylvestre
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Tue, 12 Feb 2019 12:54:22 +0000 - rev 519555
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1527286 - For 'mach clang-format' don't pass files that we don't exist on the disk. r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D19481
5f4630838d46dd81dadb13220a4af0da9e23a619: Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre
Ehsan Akhgari <ehsan@mozilla.com> - Fri, 18 Jan 2019 10:16:18 +0100 - rev 514505
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre # ignore-this-changeset
9916e7d6e32720362fd18ed03f1acff4884b86df: Bug 1521000 - Part 1: Reformat the tree to ensure everything is formatted correctly with clang-format r=sylvestre
Ehsan Akhgari <ehsan@mozilla.com> - Fri, 18 Jan 2019 10:12:56 +0100 - rev 514504
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1521000 - Part 1: Reformat the tree to ensure everything is formatted correctly with clang-format r=sylvestre Summary: # ignore-this-changeset Reviewers: sylvestre Reviewed By: sylvestre Subscribers: reviewbot, emilio, jandem, bbouvier, karlt, jya Bug #: 1521000 Differential Revision: https://phabricator.services.mozilla.com/D16936
3bd12b1d762b4079ddefbe86012a88e0704d6734: Bug 1518959 - Don't format Java files by default; r=sylvestre
Ehsan Akhgari <ehsan@mozilla.com> - Thu, 10 Jan 2019 09:05:54 +0000 - rev 513205
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1518959 - Don't format Java files by default; r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D16115
0b5954be5426443fb44de34e43da0a12e46252d7: Bug 1514341 - mach clang-format - fix path on windows. r=sylvestre
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Sat, 15 Dec 2018 07:24:18 +0000 - rev 510817
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1514341 - mach clang-format - fix path on windows. r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D14605
2f15c3366bf0c1993c63c46e3e3efc4a2c9a4842: Bug 1511536 - Restore the comment in nsCSSFrameConstructor::ConstructBlock(), and disable clang-format. r=sylvestre
Ting-Yu Lin <tlin@mozilla.com> - Sat, 01 Dec 2018 13:48:45 +0000 - rev 508305
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1511536 - Restore the comment in nsCSSFrameConstructor::ConstructBlock(), and disable clang-format. r=sylvestre The example frame tree didn't survive the global clang-format change. DONTBUILD because this is a comment-only change. Differential Revision: https://phabricator.services.mozilla.com/D13602
e4712449ba4303cef134ba0b3f1bea13fbd50c4a: Bug 1511383: Update vim modelines after clang-format; r=sylvestre
Benjamin Bouvier <benj@benj.me> - Fri, 30 Nov 2018 16:39:55 +0100 - rev 508244
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1511383: Update vim modelines after clang-format; r=sylvestre - modify line wrap up to 80 chars; (tw=80) - modify size of tab to 2 chars everywhere; (sts=2, sw=2)
3acb179a17592b5f9a64cb30e0c6554b640d0a46: Bug 1511319 - Ensure that tools/clang-tidy/test doesn't get reformatted using clang-format; r=sylvestre a=Aryx
Ehsan Akhgari <ehsan@mozilla.com> - Fri, 30 Nov 2018 06:32:29 -0500 - rev 508165
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1511319 - Ensure that tools/clang-tidy/test doesn't get reformatted using clang-format; r=sylvestre a=Aryx Reformatting this directory can break some of the tests here. Differential Revision: https://phabricator.services.mozilla.com/D13518
9094a8f08747e68db0d406b2abd2fc993a3ce0d6: Bug 1511176 - Ignore the files used to generate the windows.h STL wrapper in clang-format r=sylvestre
Ehsan Akhgari <ehsan@mozilla.com> - Thu, 29 Nov 2018 21:22:51 +0000 - rev 508073
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1511176 - Ignore the files used to generate the windows.h STL wrapper in clang-format r=sylvestre Not doing so causes builds to break. Differential Revision: https://phabricator.services.mozilla.com/D13469
2449004c31ffceacbcc306b813458dd31fd8505d: Bug 1510535 - Restore a few lines in .clang-format-ignore. r=tcampbell,sylvestre
Jan de Mooij <jdemooij@mozilla.com> - Wed, 28 Nov 2018 09:33:44 +0100 - rev 507945
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1510535 - Restore a few lines in .clang-format-ignore. r=tcampbell,sylvestre Differential Revision: https://phabricator.services.mozilla.com/D13205
04f0bbf40bf36957dc1f72a8aae9916df0e3222f: Bug 1508472 - Part 5: Fifth batch of comment fix-ups in preparation for the tree reformat r=sylvestre
Ehsan Akhgari <ehsan@mozilla.com> - Thu, 29 Nov 2018 10:30:46 +0000 - rev 507921
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1508472 - Part 5: Fifth batch of comment fix-ups in preparation for the tree reformat r=sylvestre This is a best effort attempt at ensuring that the adverse impact of reformatting the entire tree over the comments would be minimal. I've used a combination of strategies including disabling of formatting, some manual formatting and some changes to formatting to work around some clang-format limitations. Differential Revision: https://phabricator.services.mozilla.com/D13371
4ecb983c1655f18460d61dde1e5a06dd2b5d04cb: Bug 1510893 - Add the wayland-scanner generated source files to .clang-format-ignore r=sylvestre
Ehsan Akhgari <ehsan@mozilla.com> - Thu, 29 Nov 2018 08:25:42 +0000 - rev 507911
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1510893 - Add the wayland-scanner generated source files to .clang-format-ignore r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D13363
50d1e014826fe3fab1a41c77cd865934321137d1: Bug 1510787 - Add security/sandbox/chromium-shim/ to the list of third-party sources r=sylvestre
Ehsan Akhgari <ehsan@mozilla.com> - Thu, 29 Nov 2018 08:25:27 +0000 - rev 507910
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1510787 - Add security/sandbox/chromium-shim/ to the list of third-party sources r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D13318
cc9977714e0350a41de8a0b8a19aa5ad97873255: Bug 1510765 - Add netwerk/dns/nsIDNKitInterface.h to the list of third-party sources r=sylvestre
Ehsan Akhgari <ehsan@mozilla.com> - Thu, 29 Nov 2018 08:25:04 +0000 - rev 507909
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1510765 - Add netwerk/dns/nsIDNKitInterface.h to the list of third-party sources r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D13306
85b68ee430dc5b8ec21663ecfd00e4b14e80b944: Bug 1510637 - mach clang-format: when using --assume-filename we don't want to download the actual clang-tools package. r=sylvestre
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Wed, 28 Nov 2018 21:32:05 +0000 - rev 507791
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1510637 - mach clang-format: when using --assume-filename we don't want to download the actual clang-tools package. r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D13254
b4662b6db1b34414494d070e33481193625403d1: Bug 1508472 - Part 4: Fourth batch of comment fix-ups in preparation for the tree reformat r=sylvestre
Ehsan Akhgari <ehsan@mozilla.com> - Wed, 28 Nov 2018 09:16:55 +0000 - rev 507697
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1508472 - Part 4: Fourth batch of comment fix-ups in preparation for the tree reformat r=sylvestre This is a best effort attempt at ensuring that the adverse impact of reformatting the entire tree over the comments would be minimal. I've used a combination of strategies including disabling of formatting, some manual formatting and some changes to formatting to work around some clang-format limitations. Differential Revision: https://phabricator.services.mozilla.com/D13193
628d20bae43fbdfcf6ec3cee2c34cf3dd42626a6: Bug 1510513 - Retain the formatting of MOZ_DEFINE_ENUM_* macros r=sylvestre
Ehsan Akhgari <ehsan@mozilla.com> - Wed, 28 Nov 2018 09:14:19 +0000 - rev 507696
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1510513 - Retain the formatting of MOZ_DEFINE_ENUM_* macros r=sylvestre These macros tend to be handled quite poorly since the clang-format tokenizer cannot figure out how to handle them. Differential Revision: https://phabricator.services.mozilla.com/D13179
5992e36db33e3a7cd79de87fea30dfede2a5a1ef: Bug 1510526 - Add a few autogenerated files to .clang-format-ignore r=sylvestre
Ehsan Akhgari <ehsan@mozilla.com> - Wed, 28 Nov 2018 07:40:30 +0000 - rev 507694
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1510526 - Add a few autogenerated files to .clang-format-ignore r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D13194
2d8ce84e0107c99974201c1b67864786b22f3ff8: Bug 1508472 - Part 2: Second batch of comment fix-ups in preparation for the tree reformat r=sylvestre
Ehsan Akhgari <ehsan@mozilla.com> - Wed, 28 Nov 2018 00:54:56 +0000 - rev 507616
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1508472 - Part 2: Second batch of comment fix-ups in preparation for the tree reformat r=sylvestre This is a best effort attempt at ensuring that the adverse impact of reformatting the entire tree over the comments would be minimal. I've used a combination of strategies including disabling of formatting, some manual formatting and some changes to formatting to work around some clang-format limitations. Differential Revision: https://phabricator.services.mozilla.com/D13073
2320933cb7bc8255b7e484df1ef27718154362d5: Bug 1508472 - Part 2: Second batch of comment fix-ups in preparation for the tree reformat r=sylvestre
Ehsan Akhgari <ehsan@mozilla.com> - Tue, 27 Nov 2018 21:36:18 +0000 - rev 507594
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1508472 - Part 2: Second batch of comment fix-ups in preparation for the tree reformat r=sylvestre This is a best effort attempt at ensuring that the adverse impact of reformatting the entire tree over the comments would be minimal. I've used a combination of strategies including disabling of formatting, some manual formatting and some changes to formatting to work around some clang-format limitations. Differential Revision: https://phabricator.services.mozilla.com/D13073
11d6688b953f800e234162bc8ed5842954de087f: Bug 1508472 - Part 2: Second batch of comment fix-ups in preparation for the tree reformat r=sylvestre
Ehsan Akhgari <ehsan@mozilla.com> - Tue, 27 Nov 2018 15:18:32 +0000 - rev 507537
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1508472 - Part 2: Second batch of comment fix-ups in preparation for the tree reformat r=sylvestre This is a best effort attempt at ensuring that the adverse impact of reformatting the entire tree over the comments would be minimal. I've used a combination of strategies including disabling of formatting, some manual formatting and some changes to formatting to work around some clang-format limitations. Differential Revision: https://phabricator.services.mozilla.com/D13073
fb09acfff1684500e989acc798e97fa7f9358dc0: Bug 1508472 - Part 1: First batch of comment fix-ups in preparation for the tree reformat r=sylvestre
Ehsan Akhgari <ehsan@mozilla.com> - Tue, 27 Nov 2018 10:08:58 +0000 - rev 507432
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1508472 - Part 1: First batch of comment fix-ups in preparation for the tree reformat r=sylvestre This is a best effort attempt at ensuring that the adverse impact of reformatting the entire tree over the comments would be minimal. I've used a combination of strategies including disabling of formatting, some manual formatting and some changes to formatting to work around some clang-format limitations. Differential Revision: https://phabricator.services.mozilla.com/D13046
c0b875613aa06ed1aeb02dab655378510f2a7dca: Bug 1510130 - Update the third-party directories under media with reality r=sylvestre
Ehsan Akhgari <ehsan@mozilla.com> - Tue, 27 Nov 2018 10:07:13 +0000 - rev 507431
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1510130 - Update the third-party directories under media with reality r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D13045
e23d7926d41ee7dfcaf5fafd46cb13f4ca2152f0: Bug 1510126 - Add tools/profiler/core/vtune to the list of third-party directories r=sylvestre
Ehsan Akhgari <ehsan@mozilla.com> - Tue, 27 Nov 2018 10:06:53 +0000 - rev 507430
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1510126 - Add tools/profiler/core/vtune to the list of third-party directories r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D13044
9f44e47ef7b33c059d076f81bac45dd7e528ce15: Bug 1510124 - Ignore files generated by protobuf in the tree r=sylvestre
Ehsan Akhgari <ehsan@mozilla.com> - Tue, 27 Nov 2018 10:06:05 +0000 - rev 507429
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1510124 - Ignore files generated by protobuf in the tree r=sylvestre These are autogenerated files so we shouldn't try to reformat them. Differential Revision: https://phabricator.services.mozilla.com/D13043
5d83d28c9ae59e31271fc400de7a63f0221a0ebe: Bug 1509025 - Remove js/src/jsapi-tests from .clang-format-ignore. r=sylvestre,tcampbell
Jan de Mooij <jdemooij@mozilla.com> - Thu, 22 Nov 2018 14:51:50 +0000 - rev 506920
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1509025 - Remove js/src/jsapi-tests from .clang-format-ignore. r=sylvestre,tcampbell Differential Revision: https://phabricator.services.mozilla.com/D12630
a22ad02cbdcc24eaf3cb62ed1436da87d6f1dacb: Bug 1509276 - mach static-analysis install - should accept more flags in order to make it more robust. r=sylvestre
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Thu, 22 Nov 2018 10:47:52 +0000 - rev 506911
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1509276 - mach static-analysis install - should accept more flags in order to make it more robust. r=sylvestre Depends on D12599 Differential Revision: https://phabricator.services.mozilla.com/D12635
fd219dda36e80a8da14f65c11db66f42c4d31982: Bug 1508635 - mach clang-format should be able to print back the file that has been reformatted to stdin, suitable when it ise used with 3rd party tools for merging. r=sylvestre
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Thu, 22 Nov 2018 10:47:50 +0000 - rev 506910
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1508635 - mach clang-format should be able to print back the file that has been reformatted to stdin, suitable when it ise used with 3rd party tools for merging. r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D12599
ab5ae5f1e381afd603d9b3032c7705a4f620bfdb: Bug 1508176 - Some clang-format fixes for generated unicode files. r=tcampbell,sylvestre
Jan de Mooij <jdemooij@mozilla.com> - Wed, 21 Nov 2018 18:30:44 +0000 - rev 506824
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1508176 - Some clang-format fixes for generated unicode files. r=tcampbell,sylvestre * Add generated files to .clang-format-ignore. * Remove the "clang-format off/on" annotations from generated files. * Rename FOR_EACH_NON_BMP_CASE_FOLDING argument from macro to MACRO. See bug 1508180. Differential Revision: https://phabricator.services.mozilla.com/D12536
2d8d64aff05a9af6af00a99c7922b86ad9d1bb55: Bug 1508255 - Merge js/src/.clang-format into top-level r=sylvestre
Ted Campbell <tcampbell@mozilla.com> - Tue, 20 Nov 2018 12:42:30 +0000 - rev 506454
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1508255 - Merge js/src/.clang-format into top-level r=sylvestre The style options now match, so remove js/src/.clang-format \o/ Depends on D12391 Differential Revision: https://phabricator.services.mozilla.com/D12392
ba714acdc402d7ab9524874bfeed78fd9517a9cc: Bug 1508270 - Add libwebp to the list of thirdparty code. r=sylvestre
Andrew Osmond <aosmond@mozilla.com> - Mon, 19 Nov 2018 09:57:43 -0500 - rev 506311
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1508270 - Add libwebp to the list of thirdparty code. r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D12296
e92a6ab741287f97ba8dd35f631e1a4c37097160: Bug 1508067 - Use clang-format off in vm/Opcodes.h instead of file ignore. r=sylvestre,jandem
Ted Campbell <tcampbell@mozilla.com> - Mon, 19 Nov 2018 09:27:17 +0000 - rev 506246
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1508067 - Use clang-format off in vm/Opcodes.h instead of file ignore. r=sylvestre,jandem Differential Revision: https://phabricator.services.mozilla.com/D12240
eb04ab1f698a06f6f9eb58b212dab59d5e1828cd: Bug 1508160 - Add JS_BEGIN_MACRO to .clang-format r=sylvestre
Ted Campbell <tcampbell@mozilla.com> - Sun, 18 Nov 2018 19:54:59 +0000 - rev 506155
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1508160 - Add JS_BEGIN_MACRO to .clang-format r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D12226
95bc945b6cd66c8adb0ac60f938d40e37774dd9a: Bug 1500241 - [Clang-Tidy] Disable 'readability-implicit-bool-conversion' check. r=sylvestre
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Tue, 30 Oct 2018 17:11:55 +0000 - rev 502766
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1500241 - [Clang-Tidy] Disable 'readability-implicit-bool-conversion' check. r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D10264
1635530c393a0f80512a3cf695fe968eb53562f2: Bug 1375861 - [mozlint] Globally exclude paths listed in tools/rewriting/ThirdPartyPaths.txt from our linters, r=sylvestre
Andrew Halberstadt <ahalberstadt@mozilla.com> - Thu, 18 Oct 2018 15:27:59 +0000 - rev 500432
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1375861 - [mozlint] Globally exclude paths listed in tools/rewriting/ThirdPartyPaths.txt from our linters, r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D9126
33692f367564122728279498617718bbc235e542: Bug 1479298 - [Static-Analysis][Clang-Based] Implement the passing of configuration flags to checkers in the configuration file. r=sylvestre
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Wed, 10 Oct 2018 08:01:24 +0000 - rev 498969
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1479298 - [Static-Analysis][Clang-Based] Implement the passing of configuration flags to checkers in the configuration file. r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D7997
a243b88f852a73cc9ef3ca1ac9caa4665900da0e: Bug 1487321 - [Static-Analysis][Clang-Tidy] Add new checkers present in 7.0. r=sylvestre
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Tue, 02 Oct 2018 14:10:32 +0000 - rev 497840
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1487321 - [Static-Analysis][Clang-Tidy] Add new checkers present in 7.0. r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D7045
741465cf8a3c4dba29d9079c8ac36a277c96c7e9: Bug 1492770 - Activate google-* checkers that make sense to our code. r=sylvestre
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Thu, 20 Sep 2018 15:29:32 +0000 - rev 496065
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1492770 - Activate google-* checkers that make sense to our code. r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D6391
1586964885f9449cfd189c41a684ebbaee433518: Bug 1485454 - [mozlint] Fix stylish formatter, issues without a column aren't indented enough, r=sylvestre
Andrew Halberstadt <ahalberstadt@mozilla.com> - Mon, 27 Aug 2018 13:40:34 +0000 - rev 491542
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1485454 - [mozlint] Fix stylish formatter, issues without a column aren't indented enough, r=sylvestre After fixing the absolute path issue in codespell, I noticed that the stylish formatter doesn't indent lint issues that don't have a column properly. This was never noticed before since most other linters have a column attribute. Depends on D4012 Differential Revision: https://phabricator.services.mozilla.com/D4013
cb3227f5156ca5b03e571b42ee50bac06713c6f8: Bug 1485454 - [lint] Use absolute paths with the codespell linter, r=sylvestre
Andrew Halberstadt <ahalberstadt@mozilla.com> - Wed, 29 Aug 2018 13:36:46 +0000 - rev 491538
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1485454 - [lint] Use absolute paths with the codespell linter, r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D4012
adbee46f307f7bc4617735c425398b3b87e9994e: Bug 1486729 - [Static-Analysis][Clang-Tidy] As default, a checker should be publish by default. r=sylvestre
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Wed, 29 Aug 2018 10:10:54 +0000 - rev 491524
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1486729 - [Static-Analysis][Clang-Tidy] As default, a checker should be publish by default. r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D4436
f664646a2e7c6554a738fe724c7a021fd9c591d7: Bug 1460856 - [mozlint] Suppress warnings by default r=Standard8,sylvestre
Andrew Halberstadt <ahalberstadt@mozilla.com> - Mon, 27 Aug 2018 13:39:46 +0000 - rev 491333
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1460856 - [mozlint] Suppress warnings by default r=Standard8,sylvestre As of this patch, any lint issue at the "warning" level will *only* be displayed if --warnings is passed in. This gives us some flexibility to track issues that are "recommended to fix" but that aren't required (aka don't cause a backout). I think it would be ideal if the reviewbot ran with warnings enabled, and CI ran without warnings. This way these issues will be surfaced to developers (and hopefully get fixed prior to landing), but developers will always be able to ignore them if the situation warrants it. Since the last change converted everything to use errors, this patch should be a no-op for now. However as we move forward (and potentially decide that certain types of lint issues should result in a backout), this feature will start seeing more and more use. Depends on D3820 Differential Revision: https://phabricator.services.mozilla.com/D3821
88fa28d336fa5ec92bc272682fb4ee9fe85c7487: Bug 1460856 - [mozlint] Encapsulate all result state in a ResultSummary class r=sylvestre
Andrew Halberstadt <ahalberstadt@mozilla.com> - Tue, 28 Aug 2018 13:51:04 +0000 - rev 491320
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1460856 - [mozlint] Encapsulate all result state in a ResultSummary class r=sylvestre Currently there are 3 things that can impact the result of a lint run: 1. The list of lint issues found 2. The set of failures that happened during the setup phase 3. The set of failures that happened during the execution phase All three of these things are stored as instance variables on the LintRoller object, and then passed into a formatter when it comes time to print the results. I'd like to add even more things that can impact the result, and it became clear that the current scenario does not scale well. This patch moves all data that could impact the end result of a lint run off of the LintRoller object and onto a new 'result.ResultSummary' class. To avoid confusion, this patch also renames the 'result.ResultContainer' class to 'result.Issue'. With this new nomenclature: result -> overall state of an entire lint run (can comprise multiple linters) issue -> one specific lint infraction (at either 'warning' or 'error' level) failure -> a non-recoverable error in the linter implementation itself A "result" is comprised of 0 or more "issues" and 0 or more "failures". Differential Revision: https://phabricator.services.mozilla.com/D3819
259675bd67f96acf1ae0f2ed6115de4331a94d32: Bug 1486502 - Add widevine CDM headers to third party paths, clang-format ignore. r=sylvestre
Bryce Van Dyk <bvandyk@mozilla.com> - Mon, 27 Aug 2018 16:25:54 +0000 - rev 491247
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1486502 - Add widevine CDM headers to third party paths, clang-format ignore. r=sylvestre We wish to keep the widevine headers in the same formatting as upstream to ease comparison and as we do not modify these files. This patch adds the existing headers, as well as another we anticipate pulling down for our next bump (content_decryption_module_proxy.h) to the ignored paths. These files are ignored individually rather than the whole directory they're in, as we also have Mozilla code in that dir. Differential Revision: https://phabricator.services.mozilla.com/D4347
e046ec0ce93d1b9d79c2c844b9135b03437f3f57: Bug 1483539 - [mozlint] Log a success message from the treeherder formatter when all lints succeed, r=sylvestre
Andrew Halberstadt <ahalberstadt@mozilla.com> - Wed, 15 Aug 2018 14:17:06 +0000 - rev 489837
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1483539 - [mozlint] Log a success message from the treeherder formatter when all lints succeed, r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D3415
bc15796e6fa77d268144f43427a9e388b6cbca91: Bug 1478644 - [Clang-Tidy] Synchronize run-clang-tidy output with the actual files that are being checked. r=sylvestre
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Thu, 26 Jul 2018 15:29:19 +0200 - rev 488967
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1478644 - [Clang-Tidy] Synchronize run-clang-tidy output with the actual files that are being checked. r=sylvestre MozReview-Commit-ID: LyfcV4oQwyw