searching for reviewer(spohl)
d52fac94f5077ee49700efe646b67a613761cda9: Bug 1546544 - Enable TCSM r=asuth,spohl,mccr8 a=abillings
Haik Aftandilian <haftandilian@mozilla.com> - Tue, 30 Apr 2019 14:01:20 -0700 - rev 526514
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1546544 - Enable TCSM r=asuth,spohl,mccr8 a=abillings
70403bae88b8486cd20c74c693ad85f79a030a00: Bug 1546544 - Enable TCSM. r=mccr8,asuth,spohl a=pascalc
Haik Aftandilian <haftandilian@mozilla.com> - Tue, 30 Apr 2019 14:01:20 -0700 - rev 526502
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1546544 - Enable TCSM. r=mccr8,asuth,spohl a=pascalc
a5641ee4b22773ce34c7aaab1201dca44cca42a2: Bug 1528490 - Reinstate corner clearing code which I overeagerly removed in bug 1491445. r=spohl
Markus Stange <mstange@themasta.com> - Thu, 07 Mar 2019 19:06:49 +0000 - rev 523897
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1528490 - Reinstate corner clearing code which I overeagerly removed in bug 1491445. r=spohl Differential Revision: https://phabricator.services.mozilla.com/D22560
ac2880eb346a750208311858fb858a01710149cb: Bug 1501543 - Misleading message when DisableAppUpdate is true but the system administrator updates Firefox in place. r=spohl,flod
phoenixabhishek <phoenixgyaan@gmail.com> - Tue, 05 Mar 2019 18:04:06 +0000 - rev 523334
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1501543 - Misleading message when DisableAppUpdate is true but the system administrator updates Firefox in place. r=spohl,flod Updated the message strings Differential Revision: https://phabricator.services.mozilla.com/D22124
a4bdd668c63799c218c76873591ddc72598f1fc1: Bug 469990: Allow command line arguments to be handed off from a new Firefox/Thunderbird process to an existing one when necessary. r=spohl
Yuri <mozilla@yuriydev.com> - Mon, 04 Mar 2019 09:58:47 -0500 - rev 523183
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 469990: Allow command line arguments to be handed off from a new Firefox/Thunderbird process to an existing one when necessary. r=spohl
04fb2d9beeaca0c1a3d69b69787c8878995f97ed: Bug 1501543 - Misleading message when DisableAppUpdate is true but the system administrator updates Firefox in place r=spohl,flod
phoenixabhishek <phoenixgyaan@gmail.com> - Mon, 25 Feb 2019 18:15:40 +0000 - rev 522645
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1501543 - Misleading message when DisableAppUpdate is true but the system administrator updates Firefox in place r=spohl,flod Changed text From: We have just installed an update in the background. To: Firefox has just been updated in the background. Differential Revision: https://phabricator.services.mozilla.com/D21019
77eb18940eb116616c0a8b5e252823879a4b3655: bug 1526004 - enterprise certs: differentiate between intermediates and roots on MacOS r=jcj,spohl
Dana Keeler <dkeeler@mozilla.com> - Fri, 22 Feb 2019 18:46:21 +0000 - rev 521520
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
bug 1526004 - enterprise certs: differentiate between intermediates and roots on MacOS r=jcj,spohl Differential Revision: https://phabricator.services.mozilla.com/D19721
6730f2c465272f6cca8aa247f2e3631fc1bf5165: Bug 1526797 - use file extension for finding helper apps for octet stream downloads on mac, r=spohl
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Thu, 14 Feb 2019 14:42:26 +0000 - rev 520201
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1526797 - use file extension for finding helper apps for octet stream downloads on mac, r=spohl
be263e3d8bdfc0b6c072ffad2736999b9652d036: Bug 1491445 - Make the ChildView always non-opaque and let NSVisualEffectView handle clearing of vibrant areas. r=spohl
Markus Stange <mstange@themasta.com> - Wed, 13 Feb 2019 18:51:20 +0000 - rev 519882
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1491445 - Make the ChildView always non-opaque and let NSVisualEffectView handle clearing of vibrant areas. r=spohl This is a clearer implementation that achieves the same thing. Moreover, disabling the clearing by overriding drawRect wouldn't work in CoreAnimation windows because in CoreAnimation windows, the clearing happens through a property of the NSVisualEffectView's CALayer, and not through the view's drawRect implementation - drawRect probably isn't even called in that context. Differential Revision: https://phabricator.services.mozilla.com/D19601
61be6672af50f4772f5c3277bee000d6dd3d44ce: Bug 1491445 - Move any drawing from the ChildView into a new subview called PixelHostingView. r=spohl
Markus Stange <mstange@themasta.com> - Wed, 13 Feb 2019 17:50:41 +0000 - rev 519881
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1491445 - Move any drawing from the ChildView into a new subview called PixelHostingView. r=spohl This has two advantages: - The drawing will now correctly be placed "on top" of the vibrancy views. - We can turn this new view into a layer-hosting view. Layer-hosting views are supposed to be leaf NSViews; they shouldn't have any children. Differential Revision: https://phabricator.services.mozilla.com/D19600
298b7fc66858c88b2918c4fc28074c3300c816a2: Bug 1491445 - Don't return YES from allowsVibrancy for the contentView of context menu windows. r=spohl
Markus Stange <mstange@themasta.com> - Wed, 13 Feb 2019 17:50:27 +0000 - rev 519880
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1491445 - Don't return YES from allowsVibrancy for the contentView of context menu windows. r=spohl Otherwise, any views inside the contentView are imbued with a vibrant effect, and even non-NSVisualEffectView NSViews subtract from the vibrant region of any actual vibrant views they overlap. This would cause the PixelHostingView to 'erase' the blue context menu item highlighting. This behavior is documented on NSVisualEffectView: > It is recommended that you enable vibrancy only in the leaf views of your view > hierarchy. Subviews inherit the vibrancy of their parent. Once enabled in a > parent view, a subview cannot turn off vibrancy. As a result, enabling > vibrancy in a parent view can lead to subviews that look incorrect if they are > not designed to take advantage of the vibrancy effect. Differential Revision: https://phabricator.services.mozilla.com/D19599
3507a9af7c90cd08ff79161156f1facffcb0b4f9: Bug 1491445 - Wrap vibrancy and nondraggable views inside container views. r=spohl
Markus Stange <mstange@themasta.com> - Wed, 13 Feb 2019 17:50:12 +0000 - rev 519879
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1491445 - Wrap vibrancy and nondraggable views inside container views. r=spohl NSView hierarchy before: - window contentView - ChildView - NonDraggableView 1 - NonDraggableView 2 - EffectViewWithoutForegroundVibrancy 1 - EffectViewWithoutForegroundVibrancy 2 NSView hierarchy after: - window contentView - ChildView - ViewRegionContainerView - NonDraggableView 1 - NonDraggableView 2 - ViewRegionContainerView - EffectViewWithoutForegroundVibrancy 1 - EffectViewWithoutForegroundVibrancy 2 This allows us to give those container views a new sibling view which stays fixed in z-order with respect to the NSViews that get created by mNonDraggableRegion and mVibrancyManager. More specifically, I'm going to add a view for the drawing of our ChildView ("PixelHostingView") which is going to be a direct child of the Gecko "ChildView" and a sibling of the ViewRegionContainerViews; the PixelHostingView needs to always stay on top of the vibrancy views. Without the wrapper around the vibrancy views, whenever the vibrant region changes, a vibrant view would be placed on top of the PixelHostingView and the order would be wrong. Differential Revision: https://phabricator.services.mozilla.com/D19598
b09a49ab3635a0c4e156e1d255e78281bc13e6c6: Bug 1527412 - Remove swizzling of -[NSView mouseDownCanMoveWindow]. r=spohl
Markus Stange <mstange@themasta.com> - Wed, 13 Feb 2019 11:14:03 +0000 - rev 519802
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1527412 - Remove swizzling of -[NSView mouseDownCanMoveWindow]. r=spohl This was added in bug 476393 in order to work around a problem with the Java plug-in. We no longer support that plug-in. The comment also mentions NSTexturedBackgroundWindowMask which we stopped using in bug 1335191. Differential Revision: https://phabricator.services.mozilla.com/D19558
80265a268c6878d35238be7d3c9135c0fa3e7a99: Bug 1527412 - Make nsChildView::mView a ChildView*, because that's what it is. r=spohl
Markus Stange <mstange@themasta.com> - Wed, 13 Feb 2019 11:14:02 +0000 - rev 519801
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1527412 - Make nsChildView::mView a ChildView*, because that's what it is. r=spohl Differential Revision: https://phabricator.services.mozilla.com/D19556
82aa9a03b71d26790c72a7c2a9b19c0fb7fd936f: Bug 1527412 - Remove unused contextMenu method. r=spohl
Markus Stange <mstange@themasta.com> - Wed, 13 Feb 2019 11:14:02 +0000 - rev 519800
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1527412 - Remove unused contextMenu method. r=spohl This method could only return something non-null in embedding situations, in which our ChildView was a subview of somebody else's NSView that conforms to the mozView protocol. Such a situation hasn't existed for about 10 years. Differential Revision: https://phabricator.services.mozilla.com/D19555
fa484096ffd36c4c0712fa7b880379e1f78171e8: Bug 1527412 - Fix mParentView's type (it doesn't necessarily implement the mozView protocol) and tweak a few comments. r=spohl
Markus Stange <mstange@themasta.com> - Wed, 13 Feb 2019 11:14:02 +0000 - rev 519799
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1527412 - Fix mParentView's type (it doesn't necessarily implement the mozView protocol) and tweak a few comments. r=spohl Differential Revision: https://phabricator.services.mozilla.com/D19554
7f66045a90f2d433aa71064f8ee06d24467dd5ad: Bug 1525611 - use the correct type for width and height in the IPDL PluginShowWindow message; r=spohl
Alex Gaynor <agaynor@mozilla.com> - Thu, 07 Feb 2019 14:52:50 +0000 - rev 518525
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1525611 - use the correct type for width and height in the IPDL PluginShowWindow message; r=spohl Differential Revision: https://phabricator.services.mozilla.com/D18848
4fe736c383665068554d179e38f87fef3935985f: Bug 1168010 - Fix leaks in updater.cpp and nsUpdateDriver.cpp. r=spohl
Robert Strong <robert.bugzilla@gmail.com> - Wed, 30 Jan 2019 22:39:35 +0000 - rev 517033
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1168010 - Fix leaks in updater.cpp and nsUpdateDriver.cpp. r=spohl Fixes leak where the return value of GetManifestContents in updater.cpp is not freed Fixes leak where the return value of get_quoted_path in updater.cpp is not freed Fixes leak in nsUpdateDriver.cpp ApplyUpdate With these leaks fixed the UI tests that stage updates can run on Linux asan Differential Revision: https://phabricator.services.mozilla.com/D17910
7f34f77e6438c153ed40a3ba2cc4c755b89e1afc: Bug 1520530: Remove the usage of deprecated OSX APIs in nsCommandLineService. r=spohl
Dave Townsend <dtownsend@oxymoronical.com> - Wed, 30 Jan 2019 22:28:56 +0000 - rev 517027
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1520530: Remove the usage of deprecated OSX APIs in nsCommandLineService. r=spohl The addition of the Carbon.h include to CreateAppData.cpp is to ensure that The OSX API headers are used before conflicting symbols are declared in the mozilla namespace. Differential Revision: https://phabricator.services.mozilla.com/D16718
1491b434a92d7b5bcb7e9d792294be53b29044f6: Bug 1522064 - Remove used definition for static function OpenApplicationWithURI from nsMIMEInfoMac/nsMIMEInfoUIKit. r=spohl
Mark Banner <standard8@mozilla.com> - Wed, 23 Jan 2019 21:10:58 +0000 - rev 515193
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1522064 - Remove used definition for static function OpenApplicationWithURI from nsMIMEInfoMac/nsMIMEInfoUIKit. r=spohl Differential Revision: https://phabricator.services.mozilla.com/D17340
0e3b5fe32d113a4a857bf7b948921f531cca8a8e: Bug 1521460 - Also reformat objective-c files r=mstange,ehsan,spohl
Sylvestre Ledru <sledru@mozilla.com> - Mon, 21 Jan 2019 18:18:16 +0100 - rev 514912
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1521460 - Also reformat objective-c files r=mstange,ehsan,spohl # ignore-this-changeset Differential Revision: https://phabricator.services.mozilla.com/D17139
099f631b90046b102aa1868455f03b7f9942eaba: Bug 1313429 - Add Touch Bar functionality to Firefox r=spohl,mikedeboer,flod
Harry Twyford <harry.a.twyford@gmail.com> - Tue, 22 Jan 2019 17:13:33 +0000 - rev 514848
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1313429 - Add Touch Bar functionality to Firefox r=spohl,mikedeboer,flod Adds Touch Bar functionality to Firefox across eight commits. Differential Revision: https://phabricator.services.mozilla.com/D5496
ddb55e312c8a2971091d704a52aec679c85b264d: Bug 1515183 - Ignore calls to viewWillDraw and drawRect on non-main threads. r=spohl
Markus Stange <mstange@themasta.com> - Thu, 17 Jan 2019 23:25:34 +0000 - rev 514372
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1515183 - Ignore calls to viewWillDraw and drawRect on non-main threads. r=spohl Differential Revision: https://phabricator.services.mozilla.com/D16909
50b3268954b1300941453d11934d032478425a55: Bug 1518938: Make it possible to hide items from the application menu. r=spohl
Dave Townsend <dtownsend@oxymoronical.com> - Mon, 14 Jan 2019 18:57:49 +0000 - rev 513754
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1518938: Make it possible to hide items from the application menu. r=spohl Differential Revision: https://phabricator.services.mozilla.com/D16107
7bd4fa70b72870a1e8a6c7e39b3904202d7bcd40: Bug 469990: Allow command line arguments to be handed off from a new Firefox/Thunderbird process to an existing one when necessary. r=spohl
Yuri <mozilla@yuriydev.com> - Fri, 07 Dec 2018 09:33:40 -0500 - rev 508863
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 469990: Allow command line arguments to be handed off from a new Firefox/Thunderbird process to an existing one when necessary. r=spohl
2b2777f72b09079f43018c04b1cbed49b959dff1: Bug 1505106 - Support TouchID/FaceID for Reauthentication r=spohl
J.C. Jones <jjones@mozilla.com> - Wed, 28 Nov 2018 18:35:02 +0000 - rev 507958
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1505106 - Support TouchID/FaceID for Reauthentication r=spohl In Bug 1499846 we added support for OSX to do Keychain-based reauthentication. On newer versions of OSX, it's possible to instead do TouchID/FaceID for bio- metric reauthentication, with a fallback to Keychain. This implements that functionality. There's no C++ interface to access the LocalAuthentication framework, so it adds an Objective-C method called by the existing OSReauthenticator methods to perform its work. Differential Revision: https://phabricator.services.mozilla.com/D11700
a6ccef7ece93aa126964145f7ffa99939295d677: Bug 1506447 - Check overlay before checking custom scrollbar style in nsNativeThemeCocoa::GetWidgetTransparency. r=spohl
Xidorn Quan <me@upsuper.org> - Sun, 25 Nov 2018 22:31:53 +1100 - rev 507949
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1506447 - Check overlay before checking custom scrollbar style in nsNativeThemeCocoa::GetWidgetTransparency. r=spohl Differential Revision: https://phabricator.services.mozilla.com/D12856
df022f193cb4b6d8f87504223adc2a2f8789be31: Bug 1510247. Fix some unified build issues in widget code. r=spohl
Jonathan Watt <jwatt@jwatt.org> - Wed, 14 Nov 2018 17:03:36 +0000 - rev 507930
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1510247. Fix some unified build issues in widget code. r=spohl Differential Revision: https://phabricator.services.mozilla.com/D13061
3cbd2cf23c867eddeaeccdfffc70485f2ad3c9c0: Bug 1446161 - Remove the earlier attempt at async launch. r=spohl,mccr8
Jed Davis <jld@mozilla.com> - Wed, 28 Nov 2018 20:42:24 +0000 - rev 507801
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1446161 - Remove the earlier attempt at async launch. r=spohl,mccr8 The first attempt at async launch tried to hide the asynchrony inside IPC, by making the process seem to be launched enough to construct new channels and send it messages, and lazily blocking on the pid/handle. Unfortunately, in practice we wind up needing the pid/handle immediately, and this requirement is too deeply embedded in IPC for that to be viable. (The alternative that will be used instead -- exposing process launch via an explicitly asynchronous promise interface -- is made simpler by Project Fission's upcoming rewrite of how the DOM requests new content processes.) Depends on D8941 Differential Revision: https://phabricator.services.mozilla.com/D8942
1bdf64b29121762bbf6b1e13df1828034b149bac: Bug 1446161 - Remove the earlier attempt at async launch. r=spohl,mccr8
Jed Davis <jld@mozilla.com> - Thu, 22 Nov 2018 00:06:14 +0000 - rev 507382
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1446161 - Remove the earlier attempt at async launch. r=spohl,mccr8 The first attempt at async launch tried to hide the asynchrony inside IPC, by making the process seem to be launched enough to construct new channels and send it messages, and lazily blocking on the pid/handle. Unfortunately, in practice we wind up needing the pid/handle immediately, and this requirement is too deeply embedded in IPC for that to be viable. (The alternative that will be used instead -- exposing process launch via an explicitly asynchronous promise interface -- is made simpler by Project Fission's upcoming rewrite of how the DOM requests new content processes.) Depends on D8941 Differential Revision: https://phabricator.services.mozilla.com/D8942
5373369eb3a63c34801be2019d1c72750fb07080: Bug 1471535 - pt12 - Hook up RDD process and Remote decoding. r=jya,spohl
Michael Froman <mfroman@mozilla.com> - Wed, 14 Nov 2018 18:07:28 +0000 - rev 505441
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1471535 - pt12 - Hook up RDD process and Remote decoding. r=jya,spohl Depends on D8493 Differential Revision: https://phabricator.services.mozilla.com/D8494
3d8a11458d79b14ed5c76b1676399859f7c727a6: Bug 1471535 - pt12 - Hook up RDD process and Remote decoding. r=jya,spohl
Michael Froman <mfroman@mozilla.com> - Tue, 13 Nov 2018 17:36:47 +0000 - rev 505292
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1471535 - pt12 - Hook up RDD process and Remote decoding. r=jya,spohl Depends on D8493 Differential Revision: https://phabricator.services.mozilla.com/D8494
2df61d7610d6d819b666e118dd019bbeffb1410f: Bug 1503577 - Remove CreateDataFromPrimitive from macOS clipboard code. r=spohl
Tom Schuster <evilpies@gmail.com> - Fri, 09 Nov 2018 13:24:28 +0000 - rev 504623
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1503577 - Remove CreateDataFromPrimitive from macOS clipboard code. r=spohl The previous |if (data)| check is not quite the same as !data.IsEmpty(), because the previous code just checked if the do_QueryInterface failed, but not if the resulting string is empty. Differential Revision: https://phabricator.services.mozilla.com/D10438
1342e21cf613ff4a7146d04dd926ce4b07f6ead6: Bug 1471535 - pt12 - Hook up RDD process and Remote decoding. r=jya,spohl
Michael Froman <mfroman@mozilla.com> - Thu, 08 Nov 2018 03:48:29 +0000 - rev 504589
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1471535 - pt12 - Hook up RDD process and Remote decoding. r=jya,spohl Depends on D8493 Differential Revision: https://phabricator.services.mozilla.com/D8494
14f6d3d137ac8edab4cec6254693e42db59ab31b: Bug 1504833 - Remove vestigial TitlebarAndBackgroundColor definition. r=spohl
Markus Stange <mstange@themasta.com> - Mon, 05 Nov 2018 21:17:12 +0000 - rev 503701
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1504833 - Remove vestigial TitlebarAndBackgroundColor definition. r=spohl Differential Revision: https://phabricator.services.mozilla.com/D10962
20e04b1355dc3f265435feaef946682834f74b46: Bug 1502096 - Make peviewing and selecting the default theme work consistently in Dark mode. r=spohl
Dão Gottwald <dao@mozilla.com> - Thu, 25 Oct 2018 21:43:35 +0000 - rev 502278
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1502096 - Make peviewing and selecting the default theme work consistently in Dark mode. r=spohl Differential Revision: https://phabricator.services.mozilla.com/D9861
ccfeb561645b499025c28c26287ee0b8d96cc7ad: bug 1499846 - implement user reauthentication on MacOS r=franziskus,spohl
David Keeler <dkeeler@mozilla.com> - Thu, 25 Oct 2018 00:24:04 +0000 - rev 502093
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
bug 1499846 - implement user reauthentication on MacOS r=franziskus,spohl Differential Revision: https://phabricator.services.mozilla.com/D9025
969fc88ef9a4aa881650668a1ddc16318802ce5c: Bug 1501381 - Fixes to the updater's plist metadata. r=spohl
Robert Strong <robert.bugzilla@gmail.com> - Tue, 23 Oct 2018 14:33:59 -0700 - rev 501900
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1501381 - Fixes to the updater's plist metadata. r=spohl Change the value of CFBundleName in Info.plist.in to 'updater' so it is less than 16 characters long per the spec Change the value of CFBundleName in InfoPlist.strings.in to 'Software Update' so it is less than 16 characters long per the spec and a generic string for the updater can be displayed Add a short version of CFBundleDisplayName to Info.plist.in to 'updater' Add a long version of CFBundleDisplayName to InfoPlist.strings.in to '%APP_NAME% Software Update' so a more detailed string for the updater can be displayed Add LSHasLocalizedDisplayName to Info.plist.in so the localized display name will be used Remove LSMinimumSystemVersion and LSMinimumSystemVersionByArchitecture in InfoPlist.strings.in since they are no longer needed
6ad9bd572bf46896dead808303c652bfb9f8d37a: Bug 1085391 - Support Yosemite Handoff 'web browsing' activity type. r=spohl
Panos Astithas <past@mozilla.com> - Sat, 20 Oct 2018 04:47:38 +0000 - rev 501680
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1085391 - Support Yosemite Handoff 'web browsing' activity type. r=spohl Differential Revision: https://phabricator.services.mozilla.com/D8665
0087557ee59e71e9756c44ef25ba23a22f08dc5a: Bug 1498216 - Properly support alpha channel on custom scrollbars. r=spohl
Xidorn Quan <me@upsuper.org> - Mon, 22 Oct 2018 16:05:05 +0000 - rev 501664
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1498216 - Properly support alpha channel on custom scrollbars. r=spohl This also includes implementation of nsNativeThemeCocoa::GetWidgetAutoColor which should have been done in bug 1464722 actually. Differential Revision: https://phabricator.services.mozilla.com/D8629
cb70f86f71435d262a2686b2ff85d11bb53f4348: Bug 1506447 - Check overlay before checking custom scrollbar style in nsNativeThemeCocoa::GetWidgetTransparency. r=spohl, a=lizzard
Xidorn Quan <me@upsuper.org> - Sun, 25 Nov 2018 22:31:53 +1100 - rev 501434
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1506447 - Check overlay before checking custom scrollbar style in nsNativeThemeCocoa::GetWidgetTransparency. r=spohl, a=lizzard Differential Revision: https://phabricator.services.mozilla.com/D12856
869a690e1c28c9baf1700cbe0100d58b282b008e: Bug 1502096 - Make peviewing and selecting the default theme work consistently in Dark mode. r=spohl, a=RyanVM
Dão Gottwald <dao@mozilla.com> - Thu, 25 Oct 2018 21:43:35 +0000 - rev 500900
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1502096 - Make peviewing and selecting the default theme work consistently in Dark mode. r=spohl, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D9861
92b434174fcfad9f9b6ecd2550e239ca0b8dbf13: Bug 1498216 - Properly support alpha channel on custom scrollbars. r=spohl a=RyanVM
Xidorn Quan <me@upsuper.org> - Mon, 22 Oct 2018 16:05:05 +0000 - rev 500813
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1498216 - Properly support alpha channel on custom scrollbars. r=spohl a=RyanVM This also includes implementation of nsNativeThemeCocoa::GetWidgetAutoColor which should have been done in bug 1464722 actually. Differential Revision: https://phabricator.services.mozilla.com/D8629
075201afc029437db5a51b94bd0fde25cb74c202: Bug 1496823 - Remove declaration of -[NSView _regionForOpaqueDescendants:forMove:]. r=spohl
Markus Stange <mstange@themasta.com> - Wed, 17 Oct 2018 20:50:09 +0000 - rev 500384
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1496823 - Remove declaration of -[NSView _regionForOpaqueDescendants:forMove:]. r=spohl Our implementation of this method was removed in bug 1070710. I forgot to remove the declaration in that bug. Differential Revision: https://phabricator.services.mozilla.com/D7947
c9da89f17cf9426dbfad7af2940ebc9f05225c3a: Bug 1496823 - Inline -[ChildView drawRect:inContext:] into -[ChildView drawRect:]. r=spohl
Markus Stange <mstange@themasta.com> - Wed, 17 Oct 2018 20:49:18 +0000 - rev 500298
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1496823 - Inline -[ChildView drawRect:inContext:] into -[ChildView drawRect:]. r=spohl This was separate because at some point in the past we were calling -[ChildView drawRect:inContext:] from a separate draw-in-titlebar pass. That separate pass was removed in bug 676241. Depends on D7929 Differential Revision: https://phabricator.services.mozilla.com/D7931
408b8733a0a6c805eab8c6bbcb267a07e6bc7dfd: Bug 1496823 - Inline drawUsingOpenGL into drawRect:inContext: and tweak a comment. r=spohl
Markus Stange <mstange@themasta.com> - Wed, 17 Oct 2018 20:48:20 +0000 - rev 500297
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1496823 - Inline drawUsingOpenGL into drawRect:inContext: and tweak a comment. r=spohl Depends on D7928 Differential Revision: https://phabricator.services.mozilla.com/D7929
d1d878123a68f2f7bcd4f31f57fd7eb648975ada: Bug 1496823 - Remove unneeded debugging code. r=spohl
Markus Stange <mstange@themasta.com> - Wed, 17 Oct 2018 20:47:33 +0000 - rev 500296
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1496823 - Remove unneeded debugging code. r=spohl I don't think anybody has made use of this code in years. Depends on D7927 Differential Revision: https://phabricator.services.mozilla.com/D7928
56dc11bab861326c3981f8a38f08027a2b90ae7a: Bug 1496823 - Remove -[ChildView setNeedsDisplayInRect:] override. r=spohl
Markus Stange <mstange@themasta.com> - Wed, 17 Oct 2018 20:47:29 +0000 - rev 500295
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1496823 - Remove -[ChildView setNeedsDisplayInRect:] override. r=spohl This override was intended to ignore unnecessary nsChildView::Invalidate calls when using main thread OpenGL. With OMTC, Gecko no longer calls Invalidate in those cases, it just composites on the compositor thread, and the widget's main thread code doesn't really hear about it. So this workaround is no longer necessary. Depends on D7925 Differential Revision: https://phabricator.services.mozilla.com/D7927
8848453f27af6f3ae1538e9cbadef50bf4e95455: Bug 1496823 - Remove -[ChildView isUsingMainThreadOpenGL] and dependent code because it always returns NO. r=spohl
Markus Stange <mstange@themasta.com> - Wed, 17 Oct 2018 20:46:16 +0000 - rev 500294
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1496823 - Remove -[ChildView isUsingMainThreadOpenGL] and dependent code because it always returns NO. r=spohl The main thread layer manager is always NONE, BASIC or CLIENT. It is never OPENGL anymore. Main-thread OpenGL rendering was removed in bug 924403. Depends on D7924 Differential Revision: https://phabricator.services.mozilla.com/D7925
959084361b1580b3dd586b6e229e21274cc83556: Bug 1496823 - Remove EventThreadRunner and the pref that enabled it. r=kats,spohl
Markus Stange <mstange@themasta.com> - Wed, 17 Oct 2018 20:44:28 +0000 - rev 500293
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1496823 - Remove EventThreadRunner and the pref that enabled it. r=kats,spohl This was an experiment before we had e10s. It's no longer needed. Depends on D7922 Differential Revision: https://phabricator.services.mozilla.com/D7924