searching for reviewer(snorp)
b12036a85308bad86fb8549ab23519aa6713dbb6: Bug 1602072 - Add a gfxInfo flag determine Firefox is embedded by FxR for telemetry. r=thomasmo,chutten,froydnj,jrmuizel,geckoview-reviewers,rbarker,snorp
Daosheng Mu <daoshengmu@gmail.com> - Thu, 25 Jun 2020 17:22:20 +0000 - rev 605228
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1602072 - Add a gfxInfo flag determine Firefox is embedded by FxR for telemetry. r=thomasmo,chutten,froydnj,jrmuizel,geckoview-reviewers,rbarker,snorp Differential Revision: https://phabricator.services.mozilla.com/D56233
cac6157a808b9329e36dc24769259f5e5e9034a1: Bug 1624993 - Expose a GeckoView API for Gecko Profiler markers r=geckoview-reviewers,agi,snorp
Nazım Can Altınova <canaltinova@gmail.com> - Thu, 25 Jun 2020 14:30:48 +0000 - rev 605171
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1624993 - Expose a GeckoView API for Gecko Profiler markers r=geckoview-reviewers,agi,snorp Differential Revision: https://phabricator.services.mozilla.com/D79125
b95162bf0644d8eb9a9ff1f4af761b8ff0427e5f: Bug 1645725 - Remove chatsetMenu.properties l10n resource from GeckoView. r=geckoview-reviewers,Pike,snorp
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 22 Jun 2020 09:00:40 +0000 - rev 604487
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1645725 - Remove chatsetMenu.properties l10n resource from GeckoView. r=geckoview-reviewers,Pike,snorp `charsetMenu.properies` was for "Text Encoding" menu in Fennec (bug 611580). EN was off as default, but some language such JA turned on this menu. Since Fennec is gone, it is unnecessary now, so let's remove this resource. Differential Revision: https://phabricator.services.mozilla.com/D79634
0238d868b580e773cd6ac568bc71407a0dc8b81a: Bug 1645725 - Remove chatsetMenu.properties l10n resource from GeckoView. r=geckoview-reviewers,Pike,snorp
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 22 Jun 2020 09:00:40 +0000 - rev 604471
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1645725 - Remove chatsetMenu.properties l10n resource from GeckoView. r=geckoview-reviewers,Pike,snorp `charsetMenu.properies` was for "Text Encoding" menu in Fennec (bug 611580). EN was off as default, but some language such JA turned on this menu. Since Fennec is gone, it is unnecessary now, so let's remove this resource. Differential Revision: https://phabricator.services.mozilla.com/D79634
c165c77e4d2444da99cb93c33804c27cd9652098: Bug 1643464 - Part 3: Rename LEFT/RIGHT_BUTTON as PRIMARY/SECONDARY_BUTTON r=masayuki,geckoview-reviewers,snorp
Kagami Sascha Rosylight <saschanaz@outlook.com> - Fri, 19 Jun 2020 17:50:43 +0000 - rev 604438
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1643464 - Part 3: Rename LEFT/RIGHT_BUTTON as PRIMARY/SECONDARY_BUTTON r=masayuki,geckoview-reviewers,snorp Differential Revision: https://phabricator.services.mozilla.com/D80333
ba4656e730c420d7621460e40a9a052669961599: Bug 1638153: Part 2 - Fix uses of .rootTreeItem to get top browser window. r=geckoview-reviewers,nika,snorp
Kris Maglione <maglione.k@gmail.com> - Wed, 17 Jun 2020 17:17:16 +0000 - rev 603894
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1638153: Part 2 - Fix uses of .rootTreeItem to get top browser window. r=geckoview-reviewers,nika,snorp Differential Revision: https://phabricator.services.mozilla.com/D75429
9a3a87c7c7bf250be4db8d5875e241e8f7dc9e80: Bug 1644021 - StreamingTelemetryDelegates need threadsafe ref counting r=snorp
Chris H-C <chutten@mozilla.com> - Mon, 15 Jun 2020 15:55:06 +0000 - rev 603460
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1644021 - StreamingTelemetryDelegates need threadsafe ref counting r=snorp Differential Revision: https://phabricator.services.mozilla.com/D79708
561694a246a0e12f9c261fca58ce26b8767e6e3b: Bug 1645770 - Fix dark mode settings on GeckoView's content processes. r=geckoview-reviewers,snorp
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 15 Jun 2020 15:55:23 +0000 - rev 603449
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1645770 - Fix dark mode settings on GeckoView's content processes. r=geckoview-reviewers,snorp GeckoRuntime is not around in content processes so we need to remote it like we remote the prefers-reduced-motion values. Differential Revision: https://phabricator.services.mozilla.com/D79670
bd1e6309d1fc862044781ef8ba1035d2509df2ae: Bug 1627523 - Disable test_selectevents.html on android for intermittent failures; r=snorp
Geoff Brown <gbrown@mozilla.com> - Wed, 10 Jun 2020 19:44:56 +0000 - rev 602704
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1627523 - Disable test_selectevents.html on android for intermittent failures; r=snorp In addition to the failures tracked by this bug and its dups for many months, there are likely many other Android test_selectevents.html failures going unnoticed or reported to random bugs because the failure message generated here is not picked up by treeherder bug suggestions (separate issue tracked by bug 1407293). Note that this test has traditionally been skipped on Android; I enabled it in bug 1585119, thinking that it was running reliably. Differential Revision: https://phabricator.services.mozilla.com/D79139
9ba8b78124a9a6d3f399b53a19e8749ab7a26905: Bug 1643129 - Skip countLogins calls in _doAsyncPrompt if the MP isn't currently showing. r=geckoview-reviewers,snorp
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Wed, 10 Jun 2020 19:42:37 +0000 - rev 602697
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1643129 - Skip countLogins calls in _doAsyncPrompt if the MP isn't currently showing. r=geckoview-reviewers,snorp Differential Revision: https://phabricator.services.mozilla.com/D78141
02e2cc3bd51141003734ce1146612bf17948bafc: Bug 1644297 - Re enable old browser.storage.sync on Android. r=rpl,snorp
Agi Sferro <agi@sferro.dev> - Wed, 10 Jun 2020 17:19:56 +0000 - rev 602670
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1644297 - Re enable old browser.storage.sync on Android. r=rpl,snorp This also adds a smoke test which runs on all platforms to avoid regressions. Differential Revision: https://phabricator.services.mozilla.com/D78987
245776c0b467e1792a66fa1ffa683975b8e9071e: Bug 1643656 - Fix GeckoRuntimeSettings color scheme configuration. r=geckoview-reviewers,snorp
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 09 Jun 2020 22:40:22 +0000 - rev 602538
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1643656 - Fix GeckoRuntimeSettings color scheme configuration. r=geckoview-reviewers,snorp So as to not use a pref with an invalid value, which I would've changed the behavior of with the previous patch. Differential Revision: https://phabricator.services.mozilla.com/D78957
8ec34ae7484d1a1039cdc72e6173e9a3788bc7f4: Bug 1628762 - Fix tree column header color to follow theme. r=geckoview-reviewers,snorp
Colomban Wendling <cwendling@hypra.fr> - Wed, 03 Jun 2020 20:52:55 +0000 - rev 602342
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1628762 - Fix tree column header color to follow theme. r=geckoview-reviewers,snorp The background color for the tree column headers is drawn using the system APIs, but the foreground uses custom colors, which didn't follow theme. This can lead to unreadable text with specific colors, e.g. leading to black on black. Fix this by using system colors for the foreground as well. It also adds on-hover styling to match possible background change on hover. Differential Revision: https://phabricator.services.mozilla.com/D78073
d8b68a88624b6058d0e0ecfb162f0e2a9a40ff44: Bug 1638672 - Use shaders to clear texture cache regions r=geckoview-reviewers,gw,snorp
Dzmitry Malyshau <dmalyshau@mozilla.com> - Mon, 08 Jun 2020 21:05:03 +0000 - rev 602262
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1638672 - Use shaders to clear texture cache regions r=geckoview-reviewers,gw,snorp This is a suggested workaround for an interesting visual bug that we see on some platforms with Intel Broadwell GPUs. Also reverts https://phabricator.services.mozilla.com/D57100 Differential Revision: https://phabricator.services.mozilla.com/D78705
447cbc28fda3f04d5b322cee1a07f2c4e41bb88e: Bug 1641948: remove android opt builds from non-mozilla-central branches; reduce frequency of fat-aar builds r=snorp,Callek
Ben Hearsum <bhearsum@mozilla.com> - Wed, 03 Jun 2020 20:52:38 +0000 - rev 601645
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1641948: remove android opt builds from non-mozilla-central branches; reduce frequency of fat-aar builds r=snorp,Callek snorp - I'm not sure if you want/need to review this yourself so I'm flagging you as optional. Differential Revision: https://phabricator.services.mozilla.com/D77834
d29525eebe79ccc056a9e7bb668fd1007934f731: Bug 1642429 - Use checkstyle to enforce that all API methods have docs. r=esawin,snorp
Agi Sferro <agi@sferro.dev> - Tue, 02 Jun 2020 15:05:13 +0000 - rev 601271
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1642429 - Use checkstyle to enforce that all API methods have docs. r=esawin,snorp Differential Revision: https://phabricator.services.mozilla.com/D77693
f7aedc92d396d9170c88af862ec0871bf4a0f6cd: Bug 1638153: Part 2 - Fix uses of .rootTreeItem to get top browser window. r=geckoview-reviewers,nika,snorp
Kris Maglione <maglione.k@gmail.com> - Mon, 01 Jun 2020 17:59:01 +0000 - rev 601102
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1638153: Part 2 - Fix uses of .rootTreeItem to get top browser window. r=geckoview-reviewers,nika,snorp Differential Revision: https://phabricator.services.mozilla.com/D75429
cc5f9b171fd9a81ebfcd82839cadf2d327f4e985: Bug 1641983 - Update apilint to 0.3.0. r=snorp
Agi Sferro <agi@sferro.dev> - Mon, 01 Jun 2020 15:58:01 +0000 - rev 601071
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1641983 - Update apilint to 0.3.0. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D77534
eb654059cd8baa99ade5008b2b5bd93166604c44: Bug 1641711 - Make javadoc output parsing more resilient. r=snorp
Agi Sferro <agi@sferro.dev> - Mon, 01 Jun 2020 15:58:05 +0000 - rev 601069
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1641711 - Make javadoc output parsing more resilient. r=snorp As it turns out, javadoc output is not stable across platforms / OSs / versions (not a big suprise). E.g. in try this is an example line: ``` /builds/worker/checkouts/gecko/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoRuntimeSettings.java:1124: warning - Tag @link: reference not found: Autocomplete.LoginStorageDelegate.onLoginFetch onLoginFetch ``` on my mac, this is the same error: ``` /Users/asferro/workspace/mozilla-central/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoRuntimeSettings.java:1118: error: reference not found * {@link Autocomplete.LoginStorageDelegate.onLoginFetch onLoginFetch}. ``` Notice the `-` character after `warning` in the first example and the `:` character after the second example. To be able to parse both this patch simiplifies the regex and also adds a failsafe that will mark anything that contains the string "error" and "warning" as such. Differential Revision: https://phabricator.services.mozilla.com/D77545
f7b9cdfbc377dcbfc2c5c4e77411d4dbe965acfc: Bug 1641711 - Don't fail the build if javadoc fails. r=nalexander,snorp,esawin
Agi Sferro <agi@sferro.dev> - Mon, 01 Jun 2020 15:58:13 +0000 - rev 601067
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1641711 - Don't fail the build if javadoc fails. r=nalexander,snorp,esawin `|mach lint -f treeherder|` expects lint to not fail ever, if a lint fails it's just ignored. This means that when our javadoc errors out and fails the build all lints are ignored. To avoid that we add `failOnError = false` to the javadoc job so that we can finish the build and actually report the errors. This patch also adds gradle output `|mach lint|` to make it easier to diagnose errors in the lint. Differential Revision: https://phabricator.services.mozilla.com/D77373
dce83a6b19e2922f8fe025d5e13690b11c9b229e: Bug 1644297 - Re enable old browser.storage.sync on Android. r=rpl,snorp, a=jcristau
Agi Sferro <agi@sferro.dev> - Wed, 10 Jun 2020 17:19:56 +0000 - rev 600786
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1644297 - Re enable old browser.storage.sync on Android. r=rpl,snorp, a=jcristau This also adds a smoke test which runs on all platforms to avoid regressions. Differential Revision: https://phabricator.services.mozilla.com/D78987
2548f39e1751f10df77ccae8c42702d6ef9bbd7d: Bug 1641711 - Don't fail the build if javadoc fails. r=nalexander,snorp
Agi Sferro <agi@sferro.dev> - Fri, 29 May 2020 00:24:22 +0000 - rev 600290
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1641711 - Don't fail the build if javadoc fails. r=nalexander,snorp `|mach lint -f treeherder|` expects lints to not fail ever, if a lint fails it's just ignored. This means that when our javadoc errors out and fails the build all lints are ignored. To avoid that we add `failOnError = false` to the javadoc job so that we can finish the build and actually report the errors. This patch also adds gradle output `|mach lint|` to make it easier to diagnose errors in the lint. Differential Revision: https://phabricator.services.mozilla.com/D77373
f0de352a865b371e5d757cbef4b2b4216ab8a805: Bug 1630323 - Do not override user preferences when clicking on a service worker notification to open a new document, r=Gijs,nika,geckoview-reviewers,snorp
Anny Gakhokidze <agakhokidze@mozilla.com> - Wed, 27 May 2020 18:15:36 +0000 - rev 599911
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1630323 - Do not override user preferences when clicking on a service worker notification to open a new document, r=Gijs,nika,geckoview-reviewers,snorp In Bug 1622749 a user preference for where to open new documents (from a service worker notification) was temporarily overriden in order to quickly fix a crash that was happening in mozilla::dom::ClientOpenWindow. The crash was ocurring when the pref "browser.link.open_newwindow" was set to 2, meaning new documents are opened in a new window, instead of a new tab. The reason the browser crashed is because the path for opening a new document is different depending on the current user setting, and in NEWWINDOW case we did not get a browsing context returned when calling mozilla::dom::OpenWindow which resulted in a failed assertion. The solution is to pass in a callback to mozilla::dom::OpenWindow as part of nsOpenWindowInfo object, and invoke that callback with a corresponding BrowsingContext in nsFrameLoader when that browsing context is ready. After we call mozilla::dom::OpenWindow, we wait on a promise, that will be resolved when the callback is invoked, before executing the rest of the code that depends on the browsing context for a newly opened document being available. Differential Revision: https://phabricator.services.mozilla.com/D72745
00082591503eb5e57cce27f722b8a45c943c7034: Bug 1640990 - [1.1] Add login autofill runtime setting. r=geckoview-reviewers,MattN,snorp
Eugen Sawin <esawin@mozilla.com> - Wed, 27 May 2020 14:04:52 +0000 - rev 599854
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1640990 - [1.1] Add login autofill runtime setting. r=geckoview-reviewers,MattN,snorp Differential Revision: https://phabricator.services.mozilla.com/D76891
53cc0d95ca87299bdfb71351de4a4a006c9ea4a4: Bug 1640743 - Update WebExtension example links. r=snorp
Agi Sferro <agi@sferro.dev> - Tue, 26 May 2020 19:31:01 +0000 - rev 599606
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1640743 - Update WebExtension example links. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D76756
534e2eb7eaaedd53196fdba7d138bfb7f7a25d41: Bug 1629113 - Use |class| in GeckoViewPrompt.jsm r=snorp
Agi Sferro <agi@sferro.dev> - Tue, 26 May 2020 07:44:49 +0000 - rev 599580
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1629113 - Use |class| in GeckoViewPrompt.jsm r=snorp Differential Revision: https://phabricator.services.mozilla.com/D75879
86df4717f1e5b57d24ebd29a7357ef63d1ce6f89: Bug 1629113 - Move remaining services to components.conf. r=snorp,baku
Agi Sferro <agi@sferro.dev> - Tue, 26 May 2020 07:44:52 +0000 - rev 599579
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1629113 - Move remaining services to components.conf. r=snorp,baku Differential Revision: https://phabricator.services.mozilla.com/D75878
96c247dac742ef0ba8196e536475671c14f677e9: Bug 1629113 - Move prompt classes to its own modules. r=snorp
Agi Sferro <agi@sferro.dev> - Tue, 26 May 2020 16:35:28 +0000 - rev 599578
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1629113 - Move prompt classes to its own modules. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D75877
c60451dacf684f9bf7811f3a89f2efac317055dd: Bug 1629113 - Use |class| more in GeckoViewPrompt. r=snorp
Agi Sferro <agi@sferro.dev> - Tue, 26 May 2020 16:33:21 +0000 - rev 599577
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1629113 - Use |class| more in GeckoViewPrompt. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D75876
5cf3ae77ccb3d6eb8604c74a0413b5c5384439bb: Bug 1640387 - Only set HitResult::mTargetIsRoot for confirmed-root targets. r=snorp,botond
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 26 May 2020 16:30:12 +0000 - rev 599571
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1640387 - Only set HitResult::mTargetIsRoot for confirmed-root targets. r=snorp,botond Differential Revision: https://phabricator.services.mozilla.com/D76594
cd5c87a1700881582a938bff5d653b48eb82d0bc: Bug 1629113 - Use |class| in GeckoViewPrompt.jsm r=snorp
Agi Sferro <agi@sferro.dev> - Tue, 26 May 2020 04:14:15 +0000 - rev 599483
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1629113 - Use |class| in GeckoViewPrompt.jsm r=snorp Differential Revision: https://phabricator.services.mozilla.com/D75879
3729b2c288ba46c7d48f5a2bca68f5faafafd60b: Bug 1629113 - Move remaining services to components.conf. r=snorp,baku
Agi Sferro <agi@sferro.dev> - Tue, 26 May 2020 04:14:12 +0000 - rev 599482
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1629113 - Move remaining services to components.conf. r=snorp,baku Differential Revision: https://phabricator.services.mozilla.com/D75878
2cd92d6c2998f8ab81e6b14540bec17c15227950: Bug 1629113 - Move prompt classes to its own modules. r=snorp
Agi Sferro <agi@sferro.dev> - Tue, 26 May 2020 04:14:05 +0000 - rev 599481
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1629113 - Move prompt classes to its own modules. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D75877
6d7c87f3c329bd3aeb32bd9fdffbfc3af1255c60: Bug 1629113 - Use |class| more in GeckoViewPrompt. r=snorp
Agi Sferro <agi@sferro.dev> - Tue, 26 May 2020 04:14:05 +0000 - rev 599480
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1629113 - Use |class| more in GeckoViewPrompt. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D75876
106285c88a8504c4460d72b4c4d1eebd78d309f8: Bug 1618058 - [3.3] Rename and extend LoginStorage tests to Autocomplete tests. r=geckoview-reviewers,agi,snorp
Eugen Sawin <esawin@mozilla.com> - Mon, 25 May 2020 18:46:15 +0000 - rev 599434
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1618058 - [3.3] Rename and extend LoginStorage tests to Autocomplete tests. r=geckoview-reviewers,agi,snorp Differential Revision: https://phabricator.services.mozilla.com/D73060
e975470f4a8c5ad9acd7f5930c95b3e5683b01e2: Bug 1618058 - [1.4] Add Autocomplete API for login autocomplete. r=geckoview-reviewers,snorp,agi
Eugen Sawin <esawin@mozilla.com> - Mon, 25 May 2020 18:43:15 +0000 - rev 599431
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1618058 - [1.4] Add Autocomplete API for login autocomplete. r=geckoview-reviewers,snorp,agi Differential Revision: https://phabricator.services.mozilla.com/D73055
1f2dfbcafe57e8aac38dca4df96e691b659bae8e: Bug 1629113 - Implement nsIPromptCollection on GeckoView. r=snorp,droeh
Agi Sferro <agi@sferro.dev> - Fri, 22 May 2020 23:22:41 +0000 - rev 599106
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1629113 - Implement nsIPromptCollection on GeckoView. r=snorp,droeh Differential Revision: https://phabricator.services.mozilla.com/D72722
d07f8d9d1a01068fdad27c09966326b7109574a5: Bug 1636158 - Remove addons-bloomfilters from Android package r=agi,geckoview-reviewers,snorp
Rob Wu <rob@robwu.nl> - Wed, 20 May 2020 16:39:05 +0000 - rev 599003
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1636158 - Remove addons-bloomfilters from Android package r=agi,geckoview-reviewers,snorp Those will be restored in bug 1639050 Differential Revision: https://phabricator.services.mozilla.com/D76157
7ded7f391f1b90c8ccc81bf151d289a802470317: Bug 1609024 - Remove cache mechanism which is not very useful. r=hiro,snorp,mccr8
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 21 May 2020 17:02:06 +0000 - rev 598836
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1609024 - Remove cache mechanism which is not very useful. r=hiro,snorp,mccr8 I don't think all this complexity is worth it for having a marginally-more-realistic testing story. Using the pref just works and we should do that, I think. Differential Revision: https://phabricator.services.mozilla.com/D59980
64f2ad721dbf0bcbbdad1109aa147b83f888b814: Bug 1639180 - Port docs to Sphinx and reST and stop copying to GitHub. r=geckoview-reviewers,snorp
Emily Toop <etoop@mozilla.com> - Wed, 20 May 2020 15:22:32 +0000 - rev 598640
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1639180 - Port docs to Sphinx and reST and stop copying to GitHub. r=geckoview-reviewers,snorp Differential Revision: https://phabricator.services.mozilla.com/D75935
8b425b5dfb9f08cf17fab269b91b01aa861208b4: Bug 1432949 - Allow system principal initialize a channel for revoked blob URLs r=geckoview-reviewers,snorp,baku,ckerschb
owlishDeveloper <bugzeeeeee@gmail.com> - Wed, 20 May 2020 14:39:28 +0000 - rev 598609
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1432949 - Allow system principal initialize a channel for revoked blob URLs r=geckoview-reviewers,snorp,baku,ckerschb Differential Revision: https://phabricator.services.mozilla.com/D75659
141fda86ce584056961fbff02b1f6abb028a4d76: Bug 1639180 - Port docs to Sphinx and reST and stop copying to GitHub. r=geckoview-reviewers,snorp
Emily Toop <etoop@mozilla.com> - Tue, 19 May 2020 14:51:17 +0000 - rev 598571
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1639180 - Port docs to Sphinx and reST and stop copying to GitHub. r=geckoview-reviewers,snorp Differential Revision: https://phabricator.services.mozilla.com/D75935
4f5359c798fcef836a4371243f76a1182f5b79ac: Bug 1619550 - p1: listen to media segment load event and pass the URL to resource wrapper. r=bryce,geckoview-reviewers,snorp
John Lin <jolin@mozilla.com> - Tue, 19 May 2020 14:51:07 +0000 - rev 598250
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1619550 - p1: listen to media segment load event and pass the URL to resource wrapper. r=bryce,geckoview-reviewers,snorp Differential Revision: https://phabricator.services.mozilla.com/D74989
328927902c0607dd2600063e259bda1fa51c2e7b: Bug 1596825 - Add NavigationDelegate.onSubframeLoadRequest to handle non-top-level load requests. r=snorp,mattwoodrow,geckoview-reviewers,agi
Dylan Roeh <droeh@mozilla.com> - Tue, 19 May 2020 17:05:42 +0000 - rev 598207
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1596825 - Add NavigationDelegate.onSubframeLoadRequest to handle non-top-level load requests. r=snorp,mattwoodrow,geckoview-reviewers,agi Differential Revision: https://phabricator.services.mozilla.com/D74939
41012e39a75d1e0a78bd4756ccc84902b50af309: Bug 1636089 - ActorManagerParent.addJSProcessActors;r=kmag,geckoview-reviewers,snorp
David Teller <dteller@mozilla.com> - Tue, 19 May 2020 16:29:36 +0000 - rev 598196
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1636089 - ActorManagerParent.addJSProcessActors;r=kmag,geckoview-reviewers,snorp Differential Revision: https://phabricator.services.mozilla.com/D75047
ae83a793e7c98d249e35645e9d7e95013bb5c279: Bug 1633432 - Don't detach SurfaceTextures from GL context on Pause(). r=sotaro,geckoview-reviewers,snorp,imanol
Jamie Nicol <jnicol@mozilla.com> - Fri, 15 May 2020 12:05:15 +0000 - rev 597622
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1633432 - Don't detach SurfaceTextures from GL context on Pause(). r=sotaro,geckoview-reviewers,snorp,imanol In bug 1470348 we started to detach all SurfaceTextures from the current GL context in CompositorOGL::Pause(). This was required for VR, so that when the VR presentation was entered the SurfaceTextures could be attached to the VR context instead. When RenderCompositorEGL was implemented for webrender, we copied the call to detach from CompositorOGL. However, due to extra complexity in webrender's threading model, this is causing assertion failures. VR no longer relies upon the SurfaceTextures being detached when the compositor is paused, as it now uses its own SurfaceTexture set. Therefore we can remove the detach call from both CompositorOGL::Pause and RenderCompositorEGL::Pause. Differential Revision: https://phabricator.services.mozilla.com/D74832
5b34a70e2378d86fe579acf3346013f15a939835: Bug 1509933 - part1 : add new pref 'media.autoplay.blocking_policy'. r=geckoview-reviewers,snorp,padenot
alwu <alwu@mozilla.com> - Fri, 15 May 2020 03:40:31 +0000 - rev 597571
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1509933 - part1 : add new pref 'media.autoplay.blocking_policy'. r=geckoview-reviewers,snorp,padenot This patch will do : - rename the old pref `media.autoplay.enabled.user-gestures-needed` to the new pref `media.autoplay.blocking_policy` - modify the value of the pref to `int` in order to introduce new policy - implement new policy in `AutoplayPoliocy` The advantage of doing so : - rename the pref to explicitly indicate that it's related the block policy we use - use the transient user gesture activation as a new policy to replace the old one using the user input, which doesn't work on the async handler More details : The old `click-to-play` policy we use is using the user input to determine if the play invocation is called by users or by scripts. But `UserActivation::IsHandlingUserInput()` is buggy which would fail when you call `video.play()` inside an async event handler. So we would like to replace it with the new transient user activation, which would treat the action as an user input if the action is performed within a certain period of time after a user interacts (eg. click) with the page. [1] https://html.spec.whatwg.org/multipage/interaction.html#transient-activation Differential Revision: https://phabricator.services.mozilla.com/D73971
3abb24d6dfc9449bd0c5949121b27fb237d573f8: Bug 1509933 - part1 : add new pref 'media.autoplay.blocking_policy'. r=geckoview-reviewers,snorp,padenot
alwu <alwu@mozilla.com> - Fri, 15 May 2020 01:39:31 +0000 - rev 597556
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1509933 - part1 : add new pref 'media.autoplay.blocking_policy'. r=geckoview-reviewers,snorp,padenot This patch will do : - rename the old pref `media.autoplay.enabled.user-gestures-needed` to the new pref `media.autoplay.blocking_policy` - modify the value of the pref to `int` in order to introduce new policy - implement new policy in `AutoplayPoliocy` The advantage of doing so : - rename the pref to explicitly indicate that it's related the block policy we use - use the transient user gesture activation as a new policy to replace the old one using the user input, which doesn't work on the async handler More details : The old `click-to-play` policy we use is using the user input to determine if the play invocation is called by users or by scripts. But `UserActivation::IsHandlingUserInput()` is buggy which would fail when you call `video.play()` inside an async event handler. So we would like to replace it with the new transient user activation, which would treat the action as an user input if the action is performed within a certain period of time after a user interacts (eg. click) with the page. [1] https://html.spec.whatwg.org/multipage/interaction.html#transient-activation Differential Revision: https://phabricator.services.mozilla.com/D73971
f12050b298470f8bc99e19c1976a1eed3cf63f21: Bug 1638114 - Do not keep EGLSurfaceOverride references to destroyed Android Shared Surfaces. r=jgilbert,snorp,rbarker
Imanol Fernandez <mortimergoro@gmail.com> - Thu, 14 May 2020 22:50:02 +0000 - rev 597537
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1638114 - Do not keep EGLSurfaceOverride references to destroyed Android Shared Surfaces. r=jgilbert,snorp,rbarker In WebVR we destroy the mVRScreen after presentation is exited by calling WebGLContext::ClearVRFrame(). We found that when having multiple windows with active WebGL contexts in Firefox Reality, the WebGL context dies a lot, and you have to reload the page to recover from it. The problem is that when the GLScreenBuffer is destroyed the EGLContext still keeps a reference to the destroyed surface, set by gl->SetEGLSurfaceOverride(surface), which can break the future eglMakeCurrent calls. Differential Revision: https://phabricator.services.mozilla.com/D75413
f049c6635dc22894fc430664ea01e7dbb31b70d2: Bug 1631754 - Improve code to distinguish between root and content handling of events. r=snorp,geckoview-reviewers
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 14 May 2020 13:51:34 +0000 - rev 597230
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1631754 - Improve code to distinguish between root and content handling of events. r=snorp,geckoview-reviewers In particular, the eConsumeNoDefault case also needs to check for mTargetIsRoot and the apz aware listeners flag. Differential Revision: https://phabricator.services.mozilla.com/D75301