searching for reviewer(snorp)
95b884dcbd6f: Bug 1496684 - Dispatch commonly expected startup notifications when opening a GeckoView window. r=snorp a=lizzard
Jan Henning <jh+bugzilla@buttercookie.de> - Thu, 07 Feb 2019 20:41:16 +0000 - rev 515877
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1496684 - Dispatch commonly expected startup notifications when opening a GeckoView window. r=snorp a=lizzard Once a webextension using a blocking WebRequest listener has started loading, all network connections covered by the extension's manifest are held until the extension is ready the process them. One condition for the extension being ready apparently includes browser startup having progressed far enough, as signified by "browser-delayed-startup-finished" having been dispatched. Therefore, we have to start sending that notification when opening a new Gecko- View window, too, and copy Fennec's InitLater() system for that. Unlike Fennec, we cannot tie registration of those InitLater() runnables to the initial content load having progressed far enough because of a) e10s, which makes that approach neither easily possible nor really sensible, as content will load in a different process in that case, and b) because we're racing with extension startup here - if extensions are loaded quick enough to block even the initial page load, we'd be deadlocked: We cannot send the notification until the page finishes loading, but the page cannot load until we send the notification. Fennec isn't affected by the latter problem because "sessionstore-windows-restored", which Fennec will send in any case, serves as an alternative pathway for completing extension startup. And unlike Desktop, we don't really have any chrome content to paint, so we cannot tie delayed initialisation to a paint listener for that, either. Therefore, we simply fire off a runnable at the *end* of geckoview.js's startup() method, which should give more pressing initialisation tasks enough of a headstart. For completeness, we're also adding the "browser-idle-startup-tasks-finished" notification and thereby solve bug 1465832 as well, allowing the ScriptPreloader to detect which scripts are commonly loaded during GeckoView startup and to start caching and pre-parsing them. Differential Revision: https://phabricator.services.mozilla.com/D18865
8b10cbe1b887: Bug 1524857 - Part 2: Use display URI's base domain for domain highlighting. r=snorp a=lizzard
Jan Henning <jh+bugzilla@buttercookie.de> - Thu, 07 Feb 2019 19:21:45 +0000 - rev 515874
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1524857 - Part 2: Use display URI's base domain for domain highlighting. r=snorp a=lizzard That way, domain highlighting (and therefore the URL justification code that right-justifies the TLD within the URL bar) can run even on error pages. This also means that the workaround from bug 1479311 for blocking javascript: URIs from being highlighted in ToolbarDisplayLayout is no longer required - the base domain for domain highlighting is now being generated from the same URI that actually ends up being displayed in the URL bar, and as such the existing checks in browser.js for only generating a base domain for HTTP(S)/ FTP-URIs, but not any other schemes, finally work the way they are intended. Differential Revision: https://phabricator.services.mozilla.com/D18587
ab592ce5d5ae: Bug 1514364 - Add appendRawFilter to nsIFilePicker to expose actual accept filters to GV for onFilePrompt. r=snorp, smaug
Dylan Roeh <droeh@mozilla.com> - Thu, 24 Jan 2019 10:21:05 -0600 - rev 515375
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1514364 - Add appendRawFilter to nsIFilePicker to expose actual accept filters to GV for onFilePrompt. r=snorp, smaug
4ef0f4957e85: Bug 1521600 - Clarify how the ViewportMode API actually works. r=geckoview-reviewers,snorp
Jan Henning <jh+bugzilla@buttercookie.de> - Wed, 23 Jan 2019 21:06:06 +0000 - rev 515191
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1521600 - Clarify how the ViewportMode API actually works. r=geckoview-reviewers,snorp VIEWPORT_MODE_DESKTOP *forces* the desktop mode viewport everywhere, whereas VIEWPORT_MODE_MOBILE merely enables <meta> viewport support for pages that have that tag defined, but still uses the desktop mode viewport for all other pages. Differential Revision: https://phabricator.services.mozilla.com/D17159
03609832ffdc: Bug 1382637 - Zombify tabs in onDestroy to ensure video/audio recording ends when Fennec is swipe-to-killed. r=snorp
Dylan Roeh <droeh@mozilla.com> - Wed, 23 Jan 2019 11:41:01 -0600 - rev 515159
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1382637 - Zombify tabs in onDestroy to ensure video/audio recording ends when Fennec is swipe-to-killed. r=snorp
c997411e8d31: Bug 1521404 - Fix apilint warnings about BuildConfig. r=geckoview-reviewers,snorp
Agi Sferro <agi@mozilla.com> - Wed, 23 Jan 2019 14:48:12 +0000 - rev 515112
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1521404 - Fix apilint warnings about BuildConfig. r=geckoview-reviewers,snorp See https://github.com/mozilla-mobile/gradle-apilint/commit/aa9e8a7a2337b3d76951e1bc78c653b51b9be188. Differential Revision: https://phabricator.services.mozilla.com/D17268
f57051371bf0: Bug 1517641 - [1.0] Add experimental ad-blocking category to the Tracking Protection API. r=snorp,geckoview-reviewers,dimi
Eugen Sawin <esawin@mozilla.com> - Thu, 17 Jan 2019 23:06:55 +0000 - rev 514350
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1517641 - [1.0] Add experimental ad-blocking category to the Tracking Protection API. r=snorp,geckoview-reviewers,dimi Differential Revision: https://phabricator.services.mozilla.com/D16700
9eb9e58dc4bc: Bug 1510705 - Fix infinite loop in tests waiting for pending callbacks. r=snorp
Matt Brubeck <mbrubeck@mozilla.com> - Thu, 17 Jan 2019 19:14:06 +0000 - rev 514339
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1510705 - Fix infinite loop in tests waiting for pending callbacks. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D16733
779094a64ae1: Bug 1519997 - Exclusively use cache for actions and events. r=geckoview-reviewers,snorp
Eitan Isaacson <eitan@monotonous.org> - Thu, 17 Jan 2019 17:01:09 +0000 - rev 514279
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1519997 - Exclusively use cache for actions and events. r=geckoview-reviewers,snorp Differential Revision: https://phabricator.services.mozilla.com/D16499
715c5bd0dc5a: Bug 1520470 - Update metadata for related Bugzilla product and component for geckoview. r=snorp DONTBUILD
Sebastian Hengst <archaeopteryx@coole-files.de> - Wed, 16 Jan 2019 16:18:45 +0200 - rev 514198
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1520470 - Update metadata for related Bugzilla product and component for geckoview. r=snorp DONTBUILD Reviewers: snorp Tags: #secure-revision Bug #: 1520470 Differential Revision: https://phabricator.services.mozilla.com/D16699
ba98166b6967: Bug 1482452 - p2: validate object before sending to Java runtime. r=snorp
John Lin <jolin@mozilla.com> - Wed, 16 Jan 2019 16:31:19 +0000 - rev 514118
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1482452 - p2: validate object before sending to Java runtime. r=snorp Depends on D16707 Differential Revision: https://phabricator.services.mozilla.com/D16708
0be55928fcb7: Bug 1482452 - p1: validate buffer contents before accessing. r=snorp
John Lin <jolin@mozilla.com> - Wed, 16 Jan 2019 16:31:16 +0000 - rev 514117
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1482452 - p1: validate buffer contents before accessing. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D16707
972a66d8aab1: Bug 1493980 - Don't pass indefinite screen orientations to Gecko. r=snorp
Matt Brubeck <mbrubeck@mozilla.com> - Thu, 10 Jan 2019 21:46:12 +0000 - rev 513866
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1493980 - Don't pass indefinite screen orientations to Gecko. r=snorp This eliminates one potential source of crashes from passing bad orientation values to onOrientationChange. Differential Revision: https://phabricator.services.mozilla.com/D16207
025a428fbec4: Bug 1494748 - Ensure GeckoView saved state lives at least as long as the app process. r=snorp
Jan Henning <jh+bugzilla@buttercookie.de> - Mon, 14 Jan 2019 19:21:49 +0000 - rev 513768
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1494748 - Ensure GeckoView saved state lives at least as long as the app process. r=snorp The arguably most interesting bit of state of BrowserApp/GeckoApp, namely the currently open tabs, are living partly in Gecko and partly in the Tabs manager singleton, the lifetimes of both of which are tied to the lifetime of the app process. If the whole process has been killed, things are simple: Neither the Tabs manager nor Gecko know anything about any tabs and we simply restore them through the session store if enabled. If GeckoApp is however being restored into an app process in which it had already executed earlier on, meaning that we have some open tabs, it relies on the savedInstanceState in order to correctly reconnect its GeckoView instance with the correct previous GeckoSession. We can however end up in a state where we don't have a savedInstanceState (e.g. because the user swiped away the BrowserApp activity in the task switcher), but the app process keeps running throughout (if another activity of ours is still present in the task switcher, e.g. a custom tab, or else if a service is active, then standard Android keeps the process running even if the user swipes away an activity). In that case, if GeckoApp is subsequently recreated, the Android UI sees all the Android-side tabs in the Tabs manager, and Gecko in fact still has the Window open that is containing all those tabs, but without the savedInstanceState GeckoApp doesn't know anything about that Window and proceeds to open a fresh session instead. This means that all previous tabs will appear white and unresponsive, while freshly opened tabs will load, but they won't be correctly saved in the session store, their context menu isn't working, etc., because we're not really expecting to handle multiple Gecko-side Windows. To fix this, we disable automatic state-saving for GeckoApp's GeckoView instance and instead do it manually, so we can keep another reference to the saved state in GeckoApplication, and therefore are able to retrieve it from there for as long as the app process keeps running. Differential Revision: https://phabricator.services.mozilla.com/D16393
39207d39e5c2: Bug 1498812 - Part 9: Switch session store/session history to use visual viewport for scroll position tracking. r=mikedeboer,snorp
Jan Henning <jh+bugzilla@buttercookie.de> - Fri, 11 Jan 2019 19:50:09 +0000 - rev 513538
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1498812 - Part 9: Switch session store/session history to use visual viewport for scroll position tracking. r=mikedeboer,snorp For simplicity's sake, for now we keep storing only one scroll position per history entry (bug 1499210), so if we have to choose between the layout and the visual viewport, the latter is a vastly better choice, as it more accurately represents the scroll position as perceived by the user, especially when the page has been pinch-zoomed. This also means that instead of the normal scroll events, the session store now has to listen for the corresponding events specific to the visual viewport. We also extend the scroll position test to check that the scroll position isn't just properly saved, but also actually properly restored in practice as well. We only add this test now instead of already adding it beforehand like we did with the rest of the test - to avoid having to temporarily extend the checkScroll() helper function to deal with todo()/todo_is etc. - because getting that part of the test to complete without timing out (which would be one of its natural failure modes, because the expected events would be missing) would require faking even more scroll events - because we already have the todo() tests that are telling us the we didn't *store* any scroll position in the first place, so there's no point in trying to actually restore anything For the GeckoView saveAndRestoreState test, we now spin the event loop once before setting the scroll position in order to give APZ opportunity to settle down after the initial page load. Differential Revision: https://phabricator.services.mozilla.com/D15690
bbbb9e3c793d: Bug 1498812 - Part 2: Switch GeckoViewScrollChild to use the visual viewport. r=snorp
Jan Henning <jh+bugzilla@buttercookie.de> - Fri, 11 Jan 2019 19:49:04 +0000 - rev 513531
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1498812 - Part 2: Switch GeckoViewScrollChild to use the visual viewport. r=snorp Given the usage example of pull-to-refresh in bug 1371796, downstream consumers will probably more interested in the true visible scroll position of the user within the page, i.e. the visual viewport. Listening for *visual* viewport events will also definitively be required to get the saveAndRestoreState GeckoView test properly working once we switch Gecko's session store helper function to use the *visual* viewport scroll position. Differential Revision: https://phabricator.services.mozilla.com/D15682
e4550e8b5a79: Bug 256180 Dalvik part - Disable some deep-tree tests on Android, because running the tests on Dalvik is not feasible. r=snorp.
Henri Sivonen <hsivonen@hsivonen.fi> - Mon, 17 Dec 2018 13:46:10 +0200 - rev 513391
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 256180 Dalvik part - Disable some deep-tree tests on Android, because running the tests on Dalvik is not feasible. r=snorp.
0fab42583213: Bug 256180 mobile part - Increase the max size for the runtime stack of the Gecko main thread on Android. r=snorp.
Henri Sivonen <hsivonen@hsivonen.fi> - Wed, 04 Oct 2017 09:46:05 +0300 - rev 513388
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 256180 mobile part - Increase the max size for the runtime stack of the Gecko main thread on Android. r=snorp. MozReview-Commit-ID: F85WvVTOP1S
9c8923903d73: Bug 1508279 - Handle persistent notification actions. r=geckoview-reviewers,snorp
Vlad Baicu <vlad.baicu@softvision.ro> - Thu, 10 Jan 2019 17:05:32 +0000 - rev 513304
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1508279 - Handle persistent notification actions. r=geckoview-reviewers,snorp Handle persistent notifications click actions in NotificationReceiver. Differential Revision: https://phabricator.services.mozilla.com/D16062
18cb79bb1c78: Bug 1500155 - Add methods for each setting in `GeckoSessionSettings`. r=snorp
Emily Toop <etoop@mozilla.com> - Tue, 08 Jan 2019 18:06:07 +0000 - rev 512932
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1500155 - Add methods for each setting in `GeckoSessionSettings`. r=snorp Part 1 - Add methods for each setting in `GeckoSessionSettings`. Migrate existing code to use these new methods instead of the exisiting get/set<DataType>(Key, Value) methods. Part 2 - Make old methods and fields for get/set<DataType> in `GeckoSessionSettings` private. Part 3 - Migrate existing code to use these new methods instead of the exisiting get/set<DataType>(Key, Value) methods. Part 4 - Add Builder to `GeckoSessionSettings` to handle setting of init only fields. * Make setters for init only fields protected. * Remove tests that ensure that init only fields throw an error when set on the fly as this is no longer possible. * Update tests to use builder when init-ing settings. * Update API doc to reflect new public API. Part 5 - Update `CHANGELOG.md`. Part 6 - Update `geckoview_example` to use new methods. Part 7 - Fetch `CHROME_URI` key when calling `getChromeUri` rather than incorrect `USER_AGENT_OVERRIDE` Differential Revision: https://phabricator.services.mozilla.com/D15651
e85e41f84971: Bug 256180 Dalvik part - Disable some deep-tree tests on Android, because running the tests on Dalvik is not feasible. r=snorp.
Henri Sivonen <hsivonen@hsivonen.fi> - Mon, 17 Dec 2018 13:46:10 +0200 - rev 512927
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 256180 Dalvik part - Disable some deep-tree tests on Android, because running the tests on Dalvik is not feasible. r=snorp.
b696df615c8b: Bug 256180 mobile part - Increase the max size for the runtime stack of the Gecko main thread on Android. r=snorp.
Henri Sivonen <hsivonen@hsivonen.fi> - Wed, 04 Oct 2017 09:46:05 +0300 - rev 512924
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 256180 mobile part - Increase the max size for the runtime stack of the Gecko main thread on Android. r=snorp. MozReview-Commit-ID: F85WvVTOP1S
953e31ae0e5d: Bug 1507852 - Add GeckoView API to toggle desktop viewport support r=geckoview-reviewers,snorp,agi
Randall Barker <rbarker@mozilla.com> - Tue, 08 Jan 2019 00:58:16 +0000 - rev 512788
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1507852 - Add GeckoView API to toggle desktop viewport support r=geckoview-reviewers,snorp,agi Differential Revision: https://phabricator.services.mozilla.com/D15598
129a3f527c8e: Bug 1507852 - Add GeckoView API to toggle desktop viewport support r=geckoview-reviewers,snorp,agi
Randall Barker <rbarker@mozilla.com> - Mon, 07 Jan 2019 20:05:08 +0000 - rev 512735
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1507852 - Add GeckoView API to toggle desktop viewport support r=geckoview-reviewers,snorp,agi Differential Revision: https://phabricator.services.mozilla.com/D15598
28694796fe29: Bug 1515960 - Add links to CHANGELOG.md. r=snorp,geckoview-reviewers
Agi Sferro <agi@mozilla.com> - Wed, 26 Dec 2018 17:25:55 +0000 - rev 512260
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1515960 - Add links to CHANGELOG.md. r=snorp,geckoview-reviewers This adds links from the CHANGELOG to the javadoc. Differential Revision: https://phabricator.services.mozilla.com/D15213
d02e6cc785a9: Bug 1510663 - Address WifiManager Potential Leak warning. r=geckoview-reviewers,snorp
Emily Toop <etoop@mozilla.com> - Wed, 19 Dec 2018 15:50:05 +0000 - rev 512245
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1510663 - Address WifiManager Potential Leak warning. r=geckoview-reviewers,snorp On versions prior to Android N (24), initializing the WifiManager via Context#getSystemService can cause a memory leak if the context is not the application context. Differential Revision: https://phabricator.services.mozilla.com/D14721
589569dbbb63: Bug 1510648 - Suppress MissingPermission warnings. r=geckoview-reviewers,snorp
Emily Toop <etoop@mozilla.com> - Wed, 19 Dec 2018 15:49:42 +0000 - rev 512244
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1510648 - Suppress MissingPermission warnings. r=geckoview-reviewers,snorp This is because these persmissions are the responsibility of the embedding app to request,not GeckoView's. Differential Revision: https://phabricator.services.mozilla.com/D14722
5651b431fe2c: Bug 1506649 - Part 3: Guess ExternalStorageProvider file paths for non-primary volumes. r=snorp
Jan Henning <jh+bugzilla@buttercookie.de> - Wed, 26 Dec 2018 20:38:01 +0000 - rev 512171
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1506649 - Part 3: Guess ExternalStorageProvider file paths for non-primary volumes. r=snorp The AOSP ExternalStorageProvider always creates document IDs of the form "storage device ID" + ':' + "document path", where the storage device ID will be "primary" for the primary emulated storage and the file system UUID for everything else. Assuming that OEMs won't customise this behaviour, the main problem that needs to be handled is how to turn the file system UUID back into a file system path. Differential Revision: https://phabricator.services.mozilla.com/D15259
fd078630d666: Bug 1506649 - Part 2: Better API version linting. r=snorp
Jan Henning <jh+bugzilla@buttercookie.de> - Wed, 26 Dec 2018 20:19:22 +0000 - rev 512170
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1506649 - Part 2: Better API version linting. r=snorp Because getOriginalFilePathFromUri() doesn't use framework methods newer than Kitkat, instead of a generic @SuppressLint("NewAPI") it would be better to use @TargetApi(19), so you still get warned if you start using framework methods more recent than API19. However because the isKitkat helper variable is only used in one place, in the end we simply replace it with a direct Build.VERSION.SDK_INT check, so that we don't have to use any special handling for the linter. Differential Revision: https://phabricator.services.mozilla.com/D15258
242e66d84734: Bug 1506649 - Part 1: Avoid exeception-based control-flow for resolving content://-URIs. r=snorp
Jan Henning <jh+bugzilla@buttercookie.de> - Wed, 26 Dec 2018 20:19:15 +0000 - rev 512169
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1506649 - Part 1: Avoid exeception-based control-flow for resolving content://-URIs. r=snorp Instead, getOriginalFilePathFromUri() will simply *always* return null if it cannot divine the original file path, and consequently resolveContentUri() will then always fall back to the temp file method if getOriginalFilePathFromUri() returns null. Differential Revision: https://phabricator.services.mozilla.com/D15257
9297836c0b83: Bug 1515729 - Remove Task.jsm usage from mobile/android. r=snorp
Mark Banner <standard8@mozilla.com> - Fri, 28 Dec 2018 22:36:18 +0000 - rev 512104
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1515729 - Remove Task.jsm usage from mobile/android. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D15464
252193307797: Bug 1515865 - Remove unnecessary Task.jsm inclusions in mobile/android tests. r=snorp
Mark Banner <standard8@mozilla.com> - Wed, 26 Dec 2018 19:20:48 +0000 - rev 511938
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1515865 - Remove unnecessary Task.jsm inclusions in mobile/android tests. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D15177
92822b4813f7: Bug 1515559 - Account for image source-sets in context menu. r=snorp
Jan Henning <jh+bugzilla@buttercookie.de> - Wed, 26 Dec 2018 18:38:20 +0000 - rev 511916
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1515559 - Account for image source-sets in context menu. r=snorp Audio/video related context menu entries are already doing this as far as I can tell. Differential Revision: https://phabricator.services.mozilla.com/D15382
531e57a2941f: Bug 1492335 - Strip view-source prefix when copying/sharing links from context menu. r=snorp
Jan Henning <jh+bugzilla@buttercookie.de> - Wed, 26 Dec 2018 18:38:18 +0000 - rev 511915
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1492335 - Strip view-source prefix when copying/sharing links from context menu. r=snorp Desktop does this when copying link URLs and sharing is just effectively just another form of copying. For completeness, we also apply this when "viewing" the source of images (which just displays the image itself anyway). No special handling is required for other media elements (audio/video), because looking at those in view-source mode does display the raw file contents and thus none of the media-specific context menu entries will show up. Differential Revision: https://phabricator.services.mozilla.com/D15381
12616753519d: Bug 1506658 - Add @Nullable or @NonNull to all APIs. r=snorp,rbarker,geckoview-reviewers
Agi Sferro <agi@mozilla.com> - Thu, 20 Dec 2018 15:22:45 +0000 - rev 511518
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1506658 - Add @Nullable or @NonNull to all APIs. r=snorp,rbarker,geckoview-reviewers Upgrading apilint to the 0.1.6 release will also ensure that new APIs have nullability annotations via the GV4 and GV5 lints, see [0]. [0]: https://github.com/mozilla-mobile/gradle-apilint/commit/b994c7ca9db056652ba4b5dd639437ddf2c5cc6f#diff-2c7de691a2642510f69b9ddf59276d85R569 Differential Revision: https://phabricator.services.mozilla.com/D14896
30abf82080a3: Bug 1458668 - Link CHANGELOG.md in javadoc. r=snorp,geckoview-reviewers
Agi Sferro <agi@mozilla.com> - Wed, 19 Dec 2018 15:48:17 +0000 - rev 511337
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1458668 - Link CHANGELOG.md in javadoc. r=snorp,geckoview-reviewers This moves the CHANGELOG.md file to a /doc-files folder that gets picked up by javadoc. Our javadoc files are hosted on a github.io page which will render the markdown file with the geckoview profile. Depends on D13883 Differential Revision: https://phabricator.services.mozilla.com/D14786
52ee186f9550: Bug 1511477 - [2.0] Extend tracking protection test. r=snorp
Eugen Sawin <esawin@mozilla.com> - Wed, 19 Dec 2018 15:48:47 +0000 - rev 511307
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1511477 - [2.0] Extend tracking protection test. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D14792
c15860d7d189: Bug 1509573 - Part 3: Use |make -C ... stage-package| rather than special Make target. r=snorp
Nick Alexander <nalexander@mozilla.com> - Tue, 18 Dec 2018 23:01:16 +0000 - rev 511200
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1509573 - Part 3: Use |make -C ... stage-package| rather than special Make target. r=snorp This splits the two stage-package invocations (which are rather slow) between Fennec and GeckoView, hopefully speeding local GV development up a little (in the IDE). The stage-package invocations depend on |mach build faster|, because the omnijar contents might need to be updated. In addition, we feed the packaged libs (and asset libs) through. Differential Revision: https://phabricator.services.mozilla.com/D12799
43ddf4c3ae27: Bug 1509573 - Part 1: Use |mach build ...| rather than special Make target. r=snorp
Nick Alexander <nalexander@mozilla.com> - Tue, 18 Dec 2018 23:54:08 +0000 - rev 511198
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1509573 - Part 1: Use |mach build ...| rather than special Make target. r=snorp This uses |mach build mobile/android/base/...| rather than a custom target, reducing Make magic and making it a little easier to reason about the Gradle build. This is somewhat rearranging deckchairs, but the more that gets out of Make and into moz.build, the simpler our lives become. The shared `onlyIf` Gradle guard will be used to make it very clear when certain tasks are being skipped, as we move details about Gecko binaries to depend on the Gradle task execution graph. I also took the opportunity to improve the task logging. Differential Revision: https://phabricator.services.mozilla.com/D12798
42f4f1c36ef6: Bug 1502118 - Enforce GV lints with apilint. r=snorp
Agi Sferro <agi@mozilla.com> - Mon, 17 Dec 2018 22:32:11 +0000 - rev 511002
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1502118 - Enforce GV lints with apilint. r=snorp This makes it so that apilints lints with "GV" codes are enforced and will fail the build. Depends on D13882 Differential Revision: https://phabricator.services.mozilla.com/D13883
4cd3b9cf8159: Bug 1502118 - Make FinderResult non-final for testing. r=snorp,esawin
Agi Sferro <agi@mozilla.com> - Mon, 17 Dec 2018 22:31:59 +0000 - rev 511001
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1502118 - Make FinderResult non-final for testing. r=snorp,esawin This allows mocking for embedders. Depends on D13881 Differential Revision: https://phabricator.services.mozilla.com/D13882
0d938252d0ed: Bug 1502118 - Add threading annotations to remaining APIs. r=snorp
Agi Sferro <agi@mozilla.com> - Mon, 17 Dec 2018 22:31:46 +0000 - rev 511000
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1502118 - Add threading annotations to remaining APIs. r=snorp Depends on D13880 Differential Revision: https://phabricator.services.mozilla.com/D13881
95951162d775: Bug 1502118 - Add @UiThread to all Delegate interfaces. r=snorp,esawin
Agi Sferro <agi@mozilla.com> - Mon, 17 Dec 2018 22:31:29 +0000 - rev 510999
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1502118 - Add @UiThread to all Delegate interfaces. r=snorp,esawin Differential Revision: https://phabricator.services.mozilla.com/D13880
62064231dfbc: Bug 1486659 - p3: copy texture contents for remote allocated Surface. r=snorp
John Lin <jolin@mozilla.com> - Fri, 14 Dec 2018 21:34:55 +0000 - rev 510957
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1486659 - p3: copy texture contents for remote allocated Surface. r=snorp Child processes cannot access textures allocated in the parent process, which is needed by the compositor to render video elements efficiently. Unfortunately, Android doesn't expose Sufrace buffers (sharable across processes) in the SDK/NDK as other platforms, so we need to generate extra texture/surface in the child process and update texture images through the surface, which is passed to the parent process for the remote texture to copy its contents into. Differential Revision: https://phabricator.services.mozilla.com/D11939
6c89aae076dd: Bug 1486659 - p2: expose native GL blitter to Java. r=snorp
John Lin <jolin@mozilla.com> - Fri, 14 Dec 2018 21:34:11 +0000 - rev 510956
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1486659 - p2: expose native GL blitter to Java. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D11938
f491ebcda076: Bug 1486659 - p1: conform SharedMemory.describeContents() to Android API spec. r=snorp
John Lin <jolin@mozilla.com> - Fri, 14 Dec 2018 21:34:09 +0000 - rev 510955
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1486659 - p1: conform SharedMemory.describeContents() to Android API spec. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D11936
31bf1cd657a3: Bug 1513395 - Vendor accessibility-test-framework in m-c. r=nalexander,geckoview-reviewers,snorp
Agi Sferro <agi@mozilla.com> - Fri, 14 Dec 2018 21:34:06 +0000 - rev 510579
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1513395 - Vendor accessibility-test-framework in m-c. r=nalexander,geckoview-reviewers,snorp This vendors accessibility-test-framework which has recently been remove by accident from the Google maven repository, this library can be removed once https://issuetracker.google.com/issues/120951637 is resolved. Depends on D14514 Differential Revision: https://phabricator.services.mozilla.com/D14516
cf2b899cc4ac: Bug 1513395 - Upgrade com.android.tools to 26.2.1. r=snorp,geckoview-reviewers
Agi Sferro <agi@mozilla.com> - Fri, 14 Dec 2018 21:33:05 +0000 - rev 510578
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1513395 - Upgrade com.android.tools to 26.2.1. r=snorp,geckoview-reviewers Differential Revision: https://phabricator.services.mozilla.com/D14514
e5079e6a5c13: Bug 1511281 - Update GeckoView user agent override to use docShell.customUserAgent r=snorp
Randall Barker <rbarker@mozilla.com> - Fri, 14 Dec 2018 14:40:06 +0000 - rev 510538
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1511281 - Update GeckoView user agent override to use docShell.customUserAgent r=snorp Differential Revision: https://phabricator.services.mozilla.com/D13593
f32605134927: Bug 1494748 - Stop stumbler service when Fennec is killed. r=snorp
Dylan Roeh <droeh@mozilla.com> - Wed, 12 Dec 2018 11:53:49 -0600 - rev 510419
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1494748 - Stop stumbler service when Fennec is killed. r=snorp