searching for reviewer(smaug)
b404112c2f6c: Bug 1493869 - Put window.event behind a pref and disable it by default for release versions. r=smaug a=pascalc
Xidorn Quan <me@upsuper.org> - Tue, 25 Sep 2018 15:55:09 +0000 - rev 492721
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1493869 - Put window.event behind a pref and disable it by default for release versions. r=smaug a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D6752
7b6a90c66a6c: Bug 1422456 - Origin for about: URL should not contain query or ref parts, r=smaug a=pascalc
Andrea Marchesini <amarchesini@mozilla.com> - Fri, 14 Sep 2018 20:07:22 +0200 - rev 492536
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1422456 - Origin for about: URL should not contain query or ref parts, r=smaug a=pascalc
f296b260e611: Bug 1482825 - Only prevent dispatching mouse-move events targeted at a slider frame to web content, if the scrollbar is being dragged. r=smaug a=pascalc
Botond Ballo <botond@mozilla.com> - Sat, 01 Sep 2018 15:00:31 +0000 - rev 492415
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1482825 - Only prevent dispatching mouse-move events targeted at a slider frame to web content, if the scrollbar is being dragged. r=smaug a=pascalc Otherwise, if the mouse is just moving over the scrollbar, mouse-move events are dispatched to web content. Differential Revision: https://phabricator.services.mozilla.com/D4800
9b35b8441aa5: Bug 1488427 - AbortSignal::Unfollow() must be called when unlinked, r=smaug a=RyanVM
Andrea Marchesini <amarchesini@mozilla.com> - Fri, 07 Sep 2018 11:05:47 +0200 - rev 492394
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1488427 - AbortSignal::Unfollow() must be called when unlinked, r=smaug a=RyanVM
3145e6f7f695: Bug 1488116 - get rid of nsIDOMXULDescriptionElement, r=smaug
Alexander Surkov <surkov.alexander@gmail.com> - Tue, 04 Sep 2018 09:08:39 +0800 - rev 492313
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1488116 - get rid of nsIDOMXULDescriptionElement, r=smaug
d630bee3155a: Bug 1487343 - Correct set the prefix for an autonomous custom element; r=smaug
Edgar Chen <echen@mozilla.com> - Mon, 03 Sep 2018 22:13:35 +0000 - rev 492282
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1487343 - Correct set the prefix for an autonomous custom element; r=smaug Differential Revision: https://phabricator.services.mozilla.com/D4871
5254a8f44df4: Bug 1487649 - Don't do a name check when cloning a shadow root for print preview. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 03 Sep 2018 14:10:58 +0000 - rev 492237
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1487649 - Don't do a name check when cloning a shadow root for print preview. r=smaug Otherwise the ShadowRoot for <use> or other internal ones may not get cloned properly. Differential Revision: https://phabricator.services.mozilla.com/D4756
d718fc7c16e6: Bug 1487237. Add some content lists stored in DOM slots to memory reporting. r=smaug
Boris Zbarsky <bzbarsky@mit.edu> - Sat, 01 Sep 2018 14:55:47 +0000 - rev 492170
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1487237. Add some content lists stored in DOM slots to memory reporting. r=smaug This reports the memory as part of element-nodes, but I think that's OK for now. If we want to, we can try to add more nsWindowSizes buckets for this stuff. Differential Revision: https://phabricator.services.mozilla.com/D4811
18320a6e8444: Bug 1487659 - Make Selection treat SelectionChangeListener as a concrete class rather than nsISelectionListener r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 31 Aug 2018 21:22:57 +0000 - rev 492112
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1487659 - Make Selection treat SelectionChangeListener as a concrete class rather than nsISelectionListener r=smaug SelectionChangeListener is an nsISelectionListener class. This is added only to Selection for "normal" and added by nsFrameSelection::Init() after AccessibleCaretEventHub. So, we can make Selection directly treat SelectionChangeListener. Differential Revision: https://phabricator.services.mozilla.com/D4757
bdbd39b2251d: Bug 1487591 - Make Selection treat AccessibleCaretEventHub as concrete class rather than nsISelectionListener r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 31 Aug 2018 21:19:44 +0000 - rev 492111
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1487591 - Make Selection treat AccessibleCaretEventHub as concrete class rather than nsISelectionListener r=smaug AccessibleCaretEventHub is an nsISelectionListener of Selection whose type is "normal". This is added only when nsFrameSelection::Init() is called and accessible caret is enabled. Additionally, nsFrameSelection::Init() is always called immediately after creating nsFrameSelection. Therefore, when AccessibleCaretEventHub is installed to Selection, this is always second selection listener and won't be installed multiple times. So, Selection can store pointer of AccessibleCaretEventHub directly only when it's enabled and the Selection needs to notify it of selection change. This patch makes Selection stores AccessibleCaretEventHub with RefPtr, then, makes Selection::NotifySelectionListeners() call its OnSelectionChange() immediately after AutoCopyListener. Unfortunately, this patch includes making of MOZ_CAN_RUN_SCRIPT_BOUNDARY and MOZ_CAN_RUN_SCRIPT a lot since some methods of AccessibleCaretEventHub are marked as MOZ_CAN_RUN_SCRIPT and including AccessibleCaretEventHub.h into Selection.h causes compile the compile errors. Differential Revision: https://phabricator.services.mozilla.com/D4733
65b36a89443f: Bug 1487649 - Don't do a name check when cloning a shadow root for print preview. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 31 Aug 2018 12:08:04 +0000 - rev 492103
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1487649 - Don't do a name check when cloning a shadow root for print preview. r=smaug Otherwise the ShadowRoot for <use> or other internal ones may not get cloned properly. Differential Revision: https://phabricator.services.mozilla.com/D4756
f34f8a70ede7: Bug 1485881 - Drop support for PaymentAddress.languageCode r=smaug
Marcos Cáceres <marcos@marcosc.com> - Mon, 27 Aug 2018 16:30:00 +0300 - rev 492068
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1485881 - Drop support for PaymentAddress.languageCode r=smaug
3897c3140df0: Bug 1485400 - Part 0: separate blocked tracker counter; r=smaug
Liang-Heng Chen <xeonchen@gmail.com> - Thu, 30 Aug 2018 20:21:44 +0000 - rev 491987
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1485400 - Part 0: separate blocked tracker counter; r=smaug separate tracker counter API Differential Revision: https://phabricator.services.mozilla.com/D4490
9370432b26ad: Bug 1485400 - Part 0: separate blocked tracker counter; r=smaug
Liang-Heng Chen <xeonchen@gmail.com> - Thu, 30 Aug 2018 20:21:44 +0000 - rev 491982
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1485400 - Part 0: separate blocked tracker counter; r=smaug separate tracker counter API Differential Revision: https://phabricator.services.mozilla.com/D4490
2fe5a97dd750: Bug 1487402 - Selection should stop notifying AutoCopyListener of selection changes after unlinked r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 30 Aug 2018 23:47:25 +0000 - rev 491919
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1487402 - Selection should stop notifying AutoCopyListener of selection changes after unlinked r=smaug This is a regression of bug 1486370. Unlink of Selection removes all nsISelectionListener first, then, it removes all its ranges since it does not want to notify the changes anymore. After bug 1486370, Selection starts to store only bool flag whether it should notify AutoCopyListener of selection changes. So, unless it sets the bool flag to false in Unlink, it'll notify selection change caused by Unlink. Differential Revision: https://phabricator.services.mozilla.com/D4690
414403195a4e: Bug 1487476 - Expose lightweight themes as chrome-only features on nsIDocument instead of XULDocument;r=smaug
Brian Grinstead <bgrinstead@mozilla.com> - Thu, 30 Aug 2018 23:17:58 +0000 - rev 491916
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1487476 - Expose lightweight themes as chrome-only features on nsIDocument instead of XULDocument;r=smaug Differential Revision: https://phabricator.services.mozilla.com/D4719
86ec37344b44: Bug 1486297 - Add a pref for Pointer Lock API so that user can disable it. r=smaug!
Xidorn Quan <me@upsuper.org> - Thu, 30 Aug 2018 22:55:31 +0000 - rev 491913
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1486297 - Add a pref for Pointer Lock API so that user can disable it. r=smaug! Differential Revision: https://phabricator.services.mozilla.com/D4637
9b452b8c8d13: Bug 1485722 - Improve thread assertions in EventSourceImpl. r=smaug.
Henri Sivonen <hsivonen@hsivonen.fi> - Fri, 24 Aug 2018 13:12:54 +0300 - rev 491839
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1485722 - Improve thread assertions in EventSourceImpl. r=smaug. MozReview-Commit-ID: Aq7vVSronYg Differential Revision: https://phabricator.services.mozilla.com/D4245
c36af4e5a515: Bug 1486370 - Change nsAutoCopyListener to a static class r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 30 Aug 2018 07:36:23 +0000 - rev 491782
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1486370 - Change nsAutoCopyListener to a static class r=smaug nsAutoCopyListener is a singleton class but refcountable and a selection listener. nsFrameSelection adds it to only normal Selection when it's on macOS or it's enabled by the pref. Additionally, it's always first selection listener since it's added immediately after Selection instance is created. So, we can make it a static class, and normal Selection instance should have a bool to decide whether it should notify nsAutoCopyListener of its changes. Then, we can save the cost of grabbing it with local RefPtr and the virtual call. Additionally, this patch renames nsAutoCopyListener to mozilla::AutoCopyListener and optimizes constructor of nsFrameSelection (using bool var cache to retrieve the pref, avoid retrieving the pref on macOS). Differential Revision: https://phabricator.services.mozilla.com/D4504
bc6567e31d48: Bug 1486674 - get rid of nsIDOMXULCheckboxElement, r=smaug
Alexander Surkov <surkov.alexander@gmail.com> - Thu, 30 Aug 2018 08:17:11 +0800 - rev 491777
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1486674 - get rid of nsIDOMXULCheckboxElement, r=smaug
48f88e237b4e: Bug 1487198 - Measure memory usage of the identifier map in ShadowRoot as well. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 29 Aug 2018 22:49:04 +0000 - rev 491740
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1487198 - Measure memory usage of the identifier map in ShadowRoot as well. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D4615
000a3f46f36c: Bug 1486772 - Refactor the screen-orientation types and headers r=smaug
Gabriele Svelto <gsvelto@mozilla.com> - Wed, 29 Aug 2018 20:54:56 +0000 - rev 491688
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1486772 - Refactor the screen-orientation types and headers r=smaug This patch removes the 'ScreenOrientationInternal' type from dom/base/ScreenOrientation.h and moves it into the HalScreenConfiguration.h header, renaming it simply to 'ScreenOrientation' in the process. This has several knock-off effects: - It allows files that needed ScreenOrientationInternal to include a much smaller header than before - It greatly reduces the number of headers pulled in when including Hal.h - It clarifies the role of the type. The 'Internal' part in the name had nothing to do with it being part of the implementation. The type was public and called that way only to avoid clashing with the 'ScreenOrientation' class. Since we moved it into a different namespace it can be renamed safely. - It allows a file that was manually re-declaring 'ScreenConfigurationInternal' type to use the original one - Finally this fixes a few files which were missing headers they actually required but that would still build because unified compilation put them into units that already had those headers thanks to ScreenConfiguration.h Differential Revision: https://phabricator.services.mozilla.com/D4458
1d6495af4aa9: Bug 1487168: Give ShouldShowFocusRingIfFocusedByMouse() an #ifndef guard to match its caller & to avoid -Wunused-function build warning. r=smaug
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 29 Aug 2018 18:01:12 +0000 - rev 491687
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1487168: Give ShouldShowFocusRingIfFocusedByMouse() an #ifndef guard to match its caller & to avoid -Wunused-function build warning. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D4583
8298388d8349: Bug 1486900 - IPCBlobInputStreamChild should be able to shutdown before receiving the remote stream, r=smaug
Andrea Marchesini <amarchesini@mozilla.com> - Wed, 29 Aug 2018 11:10:57 +0200 - rev 491559
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1486900 - IPCBlobInputStreamChild should be able to shutdown before receiving the remote stream, r=smaug
7ccc1c8a7abe: Bug 1486130: Fix reporting of unhandled DOMException rejection values. r=smaug
Kris Maglione <maglione.k@gmail.com> - Thu, 23 Aug 2018 14:01:04 -0700 - rev 491394
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1486130: Fix reporting of unhandled DOMException rejection values. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D4264
4292aeb328da: Bug 1486480. Add memory reporting for custom element data. r=smaug
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 27 Aug 2018 19:20:53 +0000 - rev 491390
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1486480. Add memory reporting for custom element data. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D4350
7318404ba4f8: Bug 1486429 - AbortSignal must use nsTObserverArray for AbortFollower objects, r=smaug
Andrea Marchesini <amarchesini@mozilla.com> - Tue, 28 Aug 2018 17:28:01 +0200 - rev 491386
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1486429 - AbortSignal must use nsTObserverArray for AbortFollower objects, r=smaug
44e3fc29c49f: Bug 1480366 - Traverse/Unlink mAbortFollowing in any object exposed to content, r=smaug
Andrea Marchesini <amarchesini@mozilla.com> - Tue, 28 Aug 2018 17:27:58 +0200 - rev 491385
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1480366 - Traverse/Unlink mAbortFollowing in any object exposed to content, r=smaug
b5ebdb085efa: Bug 1486732 - Remove useless nsXBLBinding::mIsShadowRootBinding. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 28 Aug 2018 13:10:11 +0200 - rev 491374
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1486732 - Remove useless nsXBLBinding::mIsShadowRootBinding. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D4434
54beb60ca7d5: Bug 1486633: Simplify the logic for updating mWatchID in IDTracker.cpp. r=smaug
Daniel Holbert <dholbert@cs.stanford.edu> - Tue, 28 Aug 2018 21:07:08 +0000 - rev 491340
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1486633: Simplify the logic for updating mWatchID in IDTracker.cpp. r=smaug Notes: * NS_Atomize never returns null, so this patch removes a null check on its return value. * There's no need for the |atom| local variable and for our swap() call on it. It's equivalent and simpler for us to just directly assign mWatchID, rather than to use this disposable local variable. Differential Revision: https://phabricator.services.mozilla.com/D4394
707675409147: Bug 1452569 - Implement Event's returnValue. r=smaug
Alphan Chen <alchen@mozilla.com> - Tue, 28 Aug 2018 06:28:56 +0000 - rev 491309
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1452569 - Implement Event's returnValue. r=smaug Add retrunValue into Event's interface Differential Revision: https://phabricator.services.mozilla.com/D4084
9dc25841ff4f: Bug 1486480. Add memory reporting for custom element data. r=smaug
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 27 Aug 2018 19:20:53 +0000 - rev 491285
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1486480. Add memory reporting for custom element data. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D4350
8427667b7c9a: Bug 1452569 - Implement Event's returnValue. r=smaug
Alphan Chen <alchen@mozilla.com> - Mon, 27 Aug 2018 08:08:11 +0000 - rev 491202
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1452569 - Implement Event's returnValue. r=smaug Add retrunValue into Event's interface Differential Revision: https://phabricator.services.mozilla.com/D4084
721d186ac3c3: Bug 1484373: Part 2c - Add Promise::Then handler which accepts a lambda. r=smaug
Kris Maglione <maglione.k@gmail.com> - Sat, 18 Aug 2018 09:43:22 -0700 - rev 490958
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1484373: Part 2c - Add Promise::Then handler which accepts a lambda. r=smaug This makes it easier to add promise handlers from C++ in a manner similar to JavaScript. Differential Revision: https://phabricator.services.mozilla.com/D3692
13e34da7e745: Bug 1484373: Part 2b - Add cycle collection helpers for Tuple types. r=smaug
Kris Maglione <maglione.k@gmail.com> - Sun, 19 Aug 2018 17:43:29 -0700 - rev 490957
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1484373: Part 2b - Add cycle collection helpers for Tuple types. r=smaug
ddba7fcc0d3b: Bug 1484373: Part 1 - Allow querying to ContentFrameMessageManager. r=smaug
Kris Maglione <maglione.k@gmail.com> - Fri, 17 Aug 2018 16:14:43 -0700 - rev 490955
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1484373: Part 1 - Allow querying to ContentFrameMessageManager. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D3691
d57a6d415507: Bug 1485472 - Avoid a couple addref / release in ParseStyleAttribute. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 22 Aug 2018 22:27:12 +0000 - rev 490682
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1485472 - Avoid a couple addref / release in ParseStyleAttribute. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D4008
87b754ac0db0: Bug 1481851 - Add kind to RTCRtpStreamStats as alias to mediaType. r=ng,smaug
Philipp Hancke <fippo@appear.in> - Wed, 08 Aug 2018 17:30:40 +0200 - rev 490630
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1481851 - Add kind to RTCRtpStreamStats as alias to mediaType. r=ng,smaug spec change in https://github.com/w3c/webrtc-stats/issues/301
94cfd6113ca7: Bug 1478171 - [1.0] Forward channel redirect to nsILoadURIDelegate to allow external handling. r=smaug,snorp
Dylan Roeh <droeh@mozilla.com> - Tue, 21 Aug 2018 12:52:39 -0500 - rev 490619
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1478171 - [1.0] Forward channel redirect to nsILoadURIDelegate to allow external handling. r=smaug,snorp
06caf48cb3b5: Bug 1485029 - Use SIMD for PopulateBufferForBinaryString() in FileReader.cpp. r=smaug
Henri Sivonen <hsivonen@hsivonen.fi> - Wed, 22 Aug 2018 13:59:43 +0000 - rev 490595
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1485029 - Use SIMD for PopulateBufferForBinaryString() in FileReader.cpp. r=smaug MozReview-Commit-ID: Gwoj13lFJsJ Differential Revision: https://phabricator.services.mozilla.com/D3889
db66903f54cc: Bug 1484855: Match the 'is rendered' definition from the spec in innerText. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 22 Aug 2018 09:05:09 +0000 - rev 490519
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1484855: Match the 'is rendered' definition from the spec in innerText. r=smaug This matches other implementations and the spec for fallback content like: <canvas><div>abc (calling div.innerText). We're treating the <div> as 'rendered' because it's not in a display: none subtree, but that's not ok, since it is in fact not rendered. This was added in bug 1226293, and Boris suggested this change, but roc opposed because it'd be hard to spec properly in comment 15. Looks like the HTML spec ended up merging roc's innerText spec, and now it's spec'd in terms of 'being rendered'. I think IsOrHasAncestorWithDisplayNone just doesn't work in any reasonable way for stuff out of the flat tree. Thus I think this change is the right thing. The canvas test fails because of bug 1485076. Differential Revision: https://phabricator.services.mozilla.com/D3887
f9417ef4b956: Bug 1485099 - Add some logging to the AntiTracking component for the saving and reading of storage access permissions; r=smaug
Ehsan Akhgari <ehsan@mozilla.com> - Tue, 21 Aug 2018 14:28:49 -0400 - rev 490428
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1485099 - Add some logging to the AntiTracking component for the saving and reading of storage access permissions; r=smaug
1598dc35d16a: Bug 1484773 - Containing shadow could be null after unlink. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 20 Aug 2018 23:28:57 +0000 - rev 490294
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1484773 - Containing shadow could be null after unlink. r=smaug Bug 1483882 removed the line that used to remove the SHADOW_TREE bit during unbind. I missed this caller which still assumed that `IsInShadowTree() -> GetContainingShadow()`. That means that before that patch it was going through nsIDocument::RemoveStyleSheet, which looks pretty wrong to me. Fix it so that we don't remove the stylesheet (we weren't doing it before anyway), but we don't crash. Differential Revision: https://phabricator.services.mozilla.com/D3831
31ed81aa4f46: Bug 1484478 - Use a node bit for connectedness. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 20 Aug 2018 11:56:27 +0000 - rev 490071
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1484478 - Use a node bit for connectedness. r=smaug While trying to repro bug 1484293 I noticed that this assertion failed: https://searchfox.org/mozilla-central/rev/ef8b3886cb173d5534b954b6fb7eb2d94a9473d0/dom/base/ShadowRoot.cpp#160 (during unlink, while unbinding the kids) We rely on GetComposedDoc returning the right thing during unbind to cleanup some stuff (see bug 1473637 for example), so it should probably be correct all the time, regardless of whether something is unlinked or not. Also this makes GetComposedDoc() much faster, which is nice too, since we call it somewhat often. I removed NodeHasRelevantHoverRules, since it's unused (was used by the old style system). I moved the SetIsConnected(false) call for the shadow root to before unbinding the kids for consistency with what Element does with the uncomposed doc flag, now that the children's connectedness doesn't depend on the shadow root's. Differential Revision: https://phabricator.services.mozilla.com/D3715
39f61de4e7bb: Bug 1484478 - Use a node bit for connectedness. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 19 Aug 2018 18:22:48 +0000 - rev 490067
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1484478 - Use a node bit for connectedness. r=smaug While trying to repro bug 1484293 I noticed that this assertion failed: https://searchfox.org/mozilla-central/rev/ef8b3886cb173d5534b954b6fb7eb2d94a9473d0/dom/base/ShadowRoot.cpp#160 (during unlink, while unbinding the kids) We rely on GetComposedDoc returning the right thing during unbind to cleanup some stuff (see bug 1473637 for example), so it should probably be correct all the time, regardless of whether something is unlinked or not. Also this makes GetComposedDoc() much faster, which is nice too, since we call it somewhat often. I removed NodeHasRelevantHoverRules, since it's unused (was used by the old style system). I moved the SetIsConnected(false) call for the shadow root to before unbinding the kids for consistency with what Element does with the uncomposed doc flag, now that the children's connectedness doesn't depend on the shadow root's. Differential Revision: https://phabricator.services.mozilla.com/D3715
2d78ad30fa75: Bug 1484474 - Make the ua widget flag in ShadowRoot write-only. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 18 Aug 2018 21:32:38 +0000 - rev 490066
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1484474 - Make the ua widget flag in ShadowRoot write-only. r=smaug Letting people set it back to false would be bad. Differential Revision: https://phabricator.services.mozilla.com/D3714
777ba79e0e0a: Bug 1484363: Treat FrameMessageManagers as chrome event targets. r=smaug
Kris Maglione <maglione.k@gmail.com> - Fri, 17 Aug 2018 15:11:11 -0700 - rev 489982
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1484363: Treat FrameMessageManagers as chrome event targets. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D3663
89c81ab02543: Bug 1483738: Part 2 - Add MozInvalidForm event, which can be handled in place of notifyInvalidSubmit observers. r=smaug,mconley
Kris Maglione <maglione.k@gmail.com> - Wed, 15 Aug 2018 19:22:30 -0700 - rev 489957
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1483738: Part 2 - Add MozInvalidForm event, which can be handled in place of notifyInvalidSubmit observers. r=smaug,mconley Differential Revision: https://phabricator.services.mozilla.com/D3467
335facce978e: Bug 1483664: Part 0 - Dispatch pagehide/pageshow to all system group listeners on frameloader swap. r=smaug,mconley
Kris Maglione <maglione.k@gmail.com> - Wed, 15 Aug 2018 20:06:49 -0700 - rev 489954
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1483664: Part 0 - Dispatch pagehide/pageshow to all system group listeners on frameloader swap. r=smaug,mconley Having to add pagehide/pageshow listeners to the chrome event target is a serious inconvience for the use cases of this bug. Dispatching to system group listeners has approximately the same effect as the old code, but is much easier for window-bound code to handle.
22cb98ed738b: Bug 1483765 - Fix the image cache key computation logic to only consider first-party storage access for third-party windows; r=smaug
Ehsan Akhgari <ehsan@mozilla.com> - Thu, 16 Aug 2018 16:44:37 -0400 - rev 489950
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1483765 - Fix the image cache key computation logic to only consider first-party storage access for third-party windows; r=smaug