searching for reviewer(sfoster)
96563508f9fed49ddc64469d05c9d3d7be46d547: Bug 1548393 - Generate a digestable password, free of ambiguous characters. r=mhoye,sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Mon, 13 May 2019 20:55:46 +0000 - rev 535579
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1548393 - Generate a digestable password, free of ambiguous characters. r=mhoye,sfoster Differential Revision: https://phabricator.services.mozilla.com/D30249
a42caa9f04fc41044437ac56eab6f6086c841d9f: Bug 1543258 - Handle NULL 'action_url' for Chrome login import. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Thu, 09 May 2019 22:59:18 +0000 - rev 535218
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1543258 - Handle NULL 'action_url' for Chrome login import. r=sfoster Save it with the wildcard "" value so it works with any form action. Differential Revision: https://phabricator.services.mozilla.com/D30332
9f6d0100dec9ef0b8dc7ff7a4dc9f81364812ebc: Bug 1549146 - Resize the subdialog after showing/hiding the Custom DoH textbox to make sure scrollbars appear if necessary. r=sfoster
Jared Wein <jwein@mozilla.com> - Wed, 08 May 2019 15:49:25 +0000 - rev 534966
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1549146 - Resize the subdialog after showing/hiding the Custom DoH textbox to make sure scrollbars appear if necessary. r=sfoster Differential Revision: https://phabricator.services.mozilla.com/D30068
1b84518177e73dba6d06f515d3a09373ca19cfe7: Bug 1549537 - Unconditionally offer 'Span' option for desktop background position on Linux. r=sfoster
Ian Moody <moz-ian@perix.co.uk> - Tue, 07 May 2019 18:36:19 +0000 - rev 534908
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1549537 - Unconditionally offer 'Span' option for desktop background position on Linux. r=sfoster Bug 1544105 added a default implementation of `GfxInfoBase::FindMonitors` so `gfxInfo.getMonitors()` no longer throws on Linux, but it only ever returns the primary monitor there. Differential Revision: https://phabricator.services.mozilla.com/D30096
c22a9760c9eb5b8eac862485e90dd90e0f57be5d: Bug 1547459 - Use explicit text for desktop span preview not being available. r=sfoster
Ian Moody <moz-ian@perix.co.uk> - Mon, 06 May 2019 18:55:57 +0000 - rev 534907
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1547459 - Use explicit text for desktop span preview not being available. r=sfoster When I implemented the no preview for span I did originally try using text in the canvas, but discarded it when I realised trying to format it to display nicely (across different languages and text lengths) was a losing proposition. However just the prohibition symbol without context is confusing to users, and on reflection the text can easily be included as an element stacked on top of the canvas. Also lighten the background of the no preview message, since the pure black was indistinguishable from the frame sides on Windows and Linux. Differential Revision: https://phabricator.services.mozilla.com/D29750
036a4b9e84262578b682d6e36ac60416db334d07: Bug 1549146 - Resize the subdialog after showing/hiding the Custom textbox to make sure scrollbars appear if necessary. r=sfoster
Jared Wein <jwein@mozilla.com> - Mon, 06 May 2019 15:42:33 +0000 - rev 534595
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1549146 - Resize the subdialog after showing/hiding the Custom textbox to make sure scrollbars appear if necessary. r=sfoster Differential Revision: https://phabricator.services.mozilla.com/D30068
33363b7f728c5f4a61ccf7f890ab6f1140a5ef95: Bug 1533533-Add a label to hide synced tabs sidebar when it is shown r=sfoster,jaws,flod
Mohd Umar Alam <umaralam48@gmail.com> - Fri, 26 Apr 2019 06:10:43 +0000 - rev 533332
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1533533-Add a label to hide synced tabs sidebar when it is shown r=sfoster,jaws,flod Differential Revision: https://phabricator.services.mozilla.com/D28177
903c6563775ad6ec3185ba5743ba69d5a1650c2e: Bug 1540154 - Allow autocomplete=(email|tel|tel-national) to be username fields. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Wed, 03 Apr 2019 15:46:57 +0000 - rev 529697
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1540154 - Allow autocomplete=(email|tel|tel-national) to be username fields. r=sfoster Some sites use `email`, `tel` and `tel-national` values for @autocomplete even when they are used as the username and 'username' would be more appropriate. We already allowed type=email / type=tel so allowing the autocomplete equivalents is reasonable. Differential Revision: https://phabricator.services.mozilla.com/D25883
2c01eafb7bb89195e76f6ea8daf817496b27ec44: Bug 1540154 - Allow autocomplete=(email|tel|tel-national) to be username fields. r=sfoster a=pascalc
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Wed, 03 Apr 2019 15:46:57 +0000 - rev 525974
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1540154 - Allow autocomplete=(email|tel|tel-national) to be username fields. r=sfoster a=pascalc Some sites use `email`, `tel` and `tel-national` values for @autocomplete even when they are used as the username and 'username' would be more appropriate. We already allowed type=email / type=tel so allowing the autocomplete equivalents is reasonable. Differential Revision: https://phabricator.services.mozilla.com/D25883
275692bc35bcf6ef35d3bacfa69d43c1e876d52b: Bug 1304001 - Remove unused 'blur' event listener. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Fri, 22 Feb 2019 15:42:53 +0000 - rev 521479
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1304001 - Remove unused 'blur' event listener. r=sfoster The blur event doesn't bubble so this wouldn't actually listen to fields getting blurred. See bug 1138774. Differential Revision: https://phabricator.services.mozilla.com/D20396
d6646400f45d1a63ca75ac04e6b9b109c41970f4: Bug 1304001 - Stop passing the top window to LoginManagerContent. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Fri, 22 Feb 2019 15:41:35 +0000 - rev 521478
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1304001 - Stop passing the top window to LoginManagerContent. r=sfoster It wasn't clear in callee code that the window was the top-window and it wasn't necessary in many cases. Relying on the top-window would also cause problems with Fission if the windows are in separate processes. Differential Revision: https://phabricator.services.mozilla.com/D20395
32398fe05ec236a52a01c27bae96637b222c2bbd: Bug 1304001 - Move LoginUtils._getActionOrigin to LoginHelper. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Fri, 22 Feb 2019 15:41:15 +0000 - rev 521477
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1304001 - Move LoginUtils._getActionOrigin to LoginHelper. r=sfoster Differential Revision: https://phabricator.services.mozilla.com/D20394
e25db31b4a158194ddd1a9742ea14fdf39a4f2e5: Bug 1304001 - Move LoginUtils._getPasswordOrigin to LoginHelper. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Fri, 22 Feb 2019 15:41:03 +0000 - rev 521476
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1304001 - Move LoginUtils._getPasswordOrigin to LoginHelper. r=sfoster There were too many top-level objects in that large JSM and LoginHelper didn't exist when it was added. Differential Revision: https://phabricator.services.mozilla.com/D20393
06877b0fd1a95ec218992e15d8ff08cbf96e99a1: Bug 1304001 - Update comments related to gEnabled/rememberSignons. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Fri, 22 Feb 2019 15:40:43 +0000 - rev 521475
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1304001 - Update comments related to gEnabled/rememberSignons. r=sfoster Fixes some stales comments and identation. Differential Revision: https://phabricator.services.mozilla.com/D20392
61b426c73ccf9351cb3d0fd3a0061f02651b1d2c: Bug 1304001 - Update LoginHelper prefs even if no logger was created. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Fri, 22 Feb 2019 15:40:24 +0000 - rev 521474
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1304001 - Update LoginHelper prefs even if no logger was created. r=sfoster This means there is only one signon.* listener for the whole process, not per-logger. Also move LMC prefs to LMH. Differential Revision: https://phabricator.services.mozilla.com/D20391
275c3744e05930008a7e2c6adbbb1cb8ccba5767: Bug 1304001 - Stop passing the top window to LoginManagerContent. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Thu, 21 Feb 2019 20:19:16 +0000 - rev 521326
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1304001 - Stop passing the top window to LoginManagerContent. r=sfoster It wasn't clear in callee code that the window was the top-window and it wasn't necessary in many cases. Relying on the top-window would also cause problems with Fission if the windows are in separate processes. Differential Revision: https://phabricator.services.mozilla.com/D20395
c9628639b5e13d96e0c7260b5875d3987937d80c: Bug 1304001 - Move LoginUtils._getActionOrigin to LoginHelper. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Thu, 21 Feb 2019 20:18:51 +0000 - rev 521325
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1304001 - Move LoginUtils._getActionOrigin to LoginHelper. r=sfoster Differential Revision: https://phabricator.services.mozilla.com/D20394
7d8f97779a35029dcbc72430464e7254ef1d72ca: Bug 1304001 - Move LoginUtils._getPasswordOrigin to LoginHelper. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Thu, 21 Feb 2019 20:18:39 +0000 - rev 521324
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1304001 - Move LoginUtils._getPasswordOrigin to LoginHelper. r=sfoster There were too many top-level objects in that large JSM and LoginHelper didn't exist when it was added. Differential Revision: https://phabricator.services.mozilla.com/D20393
a5644de3c2f5a4dcb7e9bc4c6b0f822543d8736e: Bug 1304001 - Update comments related to gEnabled/rememberSignons. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Thu, 21 Feb 2019 20:18:19 +0000 - rev 521323
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1304001 - Update comments related to gEnabled/rememberSignons. r=sfoster Fixes some stales comments and identation. Differential Revision: https://phabricator.services.mozilla.com/D20392
e23ef4dbbc7fbd92321aa7deb4be32c11eb7d8bb: Bug 1304001 - Update LoginHelper prefs even if no logger was created. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Thu, 21 Feb 2019 20:18:05 +0000 - rev 521322
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1304001 - Update LoginHelper prefs even if no logger was created. r=sfoster This means there is only one signon.* listener for the whole process, not per-logger. Also move LMC prefs to LMH. Differential Revision: https://phabricator.services.mozilla.com/D20391
5fafa838de111e11253c041ecf98e56f782beac4: Bug 1304001 - Remove unused 'blur' event listener. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Wed, 20 Feb 2019 15:27:34 +0000 - rev 520991
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1304001 - Remove unused 'blur' event listener. r=sfoster The blur event doesn't bubble so this wouldn't actually listen to fields getting blurred. See bug 1138774. Differential Revision: https://phabricator.services.mozilla.com/D20396
d75340a9a2640341f920efe5d924e3d053d97a3f: Bug 1304001 - Stop passing the top window to LoginManagerContent. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Wed, 20 Feb 2019 17:59:59 +0000 - rev 520990
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1304001 - Stop passing the top window to LoginManagerContent. r=sfoster It wasn't clear in callee code that the window was the top-window and it wasn't necessary in many cases. Relying on the top-window would also cause problems with Fission if the windows are in separate processes. Differential Revision: https://phabricator.services.mozilla.com/D20395
ed7ae6b877df5d05ca3c2415d4ac8e0720745d10: Bug 1304001 - Move LoginUtils._getActionOrigin to LoginHelper. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Wed, 20 Feb 2019 15:27:03 +0000 - rev 520989
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1304001 - Move LoginUtils._getActionOrigin to LoginHelper. r=sfoster Differential Revision: https://phabricator.services.mozilla.com/D20394
93bd4d634b1437faf82bd18b1dd1a05556ad7ce5: Bug 1304001 - Move LoginUtils._getPasswordOrigin to LoginHelper. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Wed, 20 Feb 2019 15:26:44 +0000 - rev 520988
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1304001 - Move LoginUtils._getPasswordOrigin to LoginHelper. r=sfoster There were too many top-level objects in that large JSM and LoginHelper didn't exist when it was added. Differential Revision: https://phabricator.services.mozilla.com/D20393
e41015881591d63c4b0a2a34a9b9fb1293208e69: Bug 1304001 - Update comments related to gEnabled/rememberSignons. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Wed, 20 Feb 2019 15:26:29 +0000 - rev 520987
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1304001 - Update comments related to gEnabled/rememberSignons. r=sfoster Fixes some stales comments and identation. Differential Revision: https://phabricator.services.mozilla.com/D20392
6346331d934dd2a9084145509b82ab9045d45cf0: Bug 1304001 - Update LoginHelper prefs even if no logger was created. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Wed, 20 Feb 2019 15:26:10 +0000 - rev 520986
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1304001 - Update LoginHelper prefs even if no logger was created. r=sfoster This means there is only one signon.* listener for the whole process, not per-logger. Also move LMC prefs to LMH. Differential Revision: https://phabricator.services.mozilla.com/D20391
2e27f3f1ebc6f38d98ddd42b6955083f637e2b1b: Bug 1520607 - only disable and re-enable autopositioning while in the process of showing subviews, r=sfoster,mconley
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 23 Jan 2019 11:17:00 +0000 - rev 515097
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1520607 - only disable and re-enable autopositioning while in the process of showing subviews, r=sfoster,mconley Differential Revision: https://phabricator.services.mozilla.com/D17105
a72dafbb2e8089c38cf155f846e2256b90c1aa9e: Bug 1506996 - Hardcode colors in the content blocking shield animation to avoid animating context properties. r=jaws,sfoster
Johann Hofmann <jhofmann@mozilla.com> - Fri, 07 Dec 2018 17:28:32 -0500 - rev 508907
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1506996 - Hardcode colors in the content blocking shield animation to avoid animating context properties. r=jaws,sfoster
8ae95326b1341fc374bc675da049fa966ccd0f80: Bug 1435880 - Send temporary records in paymentDialogWrapper.initializeFrame. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Thu, 15 Nov 2018 15:04:24 +0000 - rev 505842
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1435880 - Send temporary records in paymentDialogWrapper.initializeFrame. r=sfoster Differential Revision: https://phabricator.services.mozilla.com/D11345
aca271fb517576426f43faa02c7b2f3eb42468e5: Bug 1482689 - Don't import payment-dialog.js from other elements. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Tue, 06 Nov 2018 00:19:10 +0000 - rev 503720
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1482689 - Don't import payment-dialog.js from other elements. r=sfoster Importing payment-dialog.js ends up importing every other element because it imports the elements needed to render the full dialog. We don't want all of our elements to depend on every other payment one so we shouldn't import payment-dialog.js anywhere in non-test code. Differential Revision: https://phabricator.services.mozilla.com/D10576
c810cab5dbdba673c6416b047ed9673f3d6b4f56: Bug 1482689 - Don't import payment-dialog.js from other elements. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Thu, 01 Nov 2018 22:01:50 +0000 - rev 503628
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1482689 - Don't import payment-dialog.js from other elements. r=sfoster Importing payment-dialog.js ends up importing every other element because it imports the elements needed to render the full dialog. We don't want all of our elements to depend on every other payment one so we shouldn't import payment-dialog.js anywhere in non-test code. Differential Revision: https://phabricator.services.mozilla.com/D10576
e736a623e623dce4a18d853c077238c545a013ce: Bug 1497225 - Update the required asterisk display when changing countries. r=sfoster,MattN
Jared Wein <jwein@mozilla.com> - Fri, 02 Nov 2018 20:53:12 +0000 - rev 503403
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1497225 - Update the required asterisk display when changing countries. r=sfoster,MattN Differential Revision: https://phabricator.services.mozilla.com/D10637
8cd7b1c3737a583e6c3c5e1dc8287d5db61345f3: Bug 1497225 - Update the required asterisk display when changing countries. r=sfoster,MattN
Jared Wein <jwein@mozilla.com> - Fri, 02 Nov 2018 19:03:39 +0000 - rev 503394
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1497225 - Update the required asterisk display when changing countries. r=sfoster,MattN Differential Revision: https://phabricator.services.mozilla.com/D10637
e782c165223aa344fceb958409ede76b7797b6f2: Bug 1435163 - Show the summary page after the processing page when retry() is called. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Sat, 29 Sep 2018 00:17:50 +0000 - rev 497312
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1435163 - Show the summary page after the processing page when retry() is called. r=sfoster Differential Revision: https://phabricator.services.mozilla.com/D7159
e2d81abcb65594b6033aa84487403d3776e7e84d: Bug 1435163 - Show merchant address errors on billing and payer screens. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Sat, 29 Sep 2018 00:17:42 +0000 - rev 497311
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1435163 - Show merchant address errors on billing and payer screens. r=sfoster Differential Revision: https://phabricator.services.mozilla.com/D7149
42fac3928107b21fb99e63649386484acb34df5f: Bug 1490805 - Include temporary basic cards in validity check for supportedNetworks. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Thu, 27 Sep 2018 05:57:40 +0000 - rev 496961
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1490805 - Include temporary basic cards in validity check for supportedNetworks. r=sfoster Depends on D6848 Differential Revision: https://phabricator.services.mozilla.com/D6882
2b40812f97abd1461265674007c469ae3f059a73: Bug 1490805 - Make the CVV field required on the payment-summary screen. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Thu, 27 Sep 2018 05:40:35 +0000 - rev 496960
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1490805 - Make the CVV field required on the payment-summary screen. r=sfoster Differential Revision: https://phabricator.services.mozilla.com/D6848
32d9dbdfae6b74ee1e1144fc65b8ab1029cb1eff: Bug 1480717 - Fix credit card form billing address and persist checkbox layout. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Mon, 24 Sep 2018 19:51:39 +0000 - rev 496385
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1480717 - Fix credit card form billing address and persist checkbox layout. r=sfoster Differential Revision: https://phabricator.services.mozilla.com/D4175
216c54f4650e71b84713208f628155998e8dad7e: Bug 1463545 - Use text-overflow:ellipsis; on <shipping-option>. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Thu, 20 Sep 2018 21:07:28 +0000 - rev 495999
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1463545 - Use text-overflow:ellipsis; on <shipping-option>. r=sfoster Depends on D5186 Differential Revision: https://phabricator.services.mozilla.com/D6332
1f44117fee2ea257eca27f6015b3437d2ad7cd70: Bug 1463545 - Replace grid layout of <address-option> with a new two line design. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Thu, 20 Sep 2018 21:07:20 +0000 - rev 495998
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1463545 - Replace grid layout of <address-option> with a new two line design. r=sfoster Differential Revision: https://phabricator.services.mozilla.com/D5186
b6cc6d47b5be63bd7b8e36908535a8c06d721d5b: Bug 1463545 - Update the <basic-card-option> layout to match the UI spec. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Thu, 20 Sep 2018 21:07:18 +0000 - rev 495997
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1463545 - Update the <basic-card-option> layout to match the UI spec. r=sfoster Depends on D6330 Differential Revision: https://phabricator.services.mozilla.com/D6331
913329feffe47b17dd6b4e8ba248897d72e32f86: Bug 1463545 - Overlay the selected <rich-option> on top of the native <select>. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Thu, 20 Sep 2018 21:07:09 +0000 - rev 495996
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1463545 - Overlay the selected <rich-option> on top of the native <select>. r=sfoster * We get the shared colours (including hover) and dropmarker. * Makes it harder to regress the clickable area of the <rich-select> since the problem will be visible. * Hides the text for the closed state of the <select> so the <rich-option> text can be presented. Differential Revision: https://phabricator.services.mozilla.com/D6330
1a8ec63c6456d97cae278b46b12323651ad3010b: Bug 1429181 - Make test_payment_method_picker.html work with cc-type. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Wed, 19 Sep 2018 17:06:47 +0000 - rev 495726
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1429181 - Make test_payment_method_picker.html work with cc-type. r=sfoster synthesizeKey requires the prefix of the label which would be whitespace without cc-type so add a cc-type Depends on D6231 Differential Revision: https://phabricator.services.mozilla.com/D6232
f410e48228a944f16d9d17b5a1bbdadccb5f78d9: Bug 1429181 - Fix test_payment_dialog_required_top_level_items.html with cc-type. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Wed, 19 Sep 2018 17:12:18 +0000 - rev 495725
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1429181 - Fix test_payment_dialog_required_top_level_items.html with cc-type. r=sfoster a) We have two names starting with the same prefix: "Mrs." which causes problem when typing on a <select> to filter, especially if the desired option is already selected. b) The prefix of the payment method option would start with whitespace if cc-type is "". c) There would be no state change for the shipping option picker when we're requesting to select the option that's already selected. Depends on D6230 Differential Revision: https://phabricator.services.mozilla.com/D6231
eec81649e2cfbb1ab4bebf6a8630bae352cb4f8c: Bug 1429181 - Fix PaymentTestUtil.DialogContentTasks.select* to work with repeated calls. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Wed, 19 Sep 2018 17:05:09 +0000 - rev 495724
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1429181 - Fix PaymentTestUtil.DialogContentTasks.select* to work with repeated calls. r=sfoster Also fix test_basic_card_form.html and browser_show_dialog.js Differential Revision: https://phabricator.services.mozilla.com/D6230
2b24a0fca9b7287a19c17d9161427a7bef010939: Bug 1489629 - Adjust the size of the error images, sizing and position of text, and add footer branding to the error pages. r=sfoster
Jared Wein <jwein@mozilla.com> - Mon, 10 Sep 2018 18:16:55 +0000 - rev 493991
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1489629 - Adjust the size of the error images, sizing and position of text, and add footer branding to the error pages. r=sfoster Differential Revision: https://phabricator.services.mozilla.com/D5320
f669be991db69be9df911a29db5a97d5b135b685: Bug 1482808 - Clear the field-specific merchant error invalid state when the field has been edited. r=sfoster
Jared Wein <jwein@mozilla.com> - Fri, 07 Sep 2018 23:15:09 +0000 - rev 493780
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1482808 - Clear the field-specific merchant error invalid state when the field has been edited. r=sfoster Differential Revision: https://phabricator.services.mozilla.com/D5081
4b50d292d249836da7c3d9b969bd6156ac196702: Bug 1485837 - Position merchant field-specific error messages relative to the height of their related input field. r=sfoster
Jared Wein <jwein@mozilla.com> - Fri, 07 Sep 2018 23:18:50 +0000 - rev 493779
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1485837 - Position merchant field-specific error messages relative to the height of their related input field. r=sfoster Differential Revision: https://phabricator.services.mozilla.com/D5302
e9d83a2e788a8ff884016bb1bbec3a0efeda3f33: Bug 1487395 - Update strings on error pages, as well as convert apostrophes to use 'smart-quotes'. r=sfoster
Jared Wein <jwein@mozilla.com> - Thu, 06 Sep 2018 19:43:19 +0000 - rev 493551
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1487395 - Update strings on error pages, as well as convert apostrophes to use 'smart-quotes'. r=sfoster Differential Revision: https://phabricator.services.mozilla.com/D5068
ba1272b8b6390e8413e5d54f500914b1a95d72ba: Bug 1480886 - Position the form fields for the address-form and basic-card-form according to the spec. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Tue, 28 Aug 2018 15:34:50 -0700 - rev 491461
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1480886 - Position the form fields for the address-form and basic-card-form according to the spec. r=sfoster Based on work by Jared Wein. A follow-up will handle the persist checkbox and billing address. Differential Revision: https://phabricator.services.mozilla.com/D4174