searching for reviewer(sfink)
bb9c48a4e71aa927d148b7e91dfda6417c507c13: Bug 1522817 - Always expose returned target object of wrapper r=sfink a=pascalc DEVEDITION_67_0b16_BUILD2 DEVEDITION_67_0b16_RELEASE FENNEC_67_0b16_BUILD2 FENNEC_67_0b16_RELEASE FIREFOX_67_0b16_BUILD2 FIREFOX_67_0b16_RELEASE
Jon Coppeard <jcoppeard@mozilla.com> - Mon, 29 Apr 2019 16:06:09 +0100 - rev 526467
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1522817 - Always expose returned target object of wrapper r=sfink a=pascalc The comment here talks about unmarking wrapper targets in case we're in incremental GC, but it does it conditially based on the color of the wrapper. We can't depend on that because a wrapper marked gray may eventually be marked black. Also, I don't think we should be touching gray wrappers anyway. Let's just always expose here. Differential Revision: https://phabricator.services.mozilla.com/D29211
340c569378b94bba026080ad8f42e494637fb3f3: Bug 1536447 - Use HeapPtr rather than Heap pointer wrappers in ctypes r=sfink a=pascalc
Jon Coppeard <jcoppeard@mozilla.com> - Tue, 19 Mar 2019 14:39:58 +0000 - rev 526024
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1536447 - Use HeapPtr rather than Heap pointer wrappers in ctypes r=sfink a=pascalc
d45e5b4b57b98f6bf0fa85e951087a7359d5b1d7: Bug 1532946 - Tidy allocation functions by renaming overloads for object and string allocation r=sfink
Jon Coppeard <jcoppeard@mozilla.com> - Mon, 11 Mar 2019 07:02:39 +0000 - rev 524331
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1532946 - Tidy allocation functions by renaming overloads for object and string allocation r=sfink This patch attempts to make things clearer by renaming the functions used for allocating objects and strings to AllocateObject and AllocateString, rather than having everything be called Allocate. Allocate is still used for atoms though which is a little strange but was hard to change. Differential Revision: https://phabricator.services.mozilla.com/D22275
b8137cbaf9cfa4f4c45cb9bd82584b4375ba2662: Bug 1532946 - Tidy allocation functions by renaming overloads for object and string allocation r=sfink
Jon Coppeard <jcoppeard@mozilla.com> - Wed, 06 Mar 2019 11:23:08 +0000 - rev 523784
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1532946 - Tidy allocation functions by renaming overloads for object and string allocation r=sfink
f4e9e5429fd82f9c3787ca2d42798a2bf3d353f9: Bug 1532005 - Implement a new js/public/ArrayBuffer.h header to centralize functionality for creating and interacting with ArrayBuffers. r=sfink
Jeff Walden <jwalden@mit.edu> - Mon, 04 Mar 2019 15:19:16 -0800 - rev 523216
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1532005 - Implement a new js/public/ArrayBuffer.h header to centralize functionality for creating and interacting with ArrayBuffers. r=sfink Differential Revision: https://phabricator.services.mozilla.com/D21827
738cf4b1126a5e2daa22fe3f8e653b35da0306ad: Bug 1532005 - Implement a new js/public/ArrayBuffer.h header to centralize functionality for creating and interacting with ArrayBuffers. r=sfink
Jeff Walden <jwalden@mit.edu> - Thu, 28 Feb 2019 17:00:56 -0800 - rev 523193
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1532005 - Implement a new js/public/ArrayBuffer.h header to centralize functionality for creating and interacting with ArrayBuffers. r=sfink Differential Revision: https://phabricator.services.mozilla.com/D21827
ab0fd75fd14200dc24e08d6c5b67e044c09bd59f: Bug 1531540 - Don't specialise SubChunkLimit for mobile r=sfink
Paul Bone <pbone@mozilla.com> - Fri, 01 Mar 2019 17:53:38 +0000 - rev 523067
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1531540 - Don't specialise SubChunkLimit for mobile r=sfink This was specialised so that it wouldn't crash on mobile wouldn't crash when: SubChunkLimit + SubChunkStepstep > NurseryChunkUsableSize becase NurseryChunkUsableSize is smaller on mobile. However Bug 1530575 reduced the value of SubChunkStep so now we no-longer need to specialise SubChunkLimit. We never tested the impact of SubChunkLimit on mobile so it's just simpler to have one value. Differential Revision: https://phabricator.services.mozilla.com/D21645
dab1f2af9040b67c0458bc83b1a6ddd149735a3a: Bug 1528159 - Add finishgc() calls before each startgc() call r=sfink
Paul Bone <pbone@mozilla.com> - Fri, 01 Mar 2019 17:55:13 +0000 - rev 523021
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1528159 - Add finishgc() calls before each startgc() call r=sfink Avoid assertion failures with this test by adding finishgc() calls. Add finisgc() shell builtin functions. Differential Revision: https://phabricator.services.mozilla.com/D21644
a456a1594cb1960c465dc7a582134710f286fcf9: Bug 1530573 - Protect maybeResizeNursery() from overflow r=sfink
Paul Bone <pbone@mozilla.com> - Fri, 01 Mar 2019 00:09:09 +0000 - rev 522715
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1530573 - Protect maybeResizeNursery() from overflow r=sfink Differential Revision: https://phabricator.services.mozilla.com/D21158
664a5bdd8ab159d09bb75148a59ff5eaeafdabe8: Bug 1531018 - Update BigInt hashing to account for the possiblity of moving GC r=sfink
Jon Coppeard <jcoppeard@mozilla.com> - Thu, 28 Feb 2019 17:33:49 +0000 - rev 522627
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1531018 - Update BigInt hashing to account for the possiblity of moving GC r=sfink
1edf55d690f2deed93a506589c4053a962f0758e: Bug 1531035 - Assert that weak map keys are not null r=sfink
Jon Coppeard <jcoppeard@mozilla.com> - Thu, 28 Feb 2019 16:38:49 +0000 - rev 522626
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1531035 - Assert that weak map keys are not null r=sfink
70b353cfbbf301b0175d6b36a957fd49479a5b2d: Bug 1530643 - Check for allocation failure when initialising sweep actions r=sfink
Jon Coppeard <jcoppeard@mozilla.com> - Thu, 28 Feb 2019 16:38:48 +0000 - rev 522625
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1530643 - Check for allocation failure when initialising sweep actions r=sfink
ba49b929457a6df36413a33ce0270af65ad472e1: Bug 1319468 - Part 2: Use Rooted<GCVector> for AutoLookupVector. r=sfink
Yoshi Cheng-Hao Huang <allstars.chh@gmail.com> - Wed, 13 Feb 2019 23:27:52 +0100 - rev 522617
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1319468 - Part 2: Use Rooted<GCVector> for AutoLookupVector. r=sfink
bb879a6a95f89fc3319899d3267c77a071d88076: Bug 1529298 - Implement ArrayBufferObject::prepareForAsmJS using a switch, not a series of ifs that's less obviously exhaustive. r=sfink
Jeff Walden <jwalden@mit.edu> - Thu, 21 Feb 2019 17:58:46 -0800 - rev 522509
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529298 - Implement ArrayBufferObject::prepareForAsmJS using a switch, not a series of ifs that's less obviously exhaustive. r=sfink
9103748036d1d9f72d34474014c9ce0267271eb5: Bug 1529298 - Inline ArrayBufferObject::setNewData into its sole caller. r=sfink
Jeff Walden <jwalden@mit.edu> - Wed, 20 Feb 2019 13:51:58 -0800 - rev 522508
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529298 - Inline ArrayBufferObject::setNewData into its sole caller. r=sfink
ab967077f8a309b0d383297d071cd8397a100f7c: Bug 1529298 - Remove the |newContents| argument from ArrayBufferObject::detach that's now identical for every caller. r=sfink
Jeff Walden <jwalden@mit.edu> - Wed, 20 Feb 2019 13:51:58 -0800 - rev 522507
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529298 - Remove the |newContents| argument from ArrayBufferObject::detach that's now identical for every caller. r=sfink
973c3800d5d6c10e06ce653add01316f9b0ee25e: Bug 1529298 - Remove ArrayBufferObject::change{,View}Contents as unused. r=sfink
Jeff Walden <jwalden@mit.edu> - Wed, 20 Feb 2019 13:51:58 -0800 - rev 522506
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529298 - Remove ArrayBufferObject::change{,View}Contents as unused. r=sfink
694fe0c4379319644cd9f64781fcb71a75558ed5: Bug 1529298 - Remove setOwnsData and the OWNS_DATA flag. r=sfink
Jeff Walden <jwalden@mit.edu> - Wed, 20 Feb 2019 13:33:17 -0800 - rev 522505
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529298 - Remove setOwnsData and the OWNS_DATA flag. r=sfink
650bd5a18809655323834c7b56d84ad6c512d752: Bug 1529298 - Now that |ownsData()| is always true, inline that true value into all callers. r=sfink
Jeff Walden <jwalden@mit.edu> - Wed, 20 Feb 2019 13:33:17 -0800 - rev 522504
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529298 - Now that |ownsData()| is always true, inline that true value into all callers. r=sfink
ef4c27821811d19a0dc64e4d9b4d2e7841bb1370: Bug 1529298 - Remove the useless OwnsState argument from ArrayBufferObject::setDataPointer. r=sfink
Jeff Walden <jwalden@mit.edu> - Wed, 20 Feb 2019 13:33:17 -0800 - rev 522503
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529298 - Remove the useless OwnsState argument from ArrayBufferObject::setDataPointer. r=sfink
a06864bc83520a544a3412f81b5d3ef0e930138b: Bug 1529298 - Remove the useless OwnsState argument from ArrayBufferObject::initialize. r=sfink
Jeff Walden <jwalden@mit.edu> - Wed, 20 Feb 2019 13:33:17 -0800 - rev 522502
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529298 - Remove the useless OwnsState argument from ArrayBufferObject::initialize. r=sfink
f4101f4427821666a773c683fc893e977c81946b: Bug 1529298 - Inline the contents of a fresh |if (true) { ... }| in ArrayBufferObject::createForContent. r=sfink
Jeff Walden <jwalden@mit.edu> - Wed, 20 Feb 2019 13:33:16 -0800 - rev 522501
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529298 - Inline the contents of a fresh |if (true) { ... }| in ArrayBufferObject::createForContent. r=sfink
870a5571096968b606babc8eb1f7c495c18ddf1c: Bug 1529298 - Remove the useless OwnsState argument from ArrayBufferObject::createForContent. r=sfink
Jeff Walden <jwalden@mit.edu> - Wed, 20 Feb 2019 13:33:16 -0800 - rev 522500
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529298 - Remove the useless OwnsState argument from ArrayBufferObject::createForContent. r=sfink
713088adfe5f3c60bdb08254b2768c70731db317: Bug 1529298 - Remove the useless OwnsState argument from ArrayBufferObject::setNewData. r=sfink
Jeff Walden <jwalden@mit.edu> - Wed, 20 Feb 2019 13:33:16 -0800 - rev 522499
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529298 - Remove the useless OwnsState argument from ArrayBufferObject::setNewData. r=sfink
a7a39ff0615820e92079562b305e996865e7b56f: Bug 1529298 - Remove the useless OwnsState argument from ArrayBufferObject::changeContents. r=sfink
Jeff Walden <jwalden@mit.edu> - Wed, 20 Feb 2019 13:33:16 -0800 - rev 522498
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529298 - Remove the useless OwnsState argument from ArrayBufferObject::changeContents. r=sfink
5cb592de5e03d0df8254bbd779d84760b0d16eef: Bug 1529298 - Remove ArrayBufferObject::stealContents now that it's unused. r=sfink
Jeff Walden <jwalden@mit.edu> - Wed, 20 Feb 2019 13:33:16 -0800 - rev 522497
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529298 - Remove ArrayBufferObject::stealContents now that it's unused. r=sfink
63536a044a29b3f723e3ee829f260dafc41feb54: Bug 1529298 - Implement an ArrayBufferObject::extractStructuredCloneContents for structured-cloning an ArrayBuffer. r=sfink
Jeff Walden <jwalden@mit.edu> - Wed, 20 Feb 2019 13:33:16 -0800 - rev 522496
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529298 - Implement an ArrayBufferObject::extractStructuredCloneContents for structured-cloning an ArrayBuffer. r=sfink
a9638eeea75714425a28e5bcd9edb9ae55dd13b9: Bug 1529298 - Make ArrayBufferObject::wasmGrowToSizeInPlace do its work *not* using ArrayBufferObject::stealContents, rather using the exact operations desired, far more simply. r=sfink
Jeff Walden <jwalden@mit.edu> - Wed, 20 Feb 2019 13:33:16 -0800 - rev 522485
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529298 - Make ArrayBufferObject::wasmGrowToSizeInPlace do its work *not* using ArrayBufferObject::stealContents, rather using the exact operations desired, far more simply. r=sfink
715e9b139ebbd407ac64b5ee8737d0f042f74b4c: Bug 1529298 - Implement an ArrayBufferObject::stealMallocedContents for use in JS_StealArrayBufferContents, rather than reusing the hoary ArrayBufferObject::stealContents with finicky caller-side should-this-steal logic. r=sfink
Jeff Walden <jwalden@mit.edu> - Wed, 20 Feb 2019 13:33:15 -0800 - rev 522484
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529298 - Implement an ArrayBufferObject::stealMallocedContents for use in JS_StealArrayBufferContents, rather than reusing the hoary ArrayBufferObject::stealContents with finicky caller-side should-this-steal logic. r=sfink
f487c864d2abb77498667161baf187b3ecb7f995: Bug 1529298 - Make NoteViewBufferWasDetached a lambda instead of a global function. r=sfink
Jeff Walden <jwalden@mit.edu> - Wed, 20 Feb 2019 13:33:15 -0800 - rev 522483
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529298 - Make NoteViewBufferWasDetached a lambda instead of a global function. r=sfink
d8a4ce77f2f10639b3a5783b5961319d35342711: Bug 1529298 - Remove most uses of DoesntOwnData for NO_DATA and USER_OWNED and make current users that depend on |ownsData()| not do so. r=sfink
Jeff Walden <jwalden@mit.edu> - Mon, 18 Feb 2019 23:13:48 -0800 - rev 522482
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529298 - Remove most uses of DoesntOwnData for NO_DATA and USER_OWNED and make current users that depend on |ownsData()| not do so. r=sfink
ac3ad3942d6791b7df823d87b23f68efdfa7317a: Bug 1529298 - Remove |ArrayBufferObject::hasStealableContents()| and replace it with its contents, appropriately simplified for each calling location. r=sfink
Jeff Walden <jwalden@mit.edu> - Mon, 18 Feb 2019 23:06:33 -0800 - rev 522481
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529298 - Remove |ArrayBufferObject::hasStealableContents()| and replace it with its contents, appropriately simplified for each calling location. r=sfink
1a6bfb6eba8a3c91cee898badfff9a73a72ad8ab: Bug 1506761 - Fix existing spelling error r=sfink
Paul Bone <pbone@mozilla.com> - Wed, 27 Feb 2019 03:36:56 +0000 - rev 522283
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1506761 - Fix existing spelling error r=sfink Differential Revision: https://phabricator.services.mozilla.com/D20813
df61ae31e2a8f47b6f07f4bf0e3f5fc8b252bc4c: Bug 1506761 - Add a fraction threshold for collecting the nursery r=sfink
Paul Bone <pbone@mozilla.com> - Wed, 27 Feb 2019 03:36:54 +0000 - rev 522282
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1506761 - Add a fraction threshold for collecting the nursery r=sfink We collect the nursery in idle time if there is less than 256KB of space remaining. However when the nursery is small this doesn't make sense, so add a percentage-based threshold to be used when the nursery is small. Differential Revision: https://phabricator.services.mozilla.com/D20247
705b9ae4d7280aac57cd326467387b77424aaab6: Bug 1530575 - Reduce SubChunkStep r=sfink
Paul Bone <pbone@mozilla.com> - Wed, 27 Feb 2019 02:59:27 +0000 - rev 522279
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1530575 - Reduce SubChunkStep r=sfink I initially set this to 64K thinking that it'd prevent too much changing of the nursery size and therefore (once implemented) too many calls to madvise. But that's not true, because the nursery only changes size when a tenure rate threshold is hit, and once it does it always changes size. So we can reduce this to 4K for simplicity and alignment with other constants. Differential Revision: https://phabricator.services.mozilla.com/D21157
95d2d41b9d5b932a410d61491c866b4af6820454: Bug 1527532 - Make initial nursery size smaller r=sfink
Paul Bone <pbone@mozilla.com> - Mon, 25 Feb 2019 02:49:17 +0000 - rev 521718
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1527532 - Make initial nursery size smaller r=sfink Differential Revision: https://phabricator.services.mozilla.com/D19349
696c4b4978addce673d53097f377140ee140f964: Bug 1527767 - Make all JS allocator functions accept an arena as an argument r=sfink
Chris Martin <cmartin@mozilla.com> - Fri, 22 Feb 2019 18:12:05 +0000 - rev 521527
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1527767 - Make all JS allocator functions accept an arena as an argument r=sfink Currently, some of the JS allocators accept an 'arena' argument, but some don't. This change makes it so they all do. This is nice for consistency, but it also feeds into Bug 1052579, which will need to use arenas for JSString backing buffers. Differential Revision: https://phabricator.services.mozilla.com/D19717
5b7a07b449ba9d2a0737a3d193d8fec3984ab9ca: Bug 1529298 - Initialize all ArrayBuffers that store their data inline using a single function. r=sfink
Jeff Walden <jwalden@mit.edu> - Mon, 18 Feb 2019 23:06:28 -0800 - rev 521433
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529298 - Initialize all ArrayBuffers that store their data inline using a single function. r=sfink
3556d94cbc81358a0dbe561079b71f924c235d3f: Bug 1529298 - Add BufferKind::NO_DATA for ArrayBuffers that have no data (whether because byteLength is zero or because the ArrayBuffer is detached), for which the value of |ownsData()| is irrelevant. r=sfink
Jeff Walden <jwalden@mit.edu> - Mon, 18 Feb 2019 22:53:37 -0800 - rev 521432
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529298 - Add BufferKind::NO_DATA for ArrayBuffers that have no data (whether because byteLength is zero or because the ArrayBuffer is detached), for which the value of |ownsData()| is irrelevant. r=sfink
1cead3a873e2b866f6ffdc1e1f9a83442070a72c: Bug 1529298 - Remove ArrayBufferOffset::offsetOfFlags as unused. r=sfink
Jeff Walden <jwalden@mit.edu> - Mon, 18 Feb 2019 22:52:42 -0800 - rev 521431
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529298 - Remove ArrayBufferOffset::offsetOfFlags as unused. r=sfink
dcdddf46e820597ddcc985590782fd393cf4291b: Bug 1529298 - Add BufferContents::createFoo functions for every kind so that the templaty, harder-to-search-for create function can be removed. r=sfink
Jeff Walden <jwalden@mit.edu> - Mon, 18 Feb 2019 22:52:42 -0800 - rev 521430
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529298 - Add BufferContents::createFoo functions for every kind so that the templaty, harder-to-search-for create function can be removed. r=sfink
76e407233988bf81de782ec951887e02e43a8d09: Bug 1529298 - Consistently use "ArrayBuffer" instead of the vaguer "array buffer" in ArrayBuffer-related JSAPI descriptions. r=sfink
Jeff Walden <jwalden@mit.edu> - Mon, 18 Feb 2019 22:52:42 -0800 - rev 521429
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529298 - Consistently use "ArrayBuffer" instead of the vaguer "array buffer" in ArrayBuffer-related JSAPI descriptions. r=sfink
b2c09226e55b6d3b19160b585bc177d8df528264: Bug 1529298 - Simplify ArrayBufferObject::createForContents some now that it's only ever passed non-null contents. r=sfink
Jeff Walden <jwalden@mit.edu> - Mon, 18 Feb 2019 22:52:42 -0800 - rev 521428
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529298 - Simplify ArrayBufferObject::createForContents some now that it's only ever passed non-null contents. r=sfink
4771a589408dc33f8751eb8b4c9fc2b087967ae9: Bug 1529298 - Only pass BufferContents containing a non-null pointer to |ArrayBufferObject::createForContents|. r=sfink
Jeff Walden <jwalden@mit.edu> - Mon, 18 Feb 2019 22:52:42 -0800 - rev 521427
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529298 - Only pass BufferContents containing a non-null pointer to |ArrayBufferObject::createForContents|. r=sfink
51d373ab477b31f1306de895e235e9a879a5c099: Bug 1529298 - Make AllocateArrayBufferContents return uint8_t*, and make its callers consistently not redundantly report OOMs. r=sfink
Jeff Walden <jwalden@mit.edu> - Mon, 18 Feb 2019 22:52:42 -0800 - rev 521426
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529298 - Make AllocateArrayBufferContents return uint8_t*, and make its callers consistently not redundantly report OOMs. r=sfink
92fc3d9b6699885b0af2feb47b9577640d6d2898: Bug 1529298 - Remove trailing arguments to ArrayBufferObject::createForContents that are identical for every caller. r=sfink
Jeff Walden <jwalden@mit.edu> - Mon, 18 Feb 2019 22:52:42 -0800 - rev 521425
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529298 - Remove trailing arguments to ArrayBufferObject::createForContents that are identical for every caller. r=sfink
765bc7a86f726c7fd3633ca29026cc10f4950864: Bug 1529298 - Rename the two ArrayBufferObject::create overloads to ArrayBufferObject::create{Zeroed,WithContents}, and inline a simplified form of the more-complex ArrayBufferObject::create into the new createZeroed function. r=sfink
Jeff Walden <jwalden@mit.edu> - Mon, 18 Feb 2019 22:52:41 -0800 - rev 521424
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529298 - Rename the two ArrayBufferObject::create overloads to ArrayBufferObject::create{Zeroed,WithContents}, and inline a simplified form of the more-complex ArrayBufferObject::create into the new createZeroed function. r=sfink
5a304d4b53c05587d9da2fdb4db5276380c6ff5b: Bug 1529298 - Remove ArrayBufferObject::hasData and perform its operation in its sole caller in a more straightforward manner. r=sfink
Jeff Walden <jwalden@mit.edu> - Mon, 18 Feb 2019 22:52:41 -0800 - rev 521423
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529298 - Remove ArrayBufferObject::hasData and perform its operation in its sole caller in a more straightforward manner. r=sfink
76600605e1e3ce8a54e7ab8c1d98851cad365959: Bug 1529298 - Remove JS_ExternalizeArrayBufferContents because it has no users except in tests, implements complicated ownership semantics, and is definite implementation complexity. r=sfink
Jeff Walden <jwalden@mit.edu> - Mon, 18 Feb 2019 22:52:41 -0800 - rev 521422
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529298 - Remove JS_ExternalizeArrayBufferContents because it has no users except in tests, implements complicated ownership semantics, and is definite implementation complexity. r=sfink
9e5e10661a782ba3bd5836eef5505b3f10e09967: Bug 1529298 - Move most of JS_ExternalizeArrayBufferContents into a static member function on ArrayBufferObject so that internals-observing code isn't smeared across two functions. r=sfink
Jeff Walden <jwalden@mit.edu> - Mon, 18 Feb 2019 22:52:41 -0800 - rev 521421
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529298 - Move most of JS_ExternalizeArrayBufferContents into a static member function on ArrayBufferObject so that internals-observing code isn't smeared across two functions. r=sfink