searching for reviewer(sebastian)
9c712980e9709732e4966d404f50267566d3b149: Bug 1545232 - Add AuthStateProvider r=nalexander,sebastian
Grisha Kruglov <gkruglov@mozilla.com> - Mon, 22 Apr 2019 20:07:34 +0000 - rev 532292
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1545232 - Add AuthStateProvider r=nalexander,sebastian See comments in the patch for details. Differential Revision: https://phabricator.services.mozilla.com/D28001
dc1cbac5213d6027127892e460a852bbf6e683b3: Bug 1545232 - Add AuthStateProvider r=nalexander,sebastian
Grisha Kruglov <gkruglov@mozilla.com> - Thu, 18 Apr 2019 22:22:40 +0000 - rev 532038
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1545232 - Add AuthStateProvider r=nalexander,sebastian See comments in the patch for details. Differential Revision: https://phabricator.services.mozilla.com/D28001
ded211603671be4210c80f5c2f17c0a4a5f9ceb7: Bug 1545232 - Add AuthStateProvider r=nalexander,sebastian a=pascalc
Grisha Kruglov <gkruglov@mozilla.com> - Mon, 22 Apr 2019 20:07:34 +0000 - rev 526370
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1545232 - Add AuthStateProvider r=nalexander,sebastian a=pascalc See comments in the patch for details. Differential Revision: https://phabricator.services.mozilla.com/D28001
3f2e61c2ab7cc9378f923b59f26edc497e3db235: Bug 1514861. Add Google Analytics params to report site issue endpoint requests. r=sebastian,mkaply
Mike Taylor <miket@mozilla.com> - Thu, 20 Dec 2018 17:45:37 +0000 - rev 511561
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1514861. Add Google Analytics params to report site issue endpoint requests. r=sebastian,mkaply Add Google Analytics params to report site issue endpoint requests Differential Revision: https://phabricator.services.mozilla.com/D14899
288a2128adc5f6bbfc92619aabf99a80d857190e: Bug 1489132 - Ensure geckoview build numbers are always MAJOR.MINOR.BUILDID r=sebastian,jchen
Johan Lorenzo <jlorenzo@mozilla.com> - Mon, 10 Sep 2018 09:39:44 +0000 - rev 493806
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1489132 - Ensure geckoview build numbers are always MAJOR.MINOR.BUILDID r=sebastian,jchen Ensure geckoview build numbers are always MAJOR.MINOR.BUILDID Differential Revision: https://phabricator.services.mozilla.com/D5290
e654bee36498bb850cac4f7418ad14f8e68043cc: Bug 1489132 - Ensure geckoview build numbers are always MAJOR.MINOR.BUILDID r=sebastian,jchen a=release
Johan Lorenzo <jlorenzo@mozilla.com> - Fri, 07 Sep 2018 16:14:08 +0200 - rev 492417
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1489132 - Ensure geckoview build numbers are always MAJOR.MINOR.BUILDID r=sebastian,jchen a=release Summary: Ensure geckoview build numbers are always MAJOR.MINOR.BUILDID Test Plan: https://tools.taskcluster.net/groups/GO4L4WxkTTiwlF-OvPRsrQ/tasks/MK0jdBw8QRmcLM-MbUROIg/runs/0/logs/public%2Flogs%2Flive_backing.log#L1770 Even though MOZ_APP_VERSION is 64.0.1, maven version is 64.0.20180907165027 Reviewers: sebastian, jchen Tags: #secure-revision Bug #: 1489132 Differential Revision: https://phabricator.services.mozilla.com/D5290
75b8ac536f30108bcefb6ffa139a1b57bc43f878: Bug 1484932 - Update GeckoView maven group id: org.mozilla.geckoview r=sebastian,jchen
Johan Lorenzo <jlorenzo@mozilla.com> - Tue, 28 Aug 2018 13:04:09 +0000 - rev 491514
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1484932 - Update GeckoView maven group id: org.mozilla.geckoview r=sebastian,jchen Update GeckoView maven group id: org.mozilla.geckoview Differential Revision: https://phabricator.services.mozilla.com/D4344
a2e7223d34fcb8eefedf5aa303ad9f0b9fe9b5e0: Bug 1476552 - GeckoSession::WebResponseInfo Kotlin annotations and static r=sebastian
Raynald Mirville <raynald.mirville@gmail.com> - Tue, 28 Aug 2018 13:02:23 +0000 - rev 491297
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1476552 - GeckoSession::WebResponseInfo Kotlin annotations and static r=sebastian MozReview-Commit-ID: 1HWEStKaGVl Bug 1476552 part 1 - Add @NonNull/@Nullable annotations to GeckoSession::WebResponseInfo for Kotlin interoperability Bug 1476552 part 2 - Make GeckoSession::WebResponseInfo static MozReview-Commit-ID: 4ce92G7i2nz Differential Revision: https://phabricator.services.mozilla.com/D2885
46ea394f0c30fdfef5cc24baa78a667e9e0c1dc0: Bug 1464990 - Allow easier testing Switchboard experiments; r=jchen,sebastian
Petru Lingurar <petru.lingurar@softvision.ro> - Thu, 21 Jun 2018 09:33:20 +0300 - rev 479962
Push 1757 by ffxbld-merge at Fri, 24 Aug 2018 17:02:43 +0000
Bug 1464990 - Allow easier testing Switchboard experiments; r=jchen,sebastian Based on Sebastian's addon - https://github.com/pocmo/Addon-Switchboard-Experiments, this will allow to easily enable / disable Switchboard experiments, process that after Firefox 57 and the obsolescence of the addon was too cumbersome. MozReview-Commit-ID: 2EkYQ42Bd8B
4d3bc187d05c62dffe50132f328b71220db3f884: Bug 792808 - Change mobile/android/ to import and instantiate XHRs from global properties rather than using Cc.createInstance(Ci.nsIXMLHttpRequest); r=sebastian
Thomas Wisniewski <wisniewskit@gmail.com> - Tue, 19 Sep 2017 12:05:47 -0400 - rev 459173
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
Bug 792808 - Change mobile/android/ to import and instantiate XHRs from global properties rather than using Cc.createInstance(Ci.nsIXMLHttpRequest); r=sebastian MozReview-Commit-ID: JHIHB11vdWL
298a722b096ef75a273ac4c3b21c848d75888db3: Bug 1372517 - Escape name before joining innerHTML, r=sebastian
maliu <max@mxli.us> - Fri, 26 Jan 2018 10:04:54 -0600 - rev 456049
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
Bug 1372517 - Escape name before joining innerHTML, r=sebastian MozReview-Commit-ID: 8Wh6SCuHK6F
8ac8d4c54c2b402cee26fd9a1e51acdf68f2d5c0: Bug 1372517 - Escape name before joining innerHTML. r=sebastian, a=lizzard
maliu <max@mxli.us> - Fri, 26 Jan 2018 10:04:54 -0600 - rev 454583
Push 1648 by mtabara@mozilla.com at Thu, 01 Mar 2018 12:45:47 +0000
Bug 1372517 - Escape name before joining innerHTML. r=sebastian, a=lizzard MozReview-Commit-ID: 8Wh6SCuHK6F
733552921142a406e7d423ebb3b193d5f44ef4a0: Bug 1421874 - Fix SessionStore to include AppConstants before using it; r=sebastian
Gabriele Svelto <gsvelto@mozilla.com> - Fri, 01 Dec 2017 15:11:21 +0100 - rev 448984
Push 1648 by mtabara@mozilla.com at Thu, 01 Mar 2018 12:45:47 +0000
Bug 1421874 - Fix SessionStore to include AppConstants before using it; r=sebastian MozReview-Commit-ID: IOSHvaOOE19
ff75ef015293c18eb00f34b0df278c36f292bf94: Bug 1374574 - Remove the FlyWeb system add-on from Fennec. r=ahunt,sebastian
Johann Hofmann <jhofmann@mozilla.com> - Wed, 22 Nov 2017 14:49:35 +0100 - rev 448117
Push 1648 by mtabara@mozilla.com at Thu, 01 Mar 2018 12:45:47 +0000
Bug 1374574 - Remove the FlyWeb system add-on from Fennec. r=ahunt,sebastian MozReview-Commit-ID: AyYD4HedXFv
9542e943f1003419847cf01925556a130b3fbcef: Bug 1415297 - Dispatch TabEvents.LOADED again on DOMContentLoaded. r=sebastian
Jan Henning <jh+bugzilla@buttercookie.de> - Tue, 07 Nov 2017 22:07:05 +0100 - rev 448075
Push 1648 by mtabara@mozilla.com at Thu, 01 Mar 2018 12:45:47 +0000
Bug 1415297 - Dispatch TabEvents.LOADED again on DOMContentLoaded. r=sebastian AddToHomeScreenPromotion uses this for triggering the self-same promotion and the BrowserToolbar uses it to update its progress display. MozReview-Commit-ID: 1xrwjWP5Idh
c7986c821efe5d4d122784da3547299de5086de7: Bug 1392538 - Remove unused onboarding experiments. r=sebastian
Nevin Chen <cnevinchen@gmail.com> - Wed, 13 Sep 2017 12:02:58 +0800 - rev 444526
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1392538 - Remove unused onboarding experiments. r=sebastian MozReview-Commit-ID: 5Xjpz7l1IxP
2d6de6f3bb5c7d159b7e4e8fef38af6bc408e33d: Bug 1415220 - Make Fennec build --with-gradle by default. r=sebastian
Nick Alexander <nalexander@mozilla.com> - Tue, 07 Nov 2017 09:03:18 -0800 - rev 443841
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1415220 - Make Fennec build --with-gradle by default. r=sebastian This was just an oversight. MozReview-Commit-ID: 4mHbW3gF4Qn
fa8eaa164af801cda6637c1ab7bdcc4d6c29f1ce: Bug 1406168 - 1. Remove JNI.jsm; r=sebastian
Jim Chen <nchen@mozilla.com> - Wed, 01 Nov 2017 14:48:48 -0400 - rev 442926
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1406168 - 1. Remove JNI.jsm; r=sebastian Remove JNI.jsm. Convert code that used JNI.jsm to the equivalent using EventDispatcher. MozReview-Commit-ID: JQdCubcTBAR
a27cec0959ff816c73f53fec710f68248dd68dc8: Bug 1412818 - Part 2 - Remove other unused stuff in ToolbarDisplayLayout. r=sebastian
Jan Henning <jh+bugzilla@buttercookie.de> - Tue, 31 Oct 2017 14:45:11 +0100 - rev 442607
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1412818 - Part 2 - Remove other unused stuff in ToolbarDisplayLayout. r=sebastian MozReview-Commit-ID: FFzSODcrEEk
fd243036f455fe1ef06c45e5f7a3fd97ede4710d: Bug 1412818 - Part 1 - Remove unused Toolbar experiments. r=sebastian
Jan Henning <jh+bugzilla@buttercookie.de> - Tue, 31 Oct 2017 14:44:08 +0100 - rev 442606
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1412818 - Part 1 - Remove unused Toolbar experiments. r=sebastian MozReview-Commit-ID: 8tky8nF2EVi
ef22d58e750f8b24ceac4c93065d137aa939c6d0: Bug 1410236 - Deny permission by default if doorhanger is dismissed; r=sebastian
Jim Chen <nchen@mozilla.com> - Mon, 30 Oct 2017 12:42:30 -0400 - rev 442387
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1410236 - Deny permission by default if doorhanger is dismissed; r=sebastian Add a "defaultCallback" option to the doorhanger API that specifies a callback to call when the doorhanger is dismissed without a button being clicked. Use that to deny a permission in ContentPermissionPrompt.js when the doorhanger is dismissed without explicit action. MozReview-Commit-ID: 9kOAWirI4Ux
7c264d9bf22a0c2b42aae52ce548961a6009b02f: Bug 1382049 - Make inner classes static when possible. r=nalexander, r=sebastian
Andrew Gaul <andrew@gaul.org> - Tue, 18 Jul 2017 16:51:30 -0700 - rev 442363
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1382049 - Make inner classes static when possible. r=nalexander, r=sebastian This avoids an implicit this field and can help GC. Found via error-prone.
79be7ec660d58aed77af5484dd4a8dec758c496f: Bug 1410629 - Clear user-entered search term already after location change. r=sebastian
Jan Henning <jh+bugzilla@buttercookie.de> - Mon, 30 Oct 2017 14:05:32 +0100 - rev 442327
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1410629 - Clear user-entered search term already after location change. r=sebastian This is to avoid a situation where after searching and then navigating to a different URL, the user can already see the new URL (after location change), but not yet edit it (currently, the search term is only dropped after pageshow). Because location change is too early for checking the documentURI for the presence of an error page in case the load failed, we switch to checking the request's status instead. We still have to explicitly check for "about:neterror" as well, though, since the way our intent handling code displays an error page in case of an unknown protocol technically counts as a successful pageload. MozReview-Commit-ID: 8e6WQlD0sf3
bf87dfd8ddb977fc4ce34c1d44ff0751c1807fa2: Bug 1221344 - Remove Fennec Search Activity. r=gueroJeff,sebastian,snorp
Nick Alexander <nalexander@mozilla.com> - Thu, 19 Oct 2017 14:14:36 -0700 - rev 441768
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1221344 - Remove Fennec Search Activity. r=gueroJeff,sebastian,snorp MozReview-Commit-ID: L7rihfeqvzH
6c7b05c7855148adba9fb99643627cbb85a6ff92: Bug 1391342 - Keep toolbar hidding while showing keyboard in full screen. r=jchen,jwu,sebastian
Nevin Chen(:nechen) <cnevinchen@gmail.com> - Fri, 06 Oct 2017 11:33:14 +0800 - rev 438982
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1391342 - Keep toolbar hidding while showing keyboard in full screen. r=jchen,jwu,sebastian MozReview-Commit-ID: 7GLvOB3TyuK
1d2e66b2486d729c58e8f7eb963f9feb964131c6: Bug 1391342 - Keep toolbar hidding while showing keyboard in full screen. r=jchen,jwu,sebastian
Nevin Chen(:nechen) <cnevinchen@gmail.com> - Fri, 06 Oct 2017 11:33:14 +0800 - rev 438877
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1391342 - Keep toolbar hidding while showing keyboard in full screen. r=jchen,jwu,sebastian MozReview-Commit-ID: 7GLvOB3TyuK
c3540bcc158b323422c291c86efe58b130762c07: Bug 1405513: Add debug info to 'Requested position DNE' crash. r=sebastian
Michael Comella <michael.l.comella@gmail.com> - Tue, 03 Oct 2017 16:45:04 -0700 - rev 437617
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1405513: Add debug info to 'Requested position DNE' crash. r=sebastian MozReview-Commit-ID: 9ZLj7i74AgR
6e019978b9d3c65f9ed34174c97dfb19125334af: Bug 1385124 - Close tab when new tab redirects to external app; r=sebastian
Jim Chen <nchen@mozilla.com> - Wed, 27 Sep 2017 16:47:13 -0400 - rev 436907
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1385124 - Close tab when new tab redirects to external app; r=sebastian When a site opens link in a new tab that redirects to an external app, we should close the new (empty) tab and return to the previous page. MozReview-Commit-ID: KXWA2d26RBh
7a9240b488a2c9cd7ec133103a700c94587f9983: Bug 1403251 - Only display validation message when element is invalid; r=sebastian
Jim Chen <nchen@mozilla.com> - Tue, 26 Sep 2017 18:39:52 -0400 - rev 436466
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1403251 - Only display validation message when element is invalid; r=sebastian Only display form validation message when the element becomes invalid after an invalid submission, by checking the "-moz-ui-invalid" pseudo-class. Also fix some message visibility bugs, by making sure in more places that we only display messages for focused elements. MozReview-Commit-ID: 16rvMmu8Zj6
75c688fefb300e8b2be69e33665f5e2fcf24d559: Bug 1399683: Change padding of content view rather than self in onSizeChanged. r=sebastian
Michael Comella <michael.l.comella@gmail.com> - Thu, 21 Sep 2017 15:40:55 -0700 - rev 435662
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1399683: Change padding of content view rather than self in onSizeChanged. r=sebastian To be honest, I'm not sure why this works. onSizeChanged seems to be a callback to notify the user that your layout has completed and not a place to update layout params. However, it makes *slightly* more sense that you could update your children's layout from this view, which is what this patch changes the code to do. I think I could figure out why this works if I dug further into [1] but I have other things to focus on. I don't think this is the most correct solution, but it is likely the smallest and least risky change we can make to fix this issue, which is ideal because we'd like to uplift this to the 57 Beta. A more correct solution would override the Activity Stream RecyclerView and provide different desired measurements to its parent so that the new size is set *during* layout rather than after it, which would make the layout process more efficient. However, this type of code is less commonly written day-to-day by developers so it's harder to write, harder to maintain, and I'd have to read a lot of [1] in order to write it. :) [1]: https://developer.android.com/guide/topics/ui/how-android-draws.html MozReview-Commit-ID: AceUvDYGWCR
38bd8b9bf3d8a36317513b5765e5fc8ef57372eb: Bug 1392176 Implement prompts for browser.permissions.request() on Android r=kmag,sebastian
Andrew Swan <aswan@mozilla.com> - Tue, 12 Sep 2017 19:06:45 -0700 - rev 435482
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1392176 Implement prompts for browser.permissions.request() on Android r=kmag,sebastian MozReview-Commit-ID: Dufy1pRFtgK
f2db1ec2bf72db9f4d164188e6173a90412939d1: Bug 1403251 - Only display validation message when element is invalid. r=sebastian, a=sledru
Jim Chen <nchen@mozilla.com> - Tue, 26 Sep 2017 18:39:52 -0400 - rev 434373
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1403251 - Only display validation message when element is invalid. r=sebastian, a=sledru Only display form validation message when the element becomes invalid after an invalid submission, by checking the "-moz-ui-invalid" pseudo-class. Also fix some message visibility bugs, by making sure in more places that we only display messages for focused elements. MozReview-Commit-ID: 16rvMmu8Zj6
8158695b90e423f6eb559ac90ee967f196afd44f: Bug 1392176 - Implement prompts for browser.permissions.request() on Android. r=kmag, r=sebastian, a=sledru, l10n=flod
Andrew Swan <aswan@mozilla.com> - Tue, 12 Sep 2017 19:06:45 -0700 - rev 434243
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1392176 - Implement prompts for browser.permissions.request() on Android. r=kmag, r=sebastian, a=sledru, l10n=flod MozReview-Commit-ID: Dufy1pRFtgK
b18dcb98aa98f90d8cbabf8f54db9804f3bca2f2: Bug 1399683 - Change padding of content view rather than self in onSizeChanged. r=sebastian, a=sledru
Michael Comella <michael.l.comella@gmail.com> - Thu, 21 Sep 2017 15:40:55 -0700 - rev 434240
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1399683 - Change padding of content view rather than self in onSizeChanged. r=sebastian, a=sledru To be honest, I'm not sure why this works. onSizeChanged seems to be a callback to notify the user that your layout has completed and not a place to update layout params. However, it makes *slightly* more sense that you could update your children's layout from this view, which is what this patch changes the code to do. I think I could figure out why this works if I dug further into [1] but I have other things to focus on. I don't think this is the most correct solution, but it is likely the smallest and least risky change we can make to fix this issue, which is ideal because we'd like to uplift this to the 57 Beta. A more correct solution would override the Activity Stream RecyclerView and provide different desired measurements to its parent so that the new size is set *during* layout rather than after it, which would make the layout process more efficient. However, this type of code is less commonly written day-to-day by developers so it's harder to write, harder to maintain, and I'd have to read a lot of [1] in order to write it. :) [1]: https://developer.android.com/guide/topics/ui/how-android-draws.html MozReview-Commit-ID: AceUvDYGWCR
7033e71f79294542fe45a40f591e45b06f236431: Bug 1329152 - turn on CustomTabs via SwitchBoard r=nechen,sebastian
Julian_Chu <walkingice0204@gmail.com> - Fri, 21 Apr 2017 15:05:19 +0800 - rev 434103
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1329152 - turn on CustomTabs via SwitchBoard r=nechen,sebastian We are going to enable Custom Tabs by default. Now it is still controlled by SwitchBoard in case of any accident. MozReview-Commit-ID: JREAhkYzVSu
e692d1d1be1e51ac1b0dbd527b236bc2eef63d75: Bug 1329152 - Enable custom tabs by default r=sebastian
Julian_Chu <walkingice0204@gmail.com> - Mon, 10 Apr 2017 17:32:16 +0800 - rev 434102
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1329152 - Enable custom tabs by default r=sebastian Remove related options, just use CustomTabs directly. MozReview-Commit-ID: DdcMHnsfAU1
b1de7fdaa3835f5469206fc120ecb74616534291: Bug 1398409 - 2. Use event callback to communicate FormAssistPopup actions; r=sebastian
Jim Chen <nchen@mozilla.com> - Thu, 14 Sep 2017 17:50:57 -0400 - rev 432999
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1398409 - 2. Use event callback to communicate FormAssistPopup actions; r=sebastian Use event callbacks instead of separate events to deliver FormAssistPopup replies back to FormAssistant. This lets us better handle having multiple FormAssistPopup instances across Fennec, custom tabs, and PWAs. FormAssistant._currentInputElement is removed because it does not allow us to have multiple concurrent popups. Instead, we track the current element through the event callback closure. FormAssistant._currentInputValue is also removed for similar reasons, and I don't think it was really necessary. MozReview-Commit-ID: DdeMBGCxDou
a99a2486f70c65b2411caef9898c05680b374499: Bug 1398409 - 1. Move FormAssistant out of browser.js; r=sebastian
Jim Chen <nchen@mozilla.com> - Thu, 14 Sep 2017 17:50:57 -0400 - rev 432998
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1398409 - 1. Move FormAssistant out of browser.js; r=sebastian To support FormAssistPopup in custom tabs, we need to move the FormAssitant object out of browser.js and into its own separate file. BrowserCLH.h in turn loads FormAssistant.js when necessary. MozReview-Commit-ID: 7CFQ9R16P4J
17f9dd20314af009f328e920f68008885ab8cb73: Bug 1367077 - 3. Move form fill event listeners out of browser.js; r=sebastian
Jim Chen <nchen@mozilla.com> - Thu, 14 Sep 2017 17:50:57 -0400 - rev 432996
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1367077 - 3. Move form fill event listeners out of browser.js; r=sebastian Move the form fill event listeners out of browser.js and into BrowserCLH.js, and update them to support chrome windows, so we can handle form fill events for Fennec, custom tabs, and PWAs. MozReview-Commit-ID: Fb5gWmGvxfE
314cd9bfe986e124b9f95b3c21f918a294ef4fd1: Bug 1391579 Part 4: Handle the in-app extension update flow for Fennec r=jwu,sebastian
Andrew Swan <aswan@mozilla.com> - Fri, 08 Sep 2017 16:48:22 -0700 - rev 432898
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1391579 Part 4: Handle the in-app extension update flow for Fennec r=jwu,sebastian The mechanics implemented here involve listening for extension updates that require new permissions, notifying the user with icons attached to the top level Add-ons menu and to the individual item in about:addons, and then showing the permissions dialog when the user asks to update. The basic plumbing is mostly in ExtensionPermissions.js, this also required a fair amount of change to aboutAddons to accomodate new UI elements, and to handle updates gracefully. MozReview-Commit-ID: Jkgc3OVYtnc
f25a9201e1eabaa6a85bca571fbd6274c66ca4c3: Bug 1391579 Part 3: Add update indicator to top-level Add-ons menu entry r=jwu,sebastian
Andrew Swan <aswan@mozilla.com> - Mon, 11 Sep 2017 10:31:51 -0700 - rev 432897
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1391579 Part 3: Add update indicator to top-level Add-ons menu entry r=jwu,sebastian MozReview-Commit-ID: 937Zsd6yfBO
7048637ef80c14b230d7cde182dbc8d3c93e1554: Bug 1391579 Part 2: Add MenuItemIcon r=jwu,sebastian
Julian_Chu <walkingice0204@gmail.com> - Thu, 24 Aug 2017 01:15:22 -0700 - rev 432896
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1391579 Part 2: Add MenuItemIcon r=jwu,sebastian GeckoMenu always create view from MenuItemDefault. Now lets adding a new type for MenuItem which will display a Drawable in right side. MozReview-Commit-ID: F7zVDze0RaP
bb3a37d321e22313ce8d9d8cd71274569fc5121c: Bug 1391579 Part 1: add attribute itemType to GeckoMenuItem r=jwu,sebastian
Julian_Chu <walkingice0204@gmail.com> - Thu, 24 Aug 2017 01:15:04 -0700 - rev 432895
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1391579 Part 1: add attribute itemType to GeckoMenuItem r=jwu,sebastian MozReview-Commit-ID: CelYcXveCvO
bca0b077f039e78fb8fdf6831adfa2d35ef57c88: Bug 1388396: Add MinimumSizeProcessor; .forActivityStream takes effect. r=sebastian
Michael Comella <michael.l.comella@gmail.com> - Mon, 11 Sep 2017 17:41:33 -0700 - rev 432718
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1388396: Add MinimumSizeProcessor; .forActivityStream takes effect. r=sebastian This patch is necessary for the previous changesets to take effect. MozReview-Commit-ID: 98IemAEgbmi
b79ec53305633fe444abfe4b0d7d64de276309bb: Bug 1388396: Use IconRequestBuilder.forActivityStream in AS UI. r=sebastian
Michael Comella <michael.l.comella@gmail.com> - Mon, 11 Sep 2017 17:27:22 -0700 - rev 432717
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1388396: Use IconRequestBuilder.forActivityStream in AS UI. r=sebastian MozReview-Commit-ID: jLVtXk0hJZ
a5f78f2e5bfd84b220a6b886f0feb48c478f9d17: Bug 1388396: Add IconRequestBuilder.forActivityStream. r=sebastian
Michael Comella <michael.l.comella@gmail.com> - Mon, 11 Sep 2017 17:25:10 -0700 - rev 432716
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1388396: Add IconRequestBuilder.forActivityStream. r=sebastian MozReview-Commit-ID: HwCjdyB7o7q
ada7d6900274686aca0b3500b3242c736caa9f49: Bug 1388396: Increase max favicon scale factor to 3. r=sebastian
Michael Comella <michael.l.comella@gmail.com> - Mon, 11 Sep 2017 17:13:07 -0700 - rev 432715
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1388396: Increase max favicon scale factor to 3. r=sebastian This is part 1 of the good-enough approach: see the MAX_SCALE_FACTOR comment as to what we're aiming for. The next changeset will discard any icons that do not look good being scaled so much. The MAX_SCALE_FACTOR field is non-private because it's used in the next changeset. MozReview-Commit-ID: HGzdQBEuMAy
34b7638b00c8f465b368b53901b1a4597becd653: Bug 1399039 - Don't initialize GlobalPageMetadata more than once r=sebastian
Grigory Kruglov <gkruglov@mozilla.com> - Tue, 12 Sep 2017 20:28:36 -0400 - rev 432591
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1399039 - Don't initialize GlobalPageMetadata more than once r=sebastian MozReview-Commit-ID: 6VqkvDrEc5K
8a3e6fbd6511d12292c0a0497bf56a779fc20bba: Bug 1367077 - 3. Move form fill event listeners out of browser.js; r=sebastian
Jim Chen <nchen@mozilla.com> - Wed, 13 Sep 2017 11:52:04 -0400 - rev 432561
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1367077 - 3. Move form fill event listeners out of browser.js; r=sebastian Move the form fill event listeners out of browser.js and into BrowserCLH.js, and update them to support chrome windows, so we can handle form fill events for Fennec, custom tabs, and PWAs. MozReview-Commit-ID: Fb5gWmGvxfE
3044b28ca2baa0785c47fc25565aeebba7df68fe: Bug 1368147 - Support renaming an account in response to profileUpdate events r=nalexander,sebastian
Grigory Kruglov <gkruglov@mozilla.com> - Tue, 12 Sep 2017 19:09:00 -0400 - rev 432434
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1368147 - Support renaming an account in response to profileUpdate events r=nalexander,sebastian MozReview-Commit-ID: 7rQzTN0jEWb