searching for reviewer(rstrong)
d1e960d52ee7b4826d39d6abed4382611eaf1be5: Bug 1551913 - Fix issues setting update directory permissions. r=rstrong, a=RyanVM
Kirk Steuber <ksteuber@mozilla.com> - Mon, 19 Aug 2019 19:43:17 +0000 - rev 545228
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1551913 - Fix issues setting update directory permissions. r=rstrong, a=RyanVM This patch addresses both Bug 1551913 and Bug 1552206. This patches the update directory permission-fixing code. This also fixes a related bug that I discovered while testing this patch: nsAutoSid doesn't actually work because both PSID and HANDLE are both typedef'ed from void*, so the compiler can't actually tell the difference between them and ends up calling CloseHandle instead of FreeSid. To fix this, I removed nsAutoSid and replaced it with UniqueSidPtr, a UniquePtr type that uses a custom deleter class to free the SID properly. Differential Revision: https://phabricator.services.mozilla.com/D34941 *** Bug 1570396 - Fix misc. issues with permission setting r=mhowell This patch fixes a number of miscellaneous issues with permission setting. When we move a directory, recreate it, and move the contents back, those contents may be in use (possibly by antivirus). To address this, we now fall back to copying the data back and removing the originals. The maximum number of backups to make when moving conflicting files is now 3 instead of 9. 9 seemed a bit excessive. There is now an additional level of SetPermissionsOf, FilesAndDirsWithBadPerms. This new value causes permissions not to be fixed if we are unable to read them. This should prevent unnecessary permission fixes while still allowing us to aggressively set them when necessary. Differential Revision: https://phabricator.services.mozilla.com/D42066 *** Bug 1486637 - Backout bug 1486637 and related patches. r=agashlin Differential Revision: https://phabricator.services.mozilla.com/D42143
04382a534a2070436bc612718c368b859e6ff297: Bug 1563790 - Part 2: Lower No Progress Timeout when UI is displayed r=bytesized,rstrong a=RyanVM
Adam Gashlin <agashlin@mozilla.com> - Thu, 01 Aug 2019 20:00:54 +0000 - rev 545115
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1563790 - Part 2: Lower No Progress Timeout when UI is displayed r=bytesized,rstrong a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D39270
6c5c0e279a386b0bcfba2900dffa4e4b3e7d15f9: Bug 1563790 - Part 1: Expose and require No Progress Timeout r=bytesized,rstrong a=RyanVM
Adam Gashlin <agashlin@mozilla.com> - Thu, 01 Aug 2019 20:01:09 +0000 - rev 545114
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1563790 - Part 1: Expose and require No Progress Timeout r=bytesized,rstrong a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D39095
98a5a4864b88bceb374f48c841fc8c67fb3b1eed: Bug 1561636 - intermittent updater failures on Win64 (Error 19) r=rstrong
Kathy Brade <brade@pearlcrescent.com> - Thu, 27 Jun 2019 09:11:48 +0000 - rev 543198
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1561636 - intermittent updater failures on Win64 (Error 19) r=rstrong Avoid MinGW's _ftelli64() and _fseeki64() implementations because they are unreliable. Differential Revision: https://phabricator.services.mozilla.com/D36037
c35dfc59349855f1acfe97c5fc299ea10551b45b: Bug 1556733 - [10.15] Multiple "Firefox Nightly Software Update" Mac OS X quarantine dialogs when performing a software update r=rstrong,spohl
Haik Aftandilian <haftandilian@mozilla.com> - Thu, 27 Jun 2019 02:51:45 +0000 - rev 543131
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1556733 - [10.15] Multiple "Firefox Nightly Software Update" Mac OS X quarantine dialogs when performing a software update r=rstrong,spohl On Mac, remove the "com.apple.quarantine" extended attribute from the updater after it is copied to the staging area. Required on macOS 10.15 which has new restrictions on launching quarantined applications. Differential Revision: https://phabricator.services.mozilla.com/D35972
e74c6c4c5d62068686b0d87ac724f07931b1be3a: Bug 1558095 - Remove useless waitpid from updater. r=rstrong
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Tue, 11 Jun 2019 17:34:05 +0000 - rev 541177
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1558095 - Remove useless waitpid from updater. r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D34503
a3031bdbf14ad7515fd6abca317b10e71ecfcbff: Bug 1557963. Stop using [array] in nsIUpdateService. r=rstrong
Boris Zbarsky <bzbarsky@mit.edu> - Sat, 08 Jun 2019 19:04:47 +0000 - rev 540818
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1557963. Stop using [array] in nsIUpdateService. r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D34278
ca8e3e6b3a825ff13012bc6029d767b54cdf573a: Bug 1532190 - Don't call CloseHandle on invalid handle during update service. r=rstrong
Ted Campbell <tcampbell@mozilla.com> - Thu, 02 May 2019 20:39:36 +0000 - rev 539158
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1532190 - Don't call CloseHandle on invalid handle during update service. r=rstrong During forced shutdown, we may call 'closeHandle' without having a proper mutex. This results in a crash in ntdll, so instead just do nothing if the handle is missing. Differential Revision: https://phabricator.services.mozilla.com/D29716
29ab504dc7481c60532d7d5bf3f1f7d36c15235f: Bug 1552676 - Cleanup cookie policy tests. r=rstrong
Michael Kaply <mozilla@kaply.com> - Tue, 21 May 2019 19:15:36 +0000 - rev 537668
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1552676 - Cleanup cookie policy tests. r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D32037
d77755aee6dedf20ac61ddc6c5376a42ec9c331d: Bug 1556733 - [10.15] Multiple "Firefox Nightly Software Update" Mac OS X quarantine dialogs when performing a software update. r=rstrong,spohl, a=RyanVM
Haik Aftandilian <haftandilian@mozilla.com> - Thu, 27 Jun 2019 02:51:45 +0000 - rev 537133
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1556733 - [10.15] Multiple "Firefox Nightly Software Update" Mac OS X quarantine dialogs when performing a software update. r=rstrong,spohl, a=RyanVM On Mac, remove the "com.apple.quarantine" extended attribute from the updater after it is copied to the staging area. Required on macOS 10.15 which has new restrictions on launching quarantined applications. Differential Revision: https://phabricator.services.mozilla.com/D35972
aed55b0dd6434e35229937f34238b3172fa7d800: Bug 1552676 - Cleanup cookie policy tests. r=rstrong, a=test-only
Michael Kaply <mozilla@kaply.com> - Tue, 21 May 2019 19:15:36 +0000 - rev 536552
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1552676 - Cleanup cookie policy tests. r=rstrong, a=test-only Differential Revision: https://phabricator.services.mozilla.com/D32037
243251620b8e60ec461d348ee79a2df307655ba7: Bug 1551867 - Move appinfo init to head to avoid timing when initing enterprise policies. r=rstrong
Michael Kaply <mozilla@kaply.com> - Thu, 16 May 2019 23:47:13 +0000 - rev 536158
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1551867 - Move appinfo init to head to avoid timing when initing enterprise policies. r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D31499
afaf68ba6e54f8309317b3d346396178fde23fb7: Bug 1546957 - Prevent BITS Requests from being cancelled twice r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Wed, 15 May 2019 21:55:36 +0000 - rev 535897
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1546957 - Prevent BITS Requests from being cancelled twice r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D31338
8096d130b1346ba0c6bc10450de6f86196f3f768: Bug 1546627 - Prevent Firefox from prematurely showing "Restart to Update" on startup r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Fri, 10 May 2019 19:06:34 +0000 - rev 535336
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1546627 - Prevent Firefox from prematurely showing "Restart to Update" on startup r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D30520
e978f9960f5759e80511573a05fd649cab27f0dc: Bug 1546627 - Prevent Firefox from prematurely showing "Restart to Update" on startup r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Fri, 10 May 2019 16:56:45 +0000 - rev 535310
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1546627 - Prevent Firefox from prematurely showing "Restart to Update" on startup r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D30520
adb1c1a79a40102f634a419b6c5d1245de474d67: Bug 1546287 - Fix leak in BITS update tests r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Fri, 03 May 2019 17:37:55 +0000 - rev 534414
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1546287 - Fix leak in BITS update tests r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D29751
b93a543241aee81d6c5212f09f1f7db6a25a6a85: Bug 1547099 - Ensure that BITS update is not used for mochitest-chrome update tests that do not use it r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Fri, 26 Apr 2019 15:38:38 +0000 - rev 533416
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1547099 - Ensure that BITS update is not used for mochitest-chrome update tests that do not use it r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D28999
30ed3b129f01e715bb12f91a7c11d6794d89601c: Bug 1542100 - Only enable BITS update for 50% of eligible population r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Tue, 23 Apr 2019 17:18:07 +0000 - rev 532452
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1542100 - Only enable BITS update for 50% of eligible population r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D28368
27c8b8f5b3c81e5f216a4ac948c7d082e19fc287: Bug 1545793 - Don't put a BITS update in a failure state if the user doesn't have permission to access BITS r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Mon, 22 Apr 2019 17:06:59 +0000 - rev 532254
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1545793 - Don't put a BITS update in a failure state if the user doesn't have permission to access BITS r=rstrong This patch should prevent a guest user from putting a non-guest user's (existing) BITS download in a failure state. If, however, the guest user is the first user to try BITS, it will fail and will still put BITS in an error state, falling back to nsIIncrementalDownload. Differential Revision: https://phabricator.services.mozilla.com/D28258
be77d454cbe7e8cf3d619b56d87d399699bd7edd: Bug 1544562 - Call onUnload when about:preferences is closed r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Thu, 18 Apr 2019 20:52:02 +0000 - rev 532024
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1544562 - Call onUnload when about:preferences is closed r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D27591
7c149c2cd4a90a9063c02082c51362043f29d47c: Bug 1544894 - Fix bug where BITS notifications never return from active to idle mode r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Tue, 16 Apr 2019 18:21:45 +0000 - rev 531649
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1544894 - Fix bug where BITS notifications never return from active to idle mode r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D27781
252732b54408cbf9de761baf469a03e55066a280: Bug 1544562 - Call onUnload when about:preferences is closed r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Mon, 15 Apr 2019 21:23:04 +0000 - rev 531460
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1544562 - Call onUnload when about:preferences is closed r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D27591
fb9ff7baed4347cf0df3f252344a9f69e6942b44: Bug 1520321 - Adds Telemetry for BITS update downloads r=chutten,rstrong
Kirk Steuber <ksteuber@mozilla.com> - Mon, 15 Apr 2019 19:44:59 +0000 - rev 531440
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1520321 - Adds Telemetry for BITS update downloads r=chutten,rstrong These Histograms were added: UPDATE_CAN_USE_BITS_EXTERNAL UPDATE_CAN_USE_BITS_NOTIFY Used for telemetry indicating whether or not BITS can be used by this system. If BITS cannot be used, the probe will contain data indicating why not. UPDATE_BITS_RESULT_COMPLETE UPDATE_BITS_RESULT_PARTIAL Used for telemetry indicating whether the BITS update download succeeded. If it failed, the probe will contain data indicating how it failed. This scalar was added: update.bitshresult Used to indicate the hresult returned, if any, when a BITS download fails. Differential Revision: https://phabricator.services.mozilla.com/D25163
84cc6e41ba1757fab96a5aed49d494d771bded5b: Bug 1520321 - Use BITS in nsUpdateService r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Mon, 15 Apr 2019 19:44:45 +0000 - rev 531439
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1520321 - Use BITS in nsUpdateService r=rstrong nsUpdateService should use BITS for download. If the BITS download fails, it will fallback to the existing download mechanism (nsIIncrementalDownload). Differential Revision: https://phabricator.services.mozilla.com/D25162
1ec7f80cf258370b47afbe6de253bad316ad80c2: Bug 1539176 - modules/ manual ESLint no-throw-literal fixes. r=rstrong
Ian Moody <moz-ian@perix.co.uk> - Tue, 02 Apr 2019 13:41:10 +0000 - rev 529601
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1539176 - modules/ manual ESLint no-throw-literal fixes. r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D25651
35a77a4804208a7eb187e674c68e85c90ecbd3c8: Bug 1534508: Move ProcessUpdates to after we have attempted to remote arguments to an existing instance. r=rstrong
Dave Townsend <dtownsend@oxymoronical.com> - Wed, 13 Mar 2019 23:26:16 +0000 - rev 524803
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1534508: Move ProcessUpdates to after we have attempted to remote arguments to an existing instance. r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D23158
d75868102ceaeb949d2bbd50c3067acd97dae217: Bug 1526475 - Add file logging to the updater r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Mon, 04 Mar 2019 01:36:49 +0000 - rev 523071
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1526475 - Add file logging to the updater r=rstrong File logging can be turned on by setting `app.update.log.file=true`. It will log update messages that would normally go to the browser console (assuming `app.update.log==true`) to a file in the user profile directory called "update_messages.log". File logging will last for a single Firefox session only before it automatically disables itself. The goal of this is to make it easier to get troubleshooting/debugging information from users that might complain of update problems. This will be especially important when upcoming changes are made to the update mechanism. Differential Revision: https://phabricator.services.mozilla.com/D19422
e9677c67b09409735efdc4a63da14c1753d61d13: Bug 1523613: Fix memory leaks during updates. r=rstrong
Stephen A Pohl <spohl.mozilla.bugs@gmail.com> - Mon, 25 Feb 2019 10:16:15 -0500 - rev 521763
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1523613: Fix memory leaks during updates. r=rstrong
56840efb59f17cb0d70e68fbd9196acfa1b2621c: Bug 1524290: Fix a potential memory leak in updater.cpp. r=rstrong
Stephen A Pohl <spohl.mozilla.bugs@gmail.com> - Thu, 31 Jan 2019 17:39:15 -0500 - rev 517223
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1524290: Fix a potential memory leak in updater.cpp. r=rstrong
63b7e43db7ccc849c3977d487ffd02e55118310e: Bug 1521902: Remove unused argument from nsIShellService.isDefaultBrowser. r=rstrong,chutten
Dave Townsend <dtownsend@oxymoronical.com> - Thu, 24 Jan 2019 20:08:14 +0000 - rev 515336
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1521902: Remove unused argument from nsIShellService.isDefaultBrowser. r=rstrong,chutten Differential Revision: https://phabricator.services.mozilla.com/D17281
217865622f7a145aab2909995002191d729c442a: Bug 1521902: Remove unused argument from nsIShellService.isDefaultBrowser. r=rstrong
Dave Townsend <dtownsend@oxymoronical.com> - Tue, 22 Jan 2019 20:41:41 +0000 - rev 514870
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1521902: Remove unused argument from nsIShellService.isDefaultBrowser. r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D17281
76786e51becf1fa3a23f0978791a80107acf2318: Bug 493503: Ensure that icons are refreshed in the macOS Dock and Finder after updates. r=mstange,rstrong
Stephen A Pohl <spohl.mozilla.bugs@gmail.com> - Fri, 18 Jan 2019 05:48:45 -0500 - rev 514512
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 493503: Ensure that icons are refreshed in the macOS Dock and Finder after updates. r=mstange,rstrong
cad6506b2f5d1c179603ef7a125219ef94c7e04a: Bug 1518846: Fix missing includes in nsUpdateDriver.cpp. r=rstrong
Dave Townsend <dtownsend@oxymoronical.com> - Wed, 09 Jan 2019 17:27:21 +0000 - rev 513144
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1518846: Fix missing includes in nsUpdateDriver.cpp. r=rstrong Adds some includes that are needed for functions used in nsUpdateDriver.cpp. Differential Revision: https://phabricator.services.mozilla.com/D16063
f184da8d467cc98ff07dfbf880557eac00566c57: Bug 1514898 - Disable user impersonation on release r=rstrong
Adam Gashlin <agashlin@mozilla.com> - Wed, 09 Jan 2019 19:57:31 +0000 - rev 513126
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1514898 - Disable user impersonation on release r=rstrong This introduces a DISABLE_USER_IMPERSONATION define when EARLY_BETA_OR_EARLIER is set, if that is present the maintenance service will not attempt to get an impersonation token for the user's updater process, and the updater will not attempt to use any token it is given. The bulk of the changes are restoring the old failure status codes and the tests that expect them, sorry for the noise that causes. Differential Revision: https://phabricator.services.mozilla.com/D15781
74bbbdf694678553a0c2afb2f810a2299616e07c: Bug 1515611 part 2 - QI nsIWritablePropertyBag instead of nsIPropertyBag on nsIUpdate. r=rstrong
Jan de Mooij <jdemooij@mozilla.com> - Thu, 20 Dec 2018 17:47:32 +0000 - rev 511809
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1515611 part 2 - QI nsIWritablePropertyBag instead of nsIPropertyBag on nsIUpdate. r=rstrong If we QI nsIPropertyBag on an XPCWrappedNative wrapping an XPCWrappedJS, calling the getProperty method might incorrectly end up calling .getProperty on the XPCWrappedJS itself, because it also implements nsIPropertyBag. This became a problem with same-compartment chrome globals because if we no longer cross a compartment boundary, we don't create a new WrappedNative and can now end up seeing the nsIPropertyBag if it got queried before nsIWritablePropertyBag. Depends on D15076 Differential Revision: https://phabricator.services.mozilla.com/D15077
dab6389dca555797ab04b33fc6d79b8547d1ec87: Bug 1515611 part 1 - Remove backgroundInterval from nsIUpdate. r=rstrong
Jan de Mooij <jdemooij@mozilla.com> - Sat, 22 Dec 2018 01:10:27 +0000 - rev 511808
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1515611 part 1 - Remove backgroundInterval from nsIUpdate. r=rstrong It was added in case there were CDN issues with downloading unthrottled and since there haven't been any issues it is no longer needed. This was suggested by rstrong and simplifies the next patch. Differential Revision: https://phabricator.services.mozilla.com/D15076
5dd777c5770d0a80575d6a6842725d3a1f048fc3: Bug 1514078 - Correctly report Windows running on AArch64 in the update URL. r=rstrong
Matt Howell <mhowell@mozilla.com> - Fri, 14 Dec 2018 02:23:01 +0000 - rev 510470
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1514078 - Correctly report Windows running on AArch64 in the update URL. r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D14502
e620bf5160a4685b2728d28d2bf0eaa1dbf9d786: Bug 1514898 - Disable user impersonation on release. r=rstrong, a=RyanVM
Adam Gashlin <agashlin@mozilla.com> - Wed, 09 Jan 2019 19:57:31 +0000 - rev 509392
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1514898 - Disable user impersonation on release. r=rstrong, a=RyanVM This introduces a DISABLE_USER_IMPERSONATION define when EARLY_BETA_OR_EARLIER is set, if that is present the maintenance service will not attempt to get an impersonation token for the user's updater process, and the updater will not attempt to use any token it is given. The bulk of the changes are restoring the old failure status codes and the tests that expect them, sorry for the noise that causes. Differential Revision: https://phabricator.services.mozilla.com/D15781
6798cc7aaed0765f259470eb5f7cac16d4310545: Bug 1468552 - Update bspatch.cpp to match Chromium version; r=rstrong
June Wilde <jewilde@mozilla.com> - Tue, 27 Nov 2018 18:30:30 +0000 - rev 507584
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1468552 - Update bspatch.cpp to match Chromium version; r=rstrong Adds bounds checking around file reads and header values Differential Revision: https://phabricator.services.mozilla.com/D12356
2b4f08a645a0385021b64b4f995c18cb2250a5c6: Bug 1468552 - Update bspatch.cpp to match Chromium version; r=rstrong
June Wilde <jewilde@mozilla.com> - Mon, 26 Nov 2018 22:01:08 +0000 - rev 507541
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1468552 - Update bspatch.cpp to match Chromium version; r=rstrong Adds bounds checking around file reads and header values Differential Revision: https://phabricator.services.mozilla.com/D12356
d1d8e236cf158b5fc75a97d6f3a0ed76cc341ebc: Bug 1486637: Impersonate user when creating files in user-controlled directories r=rstrong,mhowell
Adam Gashlin <agashlin@mozilla.com> - Mon, 19 Nov 2018 18:45:52 +0000 - rev 506280
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1486637: Impersonate user when creating files in user-controlled directories r=rstrong,mhowell Get an impersonation token for the user who started the maintenance service, use that when creating or moving files in user-controlled directories (currently only update.status). This token is passed along to the updater where it is used the same way (update.status, update log, and elevated lock file). The workings of getting the token are in usertoken.cpp Differential Revision: https://phabricator.services.mozilla.com/D7840
97613730a99f6156f256d351b5b7767b1d80a2b6: Bug 1468542 - Restrict acceptable bounds for i in nss_secutil; r=rstrong
June Wilde <jewilde@mozilla.com> - Mon, 19 Nov 2018 20:57:50 +0200 - rev 506248
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1468542 - Restrict acceptable bounds for i in nss_secutil; r=rstrong Summary: Adds some missing braces on if structures Adds a check for i being larger or equal to nb Reviewers: rstrong Reviewed By: rstrong Bug #: 1468542 Differential Revision: https://phabricator.services.mozilla.com/D12193
4a30dea025cacebb50cd376e1429ae8041c75790: Bug 1503362 - Clear the app.update.enabled pref from profiles now that it is no longer in use r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Thu, 08 Nov 2018 16:41:07 +0000 - rev 504384
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1503362 - Clear the app.update.enabled pref from profiles now that it is no longer in use r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D11128
cc07fe73ddcead18a7c3f92ce4bd3d5346cfd65c: bug 1501889 - add the ability to report binary transparency verification failures from the updater r=rstrong,francois
Dana Keeler <dkeeler@mozilla.com> - Tue, 06 Nov 2018 22:55:33 +0000 - rev 503962
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
bug 1501889 - add the ability to report binary transparency verification failures from the updater r=rstrong,francois This patch adds the ability for the updater to report binary transparency verification failures without affecting the outcome of the update in progress. Differential Revision: https://phabricator.services.mozilla.com/D9846
663e1f142dd49d3bc7912a4e7661bdf7d02cda89: Bug 1458308 - Remove app.update.auto and app.update.enabled from prefs.rs and marionette.js r=rstrong,ato
Kirk Steuber <ksteuber@mozilla.com> - Tue, 06 Nov 2018 21:16:19 +0000 - rev 503948
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1458308 - Remove app.update.auto and app.update.enabled from prefs.rs and marionette.js r=rstrong,ato `app.update.auto` should actually never have been needed here. `app.update.disabledForTesting`, and before that, `app.update.enabled` will prevent updates altogether. Now that the `app.update.auto` pref is not the correct mechanism for disabling automatic update, this pref should be removed from these files. `app.update.enabled` can also be removed from prefs.rs at this time as per the comment in the file indicating that it can be removed when Firefox 62 stabilizes. Depends on D10315 Differential Revision: https://phabricator.services.mozilla.com/D10780
1b57a28b1e90c3d3c53c575090f4f98b493e452c: Bug 1458308 - Change lookups of app.update.auto to use nsIApplicationUpdateService::(get|set)AutoUpdateIsEnabled r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Tue, 06 Nov 2018 21:18:21 +0000 - rev 503947
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1458308 - Change lookups of app.update.auto to use nsIApplicationUpdateService::(get|set)AutoUpdateIsEnabled r=rstrong This patch also contains a few additional minor changes: - Clears the user value set to the pref app.update.auto after the value is migrated. - Fixes the app.update.auto pref migration test - Makes a number of functions asynchronous to allow them to wait for app.update.auto setting changes - TestAUSHelper's create-update-dir command no longer tries to set the permissions on all files in the update directory. Fixes a potential race condition when creating the update directory. Depends on D4594 Differential Revision: https://phabricator.services.mozilla.com/D10315
c6a1aa25f4fda10ef6f95a3d6d74285c2dbd74ea: Bug 1458308 - Tests for migration and UI of app.update.auto pref r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Tue, 06 Nov 2018 21:04:16 +0000 - rev 503946
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1458308 - Tests for migration and UI of app.update.auto pref r=rstrong Depends on D4593 Differential Revision: https://phabricator.services.mozilla.com/D4594
54dd159fd0a616b164b3926c153d6297b3c2bf99: Bug 1458308 - Move app.update.auto to be stored in the update directory on Windows only r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Tue, 06 Nov 2018 21:03:31 +0000 - rev 503943
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1458308 - Move app.update.auto to be stored in the update directory on Windows only r=rstrong This patch additionally includes support for automatic migration of the pref from its old location to its new location. This patch does not fix telemetry reporting of app.update.auto - that will be addressed in another patch in the same series. MozReview-Commit-ID: KjX1mmGVB8M Differential Revision: https://phabricator.services.mozilla.com/D4590
bfc6238f43786da1babdc8ee547ddc39ddbcb216: Bug 1468544 - Replace mar_hash_name with CityHash algorithm. r=rstrong
June Wilde <jewilde@mozilla.com> - Tue, 06 Nov 2018 13:34:21 -0500 - rev 503918
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1468544 - Replace mar_hash_name with CityHash algorithm. r=rstrong Make CityHash64, CityHash64WithSeed, and CityHash64WithSeeds usable from C code Remove unnecessary includes from mar_read.c as well Add DisableStlWrapping to mar tool's moz.build to fix linkage break when building in Windows with MSVC Differential Revision: https://phabricator.services.mozilla.com/D10774
f8d63cc0c95feea7aa1e6b28724be95ff3fba93c: Bug 1504878 - Exclude Mac OS from update log file tests. r=rstrong
Matt Howell <mhowell@mozilla.com> - Tue, 06 Nov 2018 18:15:24 +0000 - rev 503917
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1504878 - Exclude Mac OS from update log file tests. r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D10982