searching for reviewer(rpl)
973fdd5f75cd: Bug 1493426 - Respect tab privateness when opening browserAction popup. r=rpl
Oriol Brufau <oriol-bugzilla@hotmail.com> - Tue, 16 Oct 2018 14:04:43 +0000 - rev 499990
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1493426 - Respect tab privateness when opening browserAction popup. r=rpl Differential Revision: https://phabricator.services.mozilla.com/D8628
84ceb42728e4: Bug 1491397 - Correctly forward falsey scriptMetadata in userScripts API r=rpl
Rob Wu <rob@robwu.nl> - Mon, 15 Oct 2018 18:05:08 +0000 - rev 499763
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1491397 - Correctly forward falsey scriptMetadata in userScripts API r=rpl This also adds new test coverage for the previously untested features: - "file" in "js" param to userScripts.register works. - "allFrames" set to true in userScripts.register works. - scriptMetadata accepts primitive values, and in particular falsey values in particular (= bug 1491397 ). - scriptMetadata is the same object in all API script calls. Differential Revision: https://phabricator.services.mozilla.com/D8582
cf62153b17ad: Bug 1488914 - Use about:home / about:privatebrowsing in windows.create r=rpl,dao
Rob Wu <rob@robwu.nl> - Fri, 12 Oct 2018 08:47:00 +0000 - rev 499284
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1488914 - Use about:home / about:privatebrowsing in windows.create r=rpl,dao Use a homepage URL instead of a new tab URL by default in browser.windows.create. Differential Revision: https://phabricator.services.mozilla.com/D6030
0c9456c0ba9a: Bug 1478694 - Ensure that WebExtensions alarms set in the past are fired immediately. r=rpl
divyansh <sharma.divyansh.501@iitg.ernet.in> - Thu, 11 Oct 2018 19:22:21 +0000 - rev 499235
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1478694 - Ensure that WebExtensions alarms set in the past are fired immediately. r=rpl Bug 1478694 - Ensure that WebExtensions alarms set in the past are fired immediately. Differential Revision: https://phabricator.services.mozilla.com/D7287
c844033d55eb: Bug 1488914 - Use about:home / about:privatebrowsing in windows.create r=rpl,dao
Rob Wu <rob@robwu.nl> - Thu, 11 Oct 2018 14:14:50 +0000 - rev 499168
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1488914 - Use about:home / about:privatebrowsing in windows.create r=rpl,dao Use a homepage URL instead of a new tab URL by default in browser.windows.create. Differential Revision: https://phabricator.services.mozilla.com/D6030
17311c934402: Bug 1494281 - Fix possible race around devToolsTarget promise creation r=rpl
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 01 Oct 2018 14:45:11 +0000 - rev 497425
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1494281 - Fix possible race around devToolsTarget promise creation r=rpl MozReview-Commit-ID: DlB05jFPtGL Differential Revision: https://phabricator.services.mozilla.com/D6939
c42695f1399c: Bug 1393570 - Support cookieStoreId in windows.create extension API r=Gijs,rpl
Rob Wu <rob@robwu.nl> - Wed, 19 Sep 2018 10:57:48 +0000 - rev 496271
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1393570 - Support cookieStoreId in windows.create extension API r=Gijs,rpl Other (internal API) changes besides extension API changes: - This also introduces support for opening a window with multiple tabs in a non-default container tab. - This also adds LOAD_FLAGS_DISALLOW_INHERIT_PRINCIPAL to the gBrowser.loadTabs call, unless allowInheritPrincipal is set. For backwards-compatibility, this flag defaults to true. Depends on D4928 Differential Revision: https://phabricator.services.mozilla.com/D4929
4ff201d93d71: Bug 1393570 - Move cookieStoreId validator to ext-tabs-base.js r=rpl
Rob Wu <rob@robwu.nl> - Sat, 15 Sep 2018 18:42:48 +0000 - rev 496270
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1393570 - Move cookieStoreId validator to ext-tabs-base.js r=rpl This is a preparation to support cookieStoreId in the windows.create. Depends on D4920 Differential Revision: https://phabricator.services.mozilla.com/D4928
9a99305d2fcb: Bug 1493057 - Make sure test_ext_privacy.js doesn't depend on the default value of the network.cookie.cookieBehavior preference r=rpl
Ehsan Akhgari <ehsan@mozilla.com> - Fri, 21 Sep 2018 15:12:10 +0000 - rev 496098
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1493057 - Make sure test_ext_privacy.js doesn't depend on the default value of the network.cookie.cookieBehavior preference r=rpl Differential Revision: https://phabricator.services.mozilla.com/D6456
0ac2987bd1b0: Bug 1485307 - Focus urlbar when extension opens new tab r=rpl
Rob Wu <rob@robwu.nl> - Wed, 19 Sep 2018 12:28:20 +0000 - rev 495669
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1485307 - Focus urlbar when extension opens new tab r=rpl Differential Revision: https://phabricator.services.mozilla.com/D6029
3e40be33fb0d: Bug 1393570 - Support cookieStoreId in windows.create extension API r=Gijs,rpl
Rob Wu <rob@robwu.nl> - Wed, 12 Sep 2018 15:15:22 +0000 - rev 494501
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1393570 - Support cookieStoreId in windows.create extension API r=Gijs,rpl Other (internal API) changes besides extension API changes: - This also introduces support for opening a window with multiple tabs in a non-default container tab. - This also adds LOAD_FLAGS_DISALLOW_INHERIT_PRINCIPAL to the gBrowser.loadTabs call, unless allowInheritPrincipal is set. Currently there are no callers that set this flag, but in case it's desired, I added an opt-in via window.arguments[10] in browser.xul/js. For single-argument URLs, the flag is an opt-out, since there are multiple callers that rely on principal inheritance (bug 1475201). Depends on D4928 Differential Revision: https://phabricator.services.mozilla.com/D4929
376b4b4ffefb: Bug 1393570 - Move cookieStoreId validator to ext-tabs-base.js r=rpl
Rob Wu <rob@robwu.nl> - Wed, 05 Sep 2018 21:04:22 +0000 - rev 494500
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1393570 - Move cookieStoreId validator to ext-tabs-base.js r=rpl This is a preparation to support cookieStoreId in the windows.create. Depends on D4920 Differential Revision: https://phabricator.services.mozilla.com/D4928
353cb0f90dc4: Bug 1488055 fix loading ext-browser-content script in sidebar when browser_style=false, r=rpl
Shane Caraveo <scaraveo@mozilla.com> - Wed, 12 Sep 2018 18:52:52 +0000 - rev 494352
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1488055 fix loading ext-browser-content script in sidebar when browser_style=false, r=rpl Differential Revision: https://phabricator.services.mozilla.com/D5196
23f496cd8a42: Bug 1393570 - Support cookieStoreId in windows.create extension API r=Gijs,rpl
Rob Wu <rob@robwu.nl> - Wed, 12 Sep 2018 15:15:22 +0000 - rev 494334
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1393570 - Support cookieStoreId in windows.create extension API r=Gijs,rpl Other (internal API) changes besides extension API changes: - This also introduces support for opening a window with multiple tabs in a non-default container tab. - This also adds LOAD_FLAGS_DISALLOW_INHERIT_PRINCIPAL to the gBrowser.loadTabs call, unless allowInheritPrincipal is set. Currently there are no callers that set this flag, but in case it's desired, I added an opt-in via window.arguments[10] in browser.xul/js. For single-argument URLs, the flag is an opt-out, since there are multiple callers that rely on principal inheritance (bug 1475201). Depends on D4928 Differential Revision: https://phabricator.services.mozilla.com/D4929
e41e69aa9eb5: Bug 1393570 - Move cookieStoreId validator to ext-tabs-base.js r=rpl
Rob Wu <rob@robwu.nl> - Wed, 05 Sep 2018 21:04:22 +0000 - rev 494333
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1393570 - Move cookieStoreId validator to ext-tabs-base.js r=rpl This is a preparation to support cookieStoreId in the windows.create. Depends on D4920 Differential Revision: https://phabricator.services.mozilla.com/D4928
17ab3c3b1256: Bug 1485307 - Focus urlbar when extension opens new tab r=rpl a=pascalc
Rob Wu <rob@robwu.nl> - Wed, 19 Sep 2018 12:28:20 +0000 - rev 492573
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1485307 - Focus urlbar when extension opens new tab r=rpl a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D6029
47094cecc7e1: Bug 1488055 fix loading ext-browser-content script in sidebar when browser_style=false, r=rpl a=pascalc
Shane Caraveo <scaraveo@mozilla.com> - Wed, 12 Sep 2018 18:52:52 +0000 - rev 492463
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1488055 fix loading ext-browser-content script in sidebar when browser_style=false, r=rpl a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D5196
69846c690825: Bug 1429610 Add internal api to look up available language packs r=gandalf,rpl
Andrew Swan <aswan@mozilla.com> - Mon, 14 May 2018 10:18:32 -0700 - rev 491702
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1429610 Add internal api to look up available language packs r=gandalf,rpl MozReview-Commit-ID: ISIu9mDIvbP
6577561a493b: Bug 1475842 - Change parameter format in browser.search API r=rpl
Rob Wu <rob@robwu.nl> - Tue, 21 Aug 2018 14:43:46 +0000 - rev 490400
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1475842 - Change parameter format in browser.search API r=rpl Changes to browser.search.search API: - Change the positional parameters to an object parameter. - Rename "engineName" to "engine", and make this an optional parameter. - Rename "searchTerms" to "query". Changes to browser.search.search implementation: - Simplify gBrowser getter. None of the "!gBrowser" conditionals are necessary, as demonstrated by the new options page+sidebar tests (which passed even after removing the `if (!gBrowser ...)` blocks). Use windowTracker.topWindow for consistency with our other code. Test changes: - Remove unneeded name / "TEST_ID" in tests - Use SEARCH_TERM constant in more places. - New test: Using API from options page. - New test: Using API from sidebar. - New test: Using API without explicit "engine" parameter. Differential Revision: https://phabricator.services.mozilla.com/D3417
774f0b7aba00: Bug 1449055 Exit the toolbox process gracefully in browser_ext_addon_debugging_netmonitor.js r=rpl
Andrew Swan <aswan@mozilla.com> - Wed, 15 Aug 2018 06:26:16 -0700 - rev 489703
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1449055 Exit the toolbox process gracefully in browser_ext_addon_debugging_netmonitor.js r=rpl
da3100049ef2: Bug 1449055 Exit the toolbox process gracefully in browser_ext_addon_debugging_netmonitor.js r=rpl
Andrew Swan <aswan@mozilla.com> - Wed, 15 Aug 2018 06:26:16 -0700 - rev 489517
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1449055 Exit the toolbox process gracefully in browser_ext_addon_debugging_netmonitor.js r=rpl
e811adca6e23: Bug 1477688 - Enable test_ext_contexts_gc on Android r=rpl
Rob Wu <rob@robwu.nl> - Wed, 01 Aug 2018 16:35:16 +0200 - rev 487549
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1477688 - Enable test_ext_contexts_gc on Android r=rpl MozReview-Commit-ID: 2q8FkeCl4Ay
fb52c3f74edc: Bug 1378647 - support creating lazy tabs from extensions, r=JanH,mikedeboer,rpl
Shane Caraveo <scaraveo@mozilla.com> - Mon, 30 Jul 2018 12:15:32 -0300 - rev 486948
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1378647 - support creating lazy tabs from extensions, r=JanH,mikedeboer,rpl MozReview-Commit-ID: 9QMkNtCQG6P
83e6d44180c0: Bug 1457115 - Simplify *_ext_tabs_executeScript_bad.* r=rpl
Rob Wu <rob@robwu.nl> - Thu, 24 May 2018 19:16:49 +0200 - rev 486502
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1457115 - Simplify *_ext_tabs_executeScript_bad.* r=rpl MozReview-Commit-ID: 6FpmCLmePVP
6cc8354ce3c5: Bug 1378647 - support creating lazy tabs from extensions, r=mikedeboer,rpl
Shane Caraveo <scaraveo@mozilla.com> - Wed, 18 Jul 2018 16:17:30 -0300 - rev 485020
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1378647 - support creating lazy tabs from extensions, r=mikedeboer,rpl MozReview-Commit-ID: 9QMkNtCQG6P
e75b08486dc6: Bug 1474132 - Choose right add-on icon size in about:addons and install popup r=rpl
Oriol Brufau <oriol-bugzilla@hotmail.com> - Fri, 13 Jul 2018 13:51:28 +0200 - rev 484882
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1474132 - Choose right add-on icon size in about:addons and install popup r=rpl MozReview-Commit-ID: L5O2OwlK879
11a2e09c259b: Bug 1459750 - Remove unused principal variable r=rpl
Rob Wu <rob@robwu.nl> - Tue, 08 May 2018 11:31:57 +0200 - rev 484840
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1459750 - Remove unused principal variable r=rpl Variable `principal` is only used when `this.isExtensionPage` is false. So move this inside the branch where this condition is satisfied, and remove the `else if (this.isExtensionPage) { ... }` block. (This is a follow-up to bug 1214658, where the check was introduced that obsoleted the principal variable when `this.isExtensionPage` due to the use of `contentWindow` instead of `principal`). (`principal = contentPrincipal` was already unused at its introduction in bug 1317697) MozReview-Commit-ID: F7VX9vAH8MM
9aeb585f5f7d: Bug 1459750 - Add JSDoc to ExtensionContent.Script constructor r=rpl
Rob Wu <rob@robwu.nl> - Tue, 08 May 2018 01:59:48 +0200 - rev 484839
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1459750 - Add JSDoc to ExtensionContent.Script constructor r=rpl `contentScripts` in extension-process-script.js lazily instantiates `ExtensionContent.Script` using the key as "matcher". This "matcher" is usually a `WebExtensionContentScript`, except in case of "Extension:Execute". Then the object is a `WebExtensionContentScript`, extended with some expando properties. MozReview-Commit-ID: 3hMAy9Ff1lr
a054ee2f2a04: Bug 1459750 - Remove unused BrowserExtensionContent.scripts r=mixedpuppy,rpl
Rob Wu <rob@robwu.nl> - Mon, 07 May 2018 22:32:53 +0200 - rev 484837
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1459750 - Remove unused BrowserExtensionContent.scripts r=mixedpuppy,rpl This "scripts" getter started to become unused in: https://hg.mozilla.org/mozilla-central/rev/1267d47eca93 The "extension" in the "extension.scripts" above was changed from "BrowserExtensionContent" to "StubExtension". (and this "StubExtension" does not exist in the current code base any more, as it has been replaced with "WebExtensionPolicy" - see the bug). MozReview-Commit-ID: HkNhy4QOB15
21074760bff6: Bug 1455405 fix intermittent by using real events, r=rpl
Shane Caraveo <scaraveo@mozilla.com> - Mon, 16 Jul 2018 09:08:30 -0300 - rev 484529
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1455405 fix intermittent by using real events, r=rpl This test was testing that files are loaded/executed/etc in the page, but what we really care about is that the webrequest api works. Other tests are responsible for stuff like css and js actually work. The patch does maintain (fixed) the js test, but removes the css test for lack of a good way to properly wait for css to apply. MozReview-Commit-ID: B2uByaxNeK2
75ee38b6550f: Bug 1474379 - Match regex against the entire panel ID. r=miker,rpl
Ian Moody <moz-ian@perix.co.uk> - Tue, 10 Jul 2018 17:38:35 +0100 - rev 484325
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1474379 - Match regex against the entire panel ID. r=miker,rpl So panels provided by extensions with IDs that contain words like "inspector" don't break. Include test in existing panel creation test. MozReview-Commit-ID: JerMCaKRgkl
d93abdc258e1: Bug 1474379 - Match regex against the entire panel ID. r=miker,rpl
Ian Moody <moz-ian@perix.co.uk> - Tue, 10 Jul 2018 17:38:35 +0100 - rev 484233
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1474379 - Match regex against the entire panel ID. r=miker,rpl So panels provided by extensions with IDs that contain words like "inspector" don't break. Include test in existing panel creation test. MozReview-Commit-ID: JerMCaKRgkl
8a4ba4e8e53e: Bug 1474626 - fix timestamp test and values, r=rpl
Shane Caraveo <scaraveo@mozilla.com> - Wed, 11 Jul 2018 14:54:03 -0300 - rev 483980
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1474626 - fix timestamp test and values, r=rpl The test was incorrect and the timestamp should be milliseconds, not microseconds. MozReview-Commit-ID: 2d79r6PHH4Z
14e28f7332c7: Bug 1471959 - leave keaGroupName and signatureSchemeName undefined if value is none, r=rpl
Shane Caraveo <scaraveo@mozilla.com> - Fri, 06 Jul 2018 09:41:56 -0300 - rev 483055
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1471959 - leave keaGroupName and signatureSchemeName undefined if value is none, r=rpl MozReview-Commit-ID: 2Ca7xCMOPAH
fc0d9d4bf1bf: Bug 1445836 - finalize topSites api on platform APIs that will be stable, r=Mardak,rpl
Shane Caraveo <scaraveo@mozilla.com> - Fri, 06 Jul 2018 09:33:50 -0300 - rev 483053
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1445836 - finalize topSites api on platform APIs that will be stable, r=Mardak,rpl MozReview-Commit-ID: Esj5sJweJ4K
ce1755e40f5b: Bug 1470516 - remove or fix localized values in securityInfo, r=rpl
Shane Caraveo <scaraveo@mozilla.com> - Mon, 02 Jul 2018 15:45:18 -0300 - rev 482540
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1470516 - remove or fix localized values in securityInfo, r=rpl MozReview-Commit-ID: 3xURSfbPTmS
75cbadc45030: Bug 1351663 - Support SameSite flag in browser.cookies API r=rpl
Rob Wu <rob@robwu.nl> - Sat, 09 Jun 2018 01:26:26 +0200 - rev 482405
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1351663 - Support SameSite flag in browser.cookies API r=rpl A part of cookies.json is copied from https://chromium.googlesource.com/chromium/src/+/ea90e377568cce415d261ecd472ab941ccc42a8e/chrome/common/extensions/api/cookies.json MozReview-Commit-ID: LCVN9Y8uHIL
1013e1d3ae84: Bug 1455405 - Fix intermittent by using real events. r=rpl, a=test-only
Shane Caraveo <scaraveo@mozilla.com> - Mon, 16 Jul 2018 09:08:30 -0300 - rev 480534
Push 1757 by ffxbld-merge at Fri, 24 Aug 2018 17:02:43 +0000
Bug 1455405 - Fix intermittent by using real events. r=rpl, a=test-only This test was testing that files are loaded/executed/etc in the page, but what we really care about is that the webrequest api works. Other tests are responsible for stuff like css and js actually work. The patch does maintain (fixed) the js test, but removes the css test for lack of a good way to properly wait for css to apply. MozReview-Commit-ID: B2uByaxNeK2
6fffc0b497a3: Bug 1474379 - Match regex against the entire panel ID. r=miker,rpl a=lizzard
Ian Moody <moz-ian@perix.co.uk> - Tue, 10 Jul 2018 17:38:35 +0100 - rev 480526
Push 1757 by ffxbld-merge at Fri, 24 Aug 2018 17:02:43 +0000
Bug 1474379 - Match regex against the entire panel ID. r=miker,rpl a=lizzard So panels provided by extensions with IDs that contain words like "inspector" don't break. Include test in existing panel creation test. MozReview-Commit-ID: JerMCaKRgkl
54ec00f46350: Bug 1474626 - fix timestamp test and values, r=rpl a=lizzard
Shane Caraveo <scaraveo@mozilla.com> - Wed, 11 Jul 2018 14:54:03 -0300 - rev 480459
Push 1757 by ffxbld-merge at Fri, 24 Aug 2018 17:02:43 +0000
Bug 1474626 - fix timestamp test and values, r=rpl a=lizzard The test was incorrect and the timestamp should be milliseconds, not microseconds. MozReview-Commit-ID: 2d79r6PHH4Z
cb0560aa6642: Bug 1471959 - Leave keaGroupName and signatureSchemeName undefined if value is none. r=rpl, a=lizzard
Shane Caraveo <scaraveo@mozilla.com> - Fri, 06 Jul 2018 09:41:56 -0300 - rev 480404
Push 1757 by ffxbld-merge at Fri, 24 Aug 2018 17:02:43 +0000
Bug 1471959 - Leave keaGroupName and signatureSchemeName undefined if value is none. r=rpl, a=lizzard MozReview-Commit-ID: 2Ca7xCMOPAH
97d009f65f60: Bug 1470516 - remove or fix localized values in securityInfo, r=rpl a=lizzard
Shane Caraveo <scaraveo@mozilla.com> - Mon, 02 Jul 2018 15:45:18 -0300 - rev 480359
Push 1757 by ffxbld-merge at Fri, 24 Aug 2018 17:02:43 +0000
Bug 1470516 - remove or fix localized values in securityInfo, r=rpl a=lizzard MozReview-Commit-ID: 3xURSfbPTmS
e05d3484f97a: Bug 1468830 ignore exceptions when retreiving response headers, r=rpl
Shane Caraveo <scaraveo@mozilla.com> - Thu, 14 Jun 2018 12:42:52 -0700 - rev 479320
Push 1757 by ffxbld-merge at Fri, 24 Aug 2018 17:02:43 +0000
Bug 1468830 ignore exceptions when retreiving response headers, r=rpl MozReview-Commit-ID: Dw4X1q15NHv
8d32de537989: Bug 1465063 - Return FP cookies from cookies.getAll even if domain/url is set r=rpl
Rob Wu <rob@robwu.nl> - Fri, 08 Jun 2018 17:20:02 +0200 - rev 478709
Push 1757 by ffxbld-merge at Fri, 24 Aug 2018 17:02:43 +0000
Bug 1465063 - Return FP cookies from cookies.getAll even if domain/url is set r=rpl `browser.cookies.getAll(details)` is expected to return all cookies if the "details.firstPartyDomain" key is set to undefined/null. This usually works, because `getCookiesWithOriginAttributes` is used, which iterates over all cookies and only checks origin attributes that exist in the specified pattern. If a "url" or "domain" are set, then `getCookiesFromHost` was used, which uses a look-up table keyed by host and OriginAttributes, with undefined origin attributes initialized at their default value. Consequently, only non-FP cookies were returned. This commit fixes the issue by using `getCookiesWithOriginAttributes` when the `firstPartyDomain` does not have an explicit (string) value. MozReview-Commit-ID: AxHbbDeqSwr
dccf43cba794: Bug 1465063 - Add tests for get/getAll w/o firstPartyDomain r=rpl
Rob Wu <rob@robwu.nl> - Fri, 08 Jun 2018 13:36:36 +0200 - rev 478708
Push 1757 by ffxbld-merge at Fri, 24 Aug 2018 17:02:43 +0000
Bug 1465063 - Add tests for get/getAll w/o firstPartyDomain r=rpl The test coverage for cookies.get was incomplete, as scenarios with empty, null and undefined firstPartyDomain were not checked. There is a distinction between "empty" and "w/o firstPartyDomain". MozReview-Commit-ID: 1l54nUOCneK
b3e5e1651b49: Bug 1465063 - Add await before assertRejects r=rpl
Rob Wu <rob@robwu.nl> - Fri, 08 Jun 2018 11:31:05 +0200 - rev 478707
Push 1757 by ffxbld-merge at Fri, 24 Aug 2018 17:02:43 +0000
Bug 1465063 - Add await before assertRejects r=rpl Wait for the promise resolution before moving to the next line in the tests. MozReview-Commit-ID: Ldeiwj9vCzn
00f45773f03d: Bug 1466388 - Android webext popup should not be considered to be the active or highlighted tab r=rpl
Oriol Brufau <oriol-bugzilla@hotmail.com> - Sun, 03 Jun 2018 03:00:39 +0200 - rev 478355
Push 1757 by ffxbld-merge at Fri, 24 Aug 2018 17:02:43 +0000
Bug 1466388 - Android webext popup should not be considered to be the active or highlighted tab r=rpl MozReview-Commit-ID: 3WVoR80ICzo
01522ef99b41: Bug 1465519 - avoid passing null node to getClassName, r=rpl
Shane Caraveo <scaraveo@mozilla.com> - Wed, 30 May 2018 12:47:18 -0400 - rev 478096
Push 1757 by ffxbld-merge at Fri, 24 Aug 2018 17:02:43 +0000
Bug 1465519 - avoid passing null node to getClassName, r=rpl MozReview-Commit-ID: 7K8A0SdqjPJ
4ab1dbec331e: Bug 1461426 - IPCBlobInputStreamParent should be sent as underlying stream to the content - unit test, r=rpl
Andrea Marchesini <amarchesini@mozilla.com> - Tue, 29 May 2018 20:02:03 +0200 - rev 477040
Push 1757 by ffxbld-merge at Fri, 24 Aug 2018 17:02:43 +0000
Bug 1461426 - IPCBlobInputStreamParent should be sent as underlying stream to the content - unit test, r=rpl
346ec4590599: Bug 1322748 add securityInfo to webRequest listeners, r=keeler,rpl
Shane Caraveo <scaraveo@mozilla.com> - Wed, 23 May 2018 14:36:19 -0400 - rev 476622
Push 1757 by ffxbld-merge at Fri, 24 Aug 2018 17:02:43 +0000
Bug 1322748 add securityInfo to webRequest listeners, r=keeler,rpl MozReview-Commit-ID: Hen1tl1RWTC