searching for reviewer(ritu)
da9f01df3bef6c8e34104875b4c5453b59e63155: Bug 1555627 - Set a learn more link on net error pages. r=prathiksha a=ritu DEVEDITION_68_0b13_BUILD1 DEVEDITION_68_0b13_RELEASE FIREFOX_68_0b13_BUILD1 FIREFOX_68_0b13_RELEASE
Johann Hofmann <jhofmann@mozilla.com> - Thu, 20 Jun 2019 23:26:43 +0000 - rev 537071
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1555627 - Set a learn more link on net error pages. r=prathiksha a=ritu Bug 1284835 removed the hard-coded learn more link on cert and net error pages, which worked for cert error pages because they explicitly set their own learn more links, but net error pages were relying on the default href to be set. This wasn't revealed until bug 1530348 made about:neterror part of the new error pages. The solution is simply to explicitly set the correct learn more link to net error pages. Note that in the case of PR_END_OF_FILE errors, we were not previously showing a "learn more" link. That was not intentional, as far as I can tell, but was caused by the bug fixed in bug 1477875. Differential Revision: https://phabricator.services.mozilla.com/D35163
c369003558cb91db6e7828c4e0c74ff32da47ff1: Bug 1559317 - ensure outline is not visible when tbody gets focus on :active. r=mtigley a=ritu
Yura Zenevich <yura.zenevich@gmail.com> - Thu, 20 Jun 2019 20:43:58 +0000 - rev 537070
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1559317 - ensure outline is not visible when tbody gets focus on :active. r=mtigley a=ritu Depends on D35065 Differential Revision: https://phabricator.services.mozilla.com/D35066
902d1b155d7bdbaeb3b08e3a2a06721aeb18d4c3: Bug 1559316 - ensure badge background does not turn white when tbody gets focus on :active. r=mtigley a=ritu
Yura Zenevich <yura.zenevich@gmail.com> - Thu, 20 Jun 2019 20:43:35 +0000 - rev 537069
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1559316 - ensure badge background does not turn white when tbody gets focus on :active. r=mtigley a=ritu Differential Revision: https://phabricator.services.mozilla.com/D35065
edc925e0821a1066f0b354a486cfffe34b40e4f2: Bug 1559094 - Restore old behavior for background-size: cover + zero-sized background positioning area. r=dholbert a=ritu
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 23 Jun 2019 10:08:16 +0000 - rev 537068
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1559094 - Restore old behavior for background-size: cover + zero-sized background positioning area. r=dholbert a=ritu This restores our previous and per-spec behavior. Comparing only ratios was not correct in the case one of the dimensions was zero and thus not scaled. Differential Revision: https://phabricator.services.mozilla.com/D35571
8fb74fcbc12c83a230f700196e83193e6749d740: Bug 1557056 - Use extended function only for self-hosted function that needs to store canonical name in extended slot. r=jandem a=ritu
Tooru Fujisawa <arai_a@mac.com> - Wed, 19 Jun 2019 20:00:24 +0000 - rev 537067
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1557056 - Use extended function only for self-hosted function that needs to store canonical name in extended slot. r=jandem a=ritu Differential Revision: https://phabricator.services.mozilla.com/D34983
60e8af0747b4ae12b440b3e406ffedd4ccc71d5f: Bug 1559264 - Quantumbar: Don't call setValueFromResult when opening the history popup. r=dao a=ritu
Drew Willcoxon <adw@mozilla.com> - Fri, 21 Jun 2019 18:37:27 +0000 - rev 537066
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1559264 - Quantumbar: Don't call setValueFromResult when opening the history popup. r=dao a=ritu The problem is that on switching back to the first tab (see the bug), userTypedValue is non-null when URLBarSetURI is called. Therefore the proxy state can't be valid. Something about bug 1529931 caused userTypedValue to go from null to non-null in this case. Details below, but the summary is that we shouldn't be calling UrlbarInput.setValueFromResult when opening the history popup, because setValueFromResult sets userTypedValue. Before bug 1529931, result.autofill would always be undefined for the first result in the history popup, because we didn't allow UnifiedComplete to return an autofill result for the search triggered by the history popup. After that bug, UnifiedComplete could return an autofill result in that case -- and it likely would since the first result in the history popup has a very high frecency, which also makes it eligible for autofill. The problem with having an autofill result in the history popup is that it triggers the input.setValueFromResult() call in UrlbarController.receiveResults [1], and setValueFromResult sets userTypedValue. So when the user opens the history popup, userTypedValue gets set to a non-null value (input._lastSearchString). The fix is to not allow autofill for the history popup. After making that fix on revision https://hg.mozilla.org/mozilla-central/rev/5e2a3b886e64, the bug went away. However, after I made that fix on a fresh tree, the bug still happened. It turns out that input.setValueFromResult still ends up getting called, by UrlbarView._selectItem [2], which is called when results are received [3]. The fix for this afaict is just to pass `updateInput: false` to _selectItem. The autofill-related fix doesn't seem to be necessary at all anymore (likely due to the substantial changes to autofill since that bug landed), but I left it in anyway since it seems right to not allow autofill results for the history popup. One other useful bit of info is that userTypedValue is set to null by tabbrowser on page load [4], so that's how userTypedValue has a null value when the bug manifests and it goes from null to non-null. [1] https://hg.mozilla.org/mozilla-central/file/5e2a3b886e647af1968b9e52a6672bdeee2a0d6f/browser/components/urlbar/UrlbarController.jsm#l150 [2] https://searchfox.org/mozilla-central/rev/da14c413ef663eb1ba246799e94a240f81c42488/browser/components/urlbar/UrlbarView.jsm#685 [3] https://searchfox.org/mozilla-central/rev/da14c413ef663eb1ba246799e94a240f81c42488/browser/components/urlbar/UrlbarView.jsm#220 [4] https://searchfox.org/mozilla-central/rev/da14c413ef663eb1ba246799e94a240f81c42488/browser/base/content/tabbrowser.js#5118 Differential Revision: https://phabricator.services.mozilla.com/D35505
3d562db5d1ed358a18da5bbe160c1da4864ef6c0: Bug 1528481 - Possible use after free in Http2Session::RecvPushPromise() if we have a usable entry in the cache for the resource. r=dragana, a=ritu
Michal Novotny <michal.novotny@gmail.com> - Fri, 14 Jun 2019 22:54:06 +0000 - rev 537065
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1528481 - Possible use after free in Http2Session::RecvPushPromise() if we have a usable entry in the cache for the resource. r=dragana, a=ritu If we find a usable cache entry, the stream is closed and release in CachePushCheckCallback::OnCacheEntryCheck(). This patch converts raw pointer to a weak pointer, so we can simply check if the object still exists after AsyncOpenURI() finishes. Differential Revision: https://phabricator.services.mozilla.com/D33945
4174d76d91945a7261f81d7666eee4b2b35cb027: Bug 1547266 - Make sure Http2PushedStream is used only on socket thread. r=dragana, a=ritu
Michal Novotny <michal.novotny@gmail.com> - Tue, 18 Jun 2019 23:36:54 +0000 - rev 537064
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1547266 - Make sure Http2PushedStream is used only on socket thread. r=dragana, a=ritu Raw pointer to Http2PushedStream is passed to nsHttpChannel and nsHttpTransaction to get it back to a new Http2Stream in the Http2Session. As a result Http2PushedStream's methods can be called on a wrong thread and possibly on already freed object. This patch uses Http2PushedStreamWrapper instead, which takes care about thread safety and checks if the object is still alive. Differential Revision: https://phabricator.services.mozilla.com/D33511
fd384ae3e04ea04fada7a72d9b2362862c0a3898: Bug 1558549 - Update to NSS_3_44_1_RTM. a=ritu UPGRADE_NSS_RELEASE
J.C. Jones <jjones@mozilla.com> - Mon, 24 Jun 2019 10:01:40 +0200 - rev 537063
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1558549 - Update to NSS_3_44_1_RTM. a=ritu UPGRADE_NSS_RELEASE
2bee7577b5a687ef6da1cd27852da85d28af2395: Bug 1560527 - Enable make backend verbose mode automatically rather than relying on mach setting it. r=froydnj a=ritu
Mike Hommey <mh+mozilla@glandium.org> - Fri, 21 Jun 2019 13:15:30 +0000 - rev 537062
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1560527 - Enable make backend verbose mode automatically rather than relying on mach setting it. r=froydnj a=ritu This makes running without mach more consistent. e.g. running `make -C $objdir/toolkit/library/rust target` makes the cargo log verbose, and adding `-s` makes it less verbose. Differential Revision: https://phabricator.services.mozilla.com/D35521
29b838345c241ca20986a6dba9843d3f5fc4d09a: Bug 1560336 - Stop using the toolbaritem-combined-buttons class for the Firefox account menu item. r=Gijs a=ritu
Dão Gottwald <dao@mozilla.com> - Thu, 20 Jun 2019 18:56:08 +0000 - rev 537061
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1560336 - Stop using the toolbaritem-combined-buttons class for the Firefox account menu item. r=Gijs a=ritu Differential Revision: https://phabricator.services.mozilla.com/D35434
4dc07e652294ff5ed28e6cd4b210ec20b162f07b: Bug 1559686 - Reimplement the inputHistory feature in the Quantum Bar. r=adw a=ritu
Marco Bonardo <mbonardo@mozilla.com> <mbonardo@mozilla.com> - Thu, 20 Jun 2019 18:21:01 +0000 - rev 537060
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1559686 - Reimplement the inputHistory feature in the Quantum Bar. r=adw a=ritu Differential Revision: https://phabricator.services.mozilla.com/D35364
be8cd9575508ce1a95b971ccbfe3a7ceec59bc0b: Bug 1549061 - Add intermediate certificate [release]. r=kmag a=ritu CLOSED TREE DEVEDITION_67_0b17_BUILD1 DEVEDITION_67_0b17_RELEASE FENNEC_67_0b17_BUILD2 FENNEC_67_0b17_RELEASE FIREFOX_67_0b17_BUILD2 FIREFOX_67_0b17_RELEASE
Mark Goodwin <mgoodwin@mozilla.com> - Sun, 05 May 2019 04:57:35 +0300 - rev 526490
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1549061 - Add intermediate certificate [release]. r=kmag a=ritu CLOSED TREE Summary: This patch relies on a schema bump in a previous commit Reviewers: kmag Reviewed By: kmag Bug #: 1549061 Differential Revision: https://phabricator.services.mozilla.com/D29949
848b15028562c6757748070f637e0e4f0bbb5f65: Bug 1549061 - Add intermediate certificate [release];r=kmag a=ritu CLOSED TREE FENNEC_66_0_4_BUILD3 FENNEC_66_0_4_RELEASE FIREFOX_66_0_4_BUILD3 FIREFOX_66_0_4_RELEASE
Mark Goodwin <mgoodwin@mozilla.com> - Sat, 04 May 2019 14:14:44 -0700 - rev 516448
Push 2019 by bgrinstead@mozilla.com at Sat, 04 May 2019 21:26:14 +0000
Bug 1549061 - Add intermediate certificate [release];r=kmag a=ritu CLOSED TREE This patch relies on a schema bump in a previous commit Differential Revision: https://phabricator.services.mozilla.com//D29949
4c716c5c75d6452b4b90b020b55644d9da11855b: Backed out changeset 94eb3f14832d (bug 1549061) a=ritu CLOSED TREE
Brian Grinstead <bgrinstead@mozilla.com> - Sat, 04 May 2019 14:08:49 -0700 - rev 516447
Push 2019 by bgrinstead@mozilla.com at Sat, 04 May 2019 21:26:14 +0000
Backed out changeset 94eb3f14832d (bug 1549061) a=ritu CLOSED TREE
f0978d33730c3a9b4b99ed623f25e352beb3ee5b: Bug 1513737 - Stop using Array.shift when mapping pause points. r=dwalsh, a=ritu
Jason Laster <jlaster@mozilla.com> - Mon, 17 Dec 2018 16:40:00 -0500 - rev 509081
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1513737 - Stop using Array.shift when mapping pause points. r=dwalsh, a=ritu Reviewers: davidwalsh Reviewed By: davidwalsh Differential Revision: https://phabricator.services.mozilla.com/D14346
331cafa0d8476c853ee44ba53353383cbbd8656f: Bug 1502410 - Don't use deleteBranch in Normandy. r=Gijs,adw, a=ritu
Michael Cooper <mcooper@mozilla.com> - Wed, 14 Nov 2018 16:47:14 +0000 - rev 501226
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1502410 - Don't use deleteBranch in Normandy. r=Gijs,adw, a=ritu nsIPrefBranch.deleteBranch doesn't work as documented when the preference's default value was set very early after Firefox has started, such as when Normandy sets startup branches. This is filed as bug 1505941. In order to work around this problem, this patch makes Normandy never use deleteBranch, except in tests where it is safe to do so. With this patch, an experiment that is run on the default branch for a preference that does not have a default value in the tree cannot be promptly unenrolled, instead we must wait until the preference is naturally cleared when Firefox restarts. This is better than never unenrolling though. Differential Revision: https://phabricator.services.mozilla.com/D11383
2085f7f22a53096e032c9c0a4931d282ed3f0d43: Bug 1502410 - Don't use deleteBranch in Normandy. r=Gijs,adw, a=ritu FIREFOX_63_0_3_BUILD1 FIREFOX_63_0_3_RELEASE
Michael Cooper <mcooper@mozilla.com> - Wed, 14 Nov 2018 16:47:14 +0000 - rev 492998
Push 1857 by ryanvm@gmail.com at Wed, 14 Nov 2018 21:46:35 +0000
Bug 1502410 - Don't use deleteBranch in Normandy. r=Gijs,adw, a=ritu nsIPrefBranch.deleteBranch doesn't work as documented when the preference's default value was set very early after Firefox has started, such as when Normandy sets startup branches. This is filed as bug 1505941. In order to work around this problem, this patch makes Normandy never use deleteBranch, except in tests where it is safe to do so. With this patch, an experiment that is run on the default branch for a preference that does not have a default value in the tree cannot be promptly unenrolled, instead we must wait until the preference is naturally cleared when Firefox restarts. This is better than never unenrolling though. Differential Revision: https://phabricator.services.mozilla.com/D11383
8c489cac4a10cb54027647e64cfd08cff46bef37: Bug 1499549 - Ensure that we only check the corresponding Content Blocking exception list when testing whether a top-level document is on the Content Blocking allow list; r=francois a=ritu
Ehsan Akhgari <ehsan@mozilla.com> - Thu, 18 Oct 2018 16:22:37 +0300 - rev 492943
Push 1826 by archaeopteryx@coole-files.de at Thu, 18 Oct 2018 13:24:30 +0000
Bug 1499549 - Ensure that we only check the corresponding Content Blocking exception list when testing whether a top-level document is on the Content Blocking allow list; r=francois a=ritu Differential Revision: https://phabricator.services.mozilla.com/D8927
095138ddfce66ad816470b4f0132e700d859f00a: Bug 1497259 - 3. Control GV logging through pref; r=droeh, a=ritu
Jim Chen <nchen@mozilla.com> - Wed, 10 Oct 2018 17:36:13 +0000 - rev 492893
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1497259 - 3. Control GV logging through pref; r=droeh, a=ritu Use the "geckoview.logging" pref to control GV logging. Differential Revision: https://phabricator.services.mozilla.com/D8052
6cd7919cc0b8b4e05c495bed36ba70c60fb14bdf: Bug 1497259 - 2. Don't log auto-fill values; r=droeh, a=ritu
Jim Chen <nchen@mozilla.com> - Wed, 10 Oct 2018 17:36:11 +0000 - rev 492892
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1497259 - 2. Don't log auto-fill values; r=droeh, a=ritu Auto-fill values can contain personal information and must not appear in the log. Differential Revision: https://phabricator.services.mozilla.com/D8051
c78886e8b28ee7ca945373cfc015ee011ce323f8: Bug 1497259 - 1. Fix log module names; r=droeh, a=ritu
Jim Chen <nchen@mozilla.com> - Wed, 10 Oct 2018 17:36:03 +0000 - rev 492891
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1497259 - 1. Fix log module names; r=droeh, a=ritu Fix the GV log module names so they are all under the GeckoView group. Differential Revision: https://phabricator.services.mozilla.com/D8050
d21a43596d555ea618da75910aa3c1cb06158725: Bug 1475325 - 2. Add tests for hiding selection action in different cases; r=jchen a=ritu
Jim Chen <nchen@mozilla.com> - Tue, 18 Sep 2018 15:20:03 -0400 - rev 492602
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1475325 - 2. Add tests for hiding selection action in different cases; r=jchen a=ritu Add some tests for hiding selection action during navigation, blurring, or clearing delegate.
297509ef3d02a63316ca5f3b6e20029b542ba996: Bug 1475325 - Hide selection action in some scenarios; r=droeh a=ritu
Jim Chen <nchen@mozilla.com> - Mon, 17 Sep 2018 23:15:17 +0000 - rev 492601
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1475325 - Hide selection action in some scenarios; r=droeh a=ritu Hide the selection action toolbar when the session is unfocused, or when changing the selection action delegate. Differential Revision: https://phabricator.services.mozilla.com/D5807
5bd0f4d6fed870fbe5697035707770522be60327: Bug 1486970 - Create revision and pushlog-id index routes for cron decision tasks. r=dustin,aki a=ritu
Justin Wood <Callek@gmail.com> - Fri, 14 Sep 2018 16:47:09 +0000 - rev 492595
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1486970 - Create revision and pushlog-id index routes for cron decision tasks. r=dustin,aki a=ritu This hardcodes the push info in .taskgraph.yml for cron so that we don't break Chain Of Trust (signing) on other branches (uplifts) when we adjust scriptworker to start passing in this data to json-e. This allows us to incrementally roll this out without needing a flag day, and will be needed on all production branches. Differential Revision: https://phabricator.services.mozilla.com/D4501
f6a4fa55f7245e3860503595c74d5b24e7ff0642: Bug 1475325 - 2. Add tests for hiding selection action in different cases; r=jchen a=ritu
Jim Chen <nchen@mozilla.com> - Tue, 18 Sep 2018 15:20:03 -0400 - rev 492567
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1475325 - 2. Add tests for hiding selection action in different cases; r=jchen a=ritu Add some tests for hiding selection action during navigation, blurring, or clearing delegate.
d66bd740b59ffdcb800dc225cf29fc383d5e1a2b: Bug 1497259 - 3. Control GV logging through pref; r=droeh, a=ritu GECKOVIEW_62_RELBRANCH
Jim Chen <nchen@mozilla.com> - Wed, 10 Oct 2018 17:36:13 +0000 - rev 481206
Push 1814 by nchen@mozilla.com at Thu, 11 Oct 2018 21:42:25 +0000
Bug 1497259 - 3. Control GV logging through pref; r=droeh, a=ritu Use the "geckoview.logging" pref to control GV logging. Differential Revision: https://phabricator.services.mozilla.com/D8052
b24c34189591dd31e16faf40daf7c73f598c23bf: Bug 1497259 - 2. Don't log auto-fill values; r=droeh, a=ritu GECKOVIEW_62_RELBRANCH
Jim Chen <nchen@mozilla.com> - Wed, 10 Oct 2018 17:36:11 +0000 - rev 481205
Push 1814 by nchen@mozilla.com at Thu, 11 Oct 2018 21:42:25 +0000
Bug 1497259 - 2. Don't log auto-fill values; r=droeh, a=ritu Auto-fill values can contain personal information and must not appear in the log. Differential Revision: https://phabricator.services.mozilla.com/D8051
d335b16bbb7c162d06b848895dace67b68d776a4: Bug 1497259 - 1. Fix log module names; r=droeh, a=ritu GECKOVIEW_62_RELBRANCH
Jim Chen <nchen@mozilla.com> - Wed, 10 Oct 2018 17:36:03 +0000 - rev 481204
Push 1814 by nchen@mozilla.com at Thu, 11 Oct 2018 21:42:25 +0000
Bug 1497259 - 1. Fix log module names; r=droeh, a=ritu Fix the GV log module names so they are all under the GeckoView group. Differential Revision: https://phabricator.services.mozilla.com/D8050
691b21e74a5179f546649c5d0f8b52c82a390790: Bug 1486552 - geckoview: Add GeckoRuntimeSettings.setLocale method. r=snorp, a=ritu GECKOVIEW_62_RELBRANCH
Matt Brubeck <mbrubeck@mozilla.com> - Fri, 31 Aug 2018 11:33:29 -0700 - rev 481187
Push 1801 by ryanvm@gmail.com at Fri, 28 Sep 2018 10:06:43 +0000
Bug 1486552 - geckoview: Add GeckoRuntimeSettings.setLocale method. r=snorp, a=ritu Differential Revision: https://phabricator.services.mozilla.com/D4794
61db99a4972c43cf440169f5c3e7cc9e696267a3: Bug 1475325 - 2. Add tests for hiding selection action in different cases; r=jchen a=ritu GECKOVIEW_62_RELBRANCH
Jim Chen <nchen@mozilla.com> - Tue, 18 Sep 2018 15:20:03 -0400 - rev 481160
Push 1795 by nchen@mozilla.com at Fri, 21 Sep 2018 00:23:57 +0000
Bug 1475325 - 2. Add tests for hiding selection action in different cases; r=jchen a=ritu Add some tests for hiding selection action during navigation, blurring, or clearing delegate.
f626192f69c331235305223cafc108ac0d1f03df: Bug 1475325 - Hide selection action in some scenarios; r=droeh a=ritu GECKOVIEW_62_RELBRANCH
Jim Chen <nchen@mozilla.com> - Mon, 17 Sep 2018 23:15:17 +0000 - rev 481159
Push 1795 by nchen@mozilla.com at Fri, 21 Sep 2018 00:23:57 +0000
Bug 1475325 - Hide selection action in some scenarios; r=droeh a=ritu Hide the selection action toolbar when the session is unfocused, or when changing the selection action delegate. Differential Revision: https://phabricator.services.mozilla.com/D5807
933eb444a83989de2bfc8b117d76276252118201: Bug 1486970 - Create revision and pushlog-id index routes for cron decision tasks. r=dustin,aki, a=ritu
Justin Wood <Callek@gmail.com> - Fri, 14 Sep 2018 16:47:09 +0000 - rev 481151
Push 1791 by ryanvm@gmail.com at Thu, 20 Sep 2018 20:41:47 +0000
Bug 1486970 - Create revision and pushlog-id index routes for cron decision tasks. r=dustin,aki, a=ritu This hardcodes the push info in .taskgraph.yml for cron so that we don't break Chain Of Trust (signing) on other branches (uplifts) when we adjust scriptworker to start passing in this data to json-e. This allows us to incrementally roll this out without needing a flag day, and will be needed on all production branches. Differential Revision: https://phabricator.services.mozilla.com/D4501
31683bdf39d7bcacf8d9bf265fc2365024473fbe: Bug 1485178 - Only migrate sharedprefs when in Fennec. r=snorp a=ritu GECKOVIEW_62_RELBRANCH
Dylan Roeh <droeh@mozilla.com> - Tue, 28 Aug 2018 11:35:46 -0500 - rev 481113
Push 1772 by nchen@mozilla.com at Fri, 31 Aug 2018 22:52:36 +0000
Bug 1485178 - Only migrate sharedprefs when in Fennec. r=snorp a=ritu
99aa10a241f65eac26672b56f94a0aabaeeed8c7: Bug 1478171 - [1.0] Forward channel redirect to nsILoadURIDelegate to allow external handling. r=smaug,snorp a=ritu GECKOVIEW_62_RELBRANCH
Dylan Roeh <droeh@mozilla.com> - Tue, 21 Aug 2018 12:52:39 -0500 - rev 481112
Push 1772 by nchen@mozilla.com at Fri, 31 Aug 2018 22:52:36 +0000
Bug 1478171 - [1.0] Forward channel redirect to nsILoadURIDelegate to allow external handling. r=smaug,snorp a=ritu
427eacc1a0bfc1bd07f9c41e16d9d03a739dce7c: Bug 1441059 - Add cycle collection implementations for Maybe. r=bz a=ritu GECKOVIEW_62_RELBRANCH
Dylan Roeh <droeh@mozilla.com> - Tue, 17 Jul 2018 10:34:58 -0500 - rev 481111
Push 1772 by nchen@mozilla.com at Fri, 31 Aug 2018 22:52:36 +0000
Bug 1441059 - Add cycle collection implementations for Maybe. r=bz a=ritu
f5d1ec5536b259e66f014cdf2de71ab8e0dbb06f: Bug 1483397 - Add media control API so apps can control when media is paused r=snorp,rbarker,jchen a=ritu GECKOVIEW_62_RELBRANCH
Imanol Fernandez <imanol@mozilla.com> - Tue, 28 Aug 2018 21:55:03 +0000 - rev 481109
Push 1771 by nchen@mozilla.com at Fri, 31 Aug 2018 22:18:46 +0000
Bug 1483397 - Add media control API so apps can control when media is paused r=snorp,rbarker,jchen a=ritu Add a GeckoSession property too specify if media should be suspended when the session is inactive. Differential Revision: https://phabricator.services.mozilla.com/D4472
e5c09855a9ab461af3ccec1e4fb566050b1504f0: Bug 1483342 - [2.1] Initialize SafeBrowsing module by default to enable safe browsing. r=jchen a=ritu GECKOVIEW_62_RELBRANCH
Eugen Sawin <esawin@mozilla.com> - Tue, 14 Aug 2018 21:42:35 +0200 - rev 481108
Push 1771 by nchen@mozilla.com at Fri, 31 Aug 2018 22:18:46 +0000
Bug 1483342 - [2.1] Initialize SafeBrowsing module by default to enable safe browsing. r=jchen a=ritu
54454c859a682c36bd05cf4e6ff71ffac7a3d05a: Bug 1483342 - [1.1] Add GeckoRuntime Safe Browsing API. r=snorp,jchen,francois a=ritu GECKOVIEW_62_RELBRANCH
Eugen Sawin <esawin@mozilla.com> - Tue, 14 Aug 2018 21:40:50 +0200 - rev 481107
Push 1771 by nchen@mozilla.com at Fri, 31 Aug 2018 22:18:46 +0000
Bug 1483342 - [1.1] Add GeckoRuntime Safe Browsing API. r=snorp,jchen,francois a=ritu
f35ce4a936985ba0c352cc783721cbf142e730ca: Bug 1441059 - Make nsILoadURIDelegate async to preserve the order of GeckoSession.loadUri() calls. r=snorp,bz a=ritu GECKOVIEW_62_RELBRANCH
Dylan Roeh <droeh@mozilla.com> - Tue, 07 Aug 2018 13:42:07 -0500 - rev 481106
Push 1771 by nchen@mozilla.com at Fri, 31 Aug 2018 22:18:46 +0000
Bug 1441059 - Make nsILoadURIDelegate async to preserve the order of GeckoSession.loadUri() calls. r=snorp,bz a=ritu This alters nsILoadURIDelegate.loadURI() to return a Promise rather than spinning the event loop to synchronously return a boolean, and alters nsDocShell::InternalLoad to allow for those changes by re-calling itself if necessary based on the resolution of the promise.
812b11ed03e02e7d5ec9f23c6abcbc46d7859740: Bug 1470394 - Increase bookmark panel width to provide enough area for text in other localizations. r=mak a=ritu DEVEDITION_62_0b16_BUILD1 DEVEDITION_62_0b16_RELEASE FIREFOX_62_0b16_BUILD1 FIREFOX_62_0b16_RELEASE
Dão Gottwald <dao@mozilla.com> - Thu, 09 Aug 2018 12:44:34 +0200 - rev 480855
Push 1757 by ffxbld-merge at Fri, 24 Aug 2018 17:02:43 +0000
Bug 1470394 - Increase bookmark panel width to provide enough area for text in other localizations. r=mak a=ritu
de436be5e56eced99d5a2c8c06fd401a1c74cb3a: Bug 1468249 - Avoid resizing the TP toggle in the main menu in touch mode. r=dao, a=ritu
Johann Hofmann <jhofmann@mozilla.com> - Wed, 27 Jun 2018 21:45:41 +0200 - rev 480779
Push 1757 by ffxbld-merge at Fri, 24 Aug 2018 17:02:43 +0000
Bug 1468249 - Avoid resizing the TP toggle in the main menu in touch mode. r=dao, a=ritu This also fixes bug 1468311, because it made the touch control significantly more annoying. Now, the TP toggle in the main menu has the right size, but tapping outside of it still doesn't trigger it, though at least the menu is not closed so the user can easily tap again. MozReview-Commit-ID: eRfAEwXype
3a3725e292e129729b50c60989a4e2012cf8112a: Bug 1470306 - More assertions in MessagePort, r=qdot a=ritu DEVEDITION_62_0b14_BUILD1 DEVEDITION_62_0b14_RELEASE FIREFOX_62_0b14_BUILD1 FIREFOX_62_0b14_RELEASE
Andrea Marchesini <amarchesini@mozilla.com> - Tue, 24 Jul 2018 09:29:51 +0200 - rev 480732
Push 1757 by ffxbld-merge at Fri, 24 Aug 2018 17:02:43 +0000
Bug 1470306 - More assertions in MessagePort, r=qdot a=ritu Still trying to understand why we have MessagePort::CloseInternal crashes, here I introduce more assertions and a security check in case PBackground initialization fails.
fb00c69a67877caee3c40d523b467ac87784b694: Bug 1470306 - Ensure MessagePort is in the right state if the connection to PBackground fails, r=qdot a=ritu
Andrea Marchesini <amarchesini@mozilla.com> - Tue, 17 Jul 2018 07:14:06 +0200 - rev 480731
Push 1757 by ffxbld-merge at Fri, 24 Aug 2018 17:02:43 +0000
Bug 1470306 - Ensure MessagePort is in the right state if the connection to PBackground fails, r=qdot a=ritu
c1927c01d7ed7678e0115e6ff728ac26069a45ad: Bug 1470306 - Adding some MOZ_DIAGNOSTIC_ASSERT in MessagePort, r=smaug a=ritu
Andrea Marchesini <amarchesini@mozilla.com> - Fri, 13 Jul 2018 17:41:34 +0200 - rev 480730
Push 1757 by ffxbld-merge at Fri, 24 Aug 2018 17:02:43 +0000
Bug 1470306 - Adding some MOZ_DIAGNOSTIC_ASSERT in MessagePort, r=smaug a=ritu
a07fb916fa61a068c5e8b22437ad5cbf9b6dbfad: Bug 1470306 - MessagePort unlinked should start the cleanup/close/shutdown procedure of the object, r=smaug a=ritu
Andrea Marchesini <amarchesini@mozilla.com> - Mon, 02 Jul 2018 12:02:39 +0200 - rev 480729
Push 1757 by ffxbld-merge at Fri, 24 Aug 2018 17:02:43 +0000
Bug 1470306 - MessagePort unlinked should start the cleanup/close/shutdown procedure of the object, r=smaug a=ritu
0249442a741cb771fdd23cd5670d07ac63f920e2: Bug 1480144: Let Windows Restart Manager ride the trains. r=jimm a=ritu
Adam Gashlin <agashlin@mozilla.com> - Thu, 02 Aug 2018 20:30:21 +0300 - rev 480728
Push 1757 by ffxbld-merge at Fri, 24 Aug 2018 17:02:43 +0000
Bug 1480144: Let Windows Restart Manager ride the trains. r=jimm a=ritu Summary: The plan is to study the "restart manager" in 62 with a pref flip, and if that goes well enable it on release in 63. If it is to be enabled for the whole population in 63 it needs to ride the trains, so we'll let it be enabled by default as 63 goes to beta. There will be time to uplift a backout so it won't reach the release population, if the 62 study indicates problems. Reviewers: jmathies Reviewed By: jmathies Bug #: 1480144 Differential Revision: https://phabricator.services.mozilla.com/D2620
e17c9454ca9479fe6f3552b714109b740cfa711f: Bug 1479536 - Fix SessionFinder.clear(); r=droeh a=ritu
Jim Chen <nchen@mozilla.com> - Mon, 30 Jul 2018 16:21:29 -0400 - rev 480727
Push 1757 by ffxbld-merge at Fri, 24 Aug 2018 17:02:43 +0000
Bug 1479536 - Fix SessionFinder.clear(); r=droeh a=ritu Fix the clear() call to clear highlights in addition to the selection. MozReview-Commit-ID: 1DNXa8fIGTP
cdb16820b53eca89322572a56d008cb8d4635df8: Bug 1478800 - Fix find-in-page display flags; r=droeh a=ritu
Jim Chen <nchen@mozilla.com> - Thu, 26 Jul 2018 17:51:45 -0400 - rev 480726
Push 1757 by ffxbld-merge at Fri, 24 Aug 2018 17:02:43 +0000
Bug 1478800 - Fix find-in-page display flags; r=droeh a=ritu Make the display flags actually work. MozReview-Commit-ID: 1fw9Oa0IaGc
60840467a49edb37b04d59c6e1487251e5ded4f5: Bug 1479631 - Fix media.memory_caches_combined_limit_kb value on Android. r=drno a=ritu
Nicholas Nethercote <nnethercote@mozilla.com> - Tue, 31 Jul 2018 10:19:51 +1000 - rev 480717
Push 1757 by ffxbld-merge at Fri, 24 Aug 2018 17:02:43 +0000
Bug 1479631 - Fix media.memory_caches_combined_limit_kb value on Android. r=drno a=ritu It was accidentally changed from 524288 to 32768 on Android by bug 1448222. This commit changes it back.