searching for reviewer(pascalc)
4c21940d5185815ccac9f39a7299ac7bec18f9fe: Bug 1560192 - Clean up prompt open calls in Prompter.jsm. r=Gijs, a=pascalc
Johann Hofmann <jhofmann@mozilla.com> - Wed, 19 Jun 2019 21:59:18 +0000 - rev 537027
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1560192 - Clean up prompt open calls in Prompter.jsm. r=Gijs, a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D35371
54457d76cd8cc055a48a4955822e937511e1b460: Bug 1547924 - Ensure Leanplum Onboarding falls back to the new Onboarding UX; r=VladBaicu a=pascalc
Petru Lingurar <petru.lingurar@softvision.ro> - Tue, 30 Apr 2019 16:43:46 +0300 - rev 536514
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1547924 - Ensure Leanplum Onboarding falls back to the new Onboarding UX; r=VladBaicu a=pascalc Summary: - Added the `LAST_PRIVACY` case for when the user is already signed into Firefox; - Use the new default onboarding strings and images. If they are localized. Differential Revision: https://phabricator.services.mozilla.com/D29347
e5ed24b52564b6a41fd6a4eadde8e8832c4b91c1: Bug 1549075 Follow-up Fix loading built in manifests r=zombie a=pascalc CLOSED TREE
Andrew Swan <aswan@mozilla.com> - Sun, 05 May 2019 09:04:47 -0700 - rev 534440
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1549075 Follow-up Fix loading built in manifests r=zombie a=pascalc CLOSED TREE Differential Revision: https://phabricator.services.mozilla.com/D29963
ea5154beddff08b919697e3bed6f38cfe3a3d82f: Bug 1560192 - Clean up prompt open calls in Prompter.jsm. r=Gijs, a=pascalc FIREFOX_67_0_4_BUILD1 FIREFOX_67_0_4_RELEASE
Johann Hofmann <jhofmann@mozilla.com> - Wed, 19 Jun 2019 21:59:18 +0000 - rev 526605
Push 2077 by jcristau@mozilla.com at Wed, 19 Jun 2019 23:56:27 +0000
Bug 1560192 - Clean up prompt open calls in Prompter.jsm. r=Gijs, a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D35371
1a95e4b8b2d28e76ef63335f96f2b4cc151497f9: Bug 1556076. Restore checking the return value of MakeInputStream in nsIconChannel on mac. r=aosmond a=pascalc FENNEC_67_0_2_BUILD1 FENNEC_67_0_2_RELEASE FIREFOX_67_0_2_BUILD2 FIREFOX_67_0_2_RELEASE
Timothy Nikkel <tnikkel@gmail.com> - Thu, 06 Jun 2019 12:33:00 +0300 - rev 526589
Push 2063 by archaeopteryx@coole-files.de at Fri, 07 Jun 2019 20:48:18 +0000
Bug 1556076. Restore checking the return value of MakeInputStream in nsIconChannel on mac. r=aosmond a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D33892
f0900e70cbef3eaa7388001eb5e5ea8c6f86b1fa: Bug 1555962 - Add a perf test which is an order of magnitude slower without the previous patch. r=heycam a=pascalc
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 03 Jun 2019 19:55:37 +0000 - rev 526588
Push 2063 by archaeopteryx@coole-files.de at Fri, 07 Jun 2019 20:48:18 +0000
Bug 1555962 - Add a perf test which is an order of magnitude slower without the previous patch. r=heycam a=pascalc Depends on D33434 Differential Revision: https://phabricator.services.mozilla.com/D33435
4bde450ccf8a7992452f2adfd98277f20b510849: Bug 1555962 - Fix a typo that makes us reflow too much in abspos subtrees. r=jwatt a=pascalc
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 03 Jun 2019 12:10:29 +0000 - rev 526587
Push 2063 by archaeopteryx@coole-files.de at Fri, 07 Jun 2019 20:48:18 +0000
Bug 1555962 - Fix a typo that makes us reflow too much in abspos subtrees. r=jwatt a=pascalc Ugh, I accidentally introduced this in bug 1523071. :( Differential Revision: https://phabricator.services.mozilla.com/D33434
391c16d79dcc2230efa70b07e672b2e488c47807: Bug 1554167 - Remove pending shutdown sanitization immediately after shutdown sanitization finishes. r=mak,baku a=pascalc
Johann Hofmann <jhofmann@mozilla.com> - Thu, 30 May 2019 15:39:39 +0000 - rev 526586
Push 2063 by archaeopteryx@coole-files.de at Fri, 07 Jun 2019 20:48:18 +0000
Bug 1554167 - Remove pending shutdown sanitization immediately after shutdown sanitization finishes. r=mak,baku a=pascalc In https://hg.mozilla.org/mozilla-central/rev/25397a6f8c4f#l1.35 we added an early return to the SanitizeOnShutdown function to avoid cleaning principals by permission if the user had set their preferences to clear all storage on shutdown anyway. This unfortunately ended the function execution before it would call `removePendingSanitization("shutdown");` later on and thus remove the pending shutdown sanitization (which, in fact, had completed successfully earlier). The result is that the shutdown sanitization would be left dangling and run again on next startup, where, for reasons I don't fully understand, it would race and conflict with loading the home page, if that home page was from web content. The solution is to remove the pending shutdown sanitization immediately after the sanitization is done. As far as I can see there was never really a point in having it happen after session principal cleanup finished, since in case of a crash it would not run the principal cleanup again next startup, just the shutdown cleanup. For good measure I also moved the new tab container sanitization to happen earlier in this function, to prevent it from dangling as well. Differential Revision: https://phabricator.services.mozilla.com/D33087
a3f5330432615f332218aea8a704604d5e392c5c: Bug 1554744 - make button state in browser language dialog correct when there's no available languages, r=johannh a=pascalc
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Fri, 31 May 2019 13:55:56 +0000 - rev 526585
Push 2063 by archaeopteryx@coole-files.de at Fri, 07 Jun 2019 20:48:18 +0000
Bug 1554744 - make button state in browser language dialog correct when there's no available languages, r=johannh a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D33273
9bc4ce49c7bfa76b8190efd1d81a9bd7c2d2686d: Bug 1551282 and bug 1553436. Allow pages to override window.u2f but not the "sign" and "register" properties on the U2F object. r=jcj,smaug a=pascalc
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 24 May 2019 20:40:59 +0000 - rev 526584
Push 2063 by archaeopteryx@coole-files.de at Fri, 07 Jun 2019 20:48:18 +0000
Bug 1551282 and bug 1553436. Allow pages to override window.u2f but not the "sign" and "register" properties on the U2F object. r=jcj,smaug a=pascalc There are two related problems this patch is trying to address. The first, and simpler, one is bug 1553436: there are websites that use existing variables and functions named "u2f" and adding a non-replaceable readonly property with that name on Window breaks them. The fix for this is straightforward: mark the property [Replaceable]. The second problem, covered by bug 1551282, involves sites that use the Google U2F polyfill. The relevant parts of that polyfill look like this: 'use strict'; var u2f = u2f || {}; u2f.register = some_function_that_only_works_right_in_Chrome; u2f.sign = some_function_that_only_works_right_in_Chrome; The failure mode for that code before this fix is that the assignment to "u2f" throws because it's a readonly property and we're in strict mode, so any code the page concatenates in the same file after the polyfill does not get run. That's what bug 1551282 is about. The [Replaceable] annotation fixes that issue, because now the polyfill gets the value of window.u2f and then redefines the property (via the [Replaceable] setter) to be a value property with that value. So far, so good. But then we need to prevent the sets of u2f.register and u2f.sign from taking effect, because if they are allowed to happen, the actual sign/register functionality on the page will not work in Firefox. We can't just make the properties readonly, because then the sets will throw due to being in strict mode, and we still have bug 1551282. The proposed fix is to make these accessor properties with a no-op setter, which is exactly what [LenientSetter] gives us. The rest of the patch is just setting up infrastructure for generating the normal bits we would generate if "sign" and "register" were methods and using that to create the JSFunctions at the point when the getter is called. The JSFunctions then get cached on the u2f instance object. Differential Revision: https://phabricator.services.mozilla.com/D32357
8b4e5a0c99fa6c09e7ef4f9ebb157a98efee3704: Bug 1553413 - Update and harden form data filtering for privacy to account for no data being passed in. r=dao a=pascalc
Mike de Boer <mdeboer@mozilla.com> - Wed, 22 May 2019 09:46:58 +0000 - rev 526583
Push 2063 by archaeopteryx@coole-files.de at Fri, 07 Jun 2019 20:48:18 +0000
Bug 1553413 - Update and harden form data filtering for privacy to account for no data being passed in. r=dao a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D32116
5bb5e54bc396b91e6d4d16f7e9f4ca1c6f0a5118: Bug 1552275 - Fix Copy Link context menu in DevTools Inspector markup view. r=gl a=pascalc
Razvan Caliman <rcaliman@mozilla.com> - Mon, 20 May 2019 16:03:00 +0000 - rev 526582
Push 2063 by archaeopteryx@coole-files.de at Fri, 07 Jun 2019 20:48:18 +0000
Bug 1552275 - Fix Copy Link context menu in DevTools Inspector markup view. r=gl a=pascalc - Fixes the references to the correct event handler & InspectorFront after a previous mass refactoring in Bug 1529364. - Augments a test to ensure the clipboard content is correct executing the context menu action to copy a link. Differential Revision: https://phabricator.services.mozilla.com/D31765
0b7cdeda8ce9687c4bc03256551908582e629317: Bug 1552627 - pt 2, r=dveditz a=pascalc
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Mon, 20 May 2019 06:19:51 +0000 - rev 526581
Push 2063 by archaeopteryx@coole-files.de at Fri, 07 Jun 2019 20:48:18 +0000
Bug 1552627 - pt 2, r=dveditz a=pascalc Depends on D31722 Differential Revision: https://phabricator.services.mozilla.com/D31723
a33f8698b1b9f3df3a2a5f90c0728c3f93c81873: Bug 1552627 - r=dveditz a=pascalc
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Mon, 20 May 2019 06:32:46 +0000 - rev 526580
Push 2063 by archaeopteryx@coole-files.de at Fri, 07 Jun 2019 20:48:18 +0000
Bug 1552627 - r=dveditz a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D31722
dab76a57636afe71343a32f05b0cf52ff69acf4f: Bug 1548804 - Remove origin suffix isolation for proxy credentials when setting authentication cache entry, r=valentin a=pascalc
Honza Bambas <honzab.moz@firemni.cz> - Fri, 07 Jun 2019 21:33:00 +0200 - rev 526579
Push 2063 by archaeopteryx@coole-files.de at Fri, 07 Jun 2019 20:48:18 +0000
Bug 1548804 - Remove origin suffix isolation for proxy credentials when setting authentication cache entry, r=valentin a=pascalc
8f446a8038936401283b7f943b793fe91a619e10: Backed out 2 changesets (bug 1495363) for causing bug 1542912 a=pascalc
Andreea Pavel <apavel@mozilla.com> - Thu, 16 May 2019 14:43:59 +0300 - rev 526578
Push 2063 by archaeopteryx@coole-files.de at Fri, 07 Jun 2019 20:48:18 +0000
Backed out 2 changesets (bug 1495363) for causing bug 1542912 a=pascalc Backed out changeset 1d6b361c337a (bug 1495363) Backed out changeset 7973453599bb (bug 1495363)
b6a4ddbd0aabe4126fd0f10a2ad24fbbc5bfabe1: Bug 1547399 - New stub installer background for release. r=agashlin a=pascalc
Matt Howell <mhowell@mozilla.com> - Wed, 08 May 2019 21:28:29 +0000 - rev 526565
Push 2051 by archaeopteryx@coole-files.de at Tue, 28 May 2019 09:52:12 +0000
Bug 1547399 - New stub installer background for release. r=agashlin a=pascalc The new background image has a white background behind the footer text, so this patch changes the color of the footer to black. It also moves the footer text a bit lower to align with the new logo placement. Differential Revision: https://phabricator.services.mozilla.com/D30210
df853c362664989e025d1206b59c37c435186a91: Bug 1550861 - Trailhead final uplift r=k88hudson,flod,r1cky a=pascalc
Ed Lee <edilee@mozilla.com> - Wed, 22 May 2019 18:59:12 -0700 - rev 526563
Push 2049 by edilee@gmail.com at Thu, 23 May 2019 02:02:36 +0000
Bug 1550861 - Trailhead final uplift r=k88hudson,flod,r1cky a=pascalc Reviewers: k88hudson, flod, r1cky Reviewed By: k88hudson, flod, r1cky Subscribers: flod Bug #: 1550861 Differential Revision: https://phabricator.services.mozilla.com/D31877
ad5f0d47928f96a6bb998da9eb52284f63ac036e: Bug 1547830 - Ensure updated WNP is shown in the Trailhead dot release (aka 67.0.5) r=Gijs a=pascalc
Ed Lee <edilee@mozilla.com> - Wed, 22 May 2019 18:57:34 -0700 - rev 526562
Push 2049 by edilee@gmail.com at Thu, 23 May 2019 02:02:36 +0000
Bug 1547830 - Ensure updated WNP is shown in the Trailhead dot release (aka 67.0.5) r=Gijs a=pascalc Reviewers: Gijs Reviewed By: Gijs Subscribers: tomprince Bug #: 1547830 Differential Revision: https://phabricator.services.mozilla.com/D31745
2a7896ba9aa5d982abe01f859d771d411fda8101: Bug 1551455 - Reinstall distribution language packs. r=kmag a=pascalc FIREFOX_67_0_BUILD2 FIREFOX_67_0_RELEASE
Michael Kaply <mozilla@kaply.com> - Fri, 17 May 2019 00:46:16 +0300 - rev 526555
Push 2043 by ncsoregi@mozilla.com at Thu, 16 May 2019 21:52:25 +0000
Bug 1551455 - Reinstall distribution language packs. r=kmag a=pascalc Reviewers: kmag Reviewed By: kmag Subscribers: mossop Bug #: 1551455 Differential Revision: https://phabricator.services.mozilla.com/D31456
499809263177f7886716575b172501aa986a5b91: Bug 1550582 - Add wrench reftest. r=gw, a=pascalc FENNEC_67_0_BUILD1 FENNEC_67_0_RELEASE
Jamie Nicol <jnicol@mozilla.com> - Wed, 15 May 2019 10:45:25 +0000 - rev 526553
Push 2041 by jcristau@mozilla.com at Thu, 16 May 2019 17:34:45 +0000
Bug 1550582 - Add wrench reftest. r=gw, a=pascalc Rename the old overlapping corners testcase and add comments to make the tests' purposes clearer: * The existing one is testing that a corner is clipped correctly when it overlaps with an adjacent corner. * The new one is testing that corners and segments are clipped correctly when opposite edges of the border overlap. Depends on D30814 Differential Revision: https://phabricator.services.mozilla.com/D30815
5f21e6f900c825223c2c076cb7cf7f928074ed05: Bug 1550582 - Ensure the overlap is filled correctly when opposite border edges overlap. r=gw, a=pascalc
Jamie Nicol <jnicol@mozilla.com> - Wed, 15 May 2019 10:43:25 +0000 - rev 526552
Push 2041 by jcristau@mozilla.com at Thu, 16 May 2019 17:34:45 +0000
Bug 1550582 - Ensure the overlap is filled correctly when opposite border edges overlap. r=gw, a=pascalc To fix bug 1496540 it was made so that webrender clips border corner segments so that they do not overlap with their opposing edges. However, cases where opposing _edges_ both overlap with eachother (rather than just a corner overlapping with an edge), the corners are clipped too far and a gap is left in the middle. Additionally, no clipping was added to the edge segments. So rather than there be a gap there is an area that is painted twice, which is apparent if the colour is semi-transparent. This fixes these issues by identifying when opposing edges overlap and calculating the midpoint, then clipping the edges and corners to that midpoint instead. Differential Revision: https://phabricator.services.mozilla.com/D30814
fa5b6a15761ce4d81f730b756ff595eb91148376: Bug 1552156: Always set launcher pref default value to false; r=mhowell, a=pascalc
Aaron Klotz <aklotz@mozilla.com> - Thu, 16 May 2019 16:58:30 +0000 - rev 526551
Push 2041 by jcristau@mozilla.com at Thu, 16 May 2019 17:34:45 +0000
Bug 1552156: Always set launcher pref default value to false; r=mhowell, a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D31502
3126a5c2560c34a8acb33d62e54b2be0f704a190: Bug 1548795 - P2. Remove dom.performance.enable_scheduler_timing preference. r=tarek a=pascalc FIREFOX_67_0_BUILD1
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 09 May 2019 23:12:12 +0000 - rev 526544
Push 2034 by apavel@mozilla.com at Mon, 13 May 2019 19:57:29 +0000
Bug 1548795 - P2. Remove dom.performance.enable_scheduler_timing preference. r=tarek a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D30467
9faf017962724896d84b2c776454132beade33da: Bug 1548795 - P1. Don't use StaticPrefs in GPU process. r=mattwoodrow a=pascalc
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 09 May 2019 23:12:12 +0000 - rev 526543
Push 2034 by apavel@mozilla.com at Mon, 13 May 2019 19:57:29 +0000
Bug 1548795 - P1. Don't use StaticPrefs in GPU process. r=mattwoodrow a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D29984
fb5d546bb5b3c583a41225376e3e5a3674f90640: Bug 1535699 - Disable httpResponseProcessSelection on Fx67 for now. r=nika a=pascalc
Andrew Sutherland <asutherland@asutherland.org> - Mon, 13 May 2019 21:59:35 +0300 - rev 526542
Push 2033 by apavel@mozilla.com at Mon, 13 May 2019 19:02:02 +0000
Bug 1535699 - Disable httpResponseProcessSelection on Fx67 for now. r=nika a=pascalc Summary: This change also alters the test we added in bug 1535699 so that if the http process selection pref is disabled and parent intercept is not enabled, we expect the page to not migrate out of the file process. Reviewers: nika Bug #: 1535699 Differential Revision: https://phabricator.services.mozilla.com/D30685
d7e6f0c8a9db25034d5c2766b04be20e47cf4fe1: Bug 1535699 - Disable httpResponseProcessSelection on Fx67 for now. r=nika a=pascalc
Andrew Sutherland <asutherland@asutherland.org> - Sun, 12 May 2019 05:11:28 +0300 - rev 526535
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1535699 - Disable httpResponseProcessSelection on Fx67 for now. r=nika a=pascalc Reviewers: nika Bug #: 1535699 Differential Revision: https://phabricator.services.mozilla.com/D30685
f293cecba8fd77bcf3395b6e66449f48851b66fa: Bug 1539846. Ensure building rect changes cause invalidations. r=mstange a=pascalc
Jeff Muizelaar <jmuizelaar@mozilla.com> - Fri, 03 May 2019 20:46:07 +0000 - rev 526534
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1539846. Ensure building rect changes cause invalidations. r=mstange a=pascalc Typically this would be handled by the visible region of the layer changing. However, since we build the container layer for the filter item directly the visible region doesn't get set or checked. As a shortcut to using more of FLB we just ensure the building rect hasn't changed. The situations under which this bugs shows up are somewhat rare: - The filtered item needs to be in transform so that it's bounds are not changed by scrolling. - The filtered item needs to contain items that change their drawing depending on the building rect. In this case an image with downscale on decode. - The filter needs to be unsupported by WebRender. Differential Revision: https://phabricator.services.mozilla.com/D29879
9c4cd169d5d07b75453e6574e13bf4f912814fb0: Bug 1550098 - Trailhead initial uplift for Firefox 67.0 r=flod a=pascalc DEVEDITION_67_0b19_BUILD1 DEVEDITION_67_0b19_RELEASE FIREFOX_67_0b19_BUILD1 FIREFOX_67_0b19_RELEASE
Ed Lee <edilee@mozilla.com> - Thu, 09 May 2019 21:40:22 +0300 - rev 526524
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1550098 - Trailhead initial uplift for Firefox 67.0 r=flod a=pascalc Reviewers: r1cky, flod Reviewed By: r1cky, flod Subscribers: pascalc, Mardak, flod Tags: #secure-revision, #bmo-mozilla-employee-confidential Bug #: 1550098 Differential Revision: https://phabricator.services.mozilla.com/D30451
306b6635505681131acd230eb8685d2c4c54311c: Bug 1548042 - Special FxA Snippet on New Tab for Firefox 67. r=mardak a=pascalc
Ricky Rosario <rickyrosario@gmail.com> - Thu, 09 May 2019 21:35:24 +0300 - rev 526523
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1548042 - Special FxA Snippet on New Tab for Firefox 67. r=mardak a=pascalc Reviewers: Mardak Reviewed By: Mardak Subscribers: flod Bug #: 1548042 Differential Revision: https://phabricator.services.mozilla.com/D30184
432e429f9663a23a3be48459cc0f0fe8324d4722: Bug 1548959: enable media_codec_used in release r=bryce a=pascalc
Nils Ohlmeier [:drno] <drno@ohlmeier.org> - Tue, 07 May 2019 17:08:46 +0000 - rev 526522
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1548959: enable media_codec_used in release r=bryce a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D29915
6124d4a75c1fc532f9240cfc1c70f83d293ce9e1: Bug 1541317 fix extension failures when setting homepage on upgrade r=aswan a=pascalc
Shane Caraveo <scaraveo@mozilla.com> - Wed, 08 May 2019 01:30:25 +0000 - rev 526521
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1541317 fix extension failures when setting homepage on upgrade r=aswan a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D29912
b620b8ee82853fa4ec7d25d27d7f347f42e87021: Bug 1549833, r=valentin, a=pascalc
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Tue, 07 May 2019 23:23:30 +0100 - rev 526520
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1549833, r=valentin, a=pascalc Differential Revision: https://phabricator.services.mozilla.com//D30285
79e9a8ef0735ae3a27531a09a54bc3b2771766a6: Bug 1548410 - Disable DXVA on Qualcomm WoA drivers. r=mattwoodrow a=pascalc
Chris Pearce <cpearce@mozilla.com> - Thu, 02 May 2019 02:42:31 +0000 - rev 526513
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1548410 - Disable DXVA on Qualcomm WoA drivers. r=mattwoodrow a=pascalc This driver version is known to have busg which cause the output of green frames from the decoder, and to cause BSODs. Differential Revision: https://phabricator.services.mozilla.com/D29603
70403bae88b8486cd20c74c693ad85f79a030a00: Bug 1546544 - Enable TCSM. r=mccr8,asuth,spohl a=pascalc
Haik Aftandilian <haftandilian@mozilla.com> - Tue, 30 Apr 2019 14:01:20 -0700 - rev 526502
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1546544 - Enable TCSM. r=mccr8,asuth,spohl a=pascalc
0deba92b39fd52160009e0296dd096c18f33830f: Bug 1548626 - Delay showing the Privacy-UI onboarding by 30 min for new users. r=johannh a=pascalc
Erica Wright <ewright@mozilla.com> - Mon, 06 May 2019 00:37:05 +0000 - rev 526501
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1548626 - Delay showing the Privacy-UI onboarding by 30 min for new users. r=johannh a=pascalc Wait 30 min after a new profile is created before showing the onbording. Differential Revision: https://phabricator.services.mozilla.com/D29762
d6c5478f35e9cc7d184772959017bef94854f72f: Bug 1548000 - Default browser triggers "Default apps" screen; r=VladBaicu a=pascalc
Andrei Teslovan <andrei.teslovan@softvision.ro> - Sat, 04 May 2019 02:32:24 +0300 - rev 526484
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1548000 - Default browser triggers "Default apps" screen; r=VladBaicu a=pascalc
dbd28ea2e13c17d9566a8a95370b87a6d3341e71: Bug 1544792 - Abort on try-catch blocks when doing definite properties analysis. r=nbp, a=pascalc
Jan de Mooij <jdemooij@mozilla.com> - Thu, 02 May 2019 17:51:24 +0000 - rev 526482
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1544792 - Abort on try-catch blocks when doing definite properties analysis. r=nbp, a=pascalc Ion does not compile the catch block so the analysis fails to account for code there. Differential Revision: https://phabricator.services.mozilla.com/D29475
76d84e7aeb3ffc34d0d52cc4adc89bd6ddd0c2e7: Bug 1539393 - TransactionDatabaseOperationBase::ActorDestroy doesn't check if we are waiting for the Continue message; r=asuth, a=pascalc
Jan Varga <jan.varga@gmail.com> - Sat, 13 Apr 2019 16:52:29 +0200 - rev 526481
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1539393 - TransactionDatabaseOperationBase::ActorDestroy doesn't check if we are waiting for the Continue message; r=asuth, a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D27429
bb9c48a4e71aa927d148b7e91dfda6417c507c13: Bug 1522817 - Always expose returned target object of wrapper r=sfink a=pascalc DEVEDITION_67_0b16_BUILD2 DEVEDITION_67_0b16_RELEASE FENNEC_67_0b16_BUILD2 FENNEC_67_0b16_RELEASE FIREFOX_67_0b16_BUILD2 FIREFOX_67_0b16_RELEASE
Jon Coppeard <jcoppeard@mozilla.com> - Mon, 29 Apr 2019 16:06:09 +0100 - rev 526467
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1522817 - Always expose returned target object of wrapper r=sfink a=pascalc The comment here talks about unmarking wrapper targets in case we're in incremental GC, but it does it conditially based on the color of the wrapper. We can't depend on that because a wrapper marked gray may eventually be marked black. Also, I don't think we should be touching gray wrappers anyway. Let's just always expose here. Differential Revision: https://phabricator.services.mozilla.com/D29211
cdf167f4186a12d4e5cf34655dfd201da159f0cd: Bug 1522817 - Expose possibly-gray global object before passing it into the JS API in Document::AdoptNode r=bzbarsky a=pascalc DEVEDITION_67_0b16_BUILD1 FENNEC_67_0b16_BUILD1 FIREFOX_67_0b16_BUILD1
Jon Coppeard <jcoppeard@mozilla.com> - Mon, 29 Apr 2019 16:06:08 +0100 - rev 526466
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1522817 - Expose possibly-gray global object before passing it into the JS API in Document::AdoptNode r=bzbarsky a=pascalc Currently Document::AdoptNode gets the JS global object, but in a way that does not expose it first, so it's possible for this to pass a gray object in here. From the comments it seems like this doesn't matter, but it does break our invariant that no gray objects are passed into the API. Differential Revision: https://phabricator.services.mozilla.com/D29210
e9cc7e9d9c734497f3e9c226cbda678871ebbe06: Bug 1539959 - Ensure origin process is subscribed when attaching remote BC, r=farre a=pascalc
Nika Layzell <nika@thelayzells.com> - Thu, 02 May 2019 08:50:12 +0000 - rev 526465
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1539959 - Ensure origin process is subscribed when attaching remote BC, r=farre a=pascalc We were incorrectly not performing an EnsureSubscribed for the origin process which a BrowsingContext came from. Normally this would mean that the BrowsingContext could die in the parent process before the WindowGlobalParent listener arrived, but that didn't generally happen due to the low likelihood of a CC occuring between the two messages. It's likely that this crash was caused by people on lower-end hardware triggering a print. This would be a longer-running operation in the content process between the first and second message than usual. On systems with memory pressure, there would be a higher chance of a CC occuring between the messages, which would then cause this crash. This patch correctly connects the origin ContentParent to the BrowsingContextGroup, which will prevent the CC from destroying our objects. In the future, it may be desirable to ensure that this doesn't happen more reliably by using a ContentParent-local table for looking up BrowsingContext IDs sent over IPC. This would prevent our current dependency on the weak pointer behaviour of the current global ID cache. Unfortunately, this patch adds no tests, and I'm not aware of a good way to test this edge case to confirm it has been fixed. I believe that this patch should fix the issue I mention, however. Differential Revision: https://phabricator.services.mozilla.com/D29563
89ab6b801db05cfcbdb94e9376d3db952ada4011: Bug 1535699 - Propagate redirect mode across cross-process redirects. r=asuth a=pascalc
Perry Jiang <perry@mozilla.com> - Thu, 02 May 2019 10:03:00 -0700 - rev 526464
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1535699 - Propagate redirect mode across cross-process redirects. r=asuth a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D29719
ce52ad329dab177d22c3cfdad819e54261d9d343: Bug 1529892 - Limit the area of a fixed-position element that's painted to the displayport. r=kats a=pascalc
Botond Ballo <botond@mozilla.com> - Fri, 26 Apr 2019 05:12:33 +0000 - rev 526463
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529892 - Limit the area of a fixed-position element that's painted to the displayport. r=kats a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D28775
11d3470f983ebc901d3fb15fb0cc779951f4221b: Bug 1545593 - Enable tab unloading in low-memory scenarios unconditionally r=mconley a=pascalc
Gabriele Svelto <gsvelto@mozilla.com> - Wed, 01 May 2019 20:02:38 +0000 - rev 526462
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1545593 - Enable tab unloading in low-memory scenarios unconditionally r=mconley a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D28146
224c70ce5efff2b014309e448dcc43a759e43441: Bug 1539208 - Propagate the result of mListener in InterceptedHttpChannel::OnStartRequest and ::OnStopRequest r=perry,ttung,kershaw a=pascalc
Eden Chuang <echuang@mozilla.com> - Wed, 24 Apr 2019 08:49:36 +0000 - rev 526461
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1539208 - Propagate the result of mListener in InterceptedHttpChannel::OnStartRequest and ::OnStopRequest r=perry,ttung,kershaw a=pascalc 1. Propagate the mListener's result in InterceptedHttpChannel::OnStartRequest() and ::OnStopRequest(). 2. remove unnecessary assertion in FetchDriver::OnStartRequest(). Differential Revision: https://phabricator.services.mozilla.com/D28477
7f749a11b5cf2fa0ffa9ed03084f9201d94f5d95: Bug 1541489 - Don't turn on WR on 100% of qualified users at the start of release 67. r=jrmuizel a=pascalc
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 08 Mar 2019 15:15:47 -0500 - rev 526460
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1541489 - Don't turn on WR on 100% of qualified users at the start of release 67. r=jrmuizel a=pascalc We'll use Normandy to deploy this gradually in 67.
e3264123c6a279b73e385836ba5013e02e9d5d78: Bug 1543641 - Part 3: Remove special-casing for Etc/UCT. r=jwalden a=pascalc
André Bargull <andre.bargull@gmail.com> - Fri, 12 Apr 2019 13:54:56 +0200 - rev 526453
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1543641 - Part 3: Remove special-casing for Etc/UCT. r=jwalden a=pascalc Etc/UCT resp. UCT is a link to Etc/UTC starting with tzdata 2019a. Differential Revision: https://phabricator.services.mozilla.com//D27344 Depends on D27343
1b1ad8962c6f91350aeaf2303237a7cbbdfbce8a: Bug 1543641 - Part 2: Update tzdata in ICU data files to 2019a. r=jwalden a=pascalc
André Bargull <andre.bargull@gmail.com> - Fri, 12 Apr 2019 11:54:31 +0200 - rev 526452
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1543641 - Part 2: Update tzdata in ICU data files to 2019a. r=jwalden a=pascalc Differential Revision: https://phabricator.services.mozilla.com//D27343 Depends on D27342
c62cd84953ed0ac1fe941af59ed2a8cabdf4f622: Bug 1543641 - Part 1: Update in-tree ICU to release 63.2. r=jwalden a=pascalc
André Bargull <andre.bargull@gmail.com> - Fri, 12 Apr 2019 11:48:52 +0200 - rev 526451
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1543641 - Part 1: Update in-tree ICU to release 63.2. r=jwalden a=pascalc Differential Revision: https://phabricator.services.mozilla.com//D27342