searching for reviewer(padenot)
dab7fc014ffe5ad54f6020788cfdcc088e72ac0b: Bug 1651049 - Mochitest to verify the failed scenario. r=padenot, a=RyanVM
Alex Chronopoulos <achronop@gmail.com> - Thu, 09 Jul 2020 14:32:21 +0000 - rev 605714
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1651049 - Mochitest to verify the failed scenario. r=padenot, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D82865
06308497afccf792c9e6c78a7c5986603eeb6505: Bug 1651049 - Move the sink change logic in MediaStreamRenderer. r=padenot, a=RyanVM
Alex Chronopoulos <achronop@gmail.com> - Thu, 09 Jul 2020 14:32:21 +0000 - rev 605713
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1651049 - Move the sink change logic in MediaStreamRenderer. r=padenot, a=RyanVM The MediaStreamRenderer handles the AudioOutput of an HTMLMediaElement. it register/unregister the AudioOutput according to the rendering status. The sink-change follows the logic of AudioOutput thus it has been moved in it. The previous way created an error when the element had been muted and the sink had been changed before the source MediaStream was attached to the element. The error occured because it was possible, the same entry to be registered more than once in the AudioOutput's list, which resulted in the track to be unmuted when it should not. Differential Revision: https://phabricator.services.mozilla.com/D82529
e621b9981d60e3cd1121fa60c2783156ff13caa4: Bug 1650030 - Backed out 3 changesets (bug 1618225) for webcompat regression. r=padenot, a=jcristau
Corentin Arnould <koalab1999@gmail.com> - Fri, 03 Jul 2020 14:27:59 +0000 - rev 605578
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1650030 - Backed out 3 changesets (bug 1618225) for webcompat regression. r=padenot, a=jcristau Backed out changeset feff7b5ed5b1 (bug 1618225) Backed out changeset 99ac03bfe9ce (bug 1618225) Backed out changeset f74c10d88304 (bug 1618225) Differential Revision: https://phabricator.services.mozilla.com/D82197
fb32455755788547fb6e9c47b4b936f90c01ece3: Bug 1513745 - Wait for input audio to arrive before start recording it. r=padenot
Alex Chronopoulos <achronop@gmail.com> - Thu, 25 Jun 2020 15:10:49 +0000 - rev 605175
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1513745 - Wait for input audio to arrive before start recording it. r=padenot The error indicates that test timeouts because there is no audio in the output. As a workaround the the test will wait for audio in the input and then will start recording and checking the output. Differential Revision: https://phabricator.services.mozilla.com/D81116
13355da57aba495ec1f52a86116da6b9a7356471: Bug 1647750 error out when AudioWorkletProcessor#process() detaches output Float32Array r=padenot
Karl Tomlinson <karlt+@karlt.net> - Thu, 25 Jun 2020 02:09:39 +0000 - rev 605041
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1647750 error out when AudioWorkletProcessor#process() detaches output Float32Array r=padenot Differential Revision: https://phabricator.services.mozilla.com/D80804
48b4525f370779e4aee3291ba40a5875a132ed19: Bug 1647750 use MakeScopeExit() to avoid repetition of error paths r=padenot
Karl Tomlinson <karlt+@karlt.net> - Wed, 24 Jun 2020 09:29:38 +0000 - rev 605040
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1647750 use MakeScopeExit() to avoid repetition of error paths r=padenot Differential Revision: https://phabricator.services.mozilla.com/D80803
feff7b5ed5b18b761f9e01e12a886d4c6a45c8a4: Bug 1618225 - Added wpt test for loop with duration r=padenot
Corentin Arnould <koalab1999@gmail.com> - Wed, 24 Jun 2020 12:00:18 +0000 - rev 604839
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1618225 - Added wpt test for loop with duration r=padenot Silenced the mochitest Differential Revision: https://phabricator.services.mozilla.com/D79875
99ac03bfe9ce6e913ae3fa55fb8ce54ef98fbc15: Bug 1618225 - Updated mochitest for loop with duration r=padenot
Corentin Arnould <koalab1999@gmail.com> - Wed, 24 Jun 2020 12:00:11 +0000 - rev 604838
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1618225 - Updated mochitest for loop with duration r=padenot Differential Revision: https://phabricator.services.mozilla.com/D79874
f74c10d883047b1fe6d072d1cd93bc464beb98e4: Bug 1618225 - Set stop time when using loop with duration. r=padenot
Corentin Arnould <koalab1999@gmail.com> - Wed, 24 Jun 2020 11:59:53 +0000 - rev 604837
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1618225 - Set stop time when using loop with duration. r=padenot The AudioBufferSourceNode can now be looping and stop after duration. Differential Revision: https://phabricator.services.mozilla.com/D79873
9ad8f66fbc7c59b3b70426fa57e1fb1176f6366c: Bug 1493990 - Enable sink change in the srcObject of HTMLMediaElement. r=padenot
Alex Chronopoulos <achronop@gmail.com> - Thu, 18 Jun 2020 14:05:28 +0000 - rev 604300
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1493990 - Enable sink change in the srcObject of HTMLMediaElement. r=padenot The SetSinkId method of HTMLMediaElement has been enhanced to handle the sink change when the element is sourced with a MediaObject through the srcObject attribute. It makes use in the corresponding method of AudioStreamTrack taking into account the AudioOutput and Volume that has to be removed and re-added to the right track. Differential Revision: https://phabricator.services.mozilla.com/D77809
49c83d2045f1f63b6558c83b095acdbb6940e329: Bug 1493990 - Enhance AudioStreamTrack to set output device and handle the connection between different graphs. r=padenot
Alex Chronopoulos <achronop@gmail.com> - Fri, 12 Jun 2020 14:03:30 +0000 - rev 604299
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1493990 - Enhance AudioStreamTrack to set output device and handle the connection between different graphs. r=padenot A new method has been added in AudioStreamTrack to allow the change of the output device. Also, the methods that add/remove the AudioOutput or Volume have been enhanced to use the CrossGraphManager, when available, in order to set the AudioOutput or volume to the correct MediaTrack. Differential Revision: https://phabricator.services.mozilla.com/D77808
8d4faaf6604cb161eaecc1e63ea00d8ec813ec91: Bug 1493990 - Create two new MediaTrack able to transfer the audio data between different threads. r=padenot.
Alex Chronopoulos <achronop@gmail.com> - Thu, 18 Jun 2020 13:58:06 +0000 - rev 604298
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1493990 - Create two new MediaTrack able to transfer the audio data between different threads. r=padenot. The name of the two new tracks is CrossGraphTransmitter and CrossGraphReceiver. They are used together to transfer the audio data of the transmitter to the receiver which belongs to different MTG. In addition to that a CrossGraphManager class has been created that creates the connection between the transmitter and the receiver and can redirect to the correct track some operations like the volume change etc. Differential Revision: https://phabricator.services.mozilla.com/D77807
b912f803b3a8659c05f9eed03b0776ff9ae1f52b: Bug 1615130 - Fix uninitialized data. r=padenot
Corentin Arnould <koalab1999@gmail.com> - Mon, 22 Jun 2020 10:21:40 +0000 - rev 604281
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1615130 - Fix uninitialized data. r=padenot Values are set to 0 by default rather than uninitialized. It is useful when JSContext is null. Differential Revision: https://phabricator.services.mozilla.com/D79986
b9704b943052b901c9fd614a5364dc52e77808a6: Bug 1642849 shut down MediaTrackGraph from AudioContext when window will be destroyed r=padenot
Karl Tomlinson <karlt+@karlt.net> - Fri, 12 Jun 2020 03:53:34 +0000 - rev 603320
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1642849 shut down MediaTrackGraph from AudioContext when window will be destroyed r=padenot Differential Revision: https://phabricator.services.mozilla.com/D74814
7c5fe3b1bec50930f1a30fefdf44b597282f5038: Bug 1644647 reject promises for Close AudioContextOperations run after forced graph shutdown r=padenot
Karl Tomlinson <karlt+@karlt.net> - Fri, 12 Jun 2020 02:38:35 +0000 - rev 603017
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1644647 reject promises for Close AudioContextOperations run after forced graph shutdown r=padenot and re-enable OnStateChanged() transition assertions. Rejecting the promise avoids having AudioContextOperation promises resolve out of order when AudioContextOperationControlMessage::RunDuringShutdown() resolves a Close operation shortly after Run() for a previous operation has queued its update via mUpdateRunnables. mUpdateRunnables are run after controlMessagesToRunDuringShutdown. https://searchfox.org/mozilla-central/rev/ea7f70dac1c5fd18400f6d2a92679777d4b21492/dom/media/MediaTrackGraph.cpp#1793,1803 AudioContext::Shutdown() takes care of rejecting JS Promises when the window is being destroyed. Differential Revision: https://phabricator.services.mozilla.com/D79055
cbbe8b775137d7321ed0128455694c67e55a7e2f: Bug 1644647 test AudioContext state updates with suspend() shortly after construction r=padenot
Karl Tomlinson <karlt+@karlt.net> - Fri, 12 Jun 2020 02:38:35 +0000 - rev 603016
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1644647 test AudioContext state updates with suspend() shortly after construction r=padenot Differential Revision: https://phabricator.services.mozilla.com/D79057
de7e71fc0ea930e80c605198676a0295c3c962a0: Bug 1644647 - remove waits for suspend and resume completion added to workaround bug 1198386 r=padenot
Karl Tomlinson <karlt+@karlt.net> - Fri, 12 Jun 2020 02:38:08 +0000 - rev 603015
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1644647 - remove waits for suspend and resume completion added to workaround bug 1198386 r=padenot Differential Revision: https://phabricator.services.mozilla.com/D76808
121dfca01d6a2f42b05c4ddebc6d409da35d7715: Bug 1638243 reject promises for Resume AudioContextOperations that have not run by graph shutdown r=padenot
Karl Tomlinson <karlt+@karlt.net> - Fri, 12 Jun 2020 01:12:56 +0000 - rev 602981
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1638243 reject promises for Resume AudioContextOperations that have not run by graph shutdown r=padenot The promises are rejected before shutting down threads so that they don't need to wait for nested event loops to exit. Differential Revision: https://phabricator.services.mozilla.com/D76807
6316b2fbd3b9c27d6a975a18c35dce4912c33ef9: Bug 1644647 rewrite AudioContextOperation handling using PendingResumeOperation r=padenot
Karl Tomlinson <karlt+@karlt.net> - Thu, 11 Jun 2020 08:52:00 +0000 - rev 602980
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1644647 rewrite AudioContextOperation handling using PendingResumeOperation r=padenot The key change here is that AudioContextOperation promises for the same AudioContext are resolved in order as long as the graph is running. There is one remaining case where AudioContextOperation promises can be resolved out of order, which is when AudioContextOperationControlMessage::RunDuringShutdown() resolves a Close operation shortly after Run() has queued its update via mUpdateRunnables. mUpdateRunnables are run after controlMessagesToRunDuringShutdown. https://searchfox.org/mozilla-central/rev/ea7f70dac1c5fd18400f6d2a92679777d4b21492/dom/media/MediaTrackGraph.cpp#1793,1803 Pending resume operations are now stored on the graph instead of on mNextDriver. This means there is no need to move operations between drivers when switching from one mNextDriver to another, the code for which was previously missing. Suspend operations are performed immediately, because even a callback driver can render nothing. Tracks are not resumed until either there is an AudioCallbackDriver to deliver the rendered audio or the Resume operation is canceled by a subsequent Suspend. While the graph is running, DispatchToMainThreadStableState() is used consistently, whereas previously this was mixed with direct Dispatch() to the main thread, which could have the runnable Run() before main thread state had been updated for rendering up to the time of a Suspend. Differential Revision: https://phabricator.services.mozilla.com/D76806
ce7f146ddc9f1920c3409722a37250e73e6bde62: Bug 1644647 - introduce PendingResumeOperation r=padenot
Karl Tomlinson <karlt+@karlt.net> - Fri, 12 Jun 2020 02:17:33 +0000 - rev 602979
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1644647 - introduce PendingResumeOperation r=padenot Differential Revision: https://phabricator.services.mozilla.com/D76805
0edf554a7996be273c81f0be33e060169739a26f: Bug 1644647 test that processing is consistent whether nodes are created before or after resume r=padenot
Karl Tomlinson <karlt+@karlt.net> - Thu, 11 Jun 2020 08:45:07 +0000 - rev 602978
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1644647 test that processing is consistent whether nodes are created before or after resume r=padenot Depends on D79049 Differential Revision: https://phabricator.services.mozilla.com/D79050
fdcd2a267d7572adefe4d305cad78744997f424e: Bug 1644647 use AudioContextOperation::Resume to start realtime AudioNodeTracks r=padenot
Karl Tomlinson <karlt+@karlt.net> - Fri, 12 Jun 2020 00:50:34 +0000 - rev 602977
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1644647 use AudioContextOperation::Resume to start realtime AudioNodeTracks r=padenot This provides that a new track does not start processing before existing tracks in the AudioContext, which may not be resumed until an AudioCallbackDriver is running. Depends on D79048 Differential Revision: https://phabricator.services.mozilla.com/D79049
71426ce4b138cd7f18f621c7fe2cb2e473ea3e90: Bug 1644647 use the same mechanism for the first suspended->running transition as for others r=padenot
Karl Tomlinson <karlt+@karlt.net> - Thu, 11 Jun 2020 08:51:17 +0000 - rev 602976
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1644647 use the same mechanism for the first suspended->running transition as for others r=padenot Differential Revision: https://phabricator.services.mozilla.com/D79048
680987aac53030c97ebb49038622ba9a63f3e3ef: Bug 1644647 explicitly initialize mFallbackDriverState r=padenot
Karl Tomlinson <karlt+@karlt.net> - Fri, 12 Jun 2020 01:02:18 +0000 - rev 602964
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1644647 explicitly initialize mFallbackDriverState r=padenot There is no change in behavior here because the default constructor is zero initialized https://searchfox.org/mozilla-central/rev/bc3600def806859c31b2c7ac06e3d69271052a89/mfbt/Atomics.h#287 and None is zero. https://searchfox.org/mozilla-central/rev/bc3600def806859c31b2c7ac06e3d69271052a89/dom/media/GraphDriver.h#763 Differential Revision: https://phabricator.services.mozilla.com/D79043
39f13a31bf2e0f98c4528d4e136e6c135b623c0c: Bug 1644647 - Bug 1285290 use strong pointers for tracks in ApplyAudioContextOperation() r=padenot
Karl Tomlinson <karlt+@karlt.net> - Fri, 12 Jun 2020 01:02:18 +0000 - rev 602963
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1644647 - Bug 1285290 use strong pointers for tracks in ApplyAudioContextOperation() r=padenot This will be helpful when delaying resumption of tracks until there is an AudioCallbackDriver. The memory for the array is also transferred to the callee to save an allocation. Differential Revision: https://phabricator.services.mozilla.com/D76801
ae4c0f78918988807c491e37bd329edcafc906ff: Bug 1644524 - Fix a gtest to assert the initial state sooner. r=padenot
Alex Chronopoulos <achronop@gmail.com> - Thu, 11 Jun 2020 13:21:09 +0000 - rev 602839
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1644524 - Fix a gtest to assert the initial state sooner. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D79078
ca9609185b3544ea0a59a53b6439b5886c8aabe7: Bug 1644080 - mach vendor rust. r=cubeb-reviewers,padenot
Corentin Arnould <koalab1999@gmail.com> - Mon, 08 Jun 2020 13:14:26 +0000 - rev 602137
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1644080 - mach vendor rust. r=cubeb-reviewers,padenot Depends on D78664 Differential Revision: https://phabricator.services.mozilla.com/D78665
b5e1e29b51728771671934114c789ab37dc8416c: Bug 1644080 - Updated cubeb-pulse-rs r=cubeb-reviewers,padenot
Corentin Arnould <koalab1999@gmail.com> - Mon, 08 Jun 2020 13:14:18 +0000 - rev 602136
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1644080 - Updated cubeb-pulse-rs r=cubeb-reviewers,padenot Depends on D78663 Differential Revision: https://phabricator.services.mozilla.com/D78664
f837ca09ae36bd09f924b98e9b35e831615ddd1c: Bug 1644080 - Updated cubeb-coreaudio-rs repository r=cubeb-reviewers,padenot
Corentin Arnould <koalab1999@gmail.com> - Mon, 08 Jun 2020 13:14:16 +0000 - rev 602135
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1644080 - Updated cubeb-coreaudio-rs repository r=cubeb-reviewers,padenot Differential Revision: https://phabricator.services.mozilla.com/D78663
c990c7ac488d331554ce5aec5915066d843b5246: Bug 1641461 generalize tolerances for convolver channelCountMode tests r=padenot
Karl Tomlinson <karlt+@karlt.net> - Wed, 03 Jun 2020 12:52:33 +0000 - rev 601574
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1641461 generalize tolerances for convolver channelCountMode tests r=padenot This is essentially a merge of https://github.com/web-platform-tests/wpt/pull/11935 with https://github.com/web-platform-tests/wpt/pull/21493. For downMixTest() in convolver-response-1-chan.html, channelCount is 2 and so channelCountMode: 'explicit' results are expected to match default 'clamped-max' results when the number of input channels is >= 2. Coefficients for down-mixing 5.1 mean the maximum expected amplitude differs between mono and stereo output as in convolver-response-2-chan.html. Depends on D77969 Differential Revision: https://phabricator.services.mozilla.com/D77970
4676aa29469d2adc402206de415f4748427e78ee: Bug 1641461 use stereoResponseExplicitTest() for all 2-response convolver explicit channelCountMode tests r=padenot
Karl Tomlinson <karlt+@karlt.net> - Wed, 03 Jun 2020 12:52:41 +0000 - rev 601573
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1641461 use stereoResponseExplicitTest() for all 2-response convolver explicit channelCountMode tests r=padenot and adjust description to match the downmixing to mono before convolution. The previous use of stereoResponseTest(), which downmixed to stereo, for 5.1 only was inconsistent with other layouts and provides little additional testing over the clamped-max test, which behaves the same for stereo ConvolverNode input. Differential Revision: https://phabricator.services.mozilla.com/D77969
06a51605468f3591b3c43cdcaaf4754946f59270: Bug 1641605 - Install SIGXCPU handler even if sandbox is disabled. r=padenot
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 03 Jun 2020 12:18:56 +0000 - rev 601448
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1641605 - Install SIGXCPU handler even if sandbox is disabled. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D78019
e650aaef268c09419ada9611bec4b985f5b21841: Bug 1636051 - Synchronize a member of MockCubeb that is touched from different thread. r=padenot
Alex Chronopoulos <achronop@gmail.com> - Tue, 02 Jun 2020 14:05:35 +0000 - rev 601262
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1636051 - Synchronize a member of MockCubeb that is touched from different thread. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D77796
1f0a68ae0e283985314adc06a75ae0212e5b74a0: Bug 1642542 - Make DebugOnly a variable used for checking an assert. r=padenot
Alex Chronopoulos <achronop@gmail.com> - Tue, 02 Jun 2020 12:07:02 +0000 - rev 601240
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1642542 - Make DebugOnly a variable used for checking an assert. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D77783
d7cb9605163714b3c9a035116d9a5b1aeb4fda20: Bug 1637235 - Implement the audio drift correction. r=padenot
Alex Chronopoulos <achronop@gmail.com> - Mon, 01 Jun 2020 15:53:43 +0000 - rev 601096
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1637235 - Implement the audio drift correction. r=padenot Implement the drift correction logic that counts the frames between a source and a target (the master clock) and adjust the source buffer in order to compensate for the drift between source and target. Differential Revision: https://phabricator.services.mozilla.com/D74884
ddc8b742c893ea1de9700e49596f3ec5b72b608c: Bug 1637235 - Implement a dynamic resampler with preallocated input and output memory. r=padenot
Alex Chronopoulos <achronop@gmail.com> - Mon, 01 Jun 2020 15:53:30 +0000 - rev 601095
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1637235 - Implement a dynamic resampler with preallocated input and output memory. r=padenot Create a dynamic resampler that will be able to preallocate its internal buffers and provide the exact requested amount of data in the output. The resampler makes use of the AudioSegment data structure to convey the audio frames to make it easier to be used from MTG. Differential Revision: https://phabricator.services.mozilla.com/D74883
7600c1bbd621e9ba857d419706b11e8b8ecbdfa0: Bug 1637235 - Implement a ring buffer for audio data. r=padenot,jya
Alex Chronopoulos <achronop@gmail.com> - Mon, 01 Jun 2020 15:53:18 +0000 - rev 601094
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1637235 - Implement a ring buffer for audio data. r=padenot,jya Implement a ring buffer that is not thread-safe and preallocate its internal buffers. The intention is that the internal data is preallocate to any thread and then read/write operations will take place in a single thread using the memory in a ring manner. Differential Revision: https://phabricator.services.mozilla.com/D74882
705f2d35af32cb12bdc2e2ea1a32751d460c7887: Bug 1637235 - Implement the audio drift correction. r=padenot
Alex Chronopoulos <achronop@gmail.com> - Mon, 01 Jun 2020 12:27:04 +0000 - rev 600960
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1637235 - Implement the audio drift correction. r=padenot Implement the drift correction logic that counts the frames between a source and a target (the master clock) and adjust the source buffer in order to compensate for the drift between source and target. Differential Revision: https://phabricator.services.mozilla.com/D74884
d32ea183ab01eafe02e95286f3ccf8400bc6c617: Bug 1637235 - Implement a dynamic resampler with preallocated input and output memory. r=padenot
Alex Chronopoulos <achronop@gmail.com> - Mon, 01 Jun 2020 12:27:02 +0000 - rev 600959
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1637235 - Implement a dynamic resampler with preallocated input and output memory. r=padenot Create a dynamic resampler that will be able to preallocate its internal buffers and provide the exact requested amount of data in the output. The resampler makes use of the AudioSegment data structure to convey the audio frames to make it easier to be used from MTG. Differential Revision: https://phabricator.services.mozilla.com/D74883
81012bc3b3ac59a2ed490dfed1c51b053bed3601: Bug 1637235 - Implement a ring buffer for audio data. r=padenot,jya
Alex Chronopoulos <achronop@gmail.com> - Mon, 01 Jun 2020 12:27:00 +0000 - rev 600958
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1637235 - Implement a ring buffer for audio data. r=padenot,jya Implement a ring buffer that is not thread-safe and preallocate its internal buffers. The intention is that the internal data is preallocate to any thread and then read/write operations will take place in a single thread using the memory in a ring manner. Differential Revision: https://phabricator.services.mozilla.com/D74882
01f96c18970fdeb4b789dd2f215108381541bd90: Bug 1636515 - Handle cycle in media element when it is fed with the captured stream. r=padenot
Alex Chronopoulos <achronop@gmail.com> - Thu, 28 May 2020 13:07:53 +0000 - rev 600224
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1636515 - Handle cycle in media element when it is fed with the captured stream. r=padenot Feeding a media element with the captured stream from the same media element does not make sense. Currently the spec does not mention anything about it. I'll clarify the case in the spec. In the meantime, when a cycle is detected, the setting of the `srcObject` is ignored and a warning is produced in the console. Differential Revision: https://phabricator.services.mozilla.com/D76821
a1dd9afbfdf5deddd0a6b2f1a76d9f83dc0bb66a: Bug 1641161 - Bug 1285290 Document suspend/resume accounting wrt ApplyAudioContextOperation() r=padenot
Karl Tomlinson <karlt+@karlt.net> - Wed, 27 May 2020 08:39:48 +0000 - rev 599717
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1641161 - Bug 1285290 Document suspend/resume accounting wrt ApplyAudioContextOperation() r=padenot Depends on D76803 Differential Revision: https://phabricator.services.mozilla.com/D76804
1823eb201ef68f7f4ba6f250c6449de53230f3f5: Bug 1285290 move code to choose the next GraphDriver to CheckDriver() r=padenot
Karl Tomlinson <karlt+@karlt.net> - Wed, 27 May 2020 10:27:20 +0000 - rev 599716
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1285290 move code to choose the next GraphDriver to CheckDriver() r=padenot There is a small logic change here when !audioTrackPresent && audioCallbackDriver && !IsStarted() && graphOutputChannelCount != audioCallbackDriver->OutputChannelCount() Now, no driver change is scheduled in that situation. Differential Revision: https://phabricator.services.mozilla.com/D76803
806573d7d69a90ea111a3b235f5fa1f45bd70b4f: Bug 1641161 remove some graph-thread LIFECYCLE_RUNNING conditions r=padenot
Karl Tomlinson <karlt+@karlt.net> - Wed, 27 May 2020 08:41:12 +0000 - rev 599715
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1641161 remove some graph-thread LIFECYCLE_RUNNING conditions r=padenot On the graph thread, mLifecycleState is known to be LIFECYCLE_RUNNING. OpenAudioInputImpl(), CloseAudioInputImpl(), AddAudioOutputImpl() are called only from ControlMessage::Run(), not RunDuringShutdown(). These conditions were first added in https://hg.mozilla.org/mozilla-central/rev/dcd375e2750d425af210fee36962219a97a334fd#l3.12 but I don't know why. Differential Revision: https://phabricator.services.mozilla.com/D76802
7bae1eadb123675a0b56815f8fe20002fc8f39cb: Bug 1641161 - Bug 1285290 alias move() to std::move() in MediaTrackGraph.cpp and AudioContext.cpp r=padenot
Karl Tomlinson <karlt+@karlt.net> - Wed, 27 May 2020 08:36:18 +0000 - rev 599714
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1641161 - Bug 1285290 alias move() to std::move() in MediaTrackGraph.cpp and AudioContext.cpp r=padenot Depends on D76799 Differential Revision: https://phabricator.services.mozilla.com/D76800
c17adfdc55cd8725c7187599cf93d439e1b7d764: Bug 1641161 - Bug 1285290 move AudioContextOperationControlMessage out of function scope r=padenot
Karl Tomlinson <karlt+@karlt.net> - Wed, 27 May 2020 08:45:01 +0000 - rev 599713
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1641161 - Bug 1285290 move AudioContextOperationControlMessage out of function scope r=padenot This will permit passing an AudioContextOperationControlMessage* to other methods. Depends on D76798 Differential Revision: https://phabricator.services.mozilla.com/D76799
a5931e2c9a139c93da3862f55048b960dd1f3d6a: Bug 1641161 - Bug 1285290 don't add destroyed tracks to graph from Increment/DecrementSuspendCount r=padenot
Karl Tomlinson <karlt+@karlt.net> - Wed, 27 May 2020 08:34:13 +0000 - rev 599712
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1641161 - Bug 1285290 don't add destroyed tracks to graph from Increment/DecrementSuspendCount r=padenot Tracks remove themselves from the graph after DestroyImpl() and so should not be added again after this. These methods are now invoked only on the MediaTrack removing the possibility of calling the wrong method. Depends on D76797 Differential Revision: https://phabricator.services.mozilla.com/D76798
b14e6ad106a54852c9a853c621eecd2dbdb098b1: Bug 1641161 - Bug 1285290 set prefs on two crashtests to allow autoplay r=padenot
Karl Tomlinson <karlt+@karlt.net> - Wed, 27 May 2020 08:32:54 +0000 - rev 599711
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1641161 - Bug 1285290 set prefs on two crashtests to allow autoplay r=padenot Apparently this pref is already set when the tests are run on CI, but it is not being set when running a single test or subdir. Differential Revision: https://phabricator.services.mozilla.com/D76797
55a7262c0f6d6ad85e13128f780ab819e6c57e54: Bug 1633493 don't EnsureNextIteration() in SourceMediaTrack::End() after forced shutdown r=padenot
Karl Tomlinson <karlt+@karlt.net> - Tue, 26 May 2020 18:36:50 +0000 - rev 599672
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1633493 don't EnsureNextIteration() in SourceMediaTrack::End() after forced shutdown r=padenot Most EnsureNextIteration() callers don't need this check, because they are either on the graph thread or otherwise know the graph has not shut down. Differential Revision: https://phabricator.services.mozilla.com/D76795
efa79eedc6ac302ea13eca74b41fc31eaad77b3a: Bug 1531851 - Make WebAudio GC tests more reliable. r=padenot
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Mon, 25 May 2020 18:04:58 +0000 - rev 599418
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1531851 - Make WebAudio GC tests more reliable. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D76590