searching for reviewer(ochameau)
784bd1c95abe7086fa5f5f22cde6ec566b4a22cb: Bug 1570279 - Some refactoring for test_objectgrips-17.js. r=ochameau, a=test-only
Oriol Brufau <oriol-bugzilla@hotmail.com> - Wed, 31 Jul 2019 17:25:30 +0300 - rev 545087
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1570279 - Some refactoring for test_objectgrips-17.js. r=ochameau, a=test-only Differential Revision: https://phabricator.services.mozilla.com//D40023 Depends on D40022
445433a1de44c9608e93d3e9fc96bc65c2b91104: Bug 1570279 - Reenable accidentally disabled checks in test_objectgrips-17.js. r=ochameau, a=test-only
Oriol Brufau <oriol-bugzilla@hotmail.com> - Wed, 31 Jul 2019 17:25:15 +0300 - rev 545086
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1570279 - Reenable accidentally disabled checks in test_objectgrips-17.js. r=ochameau, a=test-only Differential Revision: https://phabricator.services.mozilla.com//D40022
b94ef678a4be6cf724bbe4e2a33c1af8e264e811: Bug 1562821 - Mirror RemoteWebNavigation state from the <xul:browser> to the <iframe mozbrowser> when in RDM. r=ochameau, a=RyanVM
Barret Rennie <barret@brennie.ca> - Thu, 25 Jul 2019 20:14:56 +0000 - rev 544808
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1562821 - Mirror RemoteWebNavigation state from the <xul:browser> to the <iframe mozbrowser> when in RDM. r=ochameau, a=RyanVM In the last patch of this series, I forgot to sync `remoteWebNavigationImpl` state in the progress listener. This patch corrects that. Differential Revision: https://phabricator.services.mozilla.com/D39395
35e41c495b3cf7e7720d1eb41d87587ccf5b42ef: Bug 1562821 - Mirror state from the <xul:browser> to the <iframe mozbrowser> when in RDM. r=ochameau, a=RyanVM
Barret Rennie <barret@brennie.ca> - Wed, 24 Jul 2019 17:00:16 +0000 - rev 544807
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1562821 - Mirror state from the <xul:browser> to the <iframe mozbrowser> when in RDM. r=ochameau, a=RyanVM As part of bug 1510569, the majority of the `nsIWebProgress` event listeners have moved from the `WebProgressChild`/`RemoteWebProgress` to the `BrowserChild`/`BrowserParent`. In responsive design mode, the `RemoteWebProgress` previously would update the state of the `<iframe mozbrowser>` with document URI and title which would be mirrored back to the `<xul:browser>` when leaving RDM. However, the event handlers in the `BrowserParent` call directly into the `<xul:browser>`, skipping the `<iframe mozbrowser>` entirely. Therefore, when RDM is shut down, old state will be mirroed to the `<xul:browser>`, leaving it in an inconsistent state. We now mirror the state from the `<xul:browser>` to the `<iframe mozbrowser>` with an `nsIWebProgressListener` so that the `<iframe mozbrowser>` will not clobber the `<xul:browser>`'s state when leaving RDM. Differential Revision: https://phabricator.services.mozilla.com/D38918
b0403a37fb008afcecd2504f0335b1ef735f68dd: Bug 1544329 - Don't load browser console in an invisibleToDebugger compartment. r?ochameau
Oriol Brufau <oriol-bugzilla@hotmail.com> - Mon, 15 Jul 2019 22:48:43 +0300 - rev 544694
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1544329 - Don't load browser console in an invisibleToDebugger compartment. r?ochameau Differential Revision: https://phabricator.services.mozilla.com//D37926
4509c556f2980db1fc3fc4bb56fe237b07d31c0d: Bug 1561565 - Add linting rule and update documentation for setupInParent r=ochameau,yulia,Standard8
Julian Descottes <jdescottes@mozilla.com> - Fri, 28 Jun 2019 12:09:25 +0000 - rev 543365
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1561565 - Add linting rule and update documentation for setupInParent r=ochameau,yulia,Standard8 Differential Revision: https://phabricator.services.mozilla.com/D36003
f5d63a8f1a297b881a65de7eaa645778c3805f7e: Bug 1543142 - Wait for explicit events in dispatchKeyEvent test r=ochameau
Julian Descottes <jdescottes@mozilla.com> - Thu, 27 Jun 2019 15:09:13 +0000 - rev 543209
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1543142 - Wait for explicit events in dispatchKeyEvent test r=ochameau Depends on D36047 Differential Revision: https://phabricator.services.mozilla.com/D36179
cca50c60ce530e7c05b8d0e38d71c371c82490e0: Bug 1543142 - Add basic test for dispatchKeyEvent r=remote-protocol-reviewers,ochameau
Julian Descottes <jdescottes@mozilla.com> - Thu, 27 Jun 2019 12:10:45 +0000 - rev 543208
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1543142 - Add basic test for dispatchKeyEvent r=remote-protocol-reviewers,ochameau Depends on D36044 Differential Revision: https://phabricator.services.mozilla.com/D36047
b16a957f53f7be1b7414ba1c00d74328f640e7e2: Bug 1543071 - Test remote Target.closeTarget and targetDestroyed event r=ochameau
Julian Descottes <jdescottes@mozilla.com> - Wed, 19 Jun 2019 00:15:34 +0000 - rev 542039
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1543071 - Test remote Target.closeTarget and targetDestroyed event r=ochameau Depends on D35107 Differential Revision: https://phabricator.services.mozilla.com/D35108
bf1bc7abe7b6dd4a0539f494daafaf9434c03b84: Bug 1559257 - Removing getSameTypeRootTreeItemIgnoreBrowserBoundaries and getSameTypeParentIgnoreBrowserBoundaries usage; r=ochameau
Patrick Brosset <pbrosset@mozilla.com> - Tue, 18 Jun 2019 15:59:29 +0000 - rev 541986
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1559257 - Removing getSameTypeRootTreeItemIgnoreBrowserBoundaries and getSameTypeParentIgnoreBrowserBoundaries usage; r=ochameau Differential Revision: https://phabricator.services.mozilla.com/D34940
2960e77ad5a62b3361dc831b4d92a9db64822c50: Bug 1307227 - Ensure the provider is always initialized for calls to lazyRequireGetter; r=ochameau
Greg Tatum <gtatum@mozilla.com> - Fri, 31 May 2019 15:54:03 +0000 - rev 539257
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1307227 - Ensure the provider is always initialized for calls to lazyRequireGetter; r=ochameau The performance profiler pop-up menu wants to be near DevTools, but work without the complete DevTools initialization. This patch ensure that any calls to lazyRequireGetter properly initialize the provider. Differential Revision: https://phabricator.services.mozilla.com/D31628
34cc442a91cb99a9ef2f3090db57c9825ae5d4b5: bug 1553317: remote: improve error message on missing method; r=remote-protocol-reviewers,ochameau CLOSED TREE
Andreas Tolfsen <ato@sny.no> - Mon, 27 May 2019 11:39:16 +0000 - rev 538596
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
bug 1553317: remote: improve error message on missing method; r=remote-protocol-reviewers,ochameau CLOSED TREE We return with this rather omnious message when we are missing the implementation of a CDP method: Error: Protocol error (Target.createBrowserContext): TypeError: inst[command] is not a function: This patch improves the error message so that debugging is not necessary to find out which domain or command is missing. Ideally Session.jsm and ContentProcessSession.jsm would share the same execute() function (there's really not reason they don't), but that involves more work. Differential Revision: https://phabricator.services.mozilla.com/D32069
f3d44dbce7e3d1b529ce37b21a4d7471a918edd4: bug 1553317: remote: improve error message on missing method; r=remote-protocol-reviewers,ochameau
Andreas Tolfsen <ato@sny.no> - Mon, 27 May 2019 11:39:16 +0000 - rev 538542
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
bug 1553317: remote: improve error message on missing method; r=remote-protocol-reviewers,ochameau We return with this rather omnious message when we are missing the implementation of a CDP method: Error: Protocol error (Target.createBrowserContext): TypeError: inst[command] is not a function: This patch improves the error message so that debugging is not necessary to find out which domain or command is missing. Ideally Session.jsm and ContentProcessSession.jsm would share the same execute() function (there's really not reason they don't), but that involves more work. Differential Revision: https://phabricator.services.mozilla.com/D32069
9216a8250cb834d0ed5d8da01265add23a006037: Bug 1553437 - Add cold-open talos DAMP test for jsdebugger, webconsole, netmonitor r=ochameau
Julian Descottes <jdescottes@mozilla.com> - Thu, 23 May 2019 08:41:19 +0000 - rev 537974
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1553437 - Add cold-open talos DAMP test for jsdebugger, webconsole, netmonitor r=ochameau Differential Revision: https://phabricator.services.mozilla.com/D32122
65de6e306adb3257187dcb00fab74b0333765ab3: Bug 1549786 - Add test for Page.navigate reloads the page with the same URL r=ochameau
Julian Descottes <jdescottes@mozilla.com> - Wed, 22 May 2019 08:58:08 +0000 - rev 537726
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1549786 - Add test for Page.navigate reloads the page with the same URL r=ochameau Differential Revision: https://phabricator.services.mozilla.com/D32027
c4af6879f495591ca82b946a4fc1717e0322847d: Bug 1392411 Part 3 - Add test for capturing websocket stacks in net monitor, r=ochameau.
Brian Hackett <bhackett1024@gmail.com> - Sun, 19 May 2019 12:45:19 -1000 - rev 536355
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1392411 Part 3 - Add test for capturing websocket stacks in net monitor, r=ochameau.
3e0d5c61f31e3fd31726f5b4769e734a8e933008: Bug 1392411 Part 2 - Report stacks for websocket construction in net monitor, r=ochameau.
Brian Hackett <bhackett1024@gmail.com> - Sun, 19 May 2019 12:44:55 -1000 - rev 536354
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1392411 Part 2 - Report stacks for websocket construction in net monitor, r=ochameau.
1c23ba0f835f1a097ba5249bbef8e5c79308ae29: Bug 1392411 Part 3 - Add test for capturing websocket stacks in net monitor, r=ochameau.
Brian Hackett <bhackett1024@gmail.com> - Fri, 19 Apr 2019 07:50:02 -1000 - rev 536203
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1392411 Part 3 - Add test for capturing websocket stacks in net monitor, r=ochameau. Differential Revision: https://phabricator.services.mozilla.com/D28231
fce11a50c0589bb63a61abc716ea05ca1c53f12f: Bug 1392411 Part 2 - Report stacks for websocket construction in net monitor, r=ochameau.
Brian Hackett <bhackett1024@gmail.com> - Fri, 19 Apr 2019 07:42:58 -1000 - rev 536202
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1392411 Part 2 - Report stacks for websocket construction in net monitor, r=ochameau. Differential Revision: https://phabricator.services.mozilla.com/D28229
5168e91ed5b4da5b8c9c9a05cfc7f250a6de47af: Bug 1392408 Part 6 - Add test for capturing worker stacks in net monitor, r=ochameau.
Brian Hackett <bhackett1024@gmail.com> - Thu, 16 May 2019 08:09:31 -1000 - rev 536200
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1392408 Part 6 - Add test for capturing worker stacks in net monitor, r=ochameau.
8a7327b91ed243944681e5a82c1da2db7023d297: Bug 1392408 Part 5 - Listen for alternate stack traces in StackTraceCollector, r=ochameau.
Brian Hackett <bhackett1024@gmail.com> - Thu, 16 May 2019 08:09:07 -1000 - rev 536199
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1392408 Part 5 - Listen for alternate stack traces in StackTraceCollector, r=ochameau.
a2f8435fe7ed425c770d4ee59143dada8aab143b: Bug 1546736 Part 2 - Set flag on docshell when devtools are watching it, r=ochameau.
Brian Hackett <bhackett1024@gmail.com> - Wed, 08 May 2019 09:28:53 -1000 - rev 536100
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1546736 Part 2 - Set flag on docshell when devtools are watching it, r=ochameau.
b8c66ae8e149ff7dd0be76a815ffb43060ba482a: Bug 1546513 - Closing the network panel with many entries takes multiple seconds r=ochameau
Jan Odvarko <odvarko@gmail.com> - Wed, 15 May 2019 08:59:29 +0000 - rev 535801
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1546513 - Closing the network panel with many entries takes multiple seconds r=ochameau Differential Revision: https://phabricator.services.mozilla.com/D31037
8a76118beb7bfd13c4d8e01514f7905c62285a1b: Bug 1551198 - Ensure project search DAMP test display UI r=ochameau
David Walsh <dwalsh@mozilla.com> - Tue, 14 May 2019 21:08:35 +0000 - rev 535761
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1551198 - Ensure project search DAMP test display UI r=ochameau Adds two methods to make the UI display and close for search Differential Revision: https://phabricator.services.mozilla.com/D30916
dd5b92f8983514052be15d7f88a3dd0cfec9b892: Bug 1450284 - Complete method set in the Spec for Thread; r=jdescottes,ochameau
yulia <ystartsev@mozilla.com> - Mon, 13 May 2019 13:55:44 +0000 - rev 535508
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1450284 - Complete method set in the Spec for Thread; r=jdescottes,ochameau We need a complete specification in order to move forward with the front conversion. I think this will also impact other parts of the refactoring, such as some of the thread specific code in the debugger-client. This is a first pass, I did not go into detail about the return types. Differential Revision: https://phabricator.services.mozilla.com/D28640
96e678846de742425e0f48cbea15bad6731160f4: bug 1551188: remote: print listening address similarly to chrome; r=remote-protocol-reviewers,ochameau
Andreas Tolfsen <ato@sny.no> - Mon, 13 May 2019 14:43:21 +0000 - rev 535496
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
bug 1551188: remote: print listening address similarly to chrome; r=remote-protocol-reviewers,ochameau Puppeteer parses stderr looking for the regular expression ^DevTools listening on (ws:\/\/.*)$. For Puppeteer to be able to connect to Firefox, we need to change the line we print slightly to conform with this expression. The remote agent also uses Log.jsm to print it, but we cannot rely on logging always being enabled, e.g. if remote.log.level is set to Warn or above. For this reason we should use dump(). The patch also instantiates the main target before starting the HTTPD. Differential Revision: https://phabricator.services.mozilla.com/D30913
8fa4f7a2ab42ff565a7839bd401273c195f52bd4: Bug 1543940 - Remove useTopLevelWindow option from DevTools menu/utils.js helper r=ochameau
Julian Descottes <jdescottes@mozilla.com> - Wed, 08 May 2019 21:37:01 +0000 - rev 535020
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1543940 - Remove useTopLevelWindow option from DevTools menu/utils.js helper r=ochameau Depends on D27696 Differential Revision: https://phabricator.services.mozilla.com/D29887
6907e6f93141299a40d3824c8cd8de8b00dcc765: Bug 1543940 - Update tests to use toolbox.topDoc to query context-menu elements r=ochameau
Julian Descottes <jdescottes@mozilla.com> - Wed, 08 May 2019 21:36:37 +0000 - rev 535019
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1543940 - Update tests to use toolbox.topDoc to query context-menu elements r=ochameau Depends on D27695 Differential Revision: https://phabricator.services.mozilla.com/D27696
a0768b78ff32581c457122430db68e11a0a5c479: Bug 1543940 - Use the toolbox top window for context menus r=ochameau
Julian Descottes <jdescottes@mozilla.com> - Wed, 08 May 2019 21:36:04 +0000 - rev 535018
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1543940 - Use the toolbox top window for context menus r=ochameau Depends on D28036 If a context menu is opened in the toolbox document when running in a frame with type=content, keyboard navigation will not move to the context menu when it's opened. Differential Revision: https://phabricator.services.mozilla.com/D27695
388f61b1b134177011dcfe55f52faff072a50052: Bug 1543940 - menu.popup() should take a document argument instead of toolbox r=ochameau
Julian Descottes <jdescottes@mozilla.com> - Wed, 08 May 2019 21:35:36 +0000 - rev 535017
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1543940 - menu.popup() should take a document argument instead of toolbox r=ochameau Depends on D27693 Menu::popup and popupAtZoom are expecting a toolbox argument as last argument. However, half of the callsites do not have access to the toolbox and just pass a { doc } object. This is misleading when trying to work on menu.js because you cannot rely on toolbox APIs. Differential Revision: https://phabricator.services.mozilla.com/D28036
0484e2e8f7fd170c14218dcf60c9c3983e1a8267: Bug 1543940 - Rely on chromeEventHandler for toolboxContextMenu events r=ochameau
Julian Descottes <jdescottes@mozilla.com> - Wed, 08 May 2019 21:35:02 +0000 - rev 535016
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1543940 - Rely on chromeEventHandler for toolboxContextMenu events r=ochameau Using chromeEventHandler will allow us to catch events fired from any frame. By default when DevTools are in a type=chrome frame, events also bubble across frames. With type=content this is no longer the case. Differential Revision: https://phabricator.services.mozilla.com/D27693
590b72185b691bbb7a8cbf48e93373f1eecad035: Bug 1543940 - Remove useTopLevelWindow option from DevTools menu/utils.js helper r=ochameau
Julian Descottes <jdescottes@mozilla.com> - Wed, 08 May 2019 15:15:22 +0000 - rev 534962
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1543940 - Remove useTopLevelWindow option from DevTools menu/utils.js helper r=ochameau Depends on D27696 Differential Revision: https://phabricator.services.mozilla.com/D29887
42e2136f684fd55780c7a8e63227c0bc64e4b6ef: Bug 1543940 - Update tests to use toolbox.topDoc to query context-menu elements r=ochameau
Julian Descottes <jdescottes@mozilla.com> - Wed, 08 May 2019 15:14:54 +0000 - rev 534961
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1543940 - Update tests to use toolbox.topDoc to query context-menu elements r=ochameau Depends on D27695 Differential Revision: https://phabricator.services.mozilla.com/D27696
a66967f1704278ebfee2dfd560c2ccba84953395: Bug 1543940 - Use the toolbox top window for context menus r=ochameau
Julian Descottes <jdescottes@mozilla.com> - Wed, 08 May 2019 15:14:05 +0000 - rev 534960
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1543940 - Use the toolbox top window for context menus r=ochameau Depends on D28036 If a context menu is opened in the toolbox document when running in a frame with type=content, keyboard navigation will not move to the context menu when it's opened. Differential Revision: https://phabricator.services.mozilla.com/D27695
b1e6e932873c26533fe57f4d87e4c99f45f4097b: Bug 1543940 - menu.popup() should take a document argument instead of toolbox r=ochameau
Julian Descottes <jdescottes@mozilla.com> - Wed, 08 May 2019 15:13:40 +0000 - rev 534959
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1543940 - menu.popup() should take a document argument instead of toolbox r=ochameau Depends on D27693 Menu::popup and popupAtZoom are expecting a toolbox argument as last argument. However, half of the callsites do not have access to the toolbox and just pass a { doc } object. This is misleading when trying to work on menu.js because you cannot rely on toolbox APIs. Differential Revision: https://phabricator.services.mozilla.com/D28036
7fe9661e8510f9bf0430573aaceb7ed478e472b2: Bug 1543940 - Rely on chromeEventHandler for toolboxContextMenu events r=ochameau
Julian Descottes <jdescottes@mozilla.com> - Wed, 08 May 2019 15:13:32 +0000 - rev 534958
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1543940 - Rely on chromeEventHandler for toolboxContextMenu events r=ochameau Using chromeEventHandler will allow us to catch events fired from any frame. By default when DevTools are in a type=chrome frame, events also bubble across frames. With type=content this is no longer the case. Differential Revision: https://phabricator.services.mozilla.com/D27693
20a54f437d518408622e82484c9b5a6997766dab: Bug 1541175 Part 3: Update test expectations. r=ochameau
Brad Werth <bwerth@mozilla.com> - Fri, 03 May 2019 23:06:54 +0000 - rev 534830
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1541175 Part 3: Update test expectations. r=ochameau Differential Revision: https://phabricator.services.mozilla.com/D26614
2f85ada34acb9da79c83f9fb73b59f8d8d295a8d: Bug 1541175 Part 2: Force RDM UI to be at 100% zoom. r=pbro,ochameau
Brad Werth <bwerth@mozilla.com> - Mon, 06 May 2019 07:21:13 +0000 - rev 534829
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1541175 Part 2: Force RDM UI to be at 100% zoom. r=pbro,ochameau Once RDM is up-and-running, the Zoom UI will stay synchronized with the zoom level of the RDM content pane. These changes ensure that the RDM tools are forced to 100%, and then does a fixup to get the Zoom UI to match the RDM content pane zoom level again. Differential Revision: https://phabricator.services.mozilla.com/D26045
b377b5bdd883b97fedbfc61666edb780964c1f96: Bug 1541175 Part 1: Prevent fullZoom and textZoom from being remapped on RDM docshell swap. r=ochameau
Brad Werth <bwerth@mozilla.com> - Tue, 07 May 2019 17:59:36 +0000 - rev 534828
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1541175 Part 1: Prevent fullZoom and textZoom from being remapped on RDM docshell swap. r=ochameau There is no need to transfer these properties because the swap makes the outer browser act as if it is remote, and then the message manager tunnel ensures that the outer browser will get and set the zoom values from the inner browser. Differential Revision: https://phabricator.services.mozilla.com/D29911
ac9c08f90cd070b591211a51419b8e301470a911: Bug 1392408 Part 6 - Add test for capturing worker stacks in net monitor, r=ochameau.
Brian Hackett <bhackett1024@gmail.com> - Thu, 02 May 2019 08:35:50 -1000 - rev 534333
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1392408 Part 6 - Add test for capturing worker stacks in net monitor, r=ochameau.
855b8dd227f92048824ff83ee46855f6f9bf010f: Bug 1392408 Part 5 - Listen for alternate stack traces in StackTraceCollector, r=ochameau.
Brian Hackett <bhackett1024@gmail.com> - Thu, 02 May 2019 08:35:34 -1000 - rev 534332
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1392408 Part 5 - Listen for alternate stack traces in StackTraceCollector, r=ochameau.
92678c01ead789b2951fe1880c30d5251d2e5785: Bug 1494796 - Use promise pattern rather than callback pattern for threadClient methods; r=ochameau
yulia <ystartsev@mozilla.com> - Thu, 02 May 2019 15:39:20 +0000 - rev 534200
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1494796 - Use promise pattern rather than callback pattern for threadClient methods; r=ochameau This is preparation for moving the threadClient to a front. Fronts do not support the callback style that clients have, they only support promises. As such, this patch migrates all instances of the threadClient using callback style methods to promises. I have cc'd the debugger team so that they are aware of this change and it doesn't take them by surprise. try run : https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=242251058&revision=dbd6cca9619ca0880e920d5b86fc6d6e0c728113 Differential Revision: https://phabricator.services.mozilla.com/D28966
a32ab60deb60961bfa7f5df95a93aa8c7976a4d2: Bug 1392408 Part 6 - Add test for capturing worker stacks in net monitor, r=ochameau.
Brian Hackett <bhackett1024@gmail.com> - Fri, 19 Apr 2019 07:34:51 -1000 - rev 534184
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1392408 Part 6 - Add test for capturing worker stacks in net monitor, r=ochameau.
69cbc0afb1f17679877c442b1e9e4fe1ffabe07a: Bug 1392408 Part 5 - Listen for alternate stack traces in StackTraceCollector, r=ochameau.
Brian Hackett <bhackett1024@gmail.com> - Fri, 19 Apr 2019 07:25:52 -1000 - rev 534183
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1392408 Part 5 - Listen for alternate stack traces in StackTraceCollector, r=ochameau.
05e9997b6809900677149992d3a5634ae43b3a11: Bug 1529247 - remove unused pausedLongString method, threadLongString and arrayBuffer methods; r=ochameau
yulia <ystartsev@mozilla.com> - Tue, 30 Apr 2019 14:44:23 +0000 - rev 533861
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1529247 - remove unused pausedLongString method, threadLongString and arrayBuffer methods; r=ochameau Finally! the goal of all of this: removing three functions from threadClient that really belong as part of source client. PauseLongString is never used except in tests. ThreadLongString is only ever used by sourceClient. Same goes for the arrayBuffer method. This clears all of that out. Differential Revision: https://phabricator.services.mozilla.com/D21715
78df5dc92c3f9a0c58043d625a3c93352135948f: Bug 1545021 - Convert ArrayBuffer to a Front and Protocoljs actor; r=ochameau,jdescottes
yulia <ystartsev@mozilla.com> - Tue, 30 Apr 2019 14:40:43 +0000 - rev 533860
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1545021 - Convert ArrayBuffer to a Front and Protocoljs actor; r=ochameau,jdescottes This introduces an ArrayBuffer front, so that we no longer need to go through the thread client to get an array buffer for the sourceFront (this is the only place it is used). It also converts the arrayBufferActor to a protocol.js actor. I was running into an issue between them. I need to double check what this issue was. If these two refactors need to be split, I can do that, but for now it looks like it wasn’t that large of a change. Differential Revision: https://phabricator.services.mozilla.com/D27878
542c3b51efa1deda9a07a1081d635150a0d8d45f: Bug 1544697 - use LongStringFront in SourceFront; r=ochameau,jdescottes
yulia <ystartsev@mozilla.com> - Tue, 30 Apr 2019 08:04:33 +0000 - rev 533859
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1544697 - use LongStringFront in SourceFront; r=ochameau,jdescottes This change does two things: it starts returning the longstring actor directly from the server. It also introduces a new type in the spec — sourcedata. This sourcedata can handle either a plain form (for array buffer) or it writes to and from a front. This is the major change. It could be the basis for writing a union type for protocol.js, which would do the same thing based on a list (ie — RetVal(“nullable:arraybuffer|nullable:longstring”)) This could be useful for getting handling the return value of createValueGrip (https://searchfox.org/mozilla-central/rev/f46e2bf881d522a440b30cbf5cf8d76fc212eaf4/devtools/server/actors/object/utils.js#75) This requires that this stack lands first: https://phabricator.services.mozilla.com/D27709 Differential Revision: https://phabricator.services.mozilla.com/D27877
d59b5153250dc33091def93327d1134164fadbbb: bug 1547679: remote: disable browser-chrome tests on asan; r=remote-protocol-reviewers,ochameau
Andreas Tolfsen <ato@sny.no> - Tue, 30 Apr 2019 10:00:35 +0000 - rev 533791
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
bug 1547679: remote: disable browser-chrome tests on asan; r=remote-protocol-reviewers,ochameau We should also disable browser-chrome tests on ASan, as some of the leaks reported were caught by LeakSanitizer, which is run as part of AddressSanitizer. Follow-up from https://bugzilla.mozilla.org/show_bug.cgi?id=1547679#c3. Differential Revision: https://phabricator.services.mozilla.com/D29327
58ac3afa5e9a346fbc66396219f3d8be7f3b781d: bug 1547679: remote: disable all browser-chrome tests on debug; r=remote-protocol-reviewers,ochameau
Andreas Tolfsen <ato@sny.no> - Mon, 29 Apr 2019 12:50:15 +0000 - rev 533614
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
bug 1547679: remote: disable all browser-chrome tests on debug; r=remote-protocol-reviewers,ochameau Before landing the remote agent in Firefox Nightly, we had to disable remote/test/browser/browser_cdp.js because it caused a permafailure on debug due to a memory leak. We thought the problem was limited to this specific test, but over the weekend two more intermittent leaks were discovered: * https://bugzilla.mozilla.org/show_bug.cgi?id=1546850 * https://bugzilla.mozilla.org/show_bug.cgi?id=1547303 Until we have had time to investigate and plug the leak, we will disable all the browser-chrome tests on all debug platforms. Differential Revision: https://phabricator.services.mozilla.com/D29181
1b7dc4afb065cf062dbf29500b05991319052132: Bug 1544709 - Register global keyboard shortcuts on chromeEventHandler r=ochameau
Julian Descottes <jdescottes@mozilla.com> - Fri, 26 Apr 2019 16:40:57 +0000 - rev 533484
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1544709 - Register global keyboard shortcuts on chromeEventHandler r=ochameau Depends on D27686 Toolbox, zoom keys and inspector search should use the chromeeventhandler as event target. They need to capture events from inner frames. Differential Revision: https://phabricator.services.mozilla.com/D27688