searching for reviewer(nox)
741d67d502bd15ee4c463e99abb290e691813e06: Bug 1569911 - Servo: Generate apis.html and css-properties.json for docs as part of crates' build scripts. r=nox
Simon Sapin <simon.sapin@exyr.org> - Mon, 29 Jul 2019 18:57:20 +0200 - rev 549134
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1569911 - Servo: Generate apis.html and css-properties.json for docs as part of crates' build scripts. r=nox … rather than as an extra step after `cargo doc`. This helps always using the correct set of CSS properties (for layout 2013 v.s. 2020). Cherry-picked from: https://github.com/servo/servo/pull/23856
d6be422cd134b0cc94f42bfacdd972923a54ccee: Bug 1569911 - Stylo: replace product={gecko,servo} with engine={gecko,servo-2013,servo-2020}. r=emilio,nox
Simon Sapin <simon.sapin@exyr.org> - Thu, 25 Jul 2019 19:39:32 +0200 - rev 549133
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1569911 - Stylo: replace product={gecko,servo} with engine={gecko,servo-2013,servo-2020}. r=emilio,nox Renaming the variable helped make sure I looked at every use. Cherry-picked from: https://github.com/servo/servo/pull/23856
144f4ff252829f1fa36bb74d2663836ce2f7f298: Bug 1569911 - Servo: Auto-generate CSSStyleDeclaration.webidl for CSS properties based on the style crate. r=nox
Simon Sapin <simon.sapin@exyr.org> - Fri, 26 Jul 2019 21:54:42 +0200 - rev 549132
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1569911 - Servo: Auto-generate CSSStyleDeclaration.webidl for CSS properties based on the style crate. r=nox Cherry-picked from https://github.com/servo/servo/pull/23856
a5d7a71300f8000625634d67ce5cd242e5e8e4d9: Bug 1493435 - Upgrade to uluru 0.3. r=nox,emilio
Matt Brubeck <mbrubeck@limpet.net> - Sat, 22 Sep 2018 17:24:47 -0700 - rev 496275
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1493435 - Upgrade to uluru 0.3. r=nox,emilio This cherry-picks servo/servo#21789.
dbc1cffb4a11cabf48862d5206f139dd190c94ce: Bug 1455902: Update to smallbitvec 2.1. r=nox,emilio
Matt Brubeck <mbrubeck@limpet.net> - Tue, 17 Apr 2018 17:24:54 -0700 - rev 471034
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
Bug 1455902: Update to smallbitvec 2.1. r=nox,emilio This cherry-picks servo commit e3f79d91306655f4cbe3eefe6106b9c10218f464. MozReview-Commit-ID: JO1wwjFuz5N
2e462060cbedc258c3cfbb7aba14e22fd13cf854: No bug - Fix error name in comment for try_match_ident_ignore_ascii_case. r=nox,emilio
Jonathan Watt <jwatt@jwatt.org> - Tue, 17 Apr 2018 13:24:30 +0100 - rev 470205
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
No bug - Fix error name in comment for try_match_ident_ignore_ascii_case. r=nox,emilio MozReview-Commit-ID: GDejDQE7sj3
2fab5f21608554909536e0092027f301c6a32284: servo: Merge #20616 - style: Simplify border-image-repeat serialization (from emilio:border-image-repeat); r=nox
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 10 Apr 2018 18:46:39 -0400 - rev 468762
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
servo: Merge #20616 - style: Simplify border-image-repeat serialization (from emilio:border-image-repeat); r=nox We're the only ones to preserve explicitly the second keyword, as noticed in: https://github.com/w3c/web-platform-tests/pull/10170 Reland of #20610 because it got backed out because I wasn't paying attention to IRC. Source-Repo: https://github.com/servo/servo Source-Revision: 0f85c645197608a32f453f7f7f1f9d5709456c2a
d186bcce12353c5e51ec1857d24fac367003564c: servo: Merge #20610 - style: Simplify border-image-repeat serialization (from emilio:border-image-repeat); r=nox
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 10 Apr 2018 08:49:28 -0400 - rev 468681
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
servo: Merge #20610 - style: Simplify border-image-repeat serialization (from emilio:border-image-repeat); r=nox We're the only ones to preserve explicitly the second keyword, as noticed in: https://github.com/w3c/web-platform-tests/pull/10170 Source-Repo: https://github.com/servo/servo Source-Revision: 07dd37a0cf2eb19a294b27404f1deee1ee6e8fd7
9ffceba6cce1d2797c3c88fd8a469f174b48138e: servo: Merge #20474 - Use new std::num::NonZero* types instead of deprecated core::nonzero::NonZero (from servo:nonzero); r=nox
Simon Sapin <simon.sapin@exyr.org> - Mon, 09 Apr 2018 15:44:16 -0400 - rev 468534
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
servo: Merge #20474 - Use new std::num::NonZero* types instead of deprecated core::nonzero::NonZero (from servo:nonzero); r=nox Source-Repo: https://github.com/servo/servo Source-Revision: bfb9fe6159ba61f0155a5ecc5a473b2a3edd6ef6
466539192a40c3b529be848923d799385b73b2a0: servo: Merge #20486 - Bump walkdir (from Eijebong:walkdir); r=nox
Bastien Orivel <eijebong@bananium.fr> - Fri, 06 Apr 2018 08:14:00 -0400 - rev 468192
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
servo: Merge #20486 - Bump walkdir (from Eijebong:walkdir); r=nox Source-Repo: https://github.com/servo/servo Source-Revision: ad4905cb900925107c06b655109e373c48450464
2ac2b364cf5d83c6a336622cbda6b3ddb5f1e799: servo: Merge #20501 - style: Use a more consistent style for parsing functions (from emilio:parsing-style); r=nox
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 02 Apr 2018 13:36:01 -0400 - rev 467435
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
servo: Merge #20501 - style: Use a more consistent style for parsing functions (from emilio:parsing-style); r=nox Source-Repo: https://github.com/servo/servo Source-Revision: a208d4246cf0e02a1a22196f26692bd29fb35011
60e7fca839b4767cb04dd500a0d4229447213248: servo: Merge #20481 - style: Derive a debug impl instead of implementing by hand (from emilio:debug-wat); r=nox
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 02 Apr 2018 12:09:29 -0400 - rev 467409
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
servo: Merge #20481 - style: Derive a debug impl instead of implementing by hand (from emilio:debug-wat); r=nox Source-Repo: https://github.com/servo/servo Source-Revision: 39018f933997e266e11968d82f556af15c5321d8
d3df709eb18341e5b073c921bc2e45ad09d65328: servo: Merge #20371 - Bump ipc-channel and bincode (from Eijebong:ipc-channel); r=nox
Bastien Orivel <eijebong@bananium.fr> - Wed, 21 Mar 2018 09:00:16 -0400 - rev 465296
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
servo: Merge #20371 - Bump ipc-channel and bincode (from Eijebong:ipc-channel); r=nox Source-Repo: https://github.com/servo/servo Source-Revision: 02c758a2266f51a95dc2ef647462e13fad4bb6a8
f1284f5d90404c685bb6c3fd307e60d4ed8221a6: servo: Merge #20298 - Bump servo-websocket to 0.21 (from Eijebong:websocket); r=nox
Bastien Orivel <eijebong@bananium.fr> - Wed, 21 Mar 2018 06:41:31 -0400 - rev 465279
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
servo: Merge #20298 - Bump servo-websocket to 0.21 (from Eijebong:websocket); r=nox Source-Repo: https://github.com/servo/servo Source-Revision: 5b575e36479bd1edc46a036c780dccf274dd430c
0f5b36893bc24ccf9909684e842b1ec6b3cb2257: servo: Merge #20339 - style: Remove unsound Atom From implementations (from emilio:atom-from-dead-beef); r=nox
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 19 Mar 2018 06:11:14 -0400 - rev 464858
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
servo: Merge #20339 - style: Remove unsound Atom From implementations (from emilio:atom-from-dead-beef); r=nox Fixes #20158 Source-Repo: https://github.com/servo/servo Source-Revision: b47224dbcce2974e6f572b284cba1e2f5393b95d
e8d02073ed5acfe50ee9568ede049ffa96941096: servo: Merge #20224 - Fix counter() and counters() serialization (from emilio:counter-serialization); r=nox
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 14 Mar 2018 13:26:00 -0400 - rev 464270
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
servo: Merge #20224 - Fix counter() and counters() serialization (from emilio:counter-serialization); r=nox See https://github.com/w3c/csswg-drafts/issues/670 and https://github.com/w3c/web-platform-tests/pull/9862. Source-Repo: https://github.com/servo/servo Source-Revision: 7b326529db64ac27f0b956880b3b63dd12cd0c1a
1728fe9633089969d31d343ab9906348fdc34d59: servo: Merge #20204 - Rebump toml and error-chain (from Eijebong:bump); r=nox
Bastien Orivel <eijebong@bananium.fr> - Tue, 13 Mar 2018 05:36:44 -0400 - rev 463857
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
servo: Merge #20204 - Rebump toml and error-chain (from Eijebong:bump); r=nox Source-Repo: https://github.com/servo/servo Source-Revision: 7e0f45b1c7047d9e1b16f39c005de7f92e462df7
48a01c6366f3f56561083a3f4a0eddb37082fcf7: servo: Merge #20273 - Unbreak the docs build (from servo:jdm-patch-13); r=nox
Josh Matthews <josh@joshmatthews.net> - Mon, 12 Mar 2018 13:26:55 -0400 - rev 463797
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
servo: Merge #20273 - Unbreak the docs build (from servo:jdm-patch-13); r=nox I added this to avoid the problem with doc builds leaving around large build artifacts while also working around #17243, but it appears to break the doc build entirely. This won't end up executing on servo-linux1 or servo-linux2 because of #17243, but I'm looking into the correct solution for that simultaneously. Source-Repo: https://github.com/servo/servo Source-Revision: af12284b6a89b288b61298d64df215f6d6225c83
e85261fce8702b2dbe8cd526d1dc8a0a4b4ade66: servo: Merge #20236 - Introduce #[css(skip_if)] (from emilio:to-css-skip-if); r=nox
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 08 Mar 2018 09:16:55 -0500 - rev 462218
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
servo: Merge #20236 - Introduce #[css(skip_if)] (from emilio:to-css-skip-if); r=nox This is most of #20224 but without the actual counter() fix since it's waiting on a WPT update. Source-Repo: https://github.com/servo/servo Source-Revision: 8133f788cfbde23cc54032a3327303b42257b91d
270e441c36496df303aaa7b8227e614832b7394d: servo: Merge #20201 - Bump some dependencies now that metadeps is out of the way ᕕ( ᐛ )ᕗ (from Eijebong:bump); r=nox
Bastien Orivel <eijebong@bananium.fr> - Mon, 05 Mar 2018 10:22:24 -0500 - rev 461586
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
servo: Merge #20201 - Bump some dependencies now that metadeps is out of the way ᕕ( ᐛ )ᕗ (from Eijebong:bump); r=nox Source-Repo: https://github.com/servo/servo Source-Revision: 05dcfe2983f906ab5909843e242987f154360f6a
7ef3483244619c2dfa0b581676a243de6af02f90: servo: Merge #20194 - style: remove unused AsciiExt imports (from emilio:ascii-ext-stuff); r=nox
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 04 Mar 2018 13:35:04 -0500 - rev 461576
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
servo: Merge #20194 - style: remove unused AsciiExt imports (from emilio:ascii-ext-stuff); r=nox eq_ignore_ascii_case is not in AsciiExt since rustc 1.23. Source-Repo: https://github.com/servo/servo Source-Revision: fbeb5a81a8eb3fa2f5feb4c039620158ab1f87f2
87200567a2739dbe73fd072a04ad736df10b2990: servo: Merge #20193 - style: Remove more rustc_has_pr45225 stuff (from emilio:needless-stuff-is-needless); r=nox
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 04 Mar 2018 10:41:54 -0500 - rev 461573
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
servo: Merge #20193 - style: Remove more rustc_has_pr45225 stuff (from emilio:needless-stuff-is-needless); r=nox Also cleans up references to a fixed issue. Source-Repo: https://github.com/servo/servo Source-Revision: d09ea8476e68ff131d71bc78a2c6c324679b90d5
4f949bd26e326af7189a4abcbee46d496dd8812e: servo: Merge #20188 - style: Add bindings for ShadowRoot (from emilio:moar-traits); r=nox
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 03 Mar 2018 17:53:08 -0500 - rev 461497
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
servo: Merge #20188 - style: Add bindings for ShadowRoot (from emilio:moar-traits); r=nox This adds TShadowRoot to the `dom` module. Right now it barely adds uses of it, but this is a prerequisite to fix a bunch of Shadow DOM bugs and separate it from the XBL mess. Source-Repo: https://github.com/servo/servo Source-Revision: ce562a2cc6c508a423cad07be30638e89ff13def
a02e83384bde96366a3e36915cc3b22b1e216226: servo: Merge #20186 - style: Fix text-emphasis-style conversion (from emilio:fixup-fill); r=nox
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 03 Mar 2018 12:23:52 -0500 - rev 461475
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
servo: Merge #20186 - style: Fix text-emphasis-style conversion (from emilio:fixup-fill); r=nox Was accidentally broken in #20178 and is causing orange. Source-Repo: https://github.com/servo/servo Source-Revision: 2425939f9fa8fe8263e3b7108c265da6d12d7409
14a28deeba4dadfbdec9adec0e2ff59bc65527f5: No bug: Update bindgen to 0.33. r=nox on a CLOSED TREE
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 02 Mar 2018 20:28:26 +0100 - rev 461379
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
No bug: Update bindgen to 0.33. r=nox on a CLOSED TREE MozReview-Commit-ID: 4PgOmtt3zrg
855ac3f0d4b295fff8b4550e66a04eedd8ad1e7b: servo: Merge #20173 - style: Update bindgen to 0.33 (from emilio:formatted-style); r=nox
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 02 Mar 2018 12:45:29 -0500 - rev 461375
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
servo: Merge #20173 - style: Update bindgen to 0.33 (from emilio:formatted-style); r=nox Source-Repo: https://github.com/servo/servo Source-Revision: 7944bcbe8ddd71ec04e8f43d3da663311ba25928
cd1745eb254141267955f0074e0a18284ce76a7e: servo: Merge #20143 - Bump itertools, image, flate2 and caseless (from Eijebong:bump); r=nox
Bastien Orivel <eijebong@bananium.fr> - Wed, 28 Feb 2018 13:10:59 -0500 - rev 460803
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
servo: Merge #20143 - Bump itertools, image, flate2 and caseless (from Eijebong:bump); r=nox Source-Repo: https://github.com/servo/servo Source-Revision: af92c06223a65fee3037b64b29ed9f089ef87310
08a85550fb3b9eaae2974e53594600f9b5eb02eb: servo: Merge #20138 - style: Only expose longhands to rust via iterators (from emilio:longhand-iterator); r=nox
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 28 Feb 2018 06:28:41 -0500 - rev 460720
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
servo: Merge #20138 - style: Only expose longhands to rust via iterators (from emilio:longhand-iterator); r=nox The key here is that we only filter longhands if the shorthand is accessible to content and vice-versa. This prevents the bug that prevented me to land this patch before, which was us not expanding properly chrome-only shorthands. Source-Repo: https://github.com/servo/servo Source-Revision: a0be3a7fae2730bfef52db94db7f3af14b60be67
22e2edc77ef9d5048b7a9fdfa18d7e41c095a656: servo: Merge #20134 - style: Split out NonCustomPropertyId::enabled_for_all_content from allowed_in (from emilio:split-stuff); r=nox
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 27 Feb 2018 07:12:50 -0500 - rev 460598
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
servo: Merge #20134 - style: Split out NonCustomPropertyId::enabled_for_all_content from allowed_in (from emilio:split-stuff); r=nox This is part of a patch that was reviewed by nox in #20081, but which I reverted because that approach didn't quite work. I think I have something that works now, but I'm waiting for a Geckotry. Landing this should be worth it in the meantime though. Source-Repo: https://github.com/servo/servo Source-Revision: b9e16e54aae8daa3249e2a8b4483ce302d817f56
fd7b1a798fa0c95bb5db777534320be0c700de1f: servo: Merge #20117 - style: Somewhat miscelaneous cleanup (from emilio:misc-cleanup); r=nox
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 24 Feb 2018 17:28:20 -0500 - rev 460207
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
servo: Merge #20117 - style: Somewhat miscelaneous cleanup (from emilio:misc-cleanup); r=nox Source-Repo: https://github.com/servo/servo Source-Revision: bbfca28a4f3770896955375d01f1c489b4632fd3
1b6ba1c15366fb08dc376b403210615505422966: servo: Merge #20067 - Update clipboard related dependencies to use xcb 0.8 (from Eijebong:clipboard); r=nox
Bastien Orivel <eijebong@bananium.fr> - Fri, 23 Feb 2018 13:01:20 -0500 - rev 460047
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
servo: Merge #20067 - Update clipboard related dependencies to use xcb 0.8 (from Eijebong:clipboard); r=nox See https://github.com/rtbo/rust-xcb/pull/55 Source-Repo: https://github.com/servo/servo Source-Revision: 64a4dfbc71ca5e803df206eccc2696c2eae3b906
01328de0be21dfeeef394b2b0f048fc8d6994e6c: servo: Merge #20081 - style: More serialization tweaks (from emilio:more-longhand-stuff); r=nox
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 20 Feb 2018 23:49:19 -0500 - rev 459622
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
servo: Merge #20081 - style: More serialization tweaks (from emilio:more-longhand-stuff); r=nox This still doesn't fix everything. In particular, we need to check whether the subproperty will be enabled in Longhands and LonghandsToSerialize too. I haven't decided yet on what's the best way to do that. Source-Repo: https://github.com/servo/servo Source-Revision: 2c060eb81a8eab0fdcbf13231bf7703ea96bc657
bfca7256e3f4f7d641be0768d6335d1c5998351b: servo: Merge #20078 - style: Rejigger serialization of a declaration block to not look at the shorthands length (from emilio:decl-block-serialization); r=nox
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 20 Feb 2018 06:40:43 -0500 - rev 459481
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
servo: Merge #20078 - style: Rejigger serialization of a declaration block to not look at the shorthands length (from emilio:decl-block-serialization); r=nox This is because I'm going to make shorthands() and longhands() return an iterator, so that we account for prefs properly (https://bugzilla.mozilla.org/show_bug.cgi?id=1438234). Source-Repo: https://github.com/servo/servo Source-Revision: 4d7383f4f3acabfdc76c285c8cf7fb849abd11bd
54f47b42fbf4f48aae142d265d0dea98e203e905: servo: Merge #20065 - style: Cleanup GeckoElement::note_explicit_hints (from emilio:note-stuff); r=nox
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 16 Feb 2018 15:33:48 -0500 - rev 459242
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
servo: Merge #20065 - style: Cleanup GeckoElement::note_explicit_hints (from emilio:note-stuff); r=nox What it's doing is not so complicated. Source-Repo: https://github.com/servo/servo Source-Revision: d423e54d58d6cced950896eed1957ee2989f4eee
97908780b56a4498eea6857df76eaa5a9a398be4: servo: Merge #20064 - style: Trivially cleanup length parsing (from emilio:cleanup-length-parsing); r=nox
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 16 Feb 2018 14:43:50 -0500 - rev 459236
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
servo: Merge #20064 - style: Trivially cleanup length parsing (from emilio:cleanup-length-parsing); r=nox Mostly formatting signatures properly, but also removing useless functions and stuff. Source-Repo: https://github.com/servo/servo Source-Revision: d092c2e877fdbae241d6f4b53d61701d7d50e346
e68b99992d20abf911254f63a07c8939b7417d97: servo: Merge #20046 - style: Move most of allowed_in to NonCustomPropertyId (from emilio:less-dumb); r=nox
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 14 Feb 2018 13:23:07 -0500 - rev 458718
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
servo: Merge #20046 - style: Move most of allowed_in to NonCustomPropertyId (from emilio:less-dumb); r=nox Also simplify the servo property id to gecko property id conversion to be faster and less repetitive. This is in preparation of some patches to properly allow disabled longhands on enabled shorthands, something that we don't contemplate right now. Source-Repo: https://github.com/servo/servo Source-Revision: bdbb298bac881d8cf773739e4d7018080b40beb6
63f56f0215ef007a60ad3013e6a7e24948bb71f4: servo: Merge #20038 - style: Avoid an intermediate buffer in Servo_Shorthand_AnimationValues_Serialize (from emilio:no-need-for-strings); r=nox
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 13 Feb 2018 12:06:02 -0500 - rev 458601
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
servo: Merge #20038 - style: Avoid an intermediate buffer in Servo_Shorthand_AnimationValues_Serialize (from emilio:no-need-for-strings); r=nox Source-Repo: https://github.com/servo/servo Source-Revision: 4c3f1756da1373e9eef33716c9a93b0bb0559241
d4e18373df7f56d644fa4c5f44f44b6d5326a6fb: servo: Merge #20022 - Update syn, quote and synstructure (from Eijebong:syn); r=nox
Bastien Orivel <eijebong@bananium.fr> - Tue, 13 Feb 2018 11:15:54 -0500 - rev 458600
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
servo: Merge #20022 - Update syn, quote and synstructure (from Eijebong:syn); r=nox Right now they're duplicated because we need a new serde release (ping @dtolnay), a new cssparser release (ping @SimonSapin) and a new release of html5ever with https://github.com/servo/html5ever/pull/336 Source-Repo: https://github.com/servo/servo Source-Revision: 6cb78057bb115262f31548ef651b24a48957f11d
5ede77fd6d7875bf1ad7e4b2458a59238eae683d: servo: Merge #20039 - style: Use consistent formatting for functions in the glue file (from emilio:indent); r=nox
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 13 Feb 2018 10:25:30 -0500 - rev 458593
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
servo: Merge #20039 - style: Use consistent formatting for functions in the glue file (from emilio:indent); r=nox I'm tired of only drive-by fixing them :) Source-Repo: https://github.com/servo/servo Source-Revision: 7e31ae35e1036467e25484ab30132f8bd49f0ee8
89a7c485c35f3ef8a4d8398b4bb9740b31d91393: servo: Merge #20030 - style: Remove useless code after #19994 (from emilio:useless-return-is-useless); r=nox
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 12 Feb 2018 08:47:36 -0500 - rev 458382
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
servo: Merge #20030 - style: Remove useless code after #19994 (from emilio:useless-return-is-useless); r=nox Source-Repo: https://github.com/servo/servo Source-Revision: 3a42f6f988c4bfb1847ed8dbb7a0013c6b2e528a
43073730dcb382047c9d943771cab44d52da3c52: servo: Merge #20027 - style: Back out ordermap (from emilio:bye-ordermap); r=nox
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 12 Feb 2018 07:36:04 -0500 - rev 458377
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
servo: Merge #20027 - style: Back out ordermap (from emilio:bye-ordermap); r=nox It was worth a shot! Source-Repo: https://github.com/servo/servo Source-Revision: 889bb012efe1bdb08ce85b14b49104a76c4b53f0
fb2346dcaa2a5b7141b703ac0fe5a7ae98158f56: servo: Merge #20004 - style: Add infrastructure to have a standalone author stylesheet collection (from emilio:author-sheet-collection); r=nox
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 09 Feb 2018 17:18:08 -0500 - rev 458230
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
servo: Merge #20004 - style: Add infrastructure to have a standalone author stylesheet collection (from emilio:author-sheet-collection); r=nox Right now Gecko uses a whole `Stylist` for stuff like XBL / Shadow DOM. That's not great, because it has tons of unrelated logic, and also eats up a lot of memory. Also, it prevents us to optimize style changes in shadow hosts the same way we do for the document. These patches mostly rejigger stuff around so that you can define a `DocumentStylesheetSet` and then an `AuthorStylesheetSet`, which would contain just the Shadow DOM sheets / XBL resource sheets. It still doesn't introduce any use for the later, but that will come later. There's a patch in this PR that requires Gecko changes, posted in https://bugzilla.mozilla.org/show_bug.cgi?id=1436798. Source-Repo: https://github.com/servo/servo Source-Revision: 6b1a74672d6b9d9c55b027b147b0a6eb8f727bfd
8027b463829e23066343300dea6291e06c837f8d: servo: Merge #20003 - style: Remove unneeded clone (from emilio:simplify-font-family-serialize); r=nox
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 09 Feb 2018 06:32:39 -0500 - rev 458131
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
servo: Merge #20003 - style: Remove unneeded clone (from emilio:simplify-font-family-serialize); r=nox Source-Repo: https://github.com/servo/servo Source-Revision: f8ac623047085fbb46eab44f6ad7682a45f032b7
c758008325faf1e786cbd293bb12b9b65999c859: servo: Merge #19974 - style: Optimize serialization of identifiers of length <= 16 🐉🐲 (from emilio:atom-serialization); r=nox
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 07 Feb 2018 13:33:36 -0500 - rev 457820
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
servo: Merge #19974 - style: Optimize serialization of identifiers of length <= 16 🐉🐲 (from emilio:atom-serialization); r=nox Much like we optimize to_ascii_lowercase. Source-Repo: https://github.com/servo/servo Source-Revision: a0e4ea9f56947e9e47397984566e3e0cb5c3561e
c93f28ff0d54c3ddbca9ba381cc039de1754b008: servo: Merge #19981 - style: Derive ToCss for FontFamilyList (from emilio:nicer); r=nox
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 07 Feb 2018 12:42:18 -0500 - rev 457804
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
servo: Merge #19981 - style: Derive ToCss for FontFamilyList (from emilio:nicer); r=nox The extra reference in to_css is needed because the family list iterator returns by value in Gecko. Source-Repo: https://github.com/servo/servo Source-Revision: 10552c23fc6c81b37bcfcba8f35430fc8d6a0ea8
2f5e8c2dbbc1f7f2fda0605d94a9c60111d90694: servo: Merge #19966 - style: Get rid of gecko_size_type (from emilio:bye-gecko-size); r=nox
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 06 Feb 2018 21:15:07 -0500 - rev 457657
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
servo: Merge #19966 - style: Get rid of gecko_size_type (from emilio:bye-gecko-size); r=nox It's a hack, should die. Source-Repo: https://github.com/servo/servo Source-Revision: dc446198a733cab3416aaccdd13bf6e86ffeb294
211f446b6a7b838491d43fc427c38b89712ed687: servo: Merge #19964 - style: Don't serialize default values of the font shorthand (from emilio:font-shorthand); r=nox
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 06 Feb 2018 16:42:23 -0500 - rev 457647
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
servo: Merge #19964 - style: Don't serialize default values of the font shorthand (from emilio:font-shorthand); r=nox This makes us consistent with the old style system and Blink / WebKit. Not adding a test because shorthands serialization is a mess... :( Anyway, nothing like fixing bugs by removing code. Bug: 1436031 Source-Repo: https://github.com/servo/servo Source-Revision: dde15d8d6511bfb1440afeff5135757611b96a6c
ccd78a8068090f51db6b2c48ad69cdb114ddfcde: servo: Merge #19935 - style: Cleanup StyleBuilder (from emilio:cleanup-style-builder); r=nox
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 03 Feb 2018 12:24:23 -0500 - rev 457361
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
servo: Merge #19935 - style: Cleanup StyleBuilder (from emilio:cleanup-style-builder); r=nox style: Cleanup StyleBuilder. This is in preparation of a cascade optimization for custom properties. This fixes various fishiness around our StyleBuilder stuff. In particular, StyleBuilder::for_derived_style (renamed to for_animation) is only used to compute specified values, and thus doesn't need to know about rules, visited style, or other things like that. The flag propagation that was done in StyleAdjuster is now done in StyleBuilder, since we know beforehand which ones are always inherited, and it simplified the callers and the StyleAdjuster code. It also fixed some fishiness wrt which flags were propagated to anon boxes and text. Source-Repo: https://github.com/servo/servo Source-Revision: a0d9d3633b99c01868c98d2a5e64bf311f532d58
a60f6ad1415e9f865dbab134da92aa575bb97e63: servo: Merge #19923 - style: Cleanup and remove unused / dubious Length stuff (from emilio:less-crappy-code); r=nox
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 01 Feb 2018 10:27:57 -0600 - rev 457110
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
servo: Merge #19923 - style: Cleanup and remove unused / dubious Length stuff (from emilio:less-crappy-code); r=nox style: Cleanup and remove unused / dubious Length stuff. On top of #19918, turns out that the parse_numbers_are_pixels stuff is unused. Source-Repo: https://github.com/servo/servo Source-Revision: a07002a0f0547c1da9043d9e02a308edb0d54232
05d667efdfb8639bf21a4b93b9f641ab672b5b78: servo: Merge #19918 - style: Refactor font-feature-settings and font-variation-settings (from emilio:font-stuff-is-a-mess); r=nox
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 01 Feb 2018 06:45:20 -0600 - rev 457057
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
servo: Merge #19918 - style: Refactor font-feature-settings and font-variation-settings (from emilio:font-stuff-is-a-mess); r=nox This fixes all known issues with serialization and parsing of these two properties, and in particular calc handling and such: https://bugzilla.mozilla.org/show_bug.cgi?id=1434692 https://bugzilla.mozilla.org/show_bug.cgi?id=1434724 Also does a fair amount of cleanup and all that, which was needed, this code was a mess. There are further cleanups that can be done, like renaming the font-variation-settings animation stuff. Source-Repo: https://github.com/servo/servo Source-Revision: dcd13b857cc5085dcec5047433637af3d9013920