searching for reviewer(nika)
fb5d546bb5b3c583a41225376e3e5a3674f90640: Bug 1535699 - Disable httpResponseProcessSelection on Fx67 for now. r=nika a=pascalc
Andrew Sutherland <asutherland@asutherland.org> - Mon, 13 May 2019 21:59:35 +0300 - rev 526542
Push 2033 by apavel@mozilla.com at Mon, 13 May 2019 19:02:02 +0000
Bug 1535699 - Disable httpResponseProcessSelection on Fx67 for now. r=nika a=pascalc Summary: This change also alters the test we added in bug 1535699 so that if the http process selection pref is disabled and parent intercept is not enabled, we expect the page to not migrate out of the file process. Reviewers: nika Bug #: 1535699 Differential Revision: https://phabricator.services.mozilla.com/D30685
d7e6f0c8a9db25034d5c2766b04be20e47cf4fe1: Bug 1535699 - Disable httpResponseProcessSelection on Fx67 for now. r=nika a=pascalc
Andrew Sutherland <asutherland@asutherland.org> - Sun, 12 May 2019 05:11:28 +0300 - rev 526535
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1535699 - Disable httpResponseProcessSelection on Fx67 for now. r=nika a=pascalc Reviewers: nika Bug #: 1535699 Differential Revision: https://phabricator.services.mozilla.com/D30685
b476772da6b0bcb6331b98cedfbdc3faae72388f: Bug 1541038 - Part 1: Sync a BrowsingContext to it's groups. r=nika a=pascalc
Andreas Farre <farre@mozilla.com> - Sun, 21 Apr 2019 03:13:27 +0300 - rev 526264
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1541038 - Part 1: Sync a BrowsingContext to it's groups. r=nika a=pascalc Reviewers: nika Reviewed By: nika Subscribers: reviewbot Bug #: 1541038 Differential Revision: https://phabricator.services.mozilla.com/D27317
661df9ccbd0de5eda56c3cf0a766c2ddcee3abbe: Bug 1541088 - Revert focus-related Fission event delivery changes on beta. r=nika a=pascalc
Henri Sivonen <hsivonen@hsivonen.fi> - Tue, 09 Apr 2019 10:08:51 +0200 - rev 526107
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1541088 - Revert focus-related Fission event delivery changes on beta. r=nika a=pascalc This changeset reverts: * Bug 1524231 - Find TabParent to dispatch to by LayersId attached to the event. * Bug 1532334 - Make nsContentUtils::IsSubDocumentTabbable() return true for out-of-process iframes. * Bug 1524980 - Use RemoteFrameChild if present in nsFocusManager::Focus(). * Bug 1524977 - Use RemoteFrameChild if present in nsFocusManager::GetNextTabbableContent(). * Bug 1534258 - Send Deactivate() messages to out-of-process iframes. * Bug 1534255 - Enable out-of-process iframes to take APZ focus. Differential Revision: https://phabricator.services.mozilla.com//D26689
ec16cfd2ee8e2998a8d07e8fd3dd5215ba8b4d55: Bug 1535282 - Add logging of content process-level focus changes. r=nika
Henri Sivonen <hsivonen@hsivonen.fi> - Thu, 14 Mar 2019 15:55:35 +0000 - rev 524906
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1535282 - Add logging of content process-level focus changes. r=nika Depends on D22468 Differential Revision: https://phabricator.services.mozilla.com/D23479
0bc302ab1f25b03e78fd4bc2443bcb0d450bfaa2: Bug 1522713 - Don't change node binding to tree when updating remoteness; r=nika
Kyle Machulis <kyle@nonpolynomial.com> - Thu, 14 Mar 2019 00:52:02 +0000 - rev 524819
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1522713 - Don't change node binding to tree when updating remoteness; r=nika Since we now have a method on nsFrameLoaderOwner/MozFrameLoaderOwner that can update remoteness, we should no longer need to unbind and rebind browser elements to the tree to change their remoteness attributes. We can just call the method and have the Frameloaders rebuilt in the backend. We're still getting some test breakage in Marionette and browser chrome with this patch. Putting this behind a pref so the fission team can still work with it while the tests are being fixed. Depends on D22790 Differential Revision: https://phabricator.services.mozilla.com/D22791
bade3af814f6ff96bfac9a35e07b6c0dd1fb8f79: Bug 1522713 - Allow updating of Frameloader Remoteness via FrameLoaderOwner; r=nika
Kyle Machulis <kyle@nonpolynomial.com> - Thu, 14 Mar 2019 01:25:07 +0000 - rev 524818
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1522713 - Allow updating of Frameloader Remoteness via FrameLoaderOwner; r=nika Adds a method for to nsFrameLoaderOwner destroying and rebuilding a FrameLoader in order to facilitate a process switch. Method works without requiring that the work be done in the frontend. Depends on D22789 Differential Revision: https://phabricator.services.mozilla.com/D22790
d63e984effadd381fc8a21b188a33e4a8f9caead: Bug 1522713 - Rename mRemoteFrame to mIsRemoteFrame; r=nika
Kyle Machulis <kyle@nonpolynomial.com> - Thu, 14 Mar 2019 00:51:58 +0000 - rev 524817
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1522713 - Rename mRemoteFrame to mIsRemoteFrame; r=nika We have mRemoteFrameChild which owns a RemoteFrameChild, but mRemoteFrame is just a state. Change to mIsRemoteFrame to reflect this. Differential Revision: https://phabricator.services.mozilla.com/D22789
0eb7cd7c505a9617663ee8877a92bfab0a108f0d: Bug 1524709 - Remove aShouldBeRemote from updateBrowserRemoteness; r=nika
Kyle Machulis <kyle@nonpolynomial.com> - Thu, 14 Mar 2019 00:51:30 +0000 - rev 524805
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1524709 - Remove aShouldBeRemote from updateBrowserRemoteness; r=nika Just set the RemoteType in the options object argument, instead of doubling up the information. Differential Revision: https://phabricator.services.mozilla.com/D23250
685feec7f812c0d56b6e3ac49c5a8517ba90f46f: Bug 1535105 - Two very minor cleanups in nsGlobalWindowOuter.cpp. r=nika
Andrew McCreight <continuation@gmail.com> - Wed, 13 Mar 2019 20:37:08 +0000 - rev 524770
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1535105 - Two very minor cleanups in nsGlobalWindowOuter.cpp. r=nika mDocShell is now a strong reference, and it does not need to be explicitly initialized in the constructor because it is an nsCOMPtr. Differential Revision: https://phabricator.services.mozilla.com/D23376
e8c317d99a9981648624d28f9bac5dd6fc7b1ad0: Bug 1525036 - Respect CrossOriginPolicy in nsHttpChannel r=nika
Valentin Gosu <valentin.gosu@gmail.com> - Tue, 12 Mar 2019 08:05:03 +0000 - rev 524503
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1525036 - Respect CrossOriginPolicy in nsHttpChannel r=nika Differential Revision: https://phabricator.services.mozilla.com/D21415
b77be7643141a8f3646257e599b38a3be862e6e0: Bug 1525036 - Respect CrossOriginPolicy in Fetch r=nika
Valentin Gosu <valentin.gosu@gmail.com> - Tue, 12 Mar 2019 08:04:44 +0000 - rev 524502
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1525036 - Respect CrossOriginPolicy in Fetch r=nika Differential Revision: https://phabricator.services.mozilla.com/D21416
fb2aeeed63c7148e203528b929ff44b121b0f010: Bug 1525036 - Add pref for Cross-Origin policy r=nika
Valentin Gosu <valentin.gosu@gmail.com> - Tue, 12 Mar 2019 08:04:15 +0000 - rev 524501
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1525036 - Add pref for Cross-Origin policy r=nika Differential Revision: https://phabricator.services.mozilla.com/D21417
214ce4ef682ae8e113c3f5604770f05fb2fbb231: Bug 1525036 - Add CrossOriginPolicy to the browsing context r=nika
Valentin Gosu <valentin.gosu@gmail.com> - Tue, 12 Mar 2019 08:04:01 +0000 - rev 524500
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1525036 - Add CrossOriginPolicy to the browsing context r=nika Differential Revision: https://phabricator.services.mozilla.com/D21418
005ab4b76f8c43b8a9a1dd792786b65d4dd4d05a: Bug 1533617 part 4. Mark virtual methods with CAN_RUN_SCRIPT overrides as CAN_RUN_SCRIPT. r=nika
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 11 Mar 2019 14:20:29 +0000 - rev 524385
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1533617 part 4. Mark virtual methods with CAN_RUN_SCRIPT overrides as CAN_RUN_SCRIPT. r=nika Differential Revision: https://phabricator.services.mozilla.com/D22838
341a6a2e52378e01e33d9ce69aa178a391d3ee1c: Bug 1533617 part 3. Add a [can_run_script] xpidl annotation. r=nika
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 11 Mar 2019 15:16:57 +0000 - rev 524384
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1533617 part 3. Add a [can_run_script] xpidl annotation. r=nika Differential Revision: https://phabricator.services.mozilla.com/D22837
48241ea6a125e5ec01dbb323da92adabfb4ea480: Bug 1532725 - Rename PRemoteFrame to PBrowserBridge. r=nika
Ryan Hunt <rhunt@eqrion.net> - Mon, 04 Mar 2019 20:15:58 -0600 - rev 524233
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1532725 - Rename PRemoteFrame to PBrowserBridge. r=nika Differential Revision: https://phabricator.services.mozilla.com/D22132
6717beb3ac5349f33e4bcc3bbddc46feb5146067: Bug 1525036 - Add CrossOriginPolicy to the browsing context r=nika
Valentin Gosu <valentin.gosu@gmail.com> - Fri, 08 Mar 2019 15:34:54 +0000 - rev 524163
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1525036 - Add CrossOriginPolicy to the browsing context r=nika Differential Revision: https://phabricator.services.mozilla.com/D21418
0c05686bd62a99563a064af0eeaadc40db80a46d: Bug 1525036 - Add pref for Cross-Origin policy r=nika
Valentin Gosu <valentin.gosu@gmail.com> - Fri, 08 Mar 2019 15:34:16 +0000 - rev 524162
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1525036 - Add pref for Cross-Origin policy r=nika Differential Revision: https://phabricator.services.mozilla.com/D21417
502b0bb796cdf7715a286fa013653728ebb352e6: Bug 1525036 - Respect CrossOriginPolicy in Fetch r=nika
Valentin Gosu <valentin.gosu@gmail.com> - Fri, 08 Mar 2019 15:34:06 +0000 - rev 524161
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1525036 - Respect CrossOriginPolicy in Fetch r=nika Differential Revision: https://phabricator.services.mozilla.com/D21416
fa0363d33dbd074afe05a3278617d368e4d13aa1: Bug 1525036 - Respect CrossOriginPolicy in nsHttpChannel r=nika
Valentin Gosu <valentin.gosu@gmail.com> - Fri, 08 Mar 2019 15:33:56 +0000 - rev 524160
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1525036 - Respect CrossOriginPolicy in nsHttpChannel r=nika Differential Revision: https://phabricator.services.mozilla.com/D21415
6391f42aaa6d59c51c81c2da0681243a463a8012: Bug 1525036 - Add Test for Cross-Origin header policy r=nika
Valentin Gosu <valentin.gosu@gmail.com> - Fri, 08 Mar 2019 15:33:49 +0000 - rev 524159
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1525036 - Add Test for Cross-Origin header policy r=nika Differential Revision: https://phabricator.services.mozilla.com/D21414
a1358865bc47de8389ed09c16c5f205980601d12: Bug 1533401 - Use native maybe support IPDL in JSWindowActorEventDecl instead of two booleans, r=nika
John Dai <jdai@mozilla.com> - Thu, 07 Mar 2019 15:11:32 +0000 - rev 523836
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1533401 - Use native maybe support IPDL in JSWindowActorEventDecl instead of two booleans, r=nika Differential Revision: https://phabricator.services.mozilla.com/D22509
5fdc6018b45ba5b8dfd202d3b2ffb46aa20d06f7: Bug 1531837 - Part 2: Add testcase with allFrames and includeChrome for JS Window Actors, r=nika
John Dai <jdai@mozilla.com> - Thu, 07 Mar 2019 15:13:44 +0000 - rev 523833
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1531837 - Part 2: Add testcase with allFrames and includeChrome for JS Window Actors, r=nika Depends on D22472 Differential Revision: https://phabricator.services.mozilla.com/D22473
dc0a6a6383984ea1b60fe9dde982620e3869be1a: Bug 1531837 - Part 1: Save WindowActorOptions's includeChrome from webidl, r=nika
John Dai <jdai@mozilla.com> - Thu, 07 Mar 2019 15:12:09 +0000 - rev 523832
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1531837 - Part 1: Save WindowActorOptions's includeChrome from webidl, r=nika Differential Revision: https://phabricator.services.mozilla.com/D22472
875bba6627b329803cb02bf0c40d028d0520121b: Bug 1526891 - Part 2: Make it possible to use MozURL by QuotaManager for all URIs (instead of using nsIPrincipal); r=nika,asuth
Jan Varga <jan.varga@gmail.com> - Sat, 23 Feb 2019 10:13:08 +0100 - rev 523813
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1526891 - Part 2: Make it possible to use MozURL by QuotaManager for all URIs (instead of using nsIPrincipal); r=nika,asuth Differential Revision: https://phabricator.services.mozilla.com/D20906
16bf9fd6ae4b46f20bd40e6aaa793729e0b271d5: Bug 1526615 - Part 1: Add support for RealPort and Directory to MozURL; r=nika
Jan Varga <jan.varga@gmail.com> - Sun, 10 Feb 2019 10:20:09 +0100 - rev 523809
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1526615 - Part 1: Add support for RealPort and Directory to MozURL; r=nika Differential Revision: https://phabricator.services.mozilla.com/D19282
e5162aed5ec0228cf24af6c22fa03c5e1963aea9: Bug 1524231 - Find TabParent to dispatch to by LayersId attached to the event. r=nika
Henri Sivonen <hsivonen@hsivonen.fi> - Tue, 05 Mar 2019 19:33:20 +0000 - rev 523367
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1524231 - Find TabParent to dispatch to by LayersId attached to the event. r=nika Depends on D21957 Differential Revision: https://phabricator.services.mozilla.com/D20459
273f979acb0629be9ad8783b488921ba9e92554d: Bug 1532334 - Make nsContentUtils::IsSubDocumentTabbable() return true for out-of-process iframes. r=nika
Henri Sivonen <hsivonen@hsivonen.fi> - Tue, 05 Mar 2019 19:33:18 +0000 - rev 523366
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1532334 - Make nsContentUtils::IsSubDocumentTabbable() return true for out-of-process iframes. r=nika Depends on D21927 Differential Revision: https://phabricator.services.mozilla.com/D21957
627cd6785c62546797d2859a6ff3ea2a50c61df0: Bug 1524980 - Use RemoteFrameChild if present in nsFocusManager::Focus(). r=nika
Henri Sivonen <hsivonen@hsivonen.fi> - Tue, 05 Mar 2019 19:33:52 +0000 - rev 523365
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1524980 - Use RemoteFrameChild if present in nsFocusManager::Focus(). r=nika Depends on D21913 Differential Revision: https://phabricator.services.mozilla.com/D21927
ed8a0908ddf00371f6f629954116fcf2bc6950b1: Bug 1524977 - Use RemoteFrameChild if present in nsFocusManager::GetNextTabbableContent(). r=nika
Henri Sivonen <hsivonen@hsivonen.fi> - Tue, 05 Mar 2019 19:33:09 +0000 - rev 523364
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1524977 - Use RemoteFrameChild if present in nsFocusManager::GetNextTabbableContent(). r=nika Differential Revision: https://phabricator.services.mozilla.com/D21913
c0b27a35fb4cd2607f5e82883c625c0168e40d55: Bug 1527625 - Fill required arguments for ReceiveMessageArgument, r=nika
John Dai <jdai@mozilla.com> - Tue, 05 Mar 2019 17:12:40 +0000 - rev 523284
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1527625 - Fill required arguments for ReceiveMessageArgument, r=nika Differential Revision: https://phabricator.services.mozilla.com/D21987
1c4fb23363e0fca41931986561ff580c129eaa6e: Bug 1441651 - Part 2 - pass Shmem and ByteBuf by rvalref to Send* IPC methods; r=nika,jrmuizel
Alex Gaynor <agaynor@mozilla.com> - Mon, 04 Mar 2019 16:35:30 +0000 - rev 523123
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1441651 - Part 2 - pass Shmem and ByteBuf by rvalref to Send* IPC methods; r=nika,jrmuizel Differential Revision: https://phabricator.services.mozilla.com/D19954
87858af7a3cc594ed1eb1cc86c86ee08f9c76d21: Bug 1441651 - Part 1 - pass Shmem and ByteBuf by rvalref to ParamTraits; r=nika
Alex Gaynor <agaynor@mozilla.com> - Mon, 04 Mar 2019 16:07:37 +0000 - rev 523120
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1441651 - Part 1 - pass Shmem and ByteBuf by rvalref to ParamTraits; r=nika Differential Revision: https://phabricator.services.mozilla.com/D19953
3ff839ce98f5379ae9eb0aaad12117e578d0e9c8: Bug 1526406 - Part 2: Add tests for observers on JS Window Actor Protocols. r=nika
John Dai <jdai@mozilla.com> - Fri, 01 Mar 2019 18:24:58 +0000 - rev 522857
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1526406 - Part 2: Add tests for observers on JS Window Actor Protocols. r=nika Depends on D21364 Differential Revision: https://phabricator.services.mozilla.com/D21365
4cb69524998c9c6fcf1cad71e97bfac91a6a712f: Bug 1526406 - Part 1: Add support for observers to JS Window Actor Protocols. r=nika
John Dai <jdai@mozilla.com> - Fri, 01 Mar 2019 18:24:55 +0000 - rev 522856
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1526406 - Part 1: Add support for observers to JS Window Actor Protocols. r=nika Differential Revision: https://phabricator.services.mozilla.com/D21364
659176e9ffde21b217890c5a75aac8795f002fab: Bug 1527960 - Rename 'browser.fission.oopif.attribute' to 'fission.oopif.attribute'. r=nika
Ryan Hunt <rhunt@eqrion.net> - Fri, 01 Mar 2019 16:54:39 +0000 - rev 522844
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1527960 - Rename 'browser.fission.oopif.attribute' to 'fission.oopif.attribute'. r=nika Differential Revision: https://phabricator.services.mozilla.com/D21716
f41cee9bf14931b453838d1bbcbda528e3b064e8: Bug 1523969 part 6 - Move method definition inline comments to new line in 'dom/'. r=nika
Ryan Hunt <rhunt@eqrion.net> - Mon, 25 Feb 2019 16:05:29 -0600 - rev 522767
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1523969 part 6 - Move method definition inline comments to new line in 'dom/'. r=nika Differential Revision: https://phabricator.services.mozilla.com/D21106
948362bfcaf31849df085dde4967379d4d50a8bc: Bug 1529004 - Add browser.tabs.remote.useCrossOriginOpenerPolicy to all.js r=nika
Valentin Gosu <valentin.gosu@gmail.com> - Tue, 26 Feb 2019 18:54:47 +0000 - rev 522138
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529004 - Add browser.tabs.remote.useCrossOriginOpenerPolicy to all.js r=nika Differential Revision: https://phabricator.services.mozilla.com/D21232
f67d5891bef8d40fdce3c1ad266ff787cd19a4d2: Bug 1530506 - Add a generic writable property bag wrapper for Rust code. r=nika
Lina Cambridge <lina@yakshaving.ninja> - Tue, 26 Feb 2019 21:53:32 +0000 - rev 522136
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1530506 - Add a generic writable property bag wrapper for Rust code. r=nika This commit adds a `storage_variant::HashPropertyBag` type that exposes an idiomatic Rust interface for `nsIWritablePropertyBag`. Differential Revision: https://phabricator.services.mozilla.com/D21062
bd5fbc5d0466775347935f0fd74858d5fb157299: Bug 1529164 - Remove FakePlugin frame loading; r=nika
Kyle Machulis <kyle@nonpolynomial.com> - Wed, 20 Feb 2019 14:12:05 +0000 - rev 521516
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529164 - Remove FakePlugin frame loading; r=nika Remove the ability for fake plugins to create frames. Fake plugins aren't used anymore, so we can simplify nsFrameLoader a bit by removing some of the related checks. Differential Revision: https://phabricator.services.mozilla.com/D20430
1502462b388b017571bc32fa57ed705d1f326b54: Bug 1527505 - Part 11: Avoid looking up the effective TLD service repeatedly inside the permission manager; r=nika
Ehsan Akhgari <ehsan@mozilla.com> - Thu, 21 Feb 2019 22:54:34 +0000 - rev 521356
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1527505 - Part 11: Avoid looking up the effective TLD service repeatedly inside the permission manager; r=nika Depends on D20238 Differential Revision: https://phabricator.services.mozilla.com/D20239
baf310ea412c45b126844e084228a20d4d1ac640: Bug 1527505 - Part 10: Add a variation of TestPermissionFromPrincipal() that knows to not check for the presence of a default pref if the caller knows the permission type doesn't support default prefs, and use it in the anti-tracking backend; r=nika
Ehsan Akhgari <ehsan@mozilla.com> - Thu, 21 Feb 2019 22:54:30 +0000 - rev 521355
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1527505 - Part 10: Add a variation of TestPermissionFromPrincipal() that knows to not check for the presence of a default pref if the caller knows the permission type doesn't support default prefs, and use it in the anti-tracking backend; r=nika This gives us the additional benefit that it will provide a clean inlined path for the common case of testing for permissions from the anti-tracking backend. Depends on D20237 Differential Revision: https://phabricator.services.mozilla.com/D20238
c7260676a0f722ca69f7f99074679eb9f1f75cb7: Bug 1527505 - Part 9: Make nsIPermissionManager accept ACString arguments for permission types instead of raw C strings; r=nika
Ehsan Akhgari <ehsan@mozilla.com> - Thu, 21 Feb 2019 22:54:28 +0000 - rev 521354
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1527505 - Part 9: Make nsIPermissionManager accept ACString arguments for permission types instead of raw C strings; r=nika This will mean that in places like the tight loop in GetTypeIndex() we would no longer require calling strlen() on the input type argument once per loop iteration. Depends on D20236 Differential Revision: https://phabricator.services.mozilla.com/D20237
bebbfddb851f4c8dc249a8b0547c62cbc21041d4: Bug 1527505 - Part 8: Lift the handling of expanded principals out of CommonTestPermissionInternal() into CommonPrepareToTestPermission(); r=nika
Ehsan Akhgari <ehsan@mozilla.com> - Thu, 21 Feb 2019 22:54:26 +0000 - rev 521353
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1527505 - Part 8: Lift the handling of expanded principals out of CommonTestPermissionInternal() into CommonPrepareToTestPermission(); r=nika This patch in the series ensures that the order of operations in recursive invocations of CommonTestPermission() remains consistent compared to before the patch series, even though it is not strictly needed for the performance improvements that the series focuses on. The core idea behind CommonPrepareToTestPermission() now is to do the checks that do not depend on the host name being tested, and for CommonTestPermissionInternal() itself to focus on the rest of the checks, that is looking up our hashtable entry based on the host name being tested, and everything else that's needed from that point on. Depends on D20235 Differential Revision: https://phabricator.services.mozilla.com/D20236
da66636d6d3e41687ad6ff8e0b313f596bd3035e: Bug 1527505 - Part 7: Compute the default permission in the recursive loop only once; r=nika
Ehsan Akhgari <ehsan@mozilla.com> - Thu, 21 Feb 2019 22:54:24 +0000 - rev 521352
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1527505 - Part 7: Compute the default permission in the recursive loop only once; r=nika Depends on D20234 Differential Revision: https://phabricator.services.mozilla.com/D20235
05278d2d4e7348d20f97b2fa26ec0e3b67fbca2f: Bug 1527505 - Part 6: Use inline storage for storing the type array in order to speed up searching though it in the common case; r=nika
Ehsan Akhgari <ehsan@mozilla.com> - Thu, 21 Feb 2019 22:54:16 +0000 - rev 521351
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1527505 - Part 6: Use inline storage for storing the type array in order to speed up searching though it in the common case; r=nika Depends on D20233 Differential Revision: https://phabricator.services.mozilla.com/D20234
6593aa8f25dd8be43bb2161472572db2aee4750d: Bug 1527505 - Part 5: Inline nsPermissionManager::GetTypeIndex(); r=nika
Ehsan Akhgari <ehsan@mozilla.com> - Thu, 21 Feb 2019 22:54:14 +0000 - rev 521350
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1527505 - Part 5: Inline nsPermissionManager::GetTypeIndex(); r=nika Depends on D20232 Differential Revision: https://phabricator.services.mozilla.com/D20233
6d0d4698d35a80e23ac29b619c4570e0867740fd: Bug 1527505 - Part 4: Compute the type index in the recursive loop only once; r=nika
Ehsan Akhgari <ehsan@mozilla.com> - Thu, 21 Feb 2019 22:54:12 +0000 - rev 521349
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1527505 - Part 4: Compute the type index in the recursive loop only once; r=nika This patch alone decreases the runtime of the loop on my machine from about 1700 to 200-400ms ranges. It turns out that computing the type index is the most expensive part. So perhaps we should look into improving that as well. The first thing that comes to mind is whether we can inline the loop in GetTypeIndex(). The next part takes care of that, and it does help a bit. But we need to do more still. The next obvious thing is to optimize the memory access patterns. Right now we iterate over an array of dynamically allocated strings to compare them, which amounts to pointer chasing to read a bit of memory, kind of the worst possible way to access memory. Then we look at replacing that with fully sequential memory reads in the common cases. Depends on D20231 Differential Revision: https://phabricator.services.mozilla.com/D20232
dc3ac9b1a0a8570ed965acad943667b1a73f82e1: Bug 1527505 - Part 3: Compute the origin hash once when storing permissions; r=nika
Ehsan Akhgari <ehsan@mozilla.com> - Thu, 21 Feb 2019 22:54:10 +0000 - rev 521348
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1527505 - Part 3: Compute the origin hash once when storing permissions; r=nika Depends on D20230 Differential Revision: https://phabricator.services.mozilla.com/D20231