searching for reviewer(mstange)
d50a69ba1ac42d978650622f56332fa3201c68b8: Bug 1637112 - Add a wrench reftest. r=mstange, a=dveditz
Nicolas Silva <nsilva@mozilla.com> - Thu, 14 May 2020 17:51:47 +0000 - rev 595133
Push 2335 by ffxbld-merge at Mon, 25 May 2020 13:47:24 +0000
Bug 1637112 - Add a wrench reftest. r=mstange, a=dveditz Differential Revision: https://phabricator.services.mozilla.com/D75305
1f441180b01403e45c532e3e10f9054903adb674: Bug 1637112 - Don't draw border-image segments with zero slice size. r=mstange, a=dveditz
Nicolas Silva <nsilva@mozilla.com> - Wed, 13 May 2020 17:31:25 +0000 - rev 595132
Push 2335 by ffxbld-merge at Mon, 25 May 2020 13:47:24 +0000
Bug 1637112 - Don't draw border-image segments with zero slice size. r=mstange, a=dveditz Differential Revision: https://phabricator.services.mozilla.com/D75119
57b45999b145adced082b05149144c55d0b90ac0: Bug 1635257 - Implement some of nsIAlertsDoNotDisturb for the macOS NotificationCenter backend. r=mstange, a=pascalc
Mike Conley <mconley@mozilla.com> - Sat, 16 May 2020 00:58:29 +0000 - rev 595074
Push 2335 by ffxbld-merge at Mon, 25 May 2020 13:47:24 +0000
Bug 1635257 - Implement some of nsIAlertsDoNotDisturb for the macOS NotificationCenter backend. r=mstange, a=pascalc This doesn't implement manualDoNotDisturb, since we don't want to show the about:preferences option for suppressing notifications on macOS. Differential Revision: https://phabricator.services.mozilla.com/D74243
f5f3a5d324386b1575cfc67de3684ea541436cb2: Bug 1634703 - Add support for getting the window ID used by nsIMediaDevice for a shared window on macOS. r=mstange a=pascalc
Mike Conley <mconley@mozilla.com> - Tue, 12 May 2020 14:50:33 +0000 - rev 595037
Push 2335 by ffxbld-merge at Mon, 25 May 2020 13:47:24 +0000
Bug 1634703 - Add support for getting the window ID used by nsIMediaDevice for a shared window on macOS. r=mstange a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D73482
d393dc7dd956b57bfc4cb0937a03c99e79984035: Bug 1634703 - Add a parent-process-only method to nsIDOMWindowUtils to get the native window ID from a window. r=mstange a=pascalc
Mike Conley <mconley@mozilla.com> - Tue, 12 May 2020 14:50:21 +0000 - rev 595036
Push 2335 by ffxbld-merge at Mon, 25 May 2020 13:47:24 +0000
Bug 1634703 - Add a parent-process-only method to nsIDOMWindowUtils to get the native window ID from a window. r=mstange a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D73481
d7cd1e79d13a618e2a11e1de30dbc84334d91c2c: Bug 1635658. Fix how CSS filters render with webrender that are represented as component transfer when they are required to be represented as SVG filters. r=mstange a=pascalc
Timothy Nikkel <tnikkel@gmail.com> - Thu, 07 May 2020 23:39:56 +0000 - rev 595023
Push 2335 by ffxbld-merge at Mon, 25 May 2020 13:47:24 +0000
Bug 1635658. Fix how CSS filters render with webrender that are represented as component transfer when they are required to be represented as SVG filters. r=mstange a=pascalc The brightness, contrast, and invert css filters are represented as component transfer filters when they required to be represented as an svg filter (ie when an element has a combination of CSS and SVG filters specified). https://hg.mozilla.org/mozilla-central/rev/4f3360c4f104 (bug 1417699) used the value SVG_FECOMPONENTTRANSFER_TYPE_UNKNOWN for the function type in the G and B channels to specify that the R channel function should be used. As we know from https://hg.mozilla.org/mozilla-central/rev/a1ff0af83ad2 (bug 1605223) SVG_FECOMPONENTTRANSFER_TYPE_UNKNOWN is the value we get if the function is not specified, and by spec that is to be interpreted as the identity function. To fix this use a special function type that is not exposed to content, SVG_FECOMPONENTTRANSFER_SAME_AS_R, when we want to do this optimization. And then teach the webrender filter code to understand it. Differential Revision: https://phabricator.services.mozilla.com/D74189
9fcdff1da854a46f48646f2f87d38eea74714847: Bug 1629533: Fix an issue that prevented some icons from drawing in the macOS share menu. r=mstange a=pascalc
Stephen A Pohl <spohl.mozilla.bugs@gmail.com> - Fri, 01 May 2020 22:30:46 +0000 - rev 594938
Push 2335 by ffxbld-merge at Mon, 25 May 2020 13:47:24 +0000
Bug 1629533: Fix an issue that prevented some icons from drawing in the macOS share menu. r=mstange a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D71871
84811ffff4f354fc05a6060ef344c1952370d002: Bug 1609907 - Add AUTO_PROFILER_THREAD_SLEEP around wait_for in DEBUG OffTheBooksCondVar::Wait - r=mstange
Gerald Squelart <gsquelart@mozilla.com> - Fri, 01 May 2020 22:12:56 +0000 - rev 594859
Push 2335 by ffxbld-merge at Mon, 25 May 2020 13:47:24 +0000
Bug 1609907 - Add AUTO_PROFILER_THREAD_SLEEP around wait_for in DEBUG OffTheBooksCondVar::Wait - r=mstange In non-DEBUG builds, `OffTheBooksCondVar::Wait` has `AUTO_PROFILER_THREAD_SLEEP`, but it's not in DEBUG builds. `profiler_thread_sleep` does a `MOZ_ASSERT(mSleep == AWAKE)` in DEBUG builds, so the double call that happens in non-DEBUG wouldn't trigger the assertion! This patch adds `AUTO_PROFILER_THREAD_SLEEP` in DEBUG `OffTheBooksCondVar::Wait`, to catch more misuses during development. Depends on D72851 Differential Revision: https://phabricator.services.mozilla.com/D72852
91ff8fda2596540f3bd01e3a70596074796cd14f: Bug 1609907 - Remove AUTO_PROFILER_THREAD_SLEEP before mozilla::CondVar waits - r=mstange
Gerald Squelart <gsquelart@mozilla.com> - Fri, 01 May 2020 22:12:22 +0000 - rev 594858
Push 2335 by ffxbld-merge at Mon, 25 May 2020 13:47:24 +0000
Bug 1609907 - Remove AUTO_PROFILER_THREAD_SLEEP before mozilla::CondVar waits - r=mstange CondVar already calls `AUTO_PROFILER_THREAD_SLEEP`, which shouldn't be called recursively. mozilla::Monitor also uses CondVar, so it shouldn't be surrounded by `AUTO_PROFILER_THREAD_SLEEP` either. Depends on D72850 Differential Revision: https://phabricator.services.mozilla.com/D72851
5fb91d34f34e3046171dd46d06b84b3cafa3e7f9: Bug 1633718 - Make sure not to call OpenThemeData if it failed before. r=mstange
Toshihito Kikuchi <tkikuchi@mozilla.com> - Thu, 30 Apr 2020 21:28:21 +0000 - rev 594442
Push 2335 by ffxbld-merge at Mon, 25 May 2020 13:47:24 +0000
Bug 1633718 - Make sure not to call OpenThemeData if it failed before. r=mstange As bug 1544435, we blocked wbload.dll from being loaded in content processes. Because that modules is injected via `user32!RegisterUserApiHook` and Windows keeps trying to load hooking modules even if the previous attempt has failed, blocking wbload.dll caused repetitive loading attempts in the tab process, resulting in bad rendering performance. This patch is to mitigate that performance issue by not calling `OpenThemeData`, which is one of the entrypoints triggering user api hook, if the previous call has failed. With this patch, performance is still slower than with the default theme. We will seek out a long-term solution to solve the issue. Differential Revision: https://phabricator.services.mozilla.com/D73344
f44bb30dd8a2273a3d46ba1b9e5920cfbd4d52da: Bug 1630732 - Disable moving windows to a different space when the 'screensHaveSeparateSpaces' configuration option is set in Mission Control on Mac OSX. r=mstange
Mike de Boer <mdeboer@mozilla.com> - Thu, 30 Apr 2020 16:40:11 +0000 - rev 594105
Push 2335 by ffxbld-merge at Mon, 25 May 2020 13:47:24 +0000
Bug 1630732 - Disable moving windows to a different space when the 'screensHaveSeparateSpaces' configuration option is set in Mission Control on Mac OSX. r=mstange Differential Revision: https://phabricator.services.mozilla.com/D72169
078ec53cf0f5a006c36b702470107feb5cf1992f: Bug 1626570 - Improve handling of copying arrays in tools/profiler/gecko. r=mstange
Simon Giesecke <sgiesecke@mozilla.com> - Thu, 30 Apr 2020 09:36:07 +0000 - rev 593997
Push 2335 by ffxbld-merge at Mon, 25 May 2020 13:47:24 +0000
Bug 1626570 - Improve handling of copying arrays in tools/profiler/gecko. r=mstange Differential Revision: https://phabricator.services.mozilla.com/D72317
d2be0e1d228b7224ed13802c96a2ac0de4f99f81: Bug 1530419 - Move PROFILER_AUTO_THREAD_SLEEP into WinUtils::WaitForMessage from callers - r=mstange
Gerald Squelart <gsquelart@mozilla.com> - Tue, 28 Apr 2020 16:22:13 +0000 - rev 593691
Push 2335 by ffxbld-merge at Mon, 25 May 2020 13:47:24 +0000
Bug 1530419 - Move PROFILER_AUTO_THREAD_SLEEP into WinUtils::WaitForMessage from callers - r=mstange Both `nsAppShell::ProcessNextNativeEvent()` and `MessagePumpForUI::WaitForWork()` have a `PROFILER_AUTO_THREAD_SLEEP` surrounding the `mozilla::widget::WinUtils::WaitForMessage()` call. However inside `WaitForMessage()` the call to `PeekMessageW()` may trigger a sequence of events (because the system delivers pending messages) that end in the initialization of a new thread, which invokes `ReentrantMonitor::Wait()` where there is a `PROFILER_AUTO_THREAD_SLEEP`. To avoid this recursion, this patch moves `PROFILER_AUTO_THREAD_SLEEP` from both callers into `WaitForMessage()` to only enclose the actual potentially-sleeping operation `::MsgWaitForMultipleObjectsEx()`. Differential Revision: https://phabricator.services.mozilla.com/D72850
38ffc6215bbf932fc3404c5606f3fc8e8dec4002: Bug 1556556 - Update test expectations for tests which are now passing. r=mstange
Botond Ballo <botond@mozilla.com> - Tue, 28 Apr 2020 01:43:09 +0000 - rev 593507
Push 2335 by ffxbld-merge at Mon, 25 May 2020 13:47:24 +0000
Bug 1556556 - Update test expectations for tests which are now passing. r=mstange Differential Revision: https://phabricator.services.mozilla.com/D69642
03c2c25d8023135c7f74e36030aa5647e2f8f6de: Bug 1556556 - Update test expectations for elementTiming.html. r=mstange
Botond Ballo <botond@mozilla.com> - Tue, 28 Apr 2020 01:43:02 +0000 - rev 593506
Push 2335 by ffxbld-merge at Mon, 25 May 2020 13:47:24 +0000
Bug 1556556 - Update test expectations for elementTiming.html. r=mstange This test is failing due to the rounding error described in bug 1627365. As this is a web platform test, it seems inappropriate to modify the test itself upstream to avoid a Firefox-specific rounding error. Differential Revision: https://phabricator.services.mozilla.com/D69641
93190ae4f5ffd4b9f8a8cfa2a5d4f67898c6b085: Bug 1556556 - Use the "relative to layout viewport" flag to determine when to divide the composition bounds clip by the resolution. r=mstange
Botond Ballo <botond@mozilla.com> - Tue, 28 Apr 2020 01:38:00 +0000 - rev 593496
Push 2335 by ffxbld-merge at Mon, 25 May 2020 13:47:24 +0000
Bug 1556556 - Use the "relative to layout viewport" flag to determine when to divide the composition bounds clip by the resolution. r=mstange We were using "during event delivery" as a proxy for this, but it was an inaccurate proxy. Differential Revision: https://phabricator.services.mozilla.com/D68915
a7bd34d961bbdf9783e7b6e21137c671495c06c9: Bug 1556556 - Add a "relative to layout viewport" option for display list building. r=mstange,mattwoodrow
Botond Ballo <botond@mozilla.com> - Tue, 28 Apr 2020 01:37:47 +0000 - rev 593495
Push 2335 by ffxbld-merge at Mon, 25 May 2020 13:47:24 +0000
Bug 1556556 - Add a "relative to layout viewport" option for display list building. r=mstange,mattwoodrow Use it in document.elementFromPoint(). Differential Revision: https://phabricator.services.mozilla.com/D68914
fccd1d3c71891e695939bf082a21a8c182411037: Bug 1556556 - Remove many uses of IgnoreRootScrollFrame. r=mstange
Botond Ballo <botond@mozilla.com> - Tue, 28 Apr 2020 02:25:51 +0000 - rev 593494
Push 2335 by ffxbld-merge at Mon, 25 May 2020 13:47:24 +0000
Bug 1556556 - Remove many uses of IgnoreRootScrollFrame. r=mstange Differential Revision: https://phabricator.services.mozilla.com/D68913
0e01cc6c7ba91263e548d761af1b0f70fd17c706: Bug 1630781 - Eliminate the frame_delay pref, assume it true everywhere. r=botond,mstange
Kartikaya Gupta <kgupta@mozilla.com> - Sat, 25 Apr 2020 00:47:54 +0000 - rev 593292
Push 2335 by ffxbld-merge at Mon, 25 May 2020 13:47:24 +0000
Bug 1630781 - Eliminate the frame_delay pref, assume it true everywhere. r=botond,mstange Having to think about multiple codepaths adds complexity and it doesn't seem like we're going to turn this pref back off anytime soon. Differential Revision: https://phabricator.services.mozilla.com/D72040
47afa4ab35f8ed7aee5f23419d6c677d4aa7f527: Bug 1632972 - Fix logic to detect the main executable. r=mstange
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 25 Apr 2020 10:11:28 +0000 - rev 593166
Push 2335 by ffxbld-merge at Mon, 25 May 2020 13:47:24 +0000
Bug 1632972 - Fix logic to detect the main executable. r=mstange This is how my mapfile looks like: 5587df936000-5587df96b000 r--p 00000000 fd:02 21584889 /home/emilio/src/moz/gecko/obj-debug/dist/bin/firefox 5587df96b000-5587df9ec000 r-xp 00035000 fd:02 21584889 /home/emilio/src/moz/gecko/obj-debug/dist/bin/firefox 5587df9ec000-5587df9ed000 r--p 000b6000 fd:02 21584889 /home/emilio/src/moz/gecko/obj-debug/dist/bin/firefox 5587df9ed000-5587df9ee000 rw-p 000b7000 fd:02 21584889 /home/emilio/src/moz/gecko/obj-debug/dist/bin/firefox Note how the executable bit, which is the only one we look at, and which is where we get exeExeAddr from (0x5587df96b000 in this case) is in the middle of the executable, but the library will span all four ranges. Check for whether the library _contains_ the start address of the executable region instead of whether it starts with it. Differential Revision: https://phabricator.services.mozilla.com/D72504
0d2e6a6fc291e8c11c1e8b61048d8d4d80ac76db: Bug 1578917: Force macOS Aqua appearance on for content processes, crash reporter and updater. r=mstange
Stephen A Pohl <spohl.mozilla.bugs@gmail.com> - Fri, 24 Apr 2020 18:37:57 +0000 - rev 593099
Push 2335 by ffxbld-merge at Mon, 25 May 2020 13:47:24 +0000
Bug 1578917: Force macOS Aqua appearance on for content processes, crash reporter and updater. r=mstange Differential Revision: https://phabricator.services.mozilla.com/D70783
9cb108e61565be0bc386357ba0f14fdedf787148: Bug 1621478 - Drop mPropagateComponentAlphaFlattening. r=mstange
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Thu, 23 Apr 2020 00:47:26 +0000 - rev 592623
Push 2335 by ffxbld-merge at Mon, 25 May 2020 13:47:24 +0000
Bug 1621478 - Drop mPropagateComponentAlphaFlattening. r=mstange It hasn't been used since bug 1435643. Differential Revision: https://phabricator.services.mozilla.com/D66334
aea2e9528212cae57aad107d7d9224c2283587f5: Bug 1621478 - Drop the comment for |aSolidColor| argument from PaintedLayerData::Accumulate. r=mstange
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Thu, 23 Apr 2020 00:47:07 +0000 - rev 592622
Push 2335 by ffxbld-merge at Mon, 25 May 2020 13:47:24 +0000
Bug 1621478 - Drop the comment for |aSolidColor| argument from PaintedLayerData::Accumulate. r=mstange The argument was dropped in bug 945203. Differential Revision: https://phabricator.services.mozilla.com/D66333
887f1769a2c67bdf5796bc8948f41b3afa3cb3f6: Bug 1609446 - Make default window-constraints always show the content. r=mats,mstange
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 15 Apr 2020 01:44:25 +0000 - rev 591154
Push 2335 by ffxbld-merge at Mon, 25 May 2020 13:47:24 +0000
Bug 1609446 - Make default window-constraints always show the content. r=mats,mstange This code is used to determine the sizes of the top-level windows. However the code doesn't cause quite desirable behavior (see the bug, and comment 15). This patch does two things: * Unifies the html / xul code-paths. This shouldn't change behavior (because GetXULMinSize returns the fixed min-* property if present anyways), but makes the patch a bit simpler. * Makes the min-width of the XUL window be the pref size instead of the min-size (for the cases where you have no explicit min-width). This looks a bit counter intuitive, but it's the only way to guarantee that the content will be shown. This matches the sizing algorithm that dialogs use by default (via calling window.sizeToContent()), while allowing to undersize the window via a fixed min-width property. This in turn makes sizeToContent() work "by default" on XUL windows, avoiding having to make JS listen to everything that possibly could change the layout of the document (like resolution changes). Differential Revision: https://phabricator.services.mozilla.com/D70209
dab0d23256d7805f96a4630ae202c9446d41d2dc: Bug 1624532. Handle incomplete masks on svg content properly with webrender. r=mstange,jrmuizel
Timothy Nikkel <tnikkel@gmail.com> - Tue, 14 Apr 2020 17:08:52 +0000 - rev 591026
Push 2335 by ffxbld-merge at Mon, 25 May 2020 13:47:24 +0000
Bug 1624532. Handle incomplete masks on svg content properly with webrender. r=mstange,jrmuizel The basic problem here for the page is that we should draw an svg element as if it has no mask specified if the specified mask is display: none. (For html elements in the same situation we should not draw the html element at all.) The fix is to treat the return values of PaintMaskSurface (which come through nsSVGIntegrationUtils::PaintMask and nsDisplayMasksAndClipPaths::PaintMask) in WebRenderCommandBuilder::BuildWrMaskImage the same way as in CreateAndPaintMaskSurface. Differential Revision: https://phabricator.services.mozilla.com/D70596
37cd04f0b502e033bb790a8911bbecb48e2b841b: Bug 1628988. Don't apply ImgDrawResult::NOT_READY in PaintMaskSurface. r=mstange
Timothy Nikkel <tnikkel@gmail.com> - Mon, 13 Apr 2020 20:08:05 +0000 - rev 590799
Push 2335 by ffxbld-merge at Mon, 25 May 2020 13:47:24 +0000
Bug 1628988. Don't apply ImgDrawResult::NOT_READY in PaintMaskSurface. r=mstange PaintMaskSurface shouldn't be applying ImgDrawResult::NOT_READY when we don't have a frame and the mask image hasn't been resolved. ImgDrawResult is only about drawing images, not about waiting for external resources to resolve or frames to get constructed. The only purpose of tracking ImgDrawResult's in painting code is to know which frames we need to invalidate because their rendering might change if we sync decode images during a Draw call. Applying NOT_READY here means we invalidate for every paint with the sync decode images flag (ie reftest paints), and it never changes from NOT_READY. This bites the reftest for this bug 1624532. To fix it, instead of "overloading" the ImgDrawResult we return a bool to indicate the mask is missing or incomplete. Differential Revision: https://phabricator.services.mozilla.com/D70595
241aa49e1c23023e46b4d17375d3b9a19b125db9: Bug 1627460 - Add markers for ImportScripts and require in workers, r=mstange.
Florian Quèze <florian@queze.net> - Thu, 09 Apr 2020 10:10:38 +0000 - rev 590277
Push 2335 by ffxbld-merge at Mon, 25 May 2020 13:47:24 +0000
Bug 1627460 - Add markers for ImportScripts and require in workers, r=mstange. Differential Revision: https://phabricator.services.mozilla.com/D69711
a876822484b0d51fd90decb354062d8c2868b0b7: Bug 1627490 - Replace MOZ_MUST_USE with [[nodiscard]] in tools/profiler. r=mstange
Chris Peterson <cpeterson@mozilla.com> - Tue, 07 Apr 2020 18:38:52 +0000 - rev 590133
Push 2335 by ffxbld-merge at Mon, 25 May 2020 13:47:24 +0000
Bug 1627490 - Replace MOZ_MUST_USE with [[nodiscard]] in tools/profiler. r=mstange Also move MOZ_MUST_USE before function declarations' specifiers and return type. While clang and gcc's __attribute__((warn_unused_result)) can appear before, between, or after function specifiers and return types, the [[nodiscard]] attribute must precede the function specifiers. Differential Revision: https://phabricator.services.mozilla.com/D69739
36e331c78398676385233cb06a6b4d670b83dd8e: Bug 890125 - Part 2 - Convert the OSX Spaces handling to accept string-type workspace IDs. r=mstange,nika
Mike de Boer <mdeboer@mozilla.com> - Tue, 07 Apr 2020 11:02:10 +0000 - rev 590014
Push 2335 by ffxbld-merge at Mon, 25 May 2020 13:47:24 +0000
Bug 890125 - Part 2 - Convert the OSX Spaces handling to accept string-type workspace IDs. r=mstange,nika Differential Revision: https://phabricator.services.mozilla.com/D67823
925ec3ed99a48d5188d0bba91f66e4c4afc83bc7: Bug 1424714 - Add a test to ensure sticky position items don't checkerboard unnecessarily. r=mstange
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 08 Apr 2020 05:03:09 +0000 - rev 590007
Push 2335 by ffxbld-merge at Mon, 25 May 2020 13:47:24 +0000
Bug 1424714 - Add a test to ensure sticky position items don't checkerboard unnecessarily. r=mstange Depends on D68582 Differential Revision: https://phabricator.services.mozilla.com/D68583
840f340afe5a3d256b76382646749c27e6ef11eb: Bug 1424714 - Prevent the displayport clip from clipping sticky items. r=mstange
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 08 Apr 2020 04:59:14 +0000 - rev 590006
Push 2335 by ffxbld-merge at Mon, 25 May 2020 13:47:24 +0000
Bug 1424714 - Prevent the displayport clip from clipping sticky items. r=mstange The displayport clip that is applied to sticky items from the enclosing scrollframe can cause sticky items to checkerboard even when they might reasonably be left visible. This is because the displayport clip moves as the enclosing scrollframe is scrolled, but sticky items may remain fixed during such scrolling. The displayport clip can therefore clip out sticky items even if they are "stuck" and should be user-visible. This patch sets a flag to identify when a sticky item is being clipped by the displayport clip, and ensures that it doesn't actually get clipped. In the case where other clips are being applied to the sticky item, we leave the clips unaffected. This allows for other enclosing elements to clip the sticky item as before. Differential Revision: https://phabricator.services.mozilla.com/D68582
5e45ffaf38e96a17a67645b6a762ddfb40e584d2: Bug 1627460 - Add markers for ImportScripts and require in workers, r=mstange.
Florian Quèze <florian@queze.net> - Tue, 07 Apr 2020 18:39:10 +0000 - rev 590002
Push 2335 by ffxbld-merge at Mon, 25 May 2020 13:47:24 +0000
Bug 1627460 - Add markers for ImportScripts and require in workers, r=mstange. Differential Revision: https://phabricator.services.mozilla.com/D69711
17b15e227d3bd91ab5d8421c491e4d63b25f2c49: Bug 890125 - Part 2 - Convert the OSX Spaces handling to accept string-type workspace IDs. r=mstange,nika
Mike de Boer <mdeboer@mozilla.com> - Mon, 06 Apr 2020 12:56:38 +0000 - rev 589448
Push 2335 by ffxbld-merge at Mon, 25 May 2020 13:47:24 +0000
Bug 890125 - Part 2 - Convert the OSX Spaces handling to accept string-type workspace IDs. r=mstange,nika Differential Revision: https://phabricator.services.mozilla.com/D67823
d7daa6afda13894c134557409587d0bc7c92bbca: Bug 1620549 - Set stack size of profiler sampler thread to 800 KiB r=gerald,mstange
Michael Forney <mforney@mforney.org> - Sat, 04 Apr 2020 00:51:48 +0000 - rev 588898
Push 2321 by ffxbld-merge at Mon, 27 Apr 2020 16:26:39 +0000
Bug 1620549 - Set stack size of profiler sampler thread to 800 KiB r=gerald,mstange N_STACK_BYTES are needed to store backtrace information, so use that plus some extra as the minimum stack size for the sampler thread to ensure that it doesn't overflow. Differential Revision: https://phabricator.services.mozilla.com/D65705
cd850f6d0b0ba957b0ca2d51322b39ec4efca54c: Bug 890125 - Part 2 - Convert the OSX Spaces handling to accept string-type workspace IDs. r=mstange,nika
Mike de Boer <mdeboer@mozilla.com> - Fri, 03 Apr 2020 10:20:20 +0000 - rev 588789
Push 2321 by ffxbld-merge at Mon, 27 Apr 2020 16:26:39 +0000
Bug 890125 - Part 2 - Convert the OSX Spaces handling to accept string-type workspace IDs. r=mstange,nika Differential Revision: https://phabricator.services.mozilla.com/D67823
617edc71b28cf641c2edc545a7bf6a8081e13123: Bug 1625354: Two more switches to a non-deprecated API to load .nib files. r=mstange
Stephen A Pohl <spohl.mozilla.bugs@gmail.com> - Mon, 30 Mar 2020 23:17:27 +0000 - rev 587973
Push 2321 by ffxbld-merge at Mon, 27 Apr 2020 16:26:39 +0000
Bug 1625354: Two more switches to a non-deprecated API to load .nib files. r=mstange Differential Revision: https://phabricator.services.mozilla.com/D68486
bf611fbecbff871560bda3bed2933c4adbd1879a: Bug 1623861: Allow for OS authentication to succeed when no passcode is set. r=mstange
Stephen A Pohl <spohl.mozilla.bugs@gmail.com> - Tue, 31 Mar 2020 00:27:17 +0000 - rev 587971
Push 2321 by ffxbld-merge at Mon, 27 Apr 2020 16:26:39 +0000
Bug 1623861: Allow for OS authentication to succeed when no passcode is set. r=mstange Differential Revision: https://phabricator.services.mozilla.com/D68670
34c1c54b2ec0cbffae046fe4ac066e539a6d6e63: Bug 1625199: Switch to non-deprecated API to load the MainMenu.nib. r=mstange
Stephen A Pohl <spohl.mozilla.bugs@gmail.com> - Thu, 26 Mar 2020 19:56:33 +0000 - rev 587447
Push 2321 by ffxbld-merge at Mon, 27 Apr 2020 16:26:39 +0000
Bug 1625199: Switch to non-deprecated API to load the MainMenu.nib. r=mstange Differential Revision: https://phabricator.services.mozilla.com/D68447
e2f021fe0c3e0f3c0653d153ba1448627471edf7: Bug 1624696 - Respect padding for all elements except checkbox/radio. r=spohl,mstange
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 24 Mar 2020 22:51:26 +0000 - rev 587097
Push 2321 by ffxbld-merge at Mon, 27 Apr 2020 16:26:39 +0000
Bug 1624696 - Respect padding for all elements except checkbox/radio. r=spohl,mstange Only button / menulist-button were missing from the hard-coded if condition. I don't think we ever want to override author padding, and this can cause compat issues as the one in this bug. I'm making HasAuthorSpecifiedRules fast in bug 1624080, btw. Differential Revision: https://phabricator.services.mozilla.com/D68085
f3c5f5a1b35dccaf7d301e1a19653e738f327964: Bug 1624696 - Respect padding for all elements except checkbox/radio. r=spohl,mstange
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 24 Mar 2020 21:02:12 +0000 - rev 587073
Push 2321 by ffxbld-merge at Mon, 27 Apr 2020 16:26:39 +0000
Bug 1624696 - Respect padding for all elements except checkbox/radio. r=spohl,mstange Only button / menulist-button were missing from the hard-coded if condition. I don't think we ever want to override author padding, and this can cause compat issues as the one in this bug. I'm making HasAuthorSpecifiedRules fast in bug 1624080, btw. Differential Revision: https://phabricator.services.mozilla.com/D68085
bd87253f36769290993a833e18caba8644dacd0f: Bug 1623476 - Adjust coordinate values in test_user_select.html. r=mstange
Botond Ballo <botond@mozilla.com> - Mon, 23 Mar 2020 22:22:52 +0000 - rev 586951
Push 2321 by ffxbld-merge at Mon, 27 Apr 2020 16:26:39 +0000
Bug 1623476 - Adjust coordinate values in test_user_select.html. r=mstange The coordinate values are chosen to target the first pixel of a target frame. However, due to rounding error during the event synthesization code path, they can miss the frame by a fraction of a pixel. Differential Revision: https://phabricator.services.mozilla.com/D67520
8b146f14ae8bbcf7ebeafbb03637edb789eea735: Bug 1622113 - Ensure the skip rect end is aligned to a 4-byte boundary. r=mstange
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 21 Mar 2020 00:19:23 +0000 - rev 586725
Push 2321 by ffxbld-merge at Mon, 27 Apr 2020 16:26:39 +0000
Bug 1622113 - Ensure the skip rect end is aligned to a 4-byte boundary. r=mstange So that accesses that use mSkipRect.XMost() - 4 or - 16 are aligned to a 4-byte boundary. Not doing so would crash on some architectures due to a SIGBUS. Differential Revision: https://phabricator.services.mozilla.com/D66748
da7a6d2e34951f2d96aaeb7e7bb5fc7be0c68e2f: Bug 1623684: Force macOS aqua appearance on. r=mstange
Stephen A Pohl <spohl.mozilla.bugs@gmail.com> - Fri, 20 Mar 2020 12:59:19 +0000 - rev 586640
Push 2321 by ffxbld-merge at Mon, 27 Apr 2020 16:26:39 +0000
Bug 1623684: Force macOS aqua appearance on. r=mstange Differential Revision: https://phabricator.services.mozilla.com/D67525
3ea837a4853c678bad40cd220a5dae00894f7911: Bug 1623147 - Don't flush style/frames unconditionally in CanvasRenderingContext2D::UpdateFilter(). r=mstange
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 17 Mar 2020 22:14:43 +0000 - rev 586104
Push 2321 by ffxbld-merge at Mon, 27 Apr 2020 16:26:39 +0000
Bug 1623147 - Don't flush style/frames unconditionally in CanvasRenderingContext2D::UpdateFilter(). r=mstange I saw this in profiles. Differential Revision: https://phabricator.services.mozilla.com/D67225
4bd0143d7cbe6e8271e36f449de2673e70d4b9b4: Bug 1621758 - Fix occlusion rect of clipped compositor surfaces. r=mstange
dev <dev@devs-MacBook-Pro.local> - Thu, 12 Mar 2020 19:41:26 +0000 - rev 585258
Push 2321 by ffxbld-merge at Mon, 27 Apr 2020 16:26:39 +0000
Bug 1621758 - Fix occlusion rect of clipped compositor surfaces. r=mstange Differential Revision: https://phabricator.services.mozilla.com/D66506
d40b5da025001c9580641dd3dd0805e657fe910e: Bug 1620549 - Set stack size of profiler sampler thread to N_STACK_BYTES + 80 KiB r=gerald,mstange
Michael Forney <mforney@mforney.org> - Wed, 11 Mar 2020 21:04:31 +0000 - rev 585073
Push 2321 by ffxbld-merge at Mon, 27 Apr 2020 16:26:39 +0000
Bug 1620549 - Set stack size of profiler sampler thread to N_STACK_BYTES + 80 KiB r=gerald,mstange N_STACK_BYTES are needed to store backtrace information, so use that plus some extra as the minimum stack size for the sampler thread to ensure that it doesn't overflow. Differential Revision: https://phabricator.services.mozilla.com/D65705
867b615582c95b3b7d28c37d3ae9a33990e498e2: Bug 1621319 - Implement GetWidgetBorder properly for some widgets. r=mstange
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 11 Mar 2020 01:52:51 +0000 - rev 584869
Push 2321 by ffxbld-merge at Mon, 27 Apr 2020 16:26:39 +0000
Bug 1621319 - Implement GetWidgetBorder properly for some widgets. r=mstange I've left checkbox / radio / range-thumb alone because they don't have borders on gtk either. We need this for the next patch to fix our test. In particular, our combination of padding + no border means that sanityEventUtils tries to hit an <input>, but it hits the anonymous scrollable element instead, and asserts that it doesn't. I don't think that test is particularly correct, but implementing GetWidgetBorder works around it, and seems like the right thing to do anyways. Differential Revision: https://phabricator.services.mozilla.com/D66240
b57063dccba321ea0a0a61fe8192343deb18fc74: Bug 1621319 - fix test_bug365410.html with non-native theme enabled. r=mstange
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 11 Mar 2020 01:52:54 +0000 - rev 584868
Push 2321 by ffxbld-merge at Mon, 27 Apr 2020 16:26:39 +0000
Bug 1621319 - fix test_bug365410.html with non-native theme enabled. r=mstange Our <select multiple> has enough padding so that both sides take more space that one list item, and since this test sets the height explicitly and <select> has box-sizing: border-box by default, page-up / page-down steps through one less item than what the test expects. I think this is a test bug, but let me know if you want some bug on file to consider reducing this padding for non-native theme. Differential Revision: https://phabricator.services.mozilla.com/D66239
0522121ddf224a265ca97387dc0057f0f1fd1ff9: Bug 1621319 - Implement GetWidgetBorder properly for some widgets. r=mstange
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 10 Mar 2020 19:33:56 +0000 - rev 584783
Push 2321 by ffxbld-merge at Mon, 27 Apr 2020 16:26:39 +0000
Bug 1621319 - Implement GetWidgetBorder properly for some widgets. r=mstange I've left checkbox / radio / range-thumb alone because they don't have borders on gtk either. We need this for the next patch to fix our test. In particular, our combination of padding + no border means that sanityEventUtils tries to hit an <input>, but it hits the anonymous scrollable element instead, and asserts that it doesn't. I don't think that test is particularly correct, but implementing GetWidgetBorder works around it, and seems like the right thing to do anyways. Differential Revision: https://phabricator.services.mozilla.com/D66240
b65f1bde461a6f05de965f842c9a6e9328f51860: Bug 1621319 - fix test_bug365410.html with non-native theme enabled. r=mstange
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 10 Mar 2020 19:33:53 +0000 - rev 584782
Push 2321 by ffxbld-merge at Mon, 27 Apr 2020 16:26:39 +0000
Bug 1621319 - fix test_bug365410.html with non-native theme enabled. r=mstange Our <select multiple> has enough padding so that both sides take more space that one list item, and since this test sets the height explicitly and <select> has box-sizing: border-box by default, page-up / page-down steps through one less item than what the test expects. I think this is a test bug, but let me know if you want some bug on file to consider reducing this padding for non-native theme. Differential Revision: https://phabricator.services.mozilla.com/D66239