searching for reviewer(mhowell)
fa5b6a15761ce4d81f730b756ff595eb91148376: Bug 1552156: Always set launcher pref default value to false; r=mhowell, a=pascalc
Aaron Klotz <aklotz@mozilla.com> - Thu, 16 May 2019 16:58:30 +0000 - rev 526551
Push 2041 by jcristau@mozilla.com at Thu, 16 May 2019 17:34:45 +0000
Bug 1552156: Always set launcher pref default value to false; r=mhowell, a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D31502
a502516c684a08af7f15c206cd269abc2f810255: Bug 1541597: Modify PEHeaders to use NumberOfRvaAndSizes as maximum DataDirectory length; r=mhowell a=pascalc
Aaron Klotz <aklotz@mozilla.com> - Wed, 03 Apr 2019 21:56:24 +0000 - rev 526017
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1541597: Modify PEHeaders to use NumberOfRvaAndSizes as maximum DataDirectory length; r=mhowell a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D26012
7a7eda97a8f280c0cfec5a2968d6d81e2b87999c: Bug 1538218 - Correct REMOVE_DISTRIBUTION_DIR command. r=mhowell a=pascalc
Michael Kaply <mozilla@kaply.com> - Mon, 01 Apr 2019 23:57:14 +0000 - rev 525973
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1538218 - Correct REMOVE_DISTRIBUTION_DIR command. r=mhowell a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D25681
1b9b7c6da0c3454d1434d67a2d143ef56b44d8d8: Bug 1535393 - Fill in the correct MSI version number for release and ESR. r=mhowell,nalexander a=pascalc
Justin Wood <Callek@gmail.com> - Wed, 27 Mar 2019 17:10:58 +0000 - rev 525807
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1535393 - Fill in the correct MSI version number for release and ESR. r=mhowell,nalexander a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D24994
f9de9668b5e87be6b0461ef8c0295f48bc71dcd1: Bug 1531902: Enable launcher process pref on beta; r=mhowell
Aaron Klotz <aklotz@mozilla.com> - Mon, 11 Mar 2019 23:26:00 +0000 - rev 524451
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1531902: Enable launcher process pref on beta; r=mhowell * We remove the launcher process prefs from `firefox.js` and just use defaults at the time we access the pref; * We set the pref to true by default on nightly and beta; * We modify `SetupLauncherProcessPref` to save the initial state of the launcher process to `gLauncherProcessState` to reflect the status of the launcher process *at startup*; * We modify `nxXULAppInfo::GetLauncherProcessState` to call `SetupLauncherProcessPref` as the former may be called from JS ahead of the call to `SetupLauncherProcessPref` that we do in `XRE_mainRun`; * We modify `LauncherRegistryInfo::ReflectPrefToRegistry` to not clobber any registry settings unless the new pref value differs from the previous pref value. We also update the test to reflect this change. Differential Revision: https://phabricator.services.mozilla.com/D21789
b6e605718832c9bec3bb18933f3da8a286843efa: Bug 1531902: Enable launcher process pref on beta; r=mhowell
Aaron Klotz <aklotz@mozilla.com> - Tue, 05 Mar 2019 20:19:43 +0000 - rev 523323
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1531902: Enable launcher process pref on beta; r=mhowell Differential Revision: https://phabricator.services.mozilla.com/D21789
a9bb4a23d4072a2735b50b577f9668728af06d30: Bug 1510276 - Fix GetLongPath so it returns the proper case for the path. r=mhowell
Robert Strong <robert.bugzilla@gmail.com> - Mon, 04 Mar 2019 18:22:54 +0000 - rev 523132
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1510276 - Fix GetLongPath so it returns the proper case for the path. r=mhowell Always uppercase the first char of the path in GetLongPath Remove GetLongPathNameW since it isn't setting the proper case for the path segments below the leaf name Differential Revision: https://phabricator.services.mozilla.com/D21873
2624b1bdee9b2bab41ca9a8c784cf0a7f14c2b7e: Bug 1531160 - Add the original NS_tsnprintf and use a new name for the new function. r=mhowell
Robert Strong <robert.bugzilla@gmail.com> - Thu, 28 Feb 2019 00:33:12 +0000 - rev 522449
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1531160 - Add the original NS_tsnprintf and use a new name for the new function. r=mhowell Differential Revision: https://phabricator.services.mozilla.com/D21468
a09495fb2304c28b55d847f5af99c60565059047: Bug 1530960 - Add return value checks when removing files in updater.cpp. r=mhowell
Robert Strong <robert.bugzilla@gmail.com> - Wed, 27 Feb 2019 21:42:54 +0000 - rev 522412
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1530960 - Add return value checks when removing files in updater.cpp. r=mhowell Differential Revision: https://phabricator.services.mozilla.com/D21396
a20d059fc98bb69acfbe2c18b9a51ba8b920d072: Bug 1530809: Make LaunchElevated use mscom::ProcessRuntime instead of mscom::STARegion; r=mhowell
Aaron Klotz <aklotz@mozilla.com> - Tue, 26 Feb 2019 21:40:59 +0000 - rev 522374
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1530809: Make LaunchElevated use mscom::ProcessRuntime instead of mscom::STARegion; r=mhowell Differential Revision: https://phabricator.services.mozilla.com/D21261
5be3bd53aaade28dbe7c92f1c6174fd303fda3bf: Bug 1530700: Add a missing ifdef MOZ_LAUNCHER_PROCESS block; r=mhowell
Aaron Klotz <aklotz@mozilla.com> - Wed, 27 Feb 2019 11:00:14 +0000 - rev 522373
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1530700: Add a missing ifdef MOZ_LAUNCHER_PROCESS block; r=mhowell Differential Revision: https://phabricator.services.mozilla.com/D21258
86bed3fcf6f50e90e64cbde7b67659a267d6b955: Bug 1530788: Ensure that the launcher process pref remains functional on Nightly; r=mhowell
Aaron Klotz <aklotz@mozilla.com> - Tue, 26 Feb 2019 21:38:08 +0000 - rev 522372
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1530788: Ensure that the launcher process pref remains functional on Nightly; r=mhowell Differential Revision: https://phabricator.services.mozilla.com/D21254
44b0b51ef2143bbb81d47d60fd3ed8a6451751ec: Bug 1530564 - Fix truncation warnings in TestAUSHelper.cpp. r=mhowell
Robert Strong <robert.bugzilla@gmail.com> - Tue, 26 Feb 2019 18:29:18 +0000 - rev 522125
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1530564 - Fix truncation warnings in TestAUSHelper.cpp. r=mhowell Differential Revision: https://phabricator.services.mozilla.com/D21164
dfb53709e5fdb77ef09ff281309afb8eb845a83f: Bug 1530560 - Change NS_tsnprintf to return a bool to indicate success and failure. r=mhowell
Robert Strong <robert.bugzilla@gmail.com> - Tue, 26 Feb 2019 18:28:45 +0000 - rev 522124
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1530560 - Change NS_tsnprintf to return a bool to indicate success and failure. r=mhowell Differential Revision: https://phabricator.services.mozilla.com/D21163
2f5d1c8ec6f3df50a6a452e96f74e8f3033134e3: Bug 1530559 - Include updatedefines.h in TestAUSHelper.cpp and remove the defines that are provided by updatedefines.h. r=mhowell
Robert Strong <robert.bugzilla@gmail.com> - Tue, 26 Feb 2019 18:29:20 +0000 - rev 522123
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1530559 - Include updatedefines.h in TestAUSHelper.cpp and remove the defines that are provided by updatedefines.h. r=mhowell Differential Revision: https://phabricator.services.mozilla.com/D21160
1165806614a45faf998da7ffe8f670e94a5f9030: Bug 1530548 - Move the definition of MAXPATHLEN after includes in updatedefines.h. r=mhowell
Robert Strong <robert.bugzilla@gmail.com> - Tue, 26 Feb 2019 17:35:31 +0000 - rev 522076
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1530548 - Move the definition of MAXPATHLEN after includes in updatedefines.h. r=mhowell Differential Revision: https://phabricator.services.mozilla.com/D21135
c04aa3d7aa8e46bd547d8e0e1a1ac7a88ae3e4c4: Bug 1530240 - (test code only) - TestAUSHelper.cpp coverity fixes. r=mhowell
Robert Strong <robert.bugzilla@gmail.com> - Mon, 25 Feb 2019 17:50:58 -0800 - rev 521991
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1530240 - (test code only) - TestAUSHelper.cpp coverity fixes. r=mhowell Remove unnecessary access check in CheckMsg Change call to strcpy to NS_tsnprintf Add checks for the return value of mkdir, rmdir, chmod, lstat, and unlink
e5e2ac9bb33b81c020b6b7fcc20b706b3f9921f8: Bug 1530240 - (test code only) - TestAUSHelper.cpp coverity fixes. r=mhowell
Robert Strong <robert.bugzilla@gmail.com> - Mon, 25 Feb 2019 16:56:10 -0800 - rev 521978
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1530240 - (test code only) - TestAUSHelper.cpp coverity fixes. r=mhowell Remove unnecessary access check in CheckMsg Change call to strcpy to NS_tsnprintf Add checks for the return value of mkdir, rmdir, chmod, lstat, and unlink
faec87a80ed1e4f50a7961b4dd652a682ef339ce: Bug 1530531: Add a command line option to the launcher process that forces it to log errors to the Windows event log; r=mhowell
Aaron Klotz <aklotz@mozilla.com> - Mon, 25 Feb 2019 23:11:20 +0000 - rev 521893
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1530531: Add a command line option to the launcher process that forces it to log errors to the Windows event log; r=mhowell Differential Revision: https://phabricator.services.mozilla.com/D21099
7f034553129d9dc4a7e634edb58aee2ed32ee7dc: Bug 1460433: Part 2 - Log launcher process failures to a telemetry ping; r=mhowell
Aaron Klotz <aklotz@mozilla.com> - Mon, 25 Feb 2019 21:14:07 +0000 - rev 521865
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1460433: Part 2 - Log launcher process failures to a telemetry ping; r=mhowell This patch does a few things: * Fleshes out the launcher process failure ping; * Sends that ping via pingsender; * If there is any failure in doing so, we fall back to the Windows event log; * Any launcher process failures will result in us falling back to the normal startup code path, ensuring that users will still see a browser. A sample ping will be attached to the bug. Differential Revision: https://phabricator.services.mozilla.com/D19697
7733f36c6e38cf684cf612e81f6b89cad4df3566: Bug 1460433: Part 2 - Log launcher process failures to a telemetry ping; r=mhowell
Aaron Klotz <aklotz@mozilla.com> - Fri, 22 Feb 2019 18:43:18 +0000 - rev 521821
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1460433: Part 2 - Log launcher process failures to a telemetry ping; r=mhowell This patch does a few things: * Fleshes out the launcher process failure ping; * Sends that ping via pingsender; * If there is any failure in doing so, we fall back to the Windows event log; * Any launcher process failures will result in us falling back to the normal startup code path, ensuring that users will still see a browser. A sample ping will be attached to the bug. *** Format cleanup Differential Revision: https://phabricator.services.mozilla.com/D19697
50e17e84f24d4fae03f4b499d7c76fd229d224ea: Bug 1528636 - Enable staging updates on Linux entirely and not just for EARLY_BETA_OR_EARLIER for Firefox 67. r=mhowell
Robert Strong <robert.bugzilla@gmail.com> - Mon, 25 Feb 2019 16:12:10 +0000 - rev 521810
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1528636 - Enable staging updates on Linux entirely and not just for EARLY_BETA_OR_EARLIER for Firefox 67. r=mhowell Differential Revision: https://phabricator.services.mozilla.com/D20975
95d0c10a390cee0b2b10bbc8452960754d88607a: Bug 1502917 - Adding ChromeUtils.RequestProcInfo() - r=Ehsan,mstange,kershaw,mhowell
Tarek Ziadé <tarek@mozilla.com> - Sat, 23 Feb 2019 18:07:59 +0000 - rev 521616
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1502917 - Adding ChromeUtils.RequestProcInfo() - r=Ehsan,mstange,kershaw,mhowell This patch introduces a new module in widget that implements a simple API to retrieve system information about a process and its threads. This function is wrapped into ChromeUtils.RequestProcInfo to return information about processes started by Firefox. The use case for this API is to monitor Firefox resources usage in projects like the battery usage done by the data science team. Differential Revision: https://phabricator.services.mozilla.com/D10069
68c5e68c324415dbd6f014e874ef92e3daf1ef65: Bug 1529043 - Part 10 (test only) - Change IS_SERVICE_TEST into a global var to quiet eslint undefined errors and remove eslint-disable no-undef from xpcshellUtilsAUS.js. r=mhowell
Robert Strong <robert.bugzilla@gmail.com> - Fri, 22 Feb 2019 22:06:15 +0000 - rev 521564
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529043 - Part 10 (test only) - Change IS_SERVICE_TEST into a global var to quiet eslint undefined errors and remove eslint-disable no-undef from xpcshellUtilsAUS.js. r=mhowell Depends on D20801 Differential Revision: https://phabricator.services.mozilla.com/D20802
3314bffa0d510fabaa87292b0d5ef7d23c05a2a4: Bug 1529043 - Part 9 (test only) - Create functions for checking for updates and downloading updates that return a promise. r=mhowell
Robert Strong <robert.bugzilla@gmail.com> - Fri, 22 Feb 2019 22:00:31 +0000 - rev 521563
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529043 - Part 9 (test only) - Create functions for checking for updates and downloading updates that return a promise. r=mhowell Also removes several global declarations that are no longer used and moved a few global declarations to where they are used Depends on D20800 Differential Revision: https://phabricator.services.mozilla.com/D20801
17a347c991657ad0b01087caa9702a22d4daf777: Bug 1529043 - Part 8 (test only) - Make the stageUpdate function async and change call sites so they use await. r=mhowell
Robert Strong <robert.bugzilla@gmail.com> - Fri, 22 Feb 2019 21:47:37 +0000 - rev 521562
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529043 - Part 8 (test only) - Make the stageUpdate function async and change call sites so they use await. r=mhowell Depends on D20799 Differential Revision: https://phabricator.services.mozilla.com/D20800
0633e80e4acc19875b6573ecede25a2d1a8f70d0: Bug 1529043 - Part 7 (test only) - Make the runUpdateUsingApp function async and change call sites so they use await. r=mhowell
Robert Strong <robert.bugzilla@gmail.com> - Fri, 22 Feb 2019 21:26:08 +0000 - rev 521561
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529043 - Part 7 (test only) - Make the runUpdateUsingApp function async and change call sites so they use await. r=mhowell Depends on D20798 Differential Revision: https://phabricator.services.mozilla.com/D20799
7cff5bc91962d41b78afce754654ff878abda3cd: Bug 1529043 - Part 6 (test only) - Make the setupUpdaterTest function async and change call sites so they use await. r=mhowell
Robert Strong <robert.bugzilla@gmail.com> - Fri, 22 Feb 2019 21:23:08 +0000 - rev 521560
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529043 - Part 6 (test only) - Make the setupUpdaterTest function async and change call sites so they use await. r=mhowell Depends on D20797 Differential Revision: https://phabricator.services.mozilla.com/D20798
52905dcc9c1505f8870a1bf45cdb6b02fcad4814: Bug 1529043 - Part 5 (test only) - Make the checkPostUpdateAppLog function async and change call sites so they use await. r=mhowell
Robert Strong <robert.bugzilla@gmail.com> - Fri, 22 Feb 2019 21:07:32 +0000 - rev 521559
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529043 - Part 5 (test only) - Make the checkPostUpdateAppLog function async and change call sites so they use await. r=mhowell Depends on D20796 Differential Revision: https://phabricator.services.mozilla.com/D20797
a72eb0e7bb31857ccecf59203eb80b7452fb6928: Bug 1529043 - Part 4 (test only) - Make the waitForHelperExit function async and change call sites so they use await. r=mhowell
Robert Strong <robert.bugzilla@gmail.com> - Fri, 22 Feb 2019 21:05:02 +0000 - rev 521558
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529043 - Part 4 (test only) - Make the waitForHelperExit function async and change call sites so they use await. r=mhowell Depends on D20795 Differential Revision: https://phabricator.services.mozilla.com/D20796
efb5610ad438872d255665efc9a4575e56f7d9b1: Bug 1529043 - Part 3 (test only) - Make the runHelperFileInUse, runHelperPIDPersists, and runHelperLockFile functions async and change call sites so they use await. r=mhowell
Robert Strong <robert.bugzilla@gmail.com> - Fri, 22 Feb 2019 20:49:42 +0000 - rev 521557
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529043 - Part 3 (test only) - Make the runHelperFileInUse, runHelperPIDPersists, and runHelperLockFile functions async and change call sites so they use await. r=mhowell Depends on D20794 Differential Revision: https://phabricator.services.mozilla.com/D20795
ffe15ecad7442088521f6e0bdf427903f31c5b94: Bug 1529043 - Part 2 (test only) - Change runUpdate call sites to continue after calling runUpdate instead of having runUpdate call runUpdateFinished. r=mhowell
Robert Strong <robert.bugzilla@gmail.com> - Fri, 22 Feb 2019 20:42:13 +0000 - rev 521556
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529043 - Part 2 (test only) - Change runUpdate call sites to continue after calling runUpdate instead of having runUpdate call runUpdateFinished. r=mhowell Depends on D20793 Differential Revision: https://phabricator.services.mozilla.com/D20794
36a33f399a1c098f86224b5280a9602d16ab64bc: Bug 1529043 - Part 1 (test only) - change waitForUpdateXMLFiles call sites to use await instead of having waitForUpdateXMLFiles call waitForUpdateXMLFilesFinished. r=mhowell
Robert Strong <robert.bugzilla@gmail.com> - Fri, 22 Feb 2019 20:34:54 +0000 - rev 521555
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529043 - Part 1 (test only) - change waitForUpdateXMLFiles call sites to use await instead of having waitForUpdateXMLFiles call waitForUpdateXMLFilesFinished. r=mhowell Differential Revision: https://phabricator.services.mozilla.com/D20793
0291384ba66074fe5f4344becd87fecbe8c63942: Bug 1460433: Part 1 - Change BasicDllServices to not do any dll notification callbacks; r=mhowell
Aaron Klotz <aklotz@mozilla.com> - Wed, 20 Feb 2019 06:18:45 +0000 - rev 521517
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1460433: Part 1 - Change BasicDllServices to not do any dll notification callbacks; r=mhowell BasicDllServices is used to gain access to the authenticode APIs in non-Gecko contexts. One feature that WinDllServices provides is the ability to register a callback interface to be notified when a DLL has been loaded. This is not particularly useful in the BasicDllServices use case, and in the "handle a launcher process failure on a background thread" use case, would actually be harmful. This patch modifies the DLLServices backend to offer a "basic" option that omits the callback stuff. Differential Revision: https://phabricator.services.mozilla.com/D19696
cd5dbeee8c5d53b8c48925e9ad0befcf6cd6d28e: Bug 1502917 - Adding ChromeUtils.RequestProcInfo() - r=Ehsan,mstange,kershaw,mhowell
Tarek Ziadé <tarek@mozilla.com> - Thu, 21 Feb 2019 23:05:44 +0000 - rev 521392
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1502917 - Adding ChromeUtils.RequestProcInfo() - r=Ehsan,mstange,kershaw,mhowell This patch introduces a new module in widget that implements a simple API to retrieve system information about a process and its threads. This function is wrapped into ChromeUtils.RequestProcInfo to return information about processes started by Firefox. The use case for this API is to monitor Firefox resources usage in projects like the battery usage done by the data science team. Differential Revision: https://phabricator.services.mozilla.com/D10069
ad2243581733f322bdabf60b5a1d619b0de96985: Bug 1529429: Part 2 - SHIELD opt-out for launcher process in Nightly; r=mhowell
Aaron Klotz <aklotz@mozilla.com> - Thu, 21 Feb 2019 19:11:24 +0000 - rev 521314
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529429: Part 2 - SHIELD opt-out for launcher process in Nightly; r=mhowell We use the SHIELD pref instead of the usual launcher process pref for Nightly. This effectively treats the launcher process as a SHIELD study with 100% deployment. We add some Nightly-specific code that uses the SHIELD pref to determine whether or not to use the launcher. During startup, we query that pref and reflect it into the registry, which then falls through to the usual launcher process code. We will be changing this past 67, but for now this is an effective way to provide Nightly users with an opt-out to the launcher process and its telemetry. Differential Revision: https://phabricator.services.mozilla.com/D20621
1dad7090feddaff6eff2b830a931ced968e3cdc5: Bug 1529429: Part 1 - Make the installer initially disable the launcher process on Nightly; r=mhowell
Aaron Klotz <aklotz@mozilla.com> - Thu, 21 Feb 2019 18:54:12 +0000 - rev 521313
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529429: Part 1 - Make the installer initially disable the launcher process on Nightly; r=mhowell The idea here is that the installer always disables by default, but then Firefox itself later re-enables when the appropriate pref is turned on. I also added a check for the third launcher process registry key (|Image) since we really only want to do this when all three registry values are nonexistent. Differential Revision: https://phabricator.services.mozilla.com/D20620
ee53ed43d51d30b8a20907839150886b8fbc466e: Bug 1434033 - Use ORIGIN to search for NSS on Linux. r=mhowell,glandium
Robert Strong <robert.bugzilla@gmail.com> - Thu, 21 Feb 2019 00:31:11 +0000 - rev 521095
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1434033 - Use ORIGIN to search for NSS on Linux. r=mhowell,glandium Set the updater LDFLAGS to -Wl,-rpath=$ORIGIN so NSS can be found in the binary's directory Stop changing the LD_LIBRARY_PATH in nsUpdaterDriver.cpp Load the updater support files before the update begins in progressui_gtk.cpp Launch the updater from the install directory instead of copying it to the update directory Remove the skip-if = (os == linux && verify) for the staging tests since this also fixes the ETXTBSY error when calling execv on the copied updater Differential Revision: https://phabricator.services.mozilla.com/D20098
bad5b253a10c12bd2a95c1a0279bf810d1ae6095: Bug 1528570 - Add back test only return value of NS_tremove check. r=mhowell
Robert Strong <robert.bugzilla@gmail.com> - Tue, 19 Feb 2019 19:43:06 +0000 - rev 520896
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1528570 - Add back test only return value of NS_tremove check. r=mhowell Differential Revision: https://phabricator.services.mozilla.com/D20112
f01e7117e23f2b66c958bfa2e688be6b846ed8fe: Bug 1528623 - Require the channel name from the update-settings.ini file when updating. r=mhowell
Robert Strong <robert.bugzilla@gmail.com> - Tue, 19 Feb 2019 16:56:05 +0000 - rev 520895
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1528623 - Require the channel name from the update-settings.ini file when updating. r=mhowell Differential Revision: https://phabricator.services.mozilla.com/D20099
03a8e747b572f03d0edb9ad5a194ea1058353643: Bug 1528295 - Enable staging updates on Mac OS X entirely and not just for EARLY_BETA_OR_EARLIER for Firefox 67. r=mhowell
Robert Strong <robert.bugzilla@gmail.com> - Fri, 15 Feb 2019 17:34:06 +0000 - rev 520451
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1528295 - Enable staging updates on Mac OS X entirely and not just for EARLY_BETA_OR_EARLIER for Firefox 67. r=mhowell Differential Revision: https://phabricator.services.mozilla.com/D19964
bca59c2709d647d503d4214347dc885e2d069574: Bug 1515088 Part 1: Backed out changeset 86ef2274deff (bug 1519368). r=mhowell
Bob Owen <bobowencode@gmail.com> - Fri, 08 Feb 2019 17:16:29 +0000 - rev 520418
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1515088 Part 1: Backed out changeset 86ef2274deff (bug 1519368). r=mhowell This change also includes temporary installer code to try and remove any remaining Image File Execution Options.
c6130519c7cc4bb8dbdca524b65f3880dfa80296: Bug 1524688: Part 4 - Convert UpdateService to static registration r=mhowell
Kris Maglione <maglione.k@gmail.com> - Tue, 29 Jan 2019 17:46:17 -0800 - rev 520338
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1524688: Part 4 - Convert UpdateService to static registration r=mhowell
6b3684e7d8f95c7d028fcf27d1570675a8ccbbef: Bug 1524688: Part 4 - Convert UpdateService to static registration r=mhowell
Kris Maglione <maglione.k@gmail.com> - Tue, 29 Jan 2019 17:46:17 -0800 - rev 519937
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1524688: Part 4 - Convert UpdateService to static registration r=mhowell
adb008fe17ec08369e9c392d3a997d44b73a315b: Bug 1526865 - The browser chrome tests should continue instead of fail when the continue file isn't removed. r=mhowell
Robert Strong <robert.bugzilla@gmail.com> - Mon, 11 Feb 2019 19:13:44 +0000 - rev 519430
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1526865 - The browser chrome tests should continue instead of fail when the continue file isn't removed. r=mhowell Reworked the continue file code so the test doesn't fail if the continue file isn't removed. Instead tests will then check if the UI has advanced to the next check and the continue file is removed at the end of the test. Increases timeouts since some of the tests need longer for verify / TV runs. Removes skip-if for tests that now pass verify / TV on Linux Adds an .eslintrc to the test data directory Modified the sjs files so they pass eslint Differential Revision: https://phabricator.services.mozilla.com/D19335
6d8e6f960446fe8145ccb028d6644db879f2caa6: Bug 1526747 - Consolidate the calls to registerCleanupFunction where possible in app update's browser chrome tests. r=mhowell
Robert Strong <robert.bugzilla@gmail.com> - Mon, 11 Feb 2019 18:17:53 +0000 - rev 519406
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1526747 - Consolidate the calls to registerCleanupFunction where possible in app update's browser chrome tests. r=mhowell Adds a common registerCleanupFunction for all tests Moves several common test setup calls to the add_task used for common test setup Also clean up several of the comments and formatting Differential Revision: https://phabricator.services.mozilla.com/D19327
5f4edb1fe66f3cc2794d5738bfe3805c39f798f3: Bug 1526109 - Compress files in the test mar files without specifying --x86 so the test mar files will work with aarch64. r=mhowell
Robert Strong <robert.bugzilla@gmail.com> - Mon, 11 Feb 2019 16:53:48 +0000 - rev 519398
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1526109 - Compress files in the test mar files without specifying --x86 so the test mar files will work with aarch64. r=mhowell Changed simple.mar from a complete mar to a partial mar to prevent it from accidentally removing application files via an application precomplete file. Changed the name of the precomplete to update_precomplete in simple.mar so it won't accidentally replace an application's precomplete file. Differential Revision: https://phabricator.services.mozilla.com/D19267
ad397957d4794ea3a803efad8410aa540b991d2e: Bug 1526221 - Remove getAppBaseDir function from tests since getGreBinDir provides the same functionality and move readFileBytes to a common file. r=mhowell
Robert Strong <robert.bugzilla@gmail.com> - Fri, 08 Feb 2019 23:03:23 +0000 - rev 519256
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1526221 - Remove getAppBaseDir function from tests since getGreBinDir provides the same functionality and move readFileBytes to a common file. r=mhowell Differential Revision: https://phabricator.services.mozilla.com/D19130
4f7612ab6e2bbbf8b5d763cd02469c5ba741545d: Bug 1526147 - Change DEBUG_AUS_TEST so it is declared in shared.js. r=mhowell
Robert Strong <robert.bugzilla@gmail.com> - Fri, 08 Feb 2019 22:57:49 +0000 - rev 519255
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1526147 - Change DEBUG_AUS_TEST so it is declared in shared.js. r=mhowell Renames DEBUG_AUS_TEST which used to be a const to gDebugTest. Moved the declaration of gDebugTest to shared.js since it is easier to lint these files with it declared in shared.js Differential Revision: https://phabricator.services.mozilla.com/D19118
7e6b439fc86777d32af92fac2515e609ad023422: Bug 1526102 - Change app update tests to use a common function for getting update directory files. r=mhowell
Robert Strong <robert.bugzilla@gmail.com> - Fri, 08 Feb 2019 22:09:33 +0000 - rev 519243
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1526102 - Change app update tests to use a common function for getting update directory files. r=mhowell Created the getUpdateDirFile function and replaced various functions for getting files in the update directory. Change getApplyDirFile and getStageDirFile so they no longer take a second param for whether the file must exist since few callers used it. Changed waitForUpdateXMLFiles to be an async function since it simplifies the code and it makes this code eslint rule compliant. Removed unused param from checkFilesAfterUpdateCommon. Added removeUpdateFiles function for removing files for the mochitest-browser-chrome and mochitest-chrome tests and removed the removeUpdateDirsAndFiles function which never ran on Linux. Removed test_9999_cleanup.xul since it won't necessarily run for TV tasks. Differential Revision: https://phabricator.services.mozilla.com/D19117