searching for reviewer(mattn)
45249cb4b63e: Bug 1446508 - Create test file that makes it easier to add tests for simple policies. r=MattN a=test-only DEVEDITION_60_0b7_BUILD1 DEVEDITION_60_0b7_RELEASE FENNEC_60_0b7_BUILD1 FENNEC_60_0b7_RELEASE FIREFOX_60_0b7_BUILD1 FIREFOX_60_0b7_RELEASE
Felipe Gomes <felipc@gmail.com> - Mon, 26 Mar 2018 13:39:58 -0300 - rev 462856
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1446508 - Create test file that makes it easier to add tests for simple policies. r=MattN a=test-only
eb7464de4a57: Bug 1444283: Label the "Autofill addresses" and "autofill credit cards" check boxes for accessibility. r=MattN
James Teh <jteh@mozilla.com> - Fri, 09 Mar 2018 13:50:01 +1000 - rev 462577
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1444283: Label the "Autofill addresses" and "autofill credit cards" check boxes for accessibility. r=MattN MozReview-Commit-ID: EZ5ML1MQfOU
f1965cf7425f: Bug 1440499 - Implement the payerName/payerEmail/payerPhone contact picker. r=MattN
Sam Foster <sfoster@mozilla.com> - Tue, 06 Mar 2018 14:00:05 -0800 - rev 462319
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1440499 - Implement the payerName/payerEmail/payerPhone contact picker. r=MattN * Based on original patch by MattN * Make stored contacts available as payer data (MattN) * Add the address-picker element to the dialog for selecting payer details from stored contacts (MattN) * Add a field-names attribute to the payer address-picker, populated from the request paymentOptions * Basic CSS to selectively render address fields * Add mochitests to verify paymentOptions result in the correct payment picker behavior MozReview-Commit-ID: Br8i5MVyeQ3
d1a65f74a21c: Bug 1440499 - Add debug options for the payer details and shipping requested. r=MattN
Sam Foster <sfoster@mozilla.com> - Thu, 01 Mar 2018 11:46:30 -0800 - rev 462318
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1440499 - Add debug options for the payer details and shipping requested. r=MattN MozReview-Commit-ID: FnKn639SvzR
4e2e081dad55: Bug 1440499 - Implement the payerName/payerEmail/payerPhone contact picker. r=MattN
Sam Foster <sfoster@mozilla.com> - Tue, 06 Mar 2018 14:00:05 -0800 - rev 462302
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1440499 - Implement the payerName/payerEmail/payerPhone contact picker. r=MattN * Based on original patch by MattN * Make stored contacts available as payer data (MattN) * Add the address-picker element to the dialog for selecting payer details from stored contacts (MattN) * Add a field-names attribute to the payer address-picker, populated from the request paymentOptions * Basic CSS to selectively render address fields * Add mochitests to verify paymentOptions result in the correct payment picker behavior MozReview-Commit-ID: Br8i5MVyeQ3
479b143d8828: Bug 1440499 - Add debug options for the payer details and shipping requested. r=MattN
Sam Foster <sfoster@mozilla.com> - Thu, 01 Mar 2018 11:46:30 -0800 - rev 462301
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1440499 - Add debug options for the payer details and shipping requested. r=MattN MozReview-Commit-ID: FnKn639SvzR
3f419c7dcf2a: Bug 1429213 - Time out the payment dialog after the user clicks 'Pay', closing the dialog if response.complete() is not called. r=MattN
Jared Wein <jwein@mozilla.com> - Wed, 28 Feb 2018 14:57:54 -0500 - rev 462021
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1429213 - Time out the payment dialog after the user clicks 'Pay', closing the dialog if response.complete() is not called. r=MattN MozReview-Commit-ID: 8IswziomlHF
752ad36df388: Bug 1429213 - Implement the 'unknown' screen for when the merchant rejects the payment. r=MattN
Jared Wein <jwein@mozilla.com> - Fri, 02 Mar 2018 15:57:36 -0500 - rev 462020
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1429213 - Implement the 'unknown' screen for when the merchant rejects the payment. r=MattN MozReview-Commit-ID: KHf0NtE2Kir
7e7fda92a993: Bug 1443732 - Document that e10s is required for Web Payments. r=MattN.
Henri Sivonen <hsivonen@hsivonen.fi> - Wed, 07 Mar 2018 10:09:02 +0200 - rev 461929
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1443732 - Document that e10s is required for Web Payments. r=MattN. MozReview-Commit-ID: LaXHOm15mxi
ca36a410083e: Bug 1434483 - Renamed profileStorage singleton to formAutofillStorage to make it more clear; r=MattN
Daniel Marshall <daniel@starsandspirals.com> - Sat, 10 Feb 2018 21:23:19 +0000 - rev 461786
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1434483 - Renamed profileStorage singleton to formAutofillStorage to make it more clear; r=MattN MozReview-Commit-ID: CaPYBGLfs5I
a8130e46c530: Bug 1434483 - Renamed profileStorage singleton to formAutofillStorage to make it more clear; r=MattN
Daniel Marshall <daniel@starsandspirals.com> - Sat, 10 Feb 2018 21:23:19 +0000 - rev 461628
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1434483 - Renamed profileStorage singleton to formAutofillStorage to make it more clear; r=MattN MozReview-Commit-ID: CaPYBGLfs5I
4b3733f7e7f2: Bug 1442757 - use `sendMessageToContent` helper. r=MattN
Jonathan Guillotte-Blouin <jonathan.guillotte.blouin@gmail.com> - Fri, 02 Mar 2018 18:10:46 -0500 - rev 461448
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1442757 - use `sendMessageToContent` helper. r=MattN MozReview-Commit-ID: Ir3PUTopIJo
26fcec5f5ee4: Bug 1442724 - Use keydown to trigger display of payments debugging panel. r=MattN
Sam Foster <sfoster@mozilla.com> - Fri, 02 Mar 2018 11:08:15 -0800 - rev 461377
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1442724 - Use keydown to trigger display of payments debugging panel. r=MattN MozReview-Commit-ID: 3OHrEqEU4XW
e1b30d54da0b: Bug 1429207 - Implement the 'failure' screen for when the merchant rejects the payment. r=MattN
Jared Wein <jwein@mozilla.com> - Tue, 27 Feb 2018 22:09:34 -0500 - rev 461058
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1429207 - Implement the 'failure' screen for when the merchant rejects the payment. r=MattN MozReview-Commit-ID: JfsMQ8EwhqW
884c918d978c: Bug 1429211 - Implement the 'success' screen for when the merchant accepts the payment. r=MattN
Jared Wein <jwein@mozilla.com> - Tue, 27 Feb 2018 21:07:45 -0500 - rev 461057
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1429211 - Implement the 'success' screen for when the merchant accepts the payment. r=MattN MozReview-Commit-ID: 5AAKzKMqXVx
1aec20fe2d4e: Bug 1433593 - Skip test_maybeImportLogin on Android r=MattN
Doug Thayer <dothayer@mozilla.com> - Fri, 16 Feb 2018 10:02:19 -0800 - rev 460137
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1433593 - Skip test_maybeImportLogin on Android r=MattN MozReview-Commit-ID: 9LQaK318UKU
00fde1af50bf: Bug 1433593 - Clean up usages of LoginHelper.maybeImportLogin r=MattN
Doug Thayer <dothayer@mozilla.com> - Thu, 15 Feb 2018 10:26:44 -0800 - rev 460136
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1433593 - Clean up usages of LoginHelper.maybeImportLogin r=MattN In bug 1426721 we added a bulk interface for importing logins, which works in a background thread. This patch cleans up the single-login interface and updates the remaining usages to consume the bulk interface. MozReview-Commit-ID: IziLXkO5dxQ
7ab2c2f8a711: Bug 1435105 - Rename 'shippingRequested' class to 'shipping-related' to make the name clearer as well as follow file conventions. r=mattn
Jared Wein <jwein@mozilla.com> - Thu, 22 Feb 2018 21:39:59 -0800 - rev 460118
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1435105 - Rename 'shippingRequested' class to 'shipping-related' to make the name clearer as well as follow file conventions. r=mattn MozReview-Commit-ID: 6Dgzt69fFFq
cc27f2074495: Bug 1435105 - Vary the payment request address label according to 'shippingType'. r=mattn
Jared Wein <jwein@mozilla.com> - Thu, 22 Feb 2018 21:36:03 -0800 - rev 460117
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1435105 - Vary the payment request address label according to 'shippingType'. r=mattn MozReview-Commit-ID: 6HiraY6BbKb
624ce4190bce: Bug 1440530 - Move dialog setup code out to a helper function for the webpayments mochitest-browser tests. r=mattn
Jared Wein <jwein@mozilla.com> - Thu, 22 Feb 2018 17:24:59 -0800 - rev 460116
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1440530 - Move dialog setup code out to a helper function for the webpayments mochitest-browser tests. r=mattn MozReview-Commit-ID: 9rpN1lIjOCG
b281723b73dd: Bug 1429189 - Show shipping address errors on the summary screen. r=mattn
Jared Wein <jwein@mozilla.com> - Wed, 21 Feb 2018 14:16:35 -0800 - rev 460115
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1429189 - Show shipping address errors on the summary screen. r=mattn MozReview-Commit-ID: LaXrvWliWna
33318adf48fc: Bug 1435101 - Wrap some lines to under 100 characters to make eslint happy. r=MattN
Jared Wein <jwein@mozilla.com> - Wed, 21 Feb 2018 14:41:57 -0800 - rev 459735
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1435101 - Wrap some lines to under 100 characters to make eslint happy. r=MattN MozReview-Commit-ID: 4gzdA7C5krr
6c2b9768775d: Bug 1435101 - Only show the shipping options and shipping address if requestShipping is true. r=MattN
Jared Wein <jwein@mozilla.com> - Wed, 21 Feb 2018 11:21:29 -0800 - rev 459734
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1435101 - Only show the shipping options and shipping address if requestShipping is true. r=MattN MozReview-Commit-ID: 4PiQyHr3pDr
ffe15fb2541c: Bug 1429148 - Add nsIPK11Token.isInternalKeyToken. r=keeler,MattN
Felipe Gomes <felipc@gmail.com> - Tue, 20 Feb 2018 20:43:41 -0300 - rev 459684
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1429148 - Add nsIPK11Token.isInternalKeyToken. r=keeler,MattN MozReview-Commit-ID: Gdd7MxDXoTC
0c3184f918f0: Bug 1429148 - Policy: Enforce choice for the Remember Passwords setting. r=MattN
Felipe Gomes <felipc@gmail.com> - Wed, 14 Feb 2018 23:50:36 -0200 - rev 459683
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1429148 - Policy: Enforce choice for the Remember Passwords setting. r=MattN MozReview-Commit-ID: 3acY4QwQWGb
4a0f2f9776f8: Bug 1434415 - Move all hard-coded PaymentRequest strings to localization files. r=MattN
Jared Wein <jwein@mozilla.com> - Thu, 15 Feb 2018 16:12:04 -0500 - rev 459578
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1434415 - Move all hard-coded PaymentRequest strings to localization files. r=MattN MozReview-Commit-ID: 4dhHxaDjqgM
3b1aa6958142: Bug 1427947 - Dispatch `shippingoptionchange` when the shipping option is changed. r=MattN
Jared Wein <jwein@mozilla.com> - Thu, 15 Feb 2018 15:03:40 -0500 - rev 459574
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1427947 - Dispatch `shippingoptionchange` when the shipping option is changed. r=MattN MozReview-Commit-ID: J8U7ln90XnZ
7bf249f18ded: Bug 1438973: Update version of kinto.js to 11.0.0 r=MattN
Ethan Glasser-Camp <ethan@betacantrips.com> - Fri, 16 Feb 2018 15:08:18 -0500 - rev 459553
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1438973: Update version of kinto.js to 11.0.0 r=MattN MozReview-Commit-ID: 2Byd1HcbhHW
c1b0ea577728: Bug 1433593 - Skip test_maybeImportLogin on Android r=MattN
Doug Thayer <dothayer@mozilla.com> - Fri, 16 Feb 2018 10:02:19 -0800 - rev 459546
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1433593 - Skip test_maybeImportLogin on Android r=MattN MozReview-Commit-ID: 9LQaK318UKU
96327b595b91: Bug 1433593 - Clean up usages of LoginHelper.maybeImportLogin r=MattN
Doug Thayer <dothayer@mozilla.com> - Thu, 15 Feb 2018 10:26:44 -0800 - rev 459545
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1433593 - Clean up usages of LoginHelper.maybeImportLogin r=MattN In bug 1426721 we added a bulk interface for importing logins, which works in a background thread. This patch cleans up the single-login interface and updates the remaining usages to consume the bulk interface. MozReview-Commit-ID: IziLXkO5dxQ
ebbcdc3e642d: Bug 1433593 - Clean up usages of LoginHelper.maybeImportLogin r=MattN
Doug Thayer <dothayer@mozilla.com> - Thu, 15 Feb 2018 10:26:44 -0800 - rev 459050
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1433593 - Clean up usages of LoginHelper.maybeImportLogin r=MattN In bug 1426721 we added a bulk interface for importing logins, which works in a background thread. This patch cleans up the single-login interface and updates the remaining usages to consume the bulk interface. MozReview-Commit-ID: IziLXkO5dxQ
0e527d53161e: Bug 1438573 - Remove obsolete lightweight-theme-optimized notification. r=MattN
Dão Gottwald <dao@mozilla.com> - Thu, 15 Feb 2018 18:03:25 +0100 - rev 459025
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1438573 - Remove obsolete lightweight-theme-optimized notification. r=MattN MozReview-Commit-ID: Fn1itKmbVU3
684f8415581e: Bug 1388830 - upgrade kinto-http.js to 4.5.3. r=MattN
Ethan Glasser-Camp <ethan@betacantrips.com> - Wed, 14 Feb 2018 12:48:09 -0500 - rev 458780
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1388830 - upgrade kinto-http.js to 4.5.3. r=MattN This introduces an `UnparseableResponseError`, which exposes the text of the actual non-JSON response. It's also catcheable by client code (i.e. ExtensionStorageSync.jsm) if we believe this error is common enough to be silenced. MozReview-Commit-ID: H3ADFBFJRKA
d6a1c905d383: Bug 1437879 - Set the currency-amount properties as attributes on the shipping-option so they get copied to the cloned option. r=MattN
Jared Wein <jwein@mozilla.com> - Tue, 13 Feb 2018 10:24:25 -0500 - rev 458763
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1437879 - Set the currency-amount properties as attributes on the shipping-option so they get copied to the cloned option. r=MattN MozReview-Commit-ID: 9rngciIXPkX
f1cc283d8485: Bug 1427945 - Implement a Payment Request Shipping Option Picker. r=MattN
Jared Wein <jwein@mozilla.com> - Tue, 06 Feb 2018 11:37:34 -0500 - rev 458497
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1427945 - Implement a Payment Request Shipping Option Picker. r=MattN MozReview-Commit-ID: H7jWR0um0Py
0a524900f4f4: Bug 1434508 - better serialization of paymentrequest data. r=MattN
Sam Foster <sfoster@mozilla.com> - Wed, 31 Jan 2018 16:19:49 -0800 - rev 458153
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1434508 - better serialization of paymentrequest data. r=MattN * Add a serializeRequest method to paymentDialogWrapper to correctly serialize the nsIArray values * Test results of serializing a request with multiple displayItems, shippingOptions, paymentMethods and modifiers MozReview-Commit-ID: DTqzTAjvdxq
5f7d0a8085a8: Bug 1434167 - remove home page code from the migration wizard, r=MattN
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 07 Feb 2018 10:37:20 +0000 - rev 458104
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1434167 - remove home page code from the migration wizard, r=MattN This removes all the homepage-related code. All the cases where we advance the wizard straight to the homepage wizardpage now go straight to the 'start migrating' page (the 'point' was skipping earlier pages that allowed users to select items). The brand bundle was only used by the homepage code so is also being removed. MozReview-Commit-ID: I9nSU2IMkQz
e3cc726cd620: Bug 1436425 - Stop importing resetProfile.js when it is unneeded. r=MattN
Marco Castelluccio <mcastelluccio@mozilla.com> - Wed, 07 Feb 2018 13:08:55 +0100 - rev 457964
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1436425 - Stop importing resetProfile.js when it is unneeded. r=MattN
5ee280615e45: Bug 1429144 - Policy: Don't remember search and form history. r=MattN
Felipe Gomes <felipc@gmail.com> - Wed, 07 Feb 2018 20:37:55 -0200 - rev 457880
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1429144 - Policy: Don't remember search and form history. r=MattN MozReview-Commit-ID: GVHVe724dvv
f784eac344d2: Bug 1432070 - Block context menu in Autofill preference dialogs, except on text fields. r=MattN,scottwu
Ian Moody <moz-ian@perix.co.uk> - Sun, 21 Jan 2018 22:50:07 +0000 - rev 457822
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1432070 - Block context menu in Autofill preference dialogs, except on text fields. r=MattN,scottwu The context menu shown is the standard web page one, and so inappropriate for inside preferences. Keep it on text fields so text editing commands are still available, though unfortunately so are "This Frame", "Inspect Element", and "Add a Keyword for this Search". MozReview-Commit-ID: 7L012CZ4BhR
90f493006a7d: Bug 1435316 - Add container component stylesheets to the manifest for payments. r=MattN
Sam Foster <sfoster@mozilla.com> - Fri, 02 Feb 2018 09:46:11 -0800 - rev 457280
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1435316 - Add container component stylesheets to the manifest for payments. r=MattN MozReview-Commit-ID: 42QuwNmO9tC
1ec84b23a014: Bug 1434443 - Send the shippingAddress back to the webpage as part of the PaymentResponse. r=MattN
Jared Wein <jwein@mozilla.com> - Wed, 31 Jan 2018 16:17:15 -0500 - rev 457190
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1434443 - Send the shippingAddress back to the webpage as part of the PaymentResponse. r=MattN MozReview-Commit-ID: 4K8XpxkgdqB
6ea415aa3620: Bug 1427936 - Add an order-details component and details-payment-items. r=MattN
Sam Foster <sfoster@mozilla.com> - Fri, 12 Jan 2018 15:03:54 -0800 - rev 456988
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1427936 - Add an order-details component and details-payment-items. r=MattN * The order-details container arranges and populates the items list and the 2nd total line under the items. * The displayItems list is rendered into 2 lists, a "footer-items" list which displays tax and similar items just before the total, and a "main" list for everything else. * The list items are instances of a payment-details-item component * Initial layout of the line items and total with css grid * Tests for order-details component * Tests for payment-detail-item component MozReview-Commit-ID: 68r8SSgwHgq
2a7e34625fb8: Bug 1429017 - Added spotlight upon clicking view in preferences in address autofill doorhanger r=MattN
Sam Reading-Thompson, Robin Hodda, Joseph Fergusson <17988@cgs.act.edu.au> - Mon, 22 Jan 2018 16:02:55 -0800 - rev 456637
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1429017 - Added spotlight upon clicking view in preferences in address autofill doorhanger r=MattN
26403995065c: Bug 1387632: Rename ProfileStorage module to FormAutofillStorage. r=MattN
George Dan, Ryan Neilsen, Dylan Turner <ninjaprawn@ninjaprawn.com> - Tue, 30 Jan 2018 14:44:59 -0800 - rev 456636
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1387632: Rename ProfileStorage module to FormAutofillStorage. r=MattN
3b610f06c36a: Bug 1431482 - Add view-all button and toggle a activePanel property on the store. r=MattN
Sam Foster <sfoster@mozilla.com> - Fri, 19 Jan 2018 10:35:46 -0800 - rev 456312
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1431482 - Add view-all button and toggle a activePanel property on the store. r=MattN * Markup and CSS changes to start laying out the UI - treating the order details as an overlay on the payment summary * Use the orderDetailsShowing store property to toggle hidden on the order details section, when rendering PaymentDialog * Update the orderDetailsShowing property when clicking the view all items button * Test for the payment-dialog's view-all-items functionality MozReview-Commit-ID: HXNGmBatVYU
f7400dab78d5: Bug 1430979 - Wait for focus event in addition to FormReady event in formautofill tests. r=MattN
Tooru Fujisawa <arai_a@mac.com> - Mon, 29 Jan 2018 19:15:11 +0900 - rev 456219
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1430979 - Wait for focus event in addition to FormReady event in formautofill tests. r=MattN
edd801d576da: Bug 1426721 - Encrypt Chrome logins in background thread r=keeler,MattN
Doug Thayer <dothayer@mozilla.com> - Thu, 04 Jan 2018 15:10:54 -0800 - rev 456018
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1426721 - Encrypt Chrome logins in background thread r=keeler,MattN A significant chunk of migration jank that I observe locally happens due to login encryption. This patch reduces the locally observed jank (measured importing 100 logins) from 180ms to 25ms. Try is green, and as far as I can tell I don't see any thread safety issues, but I'm not 100% sure on that. I don't see any red flags inside the SecretDecoderRing::Encrypt implementation. I only moved Chrome logins over since I wanted to frontload any potential issues with the whole approach. It shouldn't be too hard to move the MSMigrationUtils and IEProfileMigrator uses over though. MozReview-Commit-ID: 75edUqJlk8x
df447e1b1a38: Bug 1426721 - Add async/bulk encryption interface to SDR r=keeler,MattN
Doug Thayer <dothayer@mozilla.com> - Tue, 23 Jan 2018 10:06:31 -0800 - rev 456017
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1426721 - Add async/bulk encryption interface to SDR r=keeler,MattN Since encryption can be somewhat CPU intensive, if we're encrypting a large number of strings we want to be able to do so in a background thread. This will be consumed by the profile migrators when importing logins. MozReview-Commit-ID: JoJGOgMzZ4u
810037ffe4a8: Bug 1417698 - Remove redundant `semi` eslint rule from toolkit/components/payments/. r=MattN
Nathan Heldon, Jonathon Soper & William Peterswald <2042@cgs.act.edu.au> - Tue, 23 Jan 2018 22:23:44 -0800 - rev 455607
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1417698 - Remove redundant `semi` eslint rule from toolkit/components/payments/. r=MattN