searching for reviewer(mattn)
5f7fd2e8f39f: Bug 1503855 - Use December as previous month for credit card validity check if it's January r=MattN a=test-only
Sebastian Hengst <archaeopteryx@coole-files.de> - Tue, 06 Nov 2018 14:52:14 +0000 - rev 501093
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1503855 - Use December as previous month for credit card validity check if it's January r=MattN a=test-only Differential Revision: https://phabricator.services.mozilla.com/D11020
d0d49443a8f1: Bug 1503751 - Increase year for check of valid credit card if current month is near end of year. r=MattN on IRC a=Aryx
Sebastian Hengst <archaeopteryx@coole-files.de> - Thu, 01 Nov 2018 03:03:17 +0200 - rev 500966
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1503751 - Increase year for check of valid credit card if current month is near end of year. r=MattN on IRC a=Aryx
1bef24401c99: Bug 1488011 - Set the checkbox label instead of using an adjacent XUL label so the checkbox focus ring appears correctly. r=MattN, a=RyanVM
Jared Wein <jwein@mozilla.com> - Wed, 24 Oct 2018 21:37:12 +0000 - rev 500936
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1488011 - Set the checkbox label instead of using an adjacent XUL label so the checkbox focus ring appears correctly. r=MattN, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D9708
25594c3013c4: Bug 1497514 - Initialize BasicCardPage selectedStateKey to 'selectPaymentCard'. r=MattN
Diego Pino Garcia <dpino@igalia.com> - Thu, 18 Oct 2018 23:56:00 +0300 - rev 500690
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1497514 - Initialize BasicCardPage selectedStateKey to 'selectPaymentCard'. r=MattN Also require basicCardPage has a selectedStateKey
388806780fac: Bug 1494551 - Sort the formautofill data by the last used time. r=MattN
Jared Wein <jwein@mozilla.com> - Fri, 19 Oct 2018 17:00:31 +0000 - rev 500684
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1494551 - Sort the formautofill data by the last used time. r=MattN Differential Revision: https://phabricator.services.mozilla.com/D9174
95fe4f9c3203: Bug 1420853 - Ensure only fields valid for the given country are saved. r=MattN
Jared Wein <jwein@mozilla.com> - Fri, 19 Oct 2018 16:36:45 +0000 - rev 500682
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1420853 - Ensure only fields valid for the given country are saved. r=MattN Differential Revision: https://phabricator.services.mozilla.com/D9034
8b3b53341da2: Bug 1497514 - Initialize BasicCardPage selectedStateKey to 'selectPaymentCard'. r=MattN
Diego Pino Garcia <dpino@igalia.com> - Thu, 18 Oct 2018 15:25:49 -0700 - rev 500543
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1497514 - Initialize BasicCardPage selectedStateKey to 'selectPaymentCard'. r=MattN Also require basicCardPage has a selectedStateKey
afdfeb4c004c: Bug 1497039 - Put a placeholder in privacy.xul that will be used to inject the form-autofill section. r=MattN
Jared Wein <jwein@mozilla.com> - Thu, 18 Oct 2018 03:42:59 +0000 - rev 500312
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1497039 - Put a placeholder in privacy.xul that will be used to inject the form-autofill section. r=MattN Differential Revision: https://phabricator.services.mozilla.com/D8892
eb2a83cba95a: Bug 1497039 - Put a placeholder in privacy.xul that will be used to inject the form-autofill section. r=MattN
Jared Wein <jwein@mozilla.com> - Wed, 17 Oct 2018 19:36:46 +0000 - rev 500260
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1497039 - Put a placeholder in privacy.xul that will be used to inject the form-autofill section. r=MattN Differential Revision: https://phabricator.services.mozilla.com/D8892
3a4b8a6a0881: Bug 1492671 - Disable screenshot capturing for triggering network requests in payments mochitests r=MattN
Andrei Oprea <andrei.br92@gmail.com> - Wed, 17 Oct 2018 15:08:50 +0000 - rev 500180
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1492671 - Disable screenshot capturing for triggering network requests in payments mochitests r=MattN Differential Revision: https://phabricator.services.mozilla.com/D8877
73912f1633a1: Bug 1481971 - Enable PaymentRequest on Nightly for Windows/macOS for US/CA users on en-US builds r=MattN,baku,gandalf
Diego Pino Garcia <dpino@igalia.com> - Tue, 16 Oct 2018 16:14:12 -0700 - rev 500094
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1481971 - Enable PaymentRequest on Nightly for Windows/macOS for US/CA users on en-US builds r=MattN,baku,gandalf
c895888bdddc: Bug 1486954 - Part IV, Recover from decryption errors in some places r=MattN
Timothy Guan-tin Chien <timdream@gmail.com> - Wed, 17 Oct 2018 02:34:22 +0000 - rev 500036
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1486954 - Part IV, Recover from decryption errors in some places r=MattN In case of loss of OS key store key, we should still allow users to go into the manage credit cards dialog and fill the numbers back in. This is not the migration strategy, see Part III. Differential Revision: https://phabricator.services.mozilla.com/D5083
27e9286503e8: Bug 1486954 - Part III, Upgrade existing Nightly credit card records to OSKeyStore r=MattN
Timothy Guan-tin Chien <timdream@gmail.com> - Wed, 17 Oct 2018 02:33:02 +0000 - rev 500035
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1486954 - Part III, Upgrade existing Nightly credit card records to OSKeyStore r=MattN For Nightly users who already have credit cards saved in their profile, we will do a one-off upgrade of their encrypted credit card number. This only applies to users who have NO master password set, to avoid showing them the master password prompt when we migrate. For those who did, we would quietly delete their credit card record from the store. Differential Revision: https://phabricator.services.mozilla.com/D8029
87e64652386d: Bug 1486954 - Part II, Remove OSKeyStore.isEnabled r=MattN
Timothy Guan-tin Chien <timdream@gmail.com> - Wed, 17 Oct 2018 02:32:05 +0000 - rev 500034
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1486954 - Part II, Remove OSKeyStore.isEnabled r=MattN Given that the new store is always considered enabled, the not-enabled code is now dead code. This patch removes them. Differential Revision: https://phabricator.services.mozilla.com/D5717
96a6e1ceb697: Bug 1486954 - Part I, (Nighty-only feature) Encrypt credit card numbers with OS key store r=MattN
Timothy Guan-tin Chien <timdream@gmail.com> - Wed, 17 Oct 2018 02:31:04 +0000 - rev 500033
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1486954 - Part I, (Nighty-only feature) Encrypt credit card numbers with OS key store r=MattN This patch morphs MasterPassword.jsm to OSKeyStore.jsm while keeping the same API, as an adaptor between the API and the native API exposed as nsIOSKeyStore.idl. Noted that OS Key Store has the concept of "recovery phrase" that we won't be adopting here. The recovery phrase, together with our label, allow the user to re-create the same key in OS key store. Test case changes are needed because we have started asking for login in places where we'll only do previously when "master password is enabled". This also made some "when master password is enabled" tests invalid because it is always considered enabled. Some more test changes are needed simply because they previously rely on the stable order of microtask resolutions (and the stable # of promises for a specific operation). That has certainly changed with OSKeyStore. The credit card form autofill is only enabled on Nightly. Differential Revision: https://phabricator.services.mozilla.com/D4498
4c98e1b28c38: Bug 1499474 - Check if the element has textContent before falling back to TestUtils.waitForCondition. r=MattN
Jared Wein <jwein@mozilla.com> - Tue, 16 Oct 2018 20:04:38 +0000 - rev 499978
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1499474 - Check if the element has textContent before falling back to TestUtils.waitForCondition. r=MattN This patch reduced the time to run from 2 minutes to 15 seconds. Differential Revision: https://phabricator.services.mozilla.com/D8895
583d689d630e: Bug 1485105 - Allow 12-19 digit length card numbers. r=MattN
Sam Foster <sfoster@mozilla.com> - Tue, 16 Oct 2018 05:37:39 +0000 - rev 499870
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1485105 - Allow 12-19 digit length card numbers. r=MattN * Change to isValidNumber to allow any number length in the range. This also removes 9 as a valid payment card number length * Amend form autocomplete test for sensitive 9 digit numbers. We no longer consider them valid cc numbers, test for 19 digit numbers instead * Fix intermittent issue in a session restore tests. It turns out Date.now().toString() can sometimes pass the Luhn algorithm and look like a valid credit card number. I believe this could lead to it being treated as sensitive data which is not saved and restored, failing the test Differential Revision: https://phabricator.services.mozilla.com/D8271
d545a48c1bfd: Bug 1470199 - Add a tooltip for the CVV input. r=MattN
Jared Wein <jwein@mozilla.com> - Sat, 13 Oct 2018 00:39:02 +0000 - rev 499420
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1470199 - Add a tooltip for the CVV input. r=MattN Differential Revision: https://phabricator.services.mozilla.com/D7473
7de161eb2e11: Bug 1496698 - Remove res/vendor from jar.mn; r=MattN
Mike Shal <mshal@mozilla.com> - Thu, 11 Oct 2018 22:13:34 +0000 - rev 499330
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1496698 - Remove res/vendor from jar.mn; r=MattN Followup to remove the now non-existent directory from the manifest. MozReview-Commit-ID: 5grb4TgoBsT Differential Revision: https://phabricator.services.mozilla.com/D8466
31313cac4517: Bug 1485105 - Allow 12-19 digit length card numbers. r=MattN
Sam Foster <sfoster@mozilla.com> - Thu, 11 Oct 2018 23:54:25 +0000 - rev 499238
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1485105 - Allow 12-19 digit length card numbers. r=MattN * Change to isValidNumber to allow any number length in the range. This also removes 9 as a valid payment card number length * Amend form autocomplete test for sensitive 9 digit numbers. We no longer consider them valid cc numbers, test for 19 digit numbers instead * Fix intermittent issue in a session restore test. It turns out Date.now().toString() can sometimes pass the Luhn algorithm and look like a valid credit card number. I believe this could lead to it being treated as sensitive data which is not saved and restored, failing the test Differential Revision: https://phabricator.services.mozilla.com/D8271
e702628b7c51: Bug 1485105 - Allow 12-19 digit length card numbers. r=MattN
Sam Foster <sfoster@mozilla.com> - Wed, 10 Oct 2018 23:23:11 +0000 - rev 499082
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1485105 - Allow 12-19 digit length card numbers. r=MattN Differential Revision: https://phabricator.services.mozilla.com/D8271
e8f0ddeec2f1: Bug 1451526 Convert mozscreenshots to a webextension r=MattN
Andrew Swan <aswan@mozilla.com> - Thu, 04 Oct 2018 21:41:06 +0000 - rev 498168
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1451526 Convert mozscreenshots to a webextension r=MattN Differential Revision: https://phabricator.services.mozilla.com/D7613
32cde67dd330: Bug 1495530 - Use card icons in form autofill card preferences screen. r=MattN
Sam Foster <sfoster@mozilla.com> - Wed, 03 Oct 2018 15:58:16 +0000 - rev 497865
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1495530 - Use card icons in form autofill card preferences screen. r=MattN Differential Revision: https://phabricator.services.mozilla.com/D7334
bd55b04144dc: Bug 1492950 - Get login prompter off of getBrowserForContentWindow. r=MattN
Mike Conley <mconley@mozilla.com> - Tue, 02 Oct 2018 17:52:54 +0000 - rev 497665
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1492950 - Get login prompter off of getBrowserForContentWindow. r=MattN Depends on D6711 Differential Revision: https://phabricator.services.mozilla.com/D6712
bb9fc6495914: Bug 1492950 - Get rid of getTabModalPromptBox in browser.js. r=Gijs,MattN
Mike Conley <mconley@mozilla.com> - Tue, 02 Oct 2018 17:50:42 +0000 - rev 497663
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1492950 - Get rid of getTabModalPromptBox in browser.js. r=Gijs,MattN Depends on D6709 Differential Revision: https://phabricator.services.mozilla.com/D6710
44ab1f5c5056: Bug 1473662 - Save button should be labelled 'Next' when adding a new address or card. r=MattN
Sam Foster <sfoster@mozilla.com> - Fri, 28 Sep 2018 20:00:03 +0000 - rev 497169
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1473662 - Save button should be labelled 'Next' when adding a new address or card. r=MattN Differential Revision: https://phabricator.services.mozilla.com/D7209
04f74c53d537: Bug 1477102 - Add third-party payment card logos, enable their use in official, branded builds. r=MattN
Sam Foster <sfoster@mozilla.com> - Fri, 28 Sep 2018 16:53:49 +0000 - rev 497153
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1477102 - Add third-party payment card logos, enable their use in official, branded builds. r=MattN Depends on D7025 Differential Revision: https://phabricator.services.mozilla.com/D7026
6ce23e4daf8d: Bug 1477102 - Toggle accepted cards list on add/edit cards. Add stub for using AppConstants.MOZILLA_OFFICIAL to fallback for non-branded builds. r=MattN
Sam Foster <sfoster@mozilla.com> - Fri, 28 Sep 2018 16:53:37 +0000 - rev 497152
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1477102 - Toggle accepted cards list on add/edit cards. Add stub for using AppConstants.MOZILLA_OFFICIAL to fallback for non-branded builds. r=MattN Differential Revision: https://phabricator.services.mozilla.com/D7025
3de6e1582de9: Bug 1470184 - Update the Preferences text and layout for Web Payments. r=flod,MattN
Jared Wein <jwein@mozilla.com> - Fri, 28 Sep 2018 08:29:01 +0000 - rev 497104
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1470184 - Update the Preferences text and layout for Web Payments. r=flod,MattN Differential Revision: https://phabricator.services.mozilla.com/D6937
e2f7985ef41d: Bug 1470168 - Add tooltip beside 'Save to Firefox' checkbox. r=MattN
Jared Wein <jwein@mozilla.com> - Thu, 27 Sep 2018 14:11:39 +0000 - rev 496997
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1470168 - Add tooltip beside 'Save to Firefox' checkbox. r=MattN I had to move the tooltip to appear above the help icon to make sure that it cause scrollbars to appear on the address form. Differential Revision: https://phabricator.services.mozilla.com/D6912
b1fc8e9cb601: Bug 1490874: Update tests to comply with new script error logging mechanism. r=MattN
Christoph Kerschbaumer <ckerschb@christophkerschbaumer.com> - Tue, 25 Sep 2018 07:52:30 +0200 - rev 496526
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1490874: Update tests to comply with new script error logging mechanism. r=MattN
0871a9a488b5: Bug 1484325 Go back to chrome.manifest for formautofill locale registration r=MattN
Andrew Swan <aswan@mozilla.com> - Tue, 25 Sep 2018 06:03:20 +0000 - rev 496518
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1484325 Go back to chrome.manifest for formautofill locale registration r=MattN Differential Revision: https://phabricator.services.mozilla.com/D6690
29e7b5d5f5e4: Bug 1481972 - Add remaining countries to address autofill countries list. r=MattN
Jared Wein <jwein@mozilla.com> - Sun, 23 Sep 2018 23:50:03 -0700 - rev 496298
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1481972 - Add remaining countries to address autofill countries list. r=MattN Saving and filling the countries via Form Autofill will still be limited to certain countries but this allows the storage to be useful for Web Payments in other countries. Differential Revision: https://phabricator.services.mozilla.com/D5194
75036af7d851: Bug 1490077 - Reflect DOM validation messages on the error popup on the address and basic-card form. r=MattN
Jared Wein <jwein@mozilla.com> - Fri, 21 Sep 2018 00:15:56 -0700 - rev 496172
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1490077 - Reflect DOM validation messages on the error popup on the address and basic-card form. r=MattN Contributions by Matthew Noorenberghe <mozilla@noorenberghe.ca> Differential Revision: https://phabricator.services.mozilla.com/D6420
29f6f86fb9cd: Bug 1490077 - Reflect DOM validation messages on the error popup on the address and basic-card form. r=MattN
Jared Wein <jwein@mozilla.com> - Fri, 21 Sep 2018 00:15:56 -0700 - rev 496101
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1490077 - Reflect DOM validation messages on the error popup on the address and basic-card form. r=MattN Contributions by Matthew Noorenberghe <mozilla@noorenberghe.ca> Differential Revision: https://phabricator.services.mozilla.com/D6420
e7e27205f4cd: Bug 1478880 - payments/test/browser/head.js: fillInCardForm reliability fixes. r=MattN
Jared Wein <jwein@mozilla.com> - Thu, 20 Sep 2018 20:44:03 -0700 - rev 496060
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1478880 - payments/test/browser/head.js: fillInCardForm reliability fixes. r=MattN * Blur before focus to reset timer for filtering <select> * Wait for field to get focus before sending keys to it. * Compare unpadded strings Differential Revision: https://phabricator.services.mozilla.com/D6338
33a833eab418: Bug 1491791 - Update the Save button state after the 'change' event. r=MattN
Jared Wein <jwein@mozilla.com> - Thu, 20 Sep 2018 17:13:26 +0000 - rev 495915
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1491791 - Update the Save button state after the 'change' event. r=MattN The validity of the cc-number field is only updated to a failure state after the 'change' event in the EditCreditCard class, but there was no code within basic-card-form.js to update the Save button enabled state after the 'change' event had been handled by EditCreditCard. Differential Revision: https://phabricator.services.mozilla.com/D6282
8889fed6e2cf: Bug 1491065 - Use 'Next' as label for the save buttons during onboarding. r=MattN
Sam Foster <sfoster@mozilla.com> - Wed, 19 Sep 2018 22:10:50 +0000 - rev 495800
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1491065 - Use 'Next' as label for the save buttons during onboarding. r=MattN Differential Revision: https://phabricator.services.mozilla.com/D6318
45df249c3895: Bug 1470183 - Add 3rd suggestion to failure page directing users to merchant for more info. r=MattN
Sam Foster <sfoster@mozilla.com> - Wed, 19 Sep 2018 20:57:26 +0000 - rev 495797
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1470183 - Add 3rd suggestion to failure page directing users to merchant for more info. r=MattN Differential Revision: https://phabricator.services.mozilla.com/D6322
90201e199fea: Bug 1429181 - Consider supportedNetworks when determining if payment method is valid. r=MattN
Sam Foster <sfoster@mozilla.com> - Wed, 19 Sep 2018 18:15:11 +0000 - rev 495723
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1429181 - Consider supportedNetworks when determining if payment method is valid. r=MattN * A new accepted-cards element to represent the labeled list of card icons * Add the accepted cards section to the summary and card add/edit page * mochitest for the accepted-cards element * Make cc-type a required field and validate it against the list of supported networks * Add verification of the pay button disabling when card network is not supported Depends on D5823 Differential Revision: https://phabricator.services.mozilla.com/D5824
7351a4c8d1a1: Bug 1429181 - Consider supportedNetworks when determining if payment method is valid. r=MattN
Sam Foster <sfoster@mozilla.com> - Fri, 14 Sep 2018 20:28:41 +0000 - rev 494831
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1429181 - Consider supportedNetworks when determining if payment method is valid. r=MattN * A new accepted-cards element to represent the labeled list of card icons * Add the accepted cards section to the summary and card add/edit page * mochitest for the accepted-cards element * Make cc-type a required field and validate it against the list of supported networks * Add verification of the pay button disabling when card network is not supported Depends on D5823 Differential Revision: https://phabricator.services.mozilla.com/D5824
a1a4703b8464: Bug 1429181 - Fix serialization of payment method data. r=MattN
Sam Foster <sfoster@mozilla.com> - Fri, 14 Sep 2018 20:24:08 +0000 - rev 494830
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1429181 - Fix serialization of payment method data. r=MattN * Includes a workaround to explicitly cloneInto the paymentMethods data when we create the PaymentRequest object in the content window in tests. MozReview-Commit-ID: LFy0h3fIXXA Differential Revision: https://phabricator.services.mozilla.com/D5823
4b3b3a1db0df: Bug 1399367 - Remove MasterPassword.{encrypt|decrypt}Sync() methods r=MattN
Timothy Guan-tin Chien <timdream@gmail.com> - Wed, 05 Sep 2018 17:54:48 +0000 - rev 493413
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1399367 - Remove MasterPassword.{encrypt|decrypt}Sync() methods r=MattN This also makes various AutofillRecords methods async, with the exception of remove() and removeAll(). Noted that I didn't implement any kind of "lock" for FormAutofillStorage -- please do not call these methods concurrently -- if you must please |await| for the last call to resolve. This most likely would happen in tests, and shouldn't happen in the real world, given that all user actions happen on macrotasks, and probably not at the next tick, unless Quicksilver is a Firefox user. FormAutofillStorage can be improved if there are complex use cases for it. Differential Revision: https://phabricator.services.mozilla.com/D4420
56aa054d4cc0: Bug 1399367 - Remove MasterPassword.{encrypt|decrypt}Sync() methods r=MattN
Timothy Guan-tin Chien <timdream@gmail.com> - Wed, 05 Sep 2018 00:32:57 +0000 - rev 493168
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1399367 - Remove MasterPassword.{encrypt|decrypt}Sync() methods r=MattN This also makes various AutofillRecords methods async, with the exception of remove() and removeAll(). Noted that I didn't implement any kind of "lock" for FormAutofillStorage -- please do not call these methods concurrently -- if you must please |await| for the last call to resolve. This most likely would happen in tests, and shouldn't happen in the real world, given that all user actions happen on macrotasks, and probably not at the next tick, unless Quicksilver is a Firefox user. FormAutofillStorage can be improved if there are complex use cases for it. Differential Revision: https://phabricator.services.mozilla.com/D4420
f91ac8ecb4dc: Bug 1503751 - Increase year for check of valid credit card if current month is near end of year. r=MattN on IRC a=Aryx
Sebastian Hengst <archaeopteryx@coole-files.de> - Thu, 01 Nov 2018 03:03:17 +0200 - rev 492964
Push 1842 by cbrindusan@mozilla.com at Thu, 01 Nov 2018 01:29:51 +0000
Bug 1503751 - Increase year for check of valid credit card if current month is near end of year. r=MattN on IRC a=Aryx
ad88fc39b67b: Bug 1484721 - Update the save button disabled state after changing the country select dropdown in the address-form. r=MattN
Jared Wein <jwein@mozilla.com> - Fri, 31 Aug 2018 16:15:51 +0000 - rev 492016
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1484721 - Update the save button disabled state after changing the country select dropdown in the address-form. r=MattN Differential Revision: https://phabricator.services.mozilla.com/D4470
ee00cb44157b: Bug 1480719 - Require credit card expiration month and year before saving credit cards. r=MattN
Jared Wein <jwein@mozilla.com> - Fri, 31 Aug 2018 16:36:34 +0000 - rev 492015
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1480719 - Require credit card expiration month and year before saving credit cards. r=MattN Differential Revision: https://phabricator.services.mozilla.com/D4485
f52b086cbd9d: Bug 1486938: Remove login-manager-storage category entry. r=MattN
Kris Maglione <maglione.k@gmail.com> - Tue, 28 Aug 2018 14:58:51 -0700 - rev 491491
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1486938: Remove login-manager-storage category entry. r=MattN This is an unused feature, with a strange implementation. If we need such an override in the future, it can be accomplished by just overriding a contract ID. This patch also changes the implementation to simply define a contract ID for the appropriate default implementation at registration time rather than adding a duplicate platform check at runtime.
1f763bb7c0ef: Bug 1477105 - Support cc-type as valid field for credit cards in form autofill. r=MattN
Sam Foster <sfoster@mozilla.com> - Tue, 28 Aug 2018 15:59:57 -0700 - rev 491462
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1477105 - Support cc-type as valid field for credit cards in form autofill. r=MattN * Add cc-type as a valid field for credit card forms * Add a select menu and new string for designating a card type in the add/edit form * Enforce matching of cc-type to one of the list of supported network ids for Basic Card * Expose the network ids list as CreditCard.SUPPORTED_TYPES * Populate the cc-type options using a getCreditCardTypes util method passed into the EditCreditCard constructor * Web Payment tests: verify cc-type picker is presented, populated as expected and selections received in the response MozReview-Commit-ID: 9QyU1UwTRay Differential Revision: https://phabricator.services.mozilla.com/D3830
c066358cf6fc: Bug 1480886 - Follow-up to disable the cc-type field. r=MattN
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Tue, 28 Aug 2018 13:43:38 -0700 - rev 491444
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1480886 - Follow-up to disable the cc-type field. r=MattN