searching for reviewer(mats)
776f100fead626a135489e8a5373b237c1691c2f: Bug 1563163 Part 2: Downgrade an assert to a warning in nsFlexContainerFrame::GetFlexFrameWithComputedInfo. r=mats
Brad Werth <bwerth@mozilla.com> - Fri, 30 Aug 2019 23:16:44 +0000 - rev 554730
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1563163 Part 2: Downgrade an assert to a warning in nsFlexContainerFrame::GetFlexFrameWithComputedInfo. r=mats Differential Revision: https://phabricator.services.mozilla.com/D44284
5119f09d6b99ac8b9f27ee676e8dc7acdfb02815: Bug 1563163 Part 1: Make Flex::Flex gracefully handle frames without FlexContainerInfo structures. r=mats
Brad Werth <bwerth@mozilla.com> - Fri, 30 Aug 2019 23:16:09 +0000 - rev 554729
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1563163 Part 1: Make Flex::Flex gracefully handle frames without FlexContainerInfo structures. r=mats Differential Revision: https://phabricator.services.mozilla.com/D44283
f7ff76e196bdb37607020bf9fc5db4ef8818fcf6: Bug 1577745 - Remove dead version of nsStyleDisplay::IsOriginalDisplayInlineOutside. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 30 Aug 2019 13:21:42 +0000 - rev 554626
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1577745 - Remove dead version of nsStyleDisplay::IsOriginalDisplayInlineOutside. r=mats SVG Text stuff doesn't support abspos or anything like that, so it's not like it is useful. Differential Revision: https://phabricator.services.mozilla.com/D44136
64140fe11fc2ba22bc1b27adca94c847a61a9cb9: Bug 1576194 - Remove kDisplayKTable. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 23 Aug 2019 15:52:05 +0000 - rev 553511
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1576194 - Remove kDisplayKTable. r=mats It doesn't represent anything useful anymore. Differential Revision: https://phabricator.services.mozilla.com/D43262
3db1abb6e436926e67d3dedefeed38fbb1faca01: Bug 1481112 - Be consistent on which properties we allow to inherit through for input, textarea, button and select, for compat with other UAs. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 23 Aug 2019 13:24:05 +0000 - rev 553347
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1481112 - Be consistent on which properties we allow to inherit through for input, textarea, button and select, for compat with other UAs. r=mats There should be no change in behavior for <input> and <textarea>. Tests need to be written for <button> and <select>. Tests are at https://github.com/web-platform-tests/wpt/pull/17152 Differential Revision: https://phabricator.services.mozilla.com/D43221
91d88ae893e790b1a3a9df5aebf87fa3ff02b29a: Bug 1574544 - Remove now-unnecessary condition that makes the frame constructor get confused with editor anonymous nodes. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 19 Aug 2019 12:16:28 +0000 - rev 552466
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1574544 - Remove now-unnecessary condition that makes the frame constructor get confused with editor anonymous nodes. r=mats This condition was needed when FindInsertionPrevSibling and co didn't understand display: contents. Editor is pretty broken (and calls into PresShell::ContentRemoved directly, and incorrectly, using anonymous nodes). In this case we were taking the XBL path because of display: contents, which means that we tried to seek to the editor anonymous node, and crash (since it's not an explicit kid). Editor needs to get fixed, but this is technically more correct and fixes the crash, so we may as well take it in the interim. Differential Revision: https://phabricator.services.mozilla.com/D42472
9798b876061ebbc28eb23ab5d456c094855a4ce9: Bug 1574101 - Use the right parent frame for `block ruby` if it's out of flow. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 15 Aug 2019 22:21:35 +0000 - rev 552123
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1574101 - Use the right parent frame for `block ruby` if it's out of flow. r=mats I should've caught this when reviewing, in fairness. Differential Revision: https://phabricator.services.mozilla.com/D42163
4d8eb840fc2eaa37f6e75e5a5f2e8863beeccf19: Bug 1574101 - Use the right parent frame for `block ruby` if it's out of flow. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 15 Aug 2019 21:14:34 +0000 - rev 552108
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1574101 - Use the right parent frame for `block ruby` if it's out of flow. r=mats I should've caught this when reviewing, in fairness. Differential Revision: https://phabricator.services.mozilla.com/D42163
0bc9d6bfeb5a08b9dfe2f03c897e564478982e36: Bug 1573907 - Make non-list-items not increment the start value for <ol reversed>. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 15 Aug 2019 09:54:21 +0000 - rev 551966
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1573907 - Make non-list-items not increment the start value for <ol reversed>. r=mats Differential Revision: https://phabricator.services.mozilla.com/D42084
a9bdb526a7a01e0984c2bf8c888e8d8ffc69c5c4: Bug 1573907 - Fix interaction of <li value> inside <ol reversed>. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 15 Aug 2019 09:52:28 +0000 - rev 551965
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1573907 - Fix interaction of <li value> inside <ol reversed>. r=mats The counting code was incrementing the start counter twice for <li value>, as it generates both an increment and a reset. We should instead only increment it once per list-item, that is, once per increment. Differential Revision: https://phabricator.services.mozilla.com/D42001
ad04c84153da637000c7a472ccbc248116b5c330: Bug 1571764 - Subtract combobox display frame border-padding when inferring the height from line-height. r=mats,jfkthame
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 15 Aug 2019 09:41:15 +0000 - rev 551963
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1571764 - Subtract combobox display frame border-padding when inferring the height from line-height. r=mats,jfkthame This fixes it and seems to be an acceptable fix... Should I make it conditional on box-sizing: border-box for completeness? The display frame has border-box box-sizing, and not having it would be a bug, I'd think... Differential Revision: https://phabricator.services.mozilla.com/D41939
bd44d2dd0c02c1e2ab10e73695ee3ef1da971aa6: Bug 1571764 - Subtract combobox display frame border-padding when inferring the height from line-height. r=mats,jfkthame
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 14 Aug 2019 16:06:46 +0000 - rev 551716
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1571764 - Subtract combobox display frame border-padding when inferring the height from line-height. r=mats,jfkthame This fixes it and seems to be an acceptable fix... Should I make it conditional on box-sizing: border-box for completeness? The display frame has border-box box-sizing, and not having it would be a bug, I'd think... Differential Revision: https://phabricator.services.mozilla.com/D41939
4e4bb211b6733d7a9d710118fe58834f631152a4: Bug 1339672 - Support multiple track sizes for grid-auto-{columns|rows}. r=emilio,mats
Boris Chiou <boris.chiou@gmail.com> - Tue, 06 Aug 2019 18:32:16 +0000 - rev 550361
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1339672 - Support multiple track sizes for grid-auto-{columns|rows}. r=emilio,mats Support `<track-size>+` on the implicit track sizing properties, grid-auto-columns and grid-auto-rows. Differential Revision: https://phabricator.services.mozilla.com/D38408
a1eb75e785ded866d66184c8b59b5a5b907a34fb: Bug 1519958 - Refactor grid types to preserve repeat() at computed value time and use cbindgen. r=mats,boris
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 28 Jun 2019 13:27:19 +0200 - rev 550182
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1519958 - Refactor grid types to preserve repeat() at computed value time and use cbindgen. r=mats,boris I'm _really_ sorry for the size of the patch. I tried to do this in two steps but it was a lot of work and pretty ugly. This patch makes us use cbindgen for grid-template-{rows,columns}, in order to: * Make us preserve repeat() at computed-value time. This is per spec since interpolation needs to know about repeat(). Except for subgrid, which did the repeat expansion at parse-time and was a bit more annoying (plus it doesn't really animate yet so we don't need it to comply with the spec). * Tweaks the WPT tests for interpolation to adopt the resolution at: https://github.com/w3c/csswg-drafts/issues/3503. Trade-off here, as this patch stands, is that this change makes us use less long-living memory, since we expand repeat() during layout, but at the cost of a bit of CPU time during layout (conditional on the property applying though, which wasn't the case before). It should be very easy to store a cached version of the template, should this be too hot (I expect it isn't), or to change the representation in other ways to optimize grid layout code if it's worth it. Another trade-off: I've used SmallPointerArray to handle line-name merging, pointing to the individual arrays in the style data, rather than actually heap-allocating the merged lists. This would also be pretty easy to change should we measure and see that it's not worth it. This patch also opens the gate to potentially improving memory usage in some other ways, by reference-counting line-name lists for example, though I don't have data that suggests it is worth it. In general, this patch makes much easier to tweak the internal representation of the grid style data structures. Overall, I think it's a win, the amount of magic going on in that mako code was a bit huge; it took a bit to wrap my head around it. This patch comments out the style struct size assertions. They will be uncommented in a follow-up patch which contains some improvements for this type, which are worth getting reviewed separately. Also, this patch doesn't remove as much code as I would've hoped for because of I tried not to change most of the dom/grid code for inspector, but I think a fair bit of the nsGridContainerFrame.cpp code that collects information for it can be simplified / de-copy-pasted to some extent. But that was a pre-existing problem and this patch is already quite massive. Differential Revision: https://phabricator.services.mozilla.com/D36598
50be005d08a9ef783c009fc8259cd4f3f3e57d49: Bug 1571135 - Remove the preference that controls breaking floats inside columns. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Mon, 05 Aug 2019 17:39:19 +0000 - rev 549965
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1571135 - Remove the preference that controls breaking floats inside columns. r=mats Differential Revision: https://phabricator.services.mozilla.com/D40587
178481b79e4e8b1e293e97813e0cc5663c60b7d6: Bug 1570096 - Fix parsing of align=bottom on replaced elements. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 31 Jul 2019 09:59:30 +0000 - rev 549305
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1570096 - Fix parsing of align=bottom on replaced elements. r=mats See https://github.com/whatwg/html/issues/4810. I accidentally changed its behavior in bug 1547985 due to an embarrassing typo. Turns out that my typo made us follow the spec, but the spec is not what we or anybody else implemented. Fun times. I added a test accounting for the proposed spec change. There's a different divergence between what does abscenter map to. Other browsers don't map `abscenter` at all, looks like, but it's in the spec. We may want to remove it, but for now I've left it in the test. Differential Revision: https://phabricator.services.mozilla.com/D39928
06b5dca91073b5b2a6b44bf0f9dd4999c794a721: Bug 1559814 - Use the cbindgen representation for grid line properties. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 26 Jun 2019 21:21:38 +0000 - rev 543067
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1559814 - Use the cbindgen representation for grid line properties. r=mats We clamp earlier (parse time rather than computed value time), but that's the only behavior change, which I think doesn't really matter. Differential Revision: https://phabricator.services.mozilla.com/D35198
9e01b4a3ac613e735d863ec922287c2dc7a0b0db: Bug 1559814 - Remove GetGridLine since it's dead code now that Stylo serializes all grid lines. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 26 Jun 2019 21:21:13 +0000 - rev 543065
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1559814 - Remove GetGridLine since it's dead code now that Stylo serializes all grid lines. r=mats Differential Revision: https://phabricator.services.mozilla.com/D35196
11ec9de590766855f98bdc3fbe839c0a1209c8e2: Bug 1559814 - Use the cbindgen representation for grid line properties. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 26 Jun 2019 20:33:23 +0000 - rev 543055
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1559814 - Use the cbindgen representation for grid line properties. r=mats We clamp earlier (parse time rather than computed value time), but that's the only behavior change, which I think doesn't really matter. Differential Revision: https://phabricator.services.mozilla.com/D35198
62f9d89fb827af89e810b728a54c2bb2024085e4: Bug 1559814 - Remove GetGridLine since it's dead code now that Stylo serializes all grid lines. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 26 Jun 2019 20:32:56 +0000 - rev 543053
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1559814 - Remove GetGridLine since it's dead code now that Stylo serializes all grid lines. r=mats Differential Revision: https://phabricator.services.mozilla.com/D35196
acf98e967abe248d16574757806f3a0f68579d3f: Bug 1559546 - Use atoms for grid line names. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 19 Jun 2019 05:58:11 +0000 - rev 542020
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1559546 - Use atoms for grid line names. r=mats The style system already atomizes all CustomIdent values, which means that we're just wasting memory and CPU by doing string copies all over the place. This patch fixes it. This also simplifies further changes to use as much of the rust data structures as possible. I had to switch from nsTHashtable to mozilla::HashTable because the former doesn't handle well non-default-constructible structs (like NamedLine, which now has a StyleAtom, which is not default-constructible). Differential Revision: https://phabricator.services.mozilla.com/D35119
26f9c324cf4214d4ec02ad860be5114471fed22e: Bug 1559545 - Use servo for the representation of grid template areas. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 18 Jun 2019 22:29:58 +0000 - rev 541979
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1559545 - Use servo for the representation of grid template areas. r=mats Right now we do a lot of useless string copying. In order to avoid transcoding to utf-16 during layout, make sure to use nsCString at a few related places. I may revisit this since we're storing other line names as atoms in some places. So it may be better to just use atoms everywhere. But that'd be a different patch either way. Depends on D35116 Differential Revision: https://phabricator.services.mozilla.com/D35117
75767e9242a57f3851a9f4b7557b034749d460eb: Bug 1559545 - Use more ffi-friendly types in grid template areas. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 17 Jun 2019 15:44:21 +0000 - rev 541978
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1559545 - Use more ffi-friendly types in grid template areas. r=mats Differential Revision: https://phabricator.services.mozilla.com/D35116
6b9cfebe807648f7c68f5a618f54cb0633298045: Bug 1488953 - Use a script runner for scrollport events. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 13 Jun 2019 02:30:25 +0000 - rev 541431
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1488953 - Use a script runner for scrollport events. r=mats This is consistent with the scroll area events too, and allows us to remove the WillPaintObserver stuff. Differential Revision: https://phabricator.services.mozilla.com/D5271
40f21ae9036167c130168e66506e974ef1cb406d: Bug 1552121 - Reftest for suppression of auto-hyphenation in words with internal capitals. r=mats
Jonathan Kew <jkew@mozilla.com> - Mon, 10 Jun 2019 15:00:29 +0000 - rev 540899
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1552121 - Reftest for suppression of auto-hyphenation in words with internal capitals. r=mats Differential Revision: https://phabricator.services.mozilla.com/D33956
004e0c127e77f222a9706d541e82641ad3f823fb: Bug 1552121 - Suppress auto-hyphenation of words with any internal capital letters. r=mats
Jonathan Kew <jkew@mozilla.com> - Mon, 10 Jun 2019 11:51:30 +0000 - rev 540898
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1552121 - Suppress auto-hyphenation of words with any internal capital letters. r=mats Differential Revision: https://phabricator.services.mozilla.com/D31408
642957575a596f1fcceed48deb95494afaa5c6fb: Bug 1557291 - Check the hyphenate-capitalized pref after resolving aliases/fuzzy matches. r=mats
Jonathan Kew <jkew@mozilla.com> - Mon, 10 Jun 2019 11:51:28 +0000 - rev 540897
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1557291 - Check the hyphenate-capitalized pref after resolving aliases/fuzzy matches. r=mats Differential Revision: https://phabricator.services.mozilla.com/D33936
c6de66b4781f55cf6a5961635d8c21f03348f75d: Bug 1555565 - Export correct user's preference for dark theme by prefers-color-scheme media query, r=mats
Martin Stransky <stransky@redhat.com> - Mon, 10 Jun 2019 09:43:27 +0000 - rev 540877
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1555565 - Export correct user's preference for dark theme by prefers-color-scheme media query, r=mats Differential Revision: https://phabricator.services.mozilla.com/D33133
3dd86c6f84681d2d3aa577873007353deecd1d2a: Bug 1552121 - Reftest for suppression of auto-hyphenation in words with internal capitals. r=mats
Jonathan Kew <jkew@mozilla.com> - Mon, 10 Jun 2019 09:38:47 +0000 - rev 540863
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1552121 - Reftest for suppression of auto-hyphenation in words with internal capitals. r=mats Differential Revision: https://phabricator.services.mozilla.com/D33956
c333e3fc63ca04c8f4957eb9a78fdcdd9ece1c93: Bug 1552121 - Suppress auto-hyphenation of words with any internal capital letters. r=mats
Jonathan Kew <jkew@mozilla.com> - Mon, 10 Jun 2019 09:39:16 +0000 - rev 540862
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1552121 - Suppress auto-hyphenation of words with any internal capital letters. r=mats Differential Revision: https://phabricator.services.mozilla.com/D31408
0b09ba0356f8f00e226ed855629a40792ca00ae0: Bug 1557291 - Check the hyphenate-capitalized pref after resolving aliases/fuzzy matches. r=mats
Jonathan Kew <jkew@mozilla.com> - Mon, 10 Jun 2019 09:39:16 +0000 - rev 540861
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1557291 - Check the hyphenate-capitalized pref after resolving aliases/fuzzy matches. r=mats Differential Revision: https://phabricator.services.mozilla.com/D33936
8646ea96944350a9e1b88881087011c582b94326: Bug 1488953 - Use a script runner for scrollport events. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 10 Jun 2019 03:06:25 +0000 - rev 540856
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1488953 - Use a script runner for scrollport events. r=mats This is consistent with the scroll area events too, and allows us to remove the WillPaintObserver stuff. Differential Revision: https://phabricator.services.mozilla.com/D5271
1731c1e39b8c6d3d100a6cb10d1a96a5a33fb7c8: Bug 1555565 - Export correct user's preference for dark theme by prefers-color-scheme media query, r=mats
Martin Stransky <stransky@redhat.com> - Fri, 07 Jun 2019 12:02:48 +0000 - rev 540663
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1555565 - Export correct user's preference for dark theme by prefers-color-scheme media query, r=mats Differential Revision: https://phabricator.services.mozilla.com/D33133
778464d9aac88b896b1f6901d1e7c6c6572f5929: Bug 1549267 Part 2 - Improve comments in LayoutConstants.h. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Thu, 06 Jun 2019 00:04:19 +0000 - rev 539883
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1549267 Part 2 - Improve comments in LayoutConstants.h. r=mats Differential Revision: https://phabricator.services.mozilla.com/D31697
23bbfebbe5834c6d6f9f4ae175c6b525ce4acfa6: Bug 1549267 Part 1 - Remove NS_INTRINSICSIZE and NS_AUTOHEIGHT. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Tue, 04 Jun 2019 23:41:20 +0000 - rev 539882
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1549267 Part 1 - Remove NS_INTRINSICSIZE and NS_AUTOHEIGHT. r=mats This patch is generated by the following steps. 1) Manually delete NS_INTRINSICSIZE and NS_AUTOHEIGHT in LayoutConstants. 2) Run the following script. ``` #!/bin/bash function rename() { find .\ -type f\ ! -path "./obj*"\ ! -path "./.git"\ ! -path "./.hg"\ \( -name "*.cpp" -or\ -name "*.h" \)\ -exec sed -i -e "s/$1/$2/g" "{}" \; } rename NS_INTRINSICSIZE NS_UNCONSTRAINEDSIZE rename NS_AUTOHEIGHT NS_UNCONSTRAINEDSIZE ``` 3) ./mach clang-format Differential Revision: https://phabricator.services.mozilla.com/D31696
d0f8414a088130c10e7af4f76cc0595eba7f841e: Bug 1556855 part 5: Update devtools css database. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 05 Jun 2019 18:23:10 +0000 - rev 539844
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1556855 part 5: Update devtools css database. r=mats This patch was generated automatically by running ./mach devtools-css-db Differential Revision: https://phabricator.services.mozilla.com/D33808
fdf0d6ca128831a476ca9c9a05316d1b495446e2: Bug 1556855 part 4: Remove support for the layout.css.prefixes.webkit pref. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 05 Jun 2019 18:23:02 +0000 - rev 539843
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1556855 part 4: Remove support for the layout.css.prefixes.webkit pref. r=mats From this point on, the webkit-prefixed CSS features that were previously protected by this pref will now be unconditionally enabled. Differential Revision: https://phabricator.services.mozilla.com/D33807
a09f9cdd1a0bca4db5c5be30aca8c6490101cbe0: Bug 1556855 part 3: Reduce indentation on some chunks of property_database.js that were moved in previous patch. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 05 Jun 2019 18:22:53 +0000 - rev 539842
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1556855 part 3: Reduce indentation on some chunks of property_database.js that were moved in previous patch. r=mats This patch only contains whitespace changes. Differential Revision: https://phabricator.services.mozilla.com/D33806
6ddf597109f6dcbd2d54d2a6f9bae5c701ad3663: Bug 1556855 part 2: Update tests to assume that 'layout.css.prefixes.webkit' is already true. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 05 Jun 2019 18:22:39 +0000 - rev 539841
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1556855 part 2: Update tests to assume that 'layout.css.prefixes.webkit' is already true. r=mats (The pref is about to be removed, but even before its removal, it defaults to 'true' so these tests don't need to bother setting/checking it.) Differential Revision: https://phabricator.services.mozilla.com/D33805
97c2f03da1f4919c6780ca44da39dd4babe3a352: Bug 1556855 part 1: Adjust tests that depend on being able to disable properties via the pref 'layout.css.prefixes.webkit'. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 05 Jun 2019 18:22:25 +0000 - rev 539840
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1556855 part 1: Adjust tests that depend on being able to disable properties via the pref 'layout.css.prefixes.webkit'. r=mats In particular: - The tests test_disabled_properties.html and test_animations_with_disabled_properties.html just want to be able to toggle some pref to turn off some property. So, this patch changes them to use a more recently-added pref-controlled property (-webkit-line-clamp). (We'll probably have to update these tests again when we eventually remove the pref for that property. Oh well.) - The tests 1265611-1.html and test_transitions_with_disabled_properties.html are more picky -- they require a pref-controlled property **whose initial value is 'currentcolor'**. We don't have any such property anymore, once the layout.css.prefixes.webkit pref is removed. For the crashtest, we might as well keep the test, with a disclaimer that its tested codepath has changed. And for the mochitest, we can't really "fix" the test, so let's just remove it. (We can take some comfort in knowing that the still-present test 'test_animations_with_disabled_properties' is very similar and covers some of the same codepaths.) Differential Revision: https://phabricator.services.mozilla.com/D33804
d0be9ca49bd74bf80de70031fc21ad4cd9f8f092: Bug 1539469 - Make all input elements display: inline-block, for compat with other UAs. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 04 Jun 2019 15:39:47 +0000 - rev 539670
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1539469 - Make all input elements display: inline-block, for compat with other UAs. r=mats See https://github.com/whatwg/html/issues/4082 for the data and some comments from Boris and David. I didn't look into fixing the font-inflation reftests, see bug 1540176 for that. Differential Revision: https://phabricator.services.mozilla.com/D25566
c354cbd93b6de88e8c31120040c81d32c554b484: Bug 1554150 - Hide some appearance values from content. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 03 Jun 2019 17:32:48 +0000 - rev 539519
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1554150 - Hide some appearance values from content. r=mats They're not used internally either, so remove all ability to address them. I haven't removed the implementation yet, as some of them are quite complex, and I don't have a mac / windows build. We should do that when this hits release though. Differential Revision: https://phabricator.services.mozilla.com/D32488
2da22c06471787c3547b604adbe3e67c45ac5bd6: Bug 1553731 - Part 3: Make nsIFrame::Is___Frame() avoid reading from memory. r=mats
Cameron McCormack <cam@mcc.id.au> - Sat, 01 Jun 2019 08:03:42 +0000 - rev 539343
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1553731 - Part 3: Make nsIFrame::Is___Frame() avoid reading from memory. r=mats Differential Revision: https://phabricator.services.mozilla.com/D32605
eec771e04586c7d67fa96f7d4850323bd50143a5: Bug 1553731 - Part 2: Generate FrameIdList.h and FrameTypeList.h from Python. r=mats,glandium
Cameron McCormack <cam@mcc.id.au> - Sat, 01 Jun 2019 08:03:40 +0000 - rev 539342
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1553731 - Part 2: Generate FrameIdList.h and FrameTypeList.h from Python. r=mats,glandium Differential Revision: https://phabricator.services.mozilla.com/D32604
5b78e292000498950201c6963c4f9070f2e0dcd7: Bug 1553731 - Part 1: Rename nsFrameIdList.h to FrameIdList.h. r=mats
Cameron McCormack <cam@mcc.id.au> - Sat, 01 Jun 2019 08:03:32 +0000 - rev 539341
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1553731 - Part 1: Rename nsFrameIdList.h to FrameIdList.h. r=mats Differential Revision: https://phabricator.services.mozilla.com/D32603
cfac49a18cf1c256575dec5a681ad85c6e09e9ee: Bug 1488871 - Don't flush layout in AsyncScrollPortEvent::Run. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 01 Jun 2019 03:25:46 +0000 - rev 539335
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1488871 - Don't flush layout in AsyncScrollPortEvent::Run. r=mats I'd claim that we don't need it because, in order to enqueue the event, we already need to have overflowed the event in a normal reflow. For now this should not break anything (or anything that wasn't already racy depending on when we paint). The only reason the flush is there is according to roc is to decide whether to fire the event, and because it needs the layout information: https://bugzilla.mozilla.org/show_bug.cgi?id=771822#c4 In practice, however, all the layout information we need we have already computed by the time we post the event. We don't expose the rects via the event details, which is what could get out-of-date, so this patch could only mean that we fire the event slightly more often in cases where people remove stuff from the DOM, right after we do layout and the content has overflowed. But that's actually pretty unlikely. This event in general is pretty problematic because it exposes when we do layout and when we paint, which is not great. Its test coverage is also pretty low (test_overflow_event.html, which of course still passes without this). I still want to do this change first since it's trivial to back out if needed. Then I'd want to change how it fires to match the scrolled area change event (which would allow us to remove the WillPaintObserver stuff), after verifying that chrome consumers are still fine with that, and then put behind a pref and hide it from content, while we leave time for chrome consumers to migrate away from it, and allow us to revert if something breaks. Differential Revision: https://phabricator.services.mozilla.com/D5082
90ed9808e1c0bc5216022e15c32a7eb3704ce20d: Bug 1553731 - Part 3: Make nsIFrame::Is___Frame() avoid reading from memory. r=mats
Cameron McCormack <cam@mcc.id.au> - Sat, 01 Jun 2019 01:04:54 +0000 - rev 539325
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1553731 - Part 3: Make nsIFrame::Is___Frame() avoid reading from memory. r=mats Differential Revision: https://phabricator.services.mozilla.com/D32605
b8669aa5a820bd291c7ce9b9a61be1c97bff7506: Bug 1553731 - Part 2: Generate FrameIdList.h and FrameTypeList.h from Python. r=mats,glandium
Cameron McCormack <cam@mcc.id.au> - Sat, 01 Jun 2019 01:04:46 +0000 - rev 539324
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1553731 - Part 2: Generate FrameIdList.h and FrameTypeList.h from Python. r=mats,glandium Differential Revision: https://phabricator.services.mozilla.com/D32604
0d0bf5d84a3cb5852047338e8f2e020e1a9b1b62: Bug 1553731 - Part 1: Rename nsFrameIdList.h to FrameIdList.h. r=mats
Cameron McCormack <cam@mcc.id.au> - Sat, 01 Jun 2019 01:04:44 +0000 - rev 539323
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1553731 - Part 1: Rename nsFrameIdList.h to FrameIdList.h. r=mats Differential Revision: https://phabricator.services.mozilla.com/D32603
9d54e34f7f6639440004a224fe0eff9a3999ac17: Bug 1539366 - Avoid calling AreOnSameLine once we know we've already changed lines since it can be expensive to compute. r=mats
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 27 May 2019 20:38:46 +0000 - rev 538606
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1539366 - Avoid calling AreOnSameLine once we know we've already changed lines since it can be expensive to compute. r=mats Differential Revision: https://phabricator.services.mozilla.com/D26650