searching for reviewer(masayuki)
4128709439219bdd3ff28ad298cd71568433a0c5: Bug 1571375 - Don't remove white space when committing composition. r=masayuki, a=RyanVM
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Wed, 18 Sep 2019 03:56:25 +0000 - rev 555268
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1571375 - Don't remove white space when committing composition. r=masayuki, a=RyanVM This is regression by bug 1530649. After landing bug 1530649, we try to scan end point of replacement text. But in this bug's situation, afterRun becomes same as current ws run by landing bug 1530649. To get white space type of next of replacement end, we have to scan around end point again. Differential Revision: https://phabricator.services.mozilla.com/D45947
e5bdd7763d2da5674bbc180bd9170b86a2ed6cc8: Bug 1579788 - Downgrade a few assertions in beta / release as to avoid crashing there. r=masayuki a=lizzard
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 12 Sep 2019 11:24:21 +0300 - rev 554986
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1579788 - Downgrade a few assertions in beta / release as to avoid crashing there. r=masayuki a=lizzard Summary: This is the only short-term fix for now until we fix editor or find a test-case... This will keep asserting on Nightly, but the correctness issue it'd show in release (some pseudo-classes not matching) is better than crashing. Reviewers: heycam, masayuki Reviewed By: masayuki Bug #: 1579788 Differential Revision: https://phabricator.services.mozilla.com/D45575
10b0a2e34429cb716ae206ff7daf32ac074a57ac: Bug 1577685 - Move some utility functions from IMEStateManager to widget. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Fri, 30 Aug 2019 05:56:58 +0000 - rev 554776
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1577685 - Move some utility functions from IMEStateManager to widget. r=masayuki I would like to log `IMEState` and `InputContextAction`in widget. But this utilities are in `IMEStateManager`, so I would like to move it to widget by using `mozilla/ToString.h`. Differential Revision: https://phabricator.services.mozilla.com/D44103
dd6e8cc3c3d4d155c69de00c8357d45a8e5d94b7: Bug 1564788. Remove unnecessary null check from PrintPreviewUserEventSuppressor::HandleEvent. r=masayuki
Jonathan Watt <jwatt@jwatt.org> - Tue, 23 Jul 2019 01:50:03 +0000 - rev 554603
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1564788. Remove unnecessary null check from PrintPreviewUserEventSuppressor::HandleEvent. r=masayuki Most other overrides of nsIDOMEventListener::HandleEvent don't null check aEvent at all. This method should never be called without an event. Differential Revision: https://phabricator.services.mozilla.com/D38906
160da901fc3e63632497c1d42b3ebd7e84892224: Bug 1572939 - part2 : remove editable content tests. r=masayuki
alwu <alwu@mozilla.com> - Tue, 27 Aug 2019 04:46:13 +0000 - rev 553763
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1572939 - part2 : remove editable content tests. r=masayuki As we will allow user inputs on editable content to activate document, we should remove them from black list test. Differential Revision: https://phabricator.services.mozilla.com/D43533
2ba2516d4a2c9d353a724b8c433701bf1b9df329: Bug 1572939 - part1 : allow user inputs on editable content to activate document. r=masayuki
alwu <alwu@mozilla.com> - Tue, 27 Aug 2019 04:45:05 +0000 - rev 553762
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1572939 - part1 : allow user inputs on editable content to activate document. r=masayuki As Chrome and Safari didn't block autoplay when haiving user input on editable content, it causes a compatible issue on Firefox because we only allow user inputs happening on non-editable content to activate document. It seems that we don't really need to restrict that user inputs, which can activate document, should only occur on non-editable content. Even if they occur on non-editable content, it might still have a chance to annoy user, it's totally depending on websites' design. Differential Revision: https://phabricator.services.mozilla.com/D43532
c8fcbaade215ecf3cd353b4196787d8c5826527a: Bug 1575584: prevent reading uninitialized variable in `TextEditor::ComputeValueInternal`. r=masayuki
Mirko Brodesser <mbrodesser@mozilla.com> - Fri, 23 Aug 2019 09:25:00 +0000 - rev 553313
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1575584: prevent reading uninitialized variable in `TextEditor::ComputeValueInternal`. r=masayuki The fix here is to first check `NS_FAILED(rv)`, because if that's the case, `cancel` wasn't necessarily set to a value. As best practice I initialized `cancel` and `handled` with default values. Differential Revision: https://phabricator.services.mozilla.com/D43071
8b40b616dbff58f7fbfd304f2bdd31652dae9837: Bug 1574596 - Keep editing UI until PresShell is really gone. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Wed, 21 Aug 2019 06:05:16 +0000 - rev 553099
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1574596 - Keep editing UI until PresShell is really gone. r=masayuki This is regression by bug 1543312. By bug 1543312, we destroy editor when destroying PresShell. But when destroying PresShell, editor doesn't remove anonymous content of editing UI from PresShell. Then, when destroying the frame manager in `PresShell::Destroy`, it hits assertion due to uncomposed doc. We shouldn't hide editing UI during destroying PresShell and we should hide it after destroyed. Differential Revision: https://phabricator.services.mozilla.com/D42773
e5549942df83c31af0d23e897bab110031eecb95: Bug 1574223, make touchstart/move passive by default also when using event handlers, not only event listeners, r=masayuki
Olli Pettay <Olli.Pettay@helsinki.fi> - Fri, 16 Aug 2019 15:18:46 +0000 - rev 552378
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1574223, make touchstart/move passive by default also when using event handlers, not only event listeners, r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D42235
2fce06fd642bada80669049de12f9b15924c979b: Bug 1438996. Don't construct a unneeded temporary range object in RangeUtils::CompareNodeToRange. r=masayuki
Timothy Nikkel <tnikkel@gmail.com> - Thu, 15 Aug 2019 21:13:54 +0000 - rev 552115
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1438996. Don't construct a unneeded temporary range object in RangeUtils::CompareNodeToRange. r=masayuki nsContentUtils::ComparePoints just immediately deconstructs the range boundary into container and offset and calls a version of nsContentUtils::ComparePoints that takes containers/offsets instead of range boundaries. This also avoids a warning in the RangeBoundary constructor. Differential Revision: https://phabricator.services.mozilla.com/D42071
8cc56f3f8a0881cdc99356d545117c03997a34a9: Bug 1573119: declare more methods around `HTMLEditor` `const`/`static`. r=masayuki
Mirko Brodesser <mbrodesser@mozilla.com> - Tue, 13 Aug 2019 07:34:11 +0000 - rev 551359
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1573119: declare more methods around `HTMLEditor` `const`/`static`. r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D41524
66e8aafac348952cd16aec2c691afa5f0c9a66be: Bug 1543312 - Tear down editor when PresShell is destroyed. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Tue, 13 Aug 2019 02:00:00 +0000 - rev 551352
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1543312 - Tear down editor when PresShell is destroyed. r=masayuki When browsing reported site (https://minecraft.curseforge.com/), user that uses Android cannot set caret on some editable contents. GV's IME code uses `NOTIFY_IME_OF_SELECTION_CHANGE` to update selection on native IME. But GV doesn't receives this notification on this reported site. This notification is fired by editor's selection listener, but when this occurs, this notification is no logner fired unfortunately. Because selection listener isn't registered by current selection. At first, editor registers selection listener by `EditorBase::Init`. But like test case, if PresShell is destroyed after editor is created, this registration is no longer used, and we have to register it by new selection again. So we should tear down editor when PresShell is destroyed. (or we have to add a way to re-initialize selection listener?) This isn't related to Android. Android's IME code depends on this notification, so this occurs easily. Also, `PresShell::SetCaretEnabled` only works when caret is valid (`PresShell::GetCaret` has caret). If caret is nothing, it hits assertion. And, attached test case is reproduced sample. Differential Revision: https://phabricator.services.mozilla.com/D41356
8fc745a7fb86b9d1af138735f9752ce2827824d5: Bug 1572715: part 2) Make some methods around `HTMLEditor` const-correct. r=masayuki
Mirko Brodesser <mbrodesser@mozilla.com> - Mon, 12 Aug 2019 08:31:04 +0000 - rev 551183
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1572715: part 2) Make some methods around `HTMLEditor` const-correct. r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D41385
710947b25081ea2da6477550e9ad068bf117e975: Bug 1572715: part 1) Factor out `WSRunScanner` from `WSRunObject`. r=masayuki
Mirko Brodesser <mbrodesser@mozilla.com> - Mon, 12 Aug 2019 08:30:57 +0000 - rev 551182
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1572715: part 1) Factor out `WSRunScanner` from `WSRunObject`. r=masayuki This allows users of `WSRunScanner`'s functionality to pass a `const HTMLEditor*`, allowing themselves to become const-correct. Differential Revision: https://phabricator.services.mozilla.com/D41384
d89fd391a5523b8f6dd527d3191a36047a657467: Bug 1571621 - Convert VarCache prefs in HTMLEditor.cpp to static prefs. r=masayuki
Nicholas Nethercote <nnethercote@mozilla.com> - Tue, 06 Aug 2019 08:49:32 +0000 - rev 550240
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1571621 - Convert VarCache prefs in HTMLEditor.cpp to static prefs. r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D40775
8a0763d975aae456b2cf4b5ddbc6ebff287293d7: Bug 1570719 - Skip more elements in spellcheck for MailNews. r=masayuki
Jorg K <jorgk@jorgk.com> - Fri, 02 Aug 2019 10:49:17 +0200 - rev 549648
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1570719 - Skip more elements in spellcheck for MailNews. r=masayuki
cea84d44c6a2758719340bf3e86b9a73285d7e57: Bug 1570861 - Editor should store text node in mCachedSelectionNode to pass previous selected node/offset to spell checker r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Fri, 02 Aug 2019 07:44:20 +0000 - rev 549637
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1570861 - Editor should store text node in mCachedSelectionNode to pass previous selected node/offset to spell checker r=masayuki When using `<textarea>`, spell checker sometimes check spell when editing last text node. Because editor passes invalid previous selection node and offset via `HandleInlineSpellCheck`. Although previous selected node uses `mCachedSelectionNode` that is stored by `BeforeEdit`, when this occurs, it isn't text node. When editing last text node in `<textarea>`, anchror node might be root node, not current text node. So we should use text node instead when this is inserting text operation. Differential Revision: https://phabricator.services.mozilla.com/D40368
fa68a5b78e08d8a67c32e1dac8d65ca222f90a08: Bug 1517477 - Upgrade Hunspell to version 1.7.0. r=masayuki
Ryan VanderMeulen <ryanvm@gmail.com> - Wed, 03 Jul 2019 16:18:23 +0000 - rev 545422
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1517477 - Upgrade Hunspell to version 1.7.0. r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D15652
022a270e63d9c9360be162ac7f457725e213b86d: Bug 1570861 - Editor should store text node in mCachedSelectionNode to pass previous selected node/offset to spell checker r=masayuki a=RyanVM
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Fri, 02 Aug 2019 07:44:20 +0000 - rev 545052
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1570861 - Editor should store text node in mCachedSelectionNode to pass previous selected node/offset to spell checker r=masayuki a=RyanVM When using `<textarea>`, spell checker sometimes check spell when editing last text node. Because editor passes invalid previous selection node and offset via `HandleInlineSpellCheck`. Although previous selected node uses `mCachedSelectionNode` that is stored by `BeforeEdit`, when this occurs, it isn't text node. When editing last text node in `<textarea>`, anchror node might be root node, not current text node. So we should use text node instead when this is inserting text operation. Differential Revision: https://phabricator.services.mozilla.com/D40368
9005dd228db53f620ea6c1fb96989053966dab22: Bug 1178763, move UIEvent.pageX/pageY to MouseEvent, r=masayuki
Olli Pettay <Olli.Pettay@helsinki.fi> - Thu, 04 Jul 2019 01:50:22 +0000 - rev 544063
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1178763, move UIEvent.pageX/pageY to MouseEvent, r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D36781
88e9ed06620ee0654795181f998b7210eee942d0: Bug 1556103 - Part 1. Add long press action when setting focus. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Fri, 28 Jun 2019 00:39:45 +0000 - rev 544042
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1556103 - Part 1. Add long press action when setting focus. r=masayuki Actually, long tap can set focus. But since it uses `nsIFocusManager::FLAG_BYMOUSE` flag, we cannot recognize whether setting focus is by long tap or not. So I would like to add new flag `FLAG_BYLONGPRESS` and `CAUSE_LONGPRESS` that are by long tap. Differential Revision: https://phabricator.services.mozilla.com/D35991
109ccdeb96342a315b86ef0c7ebe76738308673b: Bug 1562655: rename `Selection::HasSameRoot` to `HasSameRootOrSameComposedDoc`. r=masayuki
Mirko Brodesser <mbrodesser@mozilla.com> - Mon, 01 Jul 2019 17:20:28 +0200 - rev 543791
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1562655: rename `Selection::HasSameRoot` to `HasSameRootOrSameComposedDoc`. r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D36492
423026d65fe92abe9a22c10af78056be2bddcad3: Bug 1560517 - Add update script and patch files for hunspell library r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Fri, 21 Jun 2019 18:57:35 +0000 - rev 542662
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1560517 - Add update script and patch files for hunspell library r=masayuki Add `update.sh` script and patch files to update hunspell library easily. Differential Revision: https://phabricator.services.mozilla.com/D35516
164ae5b4ff067240721f51c4917961048de3a6d0: Bug 1549930 addendum - Notify widgets of IME blur on quit (on non-Android). r=masayuki
Henri Sivonen <hsivonen@hsivonen.fi> - Mon, 17 Jun 2019 04:51:29 +0000 - rev 541914
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1549930 addendum - Notify widgets of IME blur on quit (on non-Android). r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D34992
05f0605563106e546d131074bcbd397d1fd9b494: Bug 1549930 - Avoid popping BrowserParent in response to window lowering. r=masayuki
Henri Sivonen <hsivonen@hsivonen.fi> - Fri, 14 Jun 2019 07:02:18 +0000 - rev 541913
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1549930 - Avoid popping BrowserParent in response to window lowering. r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D30873
89f2a15823bc3c64a5e2b55c0d593b4e3949d2a7: Bug 1558704 - Fix spellchecker when XUL is loaded as XHTML r=masayuki
Brendan Dahl <bdahl@mozilla.com> - Thu, 13 Jun 2019 11:53:12 +0000 - rev 541551
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1558704 - Fix spellchecker when XUL is loaded as XHTML r=masayuki Temporary workaround to use the document element as the root content node in XHTML pages that have a XUL root element. Differential Revision: https://phabricator.services.mozilla.com/D34657
c259c1017aa193b8b4a2031488aab0dc779b3a2f: Bug 1557231. Stop using [array] in nsIInlineSpellChecker. r=masayuki
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 06 Jun 2019 06:59:37 +0000 - rev 540415
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1557231. Stop using [array] in nsIInlineSpellChecker. r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D33908
325b4a93e95a609fec789dd015c8c84dead86499: Bug 1556656 - Restrict script access for some methods in nsIEditingSession r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Thu, 06 Jun 2019 05:31:16 +0000 - rev 539898
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1556656 - Restrict script access for some methods in nsIEditingSession r=masayuki Some methods in `nsIEditingSession` isn't used from script. So we should move these to `nsEditingSession` or add `[noscript]`. Differential Revision: https://phabricator.services.mozilla.com/D33606
8a3012b4964721cd2bf5800dd910f842901b0d22: Bug 1556799 - Remove manual NAC as soon as parent chain changes. r=masayuki
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 06 Jun 2019 01:48:10 +0000 - rev 539892
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1556799 - Remove manual NAC as soon as parent chain changes. r=masayuki Having NAC bound to the tree when not connected is not quite fine, make sure to clean up properly. Differential Revision: https://phabricator.services.mozilla.com/D33704
da42679e0f9aaab9e950bbb22df89fba3c65208b: Bug 1556925 part 2. Stop using [array] in mozISpellCheckingEngine.getDictionaryList. r=masayuki
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 05 Jun 2019 12:57:32 +0000 - rev 539803
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1556925 part 2. Stop using [array] in mozISpellCheckingEngine.getDictionaryList. r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D33744
8e68aafb0f3cbd0799302a64ef647d1fa5534d88: Bug 1556925 part 1. Stop using [array] in mozISpellCheckingEngine.suggest. r=masayuki
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 05 Jun 2019 12:50:13 +0000 - rev 539802
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1556925 part 1. Stop using [array] in mozISpellCheckingEngine.suggest. r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D33743
9c513f0d9c67fc9545de85e471a5fe0f1ccb4643: Bug 1556922. Stop using [array] in nsIEditorSpellCheck. r=masayuki
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 05 Jun 2019 04:07:28 +0000 - rev 539748
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1556922. Stop using [array] in nsIEditorSpellCheck. r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D33742
1a77272644bc3d6706edb8b6b83b39012d97bcbf: Bug 1551835 - Add Google Docs back to legacy keycode allowlist. r=masayuki
Mike Taylor <miket@mozilla.com> - Tue, 04 Jun 2019 13:52:39 +0000 - rev 539651
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1551835 - Add Google Docs back to legacy keycode allowlist. r=masayuki Google is aware of the reported issue, but have asked us to opt back into legacy behavior until they can investigate and deploy a fix. Differential Revision: https://phabricator.services.mozilla.com/D33541
9b8cf182a743e50fab37a4a10294ee62e1099a8c: Bug 1415270 - Part 3: Prevent the editing APIs from being called on non-HTML documents; r=masayuki
Ehsan Akhgari <ehsan@mozilla.com> - Thu, 30 May 2019 17:14:05 +0000 - rev 539239
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1415270 - Part 3: Prevent the editing APIs from being called on non-HTML documents; r=masayuki This is similar to this Chromium change: https://codereview.chromium.org/1155353002 The editing spec doesn't mention editing non-HTML documents, and historically this is only a feature that WebKit has supported. Supporting this feature increases the attack surface of the browser without a clear benefit, so it seems like a good idea to converge on this behaviour. Differential Revision: https://phabricator.services.mozilla.com/D32913
060d26dc9d2f5410b140c6619634d44dd4be3125: Bug 1415270 - Part 2: Enable editing support for non-HTML documents as well; r=masayuki
Ehsan Akhgari <ehsan@mozilla.com> - Fri, 31 May 2019 01:38:58 +0000 - rev 539238
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1415270 - Part 2: Enable editing support for non-HTML documents as well; r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D32912
7910719718f46dfaef7b6124e72b8c2ed2db60f6: Bug 1415270 - Part 1: Move nsHTMLDocument editing APIs to Document; r=farre,masayuki
Ehsan Akhgari <ehsan@mozilla.com> - Fri, 31 May 2019 01:37:26 +0000 - rev 539237
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1415270 - Part 1: Move nsHTMLDocument editing APIs to Document; r=farre,masayuki Differential Revision: https://phabricator.services.mozilla.com/D32911
7576696daadb68ac6bf3dd8614e4d90a4dc79eb8: Bug 1554998 - Fix the handling of numeric characters by word-break:break-all. r=masayuki
Jonathan Kew <jkew@mozilla.com> - Wed, 29 May 2019 12:05:20 +0000 - rev 538925
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1554998 - Fix the handling of numeric characters by word-break:break-all. r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D32969
febbc0b025c5ab6d1d96516698fe4374e6d7f63e: Bug 1543439 - Part 3: change and click event fired from browser UI should be considered as an user interaction event; r=masayuki
Edgar Chen <echen@mozilla.com> - Mon, 27 May 2019 12:50:33 +0000 - rev 538868
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1543439 - Part 3: change and click event fired from browser UI should be considered as an user interaction event; r=masayuki In general case, we set `IsHandlingUserInput` flag in `PresShell::EventHandler::HandleEventWithCurrentEventInfo()` for user interaction event. However the interaction could happen on parent process, like e10s select and input date etc., whose dropdown/popup menu is implemented on parent process and it sends the interaction result to content process, then generates/dispatches corresponding event on content process directly. For such case, we need an addition hook before calling the event listener, just like what we do for popup blocker. It also makes more sense that we handle `popup blocker state` and `IsHandlingUserInput` flag at a consistent time. Differential Revision: https://phabricator.services.mozilla.com/D32020
ffc50cffcf1e0e2362db446bf3415b894bd05a85: Bug 1543439 - Part 2: Move is-user-interaction checks out of PresShell::EventHandler::PrepareToDispatchEvent; r=masayuki
Edgar Chen <echen@mozilla.com> - Mon, 27 May 2019 10:14:06 +0000 - rev 538867
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1543439 - Part 2: Move is-user-interaction checks out of PresShell::EventHandler::PrepareToDispatchEvent; r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D32019
750e3e013c4cd367bb20592bb6693dee0125dede: Bug 1543439 - Part 1: Move special handling for MouseDown/Up event out of AutoHandlingUserInputStatePusher; r=masayuki
Edgar Chen <echen@mozilla.com> - Wed, 29 May 2019 07:48:16 +0000 - rev 538866
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1543439 - Part 1: Move special handling for MouseDown/Up event out of AutoHandlingUserInputStatePusher; r=masayuki PresShell::EventHandler::HandleEventWithCurrentEventInfo is the only possible place will do such handling; other places pass either a nullptr or a non-MouseDown/Up event. Differential Revision: https://phabricator.services.mozilla.com/D32431
79436da3bf790b64e33d87f48ee9e2d3a315b109: Bug 1549930 - Avoid popping BrowserParent in response to window lowering. r=masayuki
Henri Sivonen <hsivonen@hsivonen.fi> - Mon, 27 May 2019 12:22:37 +0000 - rev 538557
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1549930 - Avoid popping BrowserParent in response to window lowering. r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D30873
5efa9947f556303da0f08a4d8d47d6edd547e72e: Bug 1520456 - test_CF_HTML_clipboard.html should skip non-mac platform instead of detecting platform in html file. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Fri, 24 May 2019 06:28:02 +0000 - rev 538178
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1520456 - test_CF_HTML_clipboard.html should skip non-mac platform instead of detecting platform in html file. r=masayuki test_CF_HTML_clipboard.html does nothing if platform isn't mac. But according to intermittent failure log, this is often failure on Android. I guess that this is infra issue, but we should use skip-if to avoid this failure instead. Differential Revision: https://phabricator.services.mozilla.com/D32413
cc747448727b98078f1369335a61e84fd80bd015: Bug 1550927. Stop using idl [array] for getting supported controller commands. r=masayuki
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 21 May 2019 17:06:06 +0000 - rev 537629
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1550927. Stop using idl [array] for getting supported controller commands. r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D30764
f6b2612701f631484e59c793308e955b01eada99: Bug 1551086 - Do not finish edit action when unbinding the frame from the editing state. r=masayuki
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 20 May 2019 05:53:24 +0000 - rev 537346
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1551086 - Do not finish edit action when unbinding the frame from the editing state. r=masayuki The code here was introduced to fix bug 1053048, but the test there and the test-case there no longer need this, and it's generally unsound to do stuff that changes the state of the input from UnbindFromFrame(). I'll file a new bug for the bogus disabled styling in the test-case in a second. I don't know how to add a test for this (no less because the testcase crashes on debug builds regardless of this patch, see bug 1551192). Differential Revision: https://phabricator.services.mozilla.com/D30914
f0a9bc62b3840bb3da69b86c6e8e6751289053f3: Bug 1549930 addendum - Notify widgets of IME blur on quit (on non-Android). r=masayuki, a=jcristau
Henri Sivonen <hsivonen@hsivonen.fi> - Mon, 17 Jun 2019 04:51:29 +0000 - rev 537036
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1549930 addendum - Notify widgets of IME blur on quit (on non-Android). r=masayuki, a=jcristau Differential Revision: https://phabricator.services.mozilla.com/D34992
382204429011c89910e360eb3f889b371c020cd5: Bug 1549930 - Avoid popping BrowserParent in response to window lowering. r=masayuki, a=jcristau
Henri Sivonen <hsivonen@hsivonen.fi> - Fri, 14 Jun 2019 07:02:18 +0000 - rev 537035
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1549930 - Avoid popping BrowserParent in response to window lowering. r=masayuki, a=jcristau Differential Revision: https://phabricator.services.mozilla.com/D30873
f787bc6258149666dd364f2d559c032a4b1a07e2: Bug 1554998 - Fix the handling of numeric characters by word-break:break-all. r=masayuki a=jcristau
Jonathan Kew <jkew@mozilla.com> - Wed, 29 May 2019 12:05:20 +0000 - rev 536601
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1554998 - Fix the handling of numeric characters by word-break:break-all. r=masayuki a=jcristau Differential Revision: https://phabricator.services.mozilla.com/D32969
7f83ca2147b8a9f3b7e5e6c6c5daae76be1c82a8: Bug 1520456 - test_CF_HTML_clipboard.html should skip non-mac platform instead of detecting platform in html file. r=masayuki a=test-only DEVEDITION_68_0b5_BUILD1 DEVEDITION_68_0b5_RELEASE FENNEC_68_0b5_BUILD1 FENNEC_68_0b5_RELEASE FIREFOX_68_0b5_BUILD1 FIREFOX_68_0b5_RELEASE
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Fri, 24 May 2019 06:28:02 +0000 - rev 536490
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1520456 - test_CF_HTML_clipboard.html should skip non-mac platform instead of detecting platform in html file. r=masayuki a=test-only test_CF_HTML_clipboard.html does nothing if platform isn't mac. But according to intermittent failure log, this is often failure on Android. I guess that this is infra issue, but we should use skip-if to avoid this failure instead. Differential Revision: https://phabricator.services.mozilla.com/D32413
66cff9aa39bcbf1b39aaf21c6759d1c97ad2fe1b: Bug 1174452: Part 2 -- scan `nsTextNode`'s parent element for preformat in nsDocumentEncoder r=masayuki,hsivonen
Mirko Brodesser <mbrodesser@mozilla.com> - Thu, 09 May 2019 07:40:47 +0000 - rev 535648
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1174452: Part 2 -- scan `nsTextNode`'s parent element for preformat in nsDocumentEncoder r=masayuki,hsivonen This takes into account `white-space: pre` style of `nsTextNode`'s parent element when formatting the selected text of the `nsTextNode` node. Differential Revision: https://phabricator.services.mozilla.com/D29159
adb37249163ee7243b14417e5771faa8564c985e: Bug 1543578 - Avoid synthetizing BrowserParent IME focus change when opening a menu. r=masayuki
Henri Sivonen <hsivonen@hsivonen.fi> - Thu, 09 May 2019 13:42:22 +0000 - rev 535232
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1543578 - Avoid synthetizing BrowserParent IME focus change when opening a menu. r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D28470