searching for reviewer(m_kato)
2b2c323a6352: Bug 1503744 - Make HTMLEditor::SetHTMLBackgroundColorWithTransaction() not refer RefPtr after moving it. r=m_kato a=jcristau
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 05 Nov 2018 02:13:05 +0000 - rev 501040
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1503744 - Make HTMLEditor::SetHTMLBackgroundColorWithTransaction() not refer RefPtr after moving it. r=m_kato a=jcristau Simple fix of crash caused by referring nullptr. Differential Revision: https://phabricator.services.mozilla.com/D10705
92c8efea7714: Bug 1484126 - part 21: Rewrite some loops in HTMLTableEditor.cpp with CellData::NextColumnIndex() or CellData::NextRowIndex() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 16 Oct 2018 01:10:44 +0000 - rev 499846
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1484126 - part 21: Rewrite some loops in HTMLTableEditor.cpp with CellData::NextColumnIndex() or CellData::NextRowIndex() r=m_kato A lot of loops in HTMLTableEditor.cpp scans cells along column-axis or row-axis. In those cases, they need to skip columns/rows which are spanned from prior column/row. So, we can rewrite them with CellData::NextColumnIndex() or CellData::NextRowColumn(). Differential Revision: https://phabricator.services.mozilla.com/D8358
19605351b361: Bug 1484126 - part 20: Replace |CellData::mFirst.mColumn + CellData::mEffectiveColSpan| with CellData::NextColumnIndex() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 15 Oct 2018 11:37:38 +0000 - rev 499845
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1484126 - part 20: Replace |CellData::mFirst.mColumn + CellData::mEffectiveColSpan| with CellData::NextColumnIndex() r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D8357
35c3aff251f0: Bug 1484126 - part 19: Replace |CellData::mCurrent.mColumn + CellData::NumberOfFollowingColumns()| with CellData::LastColumnIndex() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 15 Oct 2018 11:35:33 +0000 - rev 499844
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1484126 - part 19: Replace |CellData::mCurrent.mColumn + CellData::NumberOfFollowingColumns()| with CellData::LastColumnIndex() r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D8356
8a2722c90ac9: Bug 1484126 - part 18: Make HTMLEditor::InsertTableCellsWithTransaction() use CellData::NextColumnIndex() instead of |CellData::mCurrent::mColumn + CellData::mColSpan| r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 15 Oct 2018 11:35:10 +0000 - rev 499843
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1484126 - part 18: Make HTMLEditor::InsertTableCellsWithTransaction() use CellData::NextColumnIndex() instead of |CellData::mCurrent::mColumn + CellData::mColSpan| r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D8355
cbb895793f89: Bug 1484126 - part 17: Make all CellData users refer CellData::mIsSelected directly r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 15 Oct 2018 11:34:40 +0000 - rev 499842
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1484126 - part 17: Make all CellData users refer CellData::mIsSelected directly r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D8354
4c70964d90fd: Bug 1484126 - part 16: Replace |CellData::mEffectiveColSpan - 1| with CellData::NumberOfFollowingColumns() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 15 Oct 2018 11:34:06 +0000 - rev 499841
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1484126 - part 16: Replace |CellData::mEffectiveColSpan - 1| with CellData::NumberOfFollowingColumns() r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D8353
e5c8e5cbaf3d: Bug 1484126 - part 15: Make all CellData users refer CellData::mEffectiveColspan directly r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 15 Oct 2018 11:33:33 +0000 - rev 499840
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1484126 - part 15: Make all CellData users refer CellData::mEffectiveColspan directly r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D8352
ed17432df28c: Bug 1484126 - part 14: Replace |CellData::mEffectiveRowSpan - 1| with CellData::NumberOfFollowingRows() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 15 Oct 2018 11:15:15 +0000 - rev 499839
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1484126 - part 14: Replace |CellData::mEffectiveRowSpan - 1| with CellData::NumberOfFollowingRows() r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D8351
3e1b1e01e6a4: Bug 1484126 - part 13: Make all CellData users refer CellData::mEffectiveRowSpan directly r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 15 Oct 2018 10:44:08 +0000 - rev 499838
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1484126 - part 13: Make all CellData users refer CellData::mEffectiveRowSpan directly r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D8350
e0cea47221b8: Bug 1484126 - part 12: Make all CellData users refer CellData::mColSpan directly r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 15 Oct 2018 08:22:29 +0000 - rev 499837
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1484126 - part 12: Make all CellData users refer CellData::mColSpan directly r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D8349
6ab5dd75fbf4: Bug 1484126 - part 11: Make all CellData users refer CellData.mRowSpan directly r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 15 Oct 2018 08:14:18 +0000 - rev 499836
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1484126 - part 11: Make all CellData users refer CellData.mRowSpan directly r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D8348
3e9c08f4f705: Bug 1484126 - part 10: Replace all comparisons of CellData::mFirst.mColumn and CellData::mCurrent.mColumn with CellData::IsSpannedFromOtherColumn() or CellData::IsSpannedFromOtherRowOrColumn() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 15 Oct 2018 08:06:14 +0000 - rev 499835
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1484126 - part 10: Replace all comparisons of CellData::mFirst.mColumn and CellData::mCurrent.mColumn with CellData::IsSpannedFromOtherColumn() or CellData::IsSpannedFromOtherRowOrColumn() r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D8347
8f7afde0a6f6: Bug 1484126 - part 9: Make all CellData users refer CellData::mFirst.mColumn directly r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 15 Oct 2018 07:37:57 +0000 - rev 499834
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1484126 - part 9: Make all CellData users refer CellData::mFirst.mColumn directly r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D8346
b23363aa593d: Bug 1484126 - part 8: Replace |CellData::mCurrent.mRow - CellData::mFirst.mRow| with CellData::NumberOfPrecedingRows() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 15 Oct 2018 05:06:13 +0000 - rev 499833
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1484126 - part 8: Replace |CellData::mCurrent.mRow - CellData::mFirst.mRow| with CellData::NumberOfPrecedingRows() r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D8345
448d887560d4: Bug 1484126 - part 7: Replace all comparisons of CellData::mFirst.mRow and CellData::mCurrent.mRow with CellData::IsSpannedFromOtherRow() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 15 Oct 2018 04:21:34 +0000 - rev 499832
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1484126 - part 7: Replace all comparisons of CellData::mFirst.mRow and CellData::mCurrent.mRow with CellData::IsSpannedFromOtherRow() r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D8344
0f9a168cb7c8: Bug 1484126 - part 6: Make all CellData users refer CellData::mFirst.mRow directly r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 15 Oct 2018 04:10:32 +0000 - rev 499831
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1484126 - part 6: Make all CellData users refer CellData::mFirst.mRow directly r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D8343
181c07ae07c5: Bug 1484126 - part 5: Make all CellData users refer CellData::mElement directly r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 15 Oct 2018 04:06:32 +0000 - rev 499830
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1484126 - part 5: Make all CellData users refer CellData::mElement directly r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D8342
539a4c3e1946: Bug 1484126 - part 4: Make all CellData users use CellData::mCurrent.mColumn r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 15 Oct 2018 02:01:09 +0000 - rev 499829
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1484126 - part 4: Make all CellData users use CellData::mCurrent.mColumn r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D8341
24e31e2070fa: Bug 1484126 - part 3: Make all CellData users use CellData::mCurrent.mRow r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 15 Oct 2018 01:43:54 +0000 - rev 499828
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1484126 - part 3: Make all CellData users use CellData::mCurrent.mRow r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D8340
d3609fcd3c88: Bug 1484126 - part 2: Make all nsITableEditor::GetCellDataAt() use CellData r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 15 Oct 2018 01:43:11 +0000 - rev 499827
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1484126 - part 2: Make all nsITableEditor::GetCellDataAt() use CellData r=m_kato This patch makes all nsITableEditor::GetCellDataAt() use CellData, and if each caller checks the result of GetCellDataAt() with NS_FAILED(), this replaces it with CellData::FailedOrNotFound() since GetCellDataAt() returns error even when it does not find a cell element. Finally, copies each CellData member to the variable which received corresponding value from GetCellDataAt() for making this change safe. Note that for easier to review, the copying blocks have odd indent. Those variables will be removed or corrected the indent by the following patches. Differential Revision: https://phabricator.services.mozilla.com/D8339
bf74fc63e816: Bug 1484126 - part 1: Create CellData struct which implements nsITableEditor::GetCellDataAt() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 12 Oct 2018 13:40:25 +0000 - rev 499826
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1484126 - part 1: Create CellData struct which implements nsITableEditor::GetCellDataAt() r=m_kato nsITableEditor::GetCellDataAt() is an XPCOM method but used internally a lot. Additionally, it scatters a lot of variables (including unused) since it takes a lot of out arguments to return. Therefore, this should be implemented as struct and users should refer each member as result. This does not replaces the callers yet since it's too risky if the caller is not tested by automated test. Following patches will replace the method call and each variable step by step. Differential Revision: https://phabricator.services.mozilla.com/D8338
d7f0492bf262: Bug 1484126 - part 0: Add automated tests for nsITableEditor.getCellDataAt() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 12 Oct 2018 04:09:19 +0000 - rev 499825
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1484126 - part 0: Add automated tests for nsITableEditor.getCellDataAt() r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D8337
57d97b765e49: Bug 1497815 - Rename EditorEventListener::EnsureCommitCompoisition() to EditorEventListener::EnsureCommitComposition() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 11 Oct 2018 09:12:15 +0000 - rev 499134
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1497815 - Rename EditorEventListener::EnsureCommitCompoisition() to EditorEventListener::EnsureCommitComposition() r=m_kato Just fixing typo of the method name. Differential Revision: https://phabricator.services.mozilla.com/D8336
a22e64bb83ed: Bug 1461708 - part 6: Make EditorEventListener::MouseClick() use WidgetMouseEvent instead of dom::MouseEvent r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 10 Oct 2018 12:05:21 +0000 - rev 498897
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1461708 - part 6: Make EditorEventListener::MouseClick() use WidgetMouseEvent instead of dom::MouseEvent r=m_kato The event argument of only EditorEventListener::MouseClick() can be replaced with WidgetMouseEvent simply. So, for avoiding unnecessary RefPtr in EditorEventListener::HandleEvent(), we should fix this now. Differential Revision: https://phabricator.services.mozilla.com/D7853
80f3e8b1d66f: Bug 1495978 - Make PuppetWidget::StartPluginIME() restore cross process dispatching state of given keyboard event instance after sending it to the main process synchronously r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 09 Oct 2018 01:29:42 +0000 - rev 498568
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1495978 - Make PuppetWidget::StartPluginIME() restore cross process dispatching state of given keyboard event instance after sending it to the main process synchronously r=m_kato PuppetWidget::StartPluginIME() calls TabChild::SendStartPluginIME() with given WidgetKeyboardEvent instance. Then, the keyboard event will be marked as "posted to remote process" by ParamTraits<mozilla::WidgetEvent>::Write(). However, the method sends back the keyboard event to the main process synchronously. So, we don't want the event is treated as "posted" since the flag is used to check whether current process handles posted event *before* the remote process or not. So, PuppetWidget::StartPluginIME() should restore the cross process dispatching state with calling WidgetEvent::ResetCrossProcessDispatchingState(). Unfortunately, this also clears propagation state of the event too if the event has already been posted to a remote process and is waiting reply from the remote process. This shouldn't occur in content process, however, we should check it with MOZ_ASSERT() for detecting regressions. Differential Revision: https://phabricator.services.mozilla.com/D7579
323691f11567: Bug 1495964 - Remove unnecessary NS_ASSERTION in nsChildView::DispatchEvent() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 04 Oct 2018 02:51:16 +0000 - rev 497961
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1495964 - Remove unnecessary NS_ASSERTION in nsChildView::DispatchEvent() r=m_kato The assertion was reasonable check before fixing bug 1446401. However, this is currently valid situation in UI Events spec. Differential Revision: https://phabricator.services.mozilla.com/D7578
3b77ee1b0986: Bug 1494651 - Update encoding_rs to 0.8.7. r=m_kato
Henri Sivonen <hsivonen@hsivonen.fi> - Mon, 01 Oct 2018 01:11:59 +0000 - rev 497386
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1494651 - Update encoding_rs to 0.8.7. r=m_kato MozReview-Commit-ID: EB0wO4BxFAb Differential Revision: https://phabricator.services.mozilla.com/D7087
7fb27b858fda: Bug 1484111 - part 1: Create HTMLEditor::InsertTableCellsWithTransaction() for internal use of nsITableEditor::InsertTableCell() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 20 Sep 2018 11:44:35 +0000 - rev 495882
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1484111 - part 1: Create HTMLEditor::InsertTableCellsWithTransaction() for internal use of nsITableEditor::InsertTableCell() r=m_kato nsITableEditor::InsertTableCell() is an XPCOM method but used internally. So, HTMLEditor should implement it with a non-virtual method and all internal users should use it instead. Differential Revision: https://phabricator.services.mozilla.com/D6259
d10273c0ead3: Bug 1484111 - part 0: Add automated tests for nsITableEditor.insertTableCell.html r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 20 Sep 2018 11:44:33 +0000 - rev 495881
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1484111 - part 0: Add automated tests for nsITableEditor.insertTableCell.html r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D6258
c44ff40b9ade: Bug 1484116 - part 1: Create HTMLEditor::InsertTableColumnsWithTransaction() for internal use of nsITableEditor::InsertTableColumn() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 20 Sep 2018 09:15:08 +0000 - rev 495849
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1484116 - part 1: Create HTMLEditor::InsertTableColumnsWithTransaction() for internal use of nsITableEditor::InsertTableColumn() r=m_kato nsITableEditor::InsertTableColumn() is an XPCOM method but it's used internally. So, HTMLEditor should implement it with a non-virtual method and internal users should use it instead. Differential Revision: https://phabricator.services.mozilla.com/D6257
c7af8a8d767a: Bug 1484116 - part 0: Add automated tests for nsITableEditor.insertTableColumn() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 20 Sep 2018 09:15:06 +0000 - rev 495848
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1484116 - part 0: Add automated tests for nsITableEditor.insertTableColumn() r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D6256
d5e804da423c: Bug 1484117 - part 0: Add automated tests for nsITableEditor.insertTableRow() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 20 Sep 2018 04:45:18 +0000 - rev 495846
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1484117 - part 0: Add automated tests for nsITableEditor.insertTableRow() r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D6178
ede1caad7306: Bug 1484117 - part 1: Create HTMLEditor::InsertTableRowsWithTransaction() for internal use of nsITableEditor::InsertTableRow() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 20 Sep 2018 06:55:17 +0000 - rev 495845
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1484117 - part 1: Create HTMLEditor::InsertTableRowsWithTransaction() for internal use of nsITableEditor::InsertTableRow() r=m_kato nsITableEditor::InsertTableRow() is an XPCOM method but there are some internal users. So, HTMLEditor should implement it with a non-virtual method and it should be used by all internal users. Differential Revision: https://phabricator.services.mozilla.com/D6179
cf2ee1753201: Bug 1484119 - part 2: Make HTMLEditor::DeleteTableCellWithTransaction() remove <table> element if it becomes empty r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 19 Sep 2018 09:00:06 +0000 - rev 495659
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1484119 - part 2: Make HTMLEditor::DeleteTableCellWithTransaction() remove <table> element if it becomes empty r=m_kato HTMLEditor::DeleteTableCellWithTransaction() does not remove <table> element even if it becomes empty only when 2 or more cell elements are selected. Therefore, we should check table size before removing a row and if it's the last row, the method should remove <table>. Differential Revision: https://phabricator.services.mozilla.com/D6177
c5c4ddcd12a9: Bug 1484119 - part 1: Create HTMLEditor::DeleteTableCellWithTransaction() for internal use of nsITableEditor::DeleteTableCell() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 19 Sep 2018 08:50:11 +0000 - rev 495658
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1484119 - part 1: Create HTMLEditor::DeleteTableCellWithTransaction() for internal use of nsITableEditor::DeleteTableCell() r=m_kato nsITableEditor::DeleteTableCell() is an XPCOM method but used internally. So, HTMLEditor should implement it with non-virtual method and use it internally. Differential Revision: https://phabricator.services.mozilla.com/D6176
5e85c1d06616: Bug 1484119 - part 0: Add automated tests for nsITableEditor.deleteTableCell.html r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 19 Sep 2018 02:03:29 +0000 - rev 495657
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1484119 - part 0: Add automated tests for nsITableEditor.deleteTableCell.html r=m_kato Although this has a lot of todo_is() since this API is really broken. Differential Revision: https://phabricator.services.mozilla.com/D6175
ca674e42cbca: Bug 1484120 - part 1: Create HTMLEditor::DeleteTableCellContentsWithTransaction() for internal use of nsITableEditor::DeleteTableCellContents() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 19 Sep 2018 01:58:48 +0000 - rev 495649
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1484120 - part 1: Create HTMLEditor::DeleteTableCellContentsWithTransaction() for internal use of nsITableEditor::DeleteTableCellContents() r=m_kato nsITableEditor::DeleteTableCellContents() is an XPCOM method but it's used internally. So, HTMLEditor should implement it with a non-virtual method and all internal users should use the non-virtual method instead. This patch adds HTMLEditor::DeleteTableCellContentsWithTransaction() for that. Additionally, this patch renames its helper method DeleteCellContents() to DeleteAllChidlrenWithTransaction() and moves it to HTMLEditor.cpp since it can handle any element nodes. Differential Revision: https://phabricator.services.mozilla.com/D6174
1e13d82e0536: Bug 1484120 - part 0: Add automated tests for nsITableEditor.deleteTableCellContents.html r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 19 Sep 2018 01:58:51 +0000 - rev 495648
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1484120 - part 0: Add automated tests for nsITableEditor.deleteTableCellContents.html r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D6173
aeedb5377576: Bug 1490641 - Disable all Gecko specific UIs by default in release build r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 19 Sep 2018 06:40:03 +0000 - rev 495647
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1490641 - Disable all Gecko specific UIs by default in release build r=m_kato Currently, we have some Gecko specific editing UI: - Resizers to resize <img>s, <table>s, absolutely positioned elements. - Inline-table-editing UI to add/remove rows/columns. - Grabber to move absolutely positioned element. They are now disabled by default in Nightly and early-Beta. Starting from 64, this patch makes them disabled by default even on release channel. Note that the other browsers do not have those UIs and web apps can enable them with document.execCommand() on Gecko anyway. Those UI usage is enough low according to the telemetry, but a few users use them aggressively (see bug 1452538 comment 19). This is a request from W3C Editing API WG: https://github.com/w3c/editing/issues/171 Differential Revision: https://phabricator.services.mozilla.com/D6112
a0f7c46838a0: Bug 1484121 - part 2: Clean up HTMLEditor::DeleteColumn() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 19 Sep 2018 06:39:31 +0000 - rev 495633
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1484121 - part 2: Clean up HTMLEditor::DeleteColumn() r=m_kato This patch renames HTMLEditor::DeleteColumn() to HTMLEditor::DeleteTableColumnWithTransaction() and cleans up its implementation. Differential Revision: https://phabricator.services.mozilla.com/D5934
d2025ca568f7: Bug 1484121 - part 1: Create HTMLEditor::DeleteSelectedTableColumnsWithTransaction() for internal use of nsITableEditor::DeleteTableColumn() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 19 Sep 2018 06:34:33 +0000 - rev 495632
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1484121 - part 1: Create HTMLEditor::DeleteSelectedTableColumnsWithTransaction() for internal use of nsITableEditor::DeleteTableColumn() r=m_kato nsITableEditor::DeleteTableColumn() is an XPCOM method but used internally. So, it should be implemented with non-virtual method and internal users should use it. Note that this changes only one thing. This moves |AutoTopLevelEditSubActionNotifier maybeTopLevelEditSubAction(...| from below DeleteTableElementAndChildrenWithTransaction() to above it. I.e., DeleteTableElementAndChildrenWithTransaction() works under EditSubAction::eDeleteNode as the top level sub-action now. This is same as DeleteSelectedTableRowsWithTransaction(). Therefore, the difference with it when it removes <table> is now fixed. Differential Revision: https://phabricator.services.mozilla.com/D5933
d3f152e4c6cf: Bug 1484121 - part 0: Add automated tests for nsITableEditor.deleteTableColumn() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 19 Sep 2018 04:32:10 +0000 - rev 495631
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1484121 - part 0: Add automated tests for nsITableEditor.deleteTableColumn() r=m_kato This add automated tests for nsITableEditor.deleteTableColumn(). However, this contains some fixes of existing code since with those bugs, the test isn't passed even in the simplest case. Differential Revision: https://phabricator.services.mozilla.com/D5932
b240ef0f3694: Bug 1484122 - part 2: Clean up HTMLEditor::DeleteRow() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 18 Sep 2018 08:31:00 +0000 - rev 495385
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1484122 - part 2: Clean up HTMLEditor::DeleteRow() r=m_kato This patch renames HTMLEditor::DeleteRow() to HTMLEditor::DeleteTableRowWithTransaction() and cleans up its implementation. Differential Revision: https://phabricator.services.mozilla.com/D5931
7e2fe3f19c3c: Bug 1484122 - part 1: Create HTMLEditor::DeleteSelectedTableRowsWithTransaction() for internal use of nsITableEditor::DeleteTableRow() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 18 Sep 2018 07:56:45 +0000 - rev 495384
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1484122 - part 1: Create HTMLEditor::DeleteSelectedTableRowsWithTransaction() for internal use of nsITableEditor::DeleteTableRow() r=m_kato nsITableEditor::DeleteTableRow() is an XPCOM method but there are some internal users. So, it should be implemented as non-virtual protected method and internal users should use it instead. This also renames (and reimplement) HTMLEditor::DeleteTable2() since it's really bad name and the code dispatches unnecessary "selectionchange" events. Differential Revision: https://phabricator.services.mozilla.com/D5930
9913556f42c1: Bug 1484122 - part 0: Add automated tests for nsITableEditor.deleteTableRow.html r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 18 Sep 2018 07:25:58 +0000 - rev 495383
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1484122 - part 0: Add automated tests for nsITableEditor.deleteTableRow.html r=m_kato This patch changes a bit in HTMLEditor::DeleteTableRow() because calling DeleteTable2() without those helper classes hits MOZ_ASSERT(). Differential Revision: https://phabricator.services.mozilla.com/D5929
f5ffeeee5488: Bug 1491032 - Make TISInputSourceWrapper::WillDispatchKeyboardEvent() decide charCode value with keypress event index r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 18 Sep 2018 01:46:29 +0000 - rev 495359
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1491032 - Make TISInputSourceWrapper::WillDispatchKeyboardEvent() decide charCode value with keypress event index r=m_kato If a key inputs multiple characters, we dispatch same number eKeyPress events to input each character. However, TISInputSourceWrapper::WillDispatchKeyboardEvent() always sets charCode of all eKeyPress events to first character of inserting. Instead, it should set charCode value to nth character of the inserting string. Differential Revision: https://phabricator.services.mozilla.com/D5884
d6556911bca9: Bug 1484133 - part 1: Create non-virtual HTMLEditor::GetSelectedOrParentTableElement() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 14 Sep 2018 12:56:22 +0000 - rev 494806
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1484133 - part 1: Create non-virtual HTMLEditor::GetSelectedOrParentTableElement() r=m_kato nsITableEditor::GetSelectedOrParentTableElement() is of course an XPCOM method, but it's used internally. So, there should be non-virtual method. On the other hand, this API is too ugly. Returns various information but each meaning is not clear. So, result of the new non-virtual method should be simpler. This patch creates the new method as: - returns found element - takes ErrorResult to return error code. - takes optional out-param for returning if a cell is selected. Then, nsITableEditor::GetSelectedOrParentTableElement() can compute its result from them with Selection. Differential Revision: https://phabricator.services.mozilla.com/D5728
bcb7c4b6231b: Bug 1484133 - part 0: Add automated tests for nsITableEditor.getSelectedOrParentTableElement() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 14 Sep 2018 12:54:43 +0000 - rev 494805
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1484133 - part 0: Add automated tests for nsITableEditor.getSelectedOrParentTableElement() r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D5727
441e942242df: Bug 1484131 - part 1: Create HTMLEditor::CellAndIndexes struct to store cell element and its indexes in the <table> r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 14 Sep 2018 12:51:05 +0000 - rev 494804
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1484131 - part 1: Create HTMLEditor::CellAndIndexes struct to store cell element and its indexes in the <table> r=m_kato If a cell element and its indexes in the <table> are stored in a struct, it makes the user methods easier to read. Therefore, this patch implement such struct as HTMLEditor::CellAndIndexes and make it finds first selected cell and indexes with its method. Finally, this reimplement HTMLEditor::GetFirstSelectedCellInTable() with it. Differential Revision: https://phabricator.services.mozilla.com/D5664