searching for reviewer(longsonr)
a955374449f8ab6ba046b8ff3ac81797fe880408: Bug 1661509 - Fix SVGSVGElement::QueryInterface. r=longsonr
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 27 Aug 2020 20:56:04 +0000 - rev 615733
Push 2429 by ffxbld-merge at Mon, 12 Oct 2020 13:13:51 +0000
Bug 1661509 - Fix SVGSVGElement::QueryInterface. r=longsonr Differential Revision: https://phabricator.services.mozilla.com/D88475
fdff19ec13e2d4e94ac22be9f0702446da4088db: Bug 1494356 - Remove SVG style attribute reparsing code. r=longsonr
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 29 Jun 2020 20:16:11 +0000 - rev 605911
Push 2389 by ffxbld-merge at Mon, 17 Aug 2020 10:06:13 +0000
Bug 1494356 - Remove SVG style attribute reparsing code. r=longsonr Now that XBL and xml:base are gone, and that <svg:use> is sane (using shadow trees instead of NAC), we can just remove this, and fix this bug. Differential Revision: https://phabricator.services.mozilla.com/D81553
52a22e645070e599c161af9ef5353614d77ab5fa: Bug 1634393 - Resolve <textPath> href local references against document URL, not base URL. r=longsonr
Cameron McCormack <cam@mcc.id.au> - Mon, 08 Jun 2020 06:06:26 +0000 - rev 602091
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1634393 - Resolve <textPath> href local references against document URL, not base URL. r=longsonr Differential Revision: https://phabricator.services.mozilla.com/D78627
b85c17816d3bd4f36ee071f1775f1279d5c31ffa: Bug 1561225 - Revert the WebRender part for bug 1636119. r=longsonr
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Sat, 16 May 2020 20:41:49 +0000 - rev 597852
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1561225 - Revert the WebRender part for bug 1636119. r=longsonr And check `ShouldSnapToGrid` when we create a stacking context for the transform display item. I was totally missing a comment [1] in CreateAimationData. [1] https://searchfox.org/mozilla-central/rev/3ce874dc2703831af3e5ef3a1d216ffd08057fa5/gfx/layers/AnimationInfo.cpp#683-685 Differential Revision: https://phabricator.services.mozilla.com/D75668
3d8f0e488dbfdc39d0481939dabc80e300d93619: Bug 1609663 - Reflow non-display SVG text that has just been inserted. r=longsonr
Cameron McCormack <cam@mcc.id.au> - Wed, 13 May 2020 08:00:23 +0000 - rev 597090
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1609663 - Reflow non-display SVG text that has just been inserted. r=longsonr Differential Revision: https://phabricator.services.mozilla.com/D75034
39f8ceb567ec90338c4daea1d9dad48043206dad: Bug 1513603 - Remove SVG tearoff objects from the table when they are unlinked. r=longsonr
Cameron McCormack <cam@mcc.id.au> - Thu, 09 Apr 2020 12:50:28 +0000 - rev 590441
Push 2335 by ffxbld-merge at Mon, 25 May 2020 13:47:24 +0000
Bug 1513603 - Remove SVG tearoff objects from the table when they are unlinked. r=longsonr The only three types that can hit the PreservedWrapper() assertion currently, and which this patch avoids, are DOMSVGPathSegList, DOMSVGPointList, and DOMSVGStringList. This is because these are the only types that are implemented as proxies (due to having e.g. indexed getters on them, and thus have the offending DOMProxyHandler::GetExpandoObject() call in their bindings) and which we store in tearoff tables. Differential Revision: https://phabricator.services.mozilla.com/D70314
09c8d799a2b40015aa6a7fc1f787b0379ffa0d74: Bug 1622445 - Don't cache the SVGGeometryElement's Path with OMTP rendering. r=longsonr
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 16 Mar 2020 15:15:40 +0000 - rev 585753
Push 2321 by ffxbld-merge at Mon, 27 Apr 2020 16:26:39 +0000
Bug 1622445 - Don't cache the SVGGeometryElement's Path with OMTP rendering. r=longsonr Differential Revision: https://phabricator.services.mozilla.com/D66955
0c55843ce3af5a70617499e04d7bb9cc2aadcf69: Bug 1615944 - Add WPTs for SVG presentation attribute support. r=longsonr
Cameron McCormack <cam@mcc.id.au> - Mon, 24 Feb 2020 23:30:09 +0000 - rev 581832
Push 2292 by ffxbld-merge at Mon, 30 Mar 2020 09:22:45 +0000
Bug 1615944 - Add WPTs for SVG presentation attribute support. r=longsonr Differential Revision: https://phabricator.services.mozilla.com/D63036
a061c1e11b7643628db9da237a10c0251e177f99: Bug 1601824 - Measure partial ligature advance contributions correctly on text paths. r=longsonr
Cameron McCormack <cam@mcc.id.au> - Wed, 11 Dec 2019 04:57:41 +0000 - rev 572135
Push 2247 by ffxbld-merge at Mon, 03 Feb 2020 09:19:36 +0000
Bug 1601824 - Measure partial ligature advance contributions correctly on text paths. r=longsonr Differential Revision: https://phabricator.services.mozilla.com/D56665
e4cce6206c2590a0911ecf0086ffe9a578cef551: Bug 1601486 - Use bbox for calculating the alignment for motion path transformation on eSVGContainer elements (e.g. <g>). r=longsonr
Boris Chiou <boris.chiou@gmail.com> - Mon, 09 Dec 2019 21:28:21 +0000 - rev 571750
Push 2247 by ffxbld-merge at Mon, 03 Feb 2020 09:19:36 +0000
Bug 1601486 - Use bbox for calculating the alignment for motion path transformation on eSVGContainer elements (e.g. <g>). r=longsonr When we apply the transformation on the <g> element, its transformation also performs on its child elements. So Motion-path should also work well in this case. For offset-path:path(), we have to make sure the element is on the svg path, no matter what is its x and y values. That's why we have to calculate the the frame position of the transformed SVG element if transform-box is fill-box. However, for <g> element, its nsIFrame::GetPosition() is (0, 0), so we have to calculate the geometry bbox instead, to make sure it works well on <g> or other svg transformed elements. Differential Revision: https://phabricator.services.mozilla.com/D55888
31ead0a3bca38b5518b7f216dd21809564fb54e9: Bug 1600855 - Re-enable letter-spacing and word-spacing on SVG text. r=longsonr
Cameron McCormack <cam@mcc.id.au> - Tue, 03 Dec 2019 21:22:53 +0000 - rev 570765
Push 2247 by ffxbld-merge at Mon, 03 Feb 2020 09:19:36 +0000
Bug 1600855 - Re-enable letter-spacing and word-spacing on SVG text. r=longsonr Differential Revision: https://phabricator.services.mozilla.com/D55601
4acdc6bc23e26cd4bfa1855f7ff30cdc76b32cfc: Bug 1600855 - Avoid SVG text calling gfxTextRun::GetAdvanceWidth for ranges that cross text frame boundaries. r=longsonr
Cameron McCormack <cam@mcc.id.au> - Tue, 03 Dec 2019 21:22:46 +0000 - rev 570764
Push 2247 by ffxbld-merge at Mon, 03 Feb 2020 09:19:36 +0000
Bug 1600855 - Avoid SVG text calling gfxTextRun::GetAdvanceWidth for ranges that cross text frame boundaries. r=longsonr Differential Revision: https://phabricator.services.mozilla.com/D55600
a3473bbf2b429bab91756a80c6f2c48f8f008b8c: Bug 1600855 - Re-enable letter-spacing and word-spacing on SVG text. r=longsonr
Cameron McCormack <cam@mcc.id.au> - Tue, 03 Dec 2019 06:13:22 +0000 - rev 570757
Push 2247 by ffxbld-merge at Mon, 03 Feb 2020 09:19:36 +0000
Bug 1600855 - Re-enable letter-spacing and word-spacing on SVG text. r=longsonr Differential Revision: https://phabricator.services.mozilla.com/D55601
a9c150ebbf2b73b277790b5dd04a8704127fb215: Bug 1600855 - Avoid SVG text calling gfxTextRun::GetAdvanceWidth for ranges that cross text frame boundaries. r=longsonr
Cameron McCormack <cam@mcc.id.au> - Tue, 03 Dec 2019 06:12:39 +0000 - rev 570756
Push 2247 by ffxbld-merge at Mon, 03 Feb 2020 09:19:36 +0000
Bug 1600855 - Avoid SVG text calling gfxTextRun::GetAdvanceWidth for ranges that cross text frame boundaries. r=longsonr Differential Revision: https://phabricator.services.mozilla.com/D55600
0fd8713b9050483915cfc784b124537cb5ba5c75: Bug 1507674 - Refactor svg observer setup to not do silly things when observing an ancestor. r=longsonr
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 20 Nov 2019 10:05:29 +0000 - rev 568203
Push 2218 by ffxbld-merge at Mon, 30 Dec 2019 12:35:14 +0000
Bug 1507674 - Refactor svg observer setup to not do silly things when observing an ancestor. r=longsonr Right now we post updates and it "works" because we prevent the UpdateOverflow call if we're during reflow. If this happens during styling however this is not sound (and it is not sound in general and has caused badness in the past, as noted by the other workarounds). Make it sound by preventing to observe ancestors, and do it everywhere, removing various ad-hoc hacks that were spread around elsewhere. This changes expectations of two tests: * clip-path-recursion-002.svg: Now we consider the inner clip-path reference invalid. This matches WebKit and Blink, and I don't see any spec text explicitly asking for our old behavior, so I just changed the test. * element-paint-recursion.html: Changes the expectations of elements referencing themselves via -moz-element(). Now it is invalid, instead of painting ourselves once inside ourselves, which was a bit wild on its own. Differential Revision: https://phabricator.services.mozilla.com/D53890
ed9b896fd383049c143c41fe28547d7b37c051c0: Bug 371787 - Add support for letter-spacing and word-spacing in SVG text. r=jfkthame,longsonr
Cameron McCormack <cam@mcc.id.au> - Wed, 20 Nov 2019 04:10:36 +0000 - rev 567980
Push 2218 by ffxbld-merge at Mon, 30 Dec 2019 12:35:14 +0000
Bug 371787 - Add support for letter-spacing and word-spacing in SVG text. r=jfkthame,longsonr Differential Revision: https://phabricator.services.mozilla.com/D53376
ed2612dfc5c2f9a7c0fd5babe407e658f4371d6c: Bug 1585863 - Remove nsChangeHint_UpdateTextPath. r=longsonr
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 08 Oct 2019 21:52:47 +0000 - rev 561496
Push 2195 by ffxbld-merge at Mon, 25 Nov 2019 12:02:33 +0000
Bug 1585863 - Remove nsChangeHint_UpdateTextPath. r=longsonr The only thing it does is asserting a bit and posting more async work to the text frame. It seems we can just post all the async work early instead, and remove the change hint. This was only introduced to fix bug 779971, where a <textPath> element references its parent SVG, which is obviously unsound if we allowed to render it. What we're doing right now is a bit silly... We're observing the <svg>, so when we finish reflowing it and store its overflow, we invalidate its rendering observers, but that invalidates a _descendant_, which makes no sense. Fortunately we don't let the element affect its rendering, as it fails this check: * https://searchfox.org/mozilla-central/rev/35cc00a25c4471993fdaa5761952bd3afd4f1731/layout/svg/SVGObserverUtils.cpp#1390 But we still request reflow of the outer <text>, which is not amazing. We shouldn't invalidate anything if the textpath doesn't reference a valid element and that didn't change. This is roughly what the code tried to do when checking mValid, except we always initialize mValid to true and thus always trigger at least one bogus reflow call. Differential Revision: https://phabricator.services.mozilla.com/D48008
4495ef2bbb0cc8ef69ad71620484beee2b5a4582: Bug 1582506. Remove some pointless null-checks in SVG code. r=longsonr
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 20 Sep 2019 06:02:10 +0000 - rev 558891
Push 2195 by ffxbld-merge at Mon, 25 Nov 2019 12:02:33 +0000
Bug 1582506. Remove some pointless null-checks in SVG code. r=longsonr Assuming our caller didn't mess up passing the reference (and code inspection suggests callers did not thus mess up), we should not have null when we take a pointer to the reference. Differential Revision: https://phabricator.services.mozilla.com/D46506
0b9d726f140203f807d04ddabd499a37589bdfd1: Bug 1581399 - Remove useless rule in svg.css. r=longsonr
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 15 Sep 2019 17:39:12 +0000 - rev 557969
Push 2195 by ffxbld-merge at Mon, 25 Nov 2019 12:02:33 +0000
Bug 1581399 - Remove useless rule in svg.css. r=longsonr It was added in bug 256624, but -moz-binding is no longer exposed to content so it doesn't do anything. Differential Revision: https://phabricator.services.mozilla.com/D45954
076af5db788815042df2190e620c9dbc5911b3b1: Bug 1579181 - Don't keep <use> shadow trees which we know we'll never render. r=longsonr
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 15 Sep 2019 16:09:28 +0000 - rev 557959
Push 2195 by ffxbld-merge at Mon, 25 Nov 2019 12:02:33 +0000
Bug 1579181 - Don't keep <use> shadow trees which we know we'll never render. r=longsonr This partially addresses the regression, but not fully. With this patch we don't maintain shadow trees for nodes that we know won't get rendered. This works fast in WebKit / Blink because of a bug in their implementation which doesn't synchronize style attributes, introduced in [1]. You can see this clearly if you click on the bug's test-case and inspect the <use> shadow trees (there's no style="stroke:orange" whatsoever). They can kinda get away with it because they don't properly implement SVG 2. In particular, in Blink / WebKit, the style of the element in the <use> shadow tree is the style of the referenced element, which means that even if the style attribute isn't properly synced it's ~ok since it doesn't end up mattering for styling. Easiest test-case for the behavior difference is: ``` <!doctype html> <style> rect:hover { fill: green; } </style> <svg width=300 height=300> <g id="canvas"> <rect fill=red width=100 height=100></rect> </g> <g> <use x=200 href="#canvas"></use> </g> </svg> ``` Where Firefox will properly update each square independently when hovered, but Blink / WebKit won't. This used to work faster because in this particular test-case we have 3 hidden <use> elements whose href is the #canvas, which is basically everything. Before moving to shadow trees we'd do it using anonymous content, and since we never got a frame we'd never clone the subtree in the first case. This case was faster before bug 1450250, but this approach makes other cases slow that were fixed by that bug, like bug 1485402. So I'll try to optimize shadow tree syncing instead, I guess, but there's no good reason not to land this in the meantime IMHO. [1]: https://chromium.googlesource.com/chromium/src/+/f4b022e64bbe0c74f07ee9209aa4033bddece145%5E%21/third_party/WebKit/WebCore/svg/SVGElement.cpp Differential Revision: https://phabricator.services.mozilla.com/D45953
7e6ac55da4ff1ed35e1890b07dc331822a22e8eb: Bug 1566697 - Fix unified build problem. r=longsonr
Cameron McCormack <cam@mcc.id.au> - Wed, 17 Jul 2019 06:13:49 +0000 - rev 546821
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1566697 - Fix unified build problem. r=longsonr Differential Revision: https://phabricator.services.mozilla.com/D38262
07e44731e886fa27c919a6dc9f2c46105bf04ae5: Bug 1555851 - Detect motion path measurement failures. r=longsonr
Cameron McCormack <cam@mcc.id.au> - Tue, 09 Jul 2019 01:26:52 +0000 - rev 545524
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1555851 - Detect motion path measurement failures. r=longsonr Differential Revision: https://phabricator.services.mozilla.com/D37337
09b3d826af112c35179e87ea0ac804d787cbc2ba: Bug 1557245 - Support overflow:visible for foreignObject r=longsonr
violet <violet.bugreport@gmail.com> - Tue, 25 Jun 2019 18:03:47 +0000 - rev 542957
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1557245 - Support overflow:visible for foreignObject r=longsonr Differential Revision: https://phabricator.services.mozilla.com/D35760
66cb2acf5a9e406f9c32b20cb522fb3b12b1c5e5: Bug 1561352: Rewrite WPT test viewBox-scaling-text-001.html to not depend on Ahem font having X-with-diacritics character. r=longsonr
Daniel Holbert <dholbert@cs.stanford.edu> - Tue, 25 Jun 2019 18:02:21 +0000 - rev 542902
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1561352: Rewrite WPT test viewBox-scaling-text-001.html to not depend on Ahem font having X-with-diacritics character. r=longsonr Differential Revision: https://phabricator.services.mozilla.com/D35833
4d57aaf5c4298fc9549df0b4f5ab375839daaf8b: Bug 1544432 part 2: Add WPT for text being scaled up via SVG viewBox. r=longsonr
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 21 Jun 2019 10:16:08 -0700 - rev 542834
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1544432 part 2: Add WPT for text being scaled up via SVG viewBox. r=longsonr
7bb92957787da8256bbb345662c6b8b1d8e5fbba: Bug 1544432 part 1: Scale around (0,0) when transforming SVG text from run user space to user space. r=longsonr
Alex Henrie <alexhenrie24@gmail.com> - Thu, 20 Jun 2019 09:41:55 -0700 - rev 542833
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1544432 part 1: Scale around (0,0) when transforming SVG text from run user space to user space. r=longsonr
268277536047b0724243e48eea3fa1dee11ea6db: Bug 1529572 - Should resolve absolute units r=longsonr
violet <violet.bugreport@gmail.com> - Sun, 23 Jun 2019 12:51:05 +0000 - rev 542743
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1529572 - Should resolve absolute units r=longsonr Firefox only failure. Differential Revision: https://phabricator.services.mozilla.com/D35614
8b13b43158a46b7cf48c7e3d25adf4b92cf67448: Bug 1559096. Document the unexpected aspects of BackgroundClipRenderingObserver. r=longsonr
Jonathan Watt <jwatt@jwatt.org> - Thu, 06 Jun 2019 14:12:01 -0700 - rev 542696
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1559096. Document the unexpected aspects of BackgroundClipRenderingObserver. r=longsonr Differential Revision: https://phabricator.services.mozilla.com/D34875
321cf20e1134c328e659e8061908f81eef9788b8: Bug 1559096. Rename SVGObserverUtils::mInObserverList. r=longsonr
Jonathan Watt <jwatt@jwatt.org> - Thu, 06 Jun 2019 11:12:21 -0700 - rev 542695
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1559096. Rename SVGObserverUtils::mInObserverList. r=longsonr Differential Revision: https://phabricator.services.mozilla.com/D34852
104948fb0613ffcc470c946277dbedfb3483672b: Bug 1559096. Rename SVGObserverUtils::GetAndObservePaintServer argument. r=longsonr
Jonathan Watt <jwatt@jwatt.org> - Thu, 06 Jun 2019 11:05:38 -0700 - rev 542694
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1559096. Rename SVGObserverUtils::GetAndObservePaintServer argument. r=longsonr Differential Revision: https://phabricator.services.mozilla.com/D34851
74e7a89b8d26daebae7c0a622cce47747e2c81b7: Bug 1560179 - Image should not accept eSHAPE r=longsonr
violet <violet.bugreport@gmail.com> - Thu, 20 Jun 2019 13:14:08 +0000 - rev 542150
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1560179 - Image should not accept eSHAPE r=longsonr Differential Revision: https://phabricator.services.mozilla.com/D35396
13d68d184214d83e413d7ed769a82443f9f05162: Bug 1325319 - Implement isPointInFill() and isPointInStroke() for SVGGeometryElement r=longsonr,bzbarsky
violet <violet.bugreport@gmail.com> - Wed, 19 Jun 2019 21:14:55 +0000 - rev 542116
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1325319 - Implement isPointInFill() and isPointInStroke() for SVGGeometryElement r=longsonr,bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D33592
74a548477a4cc8630ea4642ddfa0da452b1de22c: Bug 1559344: Reinstate earlier behavior of invalidating children-only transform (and repainting) when viewBox changes. r=longsonr
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 14 Jun 2019 19:21:01 +0000 - rev 541752
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1559344: Reinstate earlier behavior of invalidating children-only transform (and repainting) when viewBox changes. r=longsonr In bug 1556511's patch, I removed an invalidation that we'd been doing in response to viewBox changes, because I thought that the patch's newly-added reflow-request would make the invalidation unnecessary. But this was wrong -- the invalidation is still necessary, for cases where the requested reflow doesn't end up resizing any frames. Such a reflow won't make us repaint anything, and yet the viewBox change typically *does* need to trigger a repaint due to impacting the transform for the SVG contents. So, this patch reverts that part of bug 1556511's patch, and returns us to triggering a repaint in response to viewBox changes. Differential Revision: https://phabricator.services.mozilla.com/D35067
96b0fd9c79cd30dfe59597a8a77564862eb30091: Bug 1032124 - Use the referenced element to check whether to ignore a mutation event r=emilio,longsonr
violet <violet.bugreport@gmail.com> - Thu, 13 Jun 2019 20:02:42 +0000 - rev 541618
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1032124 - Use the referenced element to check whether to ignore a mutation event r=emilio,longsonr Using `nsContentUtils::IsInSameAnonymousTree(this, aElement)` to check will ignore all mutation notification for anonymous <use> which will happen when <use> is nested. This is the cause that second-level <use> isn't properly synced with element mutation. We should use the referenced element instead of `this` in the check condition. Differential Revision: https://phabricator.services.mozilla.com/D34284
4ef53fac3b048ddc027b9d139bb3be8ab626f55c: Bug 1558356 - Add WPT for xml:space="" on an ancestor element. r=longsonr
Cameron McCormack <cam@mcc.id.au> - Tue, 11 Jun 2019 12:07:51 +0000 - rev 541126
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1558356 - Add WPT for xml:space="" on an ancestor element. r=longsonr Differential Revision: https://phabricator.services.mozilla.com/D34436
e70086c9a4773b135365147e3feae222a85e0368: Bug 1557637 - Correct resolve <image> size when specified size is auto and intrinsic size is missing r=longsonr
violet <violet.bugreport@gmail.com> - Sat, 08 Jun 2019 00:33:36 +0000 - rev 540767
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1557637 - Correct resolve <image> size when specified size is auto and intrinsic size is missing r=longsonr https://www.w3.org/TR/css3-images/#default-sizing-algorithm Differential Revision: https://phabricator.services.mozilla.com/D34119
bab948f512c2f5ffe5a6638676143c7063bf2ad3: Bug 1556511 part 2: Add a test variant that uses SVG embedded in an `<object>` element. r=longsonr
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 07 Jun 2019 13:37:51 +0000 - rev 540703
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1556511 part 2: Add a test variant that uses SVG embedded in an `<object>` element. r=longsonr Differential Revision: https://phabricator.services.mozilla.com/D34108
aba9b5d525af1b48929de552224626799931ff3e: Bug 1556511 part 1: Mark the outer SVG frame as needing a reflow, when its viewBox attribute changes. r=longsonr
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 07 Jun 2019 04:28:51 +0000 - rev 540702
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1556511 part 1: Mark the outer SVG frame as needing a reflow, when its viewBox attribute changes. r=longsonr The viewBox attribute establishes an aspect ratio, which may influence the size of the outer SVG element. So when the viewBox attribute changes, we have to reflow to potentially update the frame size. This patch achieves this by sharing an existing codepath for handling changes to width & height. Differential Revision: https://phabricator.services.mozilla.com/D33898
967c30311690aa759c57271883dadb641e47db4b: Bug 1556713 - Transform dirtyRect down to <image> r=longsonr
violet <violet.bugreport@gmail.com> - Thu, 06 Jun 2019 14:54:40 +0000 - rev 540625
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1556713 - Transform dirtyRect down to <image> r=longsonr aDirtyRect in PaintSVG() is in outer <svg> coordinate. Image painting API needs dirty rect in image coordinate. We need to transform it. Differential Revision: https://phabricator.services.mozilla.com/D33813
d055d72f5e77f8ffd30331ed093800e87da8151a: Bug 1556713 - Transform dirtyRect down to <image> r=longsonr
violet <violet.bugreport@gmail.com> - Thu, 06 Jun 2019 14:54:40 +0000 - rev 540593
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1556713 - Transform dirtyRect down to <image> r=longsonr aDirtyRect in PaintSVG() is in outer <svg> coordinate. Image painting API needs dirty rect in image coordinate. We need to transform it. Differential Revision: https://phabricator.services.mozilla.com/D33813
8d1253667f3ab95eff3ef08b614a4cac1e9bf3cc: Bug 1556147 - SVGImageElement::BuildPath should never be called r=longsonr
violet <violet.bugreport@gmail.com> - Sat, 01 Jun 2019 16:06:33 +0000 - rev 539546
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1556147 - SVGImageElement::BuildPath should never be called r=longsonr SVGImageElement isn't really a SVGGeometryElement, we did that just for better code sharing. BuildPath() won't be called for <image>. Differential Revision: https://phabricator.services.mozilla.com/D33400
4ab1e25f7904160717fe15da393603757fb366a2: Bug 1555758 - Fallback to GetComputedStyleNoFlush for BuildPath r=longsonr,emilio
violet <violet.bugreport@gmail.com> - Fri, 31 May 2019 13:17:46 +0000 - rev 539234
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1555758 - Fallback to GetComputedStyleNoFlush for BuildPath r=longsonr,emilio It turns out the `BuildPath()` method will still be exposed by DOM API via `getTotalLength()`. So we need to fallback to `GetComputedStyleNoFlush()` to handle display:none problem, and if the element doesn't even belong to a document, we further fallback to 0. `BuildPath()` being affected also means `GetStrokeWidth()`, etc. will also be indirectly exposed to DOM API in some obscure cases. Let's add a utility to handle the fallback. Differential Revision: https://phabricator.services.mozilla.com/D33247
b6fa96d10a09ed745f77ca332075b9dfeef803c9: Bug 1555795 - Check IsInner() to ensure it is an outer svg r=longsonr
violet <violet.bugreport@gmail.com> - Fri, 31 May 2019 09:59:04 +0000 - rev 539196
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1555795 - Check IsInner() to ensure it is an outer svg r=longsonr Differential Revision: https://phabricator.services.mozilla.com/D33246
58a92f5eff76adb20b44e6a37c58e63387be6b62: Bug 1555030 - Add NS_FRAME_SVG_LAYOUT into SVGViewFrame and nsSVGStopFrame. r=dholbert,longsonr
Boris Chiou <boris.chiou@gmail.com> - Wed, 29 May 2019 23:50:55 +0000 - rev 539090
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1555030 - Add NS_FRAME_SVG_LAYOUT into SVGViewFrame and nsSVGStopFrame. r=dholbert,longsonr To avoid hitting the assertion for ResizeObserver, which calls GetBBox() for all SVG elements. Note: If the target has SVG layout and its primary frame cannot be queries as nsSVGDisplayableFrame, we return a default gfxRect(). And always returning a default gfxRect() on <view> or <stop> element makes ResizeObserver doesn't report it (because it is always not active). This behavior is the same as what Google Chrome has. (i.e. No event is fired.) Differential Revision: https://phabricator.services.mozilla.com/D32904
33a7cec553b2b79b4067416fab3191d19243c3bf: Bug 1554457 - Obtain style from frame rather than GetComputedStyleNoFlush r=emilio,longsonr,birtles
violet <violet.bugreport@gmail.com> - Mon, 27 May 2019 05:06:47 +0000 - rev 538530
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1554457 - Obtain style from frame rather than GetComputedStyleNoFlush r=emilio,longsonr,birtles These usecases are almost the same as the geometry property stuff. It'd be better to use `GetPrimaryFrame()->Style()` consistently rather than using `GetComputedStyleNoFlush()` here. Differential Revision: https://phabricator.services.mozilla.com/D32613
0922f98398e2b3d3c51f9cad01b082f161ffdeb6: Bug 1554568 - Should resolve font-size of inner svg from itself r=longsonr
violet <violet.bugreport@gmail.com> - Mon, 27 May 2019 06:46:53 +0000 - rev 538529
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1554568 - Should resolve font-size of inner svg from itself r=longsonr Resolving length for inner <svg> is exactly the same as other ordinary element. We should not pass the context to `GetAnimValue()`, otherwise font-size will be obtained from the enclosing viewport of the inner <svg> rather than the inner <svg> itself. Differential Revision: https://phabricator.services.mozilla.com/D32657
d0646b8b69e78adfa6f7893b3c96884d0d717b9b: Bug 1383650 - Remove some redundant attribute observing logic r=longsonr
violet <violet.bugreport@gmail.com> - Sat, 25 May 2019 11:17:49 +0000 - rev 538407
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1383650 - Remove some redundant attribute observing logic r=longsonr Since geometry property values are computed from CSS, which also takes care of change hint via `CalcDifference`, we can just remove some logic to observe attribute change for `x`, `y`, etc. Differential Revision: https://phabricator.services.mozilla.com/D32564
b0a0359fdadb1c7dcd39656c449f3a072f49d66d: Bug 1383650 - Support geometry property for SVG image element r=longsonr
violet <violet.bugreport@gmail.com> - Fri, 24 May 2019 12:40:12 +0000 - rev 538215
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1383650 - Support geometry property for SVG image element r=longsonr The only different part is to resolve intrinsic image size. This patch implements explicit requirements of the spec, but an edge case is tricky. It's not clear per spec what the intrinsic image size is for an SVG without explicit width/height, something like: <svg> <image href="data:image/svg+xml,<svg xmlns='http://www.w3.org/2000/svg'><rect width='40' height='90' fill='red' /></svg>"/> </svg> Chrome treats the intrinsic size of the href svg as the default size of a replaced element (300x150), our image/VectorImage.cpp doesn't resolve size in this case. We can handle this particular case in some seperate bug if necessary, I think. Differential Revision: https://phabricator.services.mozilla.com/D32415
f5242bd1605a4955756dc26bc7b828a9b176114f: Bug 1383650 - Remove obsolete check that is wrong in SVG2 r=longsonr
violet <violet.bugreport@gmail.com> - Thu, 23 May 2019 07:24:59 +0000 - rev 537968
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1383650 - Remove obsolete check that is wrong in SVG2 r=longsonr Differential Revision: https://phabricator.services.mozilla.com/D32008
f9ec440d652a96149cd68945bfb638e8e4944394: Bug 1383650 - Add reftest for rect, circle, ellipse and foreignObject r=longsonr
violet <violet.bugreport@gmail.com> - Thu, 16 May 2019 13:21:22 +0000 - rev 537545
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1383650 - Add reftest for rect, circle, ellipse and foreignObject r=longsonr Differential Revision: https://phabricator.services.mozilla.com/D30807