searching for reviewer(lizzard)
8f9fdaef9fc06cd0dda8edcb6e58aa37efbf2ddf: bug 1549249 - hard-code new add-on signing intermediate so it's always available r=jcj,kmag a=lizzard
Dana Keeler <dkeeler@mozilla.com> - Mon, 06 May 2019 23:05:23 +0000 - rev 526503
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
bug 1549249 - hard-code new add-on signing intermediate so it's always available r=jcj,kmag a=lizzard Our previous approach to making this intermediate available relied on being able to add it to the user's NSS cert DB. This does work in the majority of cases, but there are some situations where it doesn't work (e.g. if the user's DB is set to read only, if they've configured Firefox to run in "nocertdb" mode, if they have a master password but forgot it, and so on). This patch compiles the intermediate in to Firefox in the same way we incorporate the root, so it should always be available. At the same time, this patch reverts the changes from be8cd9575508ce1a95b971ccbfe3a7ceec59bc0b (the patch that implemented the original approach) because it should no longer be necessary. This also bumps the add-on DB schema to trigger add-on revalidation. Differential Revision: https://phabricator.services.mozilla.com/D30139
f272348572e8160a73001b85013f35db51397064: Bug 1549010: Part 2 - Bump DB schema version to force certificate reverification. r=zombie a=lizzard CLOSED TREE
Kris Maglione <maglione.k@gmail.com> - Fri, 03 May 2019 21:32:17 -0700 - rev 526488
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1549010: Part 2 - Bump DB schema version to force certificate reverification. r=zombie a=lizzard CLOSED TREE Users who are affected by the intermediate add-on signing certificate expiry need their add-on signatures re-verified as soon as possible after updating to a version containging the fix. A database rebuild includes signature reverifications, so a schema version achieves this. Differential Revision: https://phabricator.services.mozilla.com/D29930
d716b75b8ac3f4588061e720074c093dae08e43e: Bug 1549010 - verify add-on signing certificates at 2019-04-27T02:43:20.000Z r=jcj a=lizzard
Dana Keeler <dkeeler@mozilla.com> - Sat, 04 May 2019 04:15:11 +0000 - rev 526487
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1549010 - verify add-on signing certificates at 2019-04-27T02:43:20.000Z r=jcj a=lizzard Differential Revision: https://phabricator.services.mozilla.com/D29928
a4417ce665b2bac2cf391dac60d0b3deaf38e63f: Bug 1536229: Remove NS_RELEASE_ASSERT that is being tripped and seems to be unnecessary. r=rhunt a=lizzard
Bas Schouten <bschouten@mozilla.com> - Sat, 27 Apr 2019 17:31:49 +0000 - rev 526486
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1536229: Remove NS_RELEASE_ASSERT that is being tripped and seems to be unnecessary. r=rhunt a=lizzard Differential Revision: https://phabricator.services.mozilla.com/D29105
06f7ac4473b0c5f0e34a784e3f61d174f802a358: Bug 1535866: Check if a valid DeviceContext is available before attempting to use it. r=rhunt a=lizzard
Bas Schouten <bschouten@mozilla.com> - Sat, 27 Apr 2019 21:01:29 +0000 - rev 526485
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1535866: Check if a valid DeviceContext is available before attempting to use it. r=rhunt a=lizzard Differential Revision: https://phabricator.services.mozilla.com/D29106
586c8f0a3c2d5fda683fba7700c526735091d303: Bug 1546327 - Clean up bytecode and source note allocation. r=arai a=lizzard
Jan de Mooij <jdemooij@mozilla.com> - Mon, 29 Apr 2019 12:55:20 +0000 - rev 526438
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1546327 - Clean up bytecode and source note allocation. r=arai a=lizzard Differential Revision: https://phabricator.services.mozilla.com/D28469
a6d52faaa77c3c7be1e3614157eb2bc15d7b488f: Bug 1542097 - Directly downmix to mono. r=bryce a=lizzard
Jean-Yves Avenard <jyavenard@mozilla.com> - Mon, 22 Apr 2019 13:27:42 +0000 - rev 526433
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1542097 - Directly downmix to mono. r=bryce a=lizzard No need to first downmix to stereo and then mono. Differential Revision: https://phabricator.services.mozilla.com/D27216
00567ac38963b491628cc9d70e131ffd4f67b029: Bug 1470107 - Update Twemoji Mozilla to 0.4.0 (twemoji 11.4.0). r=jfkthame a=lizzard
Ian Moody <moz-ian@perix.co.uk> - Fri, 19 Apr 2019 20:58:50 +0000 - rev 526274
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1470107 - Update Twemoji Mozilla to 0.4.0 (twemoji 11.4.0). r=jfkthame a=lizzard Differential Revision: https://phabricator.services.mozilla.com/D27865
5e9f1cf0693663467059f729d897e2f23b4631e9: Bug 1542581 - Block child process termination until the handler is fully initialized. r=froydnj, a=lizzard
Gabriele Svelto <gsvelto@mozilla.com> - Wed, 17 Apr 2019 18:55:14 +0000 - rev 526270
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1542581 - Block child process termination until the handler is fully initialized. r=froydnj, a=lizzard Differential Revision: https://phabricator.services.mozilla.com/D27231
5710827ee9cf5011b6698590a7d31e922f636cf2: Bug 1540136 - P5: Handle if ChromiumCDMProxy is shutdown in the middle of init. r=cpearce a=lizzard
Bryce Van Dyk <bvandyk@mozilla.com> - Tue, 09 Apr 2019 15:07:49 +0000 - rev 526224
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1540136 - P5: Handle if ChromiumCDMProxy is shutdown in the middle of init. r=cpearce a=lizzard - Watch for if a proxy shuts down during init and if so, shutdown the CDM parent that is being initialized. - Make ChromiumCDMParent only store a pointer to a ChromiumCDMProxy when it has successfully initialized. This avoid the lopsided relationship where a if a ChromiumCDMParent fails to initialize it may keep a pointer to a proxy, but the proxy will never have a reference to that CDM parent. Differential Revision: https://phabricator.services.mozilla.com/D26208
ecb3ee5969c19fe8c52cedb2bd0291edf11dc83c: Bug 1540136 - P4: Remove ChromiumCDMParent mMainThread as it is unused. r=cpearce a=lizzard
Bryce Van Dyk <bvandyk@mozilla.com> - Tue, 09 Apr 2019 15:07:19 +0000 - rev 526223
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1540136 - P4: Remove ChromiumCDMParent mMainThread as it is unused. r=cpearce a=lizzard Differential Revision: https://phabricator.services.mozilla.com/D26207
385fde9e64e20795ca20d6cb7db114b0c0bcc8fe: Bug 1540136 - P3: ChromiumCDMProxy runs CDM init thennable code on the main thread. r=cpearce a=lizzard
Bryce Van Dyk <bvandyk@mozilla.com> - Tue, 09 Apr 2019 15:06:59 +0000 - rev 526222
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1540136 - P3: ChromiumCDMProxy runs CDM init thennable code on the main thread. r=cpearce a=lizzard This code is calling other code that expects to be on the main thread, and having this on the main thread (now that the main thread is a serial event target) makes it easier to reason about this and other main thread code. I.e. this cannot be running during other main thread code. Differential Revision: https://phabricator.services.mozilla.com/D26206
48e7d2342ffa2f1bc57853dcd0c3a8e4ca838c42: Bug 1540136 - P2: CDMProxy stores main thread as nsISerialEventTarget, rather than nsIEventTarget. r=cpearce a=lizzard
Bryce Van Dyk <bvandyk@mozilla.com> - Tue, 09 Apr 2019 15:06:38 +0000 - rev 526221
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1540136 - P2: CDMProxy stores main thread as nsISerialEventTarget, rather than nsIEventTarget. r=cpearce a=lizzard This gives us greater flexibility in using the main thread member to run promises. The site where we obtain the main thread returns a serial event target, so we're not doing much more work here, we're just keeping the serial event target interface, rather than converting to an event target interface. Differential Revision: https://phabricator.services.mozilla.com/D26205
40fb1ced2598f5f2372a29819baaab5c5aab8208: Bug 1540136 - P1: Log more info in ChromiumCDMProxy dtor and Shutdown. r=cpearce a=lizzard
Bryce Van Dyk <bvandyk@mozilla.com> - Tue, 09 Apr 2019 15:05:01 +0000 - rev 526220
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1540136 - P1: Log more info in ChromiumCDMProxy dtor and Shutdown. r=cpearce a=lizzard Also remove unneeded MOZ_COUNT_[CTOR|DTOR] macros. We already get similar functionality from NS_INLINE_DECL_THREADSAFE_REFCOUNTING. Differential Revision: https://phabricator.services.mozilla.com/D26204
31a6f6acd33fe33e331688cdf7c5ac490e4aa122: Bug 1538083 - Fix -0 handling in ARM64 visitTrunc(). r=nbp a=lizzard
Sean Stangl <sean.stangl@gmail.com> - Thu, 11 Apr 2019 22:34:46 +0000 - rev 526186
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1538083 - Fix -0 handling in ARM64 visitTrunc(). r=nbp a=lizzard The existing truncation code did not correctly handle the case of negative zero. The fix is to avoid using FCMP floating-point comparisons, and check the sign bit explicitly in a GPR. Differential Revision: https://phabricator.services.mozilla.com/D26381
a692fdeb597b58fc21c0237aee9adf7540c72695: Bug 1538666: Fix typo in PathCapture::TransformedCopyToBuilder. r=rhunt a=lizzard
Bas Schouten <bschouten@mozilla.com> - Fri, 05 Apr 2019 17:59:17 +0200 - rev 526099
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1538666: Fix typo in PathCapture::TransformedCopyToBuilder. r=rhunt a=lizzard Differential Revision: https://phabricator.services.mozilla.com/D26335
94eb3f14832dfc714f8bc4044eee043ce61c0299: Bug 1549061 - Add intermediate certificate, force signature reverification;r=zombie a=lizzard CLOSED TREE FIREFOX_66_0_4_BUILD2
Mark Goodwin <mgoodwin@mozilla.com> - Sat, 04 May 2019 10:40:32 -0700 - rev 516445
Push 2017 by bgrinstead@mozilla.com at Sat, 04 May 2019 18:34:36 +0000
Bug 1549061 - Add intermediate certificate, force signature reverification;r=zombie a=lizzard CLOSED TREE Differential Revision: https://phabricator.services.mozilla.com//D29940
d4f7f9eb9e7d95b021ab00e4d78a915bd657f5b9: Bug 1549010: Part 2 - Bump DB schema version to force certificate reverification. r=zombie a=lizzard CLOSED TREE FENNEC_66_0_4_BUILD1 FIREFOX_66_0_4_BUILD1
Kris Maglione <maglione.k@gmail.com> - Fri, 03 May 2019 21:39:25 -0700 - rev 516441
Push 2013 by maglione.k@gmail.com at Sat, 04 May 2019 05:16:30 +0000
Bug 1549010: Part 2 - Bump DB schema version to force certificate reverification. r=zombie a=lizzard CLOSED TREE Users who are affected by the intermediate add-on signing certificate expiry need their add-on signatures re-verified as soon as possible after updating to a version containging the fix. A database rebuild includes signature reverifications, so a schema version achieves this. Differential Revision: https://phabricator.services.mozilla.com/D29931
9cdb06fa51891f31c4371b3d06d8e46148b5237a: Bug 1549010 - verify add-on signing certificates at 2019-04-27T02:43:20.000Z r=jcj a=lizzard
Dana Keeler <dkeeler@mozilla.com> - Sat, 04 May 2019 04:15:11 +0000 - rev 516440
Push 2013 by maglione.k@gmail.com at Sat, 04 May 2019 05:16:30 +0000
Bug 1549010 - verify add-on signing certificates at 2019-04-27T02:43:20.000Z r=jcj a=lizzard Differential Revision: https://phabricator.services.mozilla.com/D29928
37ecfd08ffee9924609121aaec3f101598f8a84e: Bug 1538666: Fix typo in PathCapture::TransformedCopyToBuilder. r=rhunt a=lizzard FIREFOX_66_0_3_BUILD1 FIREFOX_66_0_3_RELEASE
Bas Schouten <bschouten@mozilla.com> - Fri, 05 Apr 2019 17:59:17 +0200 - rev 516429
Push 2003 by archaeopteryx@coole-files.de at Tue, 09 Apr 2019 15:53:32 +0000
Bug 1538666: Fix typo in PathCapture::TransformedCopyToBuilder. r=rhunt a=lizzard Differential Revision: https://phabricator.services.mozilla.com/D26335
39016a9b0984c9fa238304248e03fdbe8530ee12: Bug 1540017 - Update Baidu searchplugin with new code. r=mkaply a=lizzard
Hector Zhao <bzhao@mozilla.com> - Sun, 07 Apr 2019 16:55:50 +0300 - rev 516427
Push 2001 by archaeopteryx@coole-files.de at Mon, 08 Apr 2019 16:52:31 +0000
Bug 1540017 - Update Baidu searchplugin with new code. r=mkaply a=lizzard Differential Revision: https://phabricator.services.mozilla.com/D25339
70bc92ce18e9d5a7c48617e2e12ebfaa73097e9f: Bug 1539618 - Remove superfluous dot from use_legacy_keycode_and_charcode pref. r=miketaylr a=lizzard
Dennis Schubert <dschubert@mozilla.com> - Wed, 27 Mar 2019 20:19:56 +0000 - rev 516425
Push 1999 by archaeopteryx@coole-files.de at Fri, 05 Apr 2019 18:44:18 +0000
Bug 1539618 - Remove superfluous dot from use_legacy_keycode_and_charcode pref. r=miketaylr a=lizzard Differential Revision: https://phabricator.services.mozilla.com/D25125
c6f45f6f744d2ed02894fdfe336b3e018db8088c: Bug 1537609 - Cap the stack size at 2MB on Windows. r=jandem a=lizzard
Jason Orendorff <jorendorff@mozilla.com> - Wed, 27 Mar 2019 15:12:00 +0000 - rev 516424
Push 1999 by archaeopteryx@coole-files.de at Fri, 05 Apr 2019 18:44:18 +0000
Bug 1537609 - Cap the stack size at 2MB on Windows. r=jandem a=lizzard In bug 256180, the size of the stack on 64-bit Windows was changed from 2MB to 8MB, and on 32-bit Windows, from 1MB to 1.5MB. This is so large that it takes significantly longer for a runaway recursive function to throw "too much recursion", which causes terrible performance in scripts obfuscated using obfuscator.io. This patch leaves the actual stack size as-is, but changes the JS-engine-specific stack quota back to 2MB on 64-bit Windows (6MB if ASAN is enabled). 32-bit Windows is unaffected by the new cap. Differential Revision: https://phabricator.services.mozilla.com/D24597
7f4781ff8f7dce970fb977bc93af0e56f19f6ded: Bug 1538970 - Add IBM domains as wildcard exceptions for legacy keyCode and charCode. r=miketaylr a=lizzard
Dennis Schubert <dschubert@mozilla.com> - Tue, 26 Mar 2019 19:13:22 +0000 - rev 516423
Push 1999 by archaeopteryx@coole-files.de at Fri, 05 Apr 2019 18:44:18 +0000
Bug 1538970 - Add IBM domains as wildcard exceptions for legacy keyCode and charCode. r=miketaylr a=lizzard Differential Revision: https://phabricator.services.mozilla.com/D24948
4400ca694ade1d9b1883c0278b5be984096c77da: Bug 1498973: Don't show a popup that should be hidden. r=jmathies a=lizzard
Adam Gashlin <agashlin@mozilla.com> - Tue, 26 Mar 2019 10:49:50 -0700 - rev 516422
Push 1999 by archaeopteryx@coole-files.de at Fri, 05 Apr 2019 18:44:18 +0000
Bug 1498973: Don't show a popup that should be hidden. r=jmathies a=lizzard This includes the fix for the bug 1534935 regression.
7c987c3a58404a6c480e2952a4f5ef4a70aee058: Bug 1534796 Tweak default search prompts r=aswan a=lizzard FENNEC_66_0_BUILD2 FIREFOX_66_0_BUILD2
Mike Kaply <mozilla@kaply.com> - Wed, 13 Mar 2019 21:15:26 +0200 - rev 516374
Push 1967 by btara@mozilla.com at Wed, 13 Mar 2019 19:34:04 +0000
Bug 1534796 Tweak default search prompts r=aswan a=lizzard Reviewers: aswan Reviewed By: aswan Subscribers: aryx, opoprus, jcristau, pascalc, mixedpuppy, mkaply, aswan, ddurst, TheOne Tags: #secure-revision, #bmo-mozilla-employee-confidential Bug #: 1534796 Differential Revision: https://phabricator.services.mozilla.com/D23227
bf49080b9793f3048554c3c63ce1d58d93a8c21c: Bug 1527393 - Ignore additional codes. r=adw a=lizzard
Michael Kaply <mozilla@kaply.com> - Sat, 09 Mar 2019 01:26:37 +0000 - rev 516373
Push 1966 by btara@mozilla.com at Wed, 13 Mar 2019 18:59:53 +0000
Bug 1527393 - Ignore additional codes. r=adw a=lizzard Differential Revision: https://phabricator.services.mozilla.com/D19539
791061efa6367a23945f207aa16a663e9c982faa: Bug 1534796 Tweak default search prompts r=mkaply a=lizzard
Andrew Swan <aswan@mozilla.com> - Tue, 12 Mar 2019 14:32:24 -0700 - rev 516369
Push 1963 by archaeopteryx@coole-files.de at Wed, 13 Mar 2019 15:32:59 +0000
Bug 1534796 Tweak default search prompts r=mkaply a=lizzard Differential Revision: https://phabricator.services.mozilla.com/D23227
2c906ef692e7556a04a924a302bf7a7fb464b0f0: Bug 1532761 - Add regionOverrides engine to jarNames. r=daleharvey a=lizzard
Michael Kaply <mozilla@kaply.com> - Wed, 13 Mar 2019 16:22:05 +0100 - rev 516368
Push 1963 by archaeopteryx@coole-files.de at Wed, 13 Mar 2019 15:32:59 +0000
Bug 1532761 - Add regionOverrides engine to jarNames. r=daleharvey a=lizzard Differential Revision: https://phabricator.services.mozilla.com/D22182
586f46c17c458f3e95f65806eedf44e024f0c245: Bug 1531346 - Check for cyclical relationship with aria-activedescendant. r=MarcoZ a=lizzard
Eitan Isaacson <eitan@monotonous.org> - Fri, 08 Mar 2019 07:55:13 +0000 - rev 516367
Push 1963 by archaeopteryx@coole-files.de at Wed, 13 Mar 2019 15:32:59 +0000
Bug 1531346 - Check for cyclical relationship with aria-activedescendant. r=MarcoZ a=lizzard Differential Revision: https://phabricator.services.mozilla.com/D22633
38edbc4fa662709ad0602d1feed51bea61711931: Bug 1530488 - Disable camera for aarch64 windows builds; r=pehrsons a=lizzard
Dan Minor <dminor@mozilla.com> - Wed, 27 Feb 2019 19:50:04 +0000 - rev 516366
Push 1963 by archaeopteryx@coole-files.de at Wed, 13 Mar 2019 15:32:59 +0000
Bug 1530488 - Disable camera for aarch64 windows builds; r=pehrsons a=lizzard This disables the camera for win64-aarch64 for Windows versions below 19H1. These versions have problems with the DirectShow implementation which prevent the camera from working properly. Differential Revision: https://phabricator.services.mozilla.com/D21272
6776dac63175e5724bb472ae64863c349613c1c6: Bug 1498973: Don't show a popup that should be hidden. r=jmathies a=lizzard FENNEC_66_0_BUILD1 FIREFOX_66_0_BUILD1
Adam Gashlin <agashlin@mozilla.com> - Wed, 06 Mar 2019 18:48:50 +0000 - rev 516363
Push 1960 by archaeopteryx@coole-files.de at Mon, 11 Mar 2019 21:10:48 +0000
Bug 1498973: Don't show a popup that should be hidden. r=jmathies a=lizzard Differential Revision: https://phabricator.services.mozilla.com/D21801
61bc653da5a9993e9192ee5d3763bffe13d74b4b: Bug 1528045: Add detection for Win10 1809 to WindowsVersion.h; r=froydnj a=lizzard
Aaron Klotz <aklotz@mozilla.com> - Tue, 05 Feb 2019 15:10:11 -0700 - rev 516362
Push 1960 by archaeopteryx@coole-files.de at Mon, 11 Mar 2019 21:10:48 +0000
Bug 1528045: Add detection for Win10 1809 to WindowsVersion.h; r=froydnj a=lizzard
f7a6917dd431fa49e5cc2c50a0f97c035b75e20c: Bug 1531893 - Add support for search channel. r=mikedeboer a=lizzard
Michael Kaply <mozilla@kaply.com> - Mon, 11 Mar 2019 22:09:33 +0100 - rev 516361
Push 1960 by archaeopteryx@coole-files.de at Mon, 11 Mar 2019 21:10:48 +0000
Bug 1531893 - Add support for search channel. r=mikedeboer a=lizzard
481d211be2ffad0d806292ebce8d3e242a8ca34d: Bug 1498973: Don't show a popup that should be hidden. r=jmathies a=lizzard
Adam Gashlin <agashlin@mozilla.com> - Wed, 06 Mar 2019 18:48:50 +0000 - rev 516359
Push 1958 by archaeopteryx@coole-files.de at Mon, 11 Mar 2019 18:49:17 +0000
Bug 1498973: Don't show a popup that should be hidden. r=jmathies a=lizzard Differential Revision: https://phabricator.services.mozilla.com/D21801
c26b774af2a7eb43509d18373a4da0320ae8aa12: Bug 1528317 - Return NS_ERROR_NET_HTTP2_SENT_GOAWAY only when we have a protocol error. r=valentin a=lizzard
Dragana Damjanovic <dd.mozilla@gmail.com> - Thu, 07 Mar 2019 21:03:27 +0000 - rev 516358
Push 1958 by archaeopteryx@coole-files.de at Mon, 11 Mar 2019 18:49:17 +0000
Bug 1528317 - Return NS_ERROR_NET_HTTP2_SENT_GOAWAY only when we have a protocol error. r=valentin a=lizzard In bug 1050329 we have introduced a new error and an error page to show that there is a h2 protocol error. The problem is that we show that error when we close a h2 connection for any reason, like a network timeout. Also Http2Session::SessionError does not return NS_ERROR_ILLEGAL_VALUE error but NS_ERROR_NET_HTTP2_SENT_GOAWAY. Differential Revision: https://phabricator.services.mozilla.com/D22525
506f35a82fa7f3e8194d5129fe21bc28693ba75d: Bug 1533261: Check whether PeerConnectionCtx is active before calling GetInstance. r=mjf a=lizzard
Byron Campen [:bwc] <docfaraday@gmail.com> - Fri, 08 Mar 2019 15:25:20 +0000 - rev 516357
Push 1957 by archaeopteryx@coole-files.de at Mon, 11 Mar 2019 18:03:35 +0000
Bug 1533261: Check whether PeerConnectionCtx is active before calling GetInstance. r=mjf a=lizzard Differential Revision: https://phabricator.services.mozilla.com/D22530
6c270c1fddd04fe20d5e756b05b390cc6c3bd7e2: Bug 1533667 - Fix scroll to bottom with repeated messages; r=Honza a=lizzard
Nicolas Chevobbe <nchevobbe@mozilla.com> - Fri, 08 Mar 2019 13:28:57 +0000 - rev 516356
Push 1957 by archaeopteryx@coole-files.de at Mon, 11 Mar 2019 18:03:35 +0000
Bug 1533667 - Fix scroll to bottom with repeated messages; r=Honza a=lizzard When a message was repeated, the bubble would appear and slightly increase the message size (by 1px), making it lose its bottom-anchoring. Then, if a new message came, the console won't automatically scroll anymore. This patch modifies the repeat bubble CSS so it doesn't impact the message height, and add a test case in the test which asserts the scroll to bottom feature. Differential Revision: https://phabricator.services.mozilla.com/D22672
9faa04ade14af2a14d05bed419678b35eca8911c: Bug 1534256 - actually open the right help topic page, r=jaws a=lizzard
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Mon, 11 Mar 2019 14:11:53 +0000 - rev 516355
Push 1957 by archaeopteryx@coole-files.de at Mon, 11 Mar 2019 18:03:35 +0000
Bug 1534256 - actually open the right help topic page, r=jaws a=lizzard Differential Revision: https://phabricator.services.mozilla.com/D22973
4ed0c8d33336c4c811f85396b4233c54d782d766: Bug 1527572 - Properly style the download panel summary. r=Felipe a=lizzard FIREFOX_RELEASE_66_BASE
Dão Gottwald <dao@mozilla.com> - Fri, 08 Mar 2019 02:55:20 +0000 - rev 516344
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1527572 - Properly style the download panel summary. r=Felipe a=lizzard Differential Revision: https://phabricator.services.mozilla.com/D22096
0b7f3caba2aa08835a4f252c6805c0224f029d98: Bug 1532719 - Reset _pinnedUnscrollable flag when unpinning a tab. r=Gijs a=lizzard
Dão Gottwald <dao@mozilla.com> - Thu, 07 Mar 2019 11:47:26 +0000 - rev 516343
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1532719 - Reset _pinnedUnscrollable flag when unpinning a tab. r=Gijs a=lizzard Differential Revision: https://phabricator.services.mozilla.com/D22474
93d78ef4e591cb9b980605691051abadaca9d773: Bug 1528097 - U2F doesn't work on Windows 10 19H1/20H1 Insider builds r=jcj, keeler a=lizzard
Bogdan Tara <btara@mozilla.com> - Sat, 09 Mar 2019 06:00:23 +0200 - rev 516342
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1528097 - U2F doesn't work on Windows 10 19H1/20H1 Insider builds r=jcj, keeler a=lizzard Reviewers: jcj, keeler Reviewed By: jcj, keeler Subscribers: reviewbot, jcj Bug #: 1528097 Differential Revision: https://phabricator.services.mozilla.com/D22343
c4d0a83454a291d01e5c8d2f9215a2d43c890562: Bug 1522092 - Disable PanelMultiView's keyboard navigation code for the Site Identity panel. r=johannh a=lizzard
Bogdan Tara <btara@mozilla.com> - Sat, 09 Mar 2019 05:43:26 +0200 - rev 516341
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1522092 - Disable PanelMultiView's keyboard navigation code for the Site Identity panel. r=johannh a=lizzard Summary: PanelMultiView's keyboard navigation code currently overrides the arrow keys in menulists. This breaks the permission selectors in the Site Identity panel. For now, just disable this keyboard navigation code. DOM will then handle tabbing as it normally would. This panel is more like a dialog than a menu, so users will generally navigate it with the tab key rather than the arrow keys anyway. Note that the code in PanelMultiView which makes controls focusable still runs even with disablekeynav set, which is what we want. Reviewers: johannh Reviewed By: johannh Bug #: 1522092 Differential Revision: https://phabricator.services.mozilla.com/D21484
0bc584b08a5f13eef5686c63cca8bfd3698b8c6e: Bug 1530594 - treat menulists as always being leaf frames. r=tnikkel a=lizzard
Neil Deakin <neil@mozilla.com> - Sat, 09 Mar 2019 05:35:44 +0200 - rev 516340
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1530594 - treat menulists as always being leaf frames. r=tnikkel a=lizzard Summary: ...false from IsLeafDynamic anyway, the only effect is that this one menulist is now not a leaf, allowing its content to be generated upfront. This particular menulist only has two items in it anyway so there shouldn't be a performance issue, r?tnikkel Reviewers: tnikkel Reviewed By: tnikkel Bug #: 1530594 Differential Revision: https://phabricator.services.mozilla.com/D22517
fb07e38d917f7d605c23dec973b5811b9b9bd9a9: Bug 1530423 - Ensure breakpoints are added to newly-cloned JSScripts for existing sources. r=loganfsmyth a=lizzard
Logan Smyth <loganfsmyth@gmail.com> - Thu, 07 Mar 2019 01:01:05 +0000 - rev 516339
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1530423 - Ensure breakpoints are added to newly-cloned JSScripts for existing sources. r=loganfsmyth a=lizzard Similar to bug 1528654, we currently bail out too early and don't process all of the correct scripts when adding breakpoints. Differential Revision: https://phabricator.services.mozilla.com/D22355
6719bb90ce8ae048c9366e92cff22dcedd59eae7: Bug 1518863: Part 4 - Add tests. r=aswan, a=lizzard
Kris Maglione <maglione.k@gmail.com> - Wed, 27 Feb 2019 13:57:08 -0800 - rev 516338
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1518863: Part 4 - Add tests. r=aswan, a=lizzard Differential Revision: https://phabricator.services.mozilla.com/D21449
24f6b74fe41c781c47c81eb69e737f60e0d0ca8f: Bug 1518863: Part 3 - Initialize stub extension policies in child during startup. r=aswan, a=lizzard
Kris Maglione <maglione.k@gmail.com> - Wed, 27 Feb 2019 13:26:03 -0800 - rev 516337
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1518863: Part 3 - Initialize stub extension policies in child during startup. r=aswan, a=lizzard We already create early stub policy objects in the parent process during extension startup, so that early load attempts and policy queries can succeed during startup and extension installation. This patch does the same for child processes, which likewise may be asked to load extension URLs early during startup when they override the homepage or have pages loaded from session restore. Differential Revision: https://phabricator.services.mozilla.com/D21448
f754bdfd46155e680afee58b230a1e08cf2c3b14: Bug 1518863: Part 2 - Delay extension protocol requests until extension is ready. r=aswan, a=lizzard
Kris Maglione <maglione.k@gmail.com> - Wed, 27 Feb 2019 11:54:31 -0800 - rev 516336
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1518863: Part 2 - Delay extension protocol requests until extension is ready. r=aswan, a=lizzard We don't want extension protocol load requests to begin loading until the extension is far enough initialized to run code. If we load it before then, the extension framework will either fail to recognize the extension entirely, or may begin running its scripts in an incomplete environment. This patch adds a slow path which adds a promise handler and creats a stub channel only in the case when the extension is not ready. In the normal, already-initialized case, we take the more direct path. Differential Revision: https://phabricator.services.mozilla.com/D21447
29e17fe8593d1c8953e82e243767f0c0d9addad5: Bug 1518863: Part 1 - Add ready promise to WebExtensionPolicy. r=aswan, a=lizzard
Kris Maglione <maglione.k@gmail.com> - Wed, 27 Feb 2019 13:26:37 -0800 - rev 516335
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1518863: Part 1 - Add ready promise to WebExtensionPolicy. r=aswan, a=lizzard This adds a promise member to the stub WebExtensionPolicy objects that we create early during extension initialization which resolves when the real extension instance is ready to load content. This promise will be used by the extension protocol handler to delay loads until the framework is ready to handle them. Differential Revision: https://phabricator.services.mozilla.com/D21445
392c75fdaebbd9738e2fef7160169ae1e6df390c: Bug 1518863: Part 0 - Minor extension protocol handler cleanup. r=aswan, a=lizzard
Kris Maglione <maglione.k@gmail.com> - Tue, 26 Feb 2019 12:58:55 -0800 - rev 516334
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1518863: Part 0 - Minor extension protocol handler cleanup. r=aswan, a=lizzard These are trivial issues that I'd rather keep out of the main patch. Differential Revision: https://phabricator.services.mozilla.com/D21444