searching for reviewer(kvark)
76e3a842e496d78a80cd547b7bf94f041f9bc612: Bug 1551187 - Rename DropShadowStack into DropShadows. r=kvark"
Nicolas Silva <nsilva@mozilla.com> - Wed, 15 May 2019 15:21:53 +0200 - rev 536266
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1551187 - Rename DropShadowStack into DropShadows. r=kvark" Differential Revision: https://phabricator.services.mozilla.com/D31248
f8516287a42503baa4cce8bee1a6025fa92f6095: Bug 1551187 - Box the color matrix in Filter. r=kvark
Nicolas Silva <nsilva@mozilla.com> - Mon, 13 May 2019 14:55:57 +0200 - rev 536051
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1551187 - Box the color matrix in Filter. r=kvark ColorMatrix is rarely used but takes most space in the Filter enum. This removes 44 bytes from the enum and all structs that embed it. Differential Revision: https://phabricator.services.mozilla.com/D30910
f92d432ffcc8bff708398c39548caa5898be4c03: Bug 1551187 - Rename render task tree into render task graph. r=kvark
Nicolas Silva <nsilva@mozilla.com> - Wed, 15 May 2019 15:11:42 +0200 - rev 536050
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1551187 - Rename render task tree into render task graph. r=kvark Differential Revision: https://phabricator.services.mozilla.com/D30897
091801115a02d2bcfbacada8a3367c3bdd805a9a: Bug 1551187 - Remove the single-shadow picture composite code. r=kvark
Nicolas Silva <nsilva@mozilla.com> - Wed, 15 May 2019 15:57:34 +0200 - rev 536049
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1551187 - Remove the single-shadow picture composite code. r=kvark Differential Revision: https://phabricator.services.mozilla.com/D30896
3339438190872637a2fbb4225ff3dc71e61721a9: Bug 1551187 - Box the color matrix in Filter. r=kvark
Nicolas Silva <nsilva@mozilla.com> - Wed, 15 May 2019 13:15:55 +0000 - rev 535819
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1551187 - Box the color matrix in Filter. r=kvark ColorMatrix is rarely used but takes most space in the Filter enum. This removes 44 bytes from the enum and all structs that embed it. Differential Revision: https://phabricator.services.mozilla.com/D30910
dc83934fa03259f44e80c9529320b280d15ae042: Bug 1551187 - Rename render task tree into render task graph. r=kvark
Nicolas Silva <nsilva@mozilla.com> - Wed, 15 May 2019 13:16:17 +0000 - rev 535818
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1551187 - Rename render task tree into render task graph. r=kvark sed -i 's/RenderTaskTree/RenderTaskGraph/g' gfx/wr/webrender/**/*.rs sed -i 's/task tree/task graph/g' gfx/wr/webrender/**/*.rs Differential Revision: https://phabricator.services.mozilla.com/D30897
aa02e32fd5bfe34931068d3906cc68a3993ad60e: Bug 1551187 - Remove the single-shadow picture composite code. r=kvark
Nicolas Silva <nsilva@mozilla.com> - Wed, 15 May 2019 13:16:19 +0000 - rev 535817
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1551187 - Remove the single-shadow picture composite code. r=kvark Differential Revision: https://phabricator.services.mozilla.com/D30896
a2fe99cb693af42947db157c030ac85c47002c0d: Bug 1551353 - Correctly map PBOs for readback on GLES r=kvark
Barret Rennie <barret@brennie.ca> - Tue, 14 May 2019 22:54:19 +0000 - rev 535769
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1551353 - Correctly map PBOs for readback on GLES r=kvark The implementation of `Device::map_pbo_for_readback` on GLES (e.g., Windows with ANGLE) was using the incorrect enumeration value when attempting to map the buffer into memory. Differential Revision: https://phabricator.services.mozilla.com/D31156
bcbaf50dca2841ec7a86f208661a5c27c49fd5fb: Bug 1536021 - Gecko side changes. r=kvark
Nicolas Silva <nsilva@mozilla.com> - Fri, 10 May 2019 22:13:31 +0200 - rev 535435
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1536021 - Gecko side changes. r=kvark Differential Revision: https://phabricator.services.mozilla.com/D30618
82e5affb98af1ae4e697c32e1a83d40b6ced69ea: Bug 1536021 - Sanitize filters in place. r=kvark
Nicolas Silva <nsilva@mozilla.com> - Fri, 10 May 2019 01:23:54 +0200 - rev 535434
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1536021 - Sanitize filters in place. r=kvark
d8bd0fd8057945c2798d0cc489bd84a50607da95: Bug 1536021 - Shadow stack implementation. r=kvark
Nicolas Silva <nsilva@mozilla.com> - Sun, 12 May 2019 12:27:44 +0200 - rev 535433
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1536021 - Shadow stack implementation. r=kvark Differential Revision: https://phabricator.services.mozilla.com/D30620
0849b28c8e3db984273f97a8d6ea4f7284802f49: Bug 1550725 - Cull primitives with an empty clip. r=kvark
Andrew Osmond <aosmond@mozilla.com> - Fri, 10 May 2019 11:17:10 -0400 - rev 535392
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1550725 - Cull primitives with an empty clip. r=kvark When the clip chain generates the local clip rect for a primitive, it can be empty. This violated the assumption that the visible rect will never be empty, and so when we snap, it produces NaNs, which in turn, violates other assumptions when converting between spaces, and hence the crash. Now we cull the primitive from the visible list if the local clip rect is empty, or if the visible rect is empty. Differential Revision: https://phabricator.services.mozilla.com/D30659
d8fa440167f565c4553fc09e55caceb6544e2d89: Bug 1524427 - Fix panic when clip mask is supplied with non-existent image key. r=kvark
Glenn Watson <github@intuitionlibrary.com> - Thu, 09 May 2019 21:23:58 +0000 - rev 535213
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1524427 - Fix panic when clip mask is supplied with non-existent image key. r=kvark In some cases, Gecko supplies a display item with an image clip mask where the image itself does not exist in the resource cache. In these cases, WR would skip requesting the image, but would still try to fetch the image info during batching, causing a panic. This patch skips adding clip items to the batching pass if the image mask does not exist. It also adds support to wrench for a crash test when the image mask is invalid. Differential Revision: https://phabricator.services.mozilla.com/D30560
b54d90e1c6814f37918a8a6a1e6fc5054ea6e868: Bug 1549921 - Refactor batch building code in preparation for multiple alpha batchers per picture. r=kvark
Glenn Watson <github@intuitionlibrary.com> - Wed, 08 May 2019 20:32:39 +0000 - rev 535002
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1549921 - Refactor batch building code in preparation for multiple alpha batchers per picture. r=kvark This patch is scaffolding only - there shouldn't be any functional changes as a result of these changes. Differential Revision: https://phabricator.services.mozilla.com/D30330
a8b4591d504eef634e7c88e774591a84666cf8cc: Bug 1547833 - Check for the KHR_debug extension before trying to use it. r=gw,kvark
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 06 May 2019 12:16:15 +0000 - rev 534774
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1547833 - Check for the KHR_debug extension before trying to use it. r=gw,kvark Differential Revision: https://phabricator.services.mozilla.com/D29824
2371d3a7ab2d46e91f4a71d1accfb74c5b01429e: Bug 1525402 - Mark all gfx/wr crates as Rust 2018. r=kvark
Alexis Beingessner <a.beingessner@gmail.com> - Tue, 07 May 2019 01:39:22 +0000 - rev 534706
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1525402 - Mark all gfx/wr crates as Rust 2018. r=kvark Differential Revision: https://phabricator.services.mozilla.com/D29569
f072f15ba54ede2c3c1eb24c09593284b3bc7c72: Bug 1525402 - Run `cargo fix --edition` on webrender on macos. r=kvark
Alexis Beingessner <a.beingessner@gmail.com> - Tue, 07 May 2019 01:40:23 +0000 - rev 534705
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1525402 - Run `cargo fix --edition` on webrender on macos. r=kvark Differential Revision: https://phabricator.services.mozilla.com/D29567
16d8a19df81393398075c6f4695d9a55b96b55d2: Bug 1525402 - Manual fixups for configs cargo fix missed. r=kvark
Alexis Beingessner <a.beingessner@gmail.com> - Tue, 07 May 2019 01:40:21 +0000 - rev 534704
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1525402 - Manual fixups for configs cargo fix missed. r=kvark cargo fix works by building under a specific config, so we can't hit both sides of a mutually exclusive pair of cfgs, such as cfg(target_os) or when cfg(feature) and cfg(not(feature)) both exist in the codebase. Differential Revision: https://phabricator.services.mozilla.com/D29568
8c7d885ae03623bf540a6d31372b5585e2aabcab: Bug 1525402 - Migrate webrender externs to a Rust 2018 compatible form. r=kvark
Alexis Beingessner <a.beingessner@gmail.com> - Tue, 07 May 2019 01:40:19 +0000 - rev 534703
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1525402 - Migrate webrender externs to a Rust 2018 compatible form. r=kvark Notably `extern crate foo as bar` is no longer supported (must do it in Cargo.toml). Also stopped using euclid through webrender_api, because it produces worse results in 2018. Differential Revision: https://phabricator.services.mozilla.com/D29566
ddce4ed9bb05e90f16187c66c798737110ca4be9: Bug 1525402 - Bump cbindgen to 0.8.6. r=kvark
Alexis Beingessner <a.beingessner@gmail.com> - Tue, 07 May 2019 01:40:15 +0000 - rev 534701
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1525402 - Bump cbindgen to 0.8.6. r=kvark This version adds support for Rust 2018's new externs Differential Revision: https://phabricator.services.mozilla.com/D29565
34510ca46cc61984ca775f30a7c4f288371cf329: Bug 1540200 - Part 3. Reuse snapping offsets calculated on the CPU in the WebRender shaders. r=kvark
Andrew Osmond <aosmond@mozilla.com> - Fri, 12 Apr 2019 09:34:25 -0400 - rev 534615
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1540200 - Part 3. Reuse snapping offsets calculated on the CPU in the WebRender shaders. r=kvark Historically we calculated the snapping offsets in the GPU shaders. Because this information is always needed on the CPU side, we now just pass the values into the shader instead of recalculating again. This ensures we will use the same set of values consistently and makes it easier to adjust how we snap in the future. This patch should have no functional change on the output of WebRender itself. Differential Revision: https://phabricator.services.mozilla.com/D28883
eefb300b7640986be7d1a4a23c133c4ebe73261d: Bug 1540200 - Part 2. Calculate snapped primitive rect and offsets for WebRender on the CPU. r=kvark
Andrew Osmond <aosmond@mozilla.com> - Wed, 10 Apr 2019 14:20:34 -0400 - rev 534614
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1540200 - Part 2. Calculate snapped primitive rect and offsets for WebRender on the CPU. r=kvark We currently do most snapping on the GPU in the shader. However the picture's local rect needs to take into account the snapping done there, so we need to calculate this earlier in the pipeline. Instead of using the clipped primitive local rects to create the picture's own local rect, we now snap the child local rects first. If no snapping is required, there should be no functional change. If snapping is required, there should be fewer visual distortions caused by an inaccurate picture local rect. Differential Revision: https://phabricator.services.mozilla.com/D28882
403ea69a03b06c297aad8938b40feffee4f5a5bc: Bug 1540200 - Part 1. Move picture local rect calculation to update visibility. r=kvark
Andrew Osmond <aosmond@mozilla.com> - Wed, 10 Apr 2019 12:35:20 -0400 - rev 534613
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1540200 - Part 1. Move picture local rect calculation to update visibility. r=kvark We currently calculate a picture's local rect when we are doing the first picture traversal. It was composed of the union of the clipped local rects of its children. However the true local rect of a picture is the union of the snapped clipped local rects of its children. The snapping is done in device space, but we won't know the exact transform until we establish the raster roots, which is based on the picture's local rect. As such, we create an estimated local rect which is how we currently calculate the local rect. Then once the raster roots have been selected, we recalculate the local rect of the picture based on its children during update visibility. This patch should have not contain any functional changes. Differential Revision: https://phabricator.services.mozilla.com/D28881
f53e8b390527be63434af20acb36b2012829c982: Bug 1541078 - Add pre/post frames hooks into save_capture r=kvark
Doug Thayer <dothayer@mozilla.com> - Mon, 06 May 2019 17:21:22 +0000 - rev 534606
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1541078 - Add pre/post frames hooks into save_capture r=kvark There's two ways we could get around this. We could add a path around the prepared_for_frames assertion in GpuCache::end_frame, or we can do this, and leave the TODO explicit with the assertion. I took the latter approach because we can clear the GpuCache / TextureCache through other routes than frame building anyway, so we could hit this failure path before any of the patches in this bug landed. Differential Revision: https://phabricator.services.mozilla.com/D29884
d4a4c9ad62fd31f0830763c7a46ebfd4d1f40301: Bug 1541078 - Rename before/after_frames r=kvark
Doug Thayer <dothayer@mozilla.com> - Mon, 06 May 2019 17:21:10 +0000 - rev 534605
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1541078 - Rename before/after_frames r=kvark These aren't great names - I couldn't come up with better though. We lose the symmetry of before/after but this clarifies a little bit what they are doing. Differential Revision: https://phabricator.services.mozilla.com/D29877
683736527e1e290a24b843c2915afb5985649d55: Bug 1541078 - Require frame builds for all docs after GpuCache clear r=kvark
Doug Thayer <dothayer@mozilla.com> - Mon, 06 May 2019 17:21:01 +0000 - rev 534604
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1541078 - Require frame builds for all docs after GpuCache clear r=kvark If we run a GpuCache clear and do not update all documents, we run into situations where the stale documents try to access things in the gpu cache and just show random garbage. The solution is similar to what we do for TextureCache, so I am just duplicating those signatures and providing helpers in RenderBackend to access both together. Differential Revision: https://phabricator.services.mozilla.com/D29860
5cba75dd63c2f1b4d2a34797e3e16e935f5ea763: Bug 1543974 - Deal with conflicting render task rect scheduling and allocation. r=kvark
Nicolas Silva <nsilva@mozilla.com> - Sat, 04 May 2019 13:31:13 +0000 - rev 534564
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1543974 - Deal with conflicting render task rect scheduling and allocation. r=kvark Due to the render task ping-pong target allocation scheme, we need to ensure: - that tasks only read from tasks that are an odd number of passes apart, - that render task content is kept valid long enough for all of the dependent tasks. The former is solved in this patch through blit tasks, the latter by marking tasks for saving as needed. Differential Revision: https://phabricator.services.mozilla.com/D29800
ee580278f872fc2b68631da034d80a3dbf4eed2a: Bug 1538540 - Respect texture_cache rebuild reqs even if doc has no pixels r=kvark
Doug Thayer <dothayer@mozilla.com> - Fri, 03 May 2019 20:30:46 +0000 - rev 534495
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1538540 - Respect texture_cache rebuild reqs even if doc has no pixels r=kvark If a document has an empty rect for whatever reason (in the case observed, this was due to running a full screen video in the content document, which occludes the chrome document), then we still want to ensure that we build a frame if the texture cache has performed a clear, as otherwise we may try to access stale items from the texture resolver in render_impl. Differential Revision: https://phabricator.services.mozilla.com/D29848
4352d1f0da341b26f79de16ca5b966ba17caa5da: Bug 1540200 - Part 3. Reuse snapping offsets calculated on the CPU in the WebRender shaders. r=kvark
Andrew Osmond <aosmond@mozilla.com> - Fri, 12 Apr 2019 09:34:25 -0400 - rev 534458
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1540200 - Part 3. Reuse snapping offsets calculated on the CPU in the WebRender shaders. r=kvark Historically we calculated the snapping offsets in the GPU shaders. Because this information is always needed on the CPU side, we now just pass the values into the shader instead of recalculating again. This ensures we will use the same set of values consistently and makes it easier to adjust how we snap in the future. This patch should have no functional change on the output of WebRender itself. Differential Revision: https://phabricator.services.mozilla.com/D28883
ff2ca836d8a7710ff5a3f7735c7767d90095c1c7: Bug 1540200 - Part 2. Calculate snapped primitive rect and offsets for WebRender on the CPU. r=kvark
Andrew Osmond <aosmond@mozilla.com> - Wed, 10 Apr 2019 14:20:34 -0400 - rev 534457
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1540200 - Part 2. Calculate snapped primitive rect and offsets for WebRender on the CPU. r=kvark We currently do most snapping on the GPU in the shader. However the picture's local rect needs to take into account the snapping done there, so we need to calculate this earlier in the pipeline. Instead of using the clipped primitive local rects to create the picture's own local rect, we now snap the child local rects first. If no snapping is required, there should be no functional change. If snapping is required, there should be fewer visual distortions caused by an inaccurate picture local rect. Differential Revision: https://phabricator.services.mozilla.com/D28882
3e4cc0d312d0d4c953484a964a0ef8ecb3201601: Bug 1540200 - Part 1. Move picture local rect calculation to update visibility. r=kvark
Andrew Osmond <aosmond@mozilla.com> - Wed, 10 Apr 2019 12:35:20 -0400 - rev 534456
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1540200 - Part 1. Move picture local rect calculation to update visibility. r=kvark We currently calculate a picture's local rect when we are doing the first picture traversal. It was composed of the union of the clipped local rects of its children. However the true local rect of a picture is the union of the snapped clipped local rects of its children. The snapping is done in device space, but we won't know the exact transform until we establish the raster roots, which is based on the picture's local rect. As such, we create an estimated local rect which is how we currently calculate the local rect. Then once the raster roots have been selected, we recalculate the local rect of the picture based on its children during update visibility. This patch should have not contain any functional changes. Differential Revision: https://phabricator.services.mozilla.com/D28881
dda3ed67b6bbe085c9b39dc56950e16683d17b7c: Bug 1548712 - Restructure and tidy up some code in prepare primitive pass. r=kvark,nical
Glenn Watson <github@intuitionlibrary.com> - Fri, 03 May 2019 20:26:32 +0000 - rev 534451
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1548712 - Restructure and tidy up some code in prepare primitive pass. r=kvark,nical Differential Revision: https://phabricator.services.mozilla.com/D29777
64764e9099c829a0fff5ea37d3b012c4835e1503: Bug 1548261 - Run wrench reftests in debug also. r=kvark
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 02 May 2019 14:18:21 +0000 - rev 534188
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1548261 - Run wrench reftests in debug also. r=kvark Differential Revision: https://phabricator.services.mozilla.com/D29663
ee9d68e93135dc540dfbee02c4f28c71cd0a127d: Bug 1548405 - Do all resource requests during visibility pass in WR. r=kvark
Glenn Watson <github@intuitionlibrary.com> - Thu, 02 May 2019 01:54:32 +0000 - rev 534110
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1548405 - Do all resource requests during visibility pass in WR. r=kvark This builds on earlier patches to move all remaining resource requests to occur during the visibility pass, and change the block on glyph rasterization to occur after the visibility pass. This allows batch generation to occur during the prepare_prims pass, which is useful for generating a batch set per-dirty-region, while only doing a single pass of the picture / primitive tree. Differential Revision: https://phabricator.services.mozilla.com/D29584
9ec9c4c0be3b7ab74b1ebaeb921ec62afa7691cd: Bug 1548202 - Request glyphs earlier during frame building. r=kvark
Glenn Watson <github@intuitionlibrary.com> - Wed, 01 May 2019 20:35:18 +0000 - rev 534043
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1548202 - Request glyphs earlier during frame building. r=kvark This patch changes glyph requests in the resource cache to occur as soon as a text run is found to be visible, rather than during the prepare_prims pass. This has two major benefits: - (with other patches) will allow some batching code to run during the prepare_prims pass. - allows glyph raster worker threads to start earlier in the frame, which may lead to less time blocking on the workers. Differential Revision: https://phabricator.services.mozilla.com/D29458
f08eb5f2a017499fc2d1b8704fc1c62ffdca5f35: Bug 1548171 - Allocate texture cache location for render task cache immediately. r=kvark
Glenn Watson <github@intuitionlibrary.com> - Wed, 01 May 2019 20:31:47 +0000 - rev 534042
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1548171 - Allocate texture cache location for render task cache immediately. r=kvark This is a first step towards allowing (some) batching work to be done during prepare_prims pass rather than render pass building. This is prep work related to output different batch lists for a given picture (e.g. a different batch list per dirty region), rather than replaying the same batch list. Differential Revision: https://phabricator.services.mozilla.com/D29445
d9c1fe157813922d86505e0c987908404fffc141: Bug 1548197 - Remove unused mut instances to fix warnings with rust nightly. r=kvark
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 01 May 2019 13:54:09 +0000 - rev 533995
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1548197 - Remove unused mut instances to fix warnings with rust nightly. r=kvark Differential Revision: https://phabricator.services.mozilla.com/D29492
f210be8c82a050a4ea525db1568e7c137d9038b1: Bug 1533735 - Refactor render task pass assignment in preparation for the render graph work. r=gw,kvark
Nicolas Silva <nsilva@mozilla.com> - Mon, 29 Apr 2019 17:53:00 +0200 - rev 533989
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1533735 - Refactor render task pass assignment in preparation for the render graph work. r=gw,kvark In addition, batch together render tasks for the cached render tasks. Differential Revision: https://phabricator.services.mozilla.com/D23839
0259eb7967f41e2476320a899efa85e59a3fe837: Bug 1540200 - Part 3. Reuse snapping offsets calculated on the CPU in the WebRender shaders. r=kvark
Andrew Osmond <aosmond@mozilla.com> - Fri, 12 Apr 2019 09:34:25 -0400 - rev 533984
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1540200 - Part 3. Reuse snapping offsets calculated on the CPU in the WebRender shaders. r=kvark Historically we calculated the snapping offsets in the GPU shaders. Because this information is always needed on the CPU side, we now just pass the values into the shader instead of recalculating again. This ensures we will use the same set of values consistently and makes it easier to adjust how we snap in the future. This patch should have no functional change on the output of WebRender itself. Differential Revision: https://phabricator.services.mozilla.com/D28883
67e8e1f2f00c55ff83a99c19f189322f6103821e: Bug 1540200 - Part 2. Calculate snapped primitive rect and offsets for WebRender on the CPU. r=kvark
Andrew Osmond <aosmond@mozilla.com> - Wed, 10 Apr 2019 14:20:34 -0400 - rev 533983
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1540200 - Part 2. Calculate snapped primitive rect and offsets for WebRender on the CPU. r=kvark We currently do most snapping on the GPU in the shader. However the picture's local rect needs to take into account the snapping done there, so we need to calculate this earlier in the pipeline. Instead of using the clipped primitive local rects to create the picture's own local rect, we now snap the child local rects first. If no snapping is required, there should be no functional change. If snapping is required, there should be fewer visual distortions caused by an inaccurate picture local rect. Differential Revision: https://phabricator.services.mozilla.com/D28882
fb1438de2bbf5b26b5d01d678e6559e9e90522b1: Bug 1540200 - Part 1. Move picture local rect calculation to update visibility. r=kvark
Andrew Osmond <aosmond@mozilla.com> - Wed, 10 Apr 2019 12:35:20 -0400 - rev 533982
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1540200 - Part 1. Move picture local rect calculation to update visibility. r=kvark We currently calculate a picture's local rect when we are doing the first picture traversal. It was composed of the union of the clipped local rects of its children. However the true local rect of a picture is the union of the snapped clipped local rects of its children. The snapping is done in device space, but we won't know the exact transform until we establish the raster roots, which is based on the picture's local rect. As such, we create an estimated local rect which is how we currently calculate the local rect. Then once the raster roots have been selected, we recalculate the local rect of the picture based on its children during update visibility. This patch should have not contain any functional changes. Differential Revision: https://phabricator.services.mozilla.com/D28881
122ff931d88359b92d695aa26a60839e244e66f0: Bug 1548092 - Fix improper alpha value in yaml reftest. r=kvark
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 30 Apr 2019 21:00:57 +0000 - rev 533903
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1548092 - Fix improper alpha value in yaml reftest. r=kvark Differential Revision: https://phabricator.services.mozilla.com/D29402
8489b0f35bd6b5ba7e272bdd6f4f305604b6b4b2: Bug 1547097 - Remove ReadPixelsFormat. r=kvark
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 30 Apr 2019 17:43:41 +0000 - rev 533879
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1547097 - Remove ReadPixelsFormat. r=kvark The Rgba8 enum value is redundant with the Standard(ImageFormat::RGBA8) value, this patch collapses the former into the latter. Which then makes the entire ReadPixelsFormat redundant, so we can get rid of it completely. Differential Revision: https://phabricator.services.mozilla.com/D29059
ac14ff604f811c88ff0cac70ce9858abd2539044: Bug 1547979 - Bump appveyor rust version to 1.34. r=kvark
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 30 Apr 2019 13:51:08 +0000 - rev 533812
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1547979 - Bump appveyor rust version to 1.34. r=kvark Differential Revision: https://phabricator.services.mozilla.com/D29351
e82b3333dfaaddf9c440d3ea3274393ff60d38e6: Bug 1547290 - Vendoring changes. r=kvark"
Nicolas Silva <nsilva@mozilla.com> - Mon, 29 Apr 2019 17:06:41 +0200 - rev 533776
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1547290 - Vendoring changes. r=kvark" Differential Revision: https://phabricator.services.mozilla.com/D29004
7fb543b7509fe6ea69d90a6762080379a07bfb7a: Bug 1547290 - Dump the render graph in SVG format in frame captures. r=kvark
Nicolas Silva <nsilva@mozilla.com> - Mon, 29 Apr 2019 16:11:12 +0200 - rev 533775
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1547290 - Dump the render graph in SVG format in frame captures. r=kvark Differential Revision: https://phabricator.services.mozilla.com/D29005
fa6be110a460610cfa89efcfeda08d9d57e4915b: Bug 1547632 - Remove unused local clip rect stored on WR picture primitives. r=emilio,kvark
Glenn Watson <github@intuitionlibrary.com> - Mon, 29 Apr 2019 16:16:11 +0000 - rev 533705
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1547632 - Remove unused local clip rect stored on WR picture primitives. r=emilio,kvark Differential Revision: https://phabricator.services.mozilla.com/D29148
d23cfcd838503bb1f9e3e3b646d2ae67d32ebcb1: Bug 1539629 - Fix WR capture for multi-document use r=kvark
Doug Thayer <dothayer@mozilla.com> - Mon, 15 Apr 2019 18:33:17 +0000 - rev 531607
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1539629 - Fix WR capture for multi-document use r=kvark We fail the assertion at the beginning of GpuCache::begin_frame right now because we run the extract_updates call after building frames for every document. This just moves the extract_updates work to be per-document. Differential Revision: https://phabricator.services.mozilla.com/D25251
df43e036b44d681f77e9d2419a0f9d6bb0d5159c: Bug 1527751 - properly apply transformed clips in brush shader. r=kvark
Alexis Beingessner <a.beingessner@gmail.com> - Fri, 05 Apr 2019 17:16:55 +0000 - rev 530118
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1527751 - properly apply transformed clips in brush shader. r=kvark Differential Revision: https://phabricator.services.mozilla.com/D26332
69736a7748c5299459dfb8121d8b2bf42a1ea410: Bug 1541059 - Add support for KHR_debug to WebRender for debug markers. r=kvark
Andrew Osmond <aosmond@mozilla.com> - Tue, 02 Apr 2019 10:43:13 -0400 - rev 529549
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1541059 - Add support for KHR_debug to WebRender for debug markers. r=kvark Today we already support EXT_debug_marker for debug markers in WebRender. This is useful to categorize GL API calls in tools such as APITrace and RenderDoc. However not all drivers indicate support for said extension, but instead support KHR_debug. This patch makes us support both methods, preferring KHR_debug. Differential Revision: https://phabricator.services.mozilla.com/D25787