searching for reviewer(jya)
ae6de9d94b5f9ed242dbb4418438fd8871a23851: Bug 1565838 - don't check timestamp of EOS samples. r=jya, a=RyanVM
John Lin <jolin@mozilla.com> - Wed, 14 Aug 2019 15:47:52 +0000 - rev 545169
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1565838 - don't check timestamp of EOS samples. r=jya, a=RyanVM Bug 1540748/D28167 checks the output sample timestamp against the time parsed by demuxer to determine the validness. However, unlike Android builtin MP3 decoder which sets EOS flag in the final valid output, the Samsung MP3 decoder always emit additional EOS sample with invalid timestamp. To address this, the timestamp check should be ignore for EOS samples. Differential Revision: https://phabricator.services.mozilla.com/D41872
6760861cd25c4fdbb6afc82f12f01d2422199260: Bug 1560611 - remember valid buffers only. r=jya a=RyanVM
John Lin <jolin@mozilla.com> - Thu, 18 Jul 2019 00:05:57 +0000 - rev 544655
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1560611 - remember valid buffers only. r=jya a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D38129
8d2b4af58b16f54bb4fe5728c38e8befc0d7ee8a: Bug 1565501 - use fallible memory allocation in MediaSpan. r=jya a=RyanVM
alwu <alwu@mozilla.com> - Thu, 18 Jul 2019 11:02:26 +0000 - rev 544654
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1565501 - use fallible memory allocation in MediaSpan. r=jya a=RyanVM Use fallible memory allocation in order to avoid the OOM issue. Differential Revision: https://phabricator.services.mozilla.com/D38400
83fbec55d5b97f5ebc864b0864339c880fa8894c: Bug 1561404 - Ensure thread safety r=jya a=RyanVM
Tarek Ziadé <tarek@mozilla.com> - Thu, 11 Jul 2019 12:15:24 +0000 - rev 544601
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1561404 - Ensure thread safety r=jya a=RyanVM Adds a lock in MediaCacheStream::SizeOfExcludingThis to prevent a race condition with MediaCache::NoteSeek Differential Revision: https://phabricator.services.mozilla.com/D36880
0b6b434c5303fa3683d013562be0f727c35cc22f: Bug 1563734 - always sync session ID from remote decoder. r=jya, a=RyanVM
John Lin <jolin@mozilla.com> - Thu, 11 Jul 2019 07:25:30 +0000 - rev 544503
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1563734 - always sync session ID from remote decoder. r=jya, a=RyanVM In bug 1552607/D36382, RemoteDataDecoder always increases session ID but CodecProxy only performs flush IPC when neccessary. This will cause the ID numbers out of sync and prevent remote decoder from receiving any more input. By reading the session ID in dequeued input samples, the numbers can always be in sync. Differential Revision: https://phabricator.services.mozilla.com/D37123
084252265e0c4bbf1b2211801b55278090f90d64: Bug 1562021 - part5 : add test 'test_texttrack_mode_change_during_loading.html'. r=jya
Alastor Wu <alwu@mozilla.com> - Wed, 03 Jul 2019 23:28:31 +0000 - rev 544307
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1562021 - part5 : add test 'test_texttrack_mode_change_during_loading.html'. r=jya In order to simulate the specific running order, we have to add a test event 'mozStartedLoadingTextTrack', which would be controlled under a pref. This test is used to ensure that we won't get `error` event when we change track's mode during loading. Differential Revision: https://phabricator.services.mozilla.com/D36410
1ff85088fbf482a4a518e74150b7bc6036552374: Bug 1562021 - part4 : wrap channel and listener clean-up to a function. r=jya
Alastor Wu <alwu@mozilla.com> - Wed, 03 Jul 2019 23:27:12 +0000 - rev 544306
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1562021 - part4 : wrap channel and listener clean-up to a function. r=jya There are several places doing channel or listenr clean up, all these places should do channel and listener clean-up together because they are being used as a pair. Differential Revision: https://phabricator.services.mozilla.com/D36409
4fa9eb527c78ca714064470b9b4a2ad63eed6689: Bug 1562021 - part3 : cancel old VTT listener when we start a new load. r=jya,baku
Alastor Wu <alwu@mozilla.com> - Wed, 03 Jul 2019 23:23:29 +0000 - rev 544305
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1562021 - part3 : cancel old VTT listener when we start a new load. r=jya,baku When we start a new load, all previous data fetching from the previous listener and all state changing applied to track element should be ignored. Therefore, we add a new method `Cancel()` which owner of the listener should call when we would like to discard current listener. Differential Revision: https://phabricator.services.mozilla.com/D36407
da1f4f3f0c5c27d5fe228b7e0c8c8ef05ca010ac: Bug 1562021 - part2 : using same log module as other VTT related files. r=jya
Alastor Wu <alwu@mozilla.com> - Wed, 03 Jul 2019 06:50:04 +0000 - rev 544304
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1562021 - part2 : using same log module as other VTT related files. r=jya This log module should be merged into a part of `WebVTT` log module because it's useless to check this log module independently. Differential Revision: https://phabricator.services.mozilla.com/D36406
602865e4e969900b82d0fc740fabd9ef34c01d2f: Bug 1562021 - part1 : modify debug log for WebVTTListener. r=jya
Alastor Wu <alwu@mozilla.com> - Wed, 03 Jul 2019 23:07:43 +0000 - rev 544303
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1562021 - part1 : modify debug log for WebVTTListener. r=jya Refactor these log by using the `WebVTT` log module and adding address info in the log. Differential Revision: https://phabricator.services.mozilla.com/D36405
e1f73a7e8dc61e41f2c4045a20ef2be3c84c295d: Bug 1559568 - Remove strong refs from OutputStreamManager. r=jya
Andreas Pehrson <apehrson@mozilla.com> - Thu, 04 Jul 2019 11:01:45 +0000 - rev 544075
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1559568 - Remove strong refs from OutputStreamManager. r=jya Differential Revision: https://phabricator.services.mozilla.com/D36570
6e2e6b0b0dc579737c3fff796c1bb4de5ee410d8: Bug 1559568 - Make DOMMediaStream support WeakPtr. r=jya
Andreas Pehrson <apehrson@mozilla.com> - Wed, 03 Jul 2019 09:09:40 +0000 - rev 544074
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1559568 - Make DOMMediaStream support WeakPtr. r=jya As required by the next patch to avoid strong refs to DOMMediaStream in OutputStreamManager. Differential Revision: https://phabricator.services.mozilla.com/D36569
f2d9515c38434ac601ed20dd4c5dfbc2c7aff26d: Bug 1552607 - p2: check sample session ID when processing buffers. r=jya
John Lin <jolin@mozilla.com> - Tue, 02 Jul 2019 18:12:44 +0000 - rev 543834
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1552607 - p2: check sample session ID when processing buffers. r=jya Because IPC call runs asynchronously in both remote decoder process and content process, ProcessOutput() for buffers prior to Flush() could be scheduled to run after the flush promise is resolved, and Codec.queueInput() could be preempted and processes prior sample after flush. To help check the validness of buffers, a session ID increased by flush is added to both RemoteDataDecoder and remote codec service and will be passed through IPC. If the passed ID doesn't agree with current session ID, it means the buffer doesn't belong to current session and should be discard. Differential Revision: https://phabricator.services.mozilla.com/D36382
f6b0141f7b1fe8bef141302f0556725ec6ba5695: Bug 1552607 - p1: filter out invalid input buffers. r=jya
John Lin <jolin@mozilla.com> - Tue, 02 Jul 2019 18:12:35 +0000 - rev 543833
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1552607 - p1: filter out invalid input buffers. r=jya Differential Revision: https://phabricator.services.mozilla.com/D36381
d70d3b500a6db99776e3706a93e54aff6137091a: Bug 1562353 - add CORS test. r=jya
Alastor Wu <alwu@mozilla.com> - Mon, 01 Jul 2019 23:54:49 +0000 - rev 543691
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1562353 - add CORS test. r=jya This test is used to ensure that we shouldn't load CORS resource if server doesn't respond with correct CORS header. In this situation, loading should be expected to fail. Differential Revision: https://phabricator.services.mozilla.com/D36513
53a39e4024511c051187db2a6c501c56c23a77ea: Bug 1552607 - p2: check sample session ID when processing buffers. r=jya
John Lin <jolin@mozilla.com> - Mon, 01 Jul 2019 23:42:59 +0000 - rev 543689
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1552607 - p2: check sample session ID when processing buffers. r=jya Because IPC call runs asynchronously in both remote decoder process and content process, ProcessOutput() for buffers prior to Flush() could be scheduled to run after the flush promise is resolved, and Codec.queueInput() could be preempted and processes prior sample after flush. To help check the validness of buffers, a session ID increased by flush is added to both RemoteDataDecoder and remote codec service and will be passed through IPC. If the passed ID doesn't agree with current session ID, it means the buffer doesn't belong to current session and should be discard. Differential Revision: https://phabricator.services.mozilla.com/D36382
6385b8616d54c62539ec4b4bb9325e9d4abfe721: Bug 1552607 - p1: filter out invalid input buffers. r=jya
John Lin <jolin@mozilla.com> - Mon, 01 Jul 2019 23:42:50 +0000 - rev 543688
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1552607 - p1: filter out invalid input buffers. r=jya Differential Revision: https://phabricator.services.mozilla.com/D36381
7ad8396f67cfc38165755438db5cbb78c1e5e5d3: Bug 1562395 - Don't try to create sync handles in the RDD process. r=jya
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 01 Jul 2019 07:58:26 +0000 - rev 543598
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1562395 - Don't try to create sync handles in the RDD process. r=jya Differential Revision: https://phabricator.services.mozilla.com/D36433
29d310d368efef7ae997f69dc979e7fcb6f6bfa9: Bug 1561178 - Initialize gfxVars in the RDD process. r=jya
Matt Woodrow <mwoodrow@mozilla.com> - Fri, 28 Jun 2019 07:08:43 +0000 - rev 543330
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1561178 - Initialize gfxVars in the RDD process. r=jya Differential Revision: https://phabricator.services.mozilla.com/D36001
ff918c1013b8d543c34fa54b7f56eaf2baa41112: Bug 1561178 - Shutdown video bridge for all processes that might be using it. r=jya
Matt Woodrow <mwoodrow@mozilla.com> - Fri, 28 Jun 2019 06:33:00 +0000 - rev 543329
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1561178 - Shutdown video bridge for all processes that might be using it. r=jya Differential Revision: https://phabricator.services.mozilla.com/D36000
a4c9b86885b79378a53856334f68f4d2e10e1976: Bug 1561178 - Create a VideoBridge connection from the RDD process to the parent process. r=jya
Matt Woodrow <mwoodrow@mozilla.com> - Fri, 28 Jun 2019 06:32:43 +0000 - rev 543328
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1561178 - Create a VideoBridge connection from the RDD process to the parent process. r=jya Differential Revision: https://phabricator.services.mozilla.com/D35969
5a60cd493115214a5a3cf1cd0037e25ae6645e2c: Bug 1561178 - Use Endpoints for VideoBridge construction, and support the possibility that there are multiple at the same time. r=jya
Matt Woodrow <mwoodrow@mozilla.com> - Fri, 28 Jun 2019 07:00:41 +0000 - rev 543327
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1561178 - Use Endpoints for VideoBridge construction, and support the possibility that there are multiple at the same time. r=jya In the future we're going to want VideoBridge connections from the RDD process into both the parent process and the GPU process. This does the preparation work for unifying the way we create VideoBridges (using Endpoints, required for cross-process connections), and detects which one to use based on where the video will be composited. Differential Revision: https://phabricator.services.mozilla.com/D35968
c9f9bba02acf40a824a92fd9430cc5e10edcc485: Bug 1561178 - Make passing a TextureFactoryIdentifier optional, and pass one whenever we can. r=jya
Matt Woodrow <mwoodrow@mozilla.com> - Fri, 28 Jun 2019 06:32:16 +0000 - rev 543326
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1561178 - Make passing a TextureFactoryIdentifier optional, and pass one whenever we can. r=jya Differential Revision: https://phabricator.services.mozilla.com/D35965
c633a515314d0d1451322d4c6bfda0031cadb459: Bug 1561178 - Combine the two video RecvOutput methods and switch based on the descriptor type. r=jya
Matt Woodrow <mwoodrow@mozilla.com> - Fri, 28 Jun 2019 06:31:59 +0000 - rev 543325
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1561178 - Combine the two video RecvOutput methods and switch based on the descriptor type. r=jya Differential Revision: https://phabricator.services.mozilla.com/D35964
8ed70f1397e9a55d43e643aff00c88d50e1e3753: Bug 1561929 - Fix slider.snapMultiplier pref values. r=jya
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 28 Jun 2019 02:27:45 +0000 - rev 543311
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1561929 - Fix slider.snapMultiplier pref values. r=jya Differential Revision: https://phabricator.services.mozilla.com/D36268
2150f683f8a80e76c1da36440249f3cc423cccbe: Bug 1561178 - Initialize gfxVars in the RDD process. r=jya
Matt Woodrow <mwoodrow@mozilla.com> - Thu, 27 Jun 2019 01:29:59 +0000 - rev 543115
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1561178 - Initialize gfxVars in the RDD process. r=jya Differential Revision: https://phabricator.services.mozilla.com/D36001
059c79722bcb4b1c6872418ebaf18e977e220b17: Bug 1561178 - Shutdown video bridge for all processes that might be using it. r=jya
Matt Woodrow <mwoodrow@mozilla.com> - Thu, 27 Jun 2019 01:29:45 +0000 - rev 543114
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1561178 - Shutdown video bridge for all processes that might be using it. r=jya Differential Revision: https://phabricator.services.mozilla.com/D36000
6f206fecaa5668f35878b29c715e39cba9ade276: Bug 1561178 - Create a VideoBridge connection from the RDD process to the parent process. r=jya
Matt Woodrow <mwoodrow@mozilla.com> - Thu, 27 Jun 2019 01:29:25 +0000 - rev 543113
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1561178 - Create a VideoBridge connection from the RDD process to the parent process. r=jya Differential Revision: https://phabricator.services.mozilla.com/D35969
d449e8c96753f50a34d3aaf260a00390f729954c: Bug 1561178 - Use Endpoints for VideoBridge construction, and support the possibility that there are multiple at the same time. r=jya
Matt Woodrow <mwoodrow@mozilla.com> - Thu, 27 Jun 2019 01:29:15 +0000 - rev 543112
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1561178 - Use Endpoints for VideoBridge construction, and support the possibility that there are multiple at the same time. r=jya In the future we're going to want VideoBridge connections from the RDD process into both the parent process and the GPU process. This does the preparation work for unifying the way we create VideoBridges (using Endpoints, required for cross-process connections), and detects which one to use based on where the video will be composited. Differential Revision: https://phabricator.services.mozilla.com/D35968
557f55a90c8aa215b7046fadf7a17436baa93713: Bug 1561178 - Make passing a TextureFactoryIdentifier optional, and pass one whenever we can. r=jya
Matt Woodrow <mwoodrow@mozilla.com> - Thu, 27 Jun 2019 01:28:56 +0000 - rev 543111
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1561178 - Make passing a TextureFactoryIdentifier optional, and pass one whenever we can. r=jya Differential Revision: https://phabricator.services.mozilla.com/D35965
e1521d8fbe9007e783ea1c094b0d3e5574d0fbf1: Bug 1561178 - Combine the two video RecvOutput methods and switch based on the descriptor type. r=jya
Matt Woodrow <mwoodrow@mozilla.com> - Thu, 27 Jun 2019 01:28:47 +0000 - rev 543110
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1561178 - Combine the two video RecvOutput methods and switch based on the descriptor type. r=jya Differential Revision: https://phabricator.services.mozilla.com/D35964
50ea5ea76349073f63750e02abe2ee102019cbe8: Bug 1484720 - Part 3: Remove some media tests' obsolete checks for B2G. r=jya
Chris Peterson <cpeterson@mozilla.com> - Wed, 05 Jun 2019 23:22:16 -0700 - rev 541854
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1484720 - Part 3: Remove some media tests' obsolete checks for B2G. r=jya Differential Revision: https://phabricator.services.mozilla.com/D34994
b2a4bff3a6a0e76eb51fcd035f1093186f00176f: Bug 1484720 - Part 2: Remove always-false isSlowPlatform() test function. r=jya
Chris Peterson <cpeterson@mozilla.com> - Sun, 12 May 2019 23:34:21 -0700 - rev 541853
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1484720 - Part 2: Remove always-false isSlowPlatform() test function. r=jya isSlowPlatform() is always false because we no longer support Android 2.3 or B2G. Also remove unused functions isWindows32() and isAndroid(). They were added in bug 1485875, but the callers were later removed in Windows bug 1475564 and Android bug 1368843. Differential Revision: https://phabricator.services.mozilla.com/D33424
cc9bef9ad09c3c480484c002f756a1bf563415db: Bug 1484720 - Part 1: Check Services.appinfo.is64Bit instead of UA string when disabling AV1-in-MP4 test. r=jya
Chris Peterson <cpeterson@mozilla.com> - Sat, 11 May 2019 23:04:01 -0700 - rev 541852
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1484720 - Part 1: Check Services.appinfo.is64Bit instead of UA string when disabling AV1-in-MP4 test. r=jya I hope to remove the CPU architecture ("x64") from the UA string in bug 1556223. Tests that need to check for Win32 vs Win64 will need to check Services.appinfo.is64Bit instead of sniffing the UA string. AV1-in-MP4 support was disabled on Win32 in bug 1417050 and re-enabled in bug 1475564. This Win32 check should have been removed at that time to re-enable this AV1-in-MP4 test on Win32. However, we can't re-enable Win32 support at this time because the RDM fails with E_OUTOFMEMORY on 32-bit Win7. Differential Revision: https://phabricator.services.mozilla.com/D33423
41ab55fee001f7fa381a77d9afc8395786417e1a: Bug 1498742 - Part 2 - Start the GMP sandbox earlier during process startup r=jya,cpearce
Haik Aftandilian <haftandilian@mozilla.com> - Fri, 14 Jun 2019 22:55:27 +0000 - rev 541813
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1498742 - Part 2 - Start the GMP sandbox earlier during process startup r=jya,cpearce Change the Mac GMP process launch to include sandboxing params on the command line to allow the sandbox to be started earlier during GMP process launch. Content, extension, and RDD processes have already been changed to start the sandbox earlier. Update GMPProcessParent to override GeckoChildProcessHost methods used to construct sandboxing parameters. Pass the plugin path as a sandbox parameter so that the sandbox rules can whitelist the plugin directory which is now read after the sandbox is enabled in the plugin process. On development builds, pass "testingReadPath" params so directories needed during automated tests can be whitelisted. Update Mac sandboxing code to detect GMP sandbox params on the command line and enable the sandbox with additional arguments needed for early sandbox start. Allow reverting to the old implementation by setting security.sandbox.gmp.mac.earlyinit to false. Differential Revision: https://phabricator.services.mozilla.com/D34085
f6da94d9035047b44f1521bfd2d37960263a2f36: Bug 1498742 - Part 2 - Start the GMP sandbox earlier during process startup r=jya,cpearce
Haik Aftandilian <haftandilian@mozilla.com> - Fri, 14 Jun 2019 20:12:01 +0000 - rev 541762
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1498742 - Part 2 - Start the GMP sandbox earlier during process startup r=jya,cpearce Change the Mac GMP process launch to include sandboxing params on the command line to allow the sandbox to be started earlier during GMP process launch. Content, extension, and RDD processes have already been changed to start the sandbox earlier. Update GMPProcessParent to override GeckoChildProcessHost methods used to construct sandboxing parameters. Pass the plugin path as a sandbox parameter so that the sandbox rules can whitelist the plugin directory which is now read after the sandbox is enabled in the plugin process. On development builds, pass "testingReadPath" params so directories needed during automated tests can be whitelisted. Update Mac sandboxing code to detect GMP sandbox params on the command line and enable the sandbox with additional arguments needed for early sandbox start. Allow reverting to the old implementation by setting security.sandbox.gmp.mac.earlyinit to false. Differential Revision: https://phabricator.services.mozilla.com/D34085
8c4a3e9cc5ed2e749cffed2eebee263766305b3a: Bug 1464012 - part2 : add test 'test_texttrack_cors_preload_none.html'. r=jya
Alastor Wu <alwu@mozilla.com> - Fri, 14 Jun 2019 07:53:51 +0000 - rev 541733
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1464012 - part2 : add test 'test_texttrack_cors_preload_none.html'. r=jya Differential Revision: https://phabricator.services.mozilla.com/D34756
105df24836a9c90dcfc85b3683ab8d06f2986b3a: Bug 1464012 - part1 : directly check media element's crossorigin attribute. r=jya
Alastor Wu <alwu@mozilla.com> - Fri, 14 Jun 2019 17:56:33 +0000 - rev 541732
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1464012 - part1 : directly check media element's crossorigin attribute. r=jya As `GetCORSMode()` would only be valid after media element starts loading, so we would fail to get the CORS mode if media's preload is `none`. Therefore, according to the spec [1], we should directly check parent media element's `crossorigin` attribute in order to decide the `corsAttributeState`. [1] https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:attr-media-crossorigin Differential Revision: https://phabricator.services.mozilla.com/D34755
f53080eb8868a5031861a0182433701dae21f1dd: Bug 1558364 - Convert TrackBuffersManager::mPendingInput into a MediaSpan. r=jya
Chris Pearce <cpearce@mozilla.com> - Fri, 14 Jun 2019 02:10:24 +0000 - rev 541653
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1558364 - Convert TrackBuffersManager::mPendingInput into a MediaSpan. r=jya This allows us to avoid a (probably small) copy when we stash the pending input. Differential Revision: https://phabricator.services.mozilla.com/D34662
f6df4eb84932ddaccae4e53d4897234e0153913e: Bug 1558364 - Add MediaSpan and use it for TrackBuffersManager::mInputBuffer. r=jya
Chris Pearce <cpearce@mozilla.com> - Fri, 14 Jun 2019 02:10:09 +0000 - rev 541652
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1558364 - Add MediaSpan and use it for TrackBuffersManager::mInputBuffer. r=jya As seen in this profile of a Twitch replay: https://perfht.ml/2K9Ydb3 we can often end up spending time in TrackBuffersManager::CodedFrameProcessing() shaving off bytes from the front off TrackBuffersManager::mInputBuffer. This requires all the remaining bytes to be memmove'd down to the start of this array. Sometimes we have close to 1MB in that buffer, and when we're just trying to consume a few hundred bytes, that becomes high overhead. So intead of using this "slice off, shuffle down" approach change TrackBuffersManager::mInputBuffer to be a new type MediaSpan, which maintains a RefPtr to a MediaByteBuffer and a span defining the subregion of the buffer we care about. This means the RemoveElementsAt(0,N) operation becomes basically free, and we can eliminate a few other copies we were doing as well. Differential Revision: https://phabricator.services.mozilla.com/D34661
098ce3586133fe57aa1d53fe4bdf541b26243563: Bug 1558364 - Convert TrackBuffersManager::mPendingInput into a MediaSpan. r=jya
Chris Pearce <cpearce@mozilla.com> - Fri, 14 Jun 2019 00:31:06 +0000 - rev 541632
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1558364 - Convert TrackBuffersManager::mPendingInput into a MediaSpan. r=jya This allows us to avoid a (probably small) copy when we stash the pending input. Differential Revision: https://phabricator.services.mozilla.com/D34662
2e64d8db2b4b630e990903a57bc75c0bfbaca237: Bug 1558364 - Add MediaSpan and use it for TrackBuffersManager::mInputBuffer. r=jya
Chris Pearce <cpearce@mozilla.com> - Fri, 14 Jun 2019 00:31:02 +0000 - rev 541631
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1558364 - Add MediaSpan and use it for TrackBuffersManager::mInputBuffer. r=jya As seen in this profile of a Twitch replay: https://perfht.ml/2K9Ydb3 we can often end up spending time in TrackBuffersManager::CodedFrameProcessing() shaving off bytes from the front off TrackBuffersManager::mInputBuffer. This requires all the remaining bytes to be memmove'd down to the start of this array. Sometimes we have close to 1MB in that buffer, and when we're just trying to consume a few hundred bytes, that becomes high overhead. So intead of using this "slice off, shuffle down" approach change TrackBuffersManager::mInputBuffer to be a new type MediaSpan, which maintains a RefPtr to a MediaByteBuffer and a span defining the subregion of the buffer we care about. This means the RemoveElementsAt(0,N) operation becomes basically free, and we can eliminate a few other copies we were doing as well. Differential Revision: https://phabricator.services.mozilla.com/D34661
b8809dc8740c50c1d7a7edc73f1c4ee15aa6237f: Bug 1555197 - part5 : enable wpt 'track-webvtt-two-cue-layout-after-first-end.html'. r=jya
alwu <alwu@mozilla.com> - Thu, 30 May 2019 07:42:51 +0000 - rev 541567
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1555197 - part5 : enable wpt 'track-webvtt-two-cue-layout-after-first-end.html'. r=jya Differential Revision: https://phabricator.services.mozilla.com/D32938
323c42c5c3777286dd99f11db2d1c2e852a07690: Bug 1555197 - part4 : modify wpt 'track-webvtt-two-cue-layout-after-first-end.html' and 'track-webvtt-two-cue-layout-after-first-end-ref.html'. r=jya
alwu <alwu@mozilla.com> - Fri, 07 Jun 2019 01:05:39 +0000 - rev 541566
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1555197 - part4 : modify wpt 'track-webvtt-two-cue-layout-after-first-end.html' and 'track-webvtt-two-cue-layout-after-first-end-ref.html'. r=jya For `track-webvtt-two-cue-layout-after-first-end.html` (1) modify cue1's start time According to the text track cue order [1], "cues must be sorted by their start time, earliest first; then, any cues with the same start time must be sorted by their end time, latest first". This order also decides which cue we would display first. As this test would like show `cue1` at top and show another cue at bottom, we should modify cue1's `startTime` in order to put it before cue [0:3] in the cue list. [1] https://html.spec.whatwg.org/multipage/media.html#text-track-cue-order (2) listen for cue1's `exit` As this cue would like to stop when the first cue ends, it should listen `exit` event. --- For `track-webvtt-two-cue-layout-after-first-end-ref.html`, we should call `video.play()` in order to clear `show-poster` flag [2] and run `TimeMarchesOn` to show the cue. If we didn't call it to reset the flag, we won't display any cue. [2] https://html.spec.whatwg.org/multipage/media.html#playing-the-media-resource:show-poster-flag Differential Revision: https://phabricator.services.mozilla.com/D32937
4a93da5a440d282375d9c0db82c903f0dad45035: Bug 1555197 - part3 : modify log. r=jya
alwu <alwu@mozilla.com> - Thu, 30 May 2019 07:39:40 +0000 - rev 541565
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1555197 - part3 : modify log. r=jya Add and modify some log content in order to help debugging. Differential Revision: https://phabricator.services.mozilla.com/D32936
6729dc168afd4186db7cfb4a3bb5810d8fc6a826: Bug 1498742 - Part 2 - Start the GMP sandbox earlier during process startup r=jya,cpearce
Haik Aftandilian <haftandilian@mozilla.com> - Thu, 13 Jun 2019 06:32:37 +0000 - rev 541467
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1498742 - Part 2 - Start the GMP sandbox earlier during process startup r=jya,cpearce Change the Mac GMP process launch to include sandboxing params on the command line to allow the sandbox to be started earlier during GMP process launch. Content, extension, and RDD processes have already been changed to start the sandbox earlier. Update GMPProcessParent to override GeckoChildProcessHost methods used to construct sandboxing parameters. Pass the plugin path as a sandbox parameter so that the sandbox rules can whitelist the plugin directory which is now read after the sandbox is enabled in the plugin process. On development builds, pass "testingReadPath" params so directories needed during automated tests can be whitelisted. Update Mac sandboxing code to detect GMP sandbox params on the command line and enable the sandbox with additional arguments needed for early sandbox start. Allow reverting to the old implementation by setting security.sandbox.gmp.mac.earlyinit to false. Differential Revision: https://phabricator.services.mozilla.com/D34085
5f9d32e26c712ca9494a2bcf3b77778a2e4e8119: Bug 1498742 - Part 2 - Start the GMP sandbox earlier during process startup r=jya,cpearce
Haik Aftandilian <haftandilian@mozilla.com> - Wed, 12 Jun 2019 23:41:53 +0000 - rev 541419
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1498742 - Part 2 - Start the GMP sandbox earlier during process startup r=jya,cpearce Change the Mac GMP process launch to include sandboxing params on the command line to allow the sandbox to be started earlier during GMP process launch. Content, extension, and RDD processes have already been changed to start the sandbox earlier. Update GMPProcessParent to override GeckoChildProcessHost methods used to construct sandboxing parameters. Pass the plugin path as a sandbox parameter so that the sandbox rules can whitelist the plugin directory which is now read after the sandbox is enabled in the plugin process. On development builds, pass "testingReadPath" params so directories needed during automated tests can be whitelisted. Update Mac sandboxing code to detect GMP sandbox params on the command line and enable the sandbox with additional arguments needed for early sandbox start. Allow reverting to the old implementation by setting security.sandbox.gmp.mac.earlyinit to false. Differential Revision: https://phabricator.services.mozilla.com/D34085
e0a7360fcc7c68076ff993de5cb968854e93f1be: Bug 1554699 - Don't fire "timeupdate" in PlayInternal as it's against spec, v2. r=jya
Andreas Pehrson <apehrson@mozilla.com> - Tue, 11 Jun 2019 11:49:35 +0000 - rev 541328
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1554699 - Don't fire "timeupdate" in PlayInternal as it's against spec, v2. r=jya This FireTimeUpdate(false) dates back to bug 611994. Perhaps it was spec compliant back in the day, but it surely isn't now. Differential Revision: https://phabricator.services.mozilla.com/D33651
7a6d1ef048099da40346447f987474efb0234324: Bug 1554699 - Don't fire "timeupdate" in PlayInternal as it's against spec. r=jya,alwu
Andreas Pehrson <apehrson@mozilla.com> - Tue, 11 Jun 2019 11:49:26 +0000 - rev 541327
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1554699 - Don't fire "timeupdate" in PlayInternal as it's against spec. r=jya,alwu Bug 1279865 introduced this under the premise of "Run TimeMarchesOn() at the beginning of play.", but it did a bit too much. This makes us spec compliant for this particular case again. Differential Revision: https://phabricator.services.mozilla.com/D33650
4be6e0cf9a6c9764db494c9c6417597f9d91eee2: Bug 1553540 - switch disk information collection in system info off the main thread, r=aklotz,chutten,jya,arai
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 12 Jun 2019 15:56:59 +0000 - rev 541319
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1553540 - switch disk information collection in system info off the main thread, r=aklotz,chutten,jya,arai Differential Revision: https://phabricator.services.mozilla.com/D34417