searching for reviewer(jfkthame)
562e910531dbb424ab2fe7a1a98a38659a695ffe: Bug 1677301 - try to catch exceptions while reading font file data in ScaledFontDWrite. r=jfkthame
Lee Salzman <lsalzman@mozilla.com> - Wed, 09 Dec 2020 10:41:34 +0000 - rev 630619
Push 2499 by ffxbld-merge at Mon, 18 Jan 2021 11:17:28 +0000
Bug 1677301 - try to catch exceptions while reading font file data in ScaledFontDWrite. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D99179
ddc258aa88d4927e8e253313824eeafb228e18a1: Bug 1679931 Part 4 - Remove workaround for flex item fragmentation reftests for Android. r=layout-reviewers,emilio,jfkthame
Ting-Yu Lin <tlin@mozilla.com> - Mon, 07 Dec 2020 23:30:59 +0000 - rev 630349
Push 2499 by ffxbld-merge at Mon, 18 Jan 2021 11:17:28 +0000
Bug 1679931 Part 4 - Remove workaround for flex item fragmentation reftests for Android. r=layout-reviewers,emilio,jfkthame Differential Revision: https://phabricator.services.mozilla.com/D98518
a6d31e726b0b47cc68e013a43b0b64cf37eac599: Bug 1679931 Part 3 - Recompute overflow container children's overflow area after moving them in vertical-rl writing-mode. r=layout-reviewers,jfkthame
Ting-Yu Lin <tlin@mozilla.com> - Mon, 07 Dec 2020 23:30:51 +0000 - rev 630348
Push 2499 by ffxbld-merge at Mon, 18 Jan 2021 11:17:28 +0000
Bug 1679931 Part 3 - Recompute overflow container children's overflow area after moving them in vertical-rl writing-mode. r=layout-reviewers,jfkthame Differential Revision: https://phabricator.services.mozilla.com/D98517
f153b932ed5e8ae11ae758ec2caa8ecbba30b12c: Bug 1679931 Part 2 - Recompute float children's overflow area after moving them in vertical-rl writing-mode. r=layout-reviewers,jfkthame
Ting-Yu Lin <tlin@mozilla.com> - Mon, 07 Dec 2020 23:31:37 +0000 - rev 630347
Push 2499 by ffxbld-merge at Mon, 18 Jan 2021 11:17:28 +0000
Bug 1679931 Part 2 - Recompute float children's overflow area after moving them in vertical-rl writing-mode. r=layout-reviewers,jfkthame Differential Revision: https://phabricator.services.mozilla.com/D98516
0d7ac1474b5541ce7f22a398f64cc44619deb7a1: Bug 1680519 - Update OTS to 8.1.1. r=jfkthame
Ryan VanderMeulen <ryanvm@gmail.com> - Mon, 07 Dec 2020 19:03:30 +0000 - rev 630323
Push 2499 by ffxbld-merge at Mon, 18 Jan 2021 11:17:28 +0000
Bug 1680519 - Update OTS to 8.1.1. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D98611
30bf6b9a836edb83e510075865a9cb6a77b62d85: Bug 1679706 - Communicate to the front-end whether there are no visible pages at all. r=jfkthame
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 02 Dec 2020 21:48:03 +0000 - rev 629722
Push 2499 by ffxbld-merge at Mon, 18 Jan 2021 11:17:28 +0000
Bug 1679706 - Communicate to the front-end whether there are no visible pages at all. r=jfkthame This will allow them to react however they want to empty page ranges as a result of another setting change. Differential Revision: https://phabricator.services.mozilla.com/D98183
0bd6c96f1280bed3e39a0b9fa2197f2f9333b293: Bug 1679706 - Cleanup a bit the page-sequence-using methods in nsPrintJob. r=jfkthame
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 02 Dec 2020 17:17:17 +0000 - rev 629721
Push 2499 by ffxbld-merge at Mon, 18 Jan 2021 11:17:28 +0000
Bug 1679706 - Cleanup a bit the page-sequence-using methods in nsPrintJob. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D98182
dff86c7857d7666baa7ef59d9c0e516d9e075e22: Bug 1678997 - [css-break] Only scrollable overflow should create new pages, not ink overflow. r=layout-reviewers,jfkthame
Mats Palmgren <mats@mozilla.com> - Mon, 30 Nov 2020 15:58:19 +0000 - rev 629299
Push 2499 by ffxbld-merge at Mon, 18 Jan 2021 11:17:28 +0000
Bug 1678997 - [css-break] Only scrollable overflow should create new pages, not ink overflow. r=layout-reviewers,jfkthame Per https://github.com/w3c/csswg-drafts/issues/4099 Differential Revision: https://phabricator.services.mozilla.com/D97875
ef0dabb6cb6603bc3816faea6a414f97e78da4d2: Bug 1669333 - Make the fragmentation fallback code use logical coordinates. r=jfkthame
Mats Palmgren <mats@mozilla.com> - Mon, 30 Nov 2020 15:58:19 +0000 - rev 629298
Push 2499 by ffxbld-merge at Mon, 18 Jan 2021 11:17:28 +0000
Bug 1669333 - Make the fragmentation fallback code use logical coordinates. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D97864
85b08b0e3773d694395e31e40cc7d6b4e901bf0c: Bug 1678962 - Add Hiragino Sans to font.name-list.sans-serif.ja. r=jfkthame
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Tue, 24 Nov 2020 10:25:05 +0000 - rev 629033
Push 2499 by ffxbld-merge at Mon, 18 Jan 2021 11:17:28 +0000
Bug 1678962 - Add Hiragino Sans to font.name-list.sans-serif.ja. r=jfkthame From macOS Catalina, Hiragino Kaku Gothic ProN and etc aren't instaleld with clean install. And default sans-serif font for Japanese is Hiragino Sans. Differential Revision: https://phabricator.services.mozilla.com/D97900
88fbeefb283822807020b1ef65d9653615cba6ce: Bug 1677388: Pass a copy of our cached default DEVMODE into DeviceCapabilitiesW calls. r=jfkthame
Bob Owen <bobowencode@gmail.com> - Sat, 21 Nov 2020 09:53:23 +0000 - rev 628851
Push 2499 by ffxbld-merge at Mon, 18 Jan 2021 11:17:28 +0000
Bug 1677388: Pass a copy of our cached default DEVMODE into DeviceCapabilitiesW calls. r=jfkthame This is to prevent threading issues that some drivers seem to have when they access their own default DEVMODE internally. Differential Revision: https://phabricator.services.mozilla.com/D97789
035ba753b5ff64eda9444dac4e100fe14ffbbb1f: Bug 1678427: Use a more precise label for native-font-resource-mac fonts. r=jfkthame
Brad Werth <bwerth@mozilla.com> - Thu, 19 Nov 2020 20:27:09 +0000 - rev 628678
Push 2499 by ffxbld-merge at Mon, 18 Jan 2021 11:17:28 +0000
Bug 1678427: Use a more precise label for native-font-resource-mac fonts. r=jfkthame The listed fonts are individual faces, not font families. Since the face name comes from a PostScript name, we'll use the label "psname". Differential Revision: https://phabricator.services.mozilla.com/D97664
33fb1c91831cf44f309ed2791dd443d709d0c9f5: Bug 1674683 - Add SamsungKorean_v2.0 instead of SEC CJK KR. r=jfkthame,saschanaz
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Wed, 18 Nov 2020 12:51:46 +0000 - rev 628547
Push 2499 by ffxbld-merge at Mon, 18 Jan 2021 11:17:28 +0000
Bug 1674683 - Add SamsungKorean_v2.0 instead of SEC CJK KR. r=jfkthame,saschanaz Although I add SEC CJK KR to font list for Samsung devices, it is better to use `SamsungKorean_v2.0` rather than it according to user feedback. Korean default font of Samsung device in `/etc/fonts.xml` is `SamsungKorean_v2.0`. Monospace font for Korean keeps SEC Mono CJK KR since no monospace font settings in Samsung devices. Differential Revision: https://phabricator.services.mozilla.com/D97252
2d259c4e443ff5f2a43a84adf86b2a7641507810: Bug 1677388: Pass a copy of our cached default DEVMODE into DeviceCapabilitiesW calls. r=jfkthame, a=jcristau
Bob Owen <bobowencode@gmail.com> - Sat, 21 Nov 2020 09:53:23 +0000 - rev 627632
Push 2472 by ffxbld-merge at Mon, 07 Dec 2020 19:30:50 +0000
Bug 1677388: Pass a copy of our cached default DEVMODE into DeviceCapabilitiesW calls. r=jfkthame, a=jcristau This is to prevent threading issues that some drivers seem to have when they access their own default DEVMODE internally. Differential Revision: https://phabricator.services.mozilla.com/D97789
48de69b39f4d2e489ec8c9ff377c2f8a1e08f2dc: Bug 1677073 - Update mapped_hyph. r=jfkthame
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 13 Nov 2020 12:23:04 +0000 - rev 627261
Push 2472 by ffxbld-merge at Mon, 07 Dec 2020 19:30:50 +0000
Bug 1677073 - Update mapped_hyph. r=jfkthame This removes a dependency on env_logger 0.7. Differential Revision: https://phabricator.services.mozilla.com/D96985
a7ba6638fa20a4654dcdfa16a3d544b534a4e51b: Bug 1667493 - Locale service shouldn't shutdown during normal shutting down phase. r=jfkthame
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Wed, 11 Nov 2020 03:33:04 +0000 - rev 626825
Push 2472 by ffxbld-merge at Mon, 07 Dec 2020 19:30:50 +0000
Bug 1667493 - Locale service shouldn't shutdown during normal shutting down phase. r=jfkthame Although ICUUtils uses LocaleService, LocaleService will be shut down before shut down observer. DOM might use Locale Service by UnbindFromTree. So LocaleService should be shut down by ShutdownPhase::ShutdownPostLastCycleCollection. Differential Revision: https://phabricator.services.mozilla.com/D94944
4bdd82a535bc0bb34e3494a5f07a597cc609c94f: Bug 1675906 - Add more crashes when we don't find a Factory. r=jfkthame
Jeff Muizelaar <jmuizelaar@mozilla.com> - Mon, 09 Nov 2020 11:57:30 +0000 - rev 626545
Push 2472 by ffxbld-merge at Mon, 07 Dec 2020 19:30:50 +0000
Bug 1675906 - Add more crashes when we don't find a Factory. r=jfkthame Unlikely, but we might as well keep narrowing this down. Differential Revision: https://phabricator.services.mozilla.com/D96303
79d95cba4857ef8124a47a6f3d3e69f432128d10: Bug 1675956 - Use PrintDlgEx on Windows for the system dialog. r=jfkthame
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 09 Nov 2020 13:39:46 +0000 - rev 626524
Push 2472 by ffxbld-merge at Mon, 07 Dec 2020 19:30:50 +0000
Bug 1675956 - Use PrintDlgEx on Windows for the system dialog. r=jfkthame This allows users to use custom print ranges from the print dialog (up to 10 by default, which should be plenty). Differential Revision: https://phabricator.services.mozilla.com/D96336
b5d69a2e739656182cbb807c7c99c69537d737d3: Bug 1664372 - Fix font loading invalidation to account for metrics coming from the parent style. r=jfkthame
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 06 Nov 2020 22:30:28 +0000 - rev 626396
Push 2472 by ffxbld-merge at Mon, 07 Dec 2020 19:30:50 +0000
Bug 1664372 - Fix font loading invalidation to account for metrics coming from the parent style. r=jfkthame We were only looking at the given frame's style, which is not sufficient for this case. Differential Revision: https://phabricator.services.mozilla.com/D96237
0b0850b7413a7af4c7ee476836d74137558d409a: Bug 1209710 - Use convenience methods to simplify CSSAlignUtils::AlignJustifySelf(). r=layout-reviewers,jfkthame
Ting-Yu Lin <tlin@mozilla.com> - Wed, 04 Nov 2020 11:12:50 +0000 - rev 626001
Push 2472 by ffxbld-merge at Mon, 07 Dec 2020 19:30:50 +0000
Bug 1209710 - Use convenience methods to simplify CSSAlignUtils::AlignJustifySelf(). r=layout-reviewers,jfkthame We already have convenience methods added over the years :) Differential Revision: https://phabricator.services.mozilla.com/D95823
a4492eeb3fa78af9a8521ef44c1a5a52eee1efd3: Bug 1674931 Part 7 - Remove WritingMode and LogicalMargin alias in SizeComputationInput. r=jfkthame
Ting-Yu Lin <tlin@mozilla.com> - Tue, 03 Nov 2020 20:14:32 +0000 - rev 625815
Push 2472 by ffxbld-merge at Mon, 07 Dec 2020 19:30:50 +0000
Bug 1674931 Part 7 - Remove WritingMode and LogicalMargin alias in SizeComputationInput. r=jfkthame When referring to WritingMode and LogicalMargin, most of the existing users in SizeComputationInput are using `mozilla::` prefix, so let's remove the alias. Differential Revision: https://phabricator.services.mozilla.com/D95667
fb89da07ea442c3487ab2fade26d7ddf974554fa: Bug 1674931 Part 6 - Remove zero-argument ReflowInput::ComputedSizeWithMarginBorderPadding(). r=jfkthame
Ting-Yu Lin <tlin@mozilla.com> - Tue, 03 Nov 2020 20:02:50 +0000 - rev 625814
Push 2472 by ffxbld-merge at Mon, 07 Dec 2020 19:30:50 +0000
Bug 1674931 Part 6 - Remove zero-argument ReflowInput::ComputedSizeWithMarginBorderPadding(). r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D95666
77f2dc7fe5020a1a0b533b2273ccdd27ffe444aa: Bug 1674931 Part 5 - Remove zero-argument ReflowInput::ComputedSizeWithBorderPadding(). r=jfkthame
Ting-Yu Lin <tlin@mozilla.com> - Tue, 03 Nov 2020 20:07:18 +0000 - rev 625813
Push 2472 by ffxbld-merge at Mon, 07 Dec 2020 19:30:50 +0000
Bug 1674931 Part 5 - Remove zero-argument ReflowInput::ComputedSizeWithBorderPadding(). r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D95665
b825a3eca0c86a9f1c8cb4db374234aa651d0f12: Bug 1674931 Part 4 - Remove zero-argument ReflowInput::ComputedSizeWithPadding(). r=jfkthame
Ting-Yu Lin <tlin@mozilla.com> - Tue, 03 Nov 2020 20:04:40 +0000 - rev 625812
Push 2472 by ffxbld-merge at Mon, 07 Dec 2020 19:30:50 +0000
Bug 1674931 Part 4 - Remove zero-argument ReflowInput::ComputedSizeWithPadding(). r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D95664
ccf29bb17bcc4a8936f641604edc62f13dbcbef3: Bug 1674931 Part 3 - Add WritingMode argument to SizeComputationInput::ComputedLogicalPadding(), and adapt callers. r=jfkthame
Ting-Yu Lin <tlin@mozilla.com> - Tue, 03 Nov 2020 19:56:03 +0000 - rev 625811
Push 2472 by ffxbld-merge at Mon, 07 Dec 2020 19:30:50 +0000
Bug 1674931 Part 3 - Add WritingMode argument to SizeComputationInput::ComputedLogicalPadding(), and adapt callers. r=jfkthame This patch is similar to Part 1, but for ComputedLogicalPadding(). Differential Revision: https://phabricator.services.mozilla.com/D95663
ad537634af0d82b58711cb0a651fab9c31443157: Bug 1674931 Part 2 - Add WritingMode argument to SizeComputationInput::ComputedLogicalBorderPadding(), and adapt callers. r=jfkthame
Ting-Yu Lin <tlin@mozilla.com> - Tue, 03 Nov 2020 19:57:40 +0000 - rev 625810
Push 2472 by ffxbld-merge at Mon, 07 Dec 2020 19:30:50 +0000
Bug 1674931 Part 2 - Add WritingMode argument to SizeComputationInput::ComputedLogicalBorderPadding(), and adapt callers. r=jfkthame This patch is similar to Part 1, but for ComputedLogicalBorderPadding(). Differential Revision: https://phabricator.services.mozilla.com/D95662
b43f8212b0e47b98c3b98a166a85bce13bce466c: Bug 1674931 Part 1 - Add WritingMode argument to SizeComputationInput::ComputedLogicalMargin(), and adapt callers. r=jfkthame
Ting-Yu Lin <tlin@mozilla.com> - Tue, 03 Nov 2020 19:44:58 +0000 - rev 625809
Push 2472 by ffxbld-merge at Mon, 07 Dec 2020 19:30:50 +0000
Bug 1674931 Part 1 - Add WritingMode argument to SizeComputationInput::ComputedLogicalMargin(), and adapt callers. r=jfkthame It's straightforward to determine which writing mode is required to pass to ComputedLogicalMargin() by looking at any subsequent method called on the margin. For example, if we see ``` ComputedLogicalMargin().BStartEnd(wm); ``` the writing mode needed to pass to `ComputedLogicalMargin()` is `wm`. Differential Revision: https://phabricator.services.mozilla.com/D95661
0db0e6a3f8f01d3060adeaaa0aa599b169811f24: Bug 1672842. Avoid using the postscript name to create the CTFontDescriptor. r=jfkthame
Jeff Muizelaar <jmuizelaar@mozilla.com> - Tue, 03 Nov 2020 17:20:19 +0000 - rev 625767
Push 2472 by ffxbld-merge at Mon, 07 Dec 2020 19:30:50 +0000
Bug 1672842. Avoid using the postscript name to create the CTFontDescriptor. r=jfkthame Instead create at CTFont and get the descriptor from it. Differential Revision: https://phabricator.services.mozilla.com/D95750
1eb2d34a4883bf95c8c5aad959044c5407f77b81: Bug 1674731 - Warn a bit harder on debug builds when printing errors. r=jfkthame
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 02 Nov 2020 11:59:18 +0000 - rev 625508
Push 2472 by ffxbld-merge at Mon, 07 Dec 2020 19:30:50 +0000
Bug 1674731 - Warn a bit harder on debug builds when printing errors. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D95502
aac7d9a5298cb9287c7b3d097183f3f997027bd8: Bug 1673708: Use the original required length for paperIDs in nsPrinterWin::PaperList. r=jfkthame
Bob Owen <bobowencode@gmail.com> - Mon, 02 Nov 2020 12:05:22 +0000 - rev 625506
Push 2472 by ffxbld-merge at Mon, 07 Dec 2020 19:30:50 +0000
Bug 1673708: Use the original required length for paperIDs in nsPrinterWin::PaperList. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D95404
c0960216f5384575c34c22be29c83e9fbe134311: Bug 1674716 - Fix printing selection-only from the GTK print dialog. r=jfkthame
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 02 Nov 2020 11:19:15 +0000 - rev 625504
Push 2472 by ffxbld-merge at Mon, 07 Dec 2020 19:30:50 +0000
Bug 1674716 - Fix printing selection-only from the GTK print dialog. r=jfkthame I don't know when this broke, but we were not reading the gtk-specific boolean even before https://hg.mozilla.org/mozilla-central/rev/c61a3b0cf79e350c400b48f6be97e08c1bfbe4aa Differential Revision: https://phabricator.services.mozilla.com/D95488
9fea7d170f8d932ff2c7585c7b99d1a3cbe4b145: Bug 1674450 Part 8 - Remove SizeComputationInput's one-argument methods to set margin, border/padding, and padding. r=layout-reviewers,jfkthame
Ting-Yu Lin <tlin@mozilla.com> - Sat, 31 Oct 2020 14:45:02 +0000 - rev 625497
Push 2472 by ffxbld-merge at Mon, 07 Dec 2020 19:30:50 +0000
Bug 1674450 Part 8 - Remove SizeComputationInput's one-argument methods to set margin, border/padding, and padding. r=layout-reviewers,jfkthame The two-argument versions are clearer and easier to use because they work for any pair of writing mode and logical margin. Differential Revision: https://phabricator.services.mozilla.com/D95371
46a25fbea18d2f79aec3b3b6cbcb749704391c45: Bug 1674450 Part 7 - Store SizeComputationInput's computed margin, border/padding, and padding in logical coordinates. r=layout-reviewers,jfkthame
Ting-Yu Lin <tlin@mozilla.com> - Sat, 31 Oct 2020 14:42:04 +0000 - rev 625496
Push 2472 by ffxbld-merge at Mon, 07 Dec 2020 19:30:50 +0000
Bug 1674450 Part 7 - Store SizeComputationInput's computed margin, border/padding, and padding in logical coordinates. r=layout-reviewers,jfkthame The one-argument SetComputedLogicalMargin(), SetComputedLogicalBorderPadding(), and SetComputedLogicalPadding() are not changed because the next part are going to delete them. Note that I'm deliberately not making ComputedLogicalMargin() and others to return `const LogicalMargin&` because the compilers can use RVO to eliminate unnecessary copy. If we'd like to convert them to accept all writing mode like `nsIFrame::GetLogicalUsedMargin(WritingMode)` so that the caller don't need to call `ConvertTo`, they can't return a const reference anyway. Differential Revision: https://phabricator.services.mozilla.com/D95370
f1ab1d9462e78120a66c537e966e6c19e0803366: Bug 1674450 Part 6 - Convert ReflowInput::Init()'s optional border and padding parameters to Maybe<LogicalMargin>. r=layout-reviewers,jfkthame
Ting-Yu Lin <tlin@mozilla.com> - Sat, 31 Oct 2020 14:39:23 +0000 - rev 625495
Push 2472 by ffxbld-merge at Mon, 07 Dec 2020 19:30:50 +0000
Bug 1674450 Part 6 - Convert ReflowInput::Init()'s optional border and padding parameters to Maybe<LogicalMargin>. r=layout-reviewers,jfkthame Similar to the optional aContainingBlockSize parameter, both border and padding should use logical coordinates in ReflowInput::mFrame's writing mode. Table frames that need to override border and padding can be simplified a bit. However, DR_init_constraints_cookie and DR_init_offsets_cookie become more complex, but they're only for debugging. I'm not planning to update their internal APIs. Differential Revision: https://phabricator.services.mozilla.com/D95369
c94697ae9905e4620272742ef860b53f09375418: Bug 1674450 Part 5 - Remove SizeComputationInput::ComputedPhysicalBorderPadding() that returns a writable-reference. r=layout-reviewers,jfkthame
Ting-Yu Lin <tlin@mozilla.com> - Sat, 31 Oct 2020 14:30:11 +0000 - rev 625494
Push 2472 by ffxbld-merge at Mon, 07 Dec 2020 19:30:50 +0000
Bug 1674450 Part 5 - Remove SizeComputationInput::ComputedPhysicalBorderPadding() that returns a writable-reference. r=layout-reviewers,jfkthame Differential Revision: https://phabricator.services.mozilla.com/D95368
f80eefc2409e158e8b4f1d87975b262210c75f6b: Bug 1674450 Part 4 - Remove SizeComputationInput::ComputedPhysicalPadding() that returns a writable-reference. r=layout-reviewers,jfkthame
Ting-Yu Lin <tlin@mozilla.com> - Sat, 31 Oct 2020 14:29:50 +0000 - rev 625493
Push 2472 by ffxbld-merge at Mon, 07 Dec 2020 19:30:50 +0000
Bug 1674450 Part 4 - Remove SizeComputationInput::ComputedPhysicalPadding() that returns a writable-reference. r=layout-reviewers,jfkthame Differential Revision: https://phabricator.services.mozilla.com/D95367
931eb62aaa5aa5bdde649f6ec4e89c1dd934f763: Bug 1674450 Part 3 - Remove SizeComputationInput::ComputedPhysicalMargin() that returns a writable-reference. r=layout-reviewers,jfkthame
Ting-Yu Lin <tlin@mozilla.com> - Sat, 31 Oct 2020 14:29:27 +0000 - rev 625492
Push 2472 by ffxbld-merge at Mon, 07 Dec 2020 19:30:50 +0000
Bug 1674450 Part 3 - Remove SizeComputationInput::ComputedPhysicalMargin() that returns a writable-reference. r=layout-reviewers,jfkthame I favor two-argument SetComputedLogicalMargin() for clarity in this patch series because it works for any pair of writing mode and logical margin. Spoiler alert: the one-argument SetComputedLogicalMargin() will be removed in a later part. Differential Revision: https://phabricator.services.mozilla.com/D95366
d7318b9d7389b4f4ddcbefa15fda06b055253591: Bug 1674450 Part 2 - Rename aWM to aCBWM for some SizeComputationInput's methods. r=layout-reviewers,jfkthame
Ting-Yu Lin <tlin@mozilla.com> - Sat, 31 Oct 2020 14:29:20 +0000 - rev 625491
Push 2472 by ffxbld-merge at Mon, 07 Dec 2020 19:30:50 +0000
Bug 1674450 Part 2 - Rename aWM to aCBWM for some SizeComputationInput's methods. r=layout-reviewers,jfkthame This is a pure rename to make the argument meaning clearer. In the later parts, we might use `wm` as an alias to SizeComputationInput::mWritingMode. It's important to differentiate between mWritingMode and containing block's writing mode. Differential Revision: https://phabricator.services.mozilla.com/D95365
ce2fcebace6960dce75ec04f82a957b0d4a3d6bd: Bug 1674450 Part 1 - Move a ReflowInput's constructor down in the file so that both constructors are near. r=layout-reviewers,jfkthame
Ting-Yu Lin <tlin@mozilla.com> - Sat, 31 Oct 2020 14:29:07 +0000 - rev 625490
Push 2472 by ffxbld-merge at Mon, 07 Dec 2020 19:30:50 +0000
Bug 1674450 Part 1 - Move a ReflowInput's constructor down in the file so that both constructors are near. r=layout-reviewers,jfkthame Differential Revision: https://phabricator.services.mozilla.com/D95364
ea800bc80f1656821b988563e4188f1e54589e6f: Bug 1674228 - Speed up HasFontTable checks for freetype fonts. r=jfkthame
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 30 Oct 2020 11:56:27 +0000 - rev 625322
Push 2472 by ffxbld-merge at Mon, 07 Dec 2020 19:30:50 +0000
Bug 1674228 - Speed up HasFontTable checks for freetype fonts. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D95280
e457e0182ae26557c2fea51275fa68cffc8068ba: Bug 1674227 - Handle -moz-emoji generic in gfxPlatformFontList. r=jfkthame
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 30 Oct 2020 10:10:06 +0000 - rev 625315
Push 2472 by ffxbld-merge at Mon, 07 Dec 2020 19:30:50 +0000
Bug 1674227 - Handle -moz-emoji generic in gfxPlatformFontList. r=jfkthame And tweak the code so that it doesn't happen next time we add a new generic font. Differential Revision: https://phabricator.services.mozilla.com/D95211
fd29ba131d13728be2b10453636e8f76d968ec33: Bug 933562 - Implement complex :not(). r=jfkthame
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 29 Oct 2020 18:03:54 +0000 - rev 625246
Push 2472 by ffxbld-merge at Mon, 07 Dec 2020 19:30:50 +0000
Bug 933562 - Implement complex :not(). r=jfkthame This fixes the failures in bug 1671573 and just works thanks to the invalidation improvements I did for :is / :where. Added a couple tests for invalidation which is the tricky bit. 001 is a very straight-forward test, 002 is the :is test but with :is() replaced by double-:not(). This also fixes default namespaces inside :is() / :where(), which are supposed to get ignored, but aren't. Added tests for that and for the pre-existing :not() behavior which Chrome doesn't quite get right. Differential Revision: https://phabricator.services.mozilla.com/D94142
2e4c9e0bdba94fd9867dd9ace951b655b647a5f1: Bug 1671726 Part 2 - Store LogicalSize as a member variable in ReflowOutput, and improve the documentation. r=jfkthame
Ting-Yu Lin <tlin@mozilla.com> - Wed, 28 Oct 2020 20:42:29 +0000 - rev 625097
Push 2472 by ffxbld-merge at Mon, 07 Dec 2020 19:30:50 +0000
Bug 1671726 Part 2 - Store LogicalSize as a member variable in ReflowOutput, and improve the documentation. r=jfkthame By using LogicalSize instead of a pair of mISize and mBSize, most of the ReflowOutput's methods can delegate to LogicalSize's methods. This change shouldn't change behavior. Differential Revision: https://phabricator.services.mozilla.com/D93869
d9b31b7b645a1ba3ade0d20baa090aec7eb4e909: Bug 1671726 Part 1 - Fix a writing-mode mismatch in ViewportFrame::Reflow(). r=jfkthame
Ting-Yu Lin <tlin@mozilla.com> - Wed, 28 Oct 2020 20:42:26 +0000 - rev 625096
Push 2472 by ffxbld-merge at Mon, 07 Dec 2020 19:30:50 +0000
Bug 1671726 Part 1 - Fix a writing-mode mismatch in ViewportFrame::Reflow(). r=jfkthame After applying the next part, 1161752.html's runTest2() can trigger the following assertion without this patch. ``` ASSERTION: writing-mode mismatch: 'aWritingMode.IgnoreSideways() == GetWritingMode().IgnoreSideways()' ``` `kidDesiredSize` is initialized by ViewportFrame's reflow input, so it stores the ViewportFrame's writing mode. But after calling `ReflowChild`, the old code is accessing the kid's block-size by using `kidDesiredSize.BSize(wm)`, where `wm` is being shadowed within the inner if and becomes the kid's writing mode. This patch fixed it by changing the inner `wm` to `kidWM` for the clarity and avoiding the variable shadowing. In the next part, ReflowOutput's documentation is updated, hoping to prevent the writing mode misusages in the future. Differential Revision: https://phabricator.services.mozilla.com/D93868
6f170fe5df51b86fd0f298f20885ee2c18f1a948: Bug 1669393 - Fix up position of overflow container children in a vertical-rl block once we know the final block size. r=jfkthame
Ting-Yu Lin <tlin@mozilla.com> - Wed, 28 Oct 2020 18:07:22 +0000 - rev 625073
Push 2472 by ffxbld-merge at Mon, 07 Dec 2020 19:30:50 +0000
Bug 1669393 - Fix up position of overflow container children in a vertical-rl block once we know the final block size. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D93727
7b80592017b72a6a92d794b32e68ee4b2ce267ba: Bug 1672411 - Update freetype2 to 2.10.4. r=jfkthame
Ryan VanderMeulen <ryanvm@gmail.com> - Wed, 28 Oct 2020 09:39:35 +0000 - rev 625022
Push 2472 by ffxbld-merge at Mon, 07 Dec 2020 19:30:50 +0000
Bug 1672411 - Update freetype2 to 2.10.4. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D94321
14e2615846392e710d48c3e3b14b7de1476f347e: Bug 1672899. Avoid CGFonts in ctfont_create_exact_copy when possible. r=jfkthame
Jeff Muizelaar <jmuizelaar@mozilla.com> - Wed, 28 Oct 2020 14:16:41 +0000 - rev 625021
Push 2472 by ffxbld-merge at Mon, 07 Dec 2020 19:30:50 +0000
Bug 1672899. Avoid CGFonts in ctfont_create_exact_copy when possible. r=jfkthame We should be able to use CTFontCreateCopyWithAttributes for non-system fonts because we don't need to worry about them changing. This avoids the leaks caused by going through a CGFont. Differential Revision: https://phabricator.services.mozilla.com/D94772
4f179bf502cedd18bf16a625477d5902e4304c89: Bug 1672625 - Make monochrome support on GTK work like on Mac. r=jfkthame
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 27 Oct 2020 16:23:26 +0000 - rev 624854
Push 2472 by ffxbld-merge at Mon, 07 Dec 2020 19:30:50 +0000
Bug 1672625 - Make monochrome support on GTK work like on Mac. r=jfkthame We do it in nsDeviceContextSpecG since that's what actually consumes the settings. On GTK the options need to be prefixed by cups- for some reason in order to work, so factor out a macro listing the options and do the NSString / cups- prefixing in the platform specific places. Differential Revision: https://phabricator.services.mozilla.com/D94479
420e6bcaf228f738230fd8bfc30a4e49c12f67cd: Bug 1673155 - Add SEC CJK font to font.name-list.sans-serif / font.name-list.monospace. r=jfkthame
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 26 Oct 2020 09:04:35 +0000 - rev 624617
Push 2472 by ffxbld-merge at Mon, 07 Dec 2020 19:30:50 +0000
Bug 1673155 - Add SEC CJK font to font.name-list.sans-serif / font.name-list.monospace. r=jfkthame The default fonts of CJK on Samsung's Galaxy device seems to be SEC CJK fonts. This seems to be modified version of Noto Sans CJK. Samsung has No. 1 market share for Android, so we should add this fonts to default font list. Differential Revision: https://phabricator.services.mozilla.com/D94702
a4853e82ea7a0f42cebd8b5ca5d769222befaada: Bug 1669007. Set the pref gfx.font_loader.delay=0 when running reftests in layout/general/test to fix test_scroll_position_restore.html intermittent failure. r=jfkthame
Timothy Nikkel <tnikkel@gmail.com> - Sun, 25 Oct 2020 20:31:45 +0000 - rev 624474
Push 2472 by ffxbld-merge at Mon, 07 Dec 2020 19:30:50 +0000
Bug 1669007. Set the pref gfx.font_loader.delay=0 when running reftests in layout/general/test to fix test_scroll_position_restore.html intermittent failure. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D94694