searching for reviewer(jaws)
cf7d4022338c: Bug 1511267 - Cloud Storage init provider test and intermittent failure fix. r=jaws, a=test-only
Punam <pdahiya@mozilla.com> - Tue, 15 Jan 2019 21:50:17 +0000 - rev 509501
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1511267 - Cloud Storage init provider test and intermittent failure fix. r=jaws, a=test-only Cloud Storage initialize provider test to help fix intermittent test failures Differential Revision: https://phabricator.services.mozilla.com/D15998
3fa15331a220: Bug 1516767 - Adjust button border, outline and box-shadow to be compatible with High-Contrast Mode and less glitchy. r=jaws, a=RyanVM
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Mon, 14 Jan 2019 13:50:34 +0000 - rev 509466
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1516767 - Adjust button border, outline and box-shadow to be compatible with High-Contrast Mode and less glitchy. r=jaws, a=RyanVM
76325782999f: Bug 1518996 - Fix double border/outline for textbox[multiline] by not setting one on the inner textarea. r=jaws, a=RyanVM
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Fri, 11 Jan 2019 20:01:39 +0000 - rev 509465
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1518996 - Fix double border/outline for textbox[multiline] by not setting one on the inner textarea. r=jaws, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D16334
8acdc547561d: Bug 1517078 - Enable browser languages section in prefs on release and beta. r=jaws, a=RyanVM
Mark Striemer <mstriemer@mozilla.com> - Fri, 11 Jan 2019 21:55:16 +0000 - rev 509438
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1517078 - Enable browser languages section in prefs on release and beta. r=jaws, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D15738
274d22447873: Bug 1502448 - Work around principal issues with pdfjs and saving local files. r=jkt,jaws, a=RyanVM
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Mon, 07 Jan 2019 16:59:26 +0000 - rev 509365
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1502448 - Work around principal issues with pdfjs and saving local files. r=jkt,jaws, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D15568
d444faf56f5c: Bug 1466817 - The "Edit Pop-up Blocker Options/Preferences" command should open the in-content preferences. r=jaws, a=RyanVM
Paolo Amadini <paolo.mozmail@amadzone.org> - Sun, 23 Dec 2018 20:52:15 +0000 - rev 509202
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1466817 - The "Edit Pop-up Blocker Options/Preferences" command should open the in-content preferences. r=jaws, a=RyanVM Instead of opening the pop-up permissions dialog with the origin already populated, this command now highlights the pop-up permission row in the preferences. This doesn't remove any functionality because the only action that would be available for the origin in the permissions dialog is "Allow", which is equivalent to the "Allow pop-ups for" command in the notification bar menu. Differential Revision: https://phabricator.services.mozilla.com/D15066
59e23e5ef5c6: Bug 1513958 - Fix aboutdebugging.noftl to work with Fluent 0.10. r=jaws, a=RyanVM
Zibi Braniecki <zbraniecki@mozilla.com> - Tue, 18 Dec 2018 23:04:42 +0000 - rev 509137
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1513958 - Fix aboutdebugging.noftl to work with Fluent 0.10. r=jaws, a=RyanVM Depends on D14612 Differential Revision: https://phabricator.services.mozilla.com/D14904
dd09f113cb8a: Bug 1513600 - Use elementFromPoint() to measure isMouseOverVideo. r=jaws, a=RyanVM
Timothy Guan-tin Chien <timdream@gmail.com> - Sat, 15 Dec 2018 02:56:27 +0000 - rev 509100
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1513600 - Use elementFromPoint() to measure isMouseOverVideo. r=jaws, a=RyanVM The checkEventWithin method is broken by two bugs: The first one is bug 1493525 because we ended up pass the proxy instance, instead of the element reference, as the parent node to compare. The second one is unknown and happened sometime after that bug. The |relatedTarget| of the mouse event is always <video>, instead of the element within Shadow DOM that the cursor is moving out to. Instead of identify the second bug in the DOM, this patch employs a simpler fix by using elementFromPoint() to identify the cursor position. Differential Revision: https://phabricator.services.mozilla.com/D14342
2fe74b55dfcc: Bug 1512187 - Update preferences spotlight color. r=jaws, a=RyanVM
Erica Wright <ewright@mozilla.com> - Tue, 11 Dec 2018 15:31:28 +0000 - rev 509090
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1512187 - Update preferences spotlight color. r=jaws, a=RyanVM Change the coloring of the spotlight, and add a fadeout Differential Revision: https://phabricator.services.mozilla.com/D13822
b380a84b065d: Bug 1503393 - Make 'no proxy' field editable. r=jaws, a=RyanVM
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Mon, 03 Dec 2018 16:27:50 +0200 - rev 509076
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1503393 - Make 'no proxy' field editable. r=jaws, a=RyanVM
5281e679d232: Bug 1513710 - Bring back stringbundle on-demand for certificate export code, and add a test for certificate exports. r=jaws, a=RyanVM
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Fri, 14 Dec 2018 20:45:58 +0000 - rev 509010
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1513710 - Bring back stringbundle on-demand for certificate export code, and add a test for certificate exports. r=jaws, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D14555
8f78e91a61b8: Bug 1506869 - Rename roundButtonBackground and roundButtonPressedBackground. r=jaws, a=RyanVM
Dão Gottwald <dao@mozilla.com> - Sat, 15 Dec 2018 12:25:53 +0100 - rev 509008
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1506869 - Rename roundButtonBackground and roundButtonPressedBackground. r=jaws, a=RyanVM
d68c09b685cc: Bug 1506869 - Don't remove .findbar-button's background-color set by toolbarbutton-icons.inc.css. r=jaws, a=RyanVM
Dão Gottwald <dao@mozilla.com> - Fri, 14 Dec 2018 19:51:13 +0000 - rev 509007
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1506869 - Don't remove .findbar-button's background-color set by toolbarbutton-icons.inc.css. r=jaws, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D14539
a72dafbb2e80: Bug 1506996 - Hardcode colors in the content blocking shield animation to avoid animating context properties. r=jaws,sfoster
Johann Hofmann <jhofmann@mozilla.com> - Fri, 07 Dec 2018 17:28:32 -0500 - rev 508907
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1506996 - Hardcode colors in the content blocking shield animation to avoid animating context properties. r=jaws,sfoster
a3a2ea1539b8: Bug 1511138 - Improve performance of LightweightThemeConsumer when setting properties, and also avoid _sanitizeCSSColor from getting fooled. r=jaws
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 03 Dec 2018 21:06:44 -0500 - rev 508902
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1511138 - Improve performance of LightweightThemeConsumer when setting properties, and also avoid _sanitizeCSSColor from getting fooled. r=jaws This probably deserves a comment as of why it belongs to this bug. This patch series caused a single, reproducible timeout on browser_ext_themes_toolbars.js, where the transitionend event it awaits for stops triggering. I got fascinated by it and I decided to poke around it in rr instead of just removing the await line, and here's what's going on. In the previous implementation of _sanitizeCSSColor, we were not flushing style because of the optimization bug 1363805 introduced (which wasn't supposed to deal with out-of-document elements, but it accidentally did so). In any case, the fact that we were not flushing style in _sanitizeCSSColor caused us to flush style sometime later when the lwtheme attribute was already set up, and thus the selector in here matched: https://searchfox.org/mozilla-central/rev/cfaa5a1d48d6bc6552199e73004ecb05d0a9c921/browser/themes/shared/browser.inc.css#40 And thus caused the transition rule to apply at a time where the background-color change happened. Now we were flushing on getComputedStyle on every call, and in the most inefficient way possible (changing a custom property on the root before each property change, which causes us to restyle the whole document to propagate it down to all descendants). Furthermore, we were flushing style at a time where the lwtheme attribute change had not yet happened, and thus when the background-color changed, there was no transition rule applicable, and the transition didn't fire. This patch changes LightweightThemeConsumer to avoid restyling the whole document over and over. Also, while at it I realized that you could fool the sanitizer with !important in an experiment stylesheet or with other !important rule in the page really. It's not clear why you'd do that, but it may be worth to just making that function completely sound, so I did that and added a test for it. Differential Revision: https://phabricator.services.mozilla.com/D13716
fa5967565fc6: Bug 1511138 - Fix LightweightThemeConsumer's use of getComputedStyle. r=jaws,mconley
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 30 Nov 2018 12:40:25 +0100 - rev 508901
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1511138 - Fix LightweightThemeConsumer's use of getComputedStyle. r=jaws,mconley See D13472 for spec quotes and such. Other browsers don't allow getting computed styles in disconnected subtrees and we agreed to follow suit (it does make sense because when you're not on the flat tree it's not defined what you're supposed to inherit from, specially in presence of Shadow DOM). Also, it allows the style system to rely on the DOM being in a sane state. Differential Revision: https://phabricator.services.mozilla.com/D13551
daee82295b3c: Bug 1511138 - Fix getComputedStyle usage of SelectChild. r=jaws,mconley
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 06 Dec 2018 17:22:45 -0500 - rev 508896
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1511138 - Fix getComputedStyle usage of SelectChild. r=jaws,mconley I missed the failure in browser_selectpopup_colors.js since it doesn't run on Linux. Fix the getComputedStyle usage in that code by using getDefaultComputedStyle, which is what it really wants. Also, do a bit of cleanup while at it: uaBackgroundColor was unused, and uaColor was wrong (we don't override the ua color of the <option> element, it just inherits, so it's the same as the <select> color, and that's what we were comparing it against anyway). Differential Revision: https://phabricator.services.mozilla.com/D13956
d23c9c3e1566: Bug 1511138 - Improve performance of LightweightThemeConsumer when setting properties, and also avoid _sanitizeCSSColor from getting fooled. r=jaws
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 03 Dec 2018 21:06:44 -0500 - rev 508895
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1511138 - Improve performance of LightweightThemeConsumer when setting properties, and also avoid _sanitizeCSSColor from getting fooled. r=jaws This probably deserves a comment as of why it belongs to this bug. This patch series caused a single, reproducible timeout on browser_ext_themes_toolbars.js, where the transitionend event it awaits for stops triggering. I got fascinated by it and I decided to poke around it in rr instead of just removing the await line, and here's what's going on. In the previous implementation of _sanitizeCSSColor, we were not flushing style because of the optimization bug 1363805 introduced (which wasn't supposed to deal with out-of-document elements, but it accidentally did so). In any case, the fact that we were not flushing style in _sanitizeCSSColor caused us to flush style sometime later when the lwtheme attribute was already set up, and thus the selector in here matched: https://searchfox.org/mozilla-central/rev/cfaa5a1d48d6bc6552199e73004ecb05d0a9c921/browser/themes/shared/browser.inc.css#40 And thus caused the transition rule to apply at a time where the background-color change happened. Now we were flushing on getComputedStyle on every call, and in the most inefficient way possible (changing a custom property on the root before each property change, which causes us to restyle the whole document to propagate it down to all descendants). Furthermore, we were flushing style at a time where the lwtheme attribute change had not yet happened, and thus when the background-color changed, there was no transition rule applicable, and the transition didn't fire. This patch changes LightweightThemeConsumer to avoid restyling the whole document over and over. Also, while at it I realized that you could fool the sanitizer with !important in an experiment stylesheet or with other !important rule in the page really. It's not clear why you'd do that, but it may be worth to just making that function completely sound, so I did that and added a test for it. Differential Revision: https://phabricator.services.mozilla.com/D13716
a99600391704: Bug 1511138 - Fix LightweightThemeConsumer's use of getComputedStyle. r=jaws,mconley
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 30 Nov 2018 12:40:25 +0100 - rev 508894
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1511138 - Fix LightweightThemeConsumer's use of getComputedStyle. r=jaws,mconley See D13472 for spec quotes and such. Other browsers don't allow getting computed styles in disconnected subtrees and we agreed to follow suit (it does make sense because when you're not on the flat tree it's not defined what you're supposed to inherit from, specially in presence of Shadow DOM). Also, it allows the style system to rely on the DOM being in a sane state. Differential Revision: https://phabricator.services.mozilla.com/D13551
f9aa23e0cc9b: Bug 1511216 - Intermittent preferences cloud storage test in verify mode r=jaws
Punam <pdahiya@mozilla.com> - Thu, 06 Dec 2018 17:53:12 +0000 - rev 508776
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1511216 - Intermittent preferences cloud storage test in verify mode r=jaws Intermittent preferences UI cloud storage test failures in verify mode Differential Revision: https://phabricator.services.mozilla.com/D13846
5f5d1c50a342: Bug 1511138 - Improve performance of LightweightThemeConsumer when setting properties, and also avoid _sanitizeCSSColor from getting fooled. r=jaws
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 03 Dec 2018 21:06:44 -0500 - rev 508762
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1511138 - Improve performance of LightweightThemeConsumer when setting properties, and also avoid _sanitizeCSSColor from getting fooled. r=jaws This probably deserves a comment as of why it belongs to this bug. This patch series caused a single, reproducible timeout on browser_ext_themes_toolbars.js, where the transitionend event it awaits for stops triggering. I got fascinated by it and I decided to poke around it in rr instead of just removing the await line, and here's what's going on. In the previous implementation of _sanitizeCSSColor, we were not flushing style because of the optimization bug 1363805 introduced (which wasn't supposed to deal with out-of-document elements, but it accidentally did so). In any case, the fact that we were not flushing style in _sanitizeCSSColor caused us to flush style sometime later when the lwtheme attribute was already set up, and thus the selector in here matched: https://searchfox.org/mozilla-central/rev/cfaa5a1d48d6bc6552199e73004ecb05d0a9c921/browser/themes/shared/browser.inc.css#40 And thus caused the transition rule to apply at a time where the background-color change happened. Now we were flushing on getComputedStyle on every call, and in the most inefficient way possible (changing a custom property on the root before each property change, which causes us to restyle the whole document to propagate it down to all descendants). Furthermore, we were flushing style at a time where the lwtheme attribute change had not yet happened, and thus when the background-color changed, there was no transition rule applicable, and the transition didn't fire. This patch changes LightweightThemeConsumer to avoid restyling the whole document over and over. Also, while at it I realized that you could fool the sanitizer with !important in an experiment stylesheet or with other !important rule in the page really. It's not clear why you'd do that, but it may be worth to just making that function completely sound, so I did that and added a test for it. Differential Revision: https://phabricator.services.mozilla.com/D13716
e03afbff55f3: Bug 1511138 - Fix LightweightThemeConsumer's use of getComputedStyle. r=jaws,mconley
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 30 Nov 2018 12:40:25 +0100 - rev 508761
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1511138 - Fix LightweightThemeConsumer's use of getComputedStyle. r=jaws,mconley See D13472 for spec quotes and such. Other browsers don't allow getting computed styles in disconnected subtrees and we agreed to follow suit (it does make sense because when you're not on the flat tree it's not defined what you're supposed to inherit from, specially in presence of Shadow DOM). Also, it allows the style system to rely on the DOM being in a sane state. Differential Revision: https://phabricator.services.mozilla.com/D13551
3fe6e58ce394: Bug 1507806 - Use level 1 headings for major groups in Preferences. r=jaws
Paolo Amadini <paolo.mozmail@amadzone.org> - Tue, 04 Dec 2018 18:51:29 +0000 - rev 508687
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1507806 - Use level 1 headings for major groups in Preferences. r=jaws Differential Revision: https://phabricator.services.mozilla.com/D13736
7878029aaba6: Bug 1503393 - Make 'no proxy' field editable r=jaws
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Mon, 03 Dec 2018 16:27:50 +0200 - rev 508456
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1503393 - Make 'no proxy' field editable r=jaws
caef08c907dd: Bug 1510017 - Ensure label is reset when adding browser language r=jaws
Mark Striemer <mstriemer@mozilla.com> - Thu, 29 Nov 2018 18:39:02 +0000 - rev 508319
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1510017 - Ensure label is reset when adding browser language r=jaws Differential Revision: https://phabricator.services.mozilla.com/D12987
dddf315cfaa2: Bug 1504868 - Add missing padding back to browser languages dialog r=jaws
Mark Striemer <mstriemer@mozilla.com> - Thu, 29 Nov 2018 18:39:00 +0000 - rev 508318
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1504868 - Add missing padding back to browser languages dialog r=jaws Differential Revision: https://phabricator.services.mozilla.com/D12986
5f0040d4be16: Bug 1506835 - Resize browser languages dialog when error appears r=jaws
Mark Striemer <mstriemer@mozilla.com> - Fri, 30 Nov 2018 19:37:41 +0000 - rev 508317
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1506835 - Resize browser languages dialog when error appears r=jaws *** Differential Revision: https://phabricator.services.mozilla.com/D12985
d97acd2c8af7: Bug 1510840 - Remove unused plugin strings r=jaws
Michael Kohler <me@michaelkohler.info> - Fri, 30 Nov 2018 19:37:08 +0000 - rev 508280
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1510840 - Remove unused plugin strings r=jaws Differential Revision: https://phabricator.services.mozilla.com/D13453
b9dcfde98e47: Bug 1506173 - use separate pref for warning on quit with sessionstore enabled, r=jaws,flod
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Fri, 30 Nov 2018 20:21:59 +0000 - rev 508271
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1506173 - use separate pref for warning on quit with sessionstore enabled, r=jaws,flod Differential Revision: https://phabricator.services.mozilla.com/D13535
f4cb63cf5e47: Bug 1504751 Migrate about:networking to Fluent r=jaws,flod
Collin Wing <masterkrombi@gmail.com> - Tue, 20 Nov 2018 00:53:23 +0000 - rev 508238
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1504751 Migrate about:networking to Fluent r=jaws,flod Differential Revision: https://phabricator.services.mozilla.com/D10977
dc8bec8f0dc0: Bug 1505846 Migrate about:searchreset to Fluent r=jaws,flod,zbraniecki
Collin Wing <masterkrombi@gmail.com> - Mon, 26 Nov 2018 17:05:18 +0000 - rev 508213
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1505846 Migrate about:searchreset to Fluent r=jaws,flod,zbraniecki Differential Revision: https://phabricator.services.mozilla.com/D11373
3c5a3bfe79a8: Bug 1446073 - Preferences UI cloud storage download tests r=jaws
Punam <pdahiya@mozilla.com> - Thu, 29 Nov 2018 21:12:22 +0000 - rev 508072
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1446073 - Preferences UI cloud storage download tests r=jaws Preferences UI cloud storage download tests Differential Revision: https://phabricator.services.mozilla.com/D13178
5ad19f215939: Bug 1472740 - Avoid LWT aliases in theme API tests that are not specifically about LWT aliases. r=ntim,jaws
Luca Greco <lgreco@mozilla.com> - Mon, 26 Nov 2018 16:10:36 +0000 - rev 507970
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1472740 - Avoid LWT aliases in theme API tests that are not specifically about LWT aliases. r=ntim,jaws This patch replace the LWT aliases with their related non-deprecated alias in all the theme API tests that don't seem to be specifically testing the LWT aliases (e.g. browser_ext_themes_lwtsupport.js is leaved unmodified for this reason). The main reason to replace them in the "not stricly LWT-related" tests before their final removal (currently planned for Firefox 69) is that the deprecation warnings will make these tests more noisy (and so they may be making harder to investigate failures, without any actual gain in terms of coverage). Depends on D12297 Differential Revision: https://phabricator.services.mozilla.com/D12783
7b5c486601e5: Bug 1472740 - Warn on deprecated static theme LWT aliases usage. r=ntim,jaws
Luca Greco <lgreco@mozilla.com> - Fri, 23 Nov 2018 18:58:45 +0000 - rev 507969
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1472740 - Warn on deprecated static theme LWT aliases usage. r=ntim,jaws This patch doesn't currently prevent a static theme which uses the LWT aliases from being installed successfully but, as the first step for their deprecation and removal, it starts to log a warning message when these aliases are being used (e.g. when installing the static theme extension from "about:debugging", these warnings are being shown to the theme author). A similar linting warning is going to be emitted on AMO submissions (See https://github.com/mozilla/addons-linter/issues/2259), and it will be turned it into a linting error once AMO should start to prevent new static theme submittions from using the LWT aliases. Differential Revision: https://phabricator.services.mozilla.com/D12297
da642018d1c6: Bug 1510321 - avoid calling buildArea for all the builtin toolbars, r=jaws,bgrins
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 28 Nov 2018 23:23:31 +0000 - rev 507864
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1510321 - avoid calling buildArea for all the builtin toolbars, r=jaws,bgrins Differential Revision: https://phabricator.services.mozilla.com/D13259
eb6081654679: Bug 1510462 - Remove redundant AddonManager definition. r=jaws
Dão Gottwald <dao@mozilla.com> - Wed, 28 Nov 2018 04:56:39 +0000 - rev 507687
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1510462 - Remove redundant AddonManager definition. r=jaws Differential Revision: https://phabricator.services.mozilla.com/D13157
40310bdbb670: Bug 1509488 - Use keydown handler instead of <key> for Shift+Ctrl+Tab. r=jaws
Dão Gottwald <dao@mozilla.com> - Mon, 26 Nov 2018 16:07:07 +0000 - rev 507387
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1509488 - Use keydown handler instead of <key> for Shift+Ctrl+Tab. r=jaws Differential Revision: https://phabricator.services.mozilla.com/D12744
1bb7cd7e79a4: Bug 1509080 - Clear language change confirmation content on hide r=jaws
Mark Striemer <mstriemer@mozilla.com> - Thu, 22 Nov 2018 17:56:27 +0000 - rev 506929
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1509080 - Clear language change confirmation content on hide r=jaws Previously this would just clear the locales attribute on the button, but the button isn't always part of the content now. The content is generated in full when it is shown. Differential Revision: https://phabricator.services.mozilla.com/D12567
b1c8590d5f74: Bug 1506026 - Don't accidentally hide the navigator-toolbox if fullscreen has been exited. r=jaws
Mike Conley <mconley@mozilla.com> - Wed, 21 Nov 2018 23:28:45 +0000 - rev 506862
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1506026 - Don't accidentally hide the navigator-toolbox if fullscreen has been exited. r=jaws Differential Revision: https://phabricator.services.mozilla.com/D12594
929c91b8afc6: Bug 1494014 - fix icon on the lightweight theme button to be correct when changing it from the menu, r=jaws
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 21 Nov 2018 17:23:05 +0000 - rev 506720
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1494014 - fix icon on the lightweight theme button to be correct when changing it from the menu, r=jaws Differential Revision: https://phabricator.services.mozilla.com/D12546
5128dd79f222: Bug 1505141 - Test that address fields hidden from edit forms aren't blanked unnecessarily. r=jaws
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Wed, 21 Nov 2018 00:43:46 +0000 - rev 506708
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1505141 - Test that address fields hidden from edit forms aren't blanked unnecessarily. r=jaws Depends on D12190 Differential Revision: https://phabricator.services.mozilla.com/D12191
4f693fc02c24: Bug 1505141 - Always preserveOldProperties for payment request but blank mailing address fields by default. r=jaws
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Wed, 21 Nov 2018 00:46:23 +0000 - rev 506707
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1505141 - Always preserveOldProperties for payment request but blank mailing address fields by default. r=jaws Differential Revision: https://phabricator.services.mozilla.com/D12190
6ce32daf8079: Bug 1494014 - fix icon on the lightweight theme button to be correct when changing it from the menu, r=jaws
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 21 Nov 2018 15:08:03 +0000 - rev 506685
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1494014 - fix icon on the lightweight theme button to be correct when changing it from the menu, r=jaws Differential Revision: https://phabricator.services.mozilla.com/D12546
f5db5f1b2690: Bug 1500218 - Set 'Move to Start' and 'Move to End' disabled state according to contextTab and contextTab position r=dao,jaws
Michael Kohler <me@michaelkohler.info> - Wed, 21 Nov 2018 11:30:33 +0000 - rev 506676
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1500218 - Set 'Move to Start' and 'Move to End' disabled state according to contextTab and contextTab position r=dao,jaws Differential Revision: https://phabricator.services.mozilla.com/D9598
004331df8823: Bug 1429940 - Part 2 - Use HTML headings inside the "label" element for labeling "groupbox" elements in Preferences, instead of the "caption" element. r=MarcoZ,dao,jaws,flod
Paolo Amadini <paolo.mozmail@amadzone.org> - Tue, 20 Nov 2018 15:14:18 +0000 - rev 506620
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1429940 - Part 2 - Use HTML headings inside the "label" element for labeling "groupbox" elements in Preferences, instead of the "caption" element. r=MarcoZ,dao,jaws,flod This makes it possible to navigate by headings when using accessibility technology. Information labels displayed when removing the master password are also restored. Differential Revision: https://phabricator.services.mozilla.com/D11792
02892fb6feab: Bug 1503393, r=jaws
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 14 Nov 2018 11:37:06 +0000 - rev 506262
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1503393, r=jaws
962527f12004: Bug 1504751 Migrate about:networking to Fluent r=jaws,flod
Collin Wing <masterkrombi@gmail.com> - Fri, 16 Nov 2018 18:01:08 +0000 - rev 506019
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1504751 Migrate about:networking to Fluent r=jaws,flod Differential Revision: https://phabricator.services.mozilla.com/D10977
0f600f20a907: Bug 1502396 - Convert change and remove master password dialogs in about:preferences to use Fluent r=jaws,Gijs,flod
Jack Smith <jack@jackdeansmith.com> - Tue, 06 Nov 2018 21:39:17 +0000 - rev 505945
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1502396 - Convert change and remove master password dialogs in about:preferences to use Fluent r=jaws,Gijs,flod Differential Revision: https://phabricator.services.mozilla.com/D10949
8867eaddfa83: Bug 1435880 - Handle moving/detaching tabs between windows when a Payment Request is showing. r=jaws
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Thu, 15 Nov 2018 15:06:21 +0000 - rev 505844
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1435880 - Handle moving/detaching tabs between windows when a Payment Request is showing. r=jaws Depends on D10180 Differential Revision: https://phabricator.services.mozilla.com/D10183
802dfe1bb501: Bug 1435880 - Put the payment dialog <browser> directly in the ChromeWindow. r=jaws
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Thu, 15 Nov 2018 15:05:12 +0000 - rev 505843
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1435880 - Put the payment dialog <browser> directly in the ChromeWindow. r=jaws Remove the intermediate <html:iframe> as it makes support of detaching impossible since we would need to swap both the <browser> and <html:iframe> contents during a tab detach. Since a docshell swap requires both docshells to have a frame and document loaded and the move of the tab won't wait on payments code to do async work to get frames and documents ready for swapping, I couldn't see a way to get detaching to work with the nested frames. * Swapping the docshell of only the outer <html:iframe> still caused a reload of the inner <browser>. Differential Revision: https://phabricator.services.mozilla.com/D10180