searching for reviewer(jaws)
91cc1385616d: Bug 1450975 - Load themes without an accentcolor. r=jaws, a=lizzard
Tim Nguyen <ntim.bugs@gmail.com> - Mon, 16 Apr 2018 10:24:48 +0200 - rev 463552
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1450975 - Load themes without an accentcolor. r=jaws, a=lizzard MozReview-Commit-ID: 2EGsaajHZfM
49d46c15ca0b: Bug 1454323 - Set the default key in <key> to avoid it capturing all command keys. r=jaws a=jcristau
Zibi Braniecki <zbraniecki@mozilla.com> - Tue, 17 Apr 2018 12:50:48 -0700 - rev 463467
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1454323 - Set the default key in <key> to avoid it capturing all command keys. r=jaws a=jcristau MozReview-Commit-ID: 3oD7iaTEbZg
c5734a8b1d7a: Bug 1451024 - Cookie settings should be disabled when the related prefs are locked r=jaws a=jcristau
Kirk Steuber <ksteuber@mozilla.com> - Tue, 10 Apr 2018 15:05:42 -0700 - rev 463377
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1451024 - Cookie settings should be disabled when the related prefs are locked r=jaws a=jcristau Also adds too the cookie tests to ensure this takes effect. MozReview-Commit-ID: A85kv20BcnI
f48a56beb09d: Bug 1452019 - Fix tab_selected when lwt-image attribute is not set. r=jaws a=jcristau
Tim Nguyen <ntim.bugs@gmail.com> - Wed, 11 Apr 2018 03:16:37 +0200 - rev 463277
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1452019 - Fix tab_selected when lwt-image attribute is not set. r=jaws a=jcristau MozReview-Commit-ID: KVhfU9siVH8
94b99a3d55b2: Bug 1450761 - Policy to hide the Add Exception button on certificate error pages. r=jaws a=jcristau
Felipe Gomes <felipc@gmail.com> - Fri, 06 Apr 2018 18:21:11 -0300 - rev 463085
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1450761 - Policy to hide the Add Exception button on certificate error pages. r=jaws a=jcristau
e5906299c4ac: Bug 1450761 - Add pref to hide the Add Exception button on certificate error pages. r=jaws a=jcristau
Felipe Gomes <felipc@gmail.com> - Wed, 04 Apr 2018 15:56:15 -0300 - rev 463084
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1450761 - Add pref to hide the Add Exception button on certificate error pages. r=jaws a=jcristau
fe973bfe84fe: Bug 1429161 - Policy: Hide Forget Button. r=jaws a=jcristau
Felipe Gomes <felipc@gmail.com> - Tue, 03 Apr 2018 15:39:35 -0300 - rev 463079
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1429161 - Policy: Hide Forget Button. r=jaws a=jcristau
02c4132c8e08: Bug 1414693 - Fix findbar buttons hover feedback when using a dark lightweight theme. r=jaws,dao a=jcristau
Bogdan Pozderca <bogdan@pozderca.com> - Tue, 13 Mar 2018 18:49:35 -0400 - rev 463010
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1414693 - Fix findbar buttons hover feedback when using a dark lightweight theme. r=jaws,dao a=jcristau
3002e41cb4a3: Bug 1429169 - Policies to set the default settings for Flash, Cookies and Popups. r=jimm,jaws,felipe a=RyanVM
Kirk Steuber <ksteuber@mozilla.com> - Tue, 20 Mar 2018 14:56:02 -0700 - rev 462965
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1429169 - Policies to set the default settings for Flash, Cookies and Popups. r=jimm,jaws,felipe a=RyanVM
1635a57d13f6: Bug 1439332 - todo assertions for "no site data" in site data cookies tests for now. r=jaws, a=test-only
Johann Hofmann <jhofmann@mozilla.com> - Thu, 22 Mar 2018 18:45:04 +0100 - rev 462832
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1439332 - todo assertions for "no site data" in site data cookies tests for now. r=jaws, a=test-only MozReview-Commit-ID: LOy30KvMBg2
6d9462961951: Bug 1444521 - Preferences UI save to cloud downloads event listener. r=jaws, a=jcristau
Punam <pdahiya@mozilla.com> - Tue, 13 Mar 2018 17:54:18 -0700 - rev 462783
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1444521 - Preferences UI save to cloud downloads event listener. r=jaws, a=jcristau MozReview-Commit-ID: LbKr1rpXn4q
9ba5a964b20d: Bug 1443771 - Add ESR name to the about dialog. It is not translated. r=Felipe,jaws, a=jcristau
Michael Kaply <mozilla@kaply.com> - Wed, 14 Mar 2018 17:41:26 -0500 - rev 462765
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1443771 - Add ESR name to the about dialog. It is not translated. r=Felipe,jaws, a=jcristau MozReview-Commit-ID: FYjA7IrTGYt
5704da3fb8b7: Bug 1445028 - Hide sync-dev-edition-root properly if sync is disabled. r=jaws a=jcristau
Edouard Oger <eoger@fastmail.com> - Tue, 13 Mar 2018 10:16:43 -0400 - rev 462640
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1445028 - Hide sync-dev-edition-root properly if sync is disabled. r=jaws a=jcristau MozReview-Commit-ID: 29ylwC3tJdM
e620f50bbdcf: Bug 1222414 - Convert hardcoded colors in add-on manager to CSS variables. r=jaws, ntim
raymond <concept_ray@hotmail.com> - Thu, 08 Mar 2018 09:00:51 -0500 - rev 462529
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1222414 - Convert hardcoded colors in add-on manager to CSS variables. r=jaws, ntim
fffb18b9cb46: Bug 1444083 - Disable custom styling for <select> and <option> on Tier3 as well. r=jaws
Jan Beich <jbeich@FreeBSD.org> - Thu, 08 Mar 2018 14:40:44 +0000 - rev 462492
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1444083 - Disable custom styling for <select> and <option> on Tier3 as well. r=jaws MozReview-Commit-ID: DUlq3hsBRfg
b8b7a46f6a24: Bug 1443604 - Flatten handler bindings r=jaws
Timothy Guan-tin Chien <timdream@gmail.com> - Tue, 06 Mar 2018 11:42:44 -0800 - rev 461996
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1443604 - Flatten handler bindings r=jaws Removes handler-base binding and switch the markup with JS instead of seperate, handler & hander-selected bindings. MozReview-Commit-ID: 9W8IGNFkUVc
b03fd1004cac: Bug 1417883 - Allow theming autocomplete popups. r=jaws,ntim
Dylan Stokes <stokesdy@msu.edu> - Sun, 11 Feb 2018 12:32:33 -0500 - rev 461775
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1417883 - Allow theming autocomplete popups. r=jaws,ntim MozReview-Commit-ID: GITgsY3yYqN
a10eb278c3b2: Bug 1443229 - follow-up: use correct checkbox state, r=jaws
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Tue, 06 Mar 2018 15:00:12 +0000 - rev 461770
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1443229 - follow-up: use correct checkbox state, r=jaws It seems `doCommand` runs through a different codepath than just clicking the checkbox, and as a result the outcome of the command handler is different that way. This aligns the automated test closer to what happens when you 'manually' click the checkbox, and fixes the bug in the command handler. MozReview-Commit-ID: ACxRUxB35px
7958b0ccbe0b: Bug 1387976 - Persist tab-muted state across restarts of the browser. r=jaws
layely <ablayelyfondou@gmail.com> - Mon, 05 Mar 2018 01:22:23 +0000 - rev 461662
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1387976 - Persist tab-muted state across restarts of the browser. r=jaws
d0074d179c01: Bug 1432906 - Display notice in about:preferences when Policies are in use. r=gandalf,jaws
Felipe Gomes <felipc@gmail.com> - Mon, 05 Mar 2018 14:18:44 -0300 - rev 461630
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1432906 - Display notice in about:preferences when Policies are in use. r=gandalf,jaws MozReview-Commit-ID: 83UUY9DmK2K
c78fcb403361: Bug 1442961 - Remove the windowdragbox element and binding. r=jaws
Dão Gottwald <dao@mozilla.com> - Mon, 05 Mar 2018 14:54:03 +0100 - rev 461624
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1442961 - Remove the windowdragbox element and binding. r=jaws MozReview-Commit-ID: JZVMty8qMCP
f7f3f1c04fcd: Bug 1439734 - Allow WebExtension themes to set the tab line color. r=jaws
Tim Nguyen <ntim.bugs@gmail.com> - Sun, 04 Mar 2018 01:25:54 +0000 - rev 461500
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1439734 - Allow WebExtension themes to set the tab line color. r=jaws MozReview-Commit-ID: LbHGyaWfXze
65f5b5e79d2e: Bug 1434476 - Allow changing the background color of the selected tab. r=jaws
vinicius <viniciuscosta0197@gmail.com> - Fri, 02 Mar 2018 15:24:05 -0300 - rev 461456
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1434476 - Allow changing the background color of the selected tab. r=jaws *** MozReview-Commit-ID: 3GpBSWepNe3 ***
ba49cc6e4117: Bug 1442437 - Rename background_tab_text to tab_background_text. r=jaws
Tim Nguyen <ntim.bugs@gmail.com> - Thu, 01 Mar 2018 23:49:07 +0000 - rev 461236
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1442437 - Rename background_tab_text to tab_background_text. r=jaws MozReview-Commit-ID: LFXUqxuHbBb
c884294ea2dd: Bug 1441816 - Move mTabProgressListener into its own class. r=jaws
Dão Gottwald <dao@mozilla.com> - Thu, 01 Mar 2018 07:56:39 +0100 - rev 460916
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1441816 - Move mTabProgressListener into its own class. r=jaws MozReview-Commit-ID: Fj5MtThJvld
e34df42ebc27: Bug 1441692 - Add error option to the PaymentRequest debug panel. r=jaws
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Tue, 27 Feb 2018 14:37:15 -0800 - rev 460869
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1441692 - Add error option to the PaymentRequest debug panel. r=jaws MozReview-Commit-ID: 4lNi0B7tkyu
f6264884db15: Bug 1441877 - remove unused css variable --breakpoint-hover-background;r=jaws
Julian Descottes <jdescottes@mozilla.com> - Wed, 28 Feb 2018 17:09:55 +0100 - rev 460854
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1441877 - remove unused css variable --breakpoint-hover-background;r=jaws MozReview-Commit-ID: HhXMTo93QnJ
e78fb987e0b0: Bug 1437335 - Manual proxy port configuration should disable when its option is not selected, r=jaws
Bob Silverberg <bsilverberg@mozilla.com> - Tue, 27 Feb 2018 15:17:28 -0500 - rev 460847
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1437335 - Manual proxy port configuration should disable when its option is not selected, r=jaws This is a regression from bug 1429593. The code that was added to enable/disable controls on the page depending on whether an extension is in control was being run when the page opened, which overrode the code which disables specific controls based on the current proxy setting. All that is needed is to call that code (which is in gConnectionsDialog.proxyTypeChanged()) if an extension is not in control after the new code that was added. This patch fixes that issue, and includes a test verifying that the manual controls are not enabled when the screen first opens. MozReview-Commit-ID: 7jpp1wewZ2k
bea5b87950b7: Bug 1441830 - Clean up and simplify treechildren styling on Windows. r=jaws
Dão Gottwald <dao@mozilla.com> - Wed, 28 Feb 2018 18:16:00 +0100 - rev 460845
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1441830 - Clean up and simplify treechildren styling on Windows. r=jaws MozReview-Commit-ID: 5V3alTQkNdj
b8da99694cb6: Bug 1440877 - Remove mistyped --toolbar-gbimage variable. r=jaws
Dão Gottwald <dao@mozilla.com> - Wed, 28 Feb 2018 12:23:53 +0100 - rev 460717
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1440877 - Remove mistyped --toolbar-gbimage variable. r=jaws MozReview-Commit-ID: ARVa7hCHddX
9b1228043619: Bug 1435912 - Migrate Preferences::General XUL part to the new Localization API. r=flod,jaws
Zibi Braniecki <zbraniecki@mozilla.com> - Tue, 27 Feb 2018 21:20:54 -0800 - rev 460644
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1435912 - Migrate Preferences::General XUL part to the new Localization API. r=flod,jaws MozReview-Commit-ID: J5Rr8Gc0oCx
6ba30e000664: Bug 1435912 - Migrate Preferences::General XUL part to the new Localization API. r=flod,jaws
Zibi Braniecki <zbraniecki@mozilla.com> - Mon, 22 Jan 2018 15:38:06 -0800 - rev 460630
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1435912 - Migrate Preferences::General XUL part to the new Localization API. r=flod,jaws MozReview-Commit-ID: J5Rr8Gc0oCx
539f995aea77: Bug 1439930 Wrap long pref checkbox labels in Privacy prefs. r=jaws
Michael Kelly <mkelly@mozilla.com> - Thu, 22 Feb 2018 10:45:38 -0800 - rev 460624
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1439930 Wrap long pref checkbox labels in Privacy prefs. r=jaws Without any flex, the checkboxes in the Privacy section of about:preferences refused to wrap their text and caused the page width to expand to accommodate them, which made the search box and other elements move around while performing searches as the page width changed. Adding flex means the checkbox wraps text to the next line when the label is longer than the width can accommodate. MozReview-Commit-ID: HtJ3f3KrO3X
9ab890e2b9c5: Bug 1438925 - Select "Never check for updates" in Preferences UI when DisableAppUpdate policy is active r=jaws
Kirk Steuber <ksteuber@mozilla.com> - Fri, 16 Feb 2018 15:48:49 -0800 - rev 460620
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1438925 - Select "Never check for updates" in Preferences UI when DisableAppUpdate policy is active r=jaws MozReview-Commit-ID: 51ZaamngdIP
80d2fbdf93c0: Bug 1440843 - Don't dispatch shipping*change events if requestShipping is false. r=jaws
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Mon, 26 Feb 2018 22:03:26 -0800 - rev 460502
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1440843 - Don't dispatch shipping*change events if requestShipping is false. r=jaws MozReview-Commit-ID: 8HfO8UN0stE
fc6f924977b4: Bug 1417880: Allow theming arrow panels(popups). r=jaws,mconley,ntim
Connor Masini <cjmasini@gmail.com> - Wed, 07 Feb 2018 00:22:22 -0500 - rev 460231
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1417880: Allow theming arrow panels(popups). r=jaws,mconley,ntim MozReview-Commit-ID: 9f1sSzaGZzf
0ec115a54885: Bug 1440843 - Don't dispatch shipping*change events if requestShipping is false. r=jaws
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Sat, 24 Feb 2018 11:11:16 -0800 - rev 460204
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1440843 - Don't dispatch shipping*change events if requestShipping is false. r=jaws MozReview-Commit-ID: Cu74O0Reu4L
88503c645f6a: Bug 1429205 - Implement the Payment Request processing screen. r=jaws
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Thu, 22 Feb 2018 21:29:57 -0800 - rev 459986
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1429205 - Implement the Payment Request processing screen. r=jaws MozReview-Commit-ID: Kb4oRFV0SWA
9d9d274ee336: Bug 1429205 - Add a sendMessageToContent helper for paymentDialogWrapper. r=jaws
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Tue, 20 Feb 2018 15:56:33 -0800 - rev 459985
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1429205 - Add a sendMessageToContent helper for paymentDialogWrapper. r=jaws MozReview-Commit-ID: FgeQaOR5yno
3f8c4cb7982f: Bug 1429205 - Implement the Payment Request processing screen. r=jaws
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Thu, 22 Feb 2018 15:19:52 -0800 - rev 459941
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1429205 - Implement the Payment Request processing screen. r=jaws MozReview-Commit-ID: 8MZAtjxRHEa
ced4c7041d8e: Bug 1429205 - Add a sendMessageToContent helper for paymentDialogWrapper. r=jaws
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Tue, 20 Feb 2018 15:56:33 -0800 - rev 459940
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1429205 - Add a sendMessageToContent helper for paymentDialogWrapper. r=jaws MozReview-Commit-ID: FgeQaOR5yno
bc4c0d5fc569: Bug 1438702 - Skip test_credit_card_autofill_section when CC autofill is disabled. r=jaws
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Wed, 21 Feb 2018 23:00:08 -0800 - rev 459846
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1438702 - Skip test_credit_card_autofill_section when CC autofill is disabled. r=jaws MozReview-Commit-ID: B1qa9BhIa05
e96d94228dc8: Bug 1440082 - Make string in about:preferences more precise. r=jaws
Mike Conley <mconley@mozilla.com> - Wed, 21 Feb 2018 16:24:15 -0500 - rev 459740
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1440082 - Make string in about:preferences more precise. r=jaws MozReview-Commit-ID: GD2o13WA0Mj
ba1d6f897a92: Bug 1438180 - don't update the url bar search suggestions pref directly, r=jaws,f=myk
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Fri, 16 Feb 2018 17:30:34 +0000 - rev 459705
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1438180 - don't update the url bar search suggestions pref directly, r=jaws,f=myk In search.js, _updateSuggestionCheckboxes is already hooked up to update this checkbox based on the preference value, including change handlers for when it changes. As a result, having both the preference attribute and the 'manual' JS means that the actual checked and disabled state races with which code sets the value first. The search suggestion order preference already doesn't have a preference attribute and is only ever updated via the JS. It seems sensible to do the same here. MozReview-Commit-ID: Cm8evlembt7
29569f02015d: Bug 1417880: Allow theming arrow panels. r=jaws, ntim
Connor Masini <cjmasini@gmail.com> - Wed, 07 Feb 2018 00:22:22 -0500 - rev 459519
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1417880: Allow theming arrow panels. r=jaws, ntim
58d315ce1f1b: Bug 1404688 - Make headerURL optional and remove text-shadow when there is no headerURL. r=jaws
Tim Nguyen <ntim.bugs@gmail.com> - Thu, 15 Feb 2018 13:37:30 +0000 - rev 458946
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1404688 - Make headerURL optional and remove text-shadow when there is no headerURL. r=jaws MozReview-Commit-ID: 5x6SPWEJ3jp
e8d05c7218c6: Bug 1422160 - Merge cache and site data in about:preferences. r=jaws
Johann Hofmann <jhofmann@mozilla.com> - Tue, 13 Feb 2018 12:33:29 +0100 - rev 458935
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1422160 - Merge cache and site data in about:preferences. r=jaws This commit removes most of the cache section in about:preferences, following the UX concept from bug 1421690. This is in the general interest of de-cluttering privacy preferences and giving users controls that are easier to understand and use. The cache size is instead shown in the site data section and the cache can be cleared using the "Clear Data" button in that same section. MozReview-Commit-ID: 7PDTDgllFFI
067ee834b07b: Bug 1404688 - Make headerURL optional and remove text-shadow when there is no headerURL. r=jaws
Tim Nguyen <ntim.bugs@gmail.com> - Thu, 15 Feb 2018 02:30:44 +0000 - rev 458818
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1404688 - Make headerURL optional and remove text-shadow when there is no headerURL. r=jaws MozReview-Commit-ID: BWhStvcLpkL
7e74601cabde: Bug 1424682 - Migrate the chrome of Preferences to the new Localization API. r=flod,jaws
Zibi Braniecki <zbraniecki@mozilla.com> - Mon, 18 Dec 2017 23:19:13 -0800 - rev 458792
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1424682 - Migrate the chrome of Preferences to the new Localization API. r=flod,jaws MozReview-Commit-ID: ALnFUmnJMDB
1abd8bf0d997: Bug 1436165 - Change extensionControlled strings for home page and new tab page, r=jaws,mstriemer
Bob Silverberg <bsilverberg@mozilla.com> - Wed, 07 Feb 2018 14:03:23 -0500 - rev 458706
Push 1683 by sfraser@mozilla.com at 2018-04-26 16:43 +0000
Bug 1436165 - Change extensionControlled strings for home page and new tab page, r=jaws,mstriemer MozReview-Commit-ID: KcWiCm5nbeB