searching for reviewer(gl)
5bb5e54bc396b91e6d4d16f7e9f4ca1c6f0a5118: Bug 1552275 - Fix Copy Link context menu in DevTools Inspector markup view. r=gl a=pascalc
Razvan Caliman <rcaliman@mozilla.com> - Mon, 20 May 2019 16:03:00 +0000 - rev 526582
Push 2063 by archaeopteryx@coole-files.de at Fri, 07 Jun 2019 20:48:18 +0000
Bug 1552275 - Fix Copy Link context menu in DevTools Inspector markup view. r=gl a=pascalc - Fixes the references to the correct event handler & InspectorFront after a previous mass refactoring in Bug 1529364. - Augments a test to ensure the clipboard content is correct executing the context menu action to copy a link. Differential Revision: https://phabricator.services.mozilla.com/D31765
31dc14d0b906b79c5feb63a745bb05a71b93160b: Bug 1531584 - catch promise error when updating a11y menu item when DOMWalker connection is already closed. r=gl
Yura Zenevich <yura.zenevich@gmail.com> - Wed, 13 Mar 2019 15:44:55 +0000 - rev 525048
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1531584 - catch promise error when updating a11y menu item when DOMWalker connection is already closed. r=gl Differential Revision: https://phabricator.services.mozilla.com/D23321
f115573cf9a82f025084210a0379a0fc84e2436a: Bug 1529883 - Add telemetry instrumentation to count the number of invocations of the element picker. r=gl
Razvan Caliman <rcaliman@mozilla.com> - Thu, 07 Mar 2019 19:51:26 +0000 - rev 524544
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529883 - Add telemetry instrumentation to count the number of invocations of the element picker. r=gl Agreed with PM (mbalfanz@mozilla.com) about the intended behavior: number of invocations, not actual picks, is considered sufficient to answer the questions. Differential Revision: https://phabricator.services.mozilla.com/D22310
8ac8ed5ac77267bf88b54ec549c49a351858a8a7: Bug 1529762 - Update browser_page_style.js test to use a normal web page rather than a data URI. r=gl
Mike Conley <mconley@mozilla.com> - Fri, 08 Mar 2019 20:22:52 +0000 - rev 524180
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529762 - Update browser_page_style.js test to use a normal web page rather than a data URI. r=gl The PageStyleChild now only attaches to normal web pages. Differential Revision: https://phabricator.services.mozilla.com/D22614
783a57afe5b8b08a97cdea33bcb9648f0473ba43: Bug 1532855 - Ensure that highlightProperty does not highlight overridden computed properties. r=gl
Micah Tigley <mtigley@mozilla.com> - Wed, 06 Mar 2019 04:22:32 +0000 - rev 523494
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1532855 - Ensure that highlightProperty does not highlight overridden computed properties. r=gl Differential Revision: https://phabricator.services.mozilla.com/D22247
cb76b90f829c7687c981c4dcb1fde868167ce765: Bug 1398725 - Adds tooltip to offset parent indicator and moves ComputedProperty.js to boxmodel/components directory. r=gl
Danielle Leblanc-Cyr <danielleleb12@gmail.com> - Tue, 05 Mar 2019 11:49:12 -0500 - rev 523276
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1398725 - Adds tooltip to offset parent indicator and moves ComputedProperty.js to boxmodel/components directory. r=gl
81de709aaadd8c580d4dc341d71905dad618aeff: Bug 1493745 - Make the RDM toolbar responsive; r=gl
Patrick Brosset <pbrosset@mozilla.com> - Mon, 04 Mar 2019 16:26:18 +0000 - rev 523227
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1493745 - Make the RDM toolbar responsive; r=gl Differential Revision: https://phabricator.services.mozilla.com/D20827
774235c0e99fc6cf9ef916d65fc5dbf3b5817e53: Bug 1505297 - Remove unused BreadcrumbsWidget r=gl
ui.manish <1991manish.kumar@gmail.com> - Sat, 23 Feb 2019 20:37:12 +0000 - rev 523083
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1505297 - Remove unused BreadcrumbsWidget r=gl Differential Revision: https://phabricator.services.mozilla.com/D20932
ab22589d2ca01b739a7f784da6be45a5bf020b16: Bug 1505298 - Remove unused FastListWidget.js r=gl
ui.manish <1991manish.kumar@gmail.com> - Sat, 23 Feb 2019 20:27:14 +0000 - rev 523082
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1505298 - Remove unused FastListWidget.js r=gl Differential Revision: https://phabricator.services.mozilla.com/D20931
9b1e57540da771540bf6dc10be8c150582ee1b84: Bug 1530199 - Remove hasSupportsHighlighters check in supportsEyeDropper r=gl
lloan <lloanalas@outlook.com> - Thu, 28 Feb 2019 20:33:45 +0000 - rev 522859
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1530199 - Remove hasSupportsHighlighters check in supportsEyeDropper r=gl Cleans up the try statement of supportsEyeDropper https://searchfox.org/mozilla-central/source/devtools/client/inspector/inspector.js#1036 by removing the hasSupportsHighlighters check and simplifying it to do a single return: ``` return await this.inspector.supportsHighlighters() ``` Differential Revision: https://phabricator.services.mozilla.com/D21265
f5936ae0c1d6eee5777bc17d539b4db9d77d2ce7: Bug 1531419 - Address errors shown by React in dev mode for Font Editor; r=gl
Razvan Caliman <rcaliman@mozilla.com> - Thu, 28 Feb 2019 18:13:39 +0000 - rev 522820
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1531419 - Address errors shown by React in dev mode for Font Editor; r=gl - add `key` where necessary; - fix element attribute typos; - use consistent Number type for axis and font property values as defined by `propTypes`. Differential Revision: https://phabricator.services.mozilla.com/D21571
6a9be28daf6e47f812310a8b4f78153f8cf5b6a8: Bug 1531343 - Remove auto-increment from range inputs in Font Editor; r=gl
Razvan Caliman <rcaliman@mozilla.com> - Thu, 28 Feb 2019 18:15:38 +0000 - rev 522818
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1531343 - Remove auto-increment from range inputs in Font Editor; r=gl With @mbalfanz's permission, I am removing the auto-increment behavior from the range inputs in the Font Editor. The feature isn't easily discoverable and when it does work, its user experience isn't good. We never invested time to refine it and we're unlikely to do so. At this point, this is dead code so we should remove it. What is getting removed is the logic to support the esoteric auto-increment behavior which happens when dragging the range input thumb to the end of the slider and waiting for a while (1000ms). There's needless complexity in handling the concert of events for a little perceived user value. Users can still type out-of-range values in the text input field for the properties which allow it: `font-size` and `line-height`. For these properties' components, there's a new prop, `allowOverflow`, which permits values above the `max` defined. Other properties are bounded by `min` and `max` just like before. Differential Revision: https://phabricator.services.mozilla.com/D21534
e6ff2537e53c4bd7dc6578df6d803e748e0d8262: Bug 1529599 - (Part 2) Rename Copy Property Declaration to Copy Declaration in Rules panel context menu; r=gl
Razvan Caliman <rcaliman@mozilla.com> - Thu, 28 Feb 2019 17:31:54 +0000 - rev 522677
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529599 - (Part 2) Rename Copy Property Declaration to Copy Declaration in Rules panel context menu; r=gl Depends on D21526 This is a request from @mbalfanz in order to keep the naming of the option consistent. This patch just replaces the l10n string and renames all the places where copyPropertyDeclaration is used in order to avoid confusion. No functional changes are introduced. Differential Revision: https://phabricator.services.mozilla.com/D21527
357281e408cf32115a1306f7ca660cf8e6445301: Bug 1529599 - (Part 1) Add Copy Declaration to Changes panel context menu; r=gl
Razvan Caliman <rcaliman@mozilla.com> - Thu, 28 Feb 2019 17:30:02 +0000 - rev 522676
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529599 - (Part 1) Add Copy Declaration to Changes panel context menu; r=gl Adds a new option to the context menu which is visible only when it's invoked on a CSS declaration. Builds a string with the property name and value and copies to the clipboard. If the declaration is marked as removed, the string is wrapped in a comment block. Differential Revision: https://phabricator.services.mozilla.com/D21526
458fef0de61d8423533fbe452c2980d9f0861064: Bug 1530823 - Use pushPref to temporarily enable highlighting boxmodel properties in tests. r=gl
Micah Tigley <mtigley@mozilla.com> - Thu, 28 Feb 2019 18:12:28 +0000 - rev 522668
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1530823 - Use pushPref to temporarily enable highlighting boxmodel properties in tests. r=gl Differential Revision: https://phabricator.services.mozilla.com/D21573
8f8d66a61e23543ab5aa790e8a5a2996deaecaa7: Bug 1526054 - Set target node in Font Editor according to selected node type. r=gl
Razvan Caliman <rcaliman@mozilla.com> - Thu, 28 Feb 2019 11:16:13 +0000 - rev 522591
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1526054 - Set target node in Font Editor according to selected node type. r=gl Refactors the logic so the target node on which the Font Editor operates can point to a parent node in case of text nodes without explicitly changing the node selection. The target node is assigned to `this.node`. When that is null, it means the node selection is not supported by the Font Editor. This removes the need for the `isSelectedNodeValid()` method. Differential Revision: https://phabricator.services.mozilla.com/D21387
19b29b2e2f5e651518b4ca8e111c3c1dcf61b8c7: Bug 1526054 - Set target node in Font Editor according to selected node type. r=gl
Razvan Caliman <rcaliman@mozilla.com> - Wed, 27 Feb 2019 17:40:49 +0000 - rev 522361
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1526054 - Set target node in Font Editor according to selected node type. r=gl Refactors the logic so the target node on which the Font Editor operates can point to a parent node in case of text nodes without explicitly changing the node selection. The target node is assigned to `this.node`. When that is null, it means the node selection is not supported by the Font Editor. This removes the need for the `isSelectedNodeValid()` method. Differential Revision: https://phabricator.services.mozilla.com/D21387
f769684a0f39c3ddbba7ca56f3682b435be251eb: Bug 1530976 - Remove functionality to mark rules as selected in the Rules view. r=gl
Razvan Caliman <rcaliman@mozilla.com> - Wed, 27 Feb 2019 15:31:16 +0000 - rev 522358
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1530976 - Remove functionality to mark rules as selected in the Rules view. r=gl Differential Revision: https://phabricator.services.mozilla.com/D21344
ecf106e36d6ff5c995aff9d344cb630f7e7f2822: Bug 1530972 - Remove obsolete modifySelctor2 method from StyleRule actor, front and spec. r=gl
Razvan Caliman <rcaliman@mozilla.com> - Wed, 27 Feb 2019 15:33:33 +0000 - rev 522357
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1530972 - Remove obsolete modifySelctor2 method from StyleRule actor, front and spec. r=gl Differential Revision: https://phabricator.services.mozilla.com/D21342
ccfe228bff77703ea43e78e8107222736e389998: Bug 1530294 - Add option to skip cache when requesting authored text for CSS rule r=gl
Razvan Caliman <rcaliman@mozilla.com> - Tue, 26 Feb 2019 09:09:01 +0000 - rev 521922
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1530294 - Add option to skip cache when requesting authored text for CSS rule r=gl This patch adds a boolean option to skip the cached value of `StyeRuleActor.authoredText` and re-parse the stylesheet for its value. When changing content of a descendant rule inside an ancestor like @media or @select, the cached `authoredText` value is outdated. This yields incorrect data when requesting the complete rule authored text, hence the need for a cache-busting option. In addition to this change, there is a slight refactor to include the generated unique selector for the mock-rule for element inline styles. Differential Revision: https://phabricator.services.mozilla.com/D21033
ea28e78057d5a0492582727564e2220322a690a6: Bug 1530341 - (Part 2) Add Copy All Changes button to Changes panel. r=gl
Razvan Caliman <rcaliman@mozilla.com> - Mon, 25 Feb 2019 22:37:02 +0000 - rev 521876
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1530341 - (Part 2) Add Copy All Changes button to Changes panel. r=gl Depends on D21007 Adds a Copy All Changes button to the toolbar of the Changes panel. When pressed, this builds a stylesheet out of the changes for all sources tracked (stylesheets, element styles, etc) The output format is the same as the now defunct Bug 1524548 with the added code comment as separator between the sources. Differential Revision: https://phabricator.services.mozilla.com/D21008
d744e4b8444357f5507c22ced0da7e6dac2fe441: Bug 1530341 - (Part 1) Remove Copy Changes and Copy All Changes context menu options. r=gl
Razvan Caliman <rcaliman@mozilla.com> - Mon, 25 Feb 2019 22:34:31 +0000 - rev 521875
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1530341 - (Part 1) Remove Copy Changes and Copy All Changes context menu options. r=gl Remove the Copy All and Copy All Changes context menu options form the Changes panel context menu. As decided by PM & UX, they will be replaced with a single Copy All Changes button in the toolbar (part 2 of this series). Differential Revision: https://phabricator.services.mozilla.com/D21007
8a760030e793ae022a93bfc1b62e29686f7df5f6: Bug 1530341 - (Part 2) Add Copy All Changes button to Changes panel. r=gl
Razvan Caliman <rcaliman@mozilla.com> - Mon, 25 Feb 2019 17:45:47 +0000 - rev 521817
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1530341 - (Part 2) Add Copy All Changes button to Changes panel. r=gl Depends on D20808 Adds a Copy All Changes button to the toolbar of the Changes panel. When pressed, this builds a stylesheet out of the changes for all sources tracked (stylesheets, element styles, etc) The output format is the same as the now defunct Bug 1524548 with the added code comment as separator between the sources. Differential Revision: https://phabricator.services.mozilla.com/D21008
2c74db63f9aa20def8805cda096774d939ff5a78: Bug 1530341 - (Part 1) Remove Copy Changes and Copy All Changes context menu options. r=gl
Razvan Caliman <rcaliman@mozilla.com> - Mon, 25 Feb 2019 14:47:56 +0000 - rev 521816
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1530341 - (Part 1) Remove Copy Changes and Copy All Changes context menu options. r=gl Remove the Copy All and Copy All Changes context menu options form the Changes panel context menu. As decided by PM & UX, they will be replaced with a single Copy All Changes button in the toolbar (part 2 of this series). Differential Revision: https://phabricator.services.mozilla.com/D21007
d18e4e5cf3fa9c4b845b9fe073f28a157386a458: Bug 1493677 - Link box-model values to their source CSS rules. r=gl
Micah Tigley <mtigley@mozilla.com> - Mon, 25 Feb 2019 15:14:12 +0000 - rev 521780
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1493677 - Link box-model values to their source CSS rules. r=gl This patch allows hovering over box-model values and scrolling to their source CSS rule while pressing down the shift-key, Differential Revision: https://phabricator.services.mozilla.com/D18772
1549e3c7bc5161ad2d447f19b96c6d233c838698: Bug 1505299 - Remove unused SimpleListWidget r=gl
ui.manish <1991manish.kumar@gmail.com> - Sat, 23 Feb 2019 20:39:57 +0000 - rev 521644
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1505299 - Remove unused SimpleListWidget r=gl Differential Revision: https://phabricator.services.mozilla.com/D20928
0a4aefb36aff504e179121c8de0039c0df9e8106: Bug 1501962 - Expose a method from rule view that scrolls to a rule property's name and value. r=gl
Micah Tigley <mtigley@mozilla.com> - Thu, 21 Feb 2019 23:04:25 +0000 - rev 521465
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1501962 - Expose a method from rule view that scrolls to a rule property's name and value. r=gl Differential Revision: https://phabricator.services.mozilla.com/D15932
43dea2157ab5388cc8619c3e876970b64295c84b: Bug 1529468 - Remove devtools.inspector.fonthighlighter.enabled pref. r=gl
Rainier G <rainier.f.go@gmail.com> - Fri, 22 Feb 2019 00:22:01 -0500 - rev 521435
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529468 - Remove devtools.inspector.fonthighlighter.enabled pref. r=gl
9c4636d8d2ffb58001ccfc76c4ec5a529f068173: Bug 1529379 - Remove devtools.inspector.changes.enabled pref. r=gl
Rainier G <rainier.f.go@gmail.com> - Fri, 22 Feb 2019 00:05:34 -0500 - rev 521434
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529379 - Remove devtools.inspector.changes.enabled pref. r=gl
4cd86fe262ec5dc1bbd13db43256e9e31f838597: Bug 1524547 - (Part 2) Add context menu option to copy the contents of a changed CSS rule. r=gl
Razvan Caliman <rcaliman@mozilla.com> - Wed, 20 Feb 2019 21:45:03 +0000 - rev 521017
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1524547 - (Part 2) Add context menu option to copy the contents of a changed CSS rule. r=gl Depends on D20195 This series of patches depends on the patch from [Bug 1525238](https://bugzilla.mozilla.org/show_bug.cgi?id=1525238) - adds method to identify a CSS Rule actor by id - adds context menu option to the Changes panel to allow copying the rule's authored text to the clipboard Differential Revision: https://phabricator.services.mozilla.com/D20196
6c32c874b10280266f2b08d0fa051bc466245d9b: Bug 1524547 - (Part 1) Add method to StyleRuleActor to get complete authored text for a CSS rule. r=gl
Razvan Caliman <rcaliman@mozilla.com> - Wed, 20 Feb 2019 20:41:44 +0000 - rev 521016
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1524547 - (Part 1) Add method to StyleRuleActor to get complete authored text for a CSS rule. r=gl This series of patches depends on the patch from [Bug 1525238](https://bugzilla.mozilla.org/show_bug.cgi?id=1525238) This patch adds a new method to the StyleRuleActor on the server to expose the full text content of a CSS rule over the protocol to the client. This means exposing the CSS rule's authored text including comments and any nested rules if the target rule is an ancestor rule, like @media or @supports. There's minor refactoring to include additional rule types for which StyleRuleActors will be created: @supports, @media, @keyframes. These are not explicitly rendered in the Rule view and shouldn't impact it. The Rule view filters for CSS Style Rules, element inline style and has special handling for keyframe at-rules. Differential Revision: https://phabricator.services.mozilla.com/D20195
2c56f5c1d4fa06a7242a0e0d97b8beb392158466: Bug 1528739 - Don't load CSS properties by default; r=gl.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 20 Feb 2019 09:01:03 +0000 - rev 520920
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1528739 - Don't load CSS properties by default; r=gl. If the cssProperties config wasn't provided, the Editor was loading getClientCssProperties, which loads properties-db which is quite large. Since the Style Editor is providing a cssProperties config, this was done for all the other consumers, none of them actually having any use of it. We remove this default behaviour which allows us to speed up panel/source opening quite significantly. Differential Revision: https://phabricator.services.mozilla.com/D20305
8c892403c16f7e27965028804f680f7f36352d70: Bug 1528910 - Remove unused externalScripts from source editor config; r=gl.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Tue, 19 Feb 2019 14:57:46 +0000 - rev 520786
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1528910 - Remove unused externalScripts from source editor config; r=gl. This config is not set by any Editor consumer, so it's safe to remove it. Furthermore, this allow us to clean things up a bit and remove a test. Differential Revision: https://phabricator.services.mozilla.com/D20302
0c72849843c8658d93487ffd981df30ebbadd823: Bug 1528608 - Fix Inspector tooltip typo. r=gl
Razvan Caliman <rcaliman@mozilla.com> - Mon, 18 Feb 2019 15:58:59 +0000 - rev 520671
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1528608 - Fix Inspector tooltip typo. r=gl Ensures the keyboard shortcut on **non-macOS platforms** is completely wrapped inside the parentheses of the tooltip label. Differential Revision: https://phabricator.services.mozilla.com/D20140
16a5ff10a90f51290d53a8828c838d994cf646c2: Bug 1519217 - Add keyboard shortcut to element picker tooltip. r=gl,flod
Razvan Caliman <rcaliman@mozilla.com> - Mon, 18 Feb 2019 12:28:14 +0000 - rev 520659
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1519217 - Add keyboard shortcut to element picker tooltip. r=gl,flod Augments tooltip with keyboard shortcut. Reflects the multiple shortcuts possible on macOS as seen in the Inspector tab tooltip. See: https://developer.mozilla.org/en-US/docs/Tools/Keyboard_shortcuts#Opening_and_closing_tools Differential Revision: https://phabricator.services.mozilla.com/D19407
02169a9e2fda754c41ad83addd4912d421c569e5: Bug 1527898 - Override find and replace commands when disableSearchAddon is true; r=gl.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 18 Feb 2019 04:35:42 +0000 - rev 520606
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1527898 - Override find and replace commands when disableSearchAddon is true; r=gl. This is an hotfix for the bug, which we want to uplift. A better fix will happen in Bug 1527903. Depends on D19963 Differential Revision: https://phabricator.services.mozilla.com/D19965
e5a0d37ff12ca8a5cb8b88641a495137778a3663: Bug 1527898 - Turn sourceditor `setup` test helper async; r=gl.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 18 Feb 2019 06:13:29 +0000 - rev 520605
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1527898 - Turn sourceditor `setup` test helper async; r=gl. The function was returning a Promise but was also taking a callback for old-style test. This patch turns the function into an async one, remove the callback param and refactor tests that relied on it. Differential Revision: https://phabricator.services.mozilla.com/D19963
5e40a4baa30b6d2623c9a4186c52c791a58d0fbf: Bug 1527322 - Move the sourceeditor folder under devtools/client/shared; r=gl.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 13 Feb 2019 15:37:08 +0000 - rev 519781
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1527322 - Move the sourceeditor folder under devtools/client/shared; r=gl. Differential Revision: https://phabricator.services.mozilla.com/D19641
b8b41d21886624db60c4e12f2ddc66d681b02782: Bug 1518487 - implement ColorContrast component to display a11y audit information for text color contrast. r=gl
Yura Zenevich <yura.zenevich@gmail.com> - Tue, 12 Feb 2019 19:40:11 +0000 - rev 519668
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1518487 - implement ColorContrast component to display a11y audit information for text color contrast. r=gl MozReview-Commit-ID: DoOp2JhaQyD Differential Revision: https://phabricator.services.mozilla.com/D19053
7fe5ccd66c8fd25fd9d8648f8b39fa47d8e27482: Bug 1518487 - add ability to customize the className of the LearnMoreLink component. r=gl
Yura Zenevich <yura.zenevich@gmail.com> - Tue, 12 Feb 2019 19:39:22 +0000 - rev 519664
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1518487 - add ability to customize the className of the LearnMoreLink component. r=gl MozReview-Commit-ID: 2Ft28e4sbi Differential Revision: https://phabricator.services.mozilla.com/D19049
0f1f38a6dd4d4f837ae788a61af1b5b1bf6f6ad4: Bug 1527309 - Log CSS rule ancestors in reverse order. r=gl
Razvan Caliman <rcaliman@mozilla.com> - Tue, 12 Feb 2019 14:45:38 +0000 - rev 519633
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1527309 - Log CSS rule ancestors in reverse order. r=gl Differential Revision: https://phabricator.services.mozilla.com/D19495
8031278b4a170b154bd6f17e9e08e609935126a3: Bug 1518487 - implement ColorContrast component to display a11y audit information for text color contrast. r=gl
Yura Zenevich <yura.zenevich@gmail.com> - Mon, 11 Feb 2019 20:46:23 +0000 - rev 519452
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1518487 - implement ColorContrast component to display a11y audit information for text color contrast. r=gl MozReview-Commit-ID: DoOp2JhaQyD Differential Revision: https://phabricator.services.mozilla.com/D19053
62f78c63d9f1a5ca9232b94202657e73d8fb7190: Bug 1518487 - add ability to customize the className of the LearnMoreLink component. r=gl
Yura Zenevich <yura.zenevich@gmail.com> - Mon, 11 Feb 2019 20:45:19 +0000 - rev 519448
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1518487 - add ability to customize the className of the LearnMoreLink component. r=gl MozReview-Commit-ID: 2Ft28e4sbi Differential Revision: https://phabricator.services.mozilla.com/D19049
6f1ebd9774c73cec51dd3af144d48e82e4cdb1df: Bug 1527004 - Add context menu option to Changes panel to copy all changes for a source. r=gl
Razvan Caliman <rcaliman@mozilla.com> - Mon, 11 Feb 2019 20:02:44 +0000 - rev 519438
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1527004 - Add context menu option to Changes panel to copy all changes for a source. r=gl Like Bug 1524548, but builds a stylesheet for all changed rules within a source. Differential Revision: https://phabricator.services.mozilla.com/D19385
6886f5504885ebb03168ec56581b692a86d26211: Bug 1526057: Adjust a test to remove reference to no-longer-recognized devtools fonteditor pref. r=gl
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 08 Feb 2019 01:53:29 +0000 - rev 518554
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1526057: Adjust a test to remove reference to no-longer-recognized devtools fonteditor pref. r=gl Differential Revision: https://phabricator.services.mozilla.com/D19078
69f78374b0b2ee4860bc3e4e323afa6b164dad83: Bug 1524548 - (Part 3) Add option to Changes panel context menu to copy changes. r-gl r=gl
Razvan Caliman <rcaliman@mozilla.com> - Wed, 06 Feb 2019 19:07:42 +0000 - rev 518512
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1524548 - (Part 3) Add option to Changes panel context menu to copy changes. r-gl r=gl Depends on D18704 Adds a new option to the context menu to copy the changes for a rule as valid CSS text. Removed properties are commented out. Added properties are used as-is. Style source information is listed as a code comment above the CSS rule. Makes use of the new Redux selector introduced in Part 2 (see D18704) to build a stylesheet text with the changes per-rule. That will be reused for copying all changes per-stylesheet. Moves the copy text selection handler out to the ChangesView to co-locate it with other (upcoming) copy actions. Adds data-ruleid and data-sourceid to DOM elements to help match the target element to the rule/source in the Redux store. Differential Revision: https://phabricator.services.mozilla.com/D18706
6059b24342142db033db72eeae6cc39bad7e2b52: Bug 1523305 - Show Font Editor in read-only mode for pseudo-elements. r=gl
Razvan Caliman <rcaliman@mozilla.com> - Mon, 04 Feb 2019 12:05:23 +0000 - rev 517490
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1523305 - Show Font Editor in read-only mode for pseudo-elements. r=gl Adds a new `disabled` property to the Font Editor Redux store applicable to all input fields. When inspecting a pseudo-element, this `disabled` property is set to true. This allows the pseudo-element to be inspected, but prevents editing font property values because it's currently not possible to write them back to CSS rules other than element inline styles. Differential Revision: https://phabricator.services.mozilla.com/D18364
f4893bab56d5eeb0b468329d885f29eeb51d7aa4: Bug 1523909 - Simplifying the scrollable badge to just scroll; r=gl
Patrick Brosset <pbrosset@mozilla.com> - Fri, 01 Feb 2019 10:10:21 +0000 - rev 517271
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1523909 - Simplifying the scrollable badge to just scroll; r=gl Differential Revision: https://phabricator.services.mozilla.com/D18093
f5a80ba028f1475a1371d2d0f821db737159f66f: Bug 1524369 - Update moz..build files to use the new Inspector Bugzilla components r=gl
Sebastian Hengst <archaeopteryx@coole-files.de> - Thu, 31 Jan 2019 19:31:40 +0000 - rev 517178
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1524369 - Update moz..build files to use the new Inspector Bugzilla components r=gl The components got renamed or added in bug 1523779. Differential Revision: https://phabricator.services.mozilla.com/D18259
eb36b503f7059c923233bb81d094351296aa8008: Bug 1522843 - Add telemetry configuration and instrumentation to Changes panel to measure usage of context menu and copy action. r=gl
Razvan Caliman <rcaliman@mozilla.com> - Tue, 29 Jan 2019 11:53:38 +0000 - rev 516742
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1522843 - Add telemetry configuration and instrumentation to Changes panel to measure usage of context menu and copy action. r=gl Adds three new scalars for counting the numer of times: - the default copy action is triggered, regardless of method - the context menu is shown - the copy option from the context menu is used Differential Revision: https://phabricator.services.mozilla.com/D17667