searching for reviewer(gchang)
0e762fc7cb7446469e69b47932cbbdeccf50ecb2: Bug 1414789: Backout Stylo DOM APIs from beta. r=xidorn a=gchang
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 01 Feb 2018 14:38:05 +1100 - rev 454605
Push 1648 by mtabara@mozilla.com at Thu, 01 Mar 2018 12:45:47 +0000
Bug 1414789: Backout Stylo DOM APIs from beta. r=xidorn a=gchang MozReview-Commit-ID: BW5BZpC63B8
05f9d3f417524ae6a4b8438a3c29b21d014e0da6: Bug 1429885 Support a rounding value of 0 for reduceTimerPrecision r=bkelly,timhuang a=gchang
Tom Ritter <tom@mozilla.com> - Thu, 11 Jan 2018 14:25:14 -0600 - rev 453239
Push 1648 by mtabara@mozilla.com at Thu, 01 Mar 2018 12:45:47 +0000
Bug 1429885 Support a rounding value of 0 for reduceTimerPrecision r=bkelly,timhuang a=gchang MozReview-Commit-ID: F96EUfXgK9F
6af0590440039c44a5299a8432a0b9f3e1566b13: Bug 1429859 - Check mDoNotTryEarlyData in Do0RTT(). r=mcmanus a=gchang
Dragana Damjanovic dd.mozilla@gmail.com - Thu, 11 Jan 2018 10:17:00 +0200 - rev 453238
Push 1648 by mtabara@mozilla.com at Thu, 01 Mar 2018 12:45:47 +0000
Bug 1429859 - Check mDoNotTryEarlyData in Do0RTT(). r=mcmanus a=gchang
912e6c9630a185d5f14388704a11c5e5ac8f2fec: Bug 1426081 - Migrate legacy search engines to WebExtensions. r=florian a=gchang
Michael Kaply <mozilla@kaply.com> - Thu, 21 Dec 2017 12:58:56 -0600 - rev 453237
Push 1648 by mtabara@mozilla.com at Thu, 01 Mar 2018 12:45:47 +0000
Bug 1426081 - Migrate legacy search engines to WebExtensions. r=florian a=gchang MozReview-Commit-ID: JfSwJwMC46F
04728698613cacf16253dd7fabf22f596c5b6044: Bug 1431282. Work around layout violating its own invariants and causing stylo code to crash, _again_. r=emilio, a=gchang
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 03 Oct 2017 18:50:10 -0400 - rev 445681
Push 1628 by bzbarsky@mozilla.com at Thu, 18 Jan 2018 03:26:29 +0000
Bug 1431282. Work around layout violating its own invariants and causing stylo code to crash, _again_. r=emilio, a=gchang MozReview-Commit-ID: 3ggJI0qmOJV
571ae115f2de6aedeb1de20a80a81b4067219921: bug 1429666 cubeb_resampler_speex: don't call data callback while draining r=padenot a=gchang
Karl Tomlinson <karlt+@karlt.net> - Thu, 11 Jan 2018 13:30:24 +1300 - rev 445679
Push 1626 by archaeopteryx@coole-files.de at Wed, 17 Jan 2018 10:41:52 +0000
bug 1429666 cubeb_resampler_speex: don't call data callback while draining r=padenot a=gchang MozReview-Commit-ID: 1XEzZjPGai9
7151850b2933e3ae6e41435461545db63b6591c9: Bug 1421345 - Check the canary during allocations. r=jet a=gchang
Matt Woodrow <mwoodrow@mozilla.com> - Wed, 17 Jan 2018 12:07:34 +1300 - rev 445678
Push 1626 by archaeopteryx@coole-files.de at Wed, 17 Jan 2018 10:41:52 +0000
Bug 1421345 - Check the canary during allocations. r=jet a=gchang
aba167b6e63f27f9b10ce8805b4e02d8b0a79035: Bug 1401459 - always run HttpChannelChild::Release on main thread. r=mayhemer a=gchang
Shih-Chiang Chien <schien@mozilla.com> - Thu, 11 Jan 2018 10:40:29 +0800 - rev 445677
Push 1626 by archaeopteryx@coole-files.de at Wed, 17 Jan 2018 10:41:52 +0000
Bug 1401459 - always run HttpChannelChild::Release on main thread. r=mayhemer a=gchang
5096a6c3aefd858af15facdd31b53d8f57baf061: Bug 1430522 - [Form Autofill] Enable address autofill by default on release build. r=seanlee a=gchang
Luke Chang <lchang@mozilla.com> - Mon, 15 Jan 2018 15:56:53 +0800 - rev 445676
Push 1626 by archaeopteryx@coole-files.de at Wed, 17 Jan 2018 10:41:52 +0000
Bug 1430522 - [Form Autofill] Enable address autofill by default on release build. r=seanlee a=gchang MozReview-Commit-ID: 9Pf8l7PqSMi
814254bd1eb76533621eea0700d0182aa3121350: Bug 1421345 - Check the canary during allocations. r=jet a=gchang
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 15 Jan 2018 21:12:57 +1300 - rev 445674
Push 1624 by archaeopteryx@coole-files.de at Mon, 15 Jan 2018 11:39:32 +0000
Bug 1421345 - Check the canary during allocations. r=jet a=gchang
4c230b89e05e6a4d87d3f26e2ca862dd59e617d0: Bug 1429885 Support a rounding value of 0 for reduceTimerPrecision r=bkelly,timhuang a=gchang
Tom Ritter <tom@mozilla.com> - Thu, 11 Jan 2018 14:25:14 -0600 - rev 445673
Push 1623 by archaeopteryx@coole-files.de at Mon, 15 Jan 2018 09:33:19 +0000
Bug 1429885 Support a rounding value of 0 for reduceTimerPrecision r=bkelly,timhuang a=gchang MozReview-Commit-ID: F96EUfXgK9F
f99b1d9d900687eeb166ec6ddcb50fd005d85513: Bug 1429859 - Check mDoNotTryEarlyData in Do0RTT(). r=mcmanus a=gchang
Dragana Damjanovic dd.mozilla@gmail.com - Thu, 11 Jan 2018 10:17:00 +0200 - rev 445672
Push 1623 by archaeopteryx@coole-files.de at Mon, 15 Jan 2018 09:33:19 +0000
Bug 1429859 - Check mDoNotTryEarlyData in Do0RTT(). r=mcmanus a=gchang
ae6c87e225d3820393a4b727be87a5a837205d72: Bug 1427221 - Do nsMathMLmfencedFrame cleanup in DestroyFrom, not in the dtor. r=mattwoodrow a=gchang
Mats Palmgren <mats@mozilla.com> - Tue, 09 Jan 2018 04:32:00 +0200 - rev 445671
Push 1623 by archaeopteryx@coole-files.de at Mon, 15 Jan 2018 09:33:19 +0000
Bug 1427221 - Do nsMathMLmfencedFrame cleanup in DestroyFrom, not in the dtor. r=mattwoodrow a=gchang
e47207b8927fc7ae26a77e6a6bb57f258b516946: Bug 1426081 - Migrate legacy search engines to WebExtensions. r=florian a=gchang
Michael Kaply <mozilla@kaply.com> - Thu, 21 Dec 2017 12:58:56 -0600 - rev 445670
Push 1623 by archaeopteryx@coole-files.de at Mon, 15 Jan 2018 09:33:19 +0000
Bug 1426081 - Migrate legacy search engines to WebExtensions. r=florian a=gchang MozReview-Commit-ID: JfSwJwMC46F
dd18bd878644487d20fc5358d2fd924e1dda0825: Bug 1416879 - Part 0d: Move browser_multie10s_update.js into its own directory. r=bkelly a=gchang
Andrew Sutherland <asutherland@asutherland.org> - Thu, 11 Jan 2018 10:31:17 -0500 - rev 445669
Push 1623 by archaeopteryx@coole-files.de at Mon, 15 Jan 2018 09:33:19 +0000
Bug 1416879 - Part 0d: Move browser_multie10s_update.js into its own directory. r=bkelly a=gchang This test is unfortunately a victim of a multi-e10s unregister() race from browser_force_refresh and given the imminent multi-e10s cleanup that's going to happen, the more complicated alternatives aren't worth the effort versus just moving this test to its own directory. ..and now it's disabled too. Bug 1429794 tracks re-enabling.
53c59a717ff04053ea958dd7a752281ec01b291b: Bug 1416879 - Part 0c: browser_multie10s_update.js should not use setTimeout. r=bkelly a=gchang
Andrew Sutherland <asutherland@asutherland.org> - Tue, 09 Jan 2018 17:31:01 -0500 - rev 445668
Push 1623 by archaeopteryx@coole-files.de at Mon, 15 Jan 2018 09:33:19 +0000
Bug 1416879 - Part 0c: browser_multie10s_update.js should not use setTimeout. r=bkelly a=gchang This test used a fixed setTimeout of 3secs for serving the SW. This lower-bounded the test runtime at 6 seconds, plus it was not safe in the event of a slow test runner. This set of changes, although a little ugly, improves the logic so that the SW's transmission is driven by a separate "release" fetch that is only triggered when both updates have been issued and the first update failure has been reported. This ensures we are observing the desired situation. There's also a sanity check on the number of times the SW script is fetched.
3196b9ada4f4a2581d6b68511d71f9067dc3117f: Bug 1416879 - Part 0b: browser_multie10s_update.js needs to protect its invariants, clean-up after itself. r=bkelly a=gchang
Andrew Sutherland <asutherland@asutherland.org> - Tue, 09 Jan 2018 16:16:24 -0500 - rev 445667
Push 1623 by archaeopteryx@coole-files.de at Mon, 15 Jan 2018 09:33:19 +0000
Bug 1416879 - Part 0b: browser_multie10s_update.js needs to protect its invariants, clean-up after itself. r=bkelly a=gchang
c77831e4963620a76663c9b23cc12c496fb4f651: Bug 1416879 - Part 0a: Make browser_force_refresh.js clean up after itself. r=bkelly a=gchang
Andrew Sutherland <asutherland@asutherland.org> - Wed, 10 Jan 2018 12:38:25 -0500 - rev 445666
Push 1623 by archaeopteryx@coole-files.de at Mon, 15 Jan 2018 09:33:19 +0000
Bug 1416879 - Part 0a: Make browser_force_refresh.js clean up after itself. r=bkelly a=gchang
7db765b809466c034cec79439f3c5f03ee0fc516: Bug 1416879 - Part 6: Test cancellation of diverted client-intercepted streams. r=bkelly a=gchang
Andrew Sutherland <asutherland@asutherland.org> - Thu, 04 Jan 2018 18:38:43 -0500 - rev 445665
Push 1623 by archaeopteryx@coole-files.de at Mon, 15 Jan 2018 09:33:19 +0000
Bug 1416879 - Part 6: Test cancellation of diverted client-intercepted streams. r=bkelly a=gchang This adds a test where we have a ServiceWorker return 2 different types of streams that Firefox recognizes as downloads which are handled by diversion of the channel to the parent. The diverted downloads are then cancelled and we verify that cancellation actually results in the underlying connections being closed and/or the ServiceWorker notified. Our 2 types of streams are: 1. A pass-through stream that is incrementally delivered through use of an .sjs file that delivers data using setInterval. 2. A SW-authored ReadableStream (which is not enabled by default, so we set a pref.) Determining when the .sjs's stream is canceled is accomplished by opening a second "monitor" connection that only completes when the streaming connection is closed. In all cases we differentiate between cancelation and timeouts firing.
4e914143668dc37aea74225b3b2c3c1436a06f28: Bug 1416879 - Part 5: FetchStreamReader needs to cancel its reader when it encounters write errors. r=baku, f=bkelly a=gchang
Andrew Sutherland <asutherland@asutherland.org> - Thu, 04 Jan 2018 18:09:32 -0500 - rev 445664
Push 1623 by archaeopteryx@coole-files.de at Mon, 15 Jan 2018 09:33:19 +0000
Bug 1416879 - Part 5: FetchStreamReader needs to cancel its reader when it encounters write errors. r=baku, f=bkelly a=gchang Currently, FetchStreamReader never signals to the JS stream code that the reader has been closed. This means that when a ServiceWorker passes a ReadableStream to respondWith and the HTTP Channel gets canceled, the JS code will keep generating the stream without ever realizing the data's not going anywhere. It's necessary to cancel the reader. Or do something like that, this seems to work!
8c317ab88b7661c41516747a0d6569c36706921b: Bug 1416879 - Part 4: FetchDriver needs to propagate write failures. r=baku a=gchang
Andrew Sutherland <asutherland@asutherland.org> - Thu, 04 Jan 2018 18:04:55 -0500 - rev 445663
Push 1623 by archaeopteryx@coole-files.de at Mon, 15 Jan 2018 09:33:19 +0000
Bug 1416879 - Part 4: FetchDriver needs to propagate write failures. r=baku a=gchang In the scenario where a ServiceWorker returns a pass-through fetch via `evt.respondWith(fetch("underlying"))`, in order for the "underlying" HTTP channel to be canceled when the outer HTTP channel is canceled, FetchDriver's OnDataAvailable method needs to return an error when the output pipe experiences an error. Unfortunately, the contract for ReadSegments is effectively that it returns NS_OK regardless of what the rv of the write handler returned, so relying on the returned rv is insufficient. And because various Write*() methods will all fast-path to returning NS_OK if a count of 0 is passed, it's necessary to infer a closed/broken pipe by noticing that we tried to write more than 0 bytes of data but 0 bytes were written. (This is safe because the pipe we write into was created by FetchDriver::OnStartRequest which explicitly creates an infinite pipe, so it's not possible for the write to fail due to lack of space in the pipe.)
0c95b7733c659823ab34ad34469fc9bbdad0d0e4: Bug 1416879 - Part 3: (Also Bug 1418795) SyntheticDiversionListener should handle !mIPCOpen. r=bkelly a=gchang
Andrew Sutherland <asutherland@asutherland.org> - Thu, 04 Jan 2018 13:59:13 -0500 - rev 445662
Push 1623 by archaeopteryx@coole-files.de at Mon, 15 Jan 2018 09:33:19 +0000
Bug 1416879 - Part 3: (Also Bug 1418795) SyntheticDiversionListener should handle !mIPCOpen. r=bkelly a=gchang The SyntheticDiversionListener needs to handle the case where the IPC connection is gone. This patch avoids calling Send* methods which will crash the content process if the actor has already been destroyed. Additionally, OnDataAvailable will return an error in such a case so that the caller can properly handle the error rather than continuing to attempt to send data to a listener that doesn't care. This latter change is an artifact of a previous hack attempt to fix a related diversion issue that is probably not required for this stack, but makes sense as a fix, so I've left it in.
721cbc4debf789ebe92960e0c96615401125c2d7: Bug 1416879 - Part 2: Allow for diversion cancellation and trigger for intercepted channels. r=bkelly, r=mayhemer a=gchang
Andrew Sutherland <asutherland@asutherland.org> - Thu, 04 Jan 2018 18:38:07 -0500 - rev 445661
Push 1623 by archaeopteryx@coole-files.de at Mon, 15 Jan 2018 09:33:19 +0000
Bug 1416879 - Part 2: Allow for diversion cancellation and trigger for intercepted channels. r=bkelly, r=mayhemer a=gchang The diversion mechanism never expected to be dealing with data sourced from the content process, but that's exactly what happens with ServiceWorker-intercepted channels with the current child-intercept situation (which is being fixed). In order to allow timely cancellation of diverted intercepted channels, there needs to be a way to relay to the HttpChannelChild that it needs to be canceled so that the synthesized pump can be canceled and diversion can be marked as complete. This patch adds such a mechanism to ADivertableParentChannel and PHttpChannel for the exclusive use of InterceptedHttpChannel and then uses it.
b855bb9f21232d7291b2256e1a275259c4ee4577: Bug 1416879 - Part 1: DivertComplete should only be sent at OnStopRequest for synthesized responses. r=bkelly a=gchang
Andrew Sutherland <asutherland@asutherland.org> - Thu, 04 Jan 2018 18:56:46 -0500 - rev 445660
Push 1623 by archaeopteryx@coole-files.de at Mon, 15 Jan 2018 09:33:19 +0000
Bug 1416879 - Part 1: DivertComplete should only be sent at OnStopRequest for synthesized responses. r=bkelly a=gchang Diversion for intercepted channels with a synthesized response is a special case. It is not appropriate to send DivertComplete when mEventQ has been drained, because we are not dealing with the usual mEventQ-enqueued OnDataAvailable payloads that had been received over the network and sent down to the child. In this case, all the data originates in the child and does not go through mEventQ. As such, the correct place to send DivertComplete is at OnStopComplete for the synthesized response.
f3d0dfafa490db5c8b700ef8d16cc97dc28d7901: Bug 1424341 Add privacy.reduceTimerPrecision and privacy.reduceTimerPrecision.microseconds prefs and tests r=bkelly,timhuang,mrbkap a=gchang
Tom Ritter <tom@mozilla.com> - Wed, 10 Jan 2018 13:50:28 -0600 - rev 445659
Push 1622 by archaeopteryx@coole-files.de at Sat, 13 Jan 2018 00:08:59 +0000
Bug 1424341 Add privacy.reduceTimerPrecision and privacy.reduceTimerPrecision.microseconds prefs and tests r=bkelly,timhuang,mrbkap a=gchang This pref does not override privacy.resistFingerprinting, but when it is set (and privacy.resistFingerprinting is not) we will still adjust the precision of almost all timers. The adjustment amount is the second pref, which is defaulted to 20us but now dynamically adjustable (in the scale of microseconds.) We are landing this preffed off at the current value we clamp performance.now() at which is 20us. This commit is the combination of the multiple commits listed in Bug 1424341
848733c4f4dee8747d1f1d6b388e4dcf7099099f: Bug 1429133 - Some FontExplorer managed fonts are not rendered. r=Alex_Gaynor a=gchang
Haik Aftandilian <haftandilian@mozilla.com> - Wed, 10 Jan 2018 11:33:47 -0800 - rev 445658
Push 1622 by archaeopteryx@coole-files.de at Sat, 13 Jan 2018 00:08:59 +0000
Bug 1429133 - Some FontExplorer managed fonts are not rendered. r=Alex_Gaynor a=gchang MozReview-Commit-ID: L5x3GNb3HGU
1f97fc614f9ea844d2e9cc8dc5e869cffee86913: Bug 1426500 - Part 2: Update test_interfaces mochitest to expect WebVR interfaces to be disabled on release builds for macOS. r=smaug, a=gchang
Kearwood "Kip" Gilbert <kgilbert@mozilla.com> - Thu, 11 Jan 2018 15:13:58 -0800 - rev 445657
Push 1622 by archaeopteryx@coole-files.de at Sat, 13 Jan 2018 00:08:59 +0000
Bug 1426500 - Part 2: Update test_interfaces mochitest to expect WebVR interfaces to be disabled on release builds for macOS. r=smaug, a=gchang
ace563efaa9917538660c474ab5b261fd4f0132e: Bug 1426500 - Disable WebVR for macOS on Beta and Release r=daoshengmu a=gchang
Kearwood "Kip" Gilbert <kgilbert@mozilla.com> - Wed, 10 Jan 2018 16:14:21 -0800 - rev 445656
Push 1622 by archaeopteryx@coole-files.de at Sat, 13 Jan 2018 00:08:59 +0000
Bug 1426500 - Disable WebVR for macOS on Beta and Release r=daoshengmu a=gchang - WebVR will continue to be enabled on macOS for Nightly and Dev Edition MozReview-Commit-ID: LpEX13yZVbb
f2c70b72815832065e939a921adc1d6a3f557f51: Bug 1425509 - Initialize PerformanceService in RuntimeService, r=bkelly a=gchang
Andrea Marchesini <amarchesini@mozilla.com> - Mon, 18 Dec 2017 17:49:54 +0100 - rev 445655
Push 1622 by archaeopteryx@coole-files.de at Sat, 13 Jan 2018 00:08:59 +0000
Bug 1425509 - Initialize PerformanceService in RuntimeService, r=bkelly a=gchang
f4256fe890db1e8d88f4bfea958e419f5ee88b75: Bug 1425612 - Better error messages for invalid structured clone data. r=sfink, a=gchang.
Jason Orendorff <jorendorff@mozilla.com> - Wed, 10 Jan 2018 20:45:39 -0600 - rev 445654
Push 1621 by jorendorff@mozilla.com at Fri, 12 Jan 2018 21:00:31 +0000
Bug 1425612 - Better error messages for invalid structured clone data. r=sfink, a=gchang.
d70260efa9014713bccb0f8a42b954ff352c7d45: Bug 1426783 - Fix error handling in deserialization of invalid typed arrays. r=sfink, a=gchang.
Jason Orendorff <jorendorff@mozilla.com> - Fri, 05 Jan 2018 15:17:35 -0600 - rev 445653
Push 1621 by jorendorff@mozilla.com at Fri, 12 Jan 2018 21:00:31 +0000
Bug 1426783 - Fix error handling in deserialization of invalid typed arrays. r=sfink, a=gchang.
3ebefc043ac67bc941f8e74182d3ba8fdc9419f4: Bug 1417741 Add support of Atomic<> for Preferences::Add*VarCache r=baku,njn a=gchang
Tom Ritter <tom@mozilla.com> - Wed, 20 Dec 2017 14:39:27 -0600 - rev 445652
Push 1620 by archaeopteryx@coole-files.de at Fri, 12 Jan 2018 20:17:17 +0000
Bug 1417741 Add support of Atomic<> for Preferences::Add*VarCache r=baku,njn a=gchang This is a partial backport of Bug 1417741 that only adds AddAtomicBoolVarCache because that is all we need.
494218c56c7eb448d61c1c803342881f27686ca7: Bug 1417431 - secureConnectionStart should be 0 for pages with HTTP scheme. r=bkelly a=gchang
Dragana Damjanovic <dd.mozilla@gmail.com> - Wed, 06 Dec 2017 12:57:28 +0100 - rev 445651
Push 1620 by archaeopteryx@coole-files.de at Fri, 12 Jan 2018 20:17:17 +0000
Bug 1417431 - secureConnectionStart should be 0 for pages with HTTP scheme. r=bkelly a=gchang
3caec21cf4f622aa56a37aa6316800cf55bef13b: Bug 1416878 - Move the implementation of nsIWidgetListener from nsWebBrowser / nsWebShellWindow to a separate object. r=bz a=gchang
Samael Wang <freesamael@gmail.com> - Fri, 12 Jan 2018 22:12:01 +0200 - rev 445650
Push 1620 by archaeopteryx@coole-files.de at Fri, 12 Jan 2018 20:17:17 +0000
Bug 1416878 - Move the implementation of nsIWidgetListener from nsWebBrowser / nsWebShellWindow to a separate object. r=bz a=gchang MozReview-Commit-ID: 5QV6lkCCGW5
75912c7725910ed540e53348c4620add73f36000: Bug 1261175. r=bobowen a=gchang
Matt Woodrow <mwoodrow@mozilla.com> - Tue, 14 Nov 2017 10:31:36 +1300 - rev 445648
Push 1620 by archaeopteryx@coole-files.de at Fri, 12 Jan 2018 20:17:17 +0000
Bug 1261175. r=bobowen a=gchang MozReview-Commit-ID: B9yAN0F01rj
d4eaca183f2fdb910ce7e67f9039e9cb27b377fc: Bug 1429219 - Ensure VP8 simulcast with temporal layers won't fail if there aren't enough bits. r=drno, a=gchang
Randell Jesup <rjesup@jesup.org> - Wed, 10 Jan 2018 20:41:09 -0500 - rev 445646
Push 1619 by ryanvm@gmail.com at Fri, 12 Jan 2018 02:41:27 +0000
Bug 1429219 - Ensure VP8 simulcast with temporal layers won't fail if there aren't enough bits. r=drno, a=gchang
000398f8c373407ba621d56cbd3b370cf43469a8: Bug 1428589: Don't read a destroyed cookie list if the last cookie in the entry expired. r=jdm a=gchang
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 11 Jan 2018 14:12:38 +0200 - rev 445637
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1428589: Don't read a destroyed cookie list if the last cookie in the entry expired. r=jdm a=gchang Consider the following situation, which is what causes the failure: * `cookies` is an array of length 1 (either from the beginning, or because other cookies have been expired while in this loop). * the only cookie that remains is expired. We append the cookie to removedList, and then we call gCookieService->RemoveCookieFromList, which has the following code: if (aIter.entry->GetCookies().Length() == 1) { mDBState->hostTable.RawRemoveEntry(aIter.entry); } else { aIter.entry->GetCookies().RemoveElementAt(aIter.index); } If we enter the first branch, as it's the case, that will destroy the array. We're effectively removing stuff from the array while mutating it, which is scary. It's fine if we don't delete the array, since we iterate through it using indices, but still it's dangerous as heck. If we're the last element in the array though, we're doomed, because `cookies` is now destroyed. We not only try to access the array length again, but also we try to index on it the next time because we never stopped the loop (`i` is still zero, and the length may very well be garbage). Fix it by keeping the length in sync from the stack and breaking out from the loop if appropriately. MozReview-Commit-ID: 6qaC9yclvP2
e57848b337fcaeec8a8e23f45354603df11c2b5b: Bug 1396399 - Clarify rules for applying activeTab permission to content scripts. r=kmag, r=bz a=gchang
Andrew Swan <aswan@mozilla.com> - Sat, 04 Nov 2017 21:06:20 -0700 - rev 445636
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1396399 - Clarify rules for applying activeTab permission to content scripts. r=kmag, r=bz a=gchang MozReview-Commit-ID: 9xPDX8Qk2iR
3f7a950871b4587af63fae0e82f601e0f4f10ba6: Bug 1426449: set the correct number of temporal layers for screencasts r=drno a=gchang
Randell Jesup <rjesup@jesup.org> - Wed, 10 Jan 2018 20:41:03 -0500 - rev 445635
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1426449: set the correct number of temporal layers for screencasts r=drno a=gchang
398360c9d5c6fcc80d7ced94afe65ee7f672b0bf: Bug 1429542 Make HttpChannelChild::OverrideRunnable check for nullptr before using mNewChannel. r=asuth a=gchang
Ben Kelly <ben@wanderview.com> - Wed, 10 Jan 2018 14:45:17 -0500 - rev 445634
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1429542 Make HttpChannelChild::OverrideRunnable check for nullptr before using mNewChannel. r=asuth a=gchang
76192bc7ded10f07dd8eb314af1b268d2b0af248: Bug 1426500 - Disable WebVR for macOS on Beta and Release r=daoshengmu a=gchang
Kearwood "Kip" Gilbert <kgilbert@mozilla.com> - Wed, 10 Jan 2018 16:14:21 -0800 - rev 445633
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1426500 - Disable WebVR for macOS on Beta and Release r=daoshengmu a=gchang - WebVR will continue to be enabled on macOS for Nightly and Dev Edition MozReview-Commit-ID: LpEX13yZVbb
3a94f3140a144491cde0c1805afcd13ae9922b7f: bug 1422735 - Change symbol upload URL from Socorro to Tecken. r=nalexander a=gchang
Ted Mielczarek <ted@mielczarek.org> - Wed, 06 Dec 2017 06:28:41 -0500 - rev 445632
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
bug 1422735 - Change symbol upload URL from Socorro to Tecken. r=nalexander a=gchang MozReview-Commit-ID: BBs6G8dFfPz
7047976f6bec7c8e611009b74456986e0045cfc9: Bug 1421214 - Try GoToAnchor() with unescaped string before using document's charset. r=smaug a=gchang
Alphan Chen <alchen@mozilla.com> - Fri, 05 Jan 2018 15:12:16 +0800 - rev 445631
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1421214 - Try GoToAnchor() with unescaped string before using document's charset. r=smaug a=gchang
3e7bec52b1431c8dfd56c86ec5062514434fa788: Bug 1427126 - Use setElementWithType instead of setElement in AppendToList. r=bhackett, a=gchang
Jan de Mooij <jdemooij@mozilla.com> - Tue, 09 Jan 2018 16:37:12 -0500 - rev 445629
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1427126 - Use setElementWithType instead of setElement in AppendToList. r=bhackett, a=gchang
a1d9a99f12a544df996ebdf833cf3e65357a7361: Bug 1426801 - Clear gFirstIdleTask if we fail to dispatch the runnable. r=mrbkap, a=gchang
Andrew McCreight <continuation@gmail.com> - Thu, 04 Jan 2018 14:59:14 -0800 - rev 445628
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1426801 - Clear gFirstIdleTask if we fail to dispatch the runnable. r=mrbkap, a=gchang MozReview-Commit-ID: 23f9VDTyyqg
38fd987182186720bc0b252a1dc94444f6db39f5: Bug 1428165 - Part 2: Fix history expiration query. r=nalexander, a=gchang
Grigory Kruglov <gkruglov@mozilla.com> - Thu, 04 Jan 2018 23:15:42 -0500 - rev 445627
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1428165 - Part 2: Fix history expiration query. r=nalexander, a=gchang 'modified' value might be missing; in SQLite, max(123, null) is null, and so we must coalesce fields which might be missing values. MozReview-Commit-ID: Bn1P0kdaHHT
916cbb15381ea0571c81e33ef37514855f152203: Bug 1428165 - Part 1: Ensure that 'modified' and 'created' timestamps are set when inserting history from sync. r=nalexander, a=gchang
Grigory Kruglov <gkruglov@mozilla.com> - Fri, 05 Jan 2018 21:15:55 -0500 - rev 445626
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1428165 - Part 1: Ensure that 'modified' and 'created' timestamps are set when inserting history from sync. r=nalexander, a=gchang This fixes a regression introduced in Bug 1291821. History records would be bulk-inserted from sync, and our ContentProvider would erroneously forget to set these two timestamp fields. MozReview-Commit-ID: 2k0afijN62H
5b67ac2c216bef0bcf3a3cf7577eade0ffb5e0e2: Bug 1426042 - Ensure we don't forget to set bidi data when required on a zero-length trailing frame. r=dholbert, a=gchang
Jonathan Kew <jkew@mozilla.com> - Fri, 05 Jan 2018 13:58:51 +0000 - rev 445625
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1426042 - Ensure we don't forget to set bidi data when required on a zero-length trailing frame. r=dholbert, a=gchang
b5147bc4e38410b1c5b66368f9e0d67f02e98738: Bug 1426042 - Reftest for bidi reordering where line has an empty trailing ::after pseudo-element. r=dholbert, a=gchang
Jonathan Kew <jkew@mozilla.com> - Fri, 05 Jan 2018 13:58:42 +0000 - rev 445624
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1426042 - Reftest for bidi reordering where line has an empty trailing ::after pseudo-element. r=dholbert, a=gchang
ed60f2c05c4ae44d1385176764dafe9b9c0321fa: Bug 1427089 - Wait for a previous empty transaction to complete before doing another empty transaction. r=dvander, a=gchang
Ryan Hunt <rhunt@eqrion.net> - Wed, 03 Jan 2018 16:56:25 -0600 - rev 445623
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1427089 - Wait for a previous empty transaction to complete before doing another empty transaction. r=dvander, a=gchang