searching for reviewer(fitzgen)
193e75ac905dc2cd9b8f01114483323fb6d0f380: Bug 1575569 - use GetSpecialSystemDirectory to avoid accessing the directory service off the main thread for worker snapshots, r=fitzgen
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 21 Aug 2019 22:18:44 +0000 - rev 553071
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1575569 - use GetSpecialSystemDirectory to avoid accessing the directory service off the main thread for worker snapshots, r=fitzgen Differential Revision: https://phabricator.services.mozilla.com/D42947
c9fe4617e3a4eae29e3b089c97fcb6da750aaeef: Bug 1565175 - Fix HeapSnapshotHandler to not add nodes to |visited| until they're written to the core dump. r=fitzgen
Jan de Mooij <jdemooij@mozilla.com> - Thu, 11 Jul 2019 18:41:43 +0000 - rev 546343
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1565175 - Fix HeapSnapshotHandler to not add nodes to |visited| until they're written to the core dump. r=fitzgen Because ShouldIncludeEdge considers the |origin| node as well, it was possible for the old code to 'miss' nodes and never write them to the core dump even though we also wrote some edges with the node as referent. Differential Revision: https://phabricator.services.mozilla.com/D37701
b5afafec0097a2d48b15908c116fb2c358cac692: Bug 1401624: Part 6: Update Rust bindings r=fitzgen
Iain Ireland <iireland@mozilla.com> - Wed, 12 Jun 2019 17:51:04 +0000 - rev 541351
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1401624: Part 6: Update Rust bindings r=fitzgen We are changing the representation of values on 64-bit. Part 5 of this patch stack has more details on the changes. Differential Revision: https://phabricator.services.mozilla.com/D29056
bccc5a509ebeb89eebad52e3d8bb01c86a1fe2c7: Bug 1401624: Part 6: Update Rust bindings r=fitzgen
Iain Ireland <iireland@mozilla.com> - Mon, 03 Jun 2019 15:57:43 +0000 - rev 541307
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1401624: Part 6: Update Rust bindings r=fitzgen We are changing the representation of values on 64-bit. Part 5 of this patch stack has more details on the changes. Differential Revision: https://phabricator.services.mozilla.com/D29056
138edceae4d995226438a92797fd29ab9140cab3: Bug 1556119 - Fix 64-byte memory leak in evalInWorker() shell builtin. r=fitzgen
Jason Orendorff <jorendorff@mozilla.com> - Fri, 07 Jun 2019 19:42:34 +0000 - rev 541162
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1556119 - Fix 64-byte memory leak in evalInWorker() shell builtin. r=fitzgen Differential Revision: https://phabricator.services.mozilla.com/D34222
4b8f9814a1ea6f412d1f02c2701096b048cd0707: Bug 1542184 - Use PersistentRooted for rooting vectors of GC things from rust code r=fitzgen?
Jon Coppeard <jcoppeard@mozilla.com> - Fri, 10 May 2019 17:36:34 +0000 - rev 535470
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1542184 - Use PersistentRooted for rooting vectors of GC things from rust code r=fitzgen? This replaces the use of heap-alloced Rooted with PersistentRooted which is safe wrt destruction order. I had to add PersistentRooted and StackGCVector to OPAQUE_TYPES to make this work... I'm not really sure what this does. Differential Revision: https://phabricator.services.mozilla.com/D30668
fbbc1ac9d28a55b23613e33ac660656d20336936: Bug 1534967 - Part 2: Use RootedIdVector in rust binding. r=jonco,fitzgen
Yoshi Cheng-Hao Huang <allstars.chh@gmail.com> - Thu, 04 Apr 2019 14:55:44 +0800 - rev 530199
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1534967 - Part 2: Use RootedIdVector in rust binding. r=jonco,fitzgen - Replace AutoIdVector with RootedIdVector. - Replace JS::MutableHandleIdVector through rustbindgen in wrapper.hpp, otherwise MutableHandleIdVector will be converted to u8 in rust, and causes only 1 byte is passed to props in GetPropertyKeys. - Add another glue function GetMutableHandleIdVector to get the object. Differential Revision: https://phabricator.services.mozilla.com/D25360
b48232ea7b093d787a1479510a80da7545303f53: Bug 1521732 - Part 4: fix SM rust binging test. r=fitzgen
Yoshi Cheng-Hao Huang <allstars.chh@gmail.com> - Mon, 25 Mar 2019 06:39:25 +0000 - rev 528173
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1521732 - Part 4: fix SM rust binging test. r=fitzgen StackGCVector and RootedVector are partial template specialization and cause cargo test failure. Bypass the classes by adding them to OPAQUE_TYPES. Depends on D23184 Differential Revision: https://phabricator.services.mozilla.com/D23185
24f4ed60ba7fe10e2a99400ad89b36b2463687f5: Bug 1523969 part 4 - Move method definition inline comments to new line in 'devtools/'. r=fitzgen
Ryan Hunt <rhunt@eqrion.net> - Mon, 25 Feb 2019 16:04:29 -0600 - rev 522765
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1523969 part 4 - Move method definition inline comments to new line in 'devtools/'. r=fitzgen Differential Revision: https://phabricator.services.mozilla.com/D21104
56eaf6c976d377cba4e44a302bdeda9e7420bd94: Bug 1485800 - Rename SourceBufferHolder to SourceText, and add a <typename Unit> template parameter to it so it can hold putative UTF-8 or UTF-16 source text. r=tcampbell, r=fitzgen
Jeff Walden <jwalden@mit.edu> - Thu, 08 Nov 2018 18:42:48 -0800 - rev 505724
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1485800 - Rename SourceBufferHolder to SourceText, and add a <typename Unit> template parameter to it so it can hold putative UTF-8 or UTF-16 source text. r=tcampbell, r=fitzgen
1f98cec81e6bdb3bea2537fa4106f83c987c1d51: Bug 1496220 - 3. Disable Necko IPC security for test_saveHeapSnapshot_e10s_01; r=fitzgen
Jim Chen <nchen@mozilla.com> - Wed, 07 Nov 2018 16:17:18 -0500 - rev 504270
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1496220 - 3. Disable Necko IPC security for test_saveHeapSnapshot_e10s_01; r=fitzgen The use of <iframe mozbrowser> in test_saveHeapSnapshot_e10s_01.html has implicitly depended on the "network.disable.ipc.security" pref set to false, which is the default for desktop and not applicable for Fennec. With the new mobile test harness, this pref needs to be set explicitly by the test. Differential Revision: https://phabricator.services.mozilla.com/D7786
960b295f45afb55ad43ac6c68e9bd7bb2d85196a: Bug 1409441 part 1 - Inline ActivationEntryMonitor constructor/destructor. r=fitzgen
Jan de Mooij <jdemooij@mozilla.com> - Wed, 31 Oct 2018 10:31:14 +0100 - rev 502957
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1409441 part 1 - Inline ActivationEntryMonitor constructor/destructor. r=fitzgen
7b5505d44965fd3b0719610c52a827c89a6081db: Bug 1496220 - 3. Disable Necko IPC security for test_saveHeapSnapshot_e10s_01; r=fitzgen
Jim Chen <nchen@mozilla.com> - Wed, 17 Oct 2018 16:12:30 +0000 - rev 500163
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1496220 - 3. Disable Necko IPC security for test_saveHeapSnapshot_e10s_01; r=fitzgen The use of <iframe mozbrowser> in test_saveHeapSnapshot_e10s_01.html has implicitly depended on the "network.disable.ipc.security" pref set to false, which is the default for desktop and not applicable for Fennec. With the new mobile test harness, this pref needs to be set explicitly by the test. Differential Revision: https://phabricator.services.mozilla.com/D7786
7f35ad97d197adc2af2ecda9d8749f8df7cb2b1f: Bug 1494195 - Back out bug 1491946, using '.fxsnapshot.gz' for memory heap snapshots. r=fitzgen
Jim Blandy <jimb@mozilla.com> - Thu, 11 Oct 2018 15:13:47 -0700 - rev 499727
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1494195 - Back out bug 1491946, using '.fxsnapshot.gz' for memory heap snapshots. r=fitzgen
70505741627fe29e79facb7fab0e3297320f0421: Bug 1496220 - 3. Disable Necko IPC security for test_saveHeapSnapshot_e10s_01; r=fitzgen
Jim Chen <nchen@mozilla.com> - Tue, 09 Oct 2018 16:30:46 +0000 - rev 499061
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1496220 - 3. Disable Necko IPC security for test_saveHeapSnapshot_e10s_01; r=fitzgen The use of <iframe mozbrowser> in test_saveHeapSnapshot_e10s_01.html has implicitly depended on the "network.disable.ipc.security" pref set to false, which is the default for desktop and not applicable for Fennec. With the new mobile test harness, this pref needs to be set explicitly by the test. Differential Revision: https://phabricator.services.mozilla.com/D7786
e58d578f13d990ac2064d38692b2440bc96f9e2f: Bug 1490948: Link libjsrust into mozjs_sys if it's been compiled; r=fitzgen
Benjamin Bouvier <benj@benj.me> - Tue, 25 Sep 2018 17:21:00 +0200 - rev 497126
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1490948: Link libjsrust into mozjs_sys if it's been compiled; r=fitzgen Also make sure to precise the panic behavior before compiling Spidermonkey and its Rust dependencies, to be compatible with the Rust bindings which want to unwind Rust code properly and not abort as Gecko does.
c9bdc101c70bb988a07fc86fab8fee0efcea4238: Bug 1491946: Save devtools heap snapshots with the extension '.fxsnapshot.gz'. r=fitzgen
Jim Blandy <jimb@mozilla.com> - Mon, 17 Sep 2018 11:57:42 -0700 - rev 496705
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1491946: Save devtools heap snapshots with the extension '.fxsnapshot.gz'. r=fitzgen
2defd19a1467b02aa6fcf130cfada6dcc994ce0d: Bug 1491946: Save devtools heap snapshots with the extension '.fxsnapshot.gz'. r=fitzgen
Jim Blandy <jimb@mozilla.com> - Mon, 17 Sep 2018 11:57:42 -0700 - rev 496323
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1491946: Save devtools heap snapshots with the extension '.fxsnapshot.gz'. r=fitzgen
4204e7eaa385eb5aa8ea0aa57cf20c588019882b: Bug 1475228 - Make synchronous compile APIs take SourceBufferHolders exclusively r=jandem r=fitzgen
Jon Coppeard <jcoppeard@mozilla.com> - Tue, 17 Jul 2018 14:30:22 +0100 - rev 487367
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1475228 - Make synchronous compile APIs take SourceBufferHolders exclusively r=jandem r=fitzgen
b2d18ea619ecfdaa34fbb1dde59502d77162fcf0: Bug 1475228 - Fix rust bindings following JS::Evaluate signature change r=fitzgen
Jon Coppeard <jcoppeard@mozilla.com> - Mon, 30 Jul 2018 11:14:03 +0100 - rev 486913
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1475228 - Fix rust bindings following JS::Evaluate signature change r=fitzgen
70c285e729d9e06c05a169ac94940a69e91574f2: Bug 1207696 Part 10f - Coordinate with snapshot mechanism in JS helper threads, r=fitzgen.
Brian Hackett <bhackett1024@gmail.com> - Mon, 23 Jul 2018 14:48:27 +0000 - rev 485626
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1207696 Part 10f - Coordinate with snapshot mechanism in JS helper threads, r=fitzgen.
ab53a96c3b3027d3a8d467c16df1d60182c61bc6: Bug 1207696 Part 5k - Don't generate debugger runnables on GC events, r=fitzgen.
Brian Hackett <bhackett1024@gmail.com> - Mon, 23 Jul 2018 14:39:48 +0000 - rev 485616
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1207696 Part 5k - Don't generate debugger runnables on GC events, r=fitzgen.
99479560fb28b06474e61a365685abada9c1446d: Bug 1207696 Part 4f - Don't record JS mutexes, r=fitzgen.
Brian Hackett <bhackett1024@gmail.com> - Sat, 21 Jul 2018 14:24:48 +0000 - rev 485409
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1207696 Part 4f - Don't record JS mutexes, r=fitzgen.
317eee299a24c5adc2e87dc27128e82eab145599: Bug 1467248 - Make the spidermonkey jobs labeled debug be debug builds, r=fitzgen
Steve Fink <sfink@mozilla.com> - Tue, 05 Jun 2018 20:32:55 -0700 - rev 478781
Push 1757 by ffxbld-merge at Fri, 24 Aug 2018 17:02:43 +0000
Bug 1467248 - Make the spidermonkey jobs labeled debug be debug builds, r=fitzgen
1e833c6a3ba2a4d592868fd2167e94c1cb933004: Bug 1467248 - Make the spidermonkey jobs labeled debug be debug builds, r=fitzgen
Steve Fink <sfink@mozilla.com> - Tue, 05 Jun 2018 20:32:55 -0700 - rev 478775
Push 1757 by ffxbld-merge at Fri, 24 Aug 2018 17:02:43 +0000
Bug 1467248 - Make the spidermonkey jobs labeled debug be debug builds, r=fitzgen
ee68c73f661babf8bbbf499387e8f044b434ed38: Bug 1465163 - Some UbiNode changes for same-compartment realms. r=fitzgen
Jan de Mooij <jdemooij@mozilla.com> - Fri, 01 Jun 2018 19:23:06 +0200 - rev 477652
Push 1757 by ffxbld-merge at Fri, 24 Aug 2018 17:02:43 +0000
Bug 1465163 - Some UbiNode changes for same-compartment realms. r=fitzgen
27f44af915f74d0c8dbaf65cc9b5e18d38287e59: Bug 1463723 - Remove ubi::Census' pointer to the atoms zone r=fitzgen
Jon Coppeard <jcoppeard@mozilla.com> - Thu, 24 May 2018 09:40:46 +0100 - rev 476401
Push 1757 by ffxbld-merge at Fri, 24 Aug 2018 17:02:43 +0000
Bug 1463723 - Remove ubi::Census' pointer to the atoms zone r=fitzgen
fc3a8ce00c3f7025871140e1275d6920d92d13db: Bug 1458029 - Baldr: update wasm frame stack format string to match WebAssembly Web API spec (r=yury,bbouvier,fitzgen)
Luke Wagner <luke@mozilla.com> - Tue, 08 May 2018 13:26:40 -0500 - rev 474245
Push 1757 by ffxbld-merge at Fri, 24 Aug 2018 17:02:43 +0000
Bug 1458029 - Baldr: update wasm frame stack format string to match WebAssembly Web API spec (r=yury,bbouvier,fitzgen)
9b7418660fe23ccf235231f210608c3669b85ed3: Bug 1449189 - Don't lock in ~ExclusiveData (r=fitzgen)
Luke Wagner <luke@mozilla.com> - Fri, 30 Mar 2018 11:16:24 -0500 - rev 466886
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
Bug 1449189 - Don't lock in ~ExclusiveData (r=fitzgen)
10b30b796dbf89e0cf054ea37cace173702d93c6: Bug 1438121: Add jit-test async-livecache.js. r=fitzgen
Jim Blandy <jimb@mozilla.com> - Fri, 09 Mar 2018 16:47:58 -0800 - rev 462552
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
Bug 1438121: Add jit-test async-livecache.js. r=fitzgen MozReview-Commit-ID: Jbe1GMPGwKj
1057c4246ffaae3b24a9b3493ac2d6cff9e33cec: Bug 1438121: Final Part 6: Omitted doc fix requested in review. DONTBUILD r=fitzgen
Jim Blandy <jimb@mozilla.com> - Fri, 09 Mar 2018 11:40:46 -0800 - rev 462469
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
Bug 1438121: Final Part 6: Omitted doc fix requested in review. DONTBUILD r=fitzgen MozReview-Commit-ID: FXQM85VAnfA
88470a2d04a100c1efb3ffad0ae215fe7f8880b6: Bug 1438121: Final Part 5: Remove meaningless 'const' this qualifier from LiveSavedFrameCache::FramePtr::SetHasCachedMatcher::match. r=fitzgen
Jim Blandy <jimb@mozilla.com> - Fri, 02 Mar 2018 23:39:15 -0800 - rev 462468
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
Bug 1438121: Final Part 5: Remove meaningless 'const' this qualifier from LiveSavedFrameCache::FramePtr::SetHasCachedMatcher::match. r=fitzgen MozReview-Commit-ID: kfcTilDEwK
bfc321ae89810ce708b0e15d6848a9a822b253f4: Bug 1438121: Final Part 4: Doc fixes for LiveSavedFrameCache. DONTBUILD r=fitzgen
Jim Blandy <jimb@mozilla.com> - Thu, 01 Mar 2018 23:22:02 -0800 - rev 462467
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
Bug 1438121: Final Part 4: Doc fixes for LiveSavedFrameCache. DONTBUILD r=fitzgen MozReview-Commit-ID: 5672uZ4pC2E
449f9d9d664bb47a8f318bba7543c34e2363a4a3: Bug 1438121: Final Part 3: Make LiveSavedFrameCache::find pop invalid entries as part of the search. r=fitzgen
Jim Blandy <jimb@mozilla.com> - Thu, 01 Mar 2018 23:14:45 -0800 - rev 462466
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
Bug 1438121: Final Part 3: Make LiveSavedFrameCache::find pop invalid entries as part of the search. r=fitzgen Rather than searching from the beginning (old end) of the cache, LiveSameFrameCache::find can search from the young end of the cache, popping invalid stack entries as it goes. This means that the number of entries searched is related to the number of cached frames popped since the last stack capture, not the total number of entries in the cache. This also removes the need for iterators, iterator arithmetic, or any random access to the stack; the function simply uses the vector's 'back', 'popBack', 'empty', and 'clear' methods. MozReview-Commit-ID: DCFt0uhiqql
f54675bcf897379cd4f81cad3b80f812b9f2a903: Bug 1438121: Final Part 2: Fix interaction between async parents and the LiveSavedFrameCache in SavedStacks::insertFrames. r=fitzgen
Jim Blandy <jimb@mozilla.com> - Sat, 24 Feb 2018 15:39:43 -0800 - rev 462465
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
Bug 1438121: Final Part 2: Fix interaction between async parents and the LiveSavedFrameCache in SavedStacks::insertFrames. r=fitzgen When capturing frames in an activation that had both 1) an async parent stack established by AutoSetAsyncStackForNewCalls and 2) SavedFrames cached in the activation's LiveSavedFramesCache, SavedStacks::insertFrames would supplant the SavedFrame chain from the cache with the async parent stack, causing frames to be dropped. The code also looked for frames in the wrong activation's LiveSavedFramesCache. The code assumed that only the parent of a frame whose hasCachedSavedFrame flag is set could be retrieved from the cache; this was pessimistic, as we can compare the cached and actual pc's, and potentially provide cache hits for the youngest frame with a flag set. MozReview-Commit-ID: 8tXTI43pjYr
018578db02247c7262593ef308c70961ace7c85e: Bug 1444081 - Shutdown the Parent JSRuntime instead of leaking it. r=fitzgen
Nicolas B. Pierron <nicolas.b.pierron@gmail.com> - Thu, 08 Mar 2018 14:14:41 +0000 - rev 462246
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
Bug 1444081 - Shutdown the Parent JSRuntime instead of leaking it. r=fitzgen
797239d1e7059c6e5f6fd394e261ea089b2325a9: Bug 1443592: Part 6: Remove hasCachedSavedFrame accessors from AbstractFramePtr. r=fitzgen
Jim Blandy <jimb@mozilla.com> - Tue, 06 Mar 2018 13:51:13 -0800 - rev 462173
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
Bug 1443592: Part 6: Remove hasCachedSavedFrame accessors from AbstractFramePtr. r=fitzgen Some variants of AbstractFramePtr have a cached saved frame flag, and others don't, but the whole point of LiveSavedFrameCache::FramePtr is that it represents a frame that does have a flag. Rather than one variant of FramePtr that is an AbstractFramePtr (restricted to certain variants), flatten out the two enums into one, and make FramePtr the sole authority on which sorts of frames we have, and how to access their flags. This means there is no need for hasCachedSavedFrame accessors on AbstractFramePtr, just on the individual concrete frame types. MozReview-Commit-ID: BRVdfqOqBsG
c8eff45d0955decbbf82df66a67d1639e986396d: Bug 1443592: Part 5: Move LiveSavedFrameCache::getFramePtr to FramePtr::create. r=fitzgen
Jim Blandy <jimb@mozilla.com> - Tue, 06 Mar 2018 13:33:52 -0800 - rev 462172
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
Bug 1443592: Part 5: Move LiveSavedFrameCache::getFramePtr to FramePtr::create. r=fitzgen MozReview-Commit-ID: EZHdkBeMGnm
269e77f6b1e5878062f9b4a5e12533cc20da01d0: Bug 1443592: Part 3: Change LiveSavedFrameCache::find to take a FramePtr, not a FrameIter. r=fitzgen
Jim Blandy <jimb@mozilla.com> - Tue, 06 Mar 2018 11:42:36 -0800 - rev 462170
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
Bug 1443592: Part 3: Change LiveSavedFrameCache::find to take a FramePtr, not a FrameIter. r=fitzgen This obviates dynamic checks in find about the state of the iterator, since they're covered by the fact that we were able to obtain a FramePtr at all. This does mean that we have to pass the pc separately. But that's symmetrical with the insert method, so it's okay. MozReview-Commit-ID: FgsDjHB2il4
1790490874a09b2da5731945e629e6b708ce9f5f: Bug 1443592: Part 2: Move hasCachedSavedFrame flag access from FrameIter to LiveSavedFrameCache::FramePtr. r=fitzgen
Jim Blandy <jimb@mozilla.com> - Tue, 06 Mar 2018 11:28:53 -0800 - rev 462169
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
Bug 1443592: Part 2: Move hasCachedSavedFrame flag access from FrameIter to LiveSavedFrameCache::FramePtr. r=fitzgen Instead of using FrameIter::hasCachedSavedFrame, the code should instead try to construct a FramePtr via LiveSavedFrameCache::getFramePtr, which returns a Maybe<FramePtr>. If that is Some, then we know the frame at hand actually has a flag, and we can test and set it. Since the existing FrameIter::hasCachedSavedFrame screens out all wasm frames, we change LiveSavedFrameCache::getFramePtr to do the same. However, the existing behavior was incorrect, since wasm::DebugFrame does carry the flag; we'll fix that in a later patch. FrameIter::hasCachedSavedFrame asserted that jsJitFrame().isIonScripted(); this is tested by isPhysicalIonFrame(), so that case is already covered. MozReview-Commit-ID: 92wCc71s4nU
faa2dd792d1cfdc83004c048a7bb9e41c388fb04: Bug 1443592: Part 1: Introduce opaque LiveSavedFrameCache::Key type for cache keys. r=fitzgen
Jim Blandy <jimb@mozilla.com> - Mon, 05 Mar 2018 18:03:56 -0800 - rev 462168
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
Bug 1443592: Part 1: Introduce opaque LiveSavedFrameCache::Key type for cache keys. r=fitzgen By design, the LiveSavedFrameCache holds the addresses of both live and dead stack frames. This change wraps those addresses in an opaque type that can only be compared for equality with other such values, and provides no interface to retrieve the underlying pointer, ensuring statically that we will not accidentally use a cache key to access memory. MozReview-Commit-ID: 9Wom5gFVQls
bc9778de0b084afaaca48cd5d27d84fc8d259348: Bug 1438121: Part 13: Make LiveSavedFrameCache::Entry's members const. r=fitzgen
Jim Blandy <jimb@mozilla.com> - Fri, 02 Mar 2018 23:56:26 -0800 - rev 461713
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
Bug 1438121: Part 13: Make LiveSavedFrameCache::Entry's members const. r=fitzgen MozReview-Commit-ID: GbJhE9nylaa
61ca8af8e31332158c4307c8277282d27012d46e: Bug 1411415 - r=bz r=fitzgen
Kannan Vijayan <kvijayan@mozilla.com> - Mon, 05 Mar 2018 19:27:02 -0500 - rev 461707
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
Bug 1411415 - r=bz r=fitzgen
f72fd25e822fc7c8f625a0b6f659a7aaee4d4a41: Bug 1438121: Part 3: Add shell tests for implicit async stacks. r=fitzgen
Jim Blandy <jimb@mozilla.com> - Sun, 25 Feb 2018 16:22:32 -0800 - rev 461706
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
Bug 1438121: Part 3: Add shell tests for implicit async stacks. r=fitzgen MozReview-Commit-ID: BfPPrvEGSgg
4ca86bbdc4090adb24956c783e1b42fd495e0f1f: Bug 1438121: Part 2: Define the 'bindToAsyncStack' JS shell testing function. r=fitzgen
Jim Blandy <jimb@mozilla.com> - Sun, 25 Feb 2018 15:43:20 -0800 - rev 461705
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
Bug 1438121: Part 2: Define the 'bindToAsyncStack' JS shell testing function. r=fitzgen See JS_FN documentation for details. MozReview-Commit-ID: 6WUaGfdwogX
6f555aced81dac6cde601db7ca6589e42efe5f57: Bug 1438121: Part 1: Add job dispatch primitive to shell. r=fitzgen
Jim Blandy <jimb@mozilla.com> - Sun, 25 Feb 2018 14:06:05 -0800 - rev 461704
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
Bug 1438121: Part 1: Add job dispatch primitive to shell. r=fitzgen See JS_FN documentation for details. MozReview-Commit-ID: 8ZLyOX85qqh
03528c9063b3647f70324b120a951a8cdf470d4f: Bug 1438121: Part 5: Don't propagate the 'hasCachedSavedFrame_' bit from the RematerializedFrame to the BaselineFrame. r=fitzgen
Jim Blandy <jimb@mozilla.com> - Fri, 23 Feb 2018 22:28:56 -0800 - rev 461703
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
Bug 1438121: Part 5: Don't propagate the 'hasCachedSavedFrame_' bit from the RematerializedFrame to the BaselineFrame. r=fitzgen When capturing the JavaScript stack as a chain of SavedFrames, the hasCachedSavedFrame flag on a frame indicates that the frame has an entry in the LiveSavedFrameCache, which may hand us the SavedFrame for a previously captured remainder of the stack, letting us stop the stack walk early. The LiveSavedFrameCache uses AbstractFramePtr and jit::CommonFrameLayout* values as keys. A RematerializedFrame uses an AbstractFramePtr as its key, but the BaselineFrame we build from it has a jit::CommonFrameLayout* as its key; the two keys are unequal. It's valuable to be able to assert that, if a frame has its hasCachedSavedFrame flag set, then it must have an entry in the cache; to allow that, converting a RematerializedFrame to a BaselineFrame must clear the flag, since the BaselineFrame's key is not present. We could instead fix up the cache entry's key, and carry over the flag, but it's simpler to just let the cache get repopulated as needed. MozReview-Commit-ID: 612daDJ1R4w
182dc936ca731074c7a332768c8123efffe79951: Bug 1438121: Part 12: Make LiveSavedFrameCache::getFramePtr's parameter const. r=fitzgen
Jim Blandy <jimb@mozilla.com> - Fri, 02 Mar 2018 00:05:27 -0800 - rev 461702
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
Bug 1438121: Part 12: Make LiveSavedFrameCache::getFramePtr's parameter const. r=fitzgen MozReview-Commit-ID: K4JAFidKNzJ
7d93207d01801b99e5a4464145f61a02e98b701f: Bug 1438121: Part 8: AutoSetAsyncStackForNewCalls doc fix. DONTBUILD r=fitzgen
Jim Blandy <jimb@mozilla.com> - Sun, 25 Feb 2018 23:33:54 -0800 - rev 461701
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
Bug 1438121: Part 8: AutoSetAsyncStackForNewCalls doc fix. DONTBUILD r=fitzgen MozReview-Commit-ID: JwIM2EAmPZY
8fd9c1479159335e4d4e9d71e2bf99d1d62b8ba7: Bug 1438121: Part 6: Improve comments for js::LiveSavedFrameCache. DONTBUILD r=fitzgen
Jim Blandy <jimb@mozilla.com> - Sat, 24 Feb 2018 13:57:41 -0800 - rev 461700
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
Bug 1438121: Part 6: Improve comments for js::LiveSavedFrameCache. DONTBUILD r=fitzgen MozReview-Commit-ID: C4W5cgwdNtv