searching for reviewer(droeh)
b63f61a97f1776a0909655817e6391cfcfe09324: Bug 1552328 - Add missing unregisterListener in GeckoViewProgress. r=droeh
Agi Sferro <agi@sferro.dev> - Fri, 17 May 2019 13:43:44 +0000 - rev 536230
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1552328 - Add missing unregisterListener in GeckoViewProgress. r=droeh Differential Revision: https://phabricator.services.mozilla.com/D31538
aee7bbc03bff773a8ce895d0bd58174f2f8aafa1: Bug 1552328 - Add missing unregisterListener in GeckoViewProgress. r=droeh
Agi Sferro <agi@sferro.dev> - Fri, 17 May 2019 04:11:29 +0000 - rev 536176
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1552328 - Add missing unregisterListener in GeckoViewProgress. r=droeh Differential Revision: https://phabricator.services.mozilla.com/D31538
6057bafee921747d5415ef5e99d8954e00f05b8d: Bug 1546851 - Ensure that the context menu is closed when performing a paste. r=geckoview-reviewers,droeh
Emily Toop <etoop@mozilla.com> - Thu, 02 May 2019 15:06:58 +0000 - rev 534197
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1546851 - Ensure that the context menu is closed when performing a paste. r=geckoview-reviewers,droeh This issue was caused by the updating of the caret position after the paste occurs firing an `updateposition` event resulting in an `GeckoView:ShowSelectionAction` message to reposition context menu without any attempt to close the context menu. The solution is to hide the context menu before the repositioning of the caret occurs such that the `updateposition` event doesn't trigger a redisplay. I tried several versions of this trying to trigger the menu close from inside `GeckoViewSelectionActionDelegate`, including making the call to `docShell.doCommand("cmd_paste");` asynchronous and firing `ACTION_HIDE` before firing `ACTION_PASTE`, but the result is always the same - one of the events is processed before the other and so the second event is rejected as a stale response. Therefore we are firing the `pagehide` from inside the code that performs the paste. This has to be done before the paste occurs otherwise the `updateposition` event is fired before the page hide event and the context menu redisplays before being hidden. Differential Revision: https://phabricator.services.mozilla.com/D29665
cda2f454e6ed0fe6a466de9de1f5ca99cfbe8d44: Bug 1544076 - [0.1] Upgrade Android support library to 28.0.0 to avoid version conflicts with the lifecycle library. r=nalexander,droeh
Eugen Sawin <esawin@me73.com> - Wed, 24 Apr 2019 16:22:50 +0000 - rev 533068
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1544076 - [0.1] Upgrade Android support library to 28.0.0 to avoid version conflicts with the lifecycle library. r=nalexander,droeh Differential Revision: https://phabricator.services.mozilla.com/D27971
b978367ef7bb80e73e9c93c6234757731b5e58fb: Bug 1533385 - Make GeckoView read configuration options from filesystem. r=droeh
Nick Alexander <nalexander@mozilla.com> - Wed, 17 Apr 2019 17:05:05 +0000 - rev 531765
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1533385 - Make GeckoView read configuration options from filesystem. r=droeh The configuration file format is YAML and looks like: ``` prefs: foo.bar.boolean: true foo.bar.string: "string" foo.bar.int: 500 env: MOZ_LOG: nsHttp:5 args: [--marionette] ``` By default, if the consuming App is debuggable, GeckoView will read configuration from `/data/local/tmp/$PACKAGE-geckoview-config.yaml` at startup. For consumers (including browsers) that want to allow the underlying GeckoView to be remote controlled in some way, the `GeckoRuntimeSettings.Builder.configFilePath()` method allows to avoid the default behaviour depending on the `android:debuggable` flag. For example, release versions of Firefox for Android will want to allow this configuration when appropriate App-level settings are toggled. The additional configuration is appended after any existing configuration methods, e.g., after anything specified using Intent argument extras or existing `GeckoRuntimeSettings.Builder` methods. Differential Revision: https://phabricator.services.mozilla.com/D25885
1eec26ba4a75870da11818b177a3c75300af08a7: Bug 1544542 - Don't try to call history delegate if we don't have one r=droeh
James Willcox <snorp@snorp.net> - Mon, 15 Apr 2019 21:01:43 +0000 - rev 531459
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1544542 - Don't try to call history delegate if we don't have one r=droeh This also fixes a doc build issue. Differential Revision: https://phabricator.services.mozilla.com/D27576
75d1ab7e1346bdfc272bd07d6a8ff38a52691172: Bug 1531531 - Update GeckoView API implementation to use scrollToVisual() in place of window.scrollTo() r=geckoview-reviewers,botond,esawin,droeh
Randall E. Barker <rbarker@mozilla.com> - Fri, 05 Apr 2019 20:09:55 +0000 - rev 530117
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1531531 - Update GeckoView API implementation to use scrollToVisual() in place of window.scrollTo() r=geckoview-reviewers,botond,esawin,droeh Differential Revision: https://phabricator.services.mozilla.com/D25491
47d793fbd8ccea31dad61e1e5b3df4b7656a7d4b: Bug 1533385 - Make GeckoView read configuration options from filesystem. r=droeh
Nick Alexander <nalexander@mozilla.com> - Thu, 04 Apr 2019 14:30:59 +0000 - rev 529882
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1533385 - Make GeckoView read configuration options from filesystem. r=droeh The configuration file format is YAML and looks like: ``` prefs: foo.bar.boolean: true foo.bar.string: "string" foo.bar.int: 500 env: MOZ_LOG: nsHttp:5 args: [--marionette] ``` By default, if the consuming App is debuggable, GeckoView will read configuration from `/data/local/tmp/$PACKAGE-geckoview-config.yaml` at startup. For consumers (including browsers) that want to allow the underlying GeckoView to be remote controlled in some way, the `GeckoRuntimeSettings.Builder.configFilePath()` method allows to avoid the default behaviour depending on the `android:debuggable` flag. For example, release versions of Firefox for Android will want to allow this configuration when appropriate App-level settings are toggled. The additional configuration is appended after any existing configuration methods, e.g., after anything specified using Intent argument extras or existing `GeckoRuntimeSettings.Builder` methods. Differential Revision: https://phabricator.services.mozilla.com/D25885
91b055c0dadb8032a44fb659695d6487c7d43d5e: Bug 1533385 - Make GeckoView read configuration options from filesystem. r=droeh
Nick Alexander <nalexander@mozilla.com> - Wed, 03 Apr 2019 23:51:17 +0000 - rev 529747
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1533385 - Make GeckoView read configuration options from filesystem. r=droeh The configuration file format is YAML and looks like: ``` prefs: foo.bar.boolean: true foo.bar.string: "string" foo.bar.int: 500 env: MOZ_LOG: nsHttp:5 args: [--marionette] ``` By default, if the consuming App is debuggable, GeckoView will read configuration from `/data/local/tmp/$PACKAGE-geckoview-config.yaml` at startup. For consumers (including browsers) that want to allow the underlying GeckoView to be remote controlled in some way, the `GeckoRuntimeSettings.Builder.configFilePath()` method allows to avoid the default behaviour depending on the `android:debuggable` flag. For example, release versions of Firefox for Android will want to allow this configuration when appropriate App-level settings are toggled. The additional configuration is appended after any existing configuration methods, e.g., after anything specified using Intent argument extras or existing `GeckoRuntimeSettings.Builder` methods. Differential Revision: https://phabricator.services.mozilla.com/D25885
b0fae76a5641d17c1ade92dd46a49d84c9dfd67d: Bug 1522451 - Add ContentDelegate.onWebAppManifest() r=geckoview-reviewers,agi,droeh
James Willcox <snorp@snorp.net> - Wed, 20 Mar 2019 14:44:22 +0000 - rev 527109
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1522451 - Add ContentDelegate.onWebAppManifest() r=geckoview-reviewers,agi,droeh This delivers a parsed and validated Web App Manifest to the application, if present, during the page load process. Differential Revision: https://phabricator.services.mozilla.com/D22612
2ddf151f9535ce36ebc56513ff3917096041eed5: Bug 1522451 - Add ContentDelegate.onWebAppManifest() r=geckoview-reviewers,agi,droeh
James Willcox <snorp@snorp.net> - Thu, 14 Mar 2019 19:18:01 +0000 - rev 524939
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1522451 - Add ContentDelegate.onWebAppManifest() r=geckoview-reviewers,agi,droeh This delivers a parsed and validated Web App Manifest to the application, if present, during the page load process. Differential Revision: https://phabricator.services.mozilla.com/D22612
d291cd16ef76f783402a0ed079263e8335e94448: Bug 1522451 - Add ContentDelegate.onWebAppManifest() r=geckoview-reviewers,agi,droeh
James Willcox <snorp@snorp.net> - Wed, 13 Mar 2019 15:32:57 +0000 - rev 524889
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1522451 - Add ContentDelegate.onWebAppManifest() r=geckoview-reviewers,agi,droeh This delivers a parsed and validated Web App Manifest to the application, if present, during the page load process. Differential Revision: https://phabricator.services.mozilla.com/D22612
e038e06397ad7ad63e52bda514979d7dfc3f6133: Bug 1532756 - Rename geckomediaplugin to gmplugin on Android; r=droeh
Dan Minor <dminor@mozilla.com> - Thu, 07 Mar 2019 16:24:28 +0000 - rev 523861
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1532756 - Rename geckomediaplugin to gmplugin on Android; r=droeh In Bug 1514043 we renamed the geckomediaplugin to gmplugin, but missed renaming it on Android. This prevents the plugin from loading, which breaks OpenH264 in WebRTC. Differential Revision: https://phabricator.services.mozilla.com/D22502
3f221b9ba73f9955f1171571eb800a6b86ad48a1: Bug 1526327 - Add GeckoWebExecutor.FETCH_FLAGS_NO_REDIRECT r=geckoview-reviewers,droeh,esawin
James Willcox <snorp@snorp.net> - Fri, 22 Feb 2019 21:46:14 +0000 - rev 521542
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1526327 - Add GeckoWebExecutor.FETCH_FLAGS_NO_REDIRECT r=geckoview-reviewers,droeh,esawin Using this flag will cause GeckoWebExecutor.fetch() to not automatically follow redirects, which is the default behavior if no flag is specified. Differential Revision: https://phabricator.services.mozilla.com/D19523
11f1c1b18d2823dfcbc92b4272d7a9c1058e6ce1: Bug 1526327 - Add GeckoWebExecutor.FETCH_FLAGS_NO_REDIRECT r=geckoview-reviewers,droeh,esawin
James Willcox <snorp@snorp.net> - Thu, 21 Feb 2019 18:15:42 +0000 - rev 521307
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1526327 - Add GeckoWebExecutor.FETCH_FLAGS_NO_REDIRECT r=geckoview-reviewers,droeh,esawin Using this flag will cause GeckoWebExecutor.fetch() to not automatically follow redirects, which is the default behavior if no flag is specified. Differential Revision: https://phabricator.services.mozilla.com/D19523
77dcf9bd89d01d422319bd2c8aeae598a38c4cb5: Bug 1532756 - Rename geckomediaplugin to gmplugin on Android; r=droeh a=lizzard
Dan Minor <dminor@mozilla.com> - Thu, 07 Mar 2019 16:24:28 +0000 - rev 516329
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1532756 - Rename geckomediaplugin to gmplugin on Android; r=droeh a=lizzard In Bug 1514043 we renamed the geckomediaplugin to gmplugin, but missed renaming it on Android. This prevents the plugin from loading, which breaks OpenH264 in WebRTC. Differential Revision: https://phabricator.services.mozilla.com/D22502
b511d2df882c7fdbd3929608860affb914944245: Bug 1382637 - Backing out patch due to breakage (see: 1532161, 1532157). r=droeh a=lizzard
Dylan Roeh <droeh@mozilla.com> - Thu, 31 Jan 2019 13:58:54 -0600 - rev 515706
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1382637 - Backing out patch due to breakage (see: 1532161, 1532157). r=droeh a=lizzard
70d0497c3cb6aecba82408e9067c13d74fa04de7: Bug 1485809 - Fix race with compositor attachment r=geckoview-reviewers,droeh#geckoview-reviewers
James Willcox <snorp@snorp.net> - Wed, 23 Jan 2019 16:31:08 +0000 - rev 515135
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1485809 - Fix race with compositor attachment r=geckoview-reviewers,droeh#geckoview-reviewers We can receive GeckoSession.onCompositorDetached() before GeckoSession.onCompositorReady() has run, so guard against this by ensuring the compositor is attached in onCompositorReady(). Differential Revision: https://phabricator.services.mozilla.com/D16983
255d5e9dc5ca7e1bbd00852c0c7fc24836f1f757: Bug 1521087 - Enable process hang monitor in GeckoView r=geckoview-reviewers,droeh#geckoview-reviewers
James Willcox <snorp@snorp.net> - Fri, 18 Jan 2019 16:08:28 +0000 - rev 514443
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1521087 - Enable process hang monitor in GeckoView r=geckoview-reviewers,droeh#geckoview-reviewers Differential Revision: https://phabricator.services.mozilla.com/D16979
821f274155c761e7de874f1b0ca86d6f1492fe47: Bug 1514253 - Create PanZoomController immediately in GeckoSession r=geckoview-reviewers,droeh#geckoview-reviewers
James Willcox <snorp@snorp.net> - Thu, 17 Jan 2019 14:17:50 +0000 - rev 514265
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1514253 - Create PanZoomController immediately in GeckoSession r=geckoview-reviewers,droeh#geckoview-reviewers Differential Revision: https://phabricator.services.mozilla.com/D14562
d3b95f808e2878849127b8f4fc43527202eecf2a: Bug 1501748 - Avoid synchronous wait when creating VsyncSource r=geckoview-reviewers,droeh#geckoview-reviewers
James Willcox <snorp@snorp.net> - Fri, 04 Jan 2019 23:24:44 +0000 - rev 512696
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1501748 - Avoid synchronous wait when creating VsyncSource r=geckoview-reviewers,droeh#geckoview-reviewers Differential Revision: https://phabricator.services.mozilla.com/D15747
20eca8ed41e6183536c27f3bdbde4979a4794b91: Bug 1515978 - Make GeckoRuntime#getSettings @NonNull. r=geckoview-reviewers,droeh
Agi Sferro <agi@mozilla.com> - Wed, 02 Jan 2019 20:06:32 +0000 - rev 512333
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1515978 - Make GeckoRuntime#getSettings @NonNull. r=geckoview-reviewers,droeh Differential Revision: https://phabricator.services.mozilla.com/D15217
b68c8690cc9e3fc1b7092d0939af17290479975d: Bug 1497682 - Part 3. Add junit test. r=droeh
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Tue, 18 Dec 2018 18:05:36 +0900 - rev 511110
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1497682 - Part 3. Add junit test. r=droeh Summary: Add autofill hint test if using Android 8+. Depends on D12881 Reviewers: droeh Reviewed By: droeh Bug #: 1497682 Differential Revision: https://phabricator.services.mozilla.com/D12882
78488dedd35ed0adcd9841f5f6a0db7eb365e58f: Bug 1497682 - Part 2. Don't set inputType to all <input type=text>. r=droeh
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Tue, 18 Dec 2018 17:20:10 +0900 - rev 511109
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1497682 - Part 2. Don't set inputType to all <input type=text>. r=droeh Summary: LastPass will fill password to all input elements which InputType is TYPE_CALSS_TEXT and TYPE_TEXT_VARIATION_WEB_EDIT_TEXT and has no AutofillHint. And it will fill username when InputType and AutofillHint is nothing in <input type="text">. Actually, current implementation of GeckoView sets InputType only for <input type="text">, so LastPass fills password to all <input type="text"> So as workaround, we should set InputType and AutofillHint when input element presumes username fields. Depends on D12880 Reviewers: droeh Reviewed By: droeh Bug #: 1497682 Differential Revision: https://phabricator.services.mozilla.com/D12881
9bfabcea5227bc9bd751a12fb1594f1b78ae8916: Bug 1514253 - Create PanZoomController immediately in GeckoSession r=geckoview-reviewers,droeh#geckoview-reviewers
James Willcox <snorp@snorp.net> - Fri, 14 Dec 2018 18:42:52 +0000 - rev 510567
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1514253 - Create PanZoomController immediately in GeckoSession r=geckoview-reviewers,droeh#geckoview-reviewers Differential Revision: https://phabricator.services.mozilla.com/D14562
860ac47c10fbe9abae52c7f0ff9a9005723d36e2: Bug 1510448 - Disallow invalid forms in GeckoView r=geckoview-reviewers,droeh
James Willcox <snorp@snorp.net> - Thu, 29 Nov 2018 18:40:26 +0000 - rev 509731
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1510448 - Disallow invalid forms in GeckoView r=geckoview-reviewers,droeh Differential Revision: https://phabricator.services.mozilla.com/D13143
f7c20de04f4d0a6966e43a77dab3a44fea733622: Bug 1501748 - Avoid synchronous wait when creating VsyncSource. r=droeh, a=RyanVM FENNEC_65_0b9_BUILD2 FENNEC_65_0b9_RELEASE
James Willcox <snorp@snorp.net> - Fri, 04 Jan 2019 23:24:44 +0000 - rev 509338
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1501748 - Avoid synchronous wait when creating VsyncSource. r=droeh, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D15747
f8cd4d3f58883d56ebfb750ce2f7d277a3949841: Bug 1497682 - Part 3. Add junit test. r=droeh, a=RyanVM
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Tue, 18 Dec 2018 18:05:36 +0900 - rev 509162
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1497682 - Part 3. Add junit test. r=droeh, a=RyanVM Summary: Add autofill hint test if using Android 8+. Depends on D12881 Reviewers: droeh Reviewed By: droeh Bug #: 1497682 Differential Revision: https://phabricator.services.mozilla.com/D12882
27b291b4e078596dc11ecc1fc86566b7aaf67be6: Bug 1497682 - Part 2. Don't set inputType to all <input type=text>. r=droeh, a=RyanVM
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Tue, 18 Dec 2018 17:20:10 +0900 - rev 509161
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1497682 - Part 2. Don't set inputType to all <input type=text>. r=droeh, a=RyanVM Summary: LastPass will fill password to all input elements which InputType is TYPE_CALSS_TEXT and TYPE_TEXT_VARIATION_WEB_EDIT_TEXT and has no AutofillHint. And it will fill username when InputType and AutofillHint is nothing in <input type="text">. Actually, current implementation of GeckoView sets InputType only for <input type="text">, so LastPass fills password to all <input type="text"> So as workaround, we should set InputType and AutofillHint when input element presumes username fields. Depends on D12880 Reviewers: droeh Reviewed By: droeh Bug #: 1497682 Differential Revision: https://phabricator.services.mozilla.com/D12881
ea4b9bbb0cf49ff47f18427132141e42f71982ee: Bug 1511012 - [1.0] Ensure non-null scheme before accessing it. r=droeh
Eugen Sawin <esawin@mozilla.com> - Thu, 29 Nov 2018 22:06:32 +0000 - rev 508089
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1511012 - [1.0] Ensure non-null scheme before accessing it. r=droeh Differential Revision: https://phabricator.services.mozilla.com/D13455
a0fb2044780dd738d8fbd9b5c6ec074cf7b05a3e: Bug 1508457 - Add GeckoView API to get first composite callback after a compositor start. r=snorp,droeh
Randall Barker <rbarker@mozilla.com> - Tue, 20 Nov 2018 18:18:24 +0000 - rev 506557
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1508457 - Add GeckoView API to get first composite callback after a compositor start. r=snorp,droeh Differential Revision: https://phabricator.services.mozilla.com/D12357
b245aba69d768056a73019c5ceb1ab39fb543fbd: Bug 1508457 - Add GeckoView API to get first composite callback after a compositor start. r=snorp,droeh
Randall Barker <rbarker@mozilla.com> - Tue, 20 Nov 2018 17:41:42 +0000 - rev 506553
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1508457 - Add GeckoView API to get first composite callback after a compositor start. r=snorp,droeh Differential Revision: https://phabricator.services.mozilla.com/D12357
78d26b6dce21a0bd8ce11a624a3bd26779d44937: Bug 1508638 - [1.0] Remove default progress value to avoid stuck progress bar for about: pages. r=droeh
Eugen Sawin <esawin@mozilla.com> - Tue, 20 Nov 2018 15:54:20 +0100 - rev 506485
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1508638 - [1.0] Remove default progress value to avoid stuck progress bar for about: pages. r=droeh
7f4d0af1b7b4f73d877a1e0fe0ff3e82c5c360c4: Bug 1506747 - Add GeckoView API for drawing transparent border around the content window r=snorp,droeh,kats
Randall Barker <rbarker@mozilla.com> - Thu, 15 Nov 2018 01:54:18 +0000 - rev 505677
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1506747 - Add GeckoView API for drawing transparent border around the content window r=snorp,droeh,kats Differential Revision: https://phabricator.services.mozilla.com/D11717
c3437e2549613cf3ef981f59d545a2371b3cc358: Bug 1502118 - Add assertOnUiThread calls to GeckoDisplay. r=snorp,droeh.
Agi Sferro <agi@mozilla.com> - Tue, 30 Oct 2018 16:31:37 +0000 - rev 502755
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1502118 - Add assertOnUiThread calls to GeckoDisplay. r=snorp,droeh. Depends on D10237 Differential Revision: https://phabricator.services.mozilla.com/D10238
0df87bbe161e757b7fee9a0213ef07a62bf77ae9: Bug 1497259 - 3. Control GV logging through pref; r=droeh
Jim Chen <nchen@mozilla.com> - Wed, 10 Oct 2018 17:36:13 +0000 - rev 499041
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1497259 - 3. Control GV logging through pref; r=droeh Use the "geckoview.logging" pref to control GV logging. Differential Revision: https://phabricator.services.mozilla.com/D8052
20cd9ac747da9b457d594fb385f13ace7bffbff2: Bug 1497259 - 2. Don't log auto-fill values; r=droeh
Jim Chen <nchen@mozilla.com> - Wed, 10 Oct 2018 17:36:11 +0000 - rev 499040
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1497259 - 2. Don't log auto-fill values; r=droeh Auto-fill values can contain personal information and must not appear in the log. Differential Revision: https://phabricator.services.mozilla.com/D8051
50b9d2e6ac5f0d14822601bcf403b8f80ce5e3d4: Bug 1497259 - 1. Fix log module names; r=droeh
Jim Chen <nchen@mozilla.com> - Wed, 10 Oct 2018 17:36:03 +0000 - rev 499039
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1497259 - 1. Fix log module names; r=droeh Fix the GV log module names so they are all under the GeckoView group. Differential Revision: https://phabricator.services.mozilla.com/D8050
538da6bb518b6a794a81ea76584c190dd66e17e9: Bug 1492704 - 2. Keep track of the auto-fill focus root node; r=droeh
Jim Chen <nchen@mozilla.com> - Thu, 04 Oct 2018 20:41:40 +0000 - rev 498164
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1492704 - 2. Keep track of the auto-fill focus root node; r=droeh The crash is happening because we may not have a full node tree when looking at a particular node; in that case we may not be able to find the root node. This patch makes us keep track of the root node from the beginning, so we always know what the root node is. Differential Revision: https://phabricator.services.mozilla.com/D6758
149bad7f0537378befc983add77a57fd55415fe5: Bug 1491094 - Don't require ACCESS_WIFI_STATE for GeckoView r=droeh
James Willcox <snorp@snorp.net> - Fri, 28 Sep 2018 18:34:57 +0000 - rev 497158
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1491094 - Don't require ACCESS_WIFI_STATE for GeckoView r=droeh Fennec will continue to require this. While we're here, also make 'touchscreen' feature optional. Differential Revision: https://phabricator.services.mozilla.com/D7125
a44a660a15803c689e8b24245171ff38d363c5dc: Bug 1492704 - 2. Don't update node during auto-fill focus event; r=droeh
Jim Chen <nchen@mozilla.com> - Thu, 27 Sep 2018 10:59:50 -0400 - rev 497016
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1492704 - 2. Don't update node during auto-fill focus event; r=droeh Don't update the focused node in the node cache during auto-fill focus events, because we don't necessarily know if the focused node should be in the node cahce (e.g. the focused node could be from another window than the one we're handling currently). Differential Revision: https://phabricator.services.mozilla.com/D6758
22a6f4ef044a5d23e4232d94433184b0b3ec91c9: Bug 1442176 - 2. Add pinned-to-screen flag in GeckoSession; r=snorp r=droeh
Jim Chen <nchen@mozilla.com> - Mon, 17 Sep 2018 17:47:21 -0400 - rev 495587
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1442176 - 2. Add pinned-to-screen flag in GeckoSession; r=snorp r=droeh Add a flag for whether the session should be pinned to the screen. The app would check the flag and prevent scrolling of the session when it's pinned. Differential Revision: https://phabricator.services.mozilla.com/D5190
14ca7a3794faf4a6c94aae99f2064cbfc155988d: Bug 1475325 - Hide selection action in some scenarios; r=droeh
Jim Chen <nchen@mozilla.com> - Mon, 17 Sep 2018 23:15:17 +0000 - rev 495361
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1475325 - Hide selection action in some scenarios; r=droeh Hide the selection action toolbar when the session is unfocused, or when changing the selection action delegate. Differential Revision: https://phabricator.services.mozilla.com/D5807
ab31927770b8dad266d2e4db97e095aa63bfeb89: Bug 1490493 - 2. Add tests for GeckoView saving/restoring state; r=droeh
Jim Chen <nchen@mozilla.com> - Fri, 14 Sep 2018 14:47:25 -0400 - rev 494935
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1490493 - 2. Add tests for GeckoView saving/restoring state; r=droeh Add some tests for all scenarios that GeckoView encounters when it is saving/restoring state. Differential Revision: https://phabricator.services.mozilla.com/D5607
8a0955e0457ac8279241a568bbc97b8fdb2d9bb3: Bug 1490493 - 1. Return early if same session is being restored; r=droeh
Jim Chen <nchen@mozilla.com> - Fri, 14 Sep 2018 14:47:24 -0400 - rev 494934
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1490493 - 1. Return early if same session is being restored; r=droeh Restoring the same session that's already managed by the GeckoView instance should be a no-op. Differential Revision: https://phabricator.services.mozilla.com/D5606
d59d980a57453bd4ee0cf1b3ec527700e3304e88: Bug 1485810 - 1. Move auto-fill code to GeckoViewAutoFill.jsm; r=droeh
Jim Chen <nchen@mozilla.com> - Fri, 14 Sep 2018 14:46:25 -0400 - rev 494932
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1485810 - 1. Move auto-fill code to GeckoViewAutoFill.jsm; r=droeh Move all auto-fill code to GeckoViewAutoFill.jsm, so they can be shared between GeckoView and Fennec. Differential Revision: https://phabricator.services.mozilla.com/D4803
e6b25c0709ad0599e189a78fac5a48306840938c: Bug 1490664 - Fix Fennec build sans MOZ_CRASHREPORTER r=droeh
James Willcox <snorp@snorp.net> - Wed, 12 Sep 2018 19:03:18 +0000 - rev 494385
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1490664 - Fix Fennec build sans MOZ_CRASHREPORTER r=droeh Differential Revision: https://phabricator.services.mozilla.com/D5694
bf0a33ff3b308f6df447f054f94c41d4441608f6: Bug 1486778 - Move GeckoDisplay into org.mozilla.geckoview r=jchen,droeh
James Willcox <snorp@snorp.net> - Tue, 28 Aug 2018 08:59:21 -0500 - rev 494219
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1486778 - Move GeckoDisplay into org.mozilla.geckoview r=jchen,droeh Summary: This also moves GeckoDisplay-related things out of LayerSession and into GeckoSession. Additionally, we try to make sure GeckoSession has only one attached GeckoDisplay. Reviewers: jchen, droeh Tags: #secure-revision Bug #: 1486778 Differential Revision: https://phabricator.services.mozilla.com/D4449
4bc9731f089e3223438d86979e3e038f74f1e1c0: Bug 1489569 - 2. Don't blur window on temporary focus loss; r=droeh
Jim Chen <nchen@mozilla.com> - Mon, 10 Sep 2018 12:42:35 -0400 - rev 493951
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1489569 - 2. Don't blur window on temporary focus loss; r=droeh When the window temporarily loses focus (e.g. due to auto-fill popups), don't call setFocus(false). Otherwise, we can end up disrupting user interaction (e.g. causing the auto-fill popup to flicker). Only call setFocus(false) when we are reasonably sure the focus loss is not temporary. Differential Revision: https://phabricator.services.mozilla.com/D5329
48c8c080a9600e522b9572b475af88d749e02dd0: Bug 1489569 - 1. Avoid unnecessary setActive calls; r=droeh
Jim Chen <nchen@mozilla.com> - Mon, 10 Sep 2018 12:42:34 -0400 - rev 493950
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1489569 - 1. Avoid unnecessary setActive calls; r=droeh To avoid unnecessary setActive calls, only call it when we have a display and when the display acquires or releases a surface. In other cases, we can delay the setActive call until later. Differential Revision: https://phabricator.services.mozilla.com/D5328