searching for reviewer(dholbert)
ba272d4ecc9a70414ac50890f2f772afbdfe1b36: Bug 1358759. Fix intermittent failures of layout/base/tests/test_bug114649.html. r=dholbert, a=test-only
Jonathan Watt <jwatt@jwatt.org> - Mon, 01 Apr 2019 20:05:07 +0100 - rev 526051
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1358759. Fix intermittent failures of layout/base/tests/test_bug114649.html. r=dholbert, a=test-only Differential Revision: https://phabricator.services.mozilla.com/D25655
9b874010673d878cb9772770bc8ba7f6572ee693: Bug 1535986 - Skip recomputing the position for frames that have a pending reflow. r=dholbert a=pascalc
Mats Palmgren <mats@mozilla.com> - Mon, 18 Mar 2019 16:25:28 +0100 - rev 525773
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1535986 - Skip recomputing the position for frames that have a pending reflow. r=dholbert a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D23971
d36eebc8899848bd3285c7b02466b3f9eb0a0f9a: Bug 1532156 - correct marker-start for closed paths so it is the average of the start and end angles i.e. the same as marker-end r=dholbert
longsonr <longsonr@gmail.com> - Sat, 16 Mar 2019 17:00:23 +0000 - rev 525591
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1532156 - correct marker-start for closed paths so it is the average of the start and end angles i.e. the same as marker-end r=dholbert
8854d4a1652878c30a85eaf9178771efc8025dee: Bug 1343357 - Ignore lower-priority animateMotion if a to-animation is encountered r=dholbert
violet <violet.bugreport@gmail.com> - Fri, 15 Mar 2019 01:26:13 +0000 - rev 524997
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1343357 - Ignore lower-priority animateMotion if a to-animation is encountered r=dholbert Current impl at SVGMotionSMILType::Interpolate has some wrong assertions, it's probably caused by overlooking the special behavior of to-animation. These assumptions also lead weird animation in the product build. Now we take to-animation into account, and implement similar behavior as Chrome and Safari. Differential Revision: https://phabricator.services.mozilla.com/D23095
f20b5098f7a266dbfde7cd871548ba3fd81ea9ae: Bug 1535084 - Cleanup contain property. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 13 Mar 2019 19:55:54 +0000 - rev 524774
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1535084 - Cleanup contain property. r=dholbert Now that cbindgen supports bitflags, this is trivial. Differential Revision: https://phabricator.services.mozilla.com/D23371
2d1f2814e41d53c985643fbb9c73f4af2caaa3ec: Bug 1524314 Part 2 - Use RAII notifier classes to simplify code r=dholbert
longsonr <longsonr@gmail.com> - Sat, 09 Mar 2019 17:50:53 +0000 - rev 524257
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1524314 Part 2 - Use RAII notifier classes to simplify code r=dholbert
6838e7d3960f9888ecdfcd6eda67fa1afae76190: Bug 1524314 Part 1 - use using mozilla:dom to reduce typing r=dholbert
longsonr <longsonr@gmail.com> - Sat, 09 Mar 2019 16:01:33 +0000 - rev 524256
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1524314 Part 1 - use using mozilla:dom to reduce typing r=dholbert
e9672ac059b453a1b6e9f5a177b2a10a9eed113f: Bug 1531578 - don't process nsChangeHint_UpdateSubtreeOverflow for nondisplay frames r=dholbert
longsonr <longsonr@gmail.com> - Sat, 09 Mar 2019 16:01:31 +0000 - rev 524255
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1531578 - don't process nsChangeHint_UpdateSubtreeOverflow for nondisplay frames r=dholbert
6b4af1ecd78d9765b9b09eb9bcaf2ff88def7b80: Bug 1532444 - Go back to doing synchronous invalidation in ReflowSVGNonDisplayText as its invoked by ScheduleReflowSVGNonDisplayText so is already asynchronous r=dholbert
longsonr <longsonr@gmail.com> - Sat, 09 Mar 2019 14:14:33 +0000 - rev 524254
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1532444 - Go back to doing synchronous invalidation in ReflowSVGNonDisplayText as its invoked by ScheduleReflowSVGNonDisplayText so is already asynchronous r=dholbert
91fcd9232c7e64ec113afd5f9eb183939cd52110: Bug 1533392 - Fix initial font-family detection in property-database.js. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 07 Mar 2019 21:27:23 +0000 - rev 523907
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1533392 - Fix initial font-family detection in property-database.js. r=dholbert Calling getComputedStyle on an element outside of the document always returns the empty string since bug 1511138, so we were incorrectly thinking that the initial font-family was serif when it was not. I chose a <meta> element instead of a <div> because they're undisplayed and they don't cause the <body> of the document to start (though I _think_ that only happens from the parser). In any case I'm pretty surprised this didn't cause issues in other tests... Differential Revision: https://phabricator.services.mozilla.com/D22604
d3a4d053ea82a628f822d15bc20162236a25f69d: Bug 1533040 - Remove invalid NS_WARNING_ASSERTION. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 06 Mar 2019 17:13:14 +0000 - rev 523534
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1533040 - Remove invalid NS_WARNING_ASSERTION. r=dholbert We can totally get there with a negative percentage basis, see comment 0 for an example. We could keep the warning like: NS_WARNING_ASSERTION(clamping_mode == StyleAllowedNumericType::All || basis >= 0, "nscoord overflow?"); Which will catch cases where the style system would refuse to parse a negative <length-percentage>, but we got a negative percent basis, which would be weird. But that's a bit misleading since right now at least we rely on the caller to do the appropriate clamping. I also think that NS_WARNING_ASSERTION is not very useful, since we're not very likely to catch stuff with it. But anyhow, your call. Differential Revision: https://phabricator.services.mozilla.com/D22328
6ec4f0415d9ae3bdbce6d32a81b137a0bc1a42a9: Bug 1531277 - Check child container count in NotifyRefreshDriverCreated; r=dholbert
Brian Birtles <birtles@gmail.com> - Mon, 04 Mar 2019 15:54:55 +0000 - rev 523415
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1531277 - Check child container count in NotifyRefreshDriverCreated; r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D21636
52e2caa87f892d8075d9e1a358d88bdfb9c89af4: Bug 1532128 - layout/build: #include nsLayoutModule.h in nsLayoutModule.cpp. r=dholbert
Chris Peterson <cpeterson@mozilla.com> - Fri, 22 Feb 2019 22:40:57 -0800 - rev 523410
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1532128 - layout/build: #include nsLayoutModule.h in nsLayoutModule.cpp. r=dholbert clang's -Wmissing-prototypes option identifies global functions that can be made static (because they're only called from one compilation unit) or removed (if they're never called). layout/build/nsLayoutModule.cpp:95:6 [-Wmissing-prototypes] no previous prototype for function 'nsLayoutModuleInitialize' layout/build/nsLayoutModule.cpp:176:11 [-Wmissing-prototypes] no previous prototype for function 'CreateXMLContentSerializer' layout/build/nsLayoutModule.cpp:178:11 [-Wmissing-prototypes] no previous prototype for function 'CreateHTMLContentSerializer' layout/build/nsLayoutModule.cpp:180:11 [-Wmissing-prototypes] no previous prototype for function 'CreateXHTMLContentSerializer' layout/build/nsLayoutModule.cpp:182:11 [-Wmissing-prototypes] no previous prototype for function 'CreatePlainTextSerializer' layout/build/nsLayoutModule.cpp:184:11 [-Wmissing-prototypes] no previous prototype for function 'CreateContentPolicy' layout/build/nsLayoutModule.cpp:188:11 [-Wmissing-prototypes] no previous prototype for function 'CreateGlobalMessageManager' layout/build/nsLayoutModule.cpp:189:11 [-Wmissing-prototypes] no previous prototype for function 'CreateParentMessageManager' layout/build/nsLayoutModule.cpp:191:11 [-Wmissing-prototypes] no previous prototype for function 'CreateChildMessageManager' layout/build/nsLayoutModule.cpp:225:10 [-Wmissing-prototypes] no previous prototype for function 'Construct_nsIScriptSecurityManager' layout/build/nsLayoutModule.cpp:237:10 [-Wmissing-prototypes] no previous prototype for function 'LocalStorageManagerConstructor' layout/build/nsLayoutModule.cpp:255:6 [-Wmissing-prototypes] no previous prototype for function 'nsLayoutModuleDtor' Differential Revision: https://phabricator.services.mozilla.com/D21854
0d185a75fd896ce312e500c3b7a3dc252ff33440: Bug 1532128 - layout: Move NS_NewLayoutDebugger() function prototype to a common header file. r=dholbert
Chris Peterson <cpeterson@mozilla.com> - Fri, 22 Feb 2019 22:01:01 -0800 - rev 523409
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1532128 - layout: Move NS_NewLayoutDebugger() function prototype to a common header file. r=dholbert clang's -Wmissing-prototypes option identifies global functions that can be made static (because they're only called from one compilation unit) or removed (if they're never called). NS_NewLayoutDebugger() is defined in nsLayoutDebugger.cpp. layout/base/nsLayoutDebugger.cpp:44:10 [-Wmissing-prototypes] no previous prototype for function 'NS_NewLayoutDebugger' Differential Revision: https://phabricator.services.mozilla.com/D21853
70d011e850dac280855f30140fe846a87ab5a7c8: Bug 1532128 - layout: Make some global functions static. r=dholbert
Chris Peterson <cpeterson@mozilla.com> - Fri, 22 Feb 2019 20:33:01 -0800 - rev 523407
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1532128 - layout: Make some global functions static. r=dholbert clang's -Wmissing-prototypes option identifies global functions that can be made static (because they're only called from one compilation unit) or removed (if they're never called). layout/painting/FrameLayerBuilder.cpp:2593:6 [-Wmissing-prototypes] no previous prototype for function 'ReleaseLayerUserData' layout/painting/RetainedDisplayListBuilder.cpp:1084:6 [-Wmissing-prototypes] no previous prototype for function 'FindContainingBlocks' layout/style/FontFaceSet.cpp:423:6 [-Wmissing-prototypes] no previous prototype for function 'IsPdfJs' layout/svg/SVGObserverUtils.cpp:969:6 [-Wmissing-prototypes] no previous prototype for function 'DestroyFilterProperty' Differential Revision: https://phabricator.services.mozilla.com/D21851
f19a83763e503190da29a68f2a644412142f3c1d: Bug 1518666 part 1 - Remove a couple of unused include files r=dholbert
longsonr <longsonr@gmail.com> - Tue, 05 Mar 2019 21:53:19 +0000 - rev 523394
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1518666 part 1 - Remove a couple of unused include files r=dholbert
7c5b913dc2e3b68cb7b019574de03d7b5d8de364: Bug 1532477 - Return BEnd() from LogicalRect::YMost() in the case of non vertical. r=dholbert
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Tue, 05 Mar 2019 01:22:06 +0000 - rev 523181
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1532477 - Return BEnd() from LogicalRect::YMost() in the case of non vertical. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D22035
5bb743ffae8c391c6481936bbc5d0b26489e4430: Bug 1530177 - Downgrade an assertion to a diagnostic assert since it exposes pre-existing bugs. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 28 Feb 2019 23:37:44 +0000 - rev 523070
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1530177 - Downgrade an assertion to a diagnostic assert since it exposes pre-existing bugs. r=dholbert nsIconChannel (for moz-icon:// images) is unsound, see bug 1438939. nsMenuPopupFrame::Init is also unsound on mac, looks like... I'll try to get them fixed on trunk, but it's not worth crashing release for this IMO, given it's pre-existing. The assert in PresShell::~PresShell hopefully avoids exploitable issues. Differential Revision: https://phabricator.services.mozilla.com/D20945
e0fb4657355d4d8052bff3f1e8baac265b5efef7: Bug 1523969 part 14 - Move method definition inline comments to new line in 'layout/'. r=dholbert
Ryan Hunt <rhunt@eqrion.net> - Mon, 25 Feb 2019 16:09:24 -0600 - rev 522775
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1523969 part 14 - Move method definition inline comments to new line in 'layout/'. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D21115
31404c0c060e9ee2c46b56a199369a3e42d668e4: Bug 1526567 - Fix devtools dependence on this bug. r=dholbert
Mats Palmgren <mats@mozilla.com> - Fri, 22 Feb 2019 13:58:24 +0100 - rev 521439
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1526567 - Fix devtools dependence on this bug. r=dholbert
739201563949300a8fe729d07a49e7b634231922: Bug 1526567 - [css-grid] Make the block-axis percentage basis be indefinite for measuring reflows. r=dholbert
Mats Palmgren <mats@mozilla.com> - Fri, 22 Feb 2019 13:58:24 +0100 - rev 521438
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1526567 - [css-grid] Make the block-axis percentage basis be indefinite for measuring reflows. r=dholbert
e291cb4e39c7a5cffcbcba639f7bbd8b9b385e0c: Bug 1529389 - Add a WPT for IntersectionObserverEntry.isIntersecting. r=dholbert
Cameron McCormack <cam@mcc.id.au> - Thu, 21 Feb 2019 20:30:13 +0000 - rev 521344
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529389 - Add a WPT for IntersectionObserverEntry.isIntersecting. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D20569
f3471544869b9de5c9864f648d077b278200675a: Bug 1526097 - Remove nsIFrame::eBlockFrame flag. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Wed, 20 Feb 2019 21:18:14 +0000 - rev 520962
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1526097 - Remove nsIFrame::eBlockFrame flag. r=dholbert Only nsBlockFrame and its subclasses recognize the nsIFrame::eBlockFrame flag, so we can replace the usage of the flag with either nsIFrame::IsBlockFrameOrSubclass() or a do_QueryFrame(). Differential Revision: https://phabricator.services.mozilla.com/D20542
e919946fd91306287e4a6197c52a77b6361676ce: Bug 1526567 - [css-grid] Make the block-axis percentage basis be indefinite for measuring reflows. r=dholbert
Mats Palmgren <mats@mozilla.com> - Mon, 18 Feb 2019 18:17:10 +0100 - rev 520703
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1526567 - [css-grid] Make the block-axis percentage basis be indefinite for measuring reflows. r=dholbert
31252f85aa36b976c83946f9bdf5b6ca715860ae: Bug 1519553 - Add test that we don't round subpixel scroll anchoring adjustments. r=dholbert
Ryan Hunt <rhunt@eqrion.net> - Thu, 07 Feb 2019 20:40:32 -0600 - rev 520542
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1519553 - Add test that we don't round subpixel scroll anchoring adjustments. r=dholbert This test might be overkill, but I was tired when writing it and couldn't think of a better way. It feels like there should be, though. Differential Revision: https://phabricator.services.mozilla.com/D19108
6fa064cb22ba0be5576eb8c101f38e3566aa511a: Bug 1528107 - Reland changes to scroll-anchoring tests. r=dholbert
Ryan Hunt <rhunt@eqrion.net> - Thu, 14 Feb 2019 18:54:49 -0600 - rev 520525
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1528107 - Reland changes to scroll-anchoring tests. r=dholbert These changes were reviewed, landed, and accidentally backed out in bug 1528107. Differential Revision: https://phabricator.services.mozilla.com/D19871
95b6997c334afa45b588408bc25b99c9f26b391d: Bug 1525509 - Add release asserts. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 15 Feb 2019 06:29:55 +0000 - rev 520465
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1525509 - Add release asserts. r=dholbert Just for my sanity. I think the other scroll observer is sane after a quick look, but this will ensure we don't ship security issues. Differential Revision: https://phabricator.services.mozilla.com/D19725
3f18f4d9dc1e7e0d226267dea1da72765126f809: Bug 1528199 - Make nsTreeColFrame::InvalidateColumns not flush. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 15 Feb 2019 19:05:09 +0000 - rev 520464
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1528199 - Make nsTreeColFrame::InvalidateColumns not flush. r=dholbert That's not sound. Differential Revision: https://phabricator.services.mozilla.com/D19934
15158d921194d94000045378b00d8944d6dbb0e3: Bug 1525509 - Don't rebuild the frame tree to un-suppress whitespace if we cannot flush layout. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 15 Feb 2019 06:29:54 +0000 - rev 520289
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1525509 - Don't rebuild the frame tree to un-suppress whitespace if we cannot flush layout. r=dholbert The information we'd get would be meaningless anyway in a fully new frame tree if we don't run layout. We should consider whether we need to un-suppress whitespace at all here... Differential Revision: https://phabricator.services.mozilla.com/D19724
683836b692db76292cc3e4494256578afe69f24e: Bug 1528098 - Remove content-select code. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 15 Feb 2019 01:51:33 +0000 - rev 520238
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1528098 - Remove content-select code. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D19869
eed5fd8bc3df0e551d7e2c748837fe575238b552: Bug 1520363 - Rename nsIScrollableFrame::GetAnchor() to Anchor(). r=dholbert
Ryan Hunt <rhunt@eqrion.net> - Fri, 15 Feb 2019 01:25:55 +0000 - rev 520232
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1520363 - Rename nsIScrollableFrame::GetAnchor() to Anchor(). r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D19872
893f2ec05d7acf999174e200b042c3c9ef6fdd7c: Bug 1519553 - Don't round scroll anchor adjustments to device pixels. r=dholbert
Ryan Hunt <rhunt@eqrion.net> - Thu, 07 Feb 2019 20:39:49 -0600 - rev 519422
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1519553 - Don't round scroll anchor adjustments to device pixels. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D19107
77bd40408628b47366a34b3f9c2727fcca263106: Bug 1521147 - Make reftest analyzer more compatible with mozlog tbpl logger, r=dholbert
James Graham <james@hoppipolla.co.uk> - Tue, 22 Jan 2019 18:33:43 +0000 - rev 517662
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1521147 - Make reftest analyzer more compatible with mozlog tbpl logger, r=dholbert This allows TEST-FAIL in addition to TEST-KNOWN-FAIL for expeceted failures. It also makes the second pipe ("|") and everything following it optional, to match the behaviour of the mozlog formatter. Differential Revision: https://phabricator.services.mozilla.com/D17120
0883d6f9b77a71662a16614b1265409ea57e2108: Bug 1524177. Accept a small amount of fuzz for clip-path-inset. r=dholbert
Jeff Muizelaar <jrmuizel@gmail.com> - Thu, 31 Jan 2019 23:40:13 +0000 - rev 517439
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1524177. Accept a small amount of fuzz for clip-path-inset. r=dholbert It seems like we intermittently get fuzz on the clip-path-inset tests. It's better for us to accept that fuzz than intermittently fail. Differential Revision: https://phabricator.services.mozilla.com/D18277
d39849743a9c25ac34a1ad76874f33b5b09b1c96: Bug 1521604 Part 3: Add a test of parentFlexElement. r=dholbert
Brad Werth <bwerth@mozilla.com> - Fri, 01 Feb 2019 22:30:45 +0000 - rev 517377
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1521604 Part 3: Add a test of parentFlexElement. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D17433
e23801bb3b78d664fac0726a0609a2996e3f0cfe: Bug 1521604 Part 2: Create a Node chrome-only parentFlexElement property, for use by devtools. r=dholbert,bzbarsky
Brad Werth <bwerth@mozilla.com> - Fri, 01 Feb 2019 22:29:34 +0000 - rev 517376
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1521604 Part 2: Create a Node chrome-only parentFlexElement property, for use by devtools. r=dholbert,bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D17308
e1865f9630af6071f8a448eb7e46bcb393c8cb1f: Bug 1521579 - Only transform one bounding rect for text nodes when computing scroll anchoring bounding rect. r=dholbert
Ryan Hunt <rhunt@eqrion.net> - Wed, 30 Jan 2019 14:42:58 +0000 - rev 516951
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1521579 - Only transform one bounding rect for text nodes when computing scroll anchoring bounding rect. r=dholbert When visiting a text frame with many continuations, traversing ancestors to compute the transform to the ancestor scroll frame can become very hot. This commit changes the algorithm to translate all the text continuations to an ancestor that can then be transformed just once. Differential Revision: https://phabricator.services.mozilla.com/D17730
39b844d85e7a86cb873fd59694c987c84623723a: Bug 1521579 - Skip text frames that are continuations. r=dholbert
Ryan Hunt <rhunt@eqrion.net> - Wed, 30 Jan 2019 14:42:28 +0000 - rev 516950
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1521579 - Skip text frames that are continuations. r=dholbert A continuation text frame's rect will be considered when visiting the primary frame via 'FindScrollAnchoringBoundingRect', so we have no reason to compute the same rect again if for some reason we have excluded the primary text frame. Differential Revision: https://phabricator.services.mozilla.com/D17729
37103bfa3dca5149f414cc6265d24fd752a4385f: Bug 1522964 - Re-enable scroll anchoring on Fennec with gofaster intervention. r=dholbert
Ryan Hunt <rhunt@eqrion.net> - Fri, 25 Jan 2019 21:08:44 +0000 - rev 516940
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1522964 - Re-enable scroll anchoring on Fennec with gofaster intervention. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D17677
acdd17a4329e63220f8ce84658b585aeb7bc0d92: Bug 1523061 Part 3 - Remove ListTag() that prints frame tag in a frame list. r=dholbert
Ting-Yu Lin <aethanyc@gmail.com> - Tue, 29 Jan 2019 21:30:11 +0000 - rev 516869
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1523061 Part 3 - Remove ListTag() that prints frame tag in a frame list. r=dholbert We can replace it by a simple for-loop. If we want to print not only the tag, but the detailed frame information, we can use nsFrameList::List(). Differential Revision: https://phabricator.services.mozilla.com/D17734
3fd657e4aea9479d9df9e49f68b1ebdce31bd7ff: Bug 1523061 Part 2 - Remove static ListTag(FILE*, const nsIFrame*). r=dholbert
Ting-Yu Lin <aethanyc@gmail.com> - Tue, 29 Jan 2019 21:22:14 +0000 - rev 516868
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1523061 Part 2 - Remove static ListTag(FILE*, const nsIFrame*). r=dholbert Many of the modifications are guarded by #ifdefs. I verify them locally by manually define them in nsBlockDebugFlags.h and nsLinelayout.cpp. Note that I replace "mFrame" with "frame" in lines guarded by NOISY_BLOCK_DIR_MARGINS in nsBlockFrame.cpp because they were incorrectly renamed in Bug 1277129 Part 6a. https://hg.mozilla.org/mozilla-central/rev/a70b04f074fc Differential Revision: https://phabricator.services.mozilla.com/D17733
a9804b2eca4a1c34f9578336affc3c8baf5fa0c6: Bug 1523061 Part 1 - Remove two nsIFrame::ListTag() methods that retrieve frame tag in a string. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Tue, 29 Jan 2019 17:59:53 +0000 - rev 516867
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1523061 Part 1 - Remove two nsIFrame::ListTag() methods that retrieve frame tag in a string. r=dholbert There are three different APIs that serve similar purpose. Keeping only one is sufficient. Differential Revision: https://phabricator.services.mozilla.com/D17732
e12caed89db3e037deb713d8a22a5c9cfa542b1e: Bug 1520584 part 2 - s/aReflowInput/aCBReflowInput/ for clarity. r=dholbert
Mats Palmgren <mats@mozilla.com> - Tue, 29 Jan 2019 17:44:56 +0100 - rev 516840
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1520584 part 2 - s/aReflowInput/aCBReflowInput/ for clarity. r=dholbert
280344f386b27fa1ba1fe0b8058a30053466d729: Bug 1520584 part 1 - [css-align][css-grid] Translate the static position to grid area coordinates. r=dholbert
Mats Palmgren <mats@mozilla.com> - Tue, 29 Jan 2019 17:44:56 +0100 - rev 516839
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1520584 part 1 - [css-align][css-grid] Translate the static position to grid area coordinates. r=dholbert
b72048157f1839b41ea407be0606a8f3cee83e47: Bug 1531277 - Check child container count in NotifyRefreshDriverCreated; r=dholbert a=lizzard
Brian Birtles <birtles@gmail.com> - Mon, 04 Mar 2019 15:54:55 +0000 - rev 516297
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1531277 - Check child container count in NotifyRefreshDriverCreated; r=dholbert a=lizzard Differential Revision: https://phabricator.services.mozilla.com/D21636
e4f640b123bbcdd59396be184689db5dd0c6d69f: Bug 1525509 - Add release asserts. r=dholbert, a=lizzard
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 15 Feb 2019 06:29:55 +0000 - rev 516048
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1525509 - Add release asserts. r=dholbert, a=lizzard Just for my sanity. I think the other scroll observer is sane after a quick look, but this will ensure we don't ship security issues. Differential Revision: https://phabricator.services.mozilla.com/D19725
d720aecf3197eb9dc9a99f1e826122158e95bcd3: Bug 1525509 - Don't rebuild the frame tree to un-suppress whitespace if we cannot flush layout. r=dholbert, a=lizzard
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 15 Feb 2019 06:29:54 +0000 - rev 516047
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1525509 - Don't rebuild the frame tree to un-suppress whitespace if we cannot flush layout. r=dholbert, a=lizzard The information we'd get would be meaningless anyway in a fully new frame tree if we don't run layout. We should consider whether we need to un-suppress whitespace at all here... Differential Revision: https://phabricator.services.mozilla.com/D19724
42c46d6cd486fca17442648ef856b8f700c13391: Bug 1528199 - Make nsTreeColFrame::InvalidateColumns not flush. r=dholbert, a=lizzard
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 15 Feb 2019 19:05:09 +0000 - rev 516046
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1528199 - Make nsTreeColFrame::InvalidateColumns not flush. r=dholbert, a=lizzard That's not sound. Differential Revision: https://phabricator.services.mozilla.com/D19934
1d2492f5e16c30063ffe410223d604776caa0ad1: Bug 1519553 - Add test that we don't round subpixel scroll anchoring adjustments. r=dholbert, a=test-only
Ryan Hunt <rhunt@eqrion.net> - Thu, 07 Feb 2019 20:40:32 -0600 - rev 516016
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1519553 - Add test that we don't round subpixel scroll anchoring adjustments. r=dholbert, a=test-only This test might be overkill, but I was tired when writing it and couldn't think of a better way. It feels like there should be, though. Differential Revision: https://phabricator.services.mozilla.com/D19108
92af0592bc43c8c11e57fd227ce6568bb0b1d0ea: Bug 1519553 - Don't round scroll anchor adjustments to device pixels. r=dholbert, a=jcristau
Ryan Hunt <rhunt@eqrion.net> - Thu, 07 Feb 2019 20:39:49 -0600 - rev 516015
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1519553 - Don't round scroll anchor adjustments to device pixels. r=dholbert, a=jcristau Differential Revision: https://phabricator.services.mozilla.com/D19107