searching for reviewer(dbaron)
d6feaa7bd4aedf27188fe706c9b05da8b8788678: Bug 1561794 - Do not crop display text of themed comboboxes due to padding. r=dbaron a=RyanVM
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 20 Jul 2019 14:54:33 +0000 - rev 544871
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1561794 - Do not crop display text of themed comboboxes due to padding. r=dbaron a=RyanVM This is a potential fix that I thought it was worth doing rather than implementing Blink's platform-dependent silliness. This ensures that the display frame always has enough space to display itself. Note that it may still get clipped, if there's no room for both the display frame and the button. Differential Revision: https://phabricator.services.mozilla.com/D37922
139c0aa658a163b441de8c526b632b0d094ba4f3: Bug 1563484 - Add reftests for this bug. r=dbaron
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 06 Jul 2019 08:20:14 +0000 - rev 544384
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1563484 - Add reftests for this bug. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D36895
fe26c79a01914291de159a3a2abc132e80497d2c: Bug 1563484 - Add reftest support for text-zoom. r=dbaron
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 05 Jul 2019 21:33:37 +0000 - rev 544383
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1563484 - Add reftest support for text-zoom. r=dbaron Seems we had no reftests for this feature :( Depends on D36893 Differential Revision: https://phabricator.services.mozilla.com/D36894
ea1d0ea4b5e5ae2c728ceb4bd128de3397848f82: Bug 1563484 - Apply text-only zoom to system fonts. r=dbaron
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 05 Jul 2019 21:31:40 +0000 - rev 544382
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1563484 - Apply text-only zoom to system fonts. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D36893
c68a6b2e01576b844a9b0637b73a501345bb5fef: Bug 1557371 - Part 1 - Load all XUL reftests with chrome privilege. r=dbaron
Brendan Dahl <bdahl@mozilla.com> - Sat, 29 Jun 2019 00:04:12 +0000 - rev 543693
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1557371 - Part 1 - Load all XUL reftests with chrome privilege. r=dbaron This will have two benefits: 1) Align test setup with shipping Firefox - We don't allow content privilege XUL in shipping versions of Firefox, so having the tests be chrome would be more realistic to our use case. 2) Support the XUL to XHTML migration. These files will soon become XHTML files, but will still need to load XUL elements, so they'll need to be marked as chrome privileged to continue working. One test (404149-1.xul) is now disabled, since it fails when loaded as chrome. Bug 1557383 was filed to address this. Differential Revision: https://phabricator.services.mozilla.com/D33986
468e240bf6683f53ad1c7f87e70253a7a3b38af6: Bug 1513643 - Enable selector() function for @supports everywhere. r=dbaron
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 01 Jul 2019 22:47:08 +0000 - rev 543685
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1513643 - Enable selector() function for @supports everywhere. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D14291
a64db20f0ec9832f583c0f925870ef58764a60f3: Bug 1552781 - Part 3: Make flex/grid items font inflation flow roots, too. r=dbaron
Jan Henning <jh+bugzilla@buttercookie.de> - Wed, 26 Jun 2019 21:12:07 +0000 - rev 543246
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1552781 - Part 3: Make flex/grid items font inflation flow roots, too. r=dbaron The arguments for the respective container elements apply to their immediate child items, too: They establish a new formatting context as well and presumably represent page content that can be considered to be logically separate enough to warrant individual consideration for font inflation. Differential Revision: https://phabricator.services.mozilla.com/D35881
02d7c3c995612e810222bd5f1c6561370ce6d328: Bug 1552781 - Part 2: Flexboxes/grids should be font inflation flow roots. r=dbaron
Jan Henning <jh+bugzilla@buttercookie.de> - Wed, 26 Jun 2019 21:11:20 +0000 - rev 543245
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1552781 - Part 2: Flexboxes/grids should be font inflation flow roots. r=dbaron Our algorithm for dividing a page up into separate font inflation flow roots seems mostly based on the idea that a new Block Formatting Context (BFC) should go hand in hand with a font inflation flow root. Flex containers so far didn't follow that rule, since they technically create a new *Flex* Formatting Context (FFC) and possibly also because nobody thought about font inflation when implementing nsFlexContainerFrame. This leads to all flex containers being counted against the next higher-level flow root, meaning that a lot of small flex containers can get inflated if their sum total of text *collectively* exceeds the font inflation threshold. This alone is likely undesired most of the time, but is then also aggravated by the fact that our flexbox behaviour under font inflation is somewhat buggy (bug 1142461). As apart from the different layout rules inside the container, a FFC behaves very much like a BFC in that it establishes a new formatting context, flex containers should therefore correspondingly become font inflation flow roots, too, and therefore be considered individually for font inflation. As far as I can tell, with this change we'll also match Blink's behaviour in that regard. For completeness's sake, we'll make grid containers follow the same principles, even though hopefully grids on non mobile-friendly pages should hopefully be somewhat rarer than flexboxes. Differential Revision: https://phabricator.services.mozilla.com/D32622
1a496fedfacca83e6f71f5da817d139ce98c82e3: Bug 1552781 - Part 1: Add reftests for flexbox/grid font inflation scope. r=dbaron
Jan Henning <jh+bugzilla@buttercookie.de> - Wed, 26 Jun 2019 21:11:14 +0000 - rev 543244
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1552781 - Part 1: Add reftests for flexbox/grid font inflation scope. r=dbaron In this case, the desired end state is *no* inflation, so we don't need separate ref-versions of the test pages - the only difference is in the prefs being used. Differential Revision: https://phabricator.services.mozilla.com/D32621
39ce05a6691d57b51c1a8a393b46ba6a26ec6cdc: Bug 1552781 - Part 0: Clarify comment in reftest manifest. r=dbaron
Jan Henning <jh+bugzilla@buttercookie.de> - Wed, 26 Jun 2019 21:11:08 +0000 - rev 543243
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1552781 - Part 0: Clarify comment in reftest manifest. r=dbaron There is a natural tendency to add new tests at the bottom of the manifest, so the comment about the lineThreshold pref wasn't entirely accurate anymore. Differential Revision: https://phabricator.services.mozilla.com/D32620
8399a5d502b951898189768b6e6a53e73646cfbf: Bug 1561717 part 2: Add "elem" suffix to reftests "contain-size-select-*", to avoid name collisions with other WPT tests, and add spec link. r=dbaron
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 27 Jun 2019 18:10:46 +0000 - rev 543238
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1561717 part 2: Add "elem" suffix to reftests "contain-size-select-*", to avoid name collisions with other WPT tests, and add spec link. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D36222
1cf069c4e6c0ea6a6b078fc51b3cc8c9a7dac66a: Bug 1552578 - Restrict properties that apply to ::marker for now. r=dbaron
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 27 Jun 2019 00:53:45 +0000 - rev 543173
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1552578 - Restrict properties that apply to ::marker for now. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D31680
7423f5bc275cff6f334a5dfb2af154a9d27a2fd3: Bug 1552578 - Restrict properties that apply to ::marker for now. r=dbaron
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 27 Jun 2019 00:53:45 +0000 - rev 543105
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1552578 - Restrict properties that apply to ::marker for now. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D31680
f8f4f9da5fc8aa69c3670260b7cbb5f5901dba40: Bug 1523595 Part 4 - Enable column-span for multicol-fill-auto-block-children-{001,002}.xht, and fix a reference file. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Wed, 19 Jun 2019 17:05:25 +0000 - rev 542076
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1523595 Part 4 - Enable column-span for multicol-fill-auto-block-children-{001,002}.xht, and fix a reference file. r=dbaron The default margin-top of h1 is 0.67em in Firefox (specified in layout/style/res/html.css) as well as in Google Chrome. The test reference tries to override it to avoid margin-collapse, but using 0.66em can cause rounding issue on MacOS that make the test failed. Differential Revision: https://phabricator.services.mozilla.com/D32063
9cd5c207529c16716daabda597d90be5517a129b: Bug 1523595 Part 3 - Apply ColumnSetWrapper's block size constraint to the available size when creating BlockReflowInput for ColumnSet. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Wed, 19 Jun 2019 17:05:22 +0000 - rev 542075
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1523595 Part 3 - Apply ColumnSetWrapper's block size constraint to the available size when creating BlockReflowInput for ColumnSet. r=dbaron We used to apply the column container's block size constraint on top of the available block size in nsColumnSetFrame::ChooseColumnStrategy(). After column-span is enabled, ColumnSet is no longer the outermost column container frame. We need to apply ColumnSetWrapper's block size constraint to the available size when creating the ReflowInput for ColumnSet so that ColumnSet can use it to compute the max column block size in ChooseColumnStrategy(). This is calculated in nsBlockFrame::ReflowBlockFrame() instead of nsColumnSetFrame::ChooseColumnStrategy() because we need BlockReflowInput::mBCoord to determine the remaining block size. multicol-breaking-004.html is copied and modified from multicol-breaking-001.html with border-bottom added to test "box-decoration-break: clone". Differential Revision: https://phabricator.services.mozilla.com/D31676
4ce4fef3967395caa7a687badc64d07c62f219de: Bug 1523595 Part 2 - Add missing NS_FRAME_HAS_MULTI_COLUMN_ANCESTOR for nested ColumnSetWrapper. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Wed, 19 Jun 2019 17:05:18 +0000 - rev 542074
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1523595 Part 2 - Add missing NS_FRAME_HAS_MULTI_COLUMN_ANCESTOR for nested ColumnSetWrapper. r=dbaron Bug 1507244 changes how NS_FRAME_HAS_MULTI_COLUMN_ANCESTOR is propagated to the child, but I forget to add the bit for nested ColumnSetWrapper. Currently, no other code depends on this bit being set on nested ColumnSetWrapper, but Part 3 will. Without this patch, testing/web-platform/tests/css/css-multicol/multicol-nested-margin-002.xht will fail with Part 3. Differential Revision: https://phabricator.services.mozilla.com/D31675
eca304c5282a9f333d04f41a121f400fe5c40e92: Bug 1523595 Part 1 - Remove margin-bottom from column-balancing-nested-000.html and its reference. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Wed, 19 Jun 2019 17:03:53 +0000 - rev 542073
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1523595 Part 1 - Remove margin-bottom from column-balancing-nested-000.html and its reference. r=dbaron This patch does the same thing as bug 1548118 Part 3, but for column-balancing-nested-000.html. Differential Revision: https://phabricator.services.mozilla.com/D31674
d82fddfaec911b800f754083eaba96da06f14f62: Bug 1558442 - Use a weaker change hint for auto -> non-auto offset changes. r=dbaron
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 14 Jun 2019 23:29:34 +0000 - rev 541822
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1558442 - Use a weaker change hint for auto -> non-auto offset changes. r=dbaron See the review comments in bug 1558442 to see why these should be correct. Quoting: > I think it would be good to avoid passing ClearDescendantIntrinsics and > NeedDirtyReflow here, since those are the most expensive ones, and I think > they're pretty clearly not needed. I think ClearAncestorIntrinsics is also > clearly not needed, since I'm reasonably confident that absolutely positioned > kids don't contribute to their parent's intrinsic size. I think the same thing applies to "slow" offset changes (when autoness changes), since relative movement doesn't affect intrinsic sizes either. Differential Revision: https://phabricator.services.mozilla.com/D34497
614615b9c8abead772f9510c12dc9e2e3bf05963: Bug 1558357 - Should update layout when the hypothetical display of an element changes, even though the final computed display doesn't. r=dbaron
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 11 Jun 2019 09:12:10 +0000 - rev 541036
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1558357 - Should update layout when the hypothetical display of an element changes, even though the final computed display doesn't. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D34443
d93982f48472eb5f2c33dead81c8eb9082bf92e0: Bug 1558357 - Remove unused nsStyleDisplay::mOriginalFloat. r=dbaron
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 11 Jun 2019 01:03:30 +0000 - rev 541035
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1558357 - Remove unused nsStyleDisplay::mOriginalFloat. r=dbaron The original float is not needed for layout, and thus there's no need to keep it around. This was presumably used by the old style system, but now it doesn't seem useful, and is always `none`. Differential Revision: https://phabricator.services.mozilla.com/D34442
156a12d60812b8278be43327f70e2bd76640799a: Bug 1348839 - Add a web platform test which tests max-height imposes constraint on column boxes' height. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Mon, 20 May 2019 22:05:09 +0000 - rev 537498
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1348839 - Add a web platform test which tests max-height imposes constraint on column boxes' height. r=dbaron This reftest renders correctly since bug 1411422 is landed. Differential Revision: https://phabricator.services.mozilla.com/D31690
d1c992257a76532251141ab763fb7c2ac8eb5376: Bug 1544995 - Always update overflow areas up to the preserve-3d root. r=dbaron
Matt Woodrow <mwoodrow@mozilla.com> - Sun, 19 May 2019 22:39:58 +0000 - rev 537497
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1544995 - Always update overflow areas up to the preserve-3d root. r=dbaron We don't store post-transform overflow areas for frames within preserve-3d, but we do store pre-transform overflow areas. Rather than just recomputing the changed overflow for the root, we should recompute overflows for all ancestors up to the 3d root. Differential Revision: https://phabricator.services.mozilla.com/D31213
1ca7d32474c635ae947a747fdc3eae8e22e3050b: Bug 1409114 - Part 10: Make sure we build display items for table parts where only the normal position is visible, since we may need to create background items for ancestors at that position. r=dbaron
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 20 May 2019 23:16:39 +0000 - rev 537474
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1409114 - Part 10: Make sure we build display items for table parts where only the normal position is visible, since we may need to create background items for ancestors at that position. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D29447
69b049f546226b6bcc288986bbf60d792f01bf8f: Bug 1409114 - Part 8: Create column and column group background display items as part of the cell's BuildDisplayList. r=dbaron
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 20 May 2019 23:16:09 +0000 - rev 537472
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1409114 - Part 8: Create column and column group background display items as part of the cell's BuildDisplayList. r=dbaron This is the main performance improvement, and means that we no longer have to iterate all the cells for each column. It has a couple of behaviour changes: The first is that we no longer apply stacking context effects (like opacity) to column and column group backgrounds. I believe this is correct as per both CSS2.1 Appendix E, and css-tables-3 (quoted in nsTableColFrame::BuildDisplayList). This matches the behaviour of blink and WebKit. We also previously created items in column,row ordering, whereas now they will be in row,column. In cases where two cells overlap (using rowspan and colspan to extend multiple neighbours in to the same place) this can render backgrounds in a different order, but the new behaviour matches blink and WebKit. Differential Revision: https://phabricator.services.mozilla.com/D29280
e88eae3b48a71d611ae395582d170548caf9bd28: Bug 1409114 - Part 6: Store column and column group backgrounds separately, and then append then before the rest of the table contents. r=dbaron
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 20 May 2019 23:15:39 +0000 - rev 537470
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1409114 - Part 6: Store column and column group backgrounds separately, and then append then before the rest of the table contents. r=dbaron This also changes behaviour a bit, previously we interleaved column and column group backgrounds. where we now put all the column group backgrounds behind all columns. I believe this is the correct ordering as per CSS2.2 Appendix E. Column backgrounds can overlap when using 'span', and we now render this in a different order, but this matches what other browsers do. Differential Revision: https://phabricator.services.mozilla.com/D29278
34651ebcbaf4c94329b367e1752ba15dc0d25604: Bug 1409114 - Part 5: Skip box-shadow for table column and column groups. r=dbaron
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 20 May 2019 23:15:19 +0000 - rev 537469
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1409114 - Part 5: Skip box-shadow for table column and column groups. r=dbaron This is a behaviour change, but I believe it matches the quoted spec text, and neither blink nor WebKit render these. Differential Revision: https://phabricator.services.mozilla.com/D29276
5137a23cfbba44349e31649fb11e57b7fd3eeeba: Bug 1409114 - Part 4: Hoist outline skipping into col(group) frame code. r=dbaron
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 20 May 2019 23:14:59 +0000 - rev 537468
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1409114 - Part 4: Hoist outline skipping into col(group) frame code. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D29275
c0aa0d405e3c38c2b63b57eac0843ec7e3a0f0b3: Bug 1409114 - Part 2: Get rid of generic table painting code, and handle each class separately. r=dbaron
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 20 May 2019 23:14:45 +0000 - rev 537466
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1409114 - Part 2: Get rid of generic table painting code, and handle each class separately. r=dbaron Most of the code in DisplayGenericTablePart was all within a per-class if statement, so it doesn't add much value, and makes the control flow harder to understand. Differential Revision: https://phabricator.services.mozilla.com/D29273
09ef16b1c51fa6917986aea632e61a3f153b7ce8: Bug 1550535: Mark outer svg frames as reflow roots. r=dbaron
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 15 May 2019 04:04:38 +0000 - rev 537409
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1550535: Mark outer svg frames as reflow roots. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D30671
9c5a51b331c230990ffe63f9f73b57d46c2ac20e: Bug 1547162 Part 3 - Strip "-moz" prefix for all column properties in the received tests, and mark multicol-span-000-ref.xht pass. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Thu, 09 May 2019 23:32:50 +0000 - rev 535228
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1547162 Part 3 - Strip "-moz" prefix for all column properties in the received tests, and mark multicol-span-000-ref.xht pass. r=dbaron multicol-span-000.xht passes because the id in <div id="column-span">123456</div> was incorrect replaced by "-moz-column-span". Strip the "-moz" prefix fixed it. Except failures.list, other files were modified mechanically by running import-tests.py against https://github.com/web-platform-tests/wpt commit 15f199c91a72b0d51bf0a12b3b77827ecb5051ff (the same commit in received/import.log). Differential Revision: https://phabricator.services.mozilla.com/D30406
108d96d047cd3ee2ec1750a802276c14141804c6: Bug 1547162 Part 2 - Remove all the column properties from gPrefixedProperties in import-tests.py. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Thu, 09 May 2019 23:32:00 +0000 - rev 535227
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1547162 Part 2 - Remove all the column properties from gPrefixedProperties in import-tests.py. r=dbaron Also, build gPrefixRegexp and replace lines only if gPrefixedProperties is non-empty. Otherwise, the import tests are messed up due to bogus gPrefixRegexp. Differential Revision: https://phabricator.services.mozilla.com/D30405
82c216e530eaaa56d5b59f95542f6835465241ff: Bug 1547162 Part 1 - Remove unused variables and imports in import-test.py. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Thu, 09 May 2019 23:30:17 +0000 - rev 535226
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1547162 Part 1 - Remove unused variables and imports in import-test.py. r=dbaron This is discovered by running "flake8 import-tests.py" locally. Differential Revision: https://phabricator.services.mozilla.com/D30404
cef0cd7882055d20b8db85c0d717fdd52122f577: Bug 1548118 Part 4 - Always mark inner ColumnSetWrapper's children dirty before reflowing it if the outer ColumnSetWrapper is balancing. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Wed, 08 May 2019 03:12:18 +0000 - rev 534883
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1548118 Part 4 - Always mark inner ColumnSetWrapper's children dirty before reflowing it if the outer ColumnSetWrapper is balancing. r=dbaron ColumnSetFrame always tries to reflow column content regardless of it's dirtiness. Making ColumnSetWrapperFrame's children dirty can have the same effect. Differential Revision: https://phabricator.services.mozilla.com/D29435
970a59a74aed7c06d25e9da071d527c86d829f9a: Bug 1548118 Part 3 - Remove margin-bottom from column-balancing-nested-001.html and its reference. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Wed, 08 May 2019 03:12:18 +0000 - rev 534882
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1548118 Part 3 - Remove margin-bottom from column-balancing-nested-001.html and its reference. r=dbaron Per bug 1487927, margin-bottom value is not always rendered as expected with our column balancing algorithm. I'd like to remove it from column-balancing-nested-001.html, and add <br> to separate each cases. Differential Revision: https://phabricator.services.mozilla.com/D30287
152fb420ffc57e19cd0015c5ca57421c535d1268: Bug 1548118 Part 2 - Extract computing column balancing depth logic to a function. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Wed, 08 May 2019 03:12:05 +0000 - rev 534881
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1548118 Part 2 - Extract computing column balancing depth logic to a function. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D29434
3db2c18f995048c3c7f2dc494ce7e582e9f374c1: Bug 1548118 Part 1 - Advance the column count at the end of the while loop. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Wed, 08 May 2019 03:09:19 +0000 - rev 534880
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1548118 Part 1 - Advance the column count at the end of the while loop. r=dbaron We use `columnCount == aConfig.mBalanceColCount - 1` in other places to determine if we are at the last column. Advancing the column count at the end of the loop make the condition consistent. Differential Revision: https://phabricator.services.mozilla.com/D29433
516cc2c504f5650083dddd563fa27c6a9cec615a: Bug 1548118 Part 3 - Always mark inner ColumnSetWrapper's children dirty before reflowing it if the outer ColumnSetWrapper is balancing. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Mon, 06 May 2019 23:09:35 +0000 - rev 534686
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1548118 Part 3 - Always mark inner ColumnSetWrapper's children dirty before reflowing it if the outer ColumnSetWrapper is balancing. r=dbaron ColumnSetFrame always tries to reflow column content regardless of it's dirtiness. Making ColumnSetWrapperFrame's children dirty can have the same effect. Differential Revision: https://phabricator.services.mozilla.com/D29435
40a074be8bf08c2f8e3ca3da13ccad5328bac624: Bug 1548118 Part 2 - Extract computing column balancing depth logic to a function. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Fri, 03 May 2019 19:25:57 +0000 - rev 534685
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1548118 Part 2 - Extract computing column balancing depth logic to a function. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D29434
f3821529e27617e69d4d4c2547c275a03f6a731a: Bug 1548118 Part 1 - Advance the column count at the end of the while loop. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Fri, 03 May 2019 19:24:03 +0000 - rev 534684
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1548118 Part 1 - Advance the column count at the end of the while loop. r=dbaron We use `columnCount == aConfig.mBalanceColCount - 1` in other places to determine if we are at the last column. Advancing the column count at the end of the loop make the condition consistent. Differential Revision: https://phabricator.services.mozilla.com/D29433
acac503a73616055e6c27786640ad8dd81a5cd96: Bug 1547852: Only enable dynamic reflow roots up through early beta. r=dbaron
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 29 Apr 2019 23:10:55 +0000 - rev 533719
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1547852: Only enable dynamic reflow roots up through early beta. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D29288
4442722c78cd11e811a6830ea5a2da48507e8f40: Bug 1547606 - Mark multicol-span-all-margin-bottom-001.xht fail for Android x86 non-e10s. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Mon, 29 Apr 2019 18:43:08 +0000 - rev 533691
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1547606 - Mark multicol-span-all-margin-bottom-001.xht fail for Android x86 non-e10s. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D29234
09a1e16dfaf1ec52411572132ec73ba444f2288d: Bug 1547086 Part 2 - Enable column-span preference to fix existing test failures. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Sat, 27 Apr 2019 22:03:54 +0000 - rev 533554
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1547086 Part 2 - Enable column-span preference to fix existing test failures. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D28893
145b3692b5935a43e3789c448b521f06e778f1c1: Bug 1547086 Part 1 - Improve import-test.py, and regenerate received/reftest.list. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Sat, 27 Apr 2019 22:03:54 +0000 - rev 533553
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1547086 Part 1 - Improve import-test.py, and regenerate received/reftest.list. r=dbaron import.log and reftest.list are generated automatically. I run import-test.py on Linux, and the filenames in import.log are not sorted properly, so I make them sort case-insensitively to reproduce the exact same order in import.log. Differential Revision: https://phabricator.services.mozilla.com/D29064
c4f25a740b967189ab6b42c9434c984ab143dd8d: Bug 1411422 - Make percentage block size children work without "height:100%" in ::-moz-column-set and ::-moz-column-content. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Fri, 19 Apr 2019 22:02:45 +0000 - rev 532158
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1411422 - Make percentage block size children work without "height:100%" in ::-moz-column-set and ::-moz-column-content. r=dbaron After introducing column-span, the ColumnSetWrapperFrame can have more than one ColumnSetFrame children if there's any column-span:all child. Thus we cannot use "height:100%" to pass block size information down to the -moz-column-content's children. Skip column span wrapper in nsIFrame::IsBlockWrapper() so that the percentage column-span:all works. Before this patch, the height of column contents are set to 100% of the multicol container, so if the previous in-flows of column content anonymous boxes consume all the height, later in-flows's height are all 0. In this patch, we don't restrict column-content's height, so their height are calculated based on their children's height. column-contain-1a.html passes because it can now correctly calculate the union of all the column content's rect to find the correct sticky positioning. Differential Revision: https://phabricator.services.mozilla.com/D27627
331387fa113c0e34e5405a558161f7f0512a9973: Bug 1544285 - tools/ automated ESLint no-throw-literal fixes. r=dbaron
Ian Moody <moz-ian@perix.co.uk> - Tue, 16 Apr 2019 15:02:05 +0000 - rev 531696
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1544285 - tools/ automated ESLint no-throw-literal fixes. r=dbaron Result of running: $ mach eslint -funix tools/ | sed -Ee 's/:.+//' - | xargs sed -E \ -e 's/throw ((["`])[^"]+\2);/throw new Error(\1);/g' \ -e 's/throw ((["`])[^"]+\2 \+ [^ ";]+);/throw new Error(\1);/g' \ -e 's/throw \(/throw new Error(/g' -i Differential Revision: https://phabricator.services.mozilla.com/D27450
a77e9a735527f210aaa6e99d995b13512dbb533e: Bug 1118168 - Always call GetColFrame on the nsTableFrame's first-in-flow. r=dbaron
Mats Palmgren <mats@mozilla.com> - Tue, 09 Apr 2019 18:16:23 +0200 - rev 530519
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1118168 - Always call GetColFrame on the nsTableFrame's first-in-flow. r=dbaron
989c26cee55799444632810744affc2f8228252b: Bug 1489295 Part 4 - Remove InitAndWrapInColumnSetFrameIfNeeded(). r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Fri, 22 Mar 2019 02:47:32 +0000 - rev 527622
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1489295 Part 4 - Remove InitAndWrapInColumnSetFrameIfNeeded(). r=dbaron The last consumer of the method is removed in Part 3. Depends on D24396 Differential Revision: https://phabricator.services.mozilla.com/D24470
804b15f4d2299995b7c212ddc50c54ac8bd1f58f: Bug 1489295 Part 3 - Implement column-span:all for <button>. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Fri, 22 Mar 2019 02:50:34 +0000 - rev 527621
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1489295 Part 3 - Implement column-span:all for <button>. r=dbaron We need to pull outerFrame one level up to the outer scope because it's needed when calling FinishBuildingColumns(). The patch is very similar to implementing column-span:all for <fieldset> in bug 1535200. Differential Revision: https://phabricator.services.mozilla.com/D24396
d53a78255fdb06dc17d7944b9ae6cf05aeeb8c38: Bug 1489295 Part 2 - Clean up the naming of a 'nsStyleContext' variable in ConstructFrameFromItemInternal(). r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Thu, 21 Mar 2019 18:27:39 +0000 - rev 527620
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1489295 Part 2 - Clean up the naming of a 'nsStyleContext' variable in ConstructFrameFromItemInternal(). r=dbaron Rename outerSC to outerStyle because nsStyleContext was gone. Depends on D24394 Differential Revision: https://phabricator.services.mozilla.com/D24395
c6d13b9a5c5c2e2028cc1307fba9e6a5f1ae9b9f: Bug 1489295 Part 1 - Rename frame construction data bit that creates flex/grid/column. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Fri, 22 Mar 2019 02:39:16 +0000 - rev 527619
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1489295 Part 1 - Rename frame construction data bit that creates flex/grid/column. r=dbaron After supporting column-span, the top-level container for multicol layout is no longer the ColumnSetFrame, so remove the "SET" suffix from FCDATA_ALLOW_GRID_FLEX_COLUMNSET bit to make it sound more general. Also, update the document and add an assertion. Differential Revision: https://phabricator.services.mozilla.com/D24394